@medicus.ai/medicus-report-pdf-generator 1.3.9 → 1.3.10

package/lib/wellbeing_report_generator.js

@@ -1,5 +1,6 @@
 "use strict";
 const fs = require("fs");
+const crypto = require("crypto");
 const { promisify } = require('util');
 const { JSDOM } = require("jsdom");
 const path = require("path");
@@ -1001,8 +1002,12 @@ let generateHTMLWellbeingReport = async (data, isDebugging, clientName, language
     // Setup
     debug = isDebugging;
     const client = clientName || 'default';
-    OUT_FILE = path.resolve(__dirname + `/../output/${client}-pdf-` + Date.now() + '.html');
-    Pdf_file = `/output/${client}-pdf-` + Date.now() + '.html';
+    // Per-call unique paths so concurrent callers never share a file on disk.
+    // The puppeteer `goto(file:///…)` step is what previously read another
+    // user's HTML when two requests overlapped, producing a swapped PDF body.
+    const callId = crypto.randomUUID();
+    const callOutFile = path.resolve(__dirname + `/../output/${client}-pdf-${callId}.html`);
+    const callPdfFile = `/output/${client}-pdf-${callId}.html`;
 
     // Language configuration
     language = empty(language) ? 'en' : language;
@@ -1113,11 +1118,12 @@ let generateHTMLWellbeingReport = async (data, isDebugging, clientName, language
     }
 
     // Write file
-    await promisify(fs.writeFile)(OUT_FILE, finalHtml);
+    await promisify(fs.writeFile)(callOutFile, finalHtml);
 
     return {
         html: finalHtml,
-        outputFile: OUT_FILE,
+        outputFile: callOutFile,
+        pdfFile: callPdfFile,
         header: renderedHeader,
         footer: footerHtml,
         historyData
@@ -1138,8 +1144,12 @@ let generateHTMLWellbeingReportWithSmartReport = async (data, isDebugging, clien
     // Setup
     debug = isDebugging;
     const client = clientName || 'default';
-    OUT_FILE = path.resolve(__dirname + `/../output/${client}-pdf-` + Date.now() + '.html');
-    Pdf_file = `/output/${client}-pdf-` + Date.now() + '.html';
+    // Per-call unique paths so concurrent callers never share a file on disk.
+    // The puppeteer `goto(file:///…)` step is what previously read another
+    // user's HTML when two requests overlapped, producing a swapped PDF body.
+    const callId = crypto.randomUUID();
+    const callOutFile = path.resolve(__dirname + `/../output/${client}-pdf-${callId}.html`);
+    const callPdfFile = `/output/${client}-pdf-${callId}.html`;
 
     // Extract data
     const wellbeingData = data.wellbeing || {};
@@ -1485,11 +1495,12 @@ let generateHTMLWellbeingReportWithSmartReport = async (data, isDebugging, clien
     }
 
     // Write file
-    await promisify(fs.writeFile)(OUT_FILE, finalHtml);
+    await promisify(fs.writeFile)(callOutFile, finalHtml);
 
     return {
         html: finalHtml,
-        outputFile: OUT_FILE,
+        outputFile: callOutFile,
+        pdfFile: callPdfFile,
         header: renderedHeader,
         footer: templates.footer,
         historyData,
@@ -1545,15 +1556,16 @@ const setupPageContent = async (page, contentHtml, filePath) => {
 let generatePDFWellbeingReport = async (data) => {
     try {
         const contentHtml = data.html;
-        OUT_FILE = data.outputFile;
 
         // Launch browser and setup page
         const browser = await launchBrowser();
         const page = await browser.newPage();
         debugLog("page launched!");
 
-        // Setup content
-        await setupPageContent(page, contentHtml, Pdf_file);
+        // Use the per-call relative path produced by generateHTMLWellbeingReport.
+        // Reading module-level state here was the root cause of cross-user PDF
+        // body swapping under concurrent requests.
+        await setupPageContent(page, contentHtml, data.pdfFile);
         debugLog("page opened!");
 
         // Generate PDF
@@ -1789,15 +1801,17 @@ const setupExtendedPageContent = async (page, contentHtml, filePath) => {
 const generatePDFReport = async (data, hideWellbeingUI = false) => {
     try {
         const contentHtml = data.html;
-        const OUT_FILE = data.outputFile;
         const footerTemplate = getPdfFooterTemplate(data.client, data.selectedLabs, data.footer);
 
         // Launch browser and setup page
         const browser = await launchExtendedBrowser();
         const page = await browser.newPage();
 
-        // Setup content
-        await setupExtendedPageContent(page, contentHtml, Pdf_file);
+        // Use the per-call relative path produced by
+        // generateHTMLWellbeingReportWithSmartReport. Reading module-level
+        // state here was the root cause of cross-user PDF body swapping
+        // under concurrent requests.
+        await setupExtendedPageContent(page, contentHtml, data.pdfFile);
 
         // Generate PDF with header and footer (PHA needs larger bottom margin to prevent content overlapping footer)
         const bottomMargin = (data.client || '').toLowerCase() === 'pha' ? '60px' : '50px';

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@medicus.ai/medicus-report-pdf-generator",
-  "version": "1.3.09",
+  "version": "1.3.10",
   "description": "Nasco corporate report - latest update in 12/10/2023 - Fix HRC for bionext",
   "main": "index.js",
   "scripts": {