@medicine-wheel/app 0.5.8 → 0.5.9

package/app/api/nodes/route.ts

@@ -16,25 +16,93 @@ const NodeCreateSchema = z.object({
   metadata: z.record(z.unknown()).optional(),
 });
 
+/**
+ * The query params `GET /api/nodes` understands. Anything else is a 400.
+ *
+ * Node `type` is a closed enum of six and cannot grow, so every artifact kind
+ * the ecosystem has invented — `chronicle_episode`, `structured_plan`,
+ * `service`, `stc_chart`, `product_goal` — got in through `metadata.kind`
+ * instead, and containment got in through `metadata.parent_id` (31 nodes point
+ * at `chronicle:miadi-chronicle` that way). Both were reachable only by
+ * fetching the whole graph and filtering client-side; forgewright's
+ * `chronicle/client.ts` and this repo's own `HttpStore.searchNodes` each do
+ * exactly that, the latter under the comment "Server has no search endpoint
+ * yet". So the wheel needed no schema change — it needed a way to ask.
+ *
+ * Query params rather than a scoped `/api/nodes/:id/children` route because the
+ * question consumers actually have is "artifacts of kind X belonging to episode
+ * Y", which is `kind` AND `parent_id` together; a scoped route would still need
+ * `?kind=` bolted onto it, and `type`/`direction` already set the query-param
+ * precedent on this same route.
+ */
+const NODE_FILTER_PARAMS = ["type", "direction", "kind", "parent_id"] as const;
+
+/**
+ * A silently-ignored filter is the failure this route exists to prevent: a
+ * consumer that asks `?kinds=service` and gets a filtered-looking payload it
+ * never filtered has been lied to. An unknown param is therefore a 400 naming
+ * what is accepted, not a shrug.
+ */
+function rejectUnknownParams(searchParams: URLSearchParams) {
+  const unknown = [...new Set(searchParams.keys())].filter(
+    (key) => !(NODE_FILTER_PARAMS as readonly string[]).includes(key),
+  );
+  if (unknown.length === 0) return null;
+
+  return NextResponse.json(
+    {
+      error: `Unknown query parameter${unknown.length > 1 ? "s" : ""}: ${unknown.join(", ")} — nothing was filtered.`,
+      accepted: [...NODE_FILTER_PARAMS],
+    },
+    { status: 400 },
+  );
+}
+
 export async function GET(request: Request) {
   try {
     const { searchParams } = new URL(request.url);
-    const type = searchParams.get("type");
-    const direction = searchParams.get("direction");
+
+    const rejection = rejectUnknownParams(searchParams);
+    if (rejection) return rejection;
+
+    // An empty value means "no filter" — forms submit "" for an unchosen
+    // option, the same reason POST preprocesses "" on `direction`.
+    const filters = Object.fromEntries(
+      NODE_FILTER_PARAMS.map((key) => [key, searchParams.get(key) || undefined]),
+    ) as Partial<Record<(typeof NODE_FILTER_PARAMS)[number], string>>;
+    const filtering = Object.values(filters).some(Boolean);
 
     const store = await createProvider();
-    let nodes = await store.getAllNodes();
 
-    if (type) {
-      nodes = nodes.filter((n) => n.type === type);
-    } else if (direction) {
-      nodes = nodes.filter((n) => n.direction === direction);
+    // Unfiltered reads keep the provider's own default page size, so this route
+    // answers a bare GET exactly as it always has. A *filtered* read must see
+    // the whole store or it answers from a truncated window — `getAllNodes()`
+    // defaults to 100 and the live wheel already holds 76, so filtering after
+    // the default slice would start returning quietly incomplete sets rather
+    // than failing loudly.
+    let nodes = filtering
+      ? await store.getAllNodes(Number.MAX_SAFE_INTEGER)
+      : await store.getAllNodes();
+
+    // Every supplied filter narrows (AND). Previously `type` and `direction`
+    // were `else if`, so `?type=x&direction=y` silently dropped the direction —
+    // the same silent-ignore defect the 400 above closes. Single-param requests
+    // are unaffected.
+    if (filters.type) nodes = nodes.filter((n) => n.type === filters.type);
+    if (filters.direction) nodes = nodes.filter((n) => n.direction === filters.direction);
+    if (filters.kind) nodes = nodes.filter((n) => n.metadata?.kind === filters.kind);
+    if (filters.parent_id) {
+      nodes = nodes.filter((n) => n.metadata?.parent_id === filters.parent_id);
     }
 
     return NextResponse.json({
       nodes,
       provider: detectProvider(),
-      count: nodes.length
+      count: nodes.length,
+      // Echoed only when asked for, so an unfiltered response stays byte-identical
+      // to what every existing consumer already parses — and so a caller can tell
+      // an empty result from an unapplied filter.
+      ...(filtering ? { filters } : {}),
     });
   } catch (error: unknown) {
     const message = error instanceof Error ? error.message : String(error);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@medicine-wheel/app",
-  "version": "0.5.8",
+  "version": "0.5.9",
   "description": "Medicine Wheel — Interactive visual layer for Indigenous relational research with Four Directions, ceremonies, and narrative arcs",
   "bin": {
     "mw": "dist/cli/mw.js",
@@ -85,29 +85,29 @@
     "release:major": "npm run version:major && npm run publish:all && npm run release:commit"
   },
   "dependencies": {
-    "@medicine-wheel/ceremonial-diary": "^0.5.8",
-    "@medicine-wheel/ceremony-protocol": "^0.5.8",
-    "@medicine-wheel/community-review": "^0.5.8",
-    "@medicine-wheel/consent-lifecycle": "^0.5.8",
-    "@medicine-wheel/creative-orientation": "^0.5.8",
-    "@medicine-wheel/data-store": "^0.5.8",
-    "@medicine-wheel/data-store-postgres": "^0.5.8",
-    "@medicine-wheel/fire-keeper": "^0.5.8",
-    "@medicine-wheel/github-ceremony": "^0.5.8",
-    "@medicine-wheel/graph-viz": "^0.5.8",
-    "@medicine-wheel/importance-unit": "^0.5.8",
-    "@medicine-wheel/mcp": "^4.5.8",
-    "@medicine-wheel/narrative-cluster": "^0.5.8",
-    "@medicine-wheel/narrative-engine": "^0.5.8",
-    "@medicine-wheel/ontology-core": "^0.5.8",
-    "@medicine-wheel/perception-layer": "^0.5.8",
-    "@medicine-wheel/prompt-decomposition": "^0.5.8",
-    "@medicine-wheel/relational-index": "^0.5.8",
-    "@medicine-wheel/relational-query": "^0.5.8",
-    "@medicine-wheel/session-reader": "^0.5.8",
-    "@medicine-wheel/storage-provider": "^0.5.8",
-    "@medicine-wheel/transformation-tracker": "^0.5.8",
-    "@medicine-wheel/ui-components": "^0.5.8",
+    "@medicine-wheel/ceremonial-diary": "^0.5.9",
+    "@medicine-wheel/ceremony-protocol": "^0.5.9",
+    "@medicine-wheel/community-review": "^0.5.9",
+    "@medicine-wheel/consent-lifecycle": "^0.5.9",
+    "@medicine-wheel/creative-orientation": "^0.5.9",
+    "@medicine-wheel/data-store": "^0.5.9",
+    "@medicine-wheel/data-store-postgres": "^0.5.9",
+    "@medicine-wheel/fire-keeper": "^0.5.9",
+    "@medicine-wheel/github-ceremony": "^0.5.9",
+    "@medicine-wheel/graph-viz": "^0.5.9",
+    "@medicine-wheel/importance-unit": "^0.5.9",
+    "@medicine-wheel/mcp": "^4.5.9",
+    "@medicine-wheel/narrative-cluster": "^0.5.9",
+    "@medicine-wheel/narrative-engine": "^0.5.9",
+    "@medicine-wheel/ontology-core": "^0.5.9",
+    "@medicine-wheel/perception-layer": "^0.5.9",
+    "@medicine-wheel/prompt-decomposition": "^0.5.9",
+    "@medicine-wheel/relational-index": "^0.5.9",
+    "@medicine-wheel/relational-query": "^0.5.9",
+    "@medicine-wheel/session-reader": "^0.5.9",
+    "@medicine-wheel/storage-provider": "^0.5.9",
+    "@medicine-wheel/transformation-tracker": "^0.5.9",
+    "@medicine-wheel/ui-components": "^0.5.9",
     "@neondatabase/serverless": "^0.10.0",
     "@xyflow/react": "^12.3.0",
     "clsx": "^2.1.1",