@mediadatafusion/pi-workflow-suite 0.0.11 → 0.0.12

package/extensions/workflow-settings-capabilities.ts

@@ -240,6 +240,16 @@ const STANDARD_MISSION_CONTEXT_CAPABILITIES: CapabilityFactory[] = [
     risk: "Can look fully enforced when current design keeps recovery supervised.",
     action: "Preserve; label as planned/partial until user-supervised recovery actions are implemented.",
   }),
+  () => capability({
+    path: "missions.missionHistoryLimit",
+    domain: "missions",
+    intent: "Limit retained saved Mission history records.",
+    owner: "saveMissionState / clearOldMissionStates / Mission History settings menu",
+    status: "wired",
+    related: ["workflow.planHistoryLimit"],
+    risk: "If misfiled under runtime settings, users may confuse saved history retention with Mission execution timers.",
+    action: "Keep surfaced under Mission History, parallel to Plan History.",
+  }),
   () => capability({
     path: "context.compactionMode",
     domain: "context",

package/extensions/workflow-state.ts

@@ -36,6 +36,13 @@ export interface WorkflowTypedHandoff {
   payload: Record<string, unknown>;
 }
 
+export interface WorkflowReviewHandoffSuppression {
+  kind: "plan_typed_initial_to_approval" | "plan_typed_review_to_execution" | "mission_typed_review_to_approval";
+  createdAt: string;
+  activePlanId?: string;
+  activeMissionId?: string;
+}
+
 export interface WorkflowRepairHistoryEntry {
   timestamp: string;
   retry: number;
@@ -91,7 +98,7 @@ export interface StandardRuntimeState {
   runtimeCounter: "running" | "paused" | "stopped";
 }
 
-export type PlanLifecycleStatus = "planning" | "awaiting_clarification" | "plan_ready" | "approved" | "reviewing" | "executing" | "validating" | "repairing" | "revalidating" | "completed" | "blocked";
+export type PlanLifecycleStatus = "planning" | "awaiting_clarification" | "plan_ready" | "approved" | "reviewing" | "reviewed" | "executing" | "validating" | "repairing" | "revalidating" | "completed" | "blocked";
 export type PlanStepStatus = "pending" | "active" | "completed" | "failed" | "blocked" | "skipped";
 export type PlanValidationStatus = "pending" | "running" | "pass" | "partial pass" | "fail" | "unknown";
 
@@ -180,6 +187,21 @@ export interface BlockedPlanResumeSnapshot {
   workflowValidationRetryCount?: number;
   planRuntime?: PlanRuntimeState;
   planProgress?: PlanProgressState;
+  reviewerReport?: string;
+  reviewerVerdict?: "PASS" | "NOTES" | "NEEDS REPAIR" | "FAIL" | "BLOCKED" | "UNKNOWN";
+  reviewHistory?: WorkflowReviewHistoryEntry[];
+  currentReviewRetry?: number;
+  workflowReviewRetryCount?: number;
+  lastReviewFailure?: string;
+  lastReviewAttempt?: string;
+  lastReviewRepairStatus?: "none" | "running" | "completed" | "failed" | "blocked";
+  reviewRepairInProgress?: boolean;
+  repairRetryState?: Partial<Record<RepairRetryGateName, RepairRetryGateState>>;
+  concreteRepairableIssue?: boolean;
+  manualVerificationRequired?: boolean;
+  evidenceGap?: boolean;
+  planTokensUsed?: number;
+  modelsUsed?: { planner?: string; executor?: string; validator?: string; reviewer?: string };
 }
 
 export interface WorkflowFinalStopSummary {
@@ -219,6 +241,7 @@ export interface WorkflowState {
   clarifyingQuestions?: ClarificationQuestion[];
   clarifyingAnswers?: ClarificationAnswer[];
   lastWorkflowHandoff?: WorkflowTypedHandoff;
+  reviewHandoffSuppression?: WorkflowReviewHandoffSuppression;
   clarificationAlreadyAsked?: boolean;
   clarificationRequiredBeforePlan?: boolean;
   clarificationRequirementReason?: string;
@@ -246,6 +269,9 @@ export interface WorkflowState {
   executionSummary?: string;
   validationReport?: string;
   validationVerdict?: "PASS" | "PARTIAL PASS" | "FAIL" | "UNKNOWN";
+  currentValidationHandoffRetry?: number;
+  maxValidationHandoffRetries?: number;
+  lastValidationHandoffFailure?: string;
   currentValidationRetry?: number;
   workflowValidationRetryCount?: number;
   maxValidationRetriesPerPlan?: number;
@@ -261,6 +287,7 @@ export interface WorkflowState {
   planStepValidationIndex?: number;
   planExecutionStepIndex?: number;
   planRuntime?: PlanRuntimeState;
+  planRuntimeHoldActive?: boolean;
   planProgress?: PlanProgressState;
   planProgressLastToolStep?: number;
   planProgressLastToolStatus?: PlanStepStatus;
@@ -348,6 +375,10 @@ export interface PlanSavingOptions {
   planHistoryLimit?: number;
 }
 
+export interface MissionSavingOptions {
+  missionHistoryLimit?: number;
+}
+
 export type MissionStatus = "draft" | "planning" | "awaiting_clarification" | "planned" | "approved" | "running" | "paused" | "checkpointing" | "validating" | "repairing" | "revalidating" | "completed" | "failed" | "blocked" | "stopped";
 export type MissionAutonomy = "manual" | "approval_gated" | "supervised_auto" | "full_auto";
 export type MissionMilestoneStatus = "pending" | "active" | "completed" | "failed" | "skipped";
@@ -439,6 +470,7 @@ export interface MissionState {
   heartbeatCount?: number;
   activeRuntimeMs?: number;
   activeRunStartedAt?: string | null;
+  runtimeHoldActive?: boolean;
   lastPausedAt?: string;
   lastResumedAt?: string;
   lastStoppedAt?: string;
@@ -469,10 +501,13 @@ export function emptyState(): WorkflowState {
   return { version: 1, mode: "idle", updatedAt: new Date().toISOString() };
 }
 
+const VALID_MODES = new Set<string>(["idle", "standard", "awaiting_plan_input", "awaiting_mission_input", "awaiting_clarification", "planning", "plan_draft", "plan_approved", "reviewing", "reviewed", "executing", "executed", "validating", "validated", "repairing", "revalidating", "mission_draft", "mission_awaiting_clarification", "mission_planning", "mission_plan_ready", "mission_approved", "mission_running", "mission_paused", "mission_checkpointing", "mission_validating", "mission_repairing", "mission_revalidating", "mission_final_validating", "mission_completed", "mission_failed", "mission_blocked", "mission_stopped", "cancelled"]);
+
 export function loadState(): WorkflowState {
   try {
     if (!existsSync(ACTIVE_STATE_FILE)) return emptyState();
     const parsed = JSON.parse(readFileSync(ACTIVE_STATE_FILE, "utf8")) as WorkflowState;
+    if (parsed.mode && !VALID_MODES.has(parsed.mode)) return emptyState();
     return { ...emptyState(), ...parsed, version: 1 };
   } catch {
     return emptyState();
@@ -710,6 +745,15 @@ export function isMissionRuntimeActiveStatus(status?: MissionStatus): boolean {
   return status === "planning" || status === "running" || status === "validating" || status === "repairing" || status === "revalidating" || status === "checkpointing";
 }
 
+export function isMissionRuntimeActive(mission?: MissionState): boolean {
+  if (!mission || mission.status === "completed" || mission.status === "failed" || mission.status === "stopped") return false;
+  return isMissionRuntimeActiveStatus(mission.status) || mission.runtimeHoldActive === true;
+}
+
+export function isMissionRuntimeHeldActive(mission?: MissionState): boolean {
+  return Boolean(mission && !isMissionRuntimeActiveStatus(mission.status) && mission.runtimeHoldActive === true);
+}
+
 function runtimeEndReason(status: MissionStatus): MissionRuntimeSegment["reasonEnded"] {
   if (status === "paused") return "paused";
   if (status === "blocked") return "blocked";
@@ -737,9 +781,18 @@ export function isPlanRuntimeActiveMode(mode?: WorkflowMode): boolean {
   return mode === "planning" || mode === "reviewing" || mode === "executing" || mode === "validating" || mode === "repairing" || mode === "revalidating";
 }
 
+export function isPlanRuntimeActive(state?: WorkflowState): boolean {
+  if (!state || state.mode === "idle" || state.mode === "cancelled") return false;
+  return isPlanRuntimeActiveMode(state.mode) || state.planRuntimeHoldActive === true;
+}
+
+export function isPlanRuntimeHeldActive(state?: WorkflowState): boolean {
+  return Boolean(state && !isPlanRuntimeActiveMode(state.mode) && state.planRuntimeHoldActive === true);
+}
+
 export function planRuntimeCounterState(state: WorkflowState): "running" | "paused" | "stopped" {
   if (state.mode === "idle" || state.mode === "cancelled") return "stopped";
-  if (isPlanRuntimeActiveMode(state.mode)) return "running";
+  if (isPlanRuntimeActive(state)) return "running";
   return "paused";
 }
 
@@ -784,8 +837,8 @@ export function applyPlanRuntimeAccounting(previous: WorkflowState | undefined,
   const createdAt = currentRuntime?.createdAt ?? previousRuntime?.createdAt ?? nowIso;
   const baseRuntimeMs = safeRuntimeMs(currentRuntime?.activeRuntimeMs ?? previousRuntime?.activeRuntimeMs);
   const previousStartedAt = previousRuntime?.activeRunStartedAt ?? currentRuntime?.activeRunStartedAt ?? null;
-  const previousActive = isPlanRuntimeActiveMode(previous?.mode);
-  const nextActive = isPlanRuntimeActiveMode(state.mode);
+  const previousActive = isPlanRuntimeActive(previous);
+  const nextActive = isPlanRuntimeActive(state);
 
   let activeRuntimeMs = baseRuntimeMs;
   let activeRunStartedAt = currentRuntime?.activeRunStartedAt ?? previousStartedAt ?? null;
@@ -816,7 +869,7 @@ export function applyPlanRuntimeAccounting(previous: WorkflowState | undefined,
 export function planActiveRuntimeMs(state: WorkflowState, now = new Date()): number {
   const runtime = state.planRuntime;
   const base = safeRuntimeMs(runtime?.activeRuntimeMs);
-  if (!runtime || !isPlanRuntimeActiveMode(state.mode)) return base;
+  if (!runtime || !isPlanRuntimeActive(state)) return base;
   return base + activeElapsedMs(runtime.activeRunStartedAt, now.getTime(), state.updatedAt);
 }
 
@@ -889,8 +942,8 @@ export function standardWallClockAgeMs(state: WorkflowState, now = new Date()):
 export function applyMissionRuntimeAccounting(previous: MissionState | undefined, mission: MissionState, now = new Date()): MissionState {
   const nowIso = now.toISOString();
   const nowMs = now.getTime();
-  const previousActive = isMissionRuntimeActiveStatus(previous?.status);
-  const nextActive = isMissionRuntimeActiveStatus(mission.status);
+  const previousActive = isMissionRuntimeActive(previous);
+  const nextActive = isMissionRuntimeActive(mission);
   const previousStartedAt = previous?.activeRunStartedAt ?? mission.activeRunStartedAt ?? null;
   const baseRuntimeMs = safeRuntimeMs(mission.activeRuntimeMs ?? previous?.activeRuntimeMs);
   const baseSegments = mission.runtimeSegments ?? previous?.runtimeSegments ?? [];
@@ -929,7 +982,7 @@ export function applyMissionRuntimeAccounting(previous: MissionState | undefined
 
 export function missionActiveRuntimeMs(mission: MissionState, now = new Date()): number {
   const base = safeRuntimeMs(mission.activeRuntimeMs);
-  if (!isMissionRuntimeActiveStatus(mission.status)) return base;
+  if (!isMissionRuntimeActive(mission)) return base;
   return base + activeElapsedMs(mission.activeRunStartedAt, now.getTime(), mission.updatedAt);
 }
 
@@ -942,7 +995,7 @@ export function missionWallClockAgeMs(mission: MissionState, now = new Date()):
 }
 
 export function missionRuntimeCounterState(mission: MissionState): "running" | "paused" | "blocked" | "stopped" | "completed" | "failed" | "waiting" {
-  if (isMissionRuntimeActiveStatus(mission.status)) return "running";
+  if (isMissionRuntimeActive(mission)) return "running";
   if (mission.status === "paused") return "paused";
   if (mission.status === "blocked") return "blocked";
   if (mission.status === "stopped") return "stopped";
@@ -951,7 +1004,7 @@ export function missionRuntimeCounterState(mission: MissionState): "running" | "
   return "waiting";
 }
 
-export function saveMissionState(mission: MissionState): MissionState {
+export function saveMissionState(mission: MissionState, options: MissionSavingOptions = {}): MissionState {
   mkdirSync(MISSION_HISTORY_DIR, { recursive: true });
   const savedAt = new Date();
   const accounted = applyMissionRuntimeAccounting(readExistingMissionState(mission.id), mission, savedAt);
@@ -959,6 +1012,7 @@ export function saveMissionState(mission: MissionState): MissionState {
   const content = JSON.stringify(next, null, 2) + "\n";
   writeFileSync(join(MISSION_HISTORY_DIR, `${next.id}.json`), content, { encoding: "utf8", mode: 0o600 });
   writeFileSync(LATEST_MISSION_FILE, content, { encoding: "utf8", mode: 0o600 });
+  clearOldMissionStates(options.missionHistoryLimit ?? 50);
   return next;
 }
 
@@ -986,6 +1040,19 @@ export function listMissionStates(): MissionState[] {
   return missions.sort((a, b) => b.updatedAt.localeCompare(a.updatedAt));
 }
 
+export function clearOldMissionStates(limit = 50): number {
+  const safeLimit = Math.max(1, Math.min(500, Math.floor(limit)));
+  const missions = listMissionStates();
+  let removed = 0;
+  for (const mission of missions.slice(safeLimit)) {
+    try {
+      unlinkSync(join(MISSION_HISTORY_DIR, `${mission.id}.json`));
+      removed++;
+    } catch { /* ignore */ }
+  }
+  return removed;
+}
+
 export function addMissionCheckpoint(mission: MissionState, summary: string, nextAction: string, milestoneId?: string, details: { filesChanged?: string[]; validationResult?: string; errors?: string[] } = {}): MissionState {
   const id = `C${String((mission.checkpoints?.length ?? 0) + 1).padStart(4, "0")}`;
   const checkpoint: MissionCheckpoint = {

package/extensions/workflow-subagent-policy.ts

@@ -21,7 +21,7 @@ export interface SubagentToolProfile {
   source?: string;
 }
 
-const MUTATING_SUBAGENT_TOOLS = new Set(["edit", "write"]);
+const MUTATING_SUBAGENT_TOOLS = new Set(["edit"]);
 const ORCHESTRATOR_AGENT_NAME = "workflow-orchestrator";
 
 export function subagentToolsAllowMutation(tools?: string[]): boolean {
@@ -176,5 +176,17 @@ export function planningNeedsOrchestrator(settings: WorkflowSettings, _mode: "pl
   return orchestrationPolicy === "orchestrator_first" || orchestrationPolicy === "forced_orchestrated";
 }
 
+// ── Uniform error classification (#9) ──────────────────────────
+export type SubagentErrorClass = "transient" | "permanent" | "policy";
+
+export function classifySubagentError(result: { exitCode: number; stopReason?: string; errorMessage?: string; stderr?: string }): SubagentErrorClass {
+  const reason = (result.errorMessage ?? result.stderr ?? "").toLowerCase();
+  if (/timed out|stale watchdog|aborted/i.test(reason) || (result.stopReason === "aborted" && /time/i.test(reason))) return "transient";
+  if (/repo lock|outside current repository/i.test(reason)) return "policy";
+  if (/unknown agent|not installed|not found/i.test(reason)) return "permanent";
+  if (result.exitCode === 0) return "transient"; // success
+  return "permanent";
+}
+
 // No-op default export so this helper module can be safely auto-discovered as a Pi extension.
 export default function workflowSuiteNoopExtension(): void {}

package/extensions/workflow-summary.ts

@@ -100,15 +100,6 @@ function gitChangedFilesLine(status: string | undefined): string {
   return `${files.length} changed/untracked file(s): ${preview}${files.length > 16 ? ", ..." : ""}`;
 }
 
-function workflowSuitePublicImpact(root: string, pkg: Record<string, unknown> | undefined, status: string | undefined): string {
-  if (pkg?.name !== "@mediadatafusion/pi-workflow-suite") return "not applicable unless the target repo is the Pi Workflow Suite package";
-  const files = (status ?? "").split("\n").map((line) => line.trim().slice(3).trim()).filter(Boolean);
-  if (!files.length) return "Pi Workflow Suite package repo detected; no current git changes detected";
-  const publicPrefixes = ["extensions/", "agents/", "skills/", "config/", "docs/", "scripts/", "README.md", "LICENSE.md", "package.json", "package-lock.json", "tsconfig.json", "AGENTS.md"];
-  const publicFiles = files.filter((file) => publicPrefixes.some((prefix) => file === prefix || file.startsWith(prefix)));
-  return publicFiles.length ? `yes — public/live package files touched: ${publicFiles.slice(0, 12).join(", ")}${publicFiles.length > 12 ? ", ..." : ""}` : "Pi Workflow Suite package repo detected; changed files are not in public package paths";
-}
-
 export function renderHandoffProjectContext(cwd?: string): string {
   const current = cwd ?? process.cwd();
   const repoRoot = safeGit(current, ["rev-parse", "--show-toplevel"]);
@@ -118,7 +109,6 @@ export function renderHandoffProjectContext(cwd?: string): string {
   const head = safeGit(root, ["rev-parse", "--short", "HEAD"]);
   const status = safeGit(root, ["status", "--short"]);
   const instructions = detectedInstructionFiles(root);
-  const isSuite = pkg?.name === "@mediadatafusion/pi-workflow-suite";
   return `## Target Application Context
 - CWD: ${current}
 - Git root: ${repoRoot ?? "not detected"}
@@ -126,14 +116,7 @@ export function renderHandoffProjectContext(cwd?: string): string {
 - HEAD: ${head ?? "unknown"}
 - Application profile: ${detectProjectProfile(root, pkg)}
 - Project instructions detected: ${instructions.length ? instructions.join(", ") : "none"}
-- Changed files: ${gitChangedFilesLine(status)}
-
-## Pi Workflow Suite Context
-- Target is Pi Workflow Suite package repo: ${isSuite ? "yes" : "no"}
-- Context boundary: keep the target application repo, the Workflow Suite DEV worktree, the live Pi runtime, and the public main package mirror distinct.
-- Public package impact: ${workflowSuitePublicImpact(root, pkg, status)}
-- Live runtime sync: only confirmed when scripts/install-to-live.sh has been run and reports auth/settings/sessions/workflow state were not touched.
-- Promotion expectation for suite package changes: validate on DEV, sync live when requested, promote the same public-safe files to main, validate main, push both branches, then verify origin/main..origin/DEV parity.`;
+- Changed files: ${gitChangedFilesLine(status)}`;
 }
 
 function planNeedsClarification(text?: string): boolean {
@@ -145,11 +128,17 @@ function planNeedsClarification(text?: string): boolean {
 }
 
 function planStatus(state: WorkflowState): string {
+  if (state.planProgress?.lifecycleStatus === "blocked") return "Blocked";
+  if (planReviewRepairActive(state)) return "Repairing";
   if (state.approvedPlan) return "Approved";
   if (state.draftPlan) return "Draft";
   return "None";
 }
 
+function planReviewRepairActive(state: WorkflowState): boolean {
+  return state.reviewRepairInProgress === true || state.lastReviewRepairStatus === "running" || state.repairRetryState?.review?.inProgress === true;
+}
+
 function isMissionMode(mode: string): boolean {
   return mode === "awaiting_mission_input" || mode.startsWith("mission_");
 }
@@ -374,7 +363,7 @@ export function renderWorkflowSummary(state: WorkflowState, cwd?: string): strin
   if (finalStop && (state.mode === "awaiting_plan_input" || state.mode === "awaiting_mission_input" || state.mode === "validated" || state.mode === "mission_blocked" || state.mode === "mission_completed" || state.mode === "mission_failed" || state.mode === "mission_stopped")) {
     return `# Workflow Summary\n\n${finalStop}`;
   }
-  return `# Workflow Summary\n\n${renderHandoffProjectContext(cwd)}\n\n## Original Task\n${state.task ?? "(none)"}\n\n## Models Used\n- Planner: ${state.modelsUsed?.planner ?? "(not recorded)"}\n- Executor: ${state.modelsUsed?.executor ?? "(not recorded)"}\n- Validator: ${state.modelsUsed?.validator ?? "(not run)"}\n- Reviewer: ${state.modelsUsed?.reviewer ?? "(not run)"}\n\n## Current Model Configuration\n${renderWorkflowModels(settings)}\n\n## Approved Plan\n${compact(state.approvedPlan, 2200)}\n\n## Execution Summary\n${compact(state.executionSummary, 1800)}\n\n## Validation Result\n${state.validationVerdict ?? "(not validated)"}\n\n${compact(state.validationReport, 1800)}\n\n## Remaining Risks\nReview validation notes, unrun tests, changed files, and public/internal package impact before committing or promoting.\n\n## Recommended Next Action\nRun project checks manually if they were not run, then review the target repo diff. For Pi Workflow Suite package work, complete DEV validation, live sync if requested, main promotion, main validation, and branch parity verification.\n\n## Exact Resume Instructions\n- Re-open the target repo shown above and confirm branch/status.\n- Run /workflow status before continuing.\n- Review this summary alongside the saved plan record when available.\n- Re-read detected project instruction files before any new edits.\n\n## Suggested Commit Message\nImplement approved workflow plan`;
+  return `# Workflow Summary\n\n${renderHandoffProjectContext(cwd)}\n\n## Original Task\n${state.task ?? "(none)"}\n\n## Models Used\n- Planner: ${state.modelsUsed?.planner ?? "(not recorded)"}\n- Executor: ${state.modelsUsed?.executor ?? "(not recorded)"}\n- Validator: ${state.modelsUsed?.validator ?? "(not run)"}\n- Reviewer: ${state.modelsUsed?.reviewer ?? "(not run)"}\n\n## Current Model Configuration\n${renderWorkflowModels(settings)}\n\n## Approved Plan\n${compact(state.approvedPlan, 2200)}\n\n## Execution Summary\n${compact(state.executionSummary, 1800)}\n\n## Validation Result\n${state.validationVerdict ?? "(not validated)"}\n\n${compact(state.validationReport, 1800)}\n\n## Remaining Risks\nReview validation notes, unrun tests, and changed files before committing or promoting.\n\n## Recommended Next Action\nRun project checks manually if they were not run, then review the target repo diff.\n\n## Exact Resume Instructions\n- Re-open the target repo shown above and confirm branch/status.\n- Run /workflow status before continuing.\n- Review this summary alongside the saved plan record when available.\n- Re-read detected project instruction files before any new edits.`;
 }
 
 // No-op default export so this helper module can be safely auto-discovered as a Pi extension.