@measurequick/measurequick-report-generator 1.5.203 → 1.5.205

package/.claude/settings.local.json

@@ -20,7 +20,8 @@
       "Bash(done)",
       "Bash(cd /Users/bobby/mQ/packages/mq-hvac/src/pages/acr-modal-subpage/combustion grep -c \"margin-bottom: 0px\" acr-modal-subpage-combustion.html grep -c \"''''mQ''''\" acr-modal-subpage-combustion.html)",
       "Bash(grep:*)",
-      "Bash(git checkout:*)"
+      "Bash(git checkout:*)",
+      "mcp__ide__getDiagnostics"
     ]
   }
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@measurequick/measurequick-report-generator",
-  "version": "1.5.203",
+  "version": "1.5.205",
   "description": "Generates PDF documents for various measureQuick applications.",
   "main": "index.js",
   "scripts": {

package/report-gen-scripts/measurement-details.js

@@ -499,7 +499,8 @@ export async function getReport(payload) {
               .setText(`${displayLabel} ${units}`);
 
             // Use derated value if available for gas_input_rated
-            let val = measurement.value !== null && measurement.value !== undefined
+            // Also check for empty string - middleman passes "" when it expects lookup from test.data
+            let val = measurement.value !== null && measurement.value !== undefined && measurement.value !== ""
               ? measurement.value
               : +test.data[measurement.ref];
             if (
@@ -509,20 +510,24 @@ export async function getReport(payload) {
               val = payload.equipment.gas_input_derated;
             }
 
-            // Special handling for CO measurements - allow 0 as valid value
+            // Special handling for CO measurements - allow 0 as valid value, no decimals
             const isCOMeasurement =
               measurement.label == "Ambient CO" ||
               measurement.label == "Return CO" ||
               measurement.label == "Supply CO";
 
-            if (!val && !isCOMeasurement) val = "--";
-            else if (measurement.fixTo && typeof val == "number")
+            // For CO measurements: if value is null/undefined, show "--"; if valid, show as integer (no decimals)
+            if (isCOMeasurement) {
+              if (measurement.value === null || measurement.value === undefined) {
+                val = "--";
+              } else {
+                val = Math.round(Number(val)).toString();
+              }
+            } else if (!val) {
+              val = "--";
+            } else if (measurement.fixTo && typeof val == "number") {
               val = val.toFixed(measurement.fixTo);
-            if (
-              isCOMeasurement &&
-              (measurement.value === null || measurement.value === undefined)
-            )
-              val = "0.0";
+            }
             if (typeof val == "number" || !isNaN(val))
               val = val.toLocaleString("en-US");
             if (measurement.fixTo && typeof val == "number")

package/report-gen-scripts/vitals-cooling-report.js

@@ -320,8 +320,11 @@ export async function getReport(payload, _test) {
       let high = +t.targets[`${targetKeys[i]}_ideal_high`];
       low = mid - low;
       high = mid + high;
-      if (targetKeys[i] == "pressure_static_total_external") high = mid * 1.4;
-      else if (targetKeys[i] == "velocity_face_filter1") high = 500;
+      // For TESP, use 40%-140% of target (low = mid * 0.4, high = mid * 1.4)
+      if (targetKeys[i] == "pressure_static_total_external") {
+        low = mid * 0.4;
+        high = mid * 1.4;
+      } else if (targetKeys[i] == "velocity_face_filter1") high = 500;
       let val = t.data[targetKeys[i]];
       if (actual < low && targetKeys[i] != "velocity_face_filter1")
         iconPlacement = "Low";
@@ -332,10 +335,8 @@ export async function getReport(payload, _test) {
           .getButton(`Image${measureLabels[i]}${iconPlacement}_af_image`)
           .setImage(icon);
       let targetZone = "";
-      if (
-        targetKeys[i] == "pressure_static_total_external" ||
-        targetKeys[i] == "velocity_face_filter1"
-      )
+      // Filter face velocity only shows upper bound
+      if (targetKeys[i] == "velocity_face_filter1")
         targetZone = `(< ${high.toFixed(1)})`;
       else if (!isNaN(low) && low != "NaN" && !isNaN(high) && high != "NaN")
         targetZone = `(${low.toFixed(1)} - ${high.toFixed(1)})`;

package/report-gen-scripts/vitals-heating-report-no-combustion.js

@@ -362,8 +362,11 @@ export async function getReport(payload, _test) {
       let high = +test.testInfo.targets[`${targetKeys[i]}_ideal_high`];
       low = mid - low;
       high = mid + high;
-      if (targetKeys[i] == "pressure_static_total_external") high = mid * 1.4;
-      else if (targetKeys[i] == "velocity_face_filter1") high = 500;
+      // For TESP, use 40%-140% of target (low = mid * 0.4, high = mid * 1.4)
+      if (targetKeys[i] == "pressure_static_total_external") {
+        low = mid * 0.4;
+        high = mid * 1.4;
+      } else if (targetKeys[i] == "velocity_face_filter1") high = 500;
       let val = test.testInfo.data[targetKeys[i]];
       if (targetKeys[i] === "pressure_manifold") {
         val = test.testInfo.data["pressure_manifold_after"]
@@ -377,10 +380,8 @@ export async function getReport(payload, _test) {
       if (icon)
         safeSetImage(form, `Image${measureLabels[i]}${iconPlacement}`, icon);
       let targetZone = "";
-      if (
-        targetKeys[i] == "pressure_static_total_external" ||
-        targetKeys[i] == "velocity_face_filter1"
-      )
+      // Filter face velocity only shows upper bound
+      if (targetKeys[i] == "velocity_face_filter1")
         targetZone = `(< ${high.toFixed(1)})`;
       else if (!isNaN(low) && low != "NaN" && !isNaN(high) && high != "NaN")
         targetZone = `(${low.toFixed(1)} - ${high.toFixed(1)})`;

package/report-gen-scripts/vitals-heating-report.js

@@ -401,8 +401,11 @@ export async function getReport(payload, _test) {
       let high = +test.testInfo.targets[`${targetKeys[i]}_ideal_high`];
       low = mid - low;
       high = mid + high;
-      if (targetKeys[i] == "pressure_static_total_external") high = mid * 1.4;
-      else if (targetKeys[i] == "velocity_face_filter1") high = 500;
+      // For TESP, use 40%-140% of target (low = mid * 0.4, high = mid * 1.4)
+      if (targetKeys[i] == "pressure_static_total_external") {
+        low = mid * 0.4;
+        high = mid * 1.4;
+      } else if (targetKeys[i] == "velocity_face_filter1") high = 500;
 
       let val = test.testInfo.data[targetKeys[i]];
       if (targetKeys[i] === "pressure_manifold") {
@@ -418,10 +421,8 @@ export async function getReport(payload, _test) {
       if (icon)
         safeSetImage(form, `Image${measureLabels[i]}${iconPlacement}`, icon);
       let targetZone = "";
-      if (
-        targetKeys[i] == "pressure_static_total_external" ||
-        targetKeys[i] == "velocity_face_filter1"
-      )
+      // Filter face velocity only shows upper bound
+      if (targetKeys[i] == "velocity_face_filter1")
         targetZone = `(< ${high.toFixed(1)})`;
       else if (!isNaN(low) && low != "NaN" && !isNaN(high) && high != "NaN")
         targetZone = `(${low.toFixed(1)} - ${high.toFixed(1)})`;