@measurequick/measurequick-report-generator 1.5.199 → 1.5.200

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@measurequick/measurequick-report-generator",
-  "version": "1.5.199",
+  "version": "1.5.200",
   "description": "Generates PDF documents for various measureQuick applications.",
   "main": "index.js",
   "scripts": {

package/report-gen-scripts/vitals-heatpump-heating-report.js

@@ -223,55 +223,103 @@ export async function getReport(payload, _test) {
 
     form.getTextField("YourSystemScorePage2").setText(`${systemScorePercentage} ${systemScoreGrade}`);
 
-    // Print targets and range icons (using appropriate values for heat pump heating)
-    // Only show range icons for measurements that exist
-    // Map field names to textFields values and check if they exist
-    const measureChecks = [
-      { label: "Superheat", value: textFields.tempRise },      // Temperature Rise
-      { label: "Subcooling", value: textFields.approach, ref: "temperature_difference_condenser" },  // Approach
-      { label: "Condenser", value: textFields.cop },           // COP/Efficiency
-      { label: "TempSplit", value: textFields.oat },           // Outdoor Air Temp
-      { label: "Tesp", value: textFields.tesp },               // Total External Static Pressure
-      { label: "FilterFace", value: textFields.airflow }       // Airflow
-    ];
-
-    for (let i = 0; i < measureChecks.length; i++) {
-      const { label, value, ref } = measureChecks[i];
-      // Only show range indicator if value exists (is not "--")
-      if (value && value !== "--") {
-        let icon = iconRangeGreen;
-        let iconPlacement = "Mid";
-
-        // Check if we have target zone data for this measurement
-        if (ref && t.targets && t.targets[ref] !== undefined) {
-          const target = parseFloat(t.targets[ref]);
-          const idealLow = t.targets[`${ref}_ideal_low`] ? parseFloat(t.targets[`${ref}_ideal_low`]) : 0;
-          const idealHigh = t.targets[`${ref}_ideal_high`] ? parseFloat(t.targets[`${ref}_ideal_high`]) : 0;
-          const actual = parseFloat(value);
-          const low = target - idealLow;
-          const high = target + idealHigh;
-
-          if (actual < low) {
-            icon = iconRangeRed;
-            iconPlacement = "Low";
-          } else if (actual > high) {
-            icon = iconRangeRed;
-            iconPlacement = "High";
+    // Print targets and range icons for heat pump heating
+    // Heat pump heating target zones - some are in data, some in targets
+    const measureLabels = ["Superheat", "Subcooling", "Condenser", "TempSplit", "Tesp", "FilterFace"];
+
+    for (let i = 0; i < measureLabels.length; i++) {
+      const label = measureLabels[i];
+      let targetZone = "";
+      let icon = iconRangeGreen;
+      let iconPlacement = "Mid";
+      let value = "";
+      let mid, low, high;
+
+      if (label === "Superheat") {
+        // Temperature Rise - no specific target zone for HP heating, show measured value
+        value = textFields.tempRise;
+        // HP heating doesn't have fixed temp rise targets like gas heating
+      } else if (label === "Subcooling") {
+        // Approach - LLT minus entering dry bulb
+        value = textFields.approach;
+        // Check for approach targets in targets object
+        if (t.targets && t.targets.approach !== undefined) {
+          mid = parseFloat(t.targets.approach);
+          const idealLow = t.targets.approach_ideal_low !== undefined ? parseFloat(t.targets.approach_ideal_low) : 3;
+          const idealHigh = t.targets.approach_ideal_high !== undefined ? parseFloat(t.targets.approach_ideal_high) : 3;
+          low = mid - idealLow;
+          high = mid + idealHigh;
+          if (!isNaN(low) && !isNaN(high)) {
+            targetZone = `(${low.toFixed(1)} - ${high.toFixed(1)})`;
+          }
+        }
+      } else if (label === "Condenser") {
+        // COP - target is in data.hp_heating_cop_target
+        value = textFields.cop;
+        if (t.data && t.data.hp_heating_cop_target !== undefined) {
+          mid = parseFloat(t.data.hp_heating_cop_target);
+          // COP ideal range is typically ±0.3
+          low = mid - 0.3;
+          high = mid + 0.3;
+          if (!isNaN(low) && !isNaN(high)) {
+            targetZone = `(${low.toFixed(2)} - ${high.toFixed(2)})`;
+          }
+        }
+      } else if (label === "TempSplit") {
+        // Outdoor Air Temp - no target zone, just informational
+        value = textFields.oat;
+      } else if (label === "Tesp") {
+        // Total External Static Pressure
+        value = textFields.tesp;
+        if (t.targets && t.targets.pressure_static_total_external !== undefined) {
+          mid = parseFloat(t.targets.pressure_static_total_external);
+          high = mid * 1.4;
+          if (!isNaN(high)) {
+            targetZone = `(< ${high.toFixed(2)})`;
           }
         }
+      } else if (label === "FilterFace") {
+        // Airflow - no specific target zone
+        value = textFields.airflow;
+      }
 
-        try {
-          form.getButton(`Image${label}${iconPlacement}_af_image`).setImage(icon);
-        } catch (e) {
-          // Field may not exist
+      // Determine range indicator position if we have target values
+      if (value && value !== "--" && mid !== undefined) {
+        const actual = parseFloat(value);
+        if (!isNaN(actual)) {
+          if (label === "Tesp") {
+            // TESP: only check if above threshold
+            if (actual > high) {
+              icon = iconRangeRed;
+              iconPlacement = "High";
+            }
+          } else if (low !== undefined && high !== undefined) {
+            if (actual < low) {
+              icon = iconRangeRed;
+              iconPlacement = "Low";
+            } else if (actual > high) {
+              icon = iconRangeRed;
+              iconPlacement = "High";
+            }
+          }
         }
       }
-      // Clear target zone text for heat pump heating (different targets apply)
+
+      // Set target zone text
       try {
-        form.getTextField(`${label}Target`).setText("");
+        form.getTextField(`${label}Target`).setText(targetZone);
       } catch (e) {
         // Field may not exist
       }
+
+      // Set range indicator icon if value exists
+      if (value && value !== "--") {
+        try {
+          form.getButton(`Image${label}${iconPlacement}_af_image`).setImage(icon);
+        } catch (e) {
+          // Field may not exist
+        }
+      }
     }
 
     // Skip pass/fail subsystem review for heat pump heating