@measurequick/measurequick-report-generator 1.5.196 → 1.5.197

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@measurequick/measurequick-report-generator",
-  "version": "1.5.196",
+  "version": "1.5.197",
   "description": "Generates PDF documents for various measureQuick applications.",
   "main": "index.js",
   "scripts": {

package/report-gen-scripts/vitals-heatpump-heating-report.js

@@ -193,7 +193,7 @@ export async function getReport(payload, _test) {
 
     // Heat pump heating measurements (using existing form fields with different data)
     form.getTextField("Superheat").setText(`${textFields.tempRise} °${payload.units.temperature}`);
-    form.getTextField("Subcooling").setText(`${textFields.llt} °${payload.units.temperature}`);
+    form.getTextField("Subcooling").setText(`${textFields.approach} °${payload.units.temperature}`);
     form.getTextField("CondenserApproach").setText(`${textFields.cop}`);
     form.getTextField("TemperatureSplit").setText(`${textFields.oat} °${payload.units.temperature}`);
     form.getTextField("TotalExternalStaticPressure").setText(`${textFields.tesp} inH2O`);
@@ -234,7 +234,7 @@ export async function getReport(payload, _test) {
     // Map field names to textFields values and check if they exist
     const measureChecks = [
       { label: "Superheat", value: textFields.tempRise },      // Temperature Rise
-      { label: "Subcooling", value: textFields.llt },          // Liquid Line Temp
+      { label: "Subcooling", value: textFields.approach, ref: "temperature_difference_condenser" },  // Approach
       { label: "Condenser", value: textFields.cop },           // COP/Efficiency
       { label: "TempSplit", value: textFields.oat },           // Outdoor Air Temp
       { label: "Tesp", value: textFields.tesp },               // Total External Static Pressure
@@ -242,13 +242,30 @@ export async function getReport(payload, _test) {
     ];
 
     for (let i = 0; i < measureChecks.length; i++) {
-      const { label, value } = measureChecks[i];
+      const { label, value, ref } = measureChecks[i];
       // Only show range indicator if value exists (is not "--")
       if (value && value !== "--") {
-        // For heat pump heating, we don't have typical target ranges yet
-        // Show green icon as placeholder for valid measurements
         let icon = iconRangeGreen;
         let iconPlacement = "Mid";
+
+        // Check if we have target zone data for this measurement
+        if (ref && t.targets && t.targets[ref] !== undefined) {
+          const target = parseFloat(t.targets[ref]);
+          const idealLow = t.targets[`${ref}_ideal_low`] ? parseFloat(t.targets[`${ref}_ideal_low`]) : 0;
+          const idealHigh = t.targets[`${ref}_ideal_high`] ? parseFloat(t.targets[`${ref}_ideal_high`]) : 0;
+          const actual = parseFloat(value);
+          const low = target - idealLow;
+          const high = target + idealHigh;
+
+          if (actual < low) {
+            icon = iconRangeRed;
+            iconPlacement = "Low";
+          } else if (actual > high) {
+            icon = iconRangeRed;
+            iconPlacement = "High";
+          }
+        }
+
         try {
           form.getButton(`Image${label}${iconPlacement}_af_image`).setImage(icon);
         } catch (e) {
@@ -310,7 +327,7 @@ function getTextFields(payload, test) {
     zip: payload.site.location.zip ? ` ${payload.site.location.zip}` : "",
     // Heat pump heating specific fields
     tempRise: tempRise,
-    llt: test.data.temperature_liquid_line !== undefined ? (+test.data.temperature_liquid_line).toFixed(1) : "--",
+    approach: test.data.temperature_difference_condenser !== undefined ? (+test.data.temperature_difference_condenser).toFixed(1) : "--",
     cop: test.data.cop !== undefined ? (+test.data.cop).toFixed(2) : "--",
     oat: test.data.temperature_outdoor_dry_bulb !== undefined ? (+test.data.temperature_outdoor_dry_bulb).toFixed(1) : "--",
     tesp: test.data.pressure_static_total_external !== undefined ? (+test.data.pressure_static_total_external).toFixed(2) : "--",