@mcpher/gas-fakes 1.0.17 → 1.0.19

package/.aiexclude

@@ -0,0 +1,6 @@
+testongas
+gaslibtests
+gasmess
+node_modules
+shells
+README.RU.md

package/gasmess/bruce/pbx.js

@@ -2,8 +2,58 @@ import '../../main.js';
 import { moveToTempFolder, deleteTempFile } from '../tempfolder.js';
 import { report, scl } from './dreport.js';
 
+
+
 const suffix = "-bruce"
 
+const tx2 = () => {
+  let doc = DocumentApp.create("abc")
+  const id = doc.getId()
+  moveToTempFolder(id, suffix)
+
+  let body = doc.getBody()
+
+  const p1 = body.appendParagraph("p1")
+  doc = scl(doc)
+  let d = Docs.Documents.get(id)
+  console.log(JSON.stringify(d))
+  
+  const attributesToSet = {
+    [DocumentApp.Attribute.HORIZONTAL_ALIGNMENT]: DocumentApp.HorizontalAlignment.CENTER,
+    [DocumentApp.Attribute.ITALIC]: true,
+    [DocumentApp.Attribute.FONT_FAMILY]: 'Comic Sans MS'
+  };
+
+  body = doc.getBody()
+  body.setAttributes(attributesToSet);
+  doc = scl(doc)
+  d = Docs.Documents.get(id)
+  console.log(JSON.stringify(d))
+
+
+  deleteTempFile(id)
+}
+
+tx2()
+const tx1 = () => {
+  let doc = DocumentApp.create("abc")
+  const id = doc.getId()
+  moveToTempFolder(id, suffix)
+
+
+
+  const body = doc.getBody();
+  const paraText = "p1";
+
+  const appendedPara = body.appendParagraph(paraText);
+  const paraToTest = body.getChild(1);
+  doc = scl(doc)
+  console.log(report(Docs.Documents.get(id, { includeTabsContent: true }), `\n1.empty document`))
+  const attributes = paraToTest.getAttributes();
+
+  deleteTempFile(id)
+}
+tx1()
 const tabsa = () => {
 
   let doc = DocumentApp.create("abc")
@@ -11,11 +61,11 @@ const tabsa = () => {
   moveToTempFolder(id, suffix)
 
   let body = doc.getBody()
-  console.log (body)
+  console.log(body)
   doc = scl(doc)
-  console.log(report(Docs.Documents.get(id, {includeTabsContent: true}), `\n1.empty document`))
+  console.log(report(Docs.Documents.get(id, { includeTabsContent: true }), `\n1.empty document`))
+
 
-  
   deleteTempFile(id)
 }
 
@@ -70,7 +120,7 @@ const pbnew = () => {
   console.log(report(Docs.Documents.get(id), `\n4.inserted para 2`))
 
   body = doc.getBody()
-  body.insertTable(1, [['eboo', 'fbar']]  )
+  body.insertTable(1, [['eboo', 'fbar']])
   doc = scl(doc)
   console.log(report(Docs.Documents.get(id), `\nt4.inserted table at child 1`))
 
@@ -81,12 +131,12 @@ const pbnew = () => {
 
   body = doc.getBody()
   let c = body.getChild(2)
-  c.appendText( 'p2 appended text')
+  c.appendText('p2 appended text')
   doc = scl(doc)
   console.log(report(Docs.Documents.get(id), `\n6.appended text to para 2`))
 
   body = doc.getBody()
-  body.insertTable(3, [['bar', 'foo'], ['barfoo', 'foobar'], ['eboo', 'fbar']]  )
+  body.insertTable(3, [['bar', 'foo'], ['barfoo', 'foobar'], ['eboo', 'fbar']])
   doc = scl(doc)
   console.log(report(Docs.Documents.get(id), `\nt6.inserted table at child 3`))
 
@@ -107,7 +157,7 @@ const pbnew = () => {
   console.log(report(Docs.Documents.get(id), `\n9.inserted page break in para 3`))
 
   body = doc.getBody()
-  c=body.getChild(3)
+  c = body.getChild(3)
   c.appendText('after pagebreak in 3')
   doc = scl(doc)
   console.log(report(Docs.Documents.get(id), `\n10.inserted text after pagebreak in 3`))
@@ -120,7 +170,7 @@ const pbnew = () => {
   deleteTempFile(id)
 }
 
-pbnew()
+
 
 
 

package/gasmess/bruce/sorting.js

@@ -0,0 +1,106 @@
+
+/**
+ * Compares two values using Google Sheets' ascending sort logic.
+ * @param {*} a first value to compare
+ * @param {*} b second value to compare
+ * @returns {number} a<b: -1, a===b: 0, a>b: 1
+ */
+const compareMixedValues = (a, b) => {
+  const isBlankA = (a === null || a === undefined || a === "");
+  const isBlankB = (b === null || b === undefined || b === "");
+
+  // Handle blanks - always sorted to the top in this ascending comparator
+  if (isBlankA && !isBlankB) return -1;
+  if (!isBlankA && isBlankB) return 1;
+  if (isBlankA && isBlankB) return 0;
+
+  // Get type priorities (lower number = sorts first)
+  const getTypePriority = (val) => {
+    // Correct Google Sheets ascending priority
+    if (typeof val === 'number') return 1;
+    if (typeof val === 'string') return 2;
+    if (typeof val === 'boolean') return 3;
+    if (val instanceof Date) return 4;
+    return 5;
+  };
+
+  const priorityA = getTypePriority(a);
+  const priorityB = getTypePriority(b);
+
+  // If different types, sort by type priority
+  if (priorityA !== priorityB) {
+    return priorityA < priorityB ? -1 : 1;
+  }
+
+  // Same types - compare values
+  if (typeof a === 'number' && typeof b === 'number') {
+    return a - b;
+  }
+  if (typeof a === 'string' && typeof b === 'string') {
+    return a.localeCompare(b, undefined, { sensitivity: 'base', numeric: true });
+  }
+  if (typeof a === 'boolean' && typeof b === 'boolean') {
+    return (a === b) ? 0 : (a ? 1 : -1); 
+  }
+  if (a instanceof Date && b instanceof Date) {
+    return a.getTime() - b.getTime();
+  }
+
+  // Fallback for other types
+  const strA = String(a);
+  const strB = String(b);
+  return strA.localeCompare(strB, undefined, { sensitivity: 'base' });
+};
+// ... your sort2d function remains correct, just pass the 'ascending' flag to compareMixedValues.
+export const sort2d = (spec, arr) => {
+  const deepCopy = arr.map(row => [...row]);
+  return deepCopy.sort((a, b) => {
+    for (const s of spec) {
+      const index = (typeof s === 'object' && s !== null) ? s.column - 1 : s - 1;
+      const ascending = (typeof s === 'object' && s !== null) ? s.ascending !== false : true;
+      let result = compareMixedValues(a[index], b[index]);
+      if (!ascending) {
+          result = -result;
+      }
+      if (result !== 0) {
+          return result;
+      }
+    }
+    return 0;
+  });
+};
+
+// Test function to verify behavior
+export const testSorting = (spec) => {
+  const testData = [
+    [false, 120, 'cheese', 'peach', 'armpit', 10],
+    ['kiwi', 'orange', 'apple', 'bub ble', 'bucket', 'armpit'],
+    ['plum', 'butter', 'buckle', 'grape', 65, 65],
+    [false, "", 'armpit', 'orange', 21, 'buckle'],
+    ['cherry', 'foo', 'butter', 21, 'red eye', 'foo'],
+    ['kiwi', 77, false, 'banana', 'red eye', 'apple'],
+    ['buckle', 'bar', 'foo', 21, 10, 'foo'],
+    ['bub ble', 65, 'butter', 'buckle', 'bub ble', null],
+    ['cheese', 'pear', 'pear', 77, 10, 'foo'],
+    [
+      'bub ble',
+      'armpit',
+      'melon',
+      'buckle',
+      'red eye',
+      3.141592653589793
+    ],
+    ['pear', false, 0.3963452962629548, 'foo', 'banana', 'plum'],
+    ['cherry', true, 'apple', 'cheese', 'butter', 'peach']
+  ]
+
+  console.log('Original:', testData);
+
+  // Sort by column 2 (booleans) ascending
+  const sorted = sort2d(spec, testData);
+  console.log('Sorted by column 2 (booleans ASC):', sorted);
+
+  return sorted;
+};
+const spec = [1,{column:2 , ascending:false}]
+testSorting(spec)

package/gasmess/tanaike/for_simple_test.js

@@ -1,12 +1,7 @@
 import "../../main.js";
-import { FakeSpreadsheetApp } from "../../src/services/spreadsheetapp/fakespreadsheetapp.js";
-import { moveToTempFolder, deleteTempFile } from "./tempfolder.js";
 
-const spreadsheet = SpreadsheetApp.openById("###");
+ScriptApp.__behavior.sandBoxMode = true;
+const spreadsheet = SpreadsheetApp.create("sample1");
 const sheet = spreadsheet.getSheets()[0];
 sheet.setName("sample");
-
-const r = spreadsheet.getRangeByName("test111");
-if (r) {
-  console.log(r.getA1Notation());
-}
+ScriptApp.__behavior.trash();

package/gasmess/tanaike/sample5.js

@@ -0,0 +1,63 @@
+import "../../main.js";
+
+ScriptApp.__behavior.sandBoxMode = true;
+sample();
+ScriptApp.__behavior.trash();
+
+function sample() {
+  const spreadsheet = SpreadsheetApp.create("sample");
+  const sheet = spreadsheet.getSheets()[0];
+
+  // Create protected sheet.
+  // For Class Sheet
+  const unprotectedRanges = [sheet.getRange("A1:B1")];
+  const p1 = sheet
+    .protect()
+    .setDescription("sample1")
+    .setWarningOnly(true)
+    .setUnprotectedRanges(unprotectedRanges);
+  console.log(p1.getDescription()); // "sample1"
+  console.log(p1.getUnprotectedRanges()[0].getA1Notation()); // "A1:B1"
+  console.log(p1.canEdit()); // true
+  console.log(p1.getEditors().length); // 1
+  console.log(p1.getProtectionType().toString()); // SHEET
+  console.log(p1.isWarningOnly()); // true
+
+  // For Class Spreadsheet
+  const protections = spreadsheet.getProtections(
+    SpreadsheetApp.ProtectionType.SHEET
+  );
+  console.log(protections.some((p) => p.getDescription() == "sample1")); // true
+
+  p1.remove();
+
+  // Create protected range with a range.
+  // For Class Range
+  const p2 = sheet.getRange("A1:D5").protect().setDescription("sample2");
+  p2.setRange(sheet.getRange("B2:E6"));
+  console.log(p2.getRange().getA1Notation()); // "B2:E6"
+  console.log(p2.getProtectionType().toString()); // RANGE
+  p2.remove();
+
+  // Create named range.
+  const rangeName = "sampleNamedRange1";
+  const range1 = sheet.getRange("C3:F7");
+  spreadsheet.setNamedRange(rangeName, range1);
+  const namedRange = spreadsheet
+    .getNamedRanges()
+    .find((e) => e.getName() == rangeName);
+
+  // Create protected range with named range 1.
+  const p3 = sheet.getRange("A1:D5").protect().setDescription("sample2");
+  p3.setRangeName(rangeName);
+  console.log(p3.getRangeName()); // sampleNamedRange1
+  p3.remove();
+
+  // Create protected range with named range 2.
+  const p4 = sheet.getRange("A1:D5").protect().setDescription("sample2");
+  p4.setNamedRange(namedRange);
+  console.log(p4.getRangeName()); // sampleNamedRange1
+  p4.remove();
+
+  namedRange.remove();
+}

package/ghissues/image-size-inconsistency-issue.sh

@@ -0,0 +1,46 @@
+#!/bin/bash
+
+# A shell script to create a GitHub issue for the image sizing inconsistency.
+
+# Issue title
+TITLE="Investigate and Align Image Insertion Sizing Behavior"
+
+# Issue body in markdown
+BODY=$(cat <<'EOF'
+## Summary
+
+There is a significant and inconsistent discrepancy in how the live `DocumentApp` service and the `gas-fakes` emulation (via the Docs API) handle the dimensions of an image when it is inserted using `body.insertImage(image.copy())` or `body.appendImage(image.copy())`.
+
+The `testdocsimages.js` test suite has repeatedly failed and required adjustments because the expected dimensions of the inserted image are unpredictable in the live environment.
+
+## Observed Behaviors in Live Apps Script
+
+Our testing has revealed several conflicting behaviors from the live API:
+
+1.  **Intrinsic Size:** Sometimes, the API ignores the dimensions of the copied `InlineImage` object and re-fetches the image from its source URI, using its original intrinsic dimensions (e.g., `544x184` for the Google logo).
+2.  **Copied Object Size:** At other times, the API correctly respects the dimensions of the copied `InlineImage` object (e.g., `61x181` in our tests).
+3.  **Default/Fixed Size:** On at least one occasion, the API appeared to resize the image to a seemingly arbitrary fixed size (e.g., `240x80`).
+4.  **State-Dependent:** The behavior seems to be dependent on the state of the document. A brand-new document might exhibit one behavior, while a reused document (even after `doc.clear()`) exhibits another.
+
+## Current Workaround
+
+The current test (`insertImage behavior on new documents` in `testdocsimages.js`) has been made more robust by:
+- Forcing the creation of a new document for the test using `maketdoc(..., { forceNew: true })`.
+- Abandoning exact dimension checks in the live environment and instead verifying the image's **aspect ratio** within a tolerance.
+
+While this makes the test pass, it highlights a core emulation inaccuracy.
+
+## TODO
+
+1.  **Investigate Further:** Conduct a definitive set of tests to determine if there is *any* predictable pattern to the live API's behavior.
+2.  **Decide on Emulation Strategy:**
+    - Should `gas-fakes` emulate the most common or most "correct" behavior (i.e., respecting the copied object's dimensions)?
+    - Or should it attempt to mimic the most recently observed "new document" behavior (using intrinsic size)?
+3.  **Document the Oddity:** Regardless of the chosen strategy, this inconsistency is a significant "oddity" and should be thoroughly documented in `oddities.md` to inform users who might encounter similar issues when working with images in `DocumentApp`.
+
+This will improve the accuracy of the fake environment and provide valuable documentation for the community.
+EOF
+)
+
+# Create the issue using GitHub CLI
+gh issue create --title "$TITLE" --body "$BODY" --label "bug" --label "emulation-accuracy" --label "document-app"

package/ghissues/issue-formapp-create-title-inconsistency.sh

@@ -0,0 +1,51 @@
+#!/bin/bash
+
+# A shell script to create a GitHub issue for the FormApp.create() title inconsistency.
+
+# Issue title
+TITLE="Discrepancy between FormApp.create(title) and Forms API behavior regarding form title and file name"
+
+# Issue body in markdown
+BODY=$(cat <<'EOF'
+### Summary
+
+There is a significant and counter-intuitive discrepancy between the documented behavior of `FormApp.create(title)` in Google Apps Script and the constraints of the underlying Google Forms API. `FormApp.create(title)` sets the Google Drive *file name* to the provided `title`, but leaves the form's internal title (retrieved by `form.getTitle()`) blank.
+
+This makes it impossible to accurately emulate the Apps Script behavior using the public Forms API, as the API requires a non-empty title for both creation and updates.
+
+### Live Apps Script Behavior
+
+When the following Apps Script code is executed:
+
+```javascript
+function testFormCreation() {
+  const formName = "foo-form";
+  const form = FormApp.create(formName);
+  const id = form.getId();
+  
+  console.log('Internal form title:', form.getTitle()); // Logs: "" (an empty string)
+  
+  const file = DriveApp.getFileById(id);
+  console.log('Drive file name:', file.getName());   // Logs: "foo-form"
+  
+  // cleanup
+  file.setTrashed(true);
+}
+```
+
+The output demonstrates that `FormApp.create()` uses the argument to set the Drive file name, but the form's own title property remains empty.
+
+### The Problem with API Emulation
+
+This behavior is problematic to replicate with the v1 Google Forms API because the `forms.create` method requires a non-empty `info.title`. Attempting to then `batchUpdate` the title to an empty string also fails, as the API rejects an empty title on update.
+
+### Conclusion
+
+This disconnect means it's impossible for developers using the public Forms API to programmatically create a form that exactly matches the state of one created by `FormApp.create()`. This poses a significant challenge for testing and emulation frameworks.
+
+The expected behavior would be for `FormApp.create(title)` to set both the Drive file name and the internal form title, or for the API to allow setting the title to an empty string via an update.
+EOF
+)
+
+# Create the issue using GitHub CLI
+gh issue create --title "$TITLE" --body "$BODY" --label "bug" --label "emulation-accuracy" --label "form-app"

package/ghissues/protection-editors-issue.sh

@@ -0,0 +1,33 @@
+#!/bin/bash
+
+# A shell script to create a GitHub issue for the Protection.getEditors() behavior.
+
+# Issue title
+TITLE="Align Protection.getEditors() behavior with Live Apps Script"
+
+# Issue body in markdown
+BODY=$(cat <<'EOF'
+## Summary
+
+There is a discrepancy between the live Google Apps Script environment and the `gas-fakes` emulation regarding the return value of `Protection.getEditors()` on a newly created protection.
+
+-   **Live Apps Script:** `protection.getEditors().length` returns `0`.
+-   **`gas-fakes` (current):** `protection.getEditors().length` incorrectly returns `1`.
+
+## Live Behavior Details
+
+In the live environment, the owner of a spreadsheet can always edit a protected range or sheet (`protection.canEdit()` returns `true`). However, the owner is **not** automatically included in the explicit list of editors returned by `getEditors()`. This is confirmed by live testing.
+
+## `gas-fakes` Behavior
+
+The `gas-fakes` implementation in `fakeprotection.js` was incorrectly adding the current user (as the owner) to the list of editors upon creation of a new `Protection` object.
+
+## TODO
+
+1.  Modify `fakeprotection.js` to no longer automatically add the owner to the `editors` list when a new protection is created. The `canEdit()` method should still return `true` for the owner.
+2.  Run the full test suite to ensure this change doesn't have unintended side effects and that the `Protection` tests now pass in both environments.
+EOF
+)
+
+# Create the issue using GitHub CLI
+gh issue create --title "$TITLE" --body "$BODY" --label "bug" --label "emulation-accuracy" --label "spreadsheet-app"

package/ghissues/review-sandbox-listing-issue.sh

@@ -0,0 +1,45 @@
+#!/bin/bash
+
+# A shell script to create a GitHub issue for reviewing sandbox listing behavior.
+
+# Issue title
+TITLE="Review Sandbox Strategy for File Listing Operations"
+
+# Issue body in markdown
+BODY=$(cat <<'EOF'
+## Summary
+
+Currently, tests that perform broad file/folder listing operations (e.g., `DriveApp.getFiles()`, `someFolder.getFolders()`) fail when `strictSandbox` is `true`. This is because the underlying iterators may need to access metadata of parent folders that are not explicitly whitelisted, causing the sandbox to correctly deny access.
+
+The current workaround, as implemented in `testdrive.js`, is to temporarily disable `strictSandbox` for the duration of these tests:
+
+```javascript
+const wasStrict = behavior.strictSandbox;
+behavior.strictSandbox = false;
+try {
+  // ... listing operations ...
+} finally {
+  behavior.strictSandbox = wasStrict;
+}
+```
+
+While this works, it feels like a patch rather than a fundamental solution. We should review if there's a more robust and elegant way to handle this.
+
+## TODO
+
+Investigate and decide on the best long-term strategy for handling file listings in strict sandbox mode.
+
+### Options to Consider:
+
+1.  **Implicit Parent Whitelisting:** Could the file/folder iterators be enhanced to automatically (and temporarily) whitelist parent folders as they are encountered? This would keep the sandbox strict for all other operations but allow listings to complete. This seems like the most robust solution if feasible.
+
+2.  **Refined Iterator Logic:** Can the iterators be modified to avoid the specific checks that cause the failure when in strict mode? This might involve fetching less metadata for items outside the session/whitelist scope.
+
+3.  **Accept and Document:** If the current `try...finally` workaround is deemed the most practical approach, we should formally document it in `sandbox.md` as the recommended pattern for this scenario.
+
+This review will help ensure the sandbox feature is both as secure and as user-friendly as possible.
+EOF
+)
+
+# Create the issue using GitHub CLI
+gh issue create --title "$TITLE" --body "$BODY" --label "enhancement"

package/package.json

@@ -4,7 +4,6 @@
   },
   "dependencies": {
     "@mcpher/fake-gasenum": "^1.0.2",
-    "@mcpher/gas-fakes": "^1.0.14",
     "@mcpher/unit": "^1.1.11",
     "@sindresorhus/is": "^7.0.1",
     "archiver": "^7.0.1",
@@ -43,6 +42,8 @@
     "testsheetsdata": "cp mainlocal.js main.js &&  node --env-file=.env ./test/testsheetsdata.js execute",
     "testdocsadv": "cp mainlocal.js main.js &&  node --env-file=.env ./test/testdocsadv.js execute",
     "testslidesadv": "cp mainlocal.js main.js &&  node --env-file=.env ./test/testslidesadv.js execute",
+    "testform": "cp mainlocal.js main.js &&  node --env-file=.env ./test/testform.js execute",
+    "testformsadv": "cp mainlocal.js main.js &&  node --env-file=.env ./test/testformsadv.js execute",
     "testdocs": "cp mainlocal.js main.js &&  node --env-file=.env ./test/testdocs.js execute",
     "testslides": "cp mainlocal.js main.js &&  node --env-file=.env ./test/testslides.js execute",
     "testdocsnext": "cp mainlocal.js main.js &&  node --env-file=.env ./test/testdocsnext.js execute",
@@ -54,10 +55,12 @@
     "testdocsfooters": "cp mainlocal.js main.js &&  node --env-file=.env ./test/testdocsfooters.js execute",
     "testdocsfootnotes": "cp mainlocal.js main.js &&  node --env-file=.env ./test/testdocsfootnotes.js execute",
     "testdocsimages": "cp mainlocal.js main.js &&  node --env-file=.env ./test/testdocsimages.js execute",
+    "testdocsstyles": "cp mainlocal.js main.js &&  node --env-file=.env ./test/testdocsstyles.js execute",
+    "testsandbox": "cp mainlocal.js main.js &&  node --env-file=.env ./test/testsandbox.js execute",
     "pub": "cp mainlocal.js main.js && npm publish --access public"
   },
   "name": "@mcpher/gas-fakes",
-  "version": "1.0.17",
+  "version": "1.0.19",
   "license": "MIT",
   "main": "main.js",
   "description": "A proof of concept implementation of Apps Script Environment on Node",

package/regenerate-progress-reports.sh

@@ -0,0 +1,38 @@
+#!/bin/bash
+ 
+
+# This script contains the prompts to regenerate the progress reports for all services.
+# Execute this script and paste the output to the Gemini agent.
+
+echo "Generating progress report for Docs service..."
+echo "now do https://developers.google.com/apps-script/reference/document into ./progress/Docs.MD"
+
+echo "Generating progress report for Drive service..."
+echo "now do https://developers.google.com/apps-script/reference/drive into ./progress/drive.MD"
+
+echo "Generating progress report for Forms service..."
+echo "now do https://developers.google.com/apps-script/reference/forms into ./progress/forms.MD"
+
+echo "Generating progress report for Slides service..."
+echo "now do https://developers.google.com/apps-script/reference/slides into ./progress/slides.MD"
+
+echo "Generating progress report for Spreadsheet service..."
+echo "now do https://developers.google.com/apps-script/reference/spreadsheet into ./progress/sheets.MD"
+
+echo "Generating progress report for Utilities service..."
+echo "now do https://developers.google.com/apps-script/reference/utilities into ./progress/utilities.MD"
+
+echo "Generating progress report for UrlFetch service..."
+echo "now do https://developers.google.com/apps-script/reference/url-fetch into ./progress/urlFetch.MD"
+
+echo "Generating progress report for Cache service..."
+echo "now do https://developers.google.com/apps-script/reference/cache into ./progress/cache.MD"
+
+echo "Generating progress report for Properties service..."
+echo "now do https://developers.google.com/apps-script/reference/properties into ./progress/properties.MD"
+
+echo "Generating progress report for Script service..."
+echo "now do https://developers.google.com/apps-script/reference/script into ./progress/script.MD"
+
+echo "Generating progress report for Base service..."
+echo "now do https://developers.google.com/apps-script/reference/base into ./progress/base.MD"

package/src/index.js

@@ -4,10 +4,12 @@ import './services/urlfetchapp/app.js'
 import './services/utilities/app.js'
 import './services/spreadsheetapp/app.js'
 import './services/stores/app.js'
-import './services/session/app.js'
+import './services/base/app.js'
 import './services/advdrive/app.js'
 import './services/advsheets/app.js'
 import './services/advdocs/app.js'
 import './services/advslides/app.js'
 import './services/documentapp/app.js'
+import './services/advforms/app.js'
+import './services/formapp/app.js'
 import './services/slidesapp/app.js'

package/src/services/advdocs/fakeadvdocs.js

@@ -628,7 +628,12 @@ class FakeAdvDocs {
   __getDocsPerformance() {
     return docsCacher.getPerformance()
   }
+  __addAllowed(id) {
+    if (ScriptApp.__behavior.sandBoxMode) {
+      ScriptApp.__behavior.addFile(id);
+    }
+    return id
+  }
 }
 
 export const newFakeAdvDocs = (...args) => Proxies.guard(new FakeAdvDocs(...args))
-

package/src/services/advdocs/fakeadvdocuments.js

@@ -17,19 +17,7 @@ class FakeAdvDocuments extends FakeAdvResource {
   constructor(docs) {
     super(docs, 'documents', Syncit.fxDocs);
     this.__fakeObjectType = "Docs.Documents";
-  }
-  // in sandbox mode only files created in this instance are
-  __allowed(id) {
-    if (!ScriptApp.__behavior.isAccessible(id)) {
-      throw new Error(`Access to document ${id} is not allowed in sandbox mode`);
-    }
-    return id
-  }
-  __addAllowed(id) {
-    if (ScriptApp.__behavior.sandBoxMode) {
-      ScriptApp.__behavior.addFile(id);
-    }
-    return id
+    this.docs = docs;
   }
 
   create(resource, options) {
@@ -44,7 +32,7 @@ class FakeAdvDocuments extends FakeAdvResource {
 
     // maybe we need to throw an error
     gError(response, 'docs.documents', "create")
-    this.__addAllowed(data.documentId);
+    this.docs.__addAllowed(data.documentId);
     return data
   }
 
@@ -55,12 +43,14 @@ class FakeAdvDocuments extends FakeAdvResource {
       matchThrow("API call to docs.documents.batchUpdate failed with error: Invalid JSON payload received.");
     }
 
+    // any update to a doc is a write
+    ScriptApp.__behavior.isAccessible(documentId, 'Docs', 'write');
 
     // Invalidate the cache for this document since we are updating it.
     docsCacher.clear(documentId);
     // console.log (JSON.stringify(requests))
     const { response, data } = this._call("batchUpdate", {
-      documentId: this.__allowed(documentId),
+      documentId,
       requestBody: requests
     });
 
@@ -101,7 +91,8 @@ class FakeAdvDocuments extends FakeAdvResource {
 
     if (is.nonEmptyObject(options) && !Reflect.ownKeys(options || {}).every(f => optionsSet.has(f))) matchThrow();
 
-    const params = {documentId: this.__allowed(documentId), ...(options || {}) };
+    ScriptApp.__behavior.isAccessible(documentId, 'Docs', 'read');
+    const params = {documentId, ...(options || {}) };
 
     const { response, data } = this._call("get", params);
     gError(response, 'docs.documents', 'get');