@mcpher/gas-fakes 1.0.11 → 1.0.12

package/README.md

@@ -794,9 +794,10 @@ The Sheets API doesn't know about these, so all r1c1 style methods such as setFo
 
 #### Intial verdict on using Gemini to generate some of this stuff
 
-I'm torn. On the one hand, it's been great at doing busy work like writing test cases and detecting dependencies that I might otherwise have missed. It can often be pretty good at refactoring/renaming things. On the other hand, if it gets it wrong, it's very hard to get it back on track as it tries bury itself deeper and deeper into previous misconceptions. It also has huge difficulty in updating large files no matter the detailed guidance. The usual end game is to restart a fresh context and/or copy and paste the content into a file you create manually.
+I'm torn. On the one hand, it's been great at doing busy work like writing test cases and detecting dependencies that I might otherwise have missed. It can often be pretty good at refactoring/renaming things. On the other hand, if it gets it wrong, it's very hard to get it back on track as it tries bury itself deeper and deeper into previous misconceptions. It also has huge difficulty in updating large files no matter the detailed guidance. The usual end game is to restart a fresh context and/or copy and paste the content into a file you create manually. 
+
+There were ocassions when the content Gemini provided content to be copied and pasted that was invalid syntax, or worse, dropped lines of code in sections it didn't plan to make any changes. In particular, code that had something like `ob[method](args)` was regularily truncated to just `ob`. Another issue is that Gemini can take 10-15 mins to create the full content for a large class in its chat window, sometimes ending in the gray screen of death. It's best to avoid using Gemini to make minor changes, but to just make them manually.
 
-There were ocassions when the content Gemini provided content to be copied and pasted that was invalid syntax, or worse, dropped lines of code in sections it didn't plan to make any changes. In particular, code that had something like `ob[method](args)` was regularily truncated to just `ob`
 
 Overall it saves some time, for sure. However, the result is often suboptimal, wordy, lacking in reusability and not something I would be be happy to put my name to. From a coder perspective, the role becomes one of repetetive specification, debugging, checking and testing, while failing to develop a deep understanding of the work in hand. I like coding, so from a satisfaction perspective, I'm not entirely convinced yet. I've found it's very impressive when creating small, standalone scripts but deteriorates rapidly both in speed and effectiveness as the codebase and dependencies grows. There's a point at which it becomes more trouble than it's worth.
 

package/package.json

@@ -41,7 +41,7 @@
     "pub": "cp mainlocal.js main.js && npm publish --access public"
   },
   "name": "@mcpher/gas-fakes",
-  "version": "1.0.11",
+  "version": "1.0.12",
   "license": "MIT",
   "main": "main.js",
   "description": "A proof of concept implementation of Apps Script Environment on Node",

package/src/services/driveapp/fakedriveapp.js

@@ -3,6 +3,8 @@ import { newFakeDriveFile } from './fakedrivefile.js'
 import { newFakeFolderApp } from './fakefolderapp.js'
 import { notYetImplemented, isFolder } from '../../support/helpers.js'
 import { Proxies } from '../../support/proxies.js'
+import { getPerformance } from '../../support/filecache.js';
+
 /**
  * basic fake DriveApp
  * @class FakeDriveApp
@@ -17,6 +19,10 @@ export class FakeDriveApp {
     this.__settleClass = (file) => isFolder(file) ? newFakeDriveFolder(file) : newFakeDriveFile(file)
   }
 
+  // exposes cache performance to tests 
+  __getPerformance() {
+    return getPerformance()
+  }
 
   toString() {
     return 'Drive'

package/src/services/spreadsheetapp/fakesheetrange.js

@@ -80,7 +80,6 @@ export class FakeSheetRange {
       'getDataSourceFormula',
       'activateAsCurrentCell',
       'setComments',
-      'setShowHyperlink',
 
       'createDataSourceTable',
       'getComments',
@@ -1310,7 +1309,7 @@ export class FakeSheetRange {
         const unionLeft = Math.min(startCol0, left);
         const unionBottom = Math.max(endRow0, bottom);
         const unionRight = Math.max(endCol0, right);
-        return sheet.getRange(unionTop + 1, unionLeft + 1, unionBottom - unionTop + 1, unionRight - unionLeft + 1);
+        return sheet.getRange(unionTop + 1, unionLeft + 1, unionBottom - unionTop + 1, unionRight - left + 1);
       }
       return sheet.getRange(top + 1, left + 1, bottom - top + 1, right - left + 1);
     }

package/src/services/spreadsheetapp/fakesheetrangelist.js

@@ -32,17 +32,17 @@ export class FakeSheetRangeList {
     const props = [
       'clearDataValidations',
       'setFontWeight',
- 
+
       'activate',
       'breakApart',
       'setFormulaR1C1',
- 
+
       'setBorder',
       'setFontColor',
       'setFontLine',
       'setFontStyle',
       'setWrap',
-      'setShowHyperlink',
+
       'setVerticalText',
       'setWrapStrategy',
       'uncheck',
@@ -76,6 +76,11 @@ export class FakeSheetRangeList {
     return 'RangeList'
   }
 
+  setShowHyperlink(showHyperlink) {
+    this.__ranges.forEach(r => r.setShowHyperlink(showHyperlink));
+    return this;
+  }
+
   /**
    * getRanges() https://developers.google.com/apps-script/reference/spreadsheet/range-list#getranges
    * Returns a list of one or more Range instances in the same sheet.
@@ -94,12 +99,12 @@ export class FakeSheetRangeList {
     return this;
   }
 
-  setBackground (color) {
+  setBackground(color) {
     this.__ranges.forEach(r => r.setBackground(color))
     return this
   }
- 
-  setBackgroundRGB (red, green, blue) {
+
+  setBackgroundRGB(red, green, blue) {
     this.__ranges.forEach(r => r.setBackgroundRGB(red, green, blue))
     return this
   }

package/src/services/spreadsheetapp/fakespreadsheetapp.js

@@ -8,6 +8,8 @@ import { newFakeTextStyleBuilder } from '../commonclasses/faketextstylebuilder.j
 import { newFakeFilterCriteriaBuilder } from './fakefiltercriteriabuilder.js'
 import { newFakeDataValidationBuilder } from './fakedatavalidationbuilder.js'
 import { newFakeDataSourceSpecBuilder } from './fakedatasourcespecbuilder.js';
+import { getSheetsPerformance } from '../../support/sheetscache.js';
+
 
 import * as Enums from '../enums/sheetsenums.js'
 
@@ -90,7 +92,7 @@ export class FakeSpreadsheetApp {
       'setActiveRangeList',
       'newCellImage',
       'getUi',
-      'flush',
+ 
       'open',
 
       'ChartAggregationType',
@@ -105,6 +107,12 @@ export class FakeSpreadsheetApp {
     })
 
   }
+  
+  // exposes cache performance to tests 
+  __getSheetsPerformance() {
+    return getSheetsPerformance()
+  }
+
 
   enableBigQueryExecution() {
     const { nargs, matchThrow } = signatureArgs(arguments, "SpreadsheetApp.enableBigQueryExecution");
@@ -123,7 +131,10 @@ export class FakeSpreadsheetApp {
     if (nargs) matchThrow();
     // This is a no-op in the fake environment.
   }
-
+  // currently no-op - probably not required as all ops are synchronous and currently not bundled
+  flush () {
+    return this
+  }
   /**
    * this one is probably deprecated
    * @param {string} id file id

package/src/services/spreadsheetapp/sheetrangemakers.js

@@ -317,7 +317,20 @@ export const setterList = [{
   maker: (_, value) => makeCellDataFromRichTextValue(value),
   fields: 'userEnteredValue,textFormatRuns,userEnteredFormat',
   typeChecker: isRichTextValue
-}]
+}, {
+  name: 'showHyperlink',
+  type: "boolean",
+  nullAllowed: false,
+  maker: (_, value) => {
+    // The API uses LINKED for true (show) and PLAIN_TEXT for false (hide).
+    // The live environment throws an error for a null argument, contrary to documentation.
+    const displayType = value ? 'LINKED' : 'PLAIN_TEXT';
+    return makeCellData('setHyperlinkDisplayType', displayType);
+  },
+  fields: 'userEnteredFormat.hyperlinkDisplayType',
+  plural: false
+}
+]
 
 // this is a list of all the range format getters and how to generate them
 export const attrGetList = [{
@@ -743,6 +756,7 @@ const isJagged = ({ range, cleaned }) => {
   return cleaned.length !== nr || cleaned.some(row => row.length !== nc)
 }
 
+
 const makeCellData = (method, value) => {
   const cellFormat = Sheets.newCellFormat()[method](value)
   const cellData = Sheets.newCellData().setUserEnteredFormat(cellFormat)
@@ -813,7 +827,7 @@ export const makeCellTextFormatData = (prop, value) => {
   if (!is.function(textFormat[prop])) {
     throw new Error(`tied to call ${prop} method on textFormat but it's not a function}`)
   }
-  if (!is.null(value)) textFormat[prop](value)
+  if (!is.null(value)) textFormatprop
   return makeCellData('setTextFormat', textFormat)
 }
 

package/src/support/helpers.js

@@ -114,7 +114,7 @@ const getWhat = (item) => getFakeType(item) || Utils.is(item)
  */
 export const argsMatchThrow = ( items, mess = "") => {
   // limit the error message 
-  const passedTypes = items.map(getWhat).map(Utils.capital).join(",")
+  const passedTypes = items.map(getWhat).map(capital).join(",")
   throw new Error(`The parameters (${passedTypes}) don't match the method ${mess}`)
 }
 
@@ -136,14 +136,13 @@ export const signatureArgs = (received, method, objectType = 'Object') => {
   const nargs = args.length
   
   // let's update the passedTypes for the error message to match what GAS does - https://github.com/brucemcpherson/gas-fakes/issues/25
-  // this throws an error if it inspects an ENUM
-  // TODO probably need to remove the guard on fake enums
-  // for now we;ll just catch and ignore
+  // this throws an error if it inspects an ENUM - this was an error in sindre's is() which is now fixed
+  // we'll just catch and ignore
   let passedTypes
   try {
-    passedTypes = args.map(is).map(capital).map(f=>f==='Object' ? objectType : f)
+    passedTypes = args.map(f=>is.null(f) ? 'null' : is(f)).map(f=>f==='null'? f :capital(f)).map(f=>f==='Object' ? objectType : f)
   } catch (err) {
-    console.log ("...warning failed signature check- probably an is. probe of an enum - ignoring", args)
+    console.log ("...warning failed signature check- probably an unsupported probe. probe of an enum - ignoring", args)
     passedTypes=[]
   }
   const matchThrow = (mess = method) => {