@mcp-abap-adt/core 6.4.0 → 6.4.1

package/CHANGELOG.md

@@ -2,6 +2,15 @@
 
 ## [Unreleased]
 
+## [6.4.1] - 2026-04-21
+
+### Fixed
+- `docker/Dockerfile`: switch default `MCP_TRANSPORT` from `stdio` to `http` so the image runs as an HTTP MCP server out of the box
+- `docker/Dockerfile`: correct launcher path (`dist/server/v2/launcher.js` → `dist/server/launcher.js`) — previous path did not exist and prevented the container from starting
+- `docker/Dockerfile`: pass `--allow-destination-header` so callers can supply SAP connection parameters via request headers (no default SAP connection baked into the image)
+- `docker/Dockerfile`: fix healthcheck endpoint (`/health` → `/mcp/health`) to match the actual route exposed by `StreamableHttpServer`
+- `docker/Dockerfile`: use `npm run build:fast` in the builder stage — the full `build` runs Biome which requires `.gitignore`, but `.dockerignore` excludes it
+
 ## [6.4.0] - 2026-04-20
 
 ### Added

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@mcp-abap-adt/core",
   "mcpName": "io.github.fr0ster/mcp-abap-adt",
-  "version": "6.4.0",
+  "version": "6.4.1",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
   "exports": {
@@ -43,9 +43,9 @@
     "test:init": "node -e \"const fs=require('fs'),s='tests/test-config.yaml',t=s+'.template';if(fs.existsSync(s)){console.log(s+' already exists, skipping (use test:reinit to overwrite)')}else{fs.copyFileSync(t,s);console.log('Created '+s+' — edit lines marked CHANGE')}\"",
     "test:reinit": "node -e \"const fs=require('fs'),s='tests/test-config.yaml',t=s+'.template';fs.copyFileSync(t,s);console.log('Recreated '+s+' from template')\"",
     "test": "jest --passWithNoTests",
-    "test:integration": "jest --testPathPatterns=integration --runInBand --passWithNoTests --forceExit",
-    "test:high": "jest --testPathPatterns='integration.*High' --runInBand --passWithNoTests --forceExit",
-    "test:low": "jest --testPathPatterns='integration.*Low' --runInBand --passWithNoTests --forceExit",
+    "test:integration": "jest --testPathPatterns=integration --testPathIgnorePatterns='__tests__/admin/' --runInBand --passWithNoTests --forceExit",
+    "test:high": "jest --testPathPatterns='integration.*High' --testPathIgnorePatterns='__tests__/admin/' --runInBand --passWithNoTests --forceExit",
+    "test:low": "jest --testPathPatterns='integration.*Low' --testPathIgnorePatterns='__tests__/admin/' --runInBand --passWithNoTests --forceExit",
     "test:check": "npx tsc --noEmit -p tsconfig.test.json",
     "shared:setup": "jest --testPathPatterns='admin/shared-deps/setup' --testPathIgnorePatterns='[]' --runInBand --passWithNoTests",
     "shared:teardown": "jest --testPathPatterns='admin/shared-deps/teardown' --testPathIgnorePatterns='[]' --runInBand --passWithNoTests",
@@ -204,7 +204,8 @@
       "!src/**/index.ts"
     ],
     "testPathIgnorePatterns": [
-      "__tests__/admin/"
+      "__tests__/admin/",
+      "__tests__/integration/"
     ],
     "maxWorkers": 1,
     "testTimeout": 600000,

package/docs/superpowers/plans/2026-03-26-guaranteed-unlock.md

@@ -1,220 +0,0 @@
-# Guaranteed Unlock on Error — Implementation Plan
-
-> **For agentic workers:** REQUIRED SUB-SKILL: Use superpowers:subagent-driven-development (recommended) or superpowers:executing-plans to implement this plan task-by-task. Steps use checkbox (`- [ ]`) syntax for tracking.
-
-**Goal:** Replace try-catch unlock-on-error with try-finally in all update handlers to guarantee unlock regardless of error path.
-
-**Architecture:** Move lock() inside the same try block that has the finally-unlock. Use the existing safe pattern from `handleUpdateFunctionGroup.ts` and `handleUpdateFunctionModule.ts` as reference. Activate stays AFTER the finally block (after unlock).
-
-**Tech Stack:** TypeScript, existing ADT client methods
-
----
-
-## Reference Pattern (from handleUpdateFunctionModule.ts)
-
-```typescript
-let lockHandle: string | undefined;
-try {
-  lockHandle = await client.getXxx().lock({ ... });
-  // ... check, update, etc.
-} finally {
-  if (lockHandle) {
-    try {
-      await client.getXxx().unlock({ ... }, lockHandle);
-    } catch (unlockError: any) {
-      logger?.warn(`Failed to unlock after error: ${unlockError?.message || unlockError}`);
-    }
-  }
-}
-// activate AFTER finally (unlock already done)
-```
-
-## Key transformation
-
-**Before (vulnerable):**
-```typescript
-lockHandle = await client.getXxx().lock({ ... });  // OUTSIDE try
-try {
-  // check → update → unlock (happy path)
-} catch (workflowError) {
-  // unlock-on-error (catch only)
-  if (lockHandle) await client.getXxx().unlock({ ... }, lockHandle);
-  throw workflowError;
-}
-```
-
-**After (safe):**
-```typescript
-let lockHandle: string | undefined;
-try {
-  lockHandle = await client.getXxx().lock({ ... });
-  // check → update (NO unlock in happy path — finally handles it)
-} finally {
-  if (lockHandle) {
-    try {
-      await client.getXxx().unlock({ ... }, lockHandle);
-      logger?.info(`Unlocked: ${objectName}`);
-    } catch (unlockError: any) {
-      logger?.warn(`Failed to unlock ${objectName}: ${unlockError?.message || unlockError}`);
-    }
-  }
-}
-// check inactive + activate AFTER finally
-```
-
-**Important:** Remove the explicit `unlock()` call from the happy path — `finally` handles both happy and error paths. Check-inactive and activate move AFTER the finally block since they don't need the lock.
-
----
-
-## Vulnerable Handlers (9 files)
-
-### Task 1: handleUpdateProgram.ts
-
-**Files:**
-- Modify: `src/handlers/program/high/handleUpdateProgram.ts`
-
-- [ ] **Step 1: Refactor lock/unlock to try-finally**
-
-Move `lock()` (line 111) inside the inner try. Replace inner `try { ... } catch (workflowError) { unlock; }` with `try { ... } finally { unlock; }`. Remove explicit `unlock()` from happy path (line 167). Move check-inactive (lines 171-191) and activate (lines 194-212) after the finally block.
-
-- [ ] **Step 2: Verify build**
-
-Run: `npx tsc --noEmit`
-Expected: no errors
-
-- [ ] **Step 3: Commit**
-
-```bash
-git commit -m "fix(UpdateProgram): guarantee unlock via try-finally (#22)"
-```
-
-### Task 2: handleUpdateClass.ts
-
-**Files:**
-- Modify: `src/handlers/class/high/handleUpdateClass.ts`
-
-- [ ] **Step 1: Refactor lock/unlock to try-finally**
-
-Same transformation: lock inside try, finally for unlock, remove happy-path unlock, move check-inactive + activate after finally.
-
-- [ ] **Step 2: Verify build**
-
-Run: `npx tsc --noEmit`
-
-- [ ] **Step 3: Commit**
-
-```bash
-git commit -m "fix(UpdateClass): guarantee unlock via try-finally (#22)"
-```
-
-### Task 3: handleUpdateInterface.ts
-
-**Files:**
-- Modify: `src/handlers/interface/high/handleUpdateInterface.ts`
-
-- [ ] **Step 1: Refactor lock/unlock to try-finally**
-- [ ] **Step 2: Verify build**
-- [ ] **Step 3: Commit**
-
-```bash
-git commit -m "fix(UpdateInterface): guarantee unlock via try-finally (#22)"
-```
-
-### Task 4: handleUpdateView.ts
-
-**Files:**
-- Modify: `src/handlers/view/high/handleUpdateView.ts`
-
-- [ ] **Step 1: Refactor lock/unlock to try-finally**
-- [ ] **Step 2: Verify build**
-- [ ] **Step 3: Commit**
-
-```bash
-git commit -m "fix(UpdateView): guarantee unlock via try-finally (#22)"
-```
-
-### Task 5: handleUpdateTable.ts
-
-**Files:**
-- Modify: `src/handlers/table/high/handleUpdateTable.ts`
-
-- [ ] **Step 1: Refactor lock/unlock to try-finally**
-- [ ] **Step 2: Verify build**
-- [ ] **Step 3: Commit**
-
-```bash
-git commit -m "fix(UpdateTable): guarantee unlock via try-finally (#22)"
-```
-
-### Task 6: handleUpdateStructure.ts
-
-**Files:**
-- Modify: `src/handlers/structure/high/handleUpdateStructure.ts`
-
-- [ ] **Step 1: Refactor lock/unlock to try-finally**
-- [ ] **Step 2: Verify build**
-- [ ] **Step 3: Commit**
-
-```bash
-git commit -m "fix(UpdateStructure): guarantee unlock via try-finally (#22)"
-```
-
-### Task 7: handleUpdateDomain.ts
-
-**Files:**
-- Modify: `src/handlers/domain/high/handleUpdateDomain.ts`
-
-- [ ] **Step 1: Refactor lock/unlock to try-finally**
-- [ ] **Step 2: Verify build**
-- [ ] **Step 3: Commit**
-
-```bash
-git commit -m "fix(UpdateDomain): guarantee unlock via try-finally (#22)"
-```
-
-### Task 8: handleUpdateServiceDefinition.ts
-
-**Files:**
-- Modify: `src/handlers/service_definition/high/handleUpdateServiceDefinition.ts`
-
-- [ ] **Step 1: Refactor lock/unlock to try-finally**
-- [ ] **Step 2: Verify build**
-- [ ] **Step 3: Commit**
-
-```bash
-git commit -m "fix(UpdateServiceDefinition): guarantee unlock via try-finally (#22)"
-```
-
-### Task 9: handleUpdateDataElement.ts
-
-**Files:**
-- Modify: `src/handlers/data_element/high/handleUpdateDataElement.ts`
-
-- [ ] **Step 1: Refactor lock/unlock to try-finally**
-- [ ] **Step 2: Verify build**
-- [ ] **Step 3: Commit**
-
-```bash
-git commit -m "fix(UpdateDataElement): guarantee unlock via try-finally (#22)"
-```
-
-### Task 10: Final verification
-
-- [ ] **Step 1: Full build check**
-
-Run: `npx tsc --noEmit`
-
-- [ ] **Step 2: Squash into single commit**
-
-Squash all 9 fix commits into one:
-```bash
-git commit -m "fix: guarantee unlock via try-finally in all update handlers (#22)"
-```
-
-- [ ] **Step 3: Update CHANGELOG.md**
-
-Add entry under `[Unreleased]`:
-```markdown
-### Fixed
-- Guarantee unlock via `try-finally` in all update handlers — prevents locked objects when errors occur between lock and unlock (#22). Affected: UpdateProgram, UpdateClass, UpdateInterface, UpdateView, UpdateTable, UpdateStructure, UpdateDomain, UpdateServiceDefinition, UpdateDataElement.
-```