@mcp-abap-adt/connection 7.0.0 → 8.0.0

package/CHANGELOG.md

@@ -7,6 +7,62 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [8.0.0] - 2026-09-08
+
+**A consumer holding the contract can now do what the connection could always do.**
+
+### Changed
+
+- **BREAKING: onto `@mcp-abap-adt/interfaces@^39.0.0`**, from `^21.0.0`.
+  Seventeen majors, and the whole of it was eight compiler errors in one file.
+
+  - `makeAdtRequest` returns `IAdtWireResponse<T, D>`, not `IAdtResponse<T, D>`.
+    The two parted company when `IAdtResponse` became the result-or-failure
+    union a *member* answers, with `E extends IAdtError`; a connection answers
+    the raw HTTP shape, which is what `IAdtWireResponse` is. Six occurrences,
+    all of them the same rename — no behaviour moved.
+  - `isNetworkError` is this package's own again, in `src/utils/networkErrors.ts`.
+    `@mcp-abap-adt/interfaces` published it until 29.0.0, when that package
+    stopped emitting code: it holds types, interfaces and constants, and a
+    predicate is none of those. `NETWORK_ERROR_CODES` is still imported from
+    there — the codes are a constant, the judgement is not.
+
+### Added
+
+- **`flushGoodbye(timeoutMs?)`** — waits for the goodbye `disconnect()`
+  dispatched, within a budget.
+
+  `disconnect()` sends the logoff and does not await it, deliberately: a goodbye
+  carries no request timeout, and a server that never answers must not hold a
+  teardown open. That is right for a teardown and wrong for a reconnect —
+  `disconnect()` then `connect()` opens the next session while the previous
+  one's goodbye is still being assembled, and the server keeps both.
+
+  Measured on E19 through `@mcp-abap-adt/adt-clients`, whose harness recycled
+  the session after each test: a new ABAP session every one to two seconds for a
+  whole run, none released, each living to its own thirty-minute idle timeout.
+
+  The budget bounds the waiting, not the overlap: finishes in time and there is
+  none, does not and the caller proceeds while the goodbye stays outstanding.
+
+- **The connection declares the atoms it honours**: `ICriticalSection`,
+  `IRequestProfiling` and — through 39.0.0's addition to
+  `ISessionLifecycleAware` — `flushGoodbye`.
+
+  All four methods already existed here. What changed is that a consumer can
+  reach them: `AbapConnection` is `IAbapConnection`, so until now
+  `beginCriticalSection()`, `setProfilingRequest()` and `flushGoodbye()` were
+  reachable only by casting to the concrete class, which is the thing the
+  contracts package exists to make unnecessary.
+
+  A test narrows a connection to each atom from the base contract and calls
+  through it. Worth saying what that does and does not check: TypeScript is
+  structural, so removing an atom from the `implements` list changes nothing —
+  the class still has the methods. What the clause buys is the compiler
+  checking the class against the contract: removing `beginCriticalSection`
+  itself is `TS2420`, which is the failure worth having.
+
+
 ## [7.0.0] - 2026-09-08
 
 **Headers that belong to the request stop belonging to the session.**
@@ -1457,7 +1513,8 @@ const connection = createAbapConnection(config, logger);
 - JWT token refresh now properly handles connection errors (401/403 during initial connect)
 - Permission errors (403 with "ExceptionResourceNoAccess") no longer trigger JWT refresh loops
 - Proper separation: base class handles HTTP/session, concrete classes handle auth-specific errors
-[Unreleased]: https://github.com/fr0ster/mcp-abap-connection/compare/v7.0.0...HEAD
+[Unreleased]: https://github.com/fr0ster/mcp-abap-connection/compare/v8.0.0...HEAD
+[8.0.0]: https://github.com/fr0ster/mcp-abap-connection/compare/v7.0.0...v8.0.0
 [7.0.0]: https://github.com/fr0ster/mcp-abap-connection/compare/v6.1.0...v7.0.0
 [6.0.1]: https://github.com/fr0ster/mcp-abap-connection/compare/v6.0.0...v6.0.1
 [6.1.0]: https://github.com/fr0ster/mcp-abap-connection/compare/v6.0.1...v6.1.0

package/dist/connection/AbstractAbapConnection.d.ts

@@ -1,10 +1,10 @@
-import { type IAdtResponse, type ISessionLifecycleAware } from '@mcp-abap-adt/interfaces';
+import { type IAdtWireResponse, type ICriticalSection, type IRequestProfiling, type ISessionLifecycleAware } from '@mcp-abap-adt/interfaces';
 import type { SapConfig } from '../config/sapConfig.js';
 import type { ILogger } from '../logger.js';
 import { SessionLifecycle } from '../session/SessionLifecycle.js';
 import type { AbapConnection, AbapRequestOptions } from './AbapConnection.js';
 import { type IAdtSessionContext, type IAdtTransport } from './IAdtTransport.js';
-declare abstract class AbstractAbapConnection implements AbapConnection, ISessionLifecycleAware {
+declare abstract class AbstractAbapConnection implements AbapConnection, ISessionLifecycleAware, ICriticalSection, IRequestProfiling {
     private readonly config;
     /**
      * Required, and constructed by the caller.
@@ -53,6 +53,21 @@ declare abstract class AbstractAbapConnection implements AbapConnection, ISessio
      * raises the effective timeout to CRITICAL_SECTION_TIMEOUT (a large ceiling)
      * so the request runs to completion instead of being interrupted.
      */
+    /**
+     * The last goodbye this connection dispatched, so a caller can wait for it.
+     *
+     * `disconnect()` sends the logoff without awaiting it, for the reason stated
+     * there. That is right for a teardown and wrong for a caller who is about to
+     * `connect()` again: the next session opens while the previous one's goodbye
+     * is still being assembled, and a caller who recycles in a loop leaves one
+     * abandoned session per iteration. Measured against E19 from
+     * `@mcp-abap-adt/adt-clients`: a session every 1-2 seconds for a whole test
+     * run, none of them released, each surviving to its 30-minute idle timeout.
+     *
+     * Keeping it costs nothing and is the only thing a caller can hold on to —
+     * before this, the promise was created and dropped on the floor.
+     */
+    private goodbye;
     private inCriticalSection;
     /** Reference count for nested beginCriticalSection()/endCriticalSection() pairs. */
     private criticalSectionDepth;
@@ -241,6 +256,22 @@ declare abstract class AbstractAbapConnection implements AbapConnection, ISessio
      * timeout by design.
      */
     disconnect(): Promise<void>;
+    /**
+     * Wait for the last dispatched goodbye, bounded.
+     *
+     * For the caller who ends a session and immediately opens another. Without
+     * it the two overlap and the server keeps both; with it the previous session
+     * is gone — or known not to be going — before the next one is asked for.
+     *
+     * Bounded because the goodbye deliberately carries no request timeout: a
+     * server that never answers must not hold a teardown open, and it must not
+     * hold this open either. On expiry this returns rather than throwing, since
+     * "the goodbye has not arrived yet" is not a failure of the caller's next
+     * step — and the session it addressed will fall to the idle timeout anyway.
+     *
+     * Safe to call at any time: with nothing dispatched it returns immediately.
+     */
+    flushGoodbye(timeoutMs?: number): Promise<void>;
     isConnected(): boolean;
     /**
      * Fingerprint of the SAP-side session, or null when none is known.
@@ -396,7 +427,7 @@ declare abstract class AbstractAbapConnection implements AbapConnection, ISessio
     protected sessionFingerprint(): Map<string, string>;
     getBaseUrl(): Promise<string>;
     getAuthHeaders(): Promise<Record<string, string>>;
-    makeAdtRequest<T = any, D = any>(options: AbapRequestOptions): Promise<IAdtResponse<T, D>>;
+    makeAdtRequest<T = any, D = any>(options: AbapRequestOptions): Promise<IAdtWireResponse<T, D>>;
     private performRequest;
     protected abstract buildAuthorizationHeader(): string;
     /**

package/dist/connection/AbstractAbapConnection.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"AbstractAbapConnection.d.ts","sourceRoot":"","sources":["../../src/connection/AbstractAbapConnection.ts"],"names":[],"mappings":"AAEA,OAAO,EAEL,KAAK,YAAY,EACjB,KAAK,sBAAsB,EAE5B,MAAM,0BAA0B,CAAC;AAMlC,OAAO,KAAK,EAAE,SAAS,EAAE,MAAM,wBAAwB,CAAC;AACxD,OAAO,KAAK,EAAE,OAAO,EAAE,MAAM,cAAc,CAAC;AAC5C,OAAO,EAEL,gBAAgB,EAEjB,MAAM,gCAAgC,CAAC;AAExC,OAAO,KAAK,EAAE,cAAc,EAAE,kBAAkB,EAAE,MAAM,qBAAqB,CAAC;AAE9E,OAAO,EACL,KAAK,kBAAkB,EACvB,KAAK,aAAa,EAGnB,MAAM,oBAAoB,CAAC;AAqC5B,uBAAe,sBACb,YAAW,cAAc,EAAE,sBAAsB;IAuF/C,OAAO,CAAC,QAAQ,CAAC,MAAM;IACvB;;;;;;;;OAQG;IACH,QAAQ,CAAC,SAAS,EAAE,aAAa;IACjC,SAAS,CAAC,QAAQ,CAAC,MAAM,EAAE,OAAO,GAAG,IAAI;IAhG3C;;;;OAIG;IACH,SAAS,CAAC,QAAQ,CAAC,SAAS,mBAA0B;IAEtD,OAAO,CAAC,OAAO,CAAS;IACxB,OAAO,CAAC,SAAS,CAAuB;IACxC,OAAO,CAAC,WAAW,CAAyC;IAE5D;;;;;;;;;;;;;;OAcG;IACH,OAAO,CAAC,gBAAgB,CAAgC;IACxD;;;;;;;;;;OAUG;IACH,OAAO,CAAC,iBAAiB,CAAS;IAClC,oFAAoF;IACpF,OAAO,CAAC,oBAAoB,CAAK;IACjC,oEAAoE;IACpE;;;;;;;;;;;;;;OAcG;IACH;;;;OAIG;IACH;;;;;;;;;;;;OAYG;IACH;;;;;;;OAOG;IAEH,SAAS,aACU,MAAM,EAAE,SAAS;IAClC;;;;;;;;OAQG;IACM,SAAS,EAAE,aAAa,EACd,MAAM,EAAE,OAAO,GAAG,IAAI,EACzC,SAAS,CAAC,EAAE,MAAM;IAoBpB;;;;;;;;;;OAUG;IACH,cAAc,CAAC,IAAI,EAAE,UAAU,GAAG,WAAW,GAAG,IAAI;IAOpD;;OAEG;IACH,cAAc,IAAI,WAAW,GAAG,UAAU;IAI1C;;;;OAIG;IACH,mBAAmB,CAAC,IAAI,EAAE,MAAM,GAAG,IAAI,GAAG,IAAI;IAI9C,oDAAoD;IACpD,mBAAmB,IAAI,MAAM,GAAG,IAAI;IAIpC;;;;;;;;;;;;;;OAcG;IACH,oBAAoB,IAAI,IAAI;IAQ5B;;;;OAIG;IACH,kBAAkB,IAAI,IAAI;IAY1B;;OAEG;IACH,mBAAmB,IAAI,OAAO;IAI9B;;;OAGG;IACH,YAAY,CAAC,SAAS,EAAE,MAAM,GAAG,IAAI;IAKrC;;OAEG;IACH,YAAY,IAAI,MAAM,GAAG,IAAI;IAI7B,SAAS,IAAI,SAAS;IAItB;;;OAGG;IACH,SAAS,CAAC,QAAQ,CAAC,gBAAgB,IAAI,OAAO,CAAC,IAAI,CAAC;IAEpD;;;;;;;;;;;;;;;;;;;OAmBG;cACa,iBAAiB,IAAI,OAAO,CAAC,IAAI,CAAC;IAElD;;;;;;;;OAQG;IACG,OAAO,IAAI,OAAO,CAAC,IAAI,CAAC;IAoB9B;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;OAkCG;IACG,UAAU,IAAI,OAAO,CAAC,IAAI,CAAC;IAkCjC,WAAW,IAAI,OAAO;IAItB;;;;;;;;;OASG;IACH,kBAAkB,IAAI,MAAM,GAAG,IAAI;IAInC;;;;;;;;;;;;OAYG;cACa,cAAc,CAAC,aAAa,EAAE,MAAM,GAAG,OAAO,CAAC,IAAI,CAAC;IAMpE;;;;;;;;;;;;OAYG;IACH;;;;OAIG;IAEH;;;;;;;;;OASG;IAEH;;;;;;OAMG;IACH,SAAS,CAAC,cAAc,IAAI,kBAAkB;YAUhC,kBAAkB;IAqJhC,sEAAsE;IACtE,SAAS,KAAK,aAAa,IAAI,MAAM,CAEpC;IAED;;;;;;OAMG;IACH,SAAS,KAAK,iBAAiB,IAAI,MAAM,CAExC;IAED;;;;;;;;;;;;;;;;;;;OAmBG;IACH,SAAS,CAAC,gBAAgB,CAAC,MAAM,EAAE,MAAM,GAAG,IAAI;IAShD,6DAA6D;IAC7D,SAAS,CAAC,cAAc,IAAI,IAAI;IAIhC;;;;;;;OAOG;IACH,SAAS,CAAC,gBAAgB,CAAC,KAAK,EAAE,OAAO,GAAG,OAAO;IASnD;;;;;;;;OAQG;IACH,SAAS,CAAC,eAAe,CACvB,OAAO,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,EACjC,UAAU,CAAC,EAAE,MAAM,GAClB,IAAI;IA2BP;;;;;;;;;;;;;;;OAeG;IACH,OAAO,CAAC,mBAAmB;IAc3B;;;;;;;;OAQG;IACH,OAAO,CAAC,qBAAqB;IAc7B,+EAA+E;IAC/E,OAAO,CAAC,iBAAiB;IASzB;;;;;;;OAOG;IACH,SAAS,CAAC,kBAAkB,IAAI,GAAG,CAAC,MAAM,EAAE,MAAM,CAAC;IAI7C,UAAU,IAAI,OAAO,CAAC,MAAM,CAAC;IAI7B,cAAc,IAAI,OAAO,CAAC,MAAM,CAAC,MAAM,EAAE,MAAM,CAAC,CAAC;IAejD,cAAc,CAAC,CAAC,GAAG,GAAG,EAAE,CAAC,GAAG,GAAG,EACnC,OAAO,EAAE,kBAAkB,GAC1B,OAAO,CAAC,YAAY,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC;YAchB,cAAc;IAuY5B,SAAS,CAAC,QAAQ,CAAC,wBAAwB,IAAI,MAAM;IAErD;;;;;;;;OAQG;cACa,cAAc,CAC5B,IAAI,EAAE,MAAM,EACZ,UAAU,GAAE,MAAgC,EAC5C,UAAU,GAAE,MAAgC;IAC5C,iFAAiF;IACjF,UAAU,CAAC,EAAE,MAAM,GAClB,OAAO,CAAC,MAAM,CAAC;IAqBlB,SAAS,CAAC,YAAY,IAAI,MAAM,GAAG,IAAI;IAIvC;;OAEG;IACH,SAAS,CAAC,YAAY,CAAC,KAAK,EAAE,MAAM,GAAG,IAAI,GAAG,IAAI;IAMlD;;OAEG;IACH,SAAS,CAAC,UAAU,IAAI,MAAM,GAAG,IAAI;IAIrC;;;;;;OAMG;IACH,SAAS,CAAC,iBAAiB,CAAC,OAAO,EAAE,MAAM,GAAG,IAAI;IAMlD;;;;OAIG;IACH,SAAS,CAAC,oBAAoB,IAAI,OAAO,YAAY,EAAE,YAAY;IAInE;;;;;;;;OAQG;YACW,eAAe;IAW7B;;;;;;;;OAQG;IACH,OAAO,CAAC,iBAAiB;IAiBzB,OAAO,CAAC,eAAe;CA6BxB;AAED,OAAO,EAAE,sBAAsB,EAAE,CAAC"}
+{"version":3,"file":"AbstractAbapConnection.d.ts","sourceRoot":"","sources":["../../src/connection/AbstractAbapConnection.ts"],"names":[],"mappings":"AAEA,OAAO,EAEL,KAAK,gBAAgB,EACrB,KAAK,gBAAgB,EACrB,KAAK,iBAAiB,EACtB,KAAK,sBAAsB,EAC5B,MAAM,0BAA0B,CAAC;AAMlC,OAAO,KAAK,EAAE,SAAS,EAAE,MAAM,wBAAwB,CAAC;AACxD,OAAO,KAAK,EAAE,OAAO,EAAE,MAAM,cAAc,CAAC;AAC5C,OAAO,EAEL,gBAAgB,EAEjB,MAAM,gCAAgC,CAAC;AAGxC,OAAO,KAAK,EAAE,cAAc,EAAE,kBAAkB,EAAE,MAAM,qBAAqB,CAAC;AAE9E,OAAO,EACL,KAAK,kBAAkB,EACvB,KAAK,aAAa,EAGnB,MAAM,oBAAoB,CAAC;AAqC5B,uBAAe,sBACb,YACE,cAAc,EACd,sBAAsB,EACtB,gBAAgB,EAChB,iBAAiB;IAuGjB,OAAO,CAAC,QAAQ,CAAC,MAAM;IACvB;;;;;;;;OAQG;IACH,QAAQ,CAAC,SAAS,EAAE,aAAa;IACjC,SAAS,CAAC,QAAQ,CAAC,MAAM,EAAE,OAAO,GAAG,IAAI;IAhH3C;;;;OAIG;IACH,SAAS,CAAC,QAAQ,CAAC,SAAS,mBAA0B;IAEtD,OAAO,CAAC,OAAO,CAAS;IACxB,OAAO,CAAC,SAAS,CAAuB;IACxC,OAAO,CAAC,WAAW,CAAyC;IAE5D;;;;;;;;;;;;;;OAcG;IACH,OAAO,CAAC,gBAAgB,CAAgC;IACxD;;;;;;;;;;OAUG;IACH;;;;;;;;;;;;;OAaG;IACH,OAAO,CAAC,OAAO,CAAoC;IAEnD,OAAO,CAAC,iBAAiB,CAAS;IAClC,oFAAoF;IACpF,OAAO,CAAC,oBAAoB,CAAK;IACjC,oEAAoE;IACpE;;;;;;;;;;;;;;OAcG;IACH;;;;OAIG;IACH;;;;;;;;;;;;OAYG;IACH;;;;;;;OAOG;IAEH,SAAS,aACU,MAAM,EAAE,SAAS;IAClC;;;;;;;;OAQG;IACM,SAAS,EAAE,aAAa,EACd,MAAM,EAAE,OAAO,GAAG,IAAI,EACzC,SAAS,CAAC,EAAE,MAAM;IAoBpB;;;;;;;;;;OAUG;IACH,cAAc,CAAC,IAAI,EAAE,UAAU,GAAG,WAAW,GAAG,IAAI;IAOpD;;OAEG;IACH,cAAc,IAAI,WAAW,GAAG,UAAU;IAI1C;;;;OAIG;IACH,mBAAmB,CAAC,IAAI,EAAE,MAAM,GAAG,IAAI,GAAG,IAAI;IAI9C,oDAAoD;IACpD,mBAAmB,IAAI,MAAM,GAAG,IAAI;IAIpC;;;;;;;;;;;;;;OAcG;IACH,oBAAoB,IAAI,IAAI;IAQ5B;;;;OAIG;IACH,kBAAkB,IAAI,IAAI;IAY1B;;OAEG;IACH,mBAAmB,IAAI,OAAO;IAI9B;;;OAGG;IACH,YAAY,CAAC,SAAS,EAAE,MAAM,GAAG,IAAI;IAKrC;;OAEG;IACH,YAAY,IAAI,MAAM,GAAG,IAAI;IAI7B,SAAS,IAAI,SAAS;IAItB;;;OAGG;IACH,SAAS,CAAC,QAAQ,CAAC,gBAAgB,IAAI,OAAO,CAAC,IAAI,CAAC;IAEpD;;;;;;;;;;;;;;;;;;;OAmBG;cACa,iBAAiB,IAAI,OAAO,CAAC,IAAI,CAAC;IAElD;;;;;;;;OAQG;IACG,OAAO,IAAI,OAAO,CAAC,IAAI,CAAC;IAoB9B;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;OAkCG;IACG,UAAU,IAAI,OAAO,CAAC,IAAI,CAAC;IAuCjC;;;;;;;;;;;;;;OAcG;IACG,YAAY,CAAC,SAAS,SAAO,GAAG,OAAO,CAAC,IAAI,CAAC;IAgBnD,WAAW,IAAI,OAAO;IAItB;;;;;;;;;OASG;IACH,kBAAkB,IAAI,MAAM,GAAG,IAAI;IAInC;;;;;;;;;;;;OAYG;cACa,cAAc,CAAC,aAAa,EAAE,MAAM,GAAG,OAAO,CAAC,IAAI,CAAC;IAMpE;;;;;;;;;;;;OAYG;IACH;;;;OAIG;IAEH;;;;;;;;;OASG;IAEH;;;;;;OAMG;IACH,SAAS,CAAC,cAAc,IAAI,kBAAkB;YAUhC,kBAAkB;IAqJhC,sEAAsE;IACtE,SAAS,KAAK,aAAa,IAAI,MAAM,CAEpC;IAED;;;;;;OAMG;IACH,SAAS,KAAK,iBAAiB,IAAI,MAAM,CAExC;IAED;;;;;;;;;;;;;;;;;;;OAmBG;IACH,SAAS,CAAC,gBAAgB,CAAC,MAAM,EAAE,MAAM,GAAG,IAAI;IAShD,6DAA6D;IAC7D,SAAS,CAAC,cAAc,IAAI,IAAI;IAIhC;;;;;;;OAOG;IACH,SAAS,CAAC,gBAAgB,CAAC,KAAK,EAAE,OAAO,GAAG,OAAO;IASnD;;;;;;;;OAQG;IACH,SAAS,CAAC,eAAe,CACvB,OAAO,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,EACjC,UAAU,CAAC,EAAE,MAAM,GAClB,IAAI;IA2BP;;;;;;;;;;;;;;;OAeG;IACH,OAAO,CAAC,mBAAmB;IAc3B;;;;;;;;OAQG;IACH,OAAO,CAAC,qBAAqB;IAc7B,+EAA+E;IAC/E,OAAO,CAAC,iBAAiB;IASzB;;;;;;;OAOG;IACH,SAAS,CAAC,kBAAkB,IAAI,GAAG,CAAC,MAAM,EAAE,MAAM,CAAC;IAI7C,UAAU,IAAI,OAAO,CAAC,MAAM,CAAC;IAI7B,cAAc,IAAI,OAAO,CAAC,MAAM,CAAC,MAAM,EAAE,MAAM,CAAC,CAAC;IAejD,cAAc,CAAC,CAAC,GAAG,GAAG,EAAE,CAAC,GAAG,GAAG,EACnC,OAAO,EAAE,kBAAkB,GAC1B,OAAO,CAAC,gBAAgB,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC;YAcpB,cAAc;IAuY5B,SAAS,CAAC,QAAQ,CAAC,wBAAwB,IAAI,MAAM;IAErD;;;;;;;;OAQG;cACa,cAAc,CAC5B,IAAI,EAAE,MAAM,EACZ,UAAU,GAAE,MAAgC,EAC5C,UAAU,GAAE,MAAgC;IAC5C,iFAAiF;IACjF,UAAU,CAAC,EAAE,MAAM,GAClB,OAAO,CAAC,MAAM,CAAC;IAqBlB,SAAS,CAAC,YAAY,IAAI,MAAM,GAAG,IAAI;IAIvC;;OAEG;IACH,SAAS,CAAC,YAAY,CAAC,KAAK,EAAE,MAAM,GAAG,IAAI,GAAG,IAAI;IAMlD;;OAEG;IACH,SAAS,CAAC,UAAU,IAAI,MAAM,GAAG,IAAI;IAIrC;;;;;;OAMG;IACH,SAAS,CAAC,iBAAiB,CAAC,OAAO,EAAE,MAAM,GAAG,IAAI;IAMlD;;;;OAIG;IACH,SAAS,CAAC,oBAAoB,IAAI,OAAO,YAAY,EAAE,YAAY;IAInE;;;;;;;;OAQG;YACW,eAAe;IAW7B;;;;;;;;OAQG;IACH,OAAO,CAAC,iBAAiB;IAiBzB,OAAO,CAAC,eAAe;CA6BxB;AAED,OAAO,EAAE,sBAAsB,EAAE,CAAC"}

package/dist/connection/AbstractAbapConnection.js

@@ -4,6 +4,7 @@ exports.AbstractAbapConnection = void 0;
 const node_crypto_1 = require("node:crypto");
 const interfaces_1 = require("@mcp-abap-adt/interfaces");
 const SessionLifecycle_js_1 = require("../session/SessionLifecycle.js");
+const networkErrors_js_1 = require("../utils/networkErrors.js");
 const timeouts_js_1 = require("../utils/timeouts.js");
 const csrfConfig_js_1 = require("./csrfConfig.js");
 const IAdtTransport_js_1 = require("./IAdtTransport.js");
@@ -81,6 +82,21 @@ class AbstractAbapConnection {
      * raises the effective timeout to CRITICAL_SECTION_TIMEOUT (a large ceiling)
      * so the request runs to completion instead of being interrupted.
      */
+    /**
+     * The last goodbye this connection dispatched, so a caller can wait for it.
+     *
+     * `disconnect()` sends the logoff without awaiting it, for the reason stated
+     * there. That is right for a teardown and wrong for a caller who is about to
+     * `connect()` again: the next session opens while the previous one's goodbye
+     * is still being assembled, and a caller who recycles in a loop leaves one
+     * abandoned session per iteration. Measured against E19 from
+     * `@mcp-abap-adt/adt-clients`: a session every 1-2 seconds for a whole test
+     * run, none of them released, each surviving to its 30-minute idle timeout.
+     *
+     * Keeping it costs nothing and is the only thing a caller can hold on to —
+     * before this, the promise was created and dropped on the floor.
+     */
+    goodbye = Promise.resolve();
     inCriticalSection = false;
     /** Reference count for nested beginCriticalSection()/endCriticalSection() pairs. */
     criticalSectionDepth = 0;
@@ -350,11 +366,47 @@ class AbstractAbapConnection {
             // The context is taken now, while the session is still true: the clear
             // below runs while the close is suspended on its first await.
             const context = this.sessionContext();
-            const inFlight = Promise.resolve(this.transport.close(context)).then(() => undefined);
+            // Kept, not dropped: `flushGoodbye()` is how a caller who is about to
+            // reconnect waits for it. Rejections are absorbed here so that holding
+            // the promise never turns a failed goodbye into an unhandled rejection —
+            // the transport already logs what went wrong.
+            this.goodbye = Promise.resolve(this.transport.close(context)).then(() => undefined, () => undefined);
             this.clearSessionState();
             this.lifecycle.markDisconnected();
         });
     }
+    /**
+     * Wait for the last dispatched goodbye, bounded.
+     *
+     * For the caller who ends a session and immediately opens another. Without
+     * it the two overlap and the server keeps both; with it the previous session
+     * is gone — or known not to be going — before the next one is asked for.
+     *
+     * Bounded because the goodbye deliberately carries no request timeout: a
+     * server that never answers must not hold a teardown open, and it must not
+     * hold this open either. On expiry this returns rather than throwing, since
+     * "the goodbye has not arrived yet" is not a failure of the caller's next
+     * step — and the session it addressed will fall to the idle timeout anyway.
+     *
+     * Safe to call at any time: with nothing dispatched it returns immediately.
+     */
+    async flushGoodbye(timeoutMs = 5000) {
+        let timer;
+        try {
+            await Promise.race([
+                this.goodbye,
+                new Promise((resolve) => {
+                    timer = setTimeout(resolve, timeoutMs);
+                    // Never hold the process open for a goodbye nobody is waiting on.
+                    timer.unref?.();
+                }),
+            ]);
+        }
+        finally {
+            if (timer)
+                clearTimeout(timer);
+        }
+    }
     isConnected() {
         return this.lifecycle.connected;
     }
@@ -927,7 +979,7 @@ class AbstractAbapConnection {
             }
             // Check if this is a network error (connection refused, timeout, DNS, etc.)
             // Don't retry for network errors - these indicate infrastructure/VPN issues
-            const networkError = (0, interfaces_1.isNetworkError)(error);
+            const networkError = (0, networkErrors_js_1.isNetworkError)(error);
             if (networkError) {
                 this.logger?.error(`Network error - cannot connect to SAP system: ${errorDetails.message}`, errorDetails);
                 throw error;

package/dist/utils/networkErrors.d.ts

@@ -0,0 +1,2 @@
+export declare function isNetworkError(error: unknown): boolean;
+//# sourceMappingURL=networkErrors.d.ts.map

package/dist/utils/networkErrors.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"networkErrors.d.ts","sourceRoot":"","sources":["../../src/utils/networkErrors.ts"],"names":[],"mappings":"AAkBA,wBAAgB,cAAc,CAAC,KAAK,EAAE,OAAO,GAAG,OAAO,CAItD"}

package/dist/utils/networkErrors.js

@@ -0,0 +1,25 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.isNetworkError = isNetworkError;
+/**
+ * Whether an error is the network's rather than the server's.
+ *
+ * `@mcp-abap-adt/interfaces` published this as a function until 29.0.0, when
+ * that package stopped emitting code: it holds types, interfaces and constants,
+ * and a predicate is none of those. The codes are still there —
+ * {@link NETWORK_ERROR_CODES} — and the judgement lives here, with the wire it
+ * judges.
+ *
+ * The distinction is not cosmetic. A refusal from SAP is an answer and can be
+ * retried once a token is refreshed; `ECONNREFUSED` is a statement about
+ * infrastructure, and retrying it re-runs the same failure against the same
+ * unreachable host.
+ */
+const interfaces_1 = require("@mcp-abap-adt/interfaces");
+const CODES = new Set(Object.values(interfaces_1.NETWORK_ERROR_CODES));
+function isNetworkError(error) {
+    if (!error || typeof error !== 'object')
+        return false;
+    const code = error.code;
+    return typeof code === 'string' && CODES.has(code);
+}

package/docs/MIGRATION-6.0.md

@@ -294,7 +294,7 @@ session was negotiated elsewhere:
 ```typescript
 import type { IAuthProvider, IRenewableCredential } from '@mcp-abap-adt/interfaces';
 
-function isRenewable(c: IAuthProvider): c is IRenewableCredential {
+function isRenewable(c: IAuthProvider): c is IAuthProvider & IRenewableCredential {
   return typeof (c as Partial<IRenewableCredential>).renew === 'function';
 }
 ```

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mcp-abap-adt/connection",
-  "version": "7.0.0",
+  "version": "8.0.0",
   "description": "ABAP connection layer for MCP ABAP ADT server",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
@@ -53,7 +53,7 @@
     "node": ">=18.0.0"
   },
   "dependencies": {
-    "@mcp-abap-adt/interfaces": "^21.0.0",
+    "@mcp-abap-adt/interfaces": "^39.0.0",
     "axios": "^1.16.0",
     "commander": "^14.0.3",
     "open": "^11.0.0"