@mcp-abap-adt/connection 1.5.2 → 1.6.0

package/README.md

@@ -1,5 +1,7 @@
 # @mcp-abap-adt/connection
 
+[![Stand With Ukraine](https://raw.githubusercontent.com/vshymanskyy/StandWithUkraine/main/badges/StandWithUkraine.svg)](https://stand-with-ukraine.pp.ua)
+
 ABAP connection layer for MCP ABAP ADT server. Provides a unified interface for connecting to SAP ABAP systems via ADT (ABAP Development Tools) protocol, supporting both on-premise (Basic Auth) and cloud (JWT/OAuth2) authentication methods.
 
 ## Key Features

package/dist/connection/RfcAbapConnection.d.ts

@@ -5,7 +5,7 @@ import type { AbapConnection } from './AbapConnection.js';
 /**
  * RFC-based connection for on-premise SAP systems.
  *
- * Uses node-rfc to call SADT_REST_RFC_ENDPOINT — the same standard SAP FM
+ * Uses @mcp-abap-adt/sap-rfc-lite to call SADT_REST_RFC_ENDPOINT — the same standard SAP FM
  * that Eclipse ADT uses for all on-premise ADT operations via JCo.
  *
  * RFC connections are inherently stateful: one ABAP session persists for the
@@ -18,7 +18,7 @@ import type { AbapConnection } from './AbapConnection.js';
  *
  * Prerequisites:
  *   - SAP NW RFC SDK installed on the machine
- *   - node-rfc package installed: npm install node-rfc
+ *   - @mcp-abap-adt/sap-rfc-lite package installed: npm install @mcp-abap-adt/sap-rfc-lite
  */
 export declare class RfcAbapConnection implements AbapConnection {
     private readonly config;
@@ -27,11 +27,13 @@ export declare class RfcAbapConnection implements AbapConnection {
     private readonly sessionId;
     private readonly baseUrl;
     private readonly rfcParams;
+    private sessionType;
+    private sessionCookie;
     constructor(config: SapConfig, logger?: ILogger | null);
     connect(): Promise<void>;
     getBaseUrl(): Promise<string>;
     getSessionId(): string | null;
-    setSessionType(_type: 'stateful' | 'stateless'): void;
+    setSessionType(type: 'stateful' | 'stateless'): void;
     makeAdtRequest<T = any, D = any>(options: IAbapRequestOptions): Promise<IAdtResponse<T, D>>;
     /**
      * Reset the connection — for RFC this closes the session.

package/dist/connection/RfcAbapConnection.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"RfcAbapConnection.d.ts","sourceRoot":"","sources":["../../src/connection/RfcAbapConnection.ts"],"names":[],"mappings":"AACA,OAAO,KAAK,EACV,mBAAmB,EACnB,YAAY,EACb,MAAM,0BAA0B,CAAC;AAClC,OAAO,KAAK,EAAE,SAAS,EAAE,MAAM,wBAAwB,CAAC;AACxD,OAAO,KAAK,EAAE,OAAO,EAAE,MAAM,cAAc,CAAC;AAC5C,OAAO,KAAK,EAAE,cAAc,EAAE,MAAM,qBAAqB,CAAC;AA0F1D;;;;;;;;;;;;;;;;;GAiBG;AACH,qBAAa,iBAAkB,YAAW,cAAc;IAOpD,OAAO,CAAC,QAAQ,CAAC,MAAM;IACvB,OAAO,CAAC,QAAQ,CAAC,MAAM;IAPzB,OAAO,CAAC,SAAS,CAA2B;IAC5C,OAAO,CAAC,QAAQ,CAAC,SAAS,CAAS;IACnC,OAAO,CAAC,QAAQ,CAAC,OAAO,CAAS;IACjC,OAAO,CAAC,QAAQ,CAAC,SAAS,CAAsB;gBAG7B,MAAM,EAAE,SAAS,EACjB,MAAM,GAAE,OAAO,GAAG,IAAW;IAa1C,OAAO,IAAI,OAAO,CAAC,IAAI,CAAC;IA8BxB,UAAU,IAAI,OAAO,CAAC,MAAM,CAAC;IAInC,YAAY,IAAI,MAAM,GAAG,IAAI;IAI7B,cAAc,CAAC,KAAK,EAAE,UAAU,GAAG,WAAW,GAAG,IAAI;IAI/C,cAAc,CAAC,CAAC,GAAG,GAAG,EAAE,CAAC,GAAG,GAAG,EACnC,OAAO,EAAE,mBAAmB,GAC3B,OAAO,CAAC,YAAY,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC;IA6J9B;;;OAGG;IACH,KAAK,IAAI,IAAI;IAIb;;OAEG;IACG,KAAK,IAAI,OAAO,CAAC,IAAI,CAAC;IAc5B,OAAO,CAAC,MAAM,CAAC,cAAc;CAqB9B"}
+{"version":3,"file":"RfcAbapConnection.d.ts","sourceRoot":"","sources":["../../src/connection/RfcAbapConnection.ts"],"names":[],"mappings":"AACA,OAAO,KAAK,EACV,mBAAmB,EACnB,YAAY,EACb,MAAM,0BAA0B,CAAC;AAClC,OAAO,KAAK,EAAE,SAAS,EAAE,MAAM,wBAAwB,CAAC;AACxD,OAAO,KAAK,EAAE,OAAO,EAAE,MAAM,cAAc,CAAC;AAC5C,OAAO,KAAK,EAAE,cAAc,EAAE,MAAM,qBAAqB,CAAC;AA0F1D;;;;;;;;;;;;;;;;;GAiBG;AACH,qBAAa,iBAAkB,YAAW,cAAc;IASpD,OAAO,CAAC,QAAQ,CAAC,MAAM;IACvB,OAAO,CAAC,QAAQ,CAAC,MAAM;IATzB,OAAO,CAAC,SAAS,CAA2B;IAC5C,OAAO,CAAC,QAAQ,CAAC,SAAS,CAAS;IACnC,OAAO,CAAC,QAAQ,CAAC,OAAO,CAAS;IACjC,OAAO,CAAC,QAAQ,CAAC,SAAS,CAAsB;IAChD,OAAO,CAAC,WAAW,CAAyC;IAC5D,OAAO,CAAC,aAAa,CAAuB;gBAGzB,MAAM,EAAE,SAAS,EACjB,MAAM,GAAE,OAAO,GAAG,IAAW;IAa1C,OAAO,IAAI,OAAO,CAAC,IAAI,CAAC;IA8BxB,UAAU,IAAI,OAAO,CAAC,MAAM,CAAC;IAInC,YAAY,IAAI,MAAM,GAAG,IAAI;IAI7B,cAAc,CAAC,IAAI,EAAE,UAAU,GAAG,WAAW,GAAG,IAAI;IAU9C,cAAc,CAAC,CAAC,GAAG,GAAG,EAAE,CAAC,GAAG,GAAG,EACnC,OAAO,EAAE,mBAAmB,GAC3B,OAAO,CAAC,YAAY,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC;IA8L9B;;;OAGG;IACH,KAAK,IAAI,IAAI;IAIb;;OAEG;IACG,KAAK,IAAI,OAAO,CAAC,IAAI,CAAC;IAc5B,OAAO,CAAC,MAAM,CAAC,cAAc;CAqB9B"}

package/dist/connection/RfcAbapConnection.js

@@ -59,7 +59,7 @@ function detectExceptionStatus(body) {
 /**
  * RFC-based connection for on-premise SAP systems.
  *
- * Uses node-rfc to call SADT_REST_RFC_ENDPOINT — the same standard SAP FM
+ * Uses @mcp-abap-adt/sap-rfc-lite to call SADT_REST_RFC_ENDPOINT — the same standard SAP FM
  * that Eclipse ADT uses for all on-premise ADT operations via JCo.
  *
  * RFC connections are inherently stateful: one ABAP session persists for the
@@ -72,7 +72,7 @@ function detectExceptionStatus(body) {
  *
  * Prerequisites:
  *   - SAP NW RFC SDK installed on the machine
- *   - node-rfc package installed: npm install node-rfc
+ *   - @mcp-abap-adt/sap-rfc-lite package installed: npm install @mcp-abap-adt/sap-rfc-lite
  */
 class RfcAbapConnection {
     config;
@@ -81,6 +81,8 @@ class RfcAbapConnection {
     sessionId;
     baseUrl;
     rfcParams;
+    sessionType = 'stateless';
+    sessionCookie = null;
     constructor(config, logger = null) {
         this.config = config;
         this.logger = logger;
@@ -93,16 +95,16 @@ class RfcAbapConnection {
     async connect() {
         let Client;
         try {
-            // Dynamic require — node-rfc is NOT a declared dependency.
+            // Dynamic require — @mcp-abap-adt/sap-rfc-lite is NOT a declared dependency.
             // Users who need RFC connections must install it manually:
-            //   npm install node-rfc (+ SAP NW RFC SDK on the machine)
+            //   npm install @mcp-abap-adt/sap-rfc-lite (+ SAP NW RFC SDK on the machine)
             // eslint-disable-next-line @typescript-eslint/no-require-imports
-            const noderfc = require('node-rfc');
+            const noderfc = require('@mcp-abap-adt/sap-rfc-lite');
             Client = noderfc.Client;
         }
         catch (e) {
-            throw new Error('node-rfc is not available. To use RFC connections, install SAP NW RFC SDK ' +
-                'and run: npm install node-rfc. ' +
+            throw new Error('@mcp-abap-adt/sap-rfc-lite is not available. To use RFC connections, install SAP NW RFC SDK ' +
+                'and run: npm install @mcp-abap-adt/sap-rfc-lite. ' +
                 `Details: ${e instanceof Error ? e.message : String(e)}`);
         }
         this.rfcClient = new Client(this.rfcParams);
@@ -123,8 +125,15 @@ class RfcAbapConnection {
     getSessionId() {
         return this.sessionId;
     }
-    setSessionType(_type) {
-        // No-op — RFC connections are always stateful
+    setSessionType(type) {
+        this.sessionType = type;
+        if (type === 'stateless') {
+            this.sessionCookie = null;
+            this.logger?.debug('RFC session type: stateless (cookie cleared)');
+        }
+        else {
+            this.logger?.debug('RFC session type: stateful (will capture cookies)');
+        }
     }
     async makeAdtRequest(options) {
         if (!this.rfcClient?.alive) {
@@ -152,6 +161,17 @@ class RfcAbapConnection {
                 headerFields.push({ NAME: name, VALUE: value });
             }
         }
+        // Inject session type header so SAP creates/maintains an ICM session
+        if (this.sessionType === 'stateful') {
+            headerFields.push({ NAME: 'x-sap-adt-sessiontype', VALUE: 'stateful' });
+        }
+        // Replay session cookie for stateful operations (cookie captured from LOCK response)
+        if (this.sessionCookie) {
+            const existingCookie = headerFields.find((h) => h.NAME.toLowerCase() === 'cookie');
+            if (!existingCookie) {
+                headerFields.push({ NAME: 'Cookie', VALUE: this.sessionCookie });
+            }
+        }
         // Ensure Content-Type for body
         const body = options.data !== undefined && options.data !== null
             ? String(options.data)
@@ -204,6 +224,21 @@ class RfcAbapConnection {
                     respHeaders[field.NAME.toLowerCase()] = field.VALUE;
                 }
             }
+            // Capture session cookie from LOCK/stateful responses for cookie replay
+            if (this.sessionType === 'stateful' && respHeaders['set-cookie']) {
+                const setCookieHeader = respHeaders['set-cookie'];
+                // Extract cookie name=value pairs (strip attributes like Path, Secure, etc.)
+                const cookies = Array.isArray(setCookieHeader)
+                    ? setCookieHeader
+                    : [setCookieHeader];
+                const cookieValues = cookies
+                    .map((c) => c.split(';')[0].trim())
+                    .filter(Boolean);
+                if (cookieValues.length > 0) {
+                    this.sessionCookie = cookieValues.join('; ');
+                    this.logger?.debug(`RFC: captured session cookie: ${this.sessionCookie}`);
+                }
+            }
             // On some systems (e.g. BASIS < 7.50), SADT_REST_RFC_ENDPOINT does not
             // populate STATUS_LINE, returning status 0. Detect errors from the
             // response body: ADT exception XML indicates a failed request.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mcp-abap-adt/connection",
-  "version": "1.5.2",
+  "version": "1.6.0",
   "description": "ABAP connection layer for MCP ABAP ADT server",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
@@ -46,7 +46,8 @@
     "node": ">=18.0.0"
   },
   "dependencies": {
-    "@mcp-abap-adt/interfaces": "^3.0.0",
+    "@mcp-abap-adt/interfaces": "^6.1.0",
+    "@mcp-abap-adt/sap-rfc-lite": "^0.1.0",
     "axios": "^1.13.5",
     "commander": "^14.0.3",
     "express": "^5.1.0",
@@ -56,6 +57,7 @@
     "@biomejs/biome": "^2.3.14",
     "@types/jest": "^30.0.0",
     "@types/node": "^25.2.3",
+    "dotenv": "^17.3.1",
     "jest": "^30.2.0",
     "jest-util": "^30.2.0",
     "ts-jest": "^29.2.5",