@mcp-abap-adt/connection 1.4.0 → 1.4.2

package/dist/connection/RfcAbapConnection.d.ts

@@ -33,6 +33,11 @@ export declare class RfcAbapConnection implements AbapConnection {
     getSessionId(): string | null;
     setSessionType(_type: 'stateful' | 'stateless'): void;
     makeAdtRequest<T = any, D = any>(options: IAbapRequestOptions): Promise<IAdtResponse<T, D>>;
+    /**
+     * Reset the connection — for RFC this closes the session.
+     * Provides interface compatibility with HTTP connections.
+     */
+    reset(): void;
     /**
      * Close the RFC connection and release the ABAP session.
      */

package/dist/connection/RfcAbapConnection.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"RfcAbapConnection.d.ts","sourceRoot":"","sources":["../../src/connection/RfcAbapConnection.ts"],"names":[],"mappings":"AACA,OAAO,KAAK,EACV,mBAAmB,EACnB,YAAY,EACb,MAAM,0BAA0B,CAAC;AAClC,OAAO,KAAK,EAAE,SAAS,EAAE,MAAM,wBAAwB,CAAC;AACxD,OAAO,KAAK,EAAE,OAAO,EAAE,MAAM,cAAc,CAAC;AAC5C,OAAO,KAAK,EAAE,cAAc,EAAE,MAAM,qBAAqB,CAAC;AAqD1D;;;;;;;;;;;;;;;;;GAiBG;AACH,qBAAa,iBAAkB,YAAW,cAAc;IAOpD,OAAO,CAAC,QAAQ,CAAC,MAAM;IACvB,OAAO,CAAC,QAAQ,CAAC,MAAM;IAPzB,OAAO,CAAC,SAAS,CAA2B;IAC5C,OAAO,CAAC,QAAQ,CAAC,SAAS,CAAS;IACnC,OAAO,CAAC,QAAQ,CAAC,OAAO,CAAS;IACjC,OAAO,CAAC,QAAQ,CAAC,SAAS,CAAsB;gBAG7B,MAAM,EAAE,SAAS,EACjB,MAAM,GAAE,OAAO,GAAG,IAAW;IAa1C,OAAO,IAAI,OAAO,CAAC,IAAI,CAAC;IA8BxB,UAAU,IAAI,OAAO,CAAC,MAAM,CAAC;IAInC,YAAY,IAAI,MAAM,GAAG,IAAI;IAI7B,cAAc,CAAC,KAAK,EAAE,UAAU,GAAG,WAAW,GAAG,IAAI;IAI/C,cAAc,CAAC,CAAC,GAAG,GAAG,EAAE,CAAC,GAAG,GAAG,EACnC,OAAO,EAAE,mBAAmB,GAC3B,OAAO,CAAC,YAAY,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC;IA6G9B;;OAEG;IACG,KAAK,IAAI,OAAO,CAAC,IAAI,CAAC;IAc5B,OAAO,CAAC,MAAM,CAAC,cAAc;CAqB9B"}
+{"version":3,"file":"RfcAbapConnection.d.ts","sourceRoot":"","sources":["../../src/connection/RfcAbapConnection.ts"],"names":[],"mappings":"AACA,OAAO,KAAK,EACV,mBAAmB,EACnB,YAAY,EACb,MAAM,0BAA0B,CAAC;AAClC,OAAO,KAAK,EAAE,SAAS,EAAE,MAAM,wBAAwB,CAAC;AACxD,OAAO,KAAK,EAAE,OAAO,EAAE,MAAM,cAAc,CAAC;AAC5C,OAAO,KAAK,EAAE,cAAc,EAAE,MAAM,qBAAqB,CAAC;AA0F1D;;;;;;;;;;;;;;;;;GAiBG;AACH,qBAAa,iBAAkB,YAAW,cAAc;IAOpD,OAAO,CAAC,QAAQ,CAAC,MAAM;IACvB,OAAO,CAAC,QAAQ,CAAC,MAAM;IAPzB,OAAO,CAAC,SAAS,CAA2B;IAC5C,OAAO,CAAC,QAAQ,CAAC,SAAS,CAAS;IACnC,OAAO,CAAC,QAAQ,CAAC,OAAO,CAAS;IACjC,OAAO,CAAC,QAAQ,CAAC,SAAS,CAAsB;gBAG7B,MAAM,EAAE,SAAS,EACjB,MAAM,GAAE,OAAO,GAAG,IAAW;IAa1C,OAAO,IAAI,OAAO,CAAC,IAAI,CAAC;IA8BxB,UAAU,IAAI,OAAO,CAAC,MAAM,CAAC;IAInC,YAAY,IAAI,MAAM,GAAG,IAAI;IAI7B,cAAc,CAAC,KAAK,EAAE,UAAU,GAAG,WAAW,GAAG,IAAI;IAI/C,cAAc,CAAC,CAAC,GAAG,GAAG,EAAE,CAAC,GAAG,GAAG,EACnC,OAAO,EAAE,mBAAmB,GAC3B,OAAO,CAAC,YAAY,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC;IA6I9B;;;OAGG;IACH,KAAK,IAAI,IAAI;IAIb;;OAEG;IACG,KAAK,IAAI,OAAO,CAAC,IAAI,CAAC;IAc5B,OAAO,CAAC,MAAM,CAAC,cAAc;CAqB9B"}

package/dist/connection/RfcAbapConnection.js

@@ -25,6 +25,37 @@ function buildRfcParams(config) {
         lang: 'EN',
     };
 }
+/**
+ * Map ADT exception type names to HTTP status codes.
+ * These are standard ADT exception types returned in `<exc:exception>` XML.
+ */
+const EXCEPTION_STATUS_MAP = {
+    ExceptionResourceNotFound: { code: 404, text: 'Not Found' },
+    ExceptionResourceNoAuthorization: { code: 403, text: 'Forbidden' },
+    ExceptionResourceAlreadyExists: { code: 409, text: 'Conflict' },
+    ExceptionResourceLocked: { code: 423, text: 'Locked' },
+    ExceptionBadRequest: { code: 400, text: 'Bad Request' },
+    ExceptionNotSupported: { code: 501, text: 'Not Implemented' },
+    ExceptionConflict: { code: 409, text: 'Conflict' },
+};
+/**
+ * Detect HTTP status from ADT exception XML in response body.
+ * On some legacy systems, SADT_REST_RFC_ENDPOINT returns errors as XML
+ * exceptions without setting proper HTTP status codes in STATUS_LINE.
+ */
+function detectExceptionStatus(body) {
+    // Extract exception type: <exc:exception ... xmlns:exc="..."><exc:type>ExceptionName</exc:type>
+    const typeMatch = body.match(/<exc:type[^>]*>([^<]+)<\/exc:type>/);
+    if (typeMatch) {
+        const exType = typeMatch[1].trim();
+        const mapped = EXCEPTION_STATUS_MAP[exType];
+        if (mapped) {
+            return { statusCode: mapped.code, statusText: mapped.text };
+        }
+    }
+    // Unknown exception type — return 500 as generic server error
+    return { statusCode: 500, statusText: 'Internal Server Error' };
+}
 /**
  * RFC-based connection for on-premise SAP systems.
  *
@@ -100,12 +131,11 @@ class RfcAbapConnection {
             throw new Error('RFC connection is not open. Call connect() first.');
         }
         const method = options.method.toUpperCase();
-        let uri = options.url;
-        // Add sap-client to URI if not present
-        if (this.config.client && !uri.includes('sap-client')) {
-            uri +=
-                (uri.includes('?') ? '&' : '?') + `sap-client=${this.config.client}`;
-        }
+        const uri = options.url;
+        // Note: sap-client is NOT added to URI for RFC connections.
+        // The RFC session is already logged into the correct client
+        // (via the 'client' param in RFC connection). Adding sap-client
+        // to the URI can cause "object not found" on some systems.
         // Build header fields
         const headerFields = [];
         if (options.headers) {
@@ -138,9 +168,16 @@ class RfcAbapConnection {
                 },
             });
             const resp = result.RESPONSE || result;
+            // Log raw RFC response structure for debugging
+            this.logger?.debug(`RFC raw response keys: ${Object.keys(resp).join(', ')}`);
+            if (resp.STATUS_LINE) {
+                this.logger?.debug(`RFC STATUS_LINE: ${JSON.stringify(resp.STATUS_LINE)}`);
+            }
             // Parse status — RFC returns status in STATUS_LINE structure
-            const statusCode = resp.STATUS_LINE?.CODE || resp.STATUS_CODE || 200;
-            const statusText = resp.STATUS_LINE?.REASON || resp.STATUS_TEXT || 'OK';
+            // Field names: STATUS_CODE (not CODE), REASON_PHRASE (not REASON)
+            const rawCode = resp.STATUS_LINE?.STATUS_CODE || resp.STATUS_LINE?.CODE || 0;
+            let statusCode = typeof rawCode === 'string' ? Number.parseInt(rawCode, 10) : rawCode;
+            let statusText = resp.STATUS_LINE?.REASON_PHRASE || resp.STATUS_LINE?.REASON || '';
             // Parse response body
             const respBody = resp.MESSAGE_BODY
                 ? Buffer.isBuffer(resp.MESSAGE_BODY)
@@ -155,6 +192,20 @@ class RfcAbapConnection {
                     respHeaders[field.NAME.toLowerCase()] = field.VALUE;
                 }
             }
+            // On some systems (e.g. BASIS < 7.50), SADT_REST_RFC_ENDPOINT does not
+            // populate STATUS_LINE, returning status 0. Detect errors from the
+            // response body: ADT exception XML indicates a failed request.
+            if (!statusCode && respBody.includes('<exc:exception')) {
+                const detected = detectExceptionStatus(respBody);
+                statusCode = detected.statusCode;
+                statusText = detected.statusText;
+                this.logger?.debug(`RFC: STATUS_LINE empty, detected ${statusCode} from exception XML`);
+            }
+            // Default to 200 OK only when no error was detected
+            if (!statusCode) {
+                statusCode = 200;
+                statusText = statusText || 'OK';
+            }
             this.logger?.debug(`RFC ← ${statusCode} ${statusText} (${respBody.length} bytes)`);
             const response = {
                 data: respBody,
@@ -181,6 +232,13 @@ class RfcAbapConnection {
             throw new Error(`RFC call to SADT_REST_RFC_ENDPOINT failed: ${msg}`);
         }
     }
+    /**
+     * Reset the connection — for RFC this closes the session.
+     * Provides interface compatibility with HTTP connections.
+     */
+    reset() {
+        this.close();
+    }
     /**
      * Close the RFC connection and release the ABAP session.
      */

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mcp-abap-adt/connection",
-  "version": "1.4.0",
+  "version": "1.4.2",
   "description": "ABAP connection layer for MCP ABAP ADT server",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",