@mcp-abap-adt/connection 1.3.2 → 1.4.0

package/dist/connection/RfcAbapConnection.d.ts

@@ -0,0 +1,42 @@
+import type { IAbapRequestOptions, IAdtResponse } from '@mcp-abap-adt/interfaces';
+import type { SapConfig } from '../config/sapConfig.js';
+import type { ILogger } from '../logger.js';
+import type { AbapConnection } from './AbapConnection.js';
+/**
+ * RFC-based connection for on-premise SAP systems.
+ *
+ * Uses node-rfc to call SADT_REST_RFC_ENDPOINT — the same standard SAP FM
+ * that Eclipse ADT uses for all on-premise ADT operations via JCo.
+ *
+ * RFC connections are inherently stateful: one ABAP session persists for the
+ * entire connection lifetime. This solves the HTTP 423 "invalid lock handle"
+ * problem on legacy systems (BASIS < 7.50) where HTTP stateful sessions
+ * are not supported.
+ *
+ * Connection parameters are derived from the standard ISapConfig.url field:
+ *   http://saphost:8000 → ashost=saphost, sysnr=00
+ *
+ * Prerequisites:
+ *   - SAP NW RFC SDK installed on the machine
+ *   - node-rfc package installed: npm install node-rfc
+ */
+export declare class RfcAbapConnection implements AbapConnection {
+    private readonly config;
+    private readonly logger;
+    private rfcClient;
+    private readonly sessionId;
+    private readonly baseUrl;
+    private readonly rfcParams;
+    constructor(config: SapConfig, logger?: ILogger | null);
+    connect(): Promise<void>;
+    getBaseUrl(): Promise<string>;
+    getSessionId(): string | null;
+    setSessionType(_type: 'stateful' | 'stateless'): void;
+    makeAdtRequest<T = any, D = any>(options: IAbapRequestOptions): Promise<IAdtResponse<T, D>>;
+    /**
+     * Close the RFC connection and release the ABAP session.
+     */
+    close(): Promise<void>;
+    private static validateConfig;
+}
+//# sourceMappingURL=RfcAbapConnection.d.ts.map

package/dist/connection/RfcAbapConnection.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"RfcAbapConnection.d.ts","sourceRoot":"","sources":["../../src/connection/RfcAbapConnection.ts"],"names":[],"mappings":"AACA,OAAO,KAAK,EACV,mBAAmB,EACnB,YAAY,EACb,MAAM,0BAA0B,CAAC;AAClC,OAAO,KAAK,EAAE,SAAS,EAAE,MAAM,wBAAwB,CAAC;AACxD,OAAO,KAAK,EAAE,OAAO,EAAE,MAAM,cAAc,CAAC;AAC5C,OAAO,KAAK,EAAE,cAAc,EAAE,MAAM,qBAAqB,CAAC;AAqD1D;;;;;;;;;;;;;;;;;GAiBG;AACH,qBAAa,iBAAkB,YAAW,cAAc;IAOpD,OAAO,CAAC,QAAQ,CAAC,MAAM;IACvB,OAAO,CAAC,QAAQ,CAAC,MAAM;IAPzB,OAAO,CAAC,SAAS,CAA2B;IAC5C,OAAO,CAAC,QAAQ,CAAC,SAAS,CAAS;IACnC,OAAO,CAAC,QAAQ,CAAC,OAAO,CAAS;IACjC,OAAO,CAAC,QAAQ,CAAC,SAAS,CAAsB;gBAG7B,MAAM,EAAE,SAAS,EACjB,MAAM,GAAE,OAAO,GAAG,IAAW;IAa1C,OAAO,IAAI,OAAO,CAAC,IAAI,CAAC;IA8BxB,UAAU,IAAI,OAAO,CAAC,MAAM,CAAC;IAInC,YAAY,IAAI,MAAM,GAAG,IAAI;IAI7B,cAAc,CAAC,KAAK,EAAE,UAAU,GAAG,WAAW,GAAG,IAAI;IAI/C,cAAc,CAAC,CAAC,GAAG,GAAG,EAAE,CAAC,GAAG,GAAG,EACnC,OAAO,EAAE,mBAAmB,GAC3B,OAAO,CAAC,YAAY,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC;IA6G9B;;OAEG;IACG,KAAK,IAAI,OAAO,CAAC,IAAI,CAAC;IAc5B,OAAO,CAAC,MAAM,CAAC,cAAc;CAqB9B"}

package/dist/connection/RfcAbapConnection.js

@@ -0,0 +1,214 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.RfcAbapConnection = void 0;
+const node_crypto_1 = require("node:crypto");
+/**
+ * Derive RFC connection parameters from ISapConfig.
+ * Parses hostname from config.url, system number from port (80XX → XX).
+ *
+ * Examples:
+ *   http://saphost:8000  → ashost=saphost, sysnr=00
+ *   http://saphost:8001  → ashost=saphost, sysnr=01
+ *   http://saphost:8042  → ashost=saphost, sysnr=42
+ */
+function buildRfcParams(config) {
+    const parsed = new URL(config.url);
+    const port = Number.parseInt(parsed.port || '8000', 10);
+    // SAP HTTP port convention: 80XX where XX = system number
+    const sysnr = String(port - 8000).padStart(2, '0');
+    return {
+        ashost: parsed.hostname,
+        sysnr,
+        client: config.client || '000',
+        user: config.username || '',
+        passwd: config.password || '',
+        lang: 'EN',
+    };
+}
+/**
+ * RFC-based connection for on-premise SAP systems.
+ *
+ * Uses node-rfc to call SADT_REST_RFC_ENDPOINT — the same standard SAP FM
+ * that Eclipse ADT uses for all on-premise ADT operations via JCo.
+ *
+ * RFC connections are inherently stateful: one ABAP session persists for the
+ * entire connection lifetime. This solves the HTTP 423 "invalid lock handle"
+ * problem on legacy systems (BASIS < 7.50) where HTTP stateful sessions
+ * are not supported.
+ *
+ * Connection parameters are derived from the standard ISapConfig.url field:
+ *   http://saphost:8000 → ashost=saphost, sysnr=00
+ *
+ * Prerequisites:
+ *   - SAP NW RFC SDK installed on the machine
+ *   - node-rfc package installed: npm install node-rfc
+ */
+class RfcAbapConnection {
+    config;
+    logger;
+    rfcClient = null;
+    sessionId;
+    baseUrl;
+    rfcParams;
+    constructor(config, logger = null) {
+        this.config = config;
+        this.logger = logger;
+        RfcAbapConnection.validateConfig(config);
+        this.sessionId = (0, node_crypto_1.randomUUID)();
+        this.baseUrl = config.url;
+        this.rfcParams = buildRfcParams(config);
+        this.logger?.debug(`RfcAbapConnection created for ${this.rfcParams.ashost}:${this.rfcParams.sysnr}, client ${this.rfcParams.client}`);
+    }
+    async connect() {
+        let Client;
+        try {
+            // Dynamic require — node-rfc is NOT a declared dependency.
+            // Users who need RFC connections must install it manually:
+            //   npm install node-rfc (+ SAP NW RFC SDK on the machine)
+            // eslint-disable-next-line @typescript-eslint/no-require-imports
+            const noderfc = require('node-rfc');
+            Client = noderfc.Client;
+        }
+        catch (e) {
+            throw new Error('node-rfc is not available. To use RFC connections, install SAP NW RFC SDK ' +
+                'and run: npm install node-rfc. ' +
+                `Details: ${e instanceof Error ? e.message : String(e)}`);
+        }
+        this.rfcClient = new Client(this.rfcParams);
+        try {
+            await this.rfcClient.open();
+            this.logger?.debug('RFC connection opened (stateful session)');
+        }
+        catch (e) {
+            this.rfcClient = null;
+            const msg = e instanceof Error ? e.message : String(e);
+            this.logger?.error(`RFC connection failed: ${msg}`);
+            throw new Error(`Failed to open RFC connection: ${msg}`);
+        }
+    }
+    async getBaseUrl() {
+        return this.baseUrl;
+    }
+    getSessionId() {
+        return this.sessionId;
+    }
+    setSessionType(_type) {
+        // No-op — RFC connections are always stateful
+    }
+    async makeAdtRequest(options) {
+        if (!this.rfcClient?.alive) {
+            throw new Error('RFC connection is not open. Call connect() first.');
+        }
+        const method = options.method.toUpperCase();
+        let uri = options.url;
+        // Add sap-client to URI if not present
+        if (this.config.client && !uri.includes('sap-client')) {
+            uri +=
+                (uri.includes('?') ? '&' : '?') + `sap-client=${this.config.client}`;
+        }
+        // Build header fields
+        const headerFields = [];
+        if (options.headers) {
+            for (const [name, value] of Object.entries(options.headers)) {
+                headerFields.push({ NAME: name, VALUE: value });
+            }
+        }
+        // Ensure Content-Type for body
+        const body = options.data !== undefined && options.data !== null
+            ? String(options.data)
+            : '';
+        if (body &&
+            !headerFields.some((h) => h.NAME.toLowerCase() === 'content-type')) {
+            headerFields.push({
+                NAME: 'Content-Type',
+                VALUE: 'text/plain; charset=utf-8',
+            });
+        }
+        this.logger?.debug(`RFC → ${method} ${uri}`);
+        try {
+            const result = await this.rfcClient.call('SADT_REST_RFC_ENDPOINT', {
+                REQUEST: {
+                    REQUEST_LINE: {
+                        METHOD: method,
+                        URI: uri,
+                        VERSION: 'HTTP/1.1',
+                    },
+                    HEADER_FIELDS: headerFields,
+                    MESSAGE_BODY: body ? Buffer.from(body, 'utf-8') : Buffer.alloc(0),
+                },
+            });
+            const resp = result.RESPONSE || result;
+            // Parse status — RFC returns status in STATUS_LINE structure
+            const statusCode = resp.STATUS_LINE?.CODE || resp.STATUS_CODE || 200;
+            const statusText = resp.STATUS_LINE?.REASON || resp.STATUS_TEXT || 'OK';
+            // Parse response body
+            const respBody = resp.MESSAGE_BODY
+                ? Buffer.isBuffer(resp.MESSAGE_BODY)
+                    ? resp.MESSAGE_BODY.toString('utf-8')
+                    : String(resp.MESSAGE_BODY)
+                : '';
+            // Parse response headers
+            const respHeaders = {};
+            const respHeaderFields = resp.HEADER_FIELDS || [];
+            for (const field of respHeaderFields) {
+                if (field.NAME && field.VALUE !== undefined) {
+                    respHeaders[field.NAME.toLowerCase()] = field.VALUE;
+                }
+            }
+            this.logger?.debug(`RFC ← ${statusCode} ${statusText} (${respBody.length} bytes)`);
+            const response = {
+                data: respBody,
+                status: statusCode,
+                statusText,
+                headers: respHeaders,
+            };
+            // Throw for error status codes (matching HTTP/axios behavior)
+            if (statusCode >= 400) {
+                const error = new Error(`Request failed with status ${statusCode}: ${method} ${uri}`);
+                error.response = response;
+                throw error;
+            }
+            return response;
+        }
+        catch (e) {
+            // Re-throw our own errors (status >= 400)
+            if (e?.response) {
+                throw e;
+            }
+            // RFC-level error
+            const msg = e instanceof Error ? e.message : String(e);
+            this.logger?.error(`RFC call failed: ${msg}`);
+            throw new Error(`RFC call to SADT_REST_RFC_ENDPOINT failed: ${msg}`);
+        }
+    }
+    /**
+     * Close the RFC connection and release the ABAP session.
+     */
+    async close() {
+        if (this.rfcClient) {
+            try {
+                await this.rfcClient.close();
+                this.logger?.debug('RFC connection closed');
+            }
+            catch (e) {
+                this.logger?.debug(`RFC close error: ${e instanceof Error ? e.message : String(e)}`);
+            }
+            this.rfcClient = null;
+        }
+    }
+    static validateConfig(config) {
+        if (config.authType !== 'rfc') {
+            throw new Error(`RFC connection expects authType "rfc", got "${config.authType}"`);
+        }
+        if (!config.url) {
+            throw new Error('RFC connection requires url (hostname is parsed from it)');
+        }
+        if (!config.username || !config.password) {
+            throw new Error('RFC connection requires both username and password');
+        }
+        if (!config.client) {
+            throw new Error('RFC connection requires SAP client');
+        }
+    }
+}
+exports.RfcAbapConnection = RfcAbapConnection;

package/dist/connection/connectionFactory.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"connectionFactory.d.ts","sourceRoot":"","sources":["../../src/connection/connectionFactory.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,eAAe,EAAE,MAAM,0BAA0B,CAAC;AAChE,OAAO,KAAK,EAAE,SAAS,EAAE,MAAM,wBAAwB,CAAC;AACxD,OAAO,KAAK,EAAE,OAAO,EAAE,MAAM,cAAc,CAAC;AAC5C,OAAO,KAAK,EAAE,cAAc,EAAE,MAAM,qBAAqB,CAAC;AAK1D,wBAAgB,oBAAoB,CAClC,MAAM,EAAE,SAAS,EACjB,MAAM,CAAC,EAAE,OAAO,GAAG,IAAI,EACvB,SAAS,CAAC,EAAE,MAAM,EAClB,cAAc,CAAC,EAAE,eAAe,EAChC,OAAO,CAAC,EAAE;IAAE,eAAe,CAAC,EAAE,OAAO,CAAA;CAAE,GACtC,cAAc,CAahB"}
+{"version":3,"file":"connectionFactory.d.ts","sourceRoot":"","sources":["../../src/connection/connectionFactory.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,eAAe,EAAE,MAAM,0BAA0B,CAAC;AAChE,OAAO,KAAK,EAAE,SAAS,EAAE,MAAM,wBAAwB,CAAC;AACxD,OAAO,KAAK,EAAE,OAAO,EAAE,MAAM,cAAc,CAAC;AAC5C,OAAO,KAAK,EAAE,cAAc,EAAE,MAAM,qBAAqB,CAAC;AAM1D,wBAAgB,oBAAoB,CAClC,MAAM,EAAE,SAAS,EACjB,MAAM,CAAC,EAAE,OAAO,GAAG,IAAI,EACvB,SAAS,CAAC,EAAE,MAAM,EAClB,cAAc,CAAC,EAAE,eAAe,EAChC,OAAO,CAAC,EAAE;IAAE,eAAe,CAAC,EAAE,OAAO,CAAA;CAAE,GACtC,cAAc,CAehB"}

package/dist/connection/connectionFactory.js

@@ -3,6 +3,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.createAbapConnection = createAbapConnection;
 const BaseAbapConnection_js_1 = require("./BaseAbapConnection.js");
 const JwtAbapConnection_js_1 = require("./JwtAbapConnection.js");
+const RfcAbapConnection_js_1 = require("./RfcAbapConnection.js");
 const SamlAbapConnection_js_1 = require("./SamlAbapConnection.js");
 function createAbapConnection(config, logger, sessionId, tokenRefresher, options) {
     switch (config.authType) {
@@ -12,6 +13,8 @@ function createAbapConnection(config, logger, sessionId, tokenRefresher, options
             return new JwtAbapConnection_js_1.JwtAbapConnection(config, logger, sessionId, tokenRefresher);
         case 'saml':
             return new SamlAbapConnection_js_1.SamlAbapConnection(config, logger, sessionId, options);
+        case 'rfc':
+            return new RfcAbapConnection_js_1.RfcAbapConnection(config, logger);
         default:
             throw new Error(`Unsupported SAP authentication type: ${config.authType}`);
     }

package/dist/index.d.ts

@@ -7,6 +7,7 @@ export { createAbapConnection } from './connection/connectionFactory.js';
 export { CSRF_CONFIG, CSRF_ERROR_MESSAGES } from './connection/csrfConfig.js';
 export { GenericWebSocketTransport, type IWebSocketFactory, type IWebSocketLike, } from './connection/GenericWebSocketTransport.js';
 export { JwtAbapConnection, JwtAbapConnection as CloudAbapConnection, } from './connection/JwtAbapConnection.js';
+export { RfcAbapConnection } from './connection/RfcAbapConnection.js';
 export { SamlAbapConnection } from './connection/SamlAbapConnection.js';
 export type { ILogger } from './logger.js';
 export { getTimeout, getTimeoutConfig, type TimeoutConfig, } from './utils/timeouts.js';

package/dist/index.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../src/index.ts"],"names":[],"mappings":"AAEA,YAAY,EACV,mBAAmB,EACnB,wBAAwB,EACxB,yBAAyB,EACzB,wBAAwB,EACxB,mBAAmB,GACpB,MAAM,0BAA0B,CAAC;AAClC,YAAY,EACV,WAAW,EACX,SAAS,GACV,MAAM,uBAAuB,CAAC;AAE/B,OAAO,EAAE,kBAAkB,EAAE,MAAM,uBAAuB,CAAC;AAE3D,YAAY,EACV,cAAc,EACd,kBAAkB,GACnB,MAAM,gCAAgC,CAAC;AAGxC,OAAO,EACL,kBAAkB,EAClB,kBAAkB,IAAI,oBAAoB,GAC3C,MAAM,oCAAoC,CAAC;AAE5C,OAAO,EAAE,oBAAoB,EAAE,MAAM,mCAAmC,CAAC;AAEzE,OAAO,EAAE,WAAW,EAAE,mBAAmB,EAAE,MAAM,4BAA4B,CAAC;AAC9E,OAAO,EACL,yBAAyB,EACzB,KAAK,iBAAiB,EACtB,KAAK,cAAc,GACpB,MAAM,2CAA2C,CAAC;AACnD,OAAO,EACL,iBAAiB,EACjB,iBAAiB,IAAI,mBAAmB,GACzC,MAAM,mCAAmC,CAAC;AAC3C,OAAO,EAAE,kBAAkB,EAAE,MAAM,oCAAoC,CAAC;AACxE,YAAY,EAAE,OAAO,EAAE,MAAM,aAAa,CAAC;AAE3C,OAAO,EACL,UAAU,EACV,gBAAgB,EAChB,KAAK,aAAa,GACnB,MAAM,qBAAqB,CAAC"}
+{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../src/index.ts"],"names":[],"mappings":"AAEA,YAAY,EACV,mBAAmB,EACnB,wBAAwB,EACxB,yBAAyB,EACzB,wBAAwB,EACxB,mBAAmB,GACpB,MAAM,0BAA0B,CAAC;AAClC,YAAY,EACV,WAAW,EACX,SAAS,GACV,MAAM,uBAAuB,CAAC;AAE/B,OAAO,EAAE,kBAAkB,EAAE,MAAM,uBAAuB,CAAC;AAE3D,YAAY,EACV,cAAc,EACd,kBAAkB,GACnB,MAAM,gCAAgC,CAAC;AAGxC,OAAO,EACL,kBAAkB,EAClB,kBAAkB,IAAI,oBAAoB,GAC3C,MAAM,oCAAoC,CAAC;AAE5C,OAAO,EAAE,oBAAoB,EAAE,MAAM,mCAAmC,CAAC;AAEzE,OAAO,EAAE,WAAW,EAAE,mBAAmB,EAAE,MAAM,4BAA4B,CAAC;AAC9E,OAAO,EACL,yBAAyB,EACzB,KAAK,iBAAiB,EACtB,KAAK,cAAc,GACpB,MAAM,2CAA2C,CAAC;AACnD,OAAO,EACL,iBAAiB,EACjB,iBAAiB,IAAI,mBAAmB,GACzC,MAAM,mCAAmC,CAAC;AAC3C,OAAO,EAAE,iBAAiB,EAAE,MAAM,mCAAmC,CAAC;AACtE,OAAO,EAAE,kBAAkB,EAAE,MAAM,oCAAoC,CAAC;AACxE,YAAY,EAAE,OAAO,EAAE,MAAM,aAAa,CAAC;AAE3C,OAAO,EACL,UAAU,EACV,gBAAgB,EAChB,KAAK,aAAa,GACnB,MAAM,qBAAqB,CAAC"}

package/dist/index.js

@@ -1,7 +1,7 @@
 "use strict";
 // Types - re-exported from interfaces package with backward compatibility aliases
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.getTimeoutConfig = exports.getTimeout = exports.SamlAbapConnection = exports.CloudAbapConnection = exports.JwtAbapConnection = exports.GenericWebSocketTransport = exports.CSRF_ERROR_MESSAGES = exports.CSRF_CONFIG = exports.createAbapConnection = exports.OnPremAbapConnection = exports.BaseAbapConnection = exports.sapConfigSignature = void 0;
+exports.getTimeoutConfig = exports.getTimeout = exports.SamlAbapConnection = exports.RfcAbapConnection = exports.CloudAbapConnection = exports.JwtAbapConnection = exports.GenericWebSocketTransport = exports.CSRF_ERROR_MESSAGES = exports.CSRF_CONFIG = exports.createAbapConnection = exports.OnPremAbapConnection = exports.BaseAbapConnection = exports.sapConfigSignature = void 0;
 // Config utilities
 var sapConfig_js_1 = require("./config/sapConfig.js");
 Object.defineProperty(exports, "sapConfigSignature", { enumerable: true, get: function () { return sapConfig_js_1.sapConfigSignature; } });
@@ -22,6 +22,8 @@ Object.defineProperty(exports, "GenericWebSocketTransport", { enumerable: true,
 var JwtAbapConnection_js_1 = require("./connection/JwtAbapConnection.js");
 Object.defineProperty(exports, "JwtAbapConnection", { enumerable: true, get: function () { return JwtAbapConnection_js_1.JwtAbapConnection; } });
 Object.defineProperty(exports, "CloudAbapConnection", { enumerable: true, get: function () { return JwtAbapConnection_js_1.JwtAbapConnection; } });
+var RfcAbapConnection_js_1 = require("./connection/RfcAbapConnection.js");
+Object.defineProperty(exports, "RfcAbapConnection", { enumerable: true, get: function () { return RfcAbapConnection_js_1.RfcAbapConnection; } });
 var SamlAbapConnection_js_1 = require("./connection/SamlAbapConnection.js");
 Object.defineProperty(exports, "SamlAbapConnection", { enumerable: true, get: function () { return SamlAbapConnection_js_1.SamlAbapConnection; } });
 // Timeouts

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mcp-abap-adt/connection",
-  "version": "1.3.2",
+  "version": "1.4.0",
   "description": "ABAP connection layer for MCP ABAP ADT server",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
@@ -46,7 +46,7 @@
     "node": ">=18.0.0"
   },
   "dependencies": {
-    "@mcp-abap-adt/interfaces": "^2.4.0",
+    "@mcp-abap-adt/interfaces": "^2.7.0",
     "axios": "^1.13.5",
     "commander": "^14.0.3",
     "express": "^5.1.0",