@mcp-abap-adt/auth-providers 1.1.0 → 1.2.0

package/dist/providers/AuthorizationCodeProvider.js

@@ -11,6 +11,8 @@ const interfaces_1 = require("@mcp-abap-adt/interfaces");
 const browserAuth_1 = require("../auth/browserAuth");
 const tokenRefresher_1 = require("../auth/tokenRefresher");
 const BaseTokenProvider_1 = require("./BaseTokenProvider");
+/** How long an interactive login may wait for its callback. */
+const LOGIN_TIMEOUT_MS = 30 * 1000;
 /**
  * Authorization Code token provider
  *
@@ -100,18 +102,15 @@ class AuthorizationCodeProvider extends BaseTokenProvider_1.BaseTokenProvider {
             uaaUrl: authConfig.uaaUrl,
             clientId: authConfig.uaaClientId,
         });
-        // Wrap startBrowserAuth with timeout
-        const timeoutMs = 30 * 1000; // 30 seconds
-        const timeoutPromise = new Promise((_, reject) => {
-            setTimeout(() => {
-                reject(new Error(`Authentication timeout after ${timeoutMs / 1000} seconds. Please try again.`));
-            }, timeoutMs);
-        });
-        const result = await Promise.race([
-            (0, browserAuth_1.startBrowserAuth)(authConfig, browser, this.logger || undefined, // Pass logger to browserAuth
-            redirectPort),
-            timeoutPromise,
-        ]);
+        // One timeout, owned by whoever owns the socket.
+        //
+        // This used to race startBrowserAuth against a second timer of the same
+        // 30 seconds, so which fired was down to scheduling — and when the outer
+        // one won, the provider rejected while the callback port was still bound.
+        // That timer was never cleared either, keeping the event loop alive for the
+        // rest of the window after a login that succeeded in a second.
+        const result = await (0, browserAuth_1.startBrowserAuth)(authConfig, browser, this.logger || undefined, // Pass logger to browserAuth
+        redirectPort, LOGIN_TIMEOUT_MS);
         this.logger?.info('[AuthorizationCodeProvider] Login completed', {
             hasAccessToken: !!result.accessToken,
             hasRefreshToken: !!result.refreshToken,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mcp-abap-adt/auth-providers",
-  "version": "1.1.0",
+  "version": "1.2.0",
   "description": "Token providers for MCP ABAP ADT auth-broker",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
@@ -55,23 +55,23 @@
     "prepublishOnly": "npm run build"
   },
   "engines": {
-    "node": ">=18.0.0"
+    "node": ">=18.2.0"
   },
   "dependencies": {
-    "@mcp-abap-adt/interfaces": "^2.3.0",
+    "@mcp-abap-adt/interfaces": "^11.4.0",
     "axios": "^1.13.5",
     "express": "^5.1.0",
     "open": "^11.0.0"
   },
   "devDependencies": {
     "@biomejs/biome": "^2.3.14",
+    "@jest/globals": "^30.2.0",
     "@mcp-abap-adt/auth-stores": "^1.0.1",
     "@mcp-abap-adt/logger": "^0.1.4",
     "@types/express": "^5.0.5",
     "@types/jest": "^30.0.0",
     "@types/js-yaml": "^4.0.9",
     "@types/node": "^25.2.3",
-    "@jest/globals": "^30.2.0",
     "jest": "^30.2.0",
     "jest-util": "^30.2.0",
     "js-yaml": "^4.1.1",