@mcp-abap-adt/auth-broker 0.1.8 → 0.1.10

package/CHANGELOG.md

@@ -11,7 +11,33 @@ Thank you to all contributors! See [CONTRIBUTORS.md](CONTRIBUTORS.md) for the co
 
 ## [Unreleased]
 
-## [0.1.8] - 2024-12-04
+## [0.1.10] - 2025-12-07
+
+### Added
+- **Constructor Validation**: Added validation checks in `AuthBroker` constructor to ensure all required dependencies are provided
+  - Validates that `stores` parameter is not null/undefined
+  - Validates that `serviceKeyStore` is provided
+  - Validates that `sessionStore` is provided
+  - Validates that `tokenProvider` is provided
+  - Throws descriptive error messages if any required dependency is missing
+  - Helps catch configuration errors early during development
+
+## [0.1.9] - 2025-12-05
+
+### Changed
+- **Dependency Injection for Logger**: Migrated from concrete `Logger` implementation to `ILogger` interface
+  - Removed dependency on `@mcp-abap-adt/logger` package
+  - Now uses `ILogger` interface from `@mcp-abap-adt/interfaces`
+  - Logger parameter in constructor is optional - uses no-op logger if not provided
+  - Follows Dependency Inversion Principle - depends on interface, not implementation
+- **Bin Script Fixes**: Fixed `generate-env-from-service-key.ts` script
+  - Corrected imports from non-existent packages (`@mcp-abap-adt/auth-stores-btp`, `@mcp-abap-adt/auth-stores-xsuaa`) to correct package (`@mcp-abap-adt/auth-stores`)
+  - Fixed constructor parameters: changed from array `[directory]` to string `directory` for all store constructors
+
+### Removed
+- **Unused Dependencies**: Removed `@mcp-abap-adt/connection` dependency (not used in production code)
+
+## [0.1.8] - 2025-12-04
 
 ### Added
 - **Interfaces Package Integration**: Migrated to use `@mcp-abap-adt/interfaces` package for all interface definitions
@@ -63,7 +89,7 @@ Thank you to all contributors! See [CONTRIBUTORS.md](CONTRIBUTORS.md) for the co
 - Token validator utility (moved to providers)
 - Authentication functions (moved to providers)
 
-## [0.1.5] - 2025-12-03
+## [0.1.5] - 2025-12-02
 
 ### Changed
 - **Interface Naming** - All interfaces now start with `I` prefix
@@ -271,64 +297,6 @@ Thank you to all contributors! See [CONTRIBUTORS.md](CONTRIBUTORS.md) for the co
   - Properly expands `~` to home directory in paths
   - Added diagnostic logging controlled by `TEST_VERBOSE` environment variable
 
-## [0.1.5] - 2025-12-02
-
-### Added
-- **SafeSessionStore** - New in-memory session store implementation
-  - Stores session data in memory (Map) - data is lost after application restart
-  - Secure by default - doesn't persist sensitive data to disk
-  - Use when you want to ensure tokens are not saved to files
-  - Perfect for applications that require re-authentication after restart
-- **SafeSessionStore Tests** - Comprehensive test coverage for SafeSessionStore
-  - Tests for `loadSession()` - loading non-existent, existing, and deleted sessions
-  - Tests for `saveSession()` - saving, overwriting, and multiple destinations
-  - Tests for `deleteSession()` - deleting existing and non-existent sessions
-  - Tests for in-memory behavior - data isolation between instances
-  - 11 test cases covering all functionality
-
-### Changed
-- **Interface Naming** - Renamed interfaces for better readability
-  - `ServiceKeyStore` → `IServiceKeyStore` (new interface name)
-  - `SessionStore` → `ISessionStore` (new interface name)
-  - Old names still available as type aliases for backward compatibility
-  - All implementations updated to use new interface names
-- **AuthBroker Constructor** - Simplified API
-  - Removed `searchPathsOrStores` parameter (string/array/object)
-  - Now accepts only `stores` object with `serviceKeyStore` and `sessionStore` properties
-  - Consumers must explicitly provide stores - no automatic path resolution
-  - Default stores: `FileServiceKeyStore()` and `FileSessionStore()` if not provided
-  - This change gives consumers full control over storage implementation
-
-### Breaking Changes
-- **AuthBroker Constructor** - API change
-  - Old API: `new AuthBroker(searchPaths?: string | string[], browser?: string, logger?: Logger)`
-  - New API: `new AuthBroker(stores?: { serviceKeyStore?: IServiceKeyStore; sessionStore?: ISessionStore }, browser?: string, logger?: Logger)`
-  - Migration: Instead of passing paths, create stores explicitly:
-    ```typescript
-    // Old way (no longer works)
-    const broker = new AuthBroker(['/path/to/destinations']);
-    
-    // New way
-    const { FileServiceKeyStore, FileSessionStore } = require('@mcp-abap-adt/auth-broker');
-    const broker = new AuthBroker({
-      serviceKeyStore: new FileServiceKeyStore(['/path/to/destinations']),
-      sessionStore: new FileSessionStore(['/path/to/destinations']),
-    });
-    ```
-
-### Fixed
-- **Test Helpers** - Updated test helpers to use new AuthBroker API
-  - `testHelpers.ts` now uses `FileServiceKeyStore` and `FileSessionStore` with explicit paths
-  - All existing tests updated to work with new constructor signature
-  - Test coverage maintained at 100% for all components
-
-### Technical Details
-- Consumers now have full control over storage implementation
-- Can choose between `FileSessionStore` (persists to disk) and `SafeSessionStore` (in-memory)
-- No automatic path resolution - consumers decide where to store files
-- Better separation of concerns - storage logic is explicit
-- All tests updated and passing (60 tests across 8 test suites)
-
 ## [0.1.4] - 2025-12-01
 
 ### Dependencies

package/README.md

@@ -273,7 +273,7 @@ new AuthBroker(
     tokenProvider?: ITokenProvider;
   }, 
   browser?: string, 
-  logger?: Logger
+  logger?: ILogger
 )
 ```
 

package/bin/generate-env-from-service-key.ts

@@ -16,8 +16,7 @@
 import * as path from 'path';
 import * as fs from 'fs';
 import { AuthBroker } from '../src/AuthBroker';
-import { AbapServiceKeyStore, AbapSessionStore } from '@mcp-abap-adt/auth-stores-btp';
-import { XsuaaServiceKeyStore, XsuaaSessionStore } from '@mcp-abap-adt/auth-stores-xsuaa';
+import { AbapServiceKeyStore, AbapSessionStore, XsuaaServiceKeyStore, XsuaaSessionStore } from '@mcp-abap-adt/auth-stores';
 import { BtpTokenProvider, XsuaaTokenProvider } from '@mcp-abap-adt/auth-providers';
 
 async function main() {
@@ -59,12 +58,12 @@ async function main() {
 
     // Create appropriate stores
     const serviceKeyStore = isXsuaa
-      ? new XsuaaServiceKeyStore([serviceKeyDir])
-      : new AbapServiceKeyStore([serviceKeyDir]);
+      ? new XsuaaServiceKeyStore(serviceKeyDir)
+      : new AbapServiceKeyStore(serviceKeyDir);
     
     const sessionStore = isXsuaa
-      ? new XsuaaSessionStore([sessionDir])
-      : new AbapSessionStore([sessionDir]);
+      ? new XsuaaSessionStore(sessionDir)
+      : new AbapSessionStore(sessionDir);
 
     // Create token provider
     const tokenProvider = isXsuaa

package/dist/AuthBroker.d.ts

@@ -1,7 +1,7 @@
 /**
  * Main AuthBroker class for managing JWT tokens based on destinations
  */
-import { Logger } from '@mcp-abap-adt/logger';
+import { ILogger } from '@mcp-abap-adt/interfaces';
 import { IServiceKeyStore, ISessionStore, IAuthorizationConfig, IConnectionConfig } from './stores/interfaces';
 import { ITokenProvider } from './providers';
 /**
@@ -22,13 +22,13 @@ export declare class AuthBroker {
      * @param browser Optional browser name for authentication (chrome, edge, firefox, system, none).
      *                Default: 'system' (system default browser).
      *                Use 'none' to print URL instead of opening browser.
-     * @param logger Optional logger instance. If not provided, uses default logger.
+     * @param logger Optional logger instance implementing ILogger interface. If not provided, uses no-op logger.
      */
     constructor(stores: {
         serviceKeyStore: IServiceKeyStore;
         sessionStore: ISessionStore;
         tokenProvider: ITokenProvider;
-    }, browser?: string, logger?: Logger);
+    }, browser?: string, logger?: ILogger);
     /**
      * Get authentication token for destination.
      * Tries to load from session store, validates it, and refreshes if needed using a fallback chain.

package/dist/AuthBroker.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"AuthBroker.d.ts","sourceRoot":"","sources":["../src/AuthBroker.ts"],"names":[],"mappings":"AAAA;;GAEG;AAEH,OAAO,EAAE,MAAM,EAAiB,MAAM,sBAAsB,CAAC;AAC7D,OAAO,EAAE,gBAAgB,EAAE,aAAa,EAAE,oBAAoB,EAAE,iBAAiB,EAAE,MAAM,qBAAqB,CAAC;AAC/G,OAAO,EAAE,cAAc,EAAE,MAAM,aAAa,CAAC;AAE7C;;GAEG;AACH,qBAAa,UAAU;IACrB,OAAO,CAAC,OAAO,CAAqB;IACpC,OAAO,CAAC,MAAM,CAAS;IACvB,OAAO,CAAC,eAAe,CAAmB;IAC1C,OAAO,CAAC,YAAY,CAAgB;IACpC,OAAO,CAAC,aAAa,CAAiB;IAEtC;;;;;;;;;;OAUG;gBAED,MAAM,EAAE;QAAE,eAAe,EAAE,gBAAgB,CAAC;QAAC,YAAY,EAAE,aAAa,CAAC;QAAC,aAAa,EAAE,cAAc,CAAA;KAAE,EACzG,OAAO,CAAC,EAAE,MAAM,EAChB,MAAM,CAAC,EAAE,MAAM;IASjB;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;OAgCG;IACG,QAAQ,CAAC,WAAW,EAAE,MAAM,GAAG,OAAO,CAAC,MAAM,CAAC;IAmIpD;;;;;OAKG;IACG,YAAY,CAAC,WAAW,EAAE,MAAM,GAAG,OAAO,CAAC,MAAM,CAAC;IAuCxD;;;;OAIG;IACG,sBAAsB,CAAC,WAAW,EAAE,MAAM,GAAG,OAAO,CAAC,oBAAoB,GAAG,IAAI,CAAC;IAWvF;;;;OAIG;IACG,mBAAmB,CAAC,WAAW,EAAE,MAAM,GAAG,OAAO,CAAC,iBAAiB,GAAG,IAAI,CAAC;CAWlF"}
+{"version":3,"file":"AuthBroker.d.ts","sourceRoot":"","sources":["../src/AuthBroker.ts"],"names":[],"mappings":"AAAA;;GAEG;AAEH,OAAO,EAAE,OAAO,EAAE,MAAM,0BAA0B,CAAC;AACnD,OAAO,EAAE,gBAAgB,EAAE,aAAa,EAAE,oBAAoB,EAAE,iBAAiB,EAAE,MAAM,qBAAqB,CAAC;AAC/G,OAAO,EAAE,cAAc,EAAE,MAAM,aAAa,CAAC;AAY7C;;GAEG;AACH,qBAAa,UAAU;IACrB,OAAO,CAAC,OAAO,CAAqB;IACpC,OAAO,CAAC,MAAM,CAAU;IACxB,OAAO,CAAC,eAAe,CAAmB;IAC1C,OAAO,CAAC,YAAY,CAAgB;IACpC,OAAO,CAAC,aAAa,CAAiB;IAEtC;;;;;;;;;;OAUG;gBAED,MAAM,EAAE;QAAE,eAAe,EAAE,gBAAgB,CAAC;QAAC,YAAY,EAAE,aAAa,CAAC;QAAC,aAAa,EAAE,cAAc,CAAA;KAAE,EACzG,OAAO,CAAC,EAAE,MAAM,EAChB,MAAM,CAAC,EAAE,OAAO;IAuBlB;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;OAgCG;IACG,QAAQ,CAAC,WAAW,EAAE,MAAM,GAAG,OAAO,CAAC,MAAM,CAAC;IAmIpD;;;;;OAKG;IACG,YAAY,CAAC,WAAW,EAAE,MAAM,GAAG,OAAO,CAAC,MAAM,CAAC;IAuCxD;;;;OAIG;IACG,sBAAsB,CAAC,WAAW,EAAE,MAAM,GAAG,OAAO,CAAC,oBAAoB,GAAG,IAAI,CAAC;IAWvF;;;;OAIG;IACG,mBAAmB,CAAC,WAAW,EAAE,MAAM,GAAG,OAAO,CAAC,iBAAiB,GAAG,IAAI,CAAC;CAWlF"}

package/dist/AuthBroker.js

@@ -4,7 +4,15 @@
  */
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.AuthBroker = void 0;
-const logger_1 = require("@mcp-abap-adt/logger");
+/**
+ * No-op logger implementation for default fallback when logger is not provided
+ */
+const noOpLogger = {
+    info: () => { },
+    error: () => { },
+    warn: () => { },
+    debug: () => { },
+};
 /**
  * AuthBroker manages JWT authentication tokens for destinations
  */
@@ -23,14 +31,27 @@ class AuthBroker {
      * @param browser Optional browser name for authentication (chrome, edge, firefox, system, none).
      *                Default: 'system' (system default browser).
      *                Use 'none' to print URL instead of opening browser.
-     * @param logger Optional logger instance. If not provided, uses default logger.
+     * @param logger Optional logger instance implementing ILogger interface. If not provided, uses no-op logger.
      */
     constructor(stores, browser, logger) {
+        // Validate that stores and provider are provided and not null/undefined
+        if (!stores) {
+            throw new Error('AuthBroker: stores parameter is required');
+        }
+        if (!stores.serviceKeyStore) {
+            throw new Error('AuthBroker: serviceKeyStore is required');
+        }
+        if (!stores.sessionStore) {
+            throw new Error('AuthBroker: sessionStore is required');
+        }
+        if (!stores.tokenProvider) {
+            throw new Error('AuthBroker: tokenProvider is required');
+        }
         this.serviceKeyStore = stores.serviceKeyStore;
         this.sessionStore = stores.sessionStore;
         this.tokenProvider = stores.tokenProvider;
         this.browser = browser || 'system';
-        this.logger = logger || logger_1.defaultLogger;
+        this.logger = logger || noOpLogger;
     }
     /**
      * Get authentication token for destination.

package/dist/index.d.ts

@@ -6,6 +6,6 @@ export { AuthBroker } from './AuthBroker';
 export type { IAuthorizationConfig, IConnectionConfig, IServiceKeyStore, ISessionStore } from './stores/interfaces';
 export type { IConfig } from './types';
 export type { ITokenProvider, TokenProviderOptions, TokenProviderResult } from './providers';
-export type { Logger } from '@mcp-abap-adt/logger';
+export type { ILogger } from '@mcp-abap-adt/interfaces';
 export type { AuthType } from '@mcp-abap-adt/interfaces';
 //# sourceMappingURL=index.d.ts.map

package/dist/index.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../src/index.ts"],"names":[],"mappings":"AAAA;;;GAGG;AAEH,OAAO,EAAE,UAAU,EAAE,MAAM,cAAc,CAAC;AAG1C,YAAY,EAAE,oBAAoB,EAAE,iBAAiB,EAAE,gBAAgB,EAAE,aAAa,EAAE,MAAM,qBAAqB,CAAC;AACpH,YAAY,EAAE,OAAO,EAAE,MAAM,SAAS,CAAC;AAEvC,YAAY,EAAE,cAAc,EAAE,oBAAoB,EAAE,mBAAmB,EAAE,MAAM,aAAa,CAAC;AAE7F,YAAY,EAAE,MAAM,EAAE,MAAM,sBAAsB,CAAC;AAEnD,YAAY,EAAE,QAAQ,EAAE,MAAM,0BAA0B,CAAC"}
+{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../src/index.ts"],"names":[],"mappings":"AAAA;;;GAGG;AAEH,OAAO,EAAE,UAAU,EAAE,MAAM,cAAc,CAAC;AAG1C,YAAY,EAAE,oBAAoB,EAAE,iBAAiB,EAAE,gBAAgB,EAAE,aAAa,EAAE,MAAM,qBAAqB,CAAC;AACpH,YAAY,EAAE,OAAO,EAAE,MAAM,SAAS,CAAC;AAEvC,YAAY,EAAE,cAAc,EAAE,oBAAoB,EAAE,mBAAmB,EAAE,MAAM,aAAa,CAAC;AAE7F,YAAY,EAAE,OAAO,EAAE,MAAM,0BAA0B,CAAC;AAExD,YAAY,EAAE,QAAQ,EAAE,MAAM,0BAA0B,CAAC"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mcp-abap-adt/auth-broker",
-  "version": "0.1.8",
+  "version": "0.1.10",
   "description": "JWT authentication broker for MCP ABAP ADT - manages tokens based on destination headers",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
@@ -51,14 +51,11 @@
     "node": ">=18.0.0"
   },
   "dependencies": {
-    "@mcp-abap-adt/connection": "^0.1.14",
-    "@mcp-abap-adt/interfaces": "^0.1.0",
-    "@mcp-abap-adt/logger": "^0.1.0"
+    "@mcp-abap-adt/interfaces": "^0.1.1"
   },
   "devDependencies": {
-    "@mcp-abap-adt/auth-providers": "^0.1.0",
-    "@mcp-abap-adt/auth-stores-btp": "^0.1.0",
-    "@mcp-abap-adt/auth-stores-xsuaa": "^0.1.0",
+    "@mcp-abap-adt/auth-providers": "^0.1.2",
+    "@mcp-abap-adt/auth-stores": "^0.1.4",
     "@types/express": "^5.0.5",
     "@types/jest": "^30.0.0",
     "@types/js-yaml": "^4.0.9",