@mcp-abap-adt/adt-clients 5.7.0 → 5.8.0

package/dist/core/functionInclude/AdtFunctionInclude.d.ts

@@ -46,9 +46,21 @@ export declare class AdtFunctionInclude implements IAdtObject<IFunctionIncludeCo
      */
     create(config: IFunctionIncludeConfig, options?: IAdtOperationOptions): Promise<IFunctionIncludeState>;
     /**
-     * Read function include metadata.
+     * Read function include SOURCE code.
+     *
+     * Per the IAdtObject contract, `read()` returns source for objects that have
+     * it (metadata is available via `readMetadata()`). This object has source, so
+     * `read()` is an alias of `readSource()`. (Historically it returned metadata,
+     * which was inconsistent with class/program/function-module `read()`.)
      */
-    read(config: Partial<IFunctionIncludeConfig>, version?: 'active' | 'inactive', options?: IReadOptions): Promise<IFunctionIncludeState | undefined>;
+    read(config: Partial<IFunctionIncludeConfig>, version?: 'active' | 'inactive', _options?: IReadOptions): Promise<IFunctionIncludeState | undefined>;
+    /**
+     * Low-level metadata read (the object's `finclude` XML), with 404 -> undefined.
+     * Used by readMetadata() and by the create/update readiness polling, which
+     * need metadata semantics and long-polling options (the source endpoint does
+     * not take them).
+     */
+    private readMetadataRaw;
     /**
      * Read function include source code.
      */

package/dist/core/functionInclude/AdtFunctionInclude.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"AdtFunctionInclude.d.ts","sourceRoot":"","sources":["../../../src/core/functionInclude/AdtFunctionInclude.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;GAeG;AAEH,OAAO,KAAK,EAEV,eAAe,EACf,UAAU,EACV,oBAAoB,EACpB,OAAO,EACR,MAAM,0BAA0B,CAAC;AAClC,OAAO,KAAK,EAAE,iBAAiB,EAAE,MAAM,yBAAyB,CAAC;AAEjE,OAAO,KAAK,EAAE,gBAAgB,EAAE,MAAM,wBAAwB,CAAC;AAU/D,OAAO,EAAE,KAAK,YAAY,EAAuB,MAAM,QAAQ,CAAC;AAEhE,OAAO,KAAK,EAEV,sBAAsB,EACtB,qBAAqB,EACtB,MAAM,SAAS,CAAC;AAMjB,qBAAa,kBACX,YAAW,UAAU,CAAC,sBAAsB,EAAE,qBAAqB,CAAC;IAEpE,SAAS,CAAC,QAAQ,CAAC,UAAU,EAAE,eAAe,CAAC;IAC/C,SAAS,CAAC,QAAQ,CAAC,MAAM,CAAC,EAAE,OAAO,CAAC;IACpC,SAAS,CAAC,QAAQ,CAAC,aAAa,EAAE,iBAAiB,CAAC;IACpD,SAAS,CAAC,QAAQ,CAAC,YAAY,CAAC,EAAE,gBAAgB,CAAC;IACnD,SAAgB,UAAU,EAAE,MAAM,CAAqB;gBAGrD,UAAU,EAAE,eAAe,EAC3B,MAAM,CAAC,EAAE,OAAO,EAChB,aAAa,CAAC,EAAE,iBAAiB,EACjC,YAAY,CAAC,EAAE,gBAAgB;IAQjC;;OAEG;IACH,OAAO,CAAC,iBAAiB;IAczB,OAAO,CAAC,iBAAiB;IAUzB;;;OAGG;IACH,OAAO,CAAC,yBAAyB;IAIjC,OAAO,CAAC,SAAS;IAIjB;;OAEG;IACG,QAAQ,CACZ,MAAM,EAAE,OAAO,CAAC,sBAAsB,CAAC,GACtC,OAAO,CAAC,qBAAqB,CAAC;IAsBjC;;OAEG;IACG,MAAM,CACV,MAAM,EAAE,sBAAsB,EAC9B,OAAO,CAAC,EAAE,oBAAoB,GAC7B,OAAO,CAAC,qBAAqB,CAAC;IA+HjC;;OAEG;IACG,IAAI,CACR,MAAM,EAAE,OAAO,CAAC,sBAAsB,CAAC,EACvC,OAAO,CAAC,EAAE,QAAQ,GAAG,UAAU,EAC/B,OAAO,CAAC,EAAE,YAAY,GACrB,OAAO,CAAC,qBAAqB,GAAG,SAAS,CAAC;IA2B7C;;OAEG;IACG,UAAU,CACd,MAAM,EAAE,OAAO,CAAC,sBAAsB,CAAC,EACvC,OAAO,CAAC,EAAE,QAAQ,GAAG,UAAU,GAC9B,OAAO,CAAC,qBAAqB,GAAG,SAAS,CAAC;IA0B7C;;OAEG;IACG,YAAY,CAChB,MAAM,EAAE,OAAO,CAAC,sBAAsB,CAAC,EACvC,OAAO,CAAC,EAAE,YAAY,GAAG;QAAE,OAAO,CAAC,EAAE,QAAQ,GAAG,UAAU,CAAA;KAAE,GAC3D,OAAO,CAAC,qBAAqB,CAAC;IAsDjC;;OAEG;IACG,MAAM,CACV,MAAM,EAAE,OAAO,CAAC,sBAAsB,CAAC,EACvC,OAAO,CAAC,EAAE,oBAAoB,GAC7B,OAAO,CAAC,qBAAqB,CAAC;IA8NjC;;OAEG;IACG,MAAM,CACV,MAAM,EAAE,OAAO,CAAC,sBAAsB,CAAC,GACtC,OAAO,CAAC,qBAAqB,CAAC;IAkCjC;;OAEG;IACG,QAAQ,CACZ,MAAM,EAAE,OAAO,CAAC,sBAAsB,CAAC,GACtC,OAAO,CAAC,qBAAqB,CAAC;IAuBjC;;OAEG;IACG,KAAK,CACT,MAAM,EAAE,OAAO,CAAC,sBAAsB,CAAC,EACvC,MAAM,CAAC,EAAE,MAAM,GACd,OAAO,CAAC,qBAAqB,CAAC;IAqBjC;;OAEG;IACG,aAAa,IAAI,OAAO,CAAC,qBAAqB,CAAC;IASrD;;OAEG;IACG,IAAI,CAAC,MAAM,EAAE,OAAO,CAAC,sBAAsB,CAAC,GAAG,OAAO,CAAC,MAAM,CAAC;IAepE;;OAEG;IACG,MAAM,CACV,MAAM,EAAE,OAAO,CAAC,sBAAsB,CAAC,EACvC,UAAU,EAAE,MAAM,GACjB,OAAO,CAAC,qBAAqB,CAAC;CAelC"}
+{"version":3,"file":"AdtFunctionInclude.d.ts","sourceRoot":"","sources":["../../../src/core/functionInclude/AdtFunctionInclude.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;GAeG;AAEH,OAAO,KAAK,EAEV,eAAe,EACf,UAAU,EACV,oBAAoB,EACpB,OAAO,EACR,MAAM,0BAA0B,CAAC;AAClC,OAAO,KAAK,EAAE,iBAAiB,EAAE,MAAM,yBAAyB,CAAC;AAEjE,OAAO,KAAK,EAAE,gBAAgB,EAAE,MAAM,wBAAwB,CAAC;AAU/D,OAAO,EAAE,KAAK,YAAY,EAAuB,MAAM,QAAQ,CAAC;AAEhE,OAAO,KAAK,EAEV,sBAAsB,EACtB,qBAAqB,EACtB,MAAM,SAAS,CAAC;AAMjB,qBAAa,kBACX,YAAW,UAAU,CAAC,sBAAsB,EAAE,qBAAqB,CAAC;IAEpE,SAAS,CAAC,QAAQ,CAAC,UAAU,EAAE,eAAe,CAAC;IAC/C,SAAS,CAAC,QAAQ,CAAC,MAAM,CAAC,EAAE,OAAO,CAAC;IACpC,SAAS,CAAC,QAAQ,CAAC,aAAa,EAAE,iBAAiB,CAAC;IACpD,SAAS,CAAC,QAAQ,CAAC,YAAY,CAAC,EAAE,gBAAgB,CAAC;IACnD,SAAgB,UAAU,EAAE,MAAM,CAAqB;gBAGrD,UAAU,EAAE,eAAe,EAC3B,MAAM,CAAC,EAAE,OAAO,EAChB,aAAa,CAAC,EAAE,iBAAiB,EACjC,YAAY,CAAC,EAAE,gBAAgB;IAQjC;;OAEG;IACH,OAAO,CAAC,iBAAiB;IAczB,OAAO,CAAC,iBAAiB;IAUzB;;;OAGG;IACH,OAAO,CAAC,yBAAyB;IAIjC,OAAO,CAAC,SAAS;IAIjB;;OAEG;IACG,QAAQ,CACZ,MAAM,EAAE,OAAO,CAAC,sBAAsB,CAAC,GACtC,OAAO,CAAC,qBAAqB,CAAC;IAsBjC;;OAEG;IACG,MAAM,CACV,MAAM,EAAE,sBAAsB,EAC9B,OAAO,CAAC,EAAE,oBAAoB,GAC7B,OAAO,CAAC,qBAAqB,CAAC;IA+HjC;;;;;;;OAOG;IACG,IAAI,CACR,MAAM,EAAE,OAAO,CAAC,sBAAsB,CAAC,EACvC,OAAO,CAAC,EAAE,QAAQ,GAAG,UAAU,EAC/B,QAAQ,CAAC,EAAE,YAAY,GACtB,OAAO,CAAC,qBAAqB,GAAG,SAAS,CAAC;IAI7C;;;;;OAKG;YACW,eAAe;IA+B7B;;OAEG;IACG,UAAU,CACd,MAAM,EAAE,OAAO,CAAC,sBAAsB,CAAC,EACvC,OAAO,CAAC,EAAE,QAAQ,GAAG,UAAU,GAC9B,OAAO,CAAC,qBAAqB,GAAG,SAAS,CAAC;IA0B7C;;OAEG;IACG,YAAY,CAChB,MAAM,EAAE,OAAO,CAAC,sBAAsB,CAAC,EACvC,OAAO,CAAC,EAAE,YAAY,GAAG;QAAE,OAAO,CAAC,EAAE,QAAQ,GAAG,UAAU,CAAA;KAAE,GAC3D,OAAO,CAAC,qBAAqB,CAAC;IAsDjC;;OAEG;IACG,MAAM,CACV,MAAM,EAAE,OAAO,CAAC,sBAAsB,CAAC,EACvC,OAAO,CAAC,EAAE,oBAAoB,GAC7B,OAAO,CAAC,qBAAqB,CAAC;IA8NjC;;OAEG;IACG,MAAM,CACV,MAAM,EAAE,OAAO,CAAC,sBAAsB,CAAC,GACtC,OAAO,CAAC,qBAAqB,CAAC;IAkCjC;;OAEG;IACG,QAAQ,CACZ,MAAM,EAAE,OAAO,CAAC,sBAAsB,CAAC,GACtC,OAAO,CAAC,qBAAqB,CAAC;IAuBjC;;OAEG;IACG,KAAK,CACT,MAAM,EAAE,OAAO,CAAC,sBAAsB,CAAC,EACvC,MAAM,CAAC,EAAE,MAAM,GACd,OAAO,CAAC,qBAAqB,CAAC;IAqBjC;;OAEG;IACG,aAAa,IAAI,OAAO,CAAC,qBAAqB,CAAC;IASrD;;OAEG;IACG,IAAI,CAAC,MAAM,EAAE,OAAO,CAAC,sBAAsB,CAAC,GAAG,OAAO,CAAC,MAAM,CAAC;IAepE;;OAEG;IACG,MAAM,CACV,MAAM,EAAE,OAAO,CAAC,sBAAsB,CAAC,EACvC,UAAU,EAAE,MAAM,GACjB,OAAO,CAAC,qBAAqB,CAAC;CAelC"}

package/dist/core/functionInclude/AdtFunctionInclude.js

@@ -165,9 +165,23 @@ class AdtFunctionInclude {
         }
     }
     /**
-     * Read function include metadata.
+     * Read function include SOURCE code.
+     *
+     * Per the IAdtObject contract, `read()` returns source for objects that have
+     * it (metadata is available via `readMetadata()`). This object has source, so
+     * `read()` is an alias of `readSource()`. (Historically it returned metadata,
+     * which was inconsistent with class/program/function-module `read()`.)
      */
-    async read(config, version, options) {
+    async read(config, version, _options) {
+        return this.readSource(config, version);
+    }
+    /**
+     * Low-level metadata read (the object's `finclude` XML), with 404 -> undefined.
+     * Used by readMetadata() and by the create/update readiness polling, which
+     * need metadata semantics and long-polling options (the source endpoint does
+     * not take them).
+     */
+    async readMetadataRaw(config, version, options) {
         if (!config.functionGroupName) {
             throw new Error('Function group name is required');
         }
@@ -234,7 +248,7 @@ class AdtFunctionInclude {
             throw error;
         }
         try {
-            const readState = await this.read(config, options?.version ?? 'active', options);
+            const readState = await this.readMetadataRaw(config, options?.version ?? 'active', options);
             if (readState) {
                 state.metadataResult = readState.readResult;
                 state.readResult = readState.readResult;
@@ -315,7 +329,7 @@ class AdtFunctionInclude {
                 // Wait for object to be ready after update
                 this.logger?.info?.('read (wait for object ready after update)');
                 try {
-                    await this.read({
+                    await this.readMetadataRaw({
                         functionGroupName: fullConfig.functionGroupName,
                         includeName: fullConfig.includeName,
                     }, 'active', { withLongPolling: true });
@@ -341,7 +355,7 @@ class AdtFunctionInclude {
                 const activateResponse = await (0, activation_1.activateFunctionInclude)(this.connection, fullConfig.functionGroupName, fullConfig.includeName);
                 state.activateResult = activateResponse;
                 try {
-                    const readState = await this.read({
+                    const readState = await this.readMetadataRaw({
                         functionGroupName: fullConfig.functionGroupName,
                         includeName: fullConfig.includeName,
                     }, 'active', { withLongPolling: true });

package/dist/core/functionInclude/delete.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"delete.d.ts","sourceRoot":"","sources":["../../../src/core/functionInclude/delete.ts"],"names":[],"mappings":"AAAA;;GAEG;AAEH,OAAO,KAAK,EACV,YAAY,IAAI,aAAa,EAC7B,eAAe,EAChB,MAAM,0BAA0B,CAAC;AAUlC,MAAM,WAAW,4BAA4B;IAC3C,mBAAmB,EAAE,MAAM,CAAC;IAC5B,YAAY,EAAE,MAAM,CAAC;IACrB,iBAAiB,CAAC,EAAE,MAAM,CAAC;CAC5B;AAQD;;GAEG;AACH,wBAAsB,aAAa,CACjC,UAAU,EAAE,eAAe,EAC3B,MAAM,EAAE,4BAA4B,GACnC,OAAO,CAAC,aAAa,CAAC,CAyBxB;AAED;;GAEG;AACH,wBAAsB,qBAAqB,CACzC,UAAU,EAAE,eAAe,EAC3B,MAAM,EAAE,4BAA4B,GACnC,OAAO,CAAC,aAAa,CAAC,CA0CxB"}
+{"version":3,"file":"delete.d.ts","sourceRoot":"","sources":["../../../src/core/functionInclude/delete.ts"],"names":[],"mappings":"AAAA;;GAEG;AAEH,OAAO,KAAK,EACV,YAAY,IAAI,aAAa,EAC7B,eAAe,EAChB,MAAM,0BAA0B,CAAC;AAgElC,MAAM,WAAW,4BAA4B;IAC3C,mBAAmB,EAAE,MAAM,CAAC;IAC5B,YAAY,EAAE,MAAM,CAAC;IACrB,iBAAiB,CAAC,EAAE,MAAM,CAAC;CAC5B;AAQD;;GAEG;AACH,wBAAsB,aAAa,CACjC,UAAU,EAAE,eAAe,EAC3B,MAAM,EAAE,4BAA4B,GACnC,OAAO,CAAC,aAAa,CAAC,CAyBxB;AAED;;GAEG;AACH,wBAAsB,qBAAqB,CACzC,UAAU,EAAE,eAAe,EAC3B,MAAM,EAAE,4BAA4B,GACnC,OAAO,CAAC,aAAa,CAAC,CA8CxB"}

package/dist/core/functionInclude/delete.js

@@ -5,9 +5,49 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.checkDeletion = checkDeletion;
 exports.deleteFunctionInclude = deleteFunctionInclude;
+const fast_xml_parser_1 = require("fast-xml-parser");
 const contentTypes_1 = require("../../constants/contentTypes");
 const internalUtils_1 = require("../../utils/internalUtils");
 const timeouts_1 = require("../../utils/timeouts");
+/**
+ * Parse a `del:deletionResult` and throw if the server did not delete.
+ *
+ * The ADT deletion service answers HTTP 200 even when it refuses to delete:
+ * `<del:object del:isDeleted="false"><del:message del:type="E"><del:text>…`.
+ * Some function-group includes can only be removed via the Function Builder, so
+ * we MUST surface that instead of reporting a phantom success.
+ */
+function assertDeleted(responseData, includeName) {
+    const parser = new fast_xml_parser_1.XMLParser({
+        ignoreAttributes: false,
+        attributeNamePrefix: '@_',
+    });
+    let deleteObject;
+    try {
+        const result = parser.parse(String(responseData ?? ''));
+        const deletionResult = (result['del:deletionResult'] ??
+            result.deletionResult);
+        deleteObject = (deletionResult?.['del:object'] ??
+            deletionResult?.object);
+    }
+    catch {
+        // Malformed/empty body — treat as a failed parse below.
+        deleteObject = undefined;
+    }
+    const isDeleted = deleteObject?.['@_del:isDeleted'] === 'true' ||
+        deleteObject?.['@_isDeleted'] === 'true';
+    if (isDeleted) {
+        return;
+    }
+    // `del:text` may be a plain string, or an object ({ '#text', atom:link }) when
+    // the message carries a longtext link — normalize both to the text.
+    const rawText = deleteObject?.['del:message']?.['del:text'] ??
+        deleteObject?.message?.text;
+    const message = typeof rawText === 'string'
+        ? rawText
+        : rawText?.['#text'];
+    throw new Error(`Function include ${includeName} was not deleted${message ? `: ${message}` : ' (server reported isDeleted=false)'}`);
+}
 function objectUri(groupName, includeName) {
     const groupLower = (0, internalUtils_1.encodeSapObjectName)(groupName).toLowerCase();
     const encodedInclude = (0, internalUtils_1.encodeSapObjectName)(includeName.toUpperCase());
@@ -69,6 +109,9 @@ async function deleteFunctionInclude(connection, params) {
             'Content-Type': contentTypes_1.CT_DELETION,
         },
     });
+    // The service returns HTTP 200 even when it refuses to delete; verify the
+    // result element instead of assuming success.
+    assertDeleted(response.data, params.include_name);
     return {
         ...response,
         data: {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mcp-abap-adt/adt-clients",
-  "version": "5.7.0",
+  "version": "5.8.0",
   "description": "ADT clients for SAP ABAP systems - AdtClient and AdtRuntimeClient",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",