@mcp-abap-adt/adt-clients 5.7.0 → 5.7.1

package/dist/core/functionInclude/delete.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"delete.d.ts","sourceRoot":"","sources":["../../../src/core/functionInclude/delete.ts"],"names":[],"mappings":"AAAA;;GAEG;AAEH,OAAO,KAAK,EACV,YAAY,IAAI,aAAa,EAC7B,eAAe,EAChB,MAAM,0BAA0B,CAAC;AAUlC,MAAM,WAAW,4BAA4B;IAC3C,mBAAmB,EAAE,MAAM,CAAC;IAC5B,YAAY,EAAE,MAAM,CAAC;IACrB,iBAAiB,CAAC,EAAE,MAAM,CAAC;CAC5B;AAQD;;GAEG;AACH,wBAAsB,aAAa,CACjC,UAAU,EAAE,eAAe,EAC3B,MAAM,EAAE,4BAA4B,GACnC,OAAO,CAAC,aAAa,CAAC,CAyBxB;AAED;;GAEG;AACH,wBAAsB,qBAAqB,CACzC,UAAU,EAAE,eAAe,EAC3B,MAAM,EAAE,4BAA4B,GACnC,OAAO,CAAC,aAAa,CAAC,CA0CxB"}
+{"version":3,"file":"delete.d.ts","sourceRoot":"","sources":["../../../src/core/functionInclude/delete.ts"],"names":[],"mappings":"AAAA;;GAEG;AAEH,OAAO,KAAK,EACV,YAAY,IAAI,aAAa,EAC7B,eAAe,EAChB,MAAM,0BAA0B,CAAC;AAgElC,MAAM,WAAW,4BAA4B;IAC3C,mBAAmB,EAAE,MAAM,CAAC;IAC5B,YAAY,EAAE,MAAM,CAAC;IACrB,iBAAiB,CAAC,EAAE,MAAM,CAAC;CAC5B;AAQD;;GAEG;AACH,wBAAsB,aAAa,CACjC,UAAU,EAAE,eAAe,EAC3B,MAAM,EAAE,4BAA4B,GACnC,OAAO,CAAC,aAAa,CAAC,CAyBxB;AAED;;GAEG;AACH,wBAAsB,qBAAqB,CACzC,UAAU,EAAE,eAAe,EAC3B,MAAM,EAAE,4BAA4B,GACnC,OAAO,CAAC,aAAa,CAAC,CA8CxB"}

package/dist/core/functionInclude/delete.js

@@ -5,9 +5,49 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.checkDeletion = checkDeletion;
 exports.deleteFunctionInclude = deleteFunctionInclude;
+const fast_xml_parser_1 = require("fast-xml-parser");
 const contentTypes_1 = require("../../constants/contentTypes");
 const internalUtils_1 = require("../../utils/internalUtils");
 const timeouts_1 = require("../../utils/timeouts");
+/**
+ * Parse a `del:deletionResult` and throw if the server did not delete.
+ *
+ * The ADT deletion service answers HTTP 200 even when it refuses to delete:
+ * `<del:object del:isDeleted="false"><del:message del:type="E"><del:text>…`.
+ * Some function-group includes can only be removed via the Function Builder, so
+ * we MUST surface that instead of reporting a phantom success.
+ */
+function assertDeleted(responseData, includeName) {
+    const parser = new fast_xml_parser_1.XMLParser({
+        ignoreAttributes: false,
+        attributeNamePrefix: '@_',
+    });
+    let deleteObject;
+    try {
+        const result = parser.parse(String(responseData ?? ''));
+        const deletionResult = (result['del:deletionResult'] ??
+            result.deletionResult);
+        deleteObject = (deletionResult?.['del:object'] ??
+            deletionResult?.object);
+    }
+    catch {
+        // Malformed/empty body — treat as a failed parse below.
+        deleteObject = undefined;
+    }
+    const isDeleted = deleteObject?.['@_del:isDeleted'] === 'true' ||
+        deleteObject?.['@_isDeleted'] === 'true';
+    if (isDeleted) {
+        return;
+    }
+    // `del:text` may be a plain string, or an object ({ '#text', atom:link }) when
+    // the message carries a longtext link — normalize both to the text.
+    const rawText = deleteObject?.['del:message']?.['del:text'] ??
+        deleteObject?.message?.text;
+    const message = typeof rawText === 'string'
+        ? rawText
+        : rawText?.['#text'];
+    throw new Error(`Function include ${includeName} was not deleted${message ? `: ${message}` : ' (server reported isDeleted=false)'}`);
+}
 function objectUri(groupName, includeName) {
     const groupLower = (0, internalUtils_1.encodeSapObjectName)(groupName).toLowerCase();
     const encodedInclude = (0, internalUtils_1.encodeSapObjectName)(includeName.toUpperCase());
@@ -69,6 +109,9 @@ async function deleteFunctionInclude(connection, params) {
             'Content-Type': contentTypes_1.CT_DELETION,
         },
     });
+    // The service returns HTTP 200 even when it refuses to delete; verify the
+    // result element instead of assuming success.
+    assertDeleted(response.data, params.include_name);
     return {
         ...response,
         data: {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mcp-abap-adt/adt-clients",
-  "version": "5.7.0",
+  "version": "5.7.1",
   "description": "ADT clients for SAP ABAP systems - AdtClient and AdtRuntimeClient",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",