@mcp-abap-adt/adt-clients 5.4.2 → 5.4.3

package/dist/core/accessControl/AdtAccessControl.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"AdtAccessControl.d.ts","sourceRoot":"","sources":["../../../src/core/accessControl/AdtAccessControl.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;GAkBG;AAEH,OAAO,KAAK,EAEV,eAAe,EACf,UAAU,EACV,oBAAoB,EACpB,OAAO,EACR,MAAM,0BAA0B,CAAC;AAClC,OAAO,KAAK,EAAE,iBAAiB,EAAE,MAAM,yBAAyB,CAAC;AAEjE,OAAO,KAAK,EAAE,YAAY,EAAE,MAAM,iBAAiB,CAAC;AAWpD,OAAO,KAAK,EAAE,oBAAoB,EAAE,mBAAmB,EAAE,MAAM,SAAS,CAAC;AAKzE,qBAAa,gBACX,YAAW,UAAU,CAAC,oBAAoB,EAAE,mBAAmB,CAAC;IAEhE,OAAO,CAAC,QAAQ,CAAC,UAAU,CAAkB;IAC7C,OAAO,CAAC,QAAQ,CAAC,MAAM,CAAC,CAAU;IAClC,OAAO,CAAC,QAAQ,CAAC,aAAa,CAAoB;IAClD,SAAgB,UAAU,EAAE,MAAM,CAAmB;gBAGnD,UAAU,EAAE,eAAe,EAC3B,MAAM,CAAC,EAAE,OAAO,EAChB,aAAa,CAAC,EAAE,iBAAiB;IAOnC;;OAEG;IACG,QAAQ,CACZ,MAAM,EAAE,OAAO,CAAC,oBAAoB,CAAC,GACpC,OAAO,CAAC,mBAAmB,CAAC;IA6B/B;;OAEG;IACG,MAAM,CACV,MAAM,EAAE,oBAAoB,EAC5B,OAAO,CAAC,EAAE,oBAAoB,GAC7B,OAAO,CAAC,mBAAmB,CAAC;IAoC/B;;OAEG;IACG,IAAI,CACR,MAAM,EAAE,OAAO,CAAC,oBAAoB,CAAC,EACrC,OAAO,CAAC,EAAE,QAAQ,GAAG,UAAU,EAC/B,OAAO,CAAC,EAAE,YAAY,GACrB,OAAO,CAAC,mBAAmB,GAAG,SAAS,CAAC;IA2B3C;;OAEG;IACG,YAAY,CAChB,MAAM,EAAE,OAAO,CAAC,oBAAoB,CAAC,EACrC,OAAO,CAAC,EAAE,YAAY,GACrB,OAAO,CAAC,mBAAmB,CAAC;IAkC/B;;OAEG;IACG,aAAa,CACjB,MAAM,EAAE,OAAO,CAAC,oBAAoB,CAAC,EACrC,OAAO,CAAC,EAAE;QAAE,eAAe,CAAC,EAAE,OAAO,CAAA;KAAE,GACtC,OAAO,CAAC,mBAAmB,CAAC;IAkC/B;;;;OAIG;IACG,MAAM,CACV,MAAM,EAAE,OAAO,CAAC,oBAAoB,CAAC,EACrC,OAAO,CAAC,EAAE,oBAAoB,GAC7B,OAAO,CAAC,mBAAmB,CAAC;IA8M/B;;OAEG;IACG,MAAM,CACV,MAAM,EAAE,OAAO,CAAC,oBAAoB,CAAC,GACpC,OAAO,CAAC,mBAAmB,CAAC;IAmC/B;;;OAGG;IACG,QAAQ,CACZ,MAAM,EAAE,OAAO,CAAC,oBAAoB,CAAC,GACpC,OAAO,CAAC,mBAAmB,CAAC;IAqB/B;;OAEG;IACG,KAAK,CACT,MAAM,EAAE,OAAO,CAAC,oBAAoB,CAAC,EACrC,MAAM,CAAC,EAAE,MAAM,GACd,OAAO,CAAC,mBAAmB,CAAC;IAkB/B;;OAEG;IACG,IAAI,CAAC,MAAM,EAAE,OAAO,CAAC,oBAAoB,CAAC,GAAG,OAAO,CAAC,MAAM,CAAC;IAclE;;OAEG;IACG,MAAM,CACV,MAAM,EAAE,OAAO,CAAC,oBAAoB,CAAC,EACrC,UAAU,EAAE,MAAM,GACjB,OAAO,CAAC,mBAAmB,CAAC;CAiBhC"}
+{"version":3,"file":"AdtAccessControl.d.ts","sourceRoot":"","sources":["../../../src/core/accessControl/AdtAccessControl.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;GAkBG;AAEH,OAAO,KAAK,EAEV,eAAe,EACf,UAAU,EACV,oBAAoB,EACpB,OAAO,EACR,MAAM,0BAA0B,CAAC;AAClC,OAAO,KAAK,EAAE,iBAAiB,EAAE,MAAM,yBAAyB,CAAC;AAEjE,OAAO,KAAK,EAAE,YAAY,EAAE,MAAM,iBAAiB,CAAC;AAWpD,OAAO,KAAK,EAAE,oBAAoB,EAAE,mBAAmB,EAAE,MAAM,SAAS,CAAC;AAKzE,qBAAa,gBACX,YAAW,UAAU,CAAC,oBAAoB,EAAE,mBAAmB,CAAC;IAEhE,OAAO,CAAC,QAAQ,CAAC,UAAU,CAAkB;IAC7C,OAAO,CAAC,QAAQ,CAAC,MAAM,CAAC,CAAU;IAClC,OAAO,CAAC,QAAQ,CAAC,aAAa,CAAoB;IAClD,SAAgB,UAAU,EAAE,MAAM,CAAmB;gBAGnD,UAAU,EAAE,eAAe,EAC3B,MAAM,CAAC,EAAE,OAAO,EAChB,aAAa,CAAC,EAAE,iBAAiB;IAOnC;;OAEG;IACG,QAAQ,CACZ,MAAM,EAAE,OAAO,CAAC,oBAAoB,CAAC,GACpC,OAAO,CAAC,mBAAmB,CAAC;IA6B/B;;OAEG;IACG,MAAM,CACV,MAAM,EAAE,oBAAoB,EAC5B,OAAO,CAAC,EAAE,oBAAoB,GAC7B,OAAO,CAAC,mBAAmB,CAAC;IAoC/B;;OAEG;IACG,IAAI,CACR,MAAM,EAAE,OAAO,CAAC,oBAAoB,CAAC,EACrC,OAAO,CAAC,EAAE,QAAQ,GAAG,UAAU,EAC/B,OAAO,CAAC,EAAE,YAAY,GACrB,OAAO,CAAC,mBAAmB,GAAG,SAAS,CAAC;IA2B3C;;OAEG;IACG,YAAY,CAChB,MAAM,EAAE,OAAO,CAAC,oBAAoB,CAAC,EACrC,OAAO,CAAC,EAAE,YAAY,GACrB,OAAO,CAAC,mBAAmB,CAAC;IAkC/B;;OAEG;IACG,aAAa,CACjB,MAAM,EAAE,OAAO,CAAC,oBAAoB,CAAC,EACrC,OAAO,CAAC,EAAE;QAAE,eAAe,CAAC,EAAE,OAAO,CAAA;KAAE,GACtC,OAAO,CAAC,mBAAmB,CAAC;IAkC/B;;;;OAIG;IACG,MAAM,CACV,MAAM,EAAE,OAAO,CAAC,oBAAoB,CAAC,EACrC,OAAO,CAAC,EAAE,oBAAoB,GAC7B,OAAO,CAAC,mBAAmB,CAAC;IAiN/B;;OAEG;IACG,MAAM,CACV,MAAM,EAAE,OAAO,CAAC,oBAAoB,CAAC,GACpC,OAAO,CAAC,mBAAmB,CAAC;IAmC/B;;;OAGG;IACG,QAAQ,CACZ,MAAM,EAAE,OAAO,CAAC,oBAAoB,CAAC,GACpC,OAAO,CAAC,mBAAmB,CAAC;IAqB/B;;OAEG;IACG,KAAK,CACT,MAAM,EAAE,OAAO,CAAC,oBAAoB,CAAC,EACrC,MAAM,CAAC,EAAE,MAAM,GACd,OAAO,CAAC,mBAAmB,CAAC;IAoB/B;;OAEG;IACG,IAAI,CAAC,MAAM,EAAE,OAAO,CAAC,oBAAoB,CAAC,GAAG,OAAO,CAAC,MAAM,CAAC;IAclE;;OAEG;IACG,MAAM,CACV,MAAM,EAAE,OAAO,CAAC,oBAAoB,CAAC,EACrC,UAAU,EAAE,MAAM,GACjB,OAAO,CAAC,mBAAmB,CAAC;CAiBhC"}

package/dist/core/accessControl/AdtAccessControl.js

@@ -232,7 +232,7 @@ class AdtAccessControl {
             const codeToCheck = options?.sourceCode || config.sourceCode;
             if (codeToCheck) {
                 this.logger?.info?.('Step 2: Checking inactive version with update content');
-                await (0, check_1.checkAccessControl)(this.connection, config.accessControlName, 'inactive', codeToCheck);
+                await (0, check_1.checkAccessControl)(this.connection, config.accessControlName, 'inactive', codeToCheck, this.logger);
                 this.logger?.info?.('Check inactive with update content passed');
             }
             // 3. Update
@@ -266,7 +266,7 @@ class AdtAccessControl {
             }
             // 5. Final check (no stateful needed)
             this.logger?.info?.('Step 5: Final check');
-            await (0, check_1.checkAccessControl)(this.connection, config.accessControlName, 'inactive');
+            await (0, check_1.checkAccessControl)(this.connection, config.accessControlName, 'inactive', undefined, this.logger);
             this.logger?.info?.('Final check passed');
             // 6. Activate (if requested, no stateful needed - uses same session/cookies)
             if (options?.activateOnUpdate) {
@@ -397,7 +397,7 @@ class AdtAccessControl {
         }
         // Map status to version
         const version = status === 'active' ? 'active' : 'inactive';
-        state.checkResult = await (0, check_1.checkAccessControl)(this.connection, config.accessControlName, version);
+        state.checkResult = await (0, check_1.checkAccessControl)(this.connection, config.accessControlName, version, undefined, this.logger);
         return state;
     }
     /**

package/dist/core/accessControl/check.d.ts

@@ -1,6 +1,13 @@
-import type { IAdtResponse as AxiosResponse, IAbapConnection } from '@mcp-abap-adt/interfaces';
+import type { IAdtResponse as AxiosResponse, IAbapConnection, ILogger } from '@mcp-abap-adt/interfaces';
 /**
  * Check access control syntax
+ *
+ * Retries once on transient `status='notProcessed'` with empty errors —
+ * observed on cloud trial under full-suite load, where the CHECK reporter
+ * occasionally returns has_errors=true without findings because async
+ * validation has not materialized yet (#20). After the retry, if the state
+ * persists with no real errors, downgrade to a warning and return the
+ * response instead of throwing with an empty message.
  */
-export declare function checkAccessControl(connection: IAbapConnection, accessControlName: string, version?: string, sourceCode?: string): Promise<AxiosResponse>;
+export declare function checkAccessControl(connection: IAbapConnection, accessControlName: string, version?: string, sourceCode?: string, logger?: ILogger): Promise<AxiosResponse>;
 //# sourceMappingURL=check.d.ts.map

package/dist/core/accessControl/check.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"check.d.ts","sourceRoot":"","sources":["../../../src/core/accessControl/check.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EACV,YAAY,IAAI,aAAa,EAC7B,eAAe,EAChB,MAAM,0BAA0B,CAAC;AAGlC;;GAEG;AACH,wBAAsB,kBAAkB,CACtC,UAAU,EAAE,eAAe,EAC3B,iBAAiB,EAAE,MAAM,EACzB,OAAO,GAAE,MAAmB,EAC5B,UAAU,CAAC,EAAE,MAAM,GAClB,OAAO,CAAC,aAAa,CAAC,CAiBxB"}
+{"version":3,"file":"check.d.ts","sourceRoot":"","sources":["../../../src/core/accessControl/check.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EACV,YAAY,IAAI,aAAa,EAC7B,eAAe,EACf,OAAO,EACR,MAAM,0BAA0B,CAAC;AAOlC;;;;;;;;;GASG;AACH,wBAAsB,kBAAkB,CACtC,UAAU,EAAE,eAAe,EAC3B,iBAAiB,EAAE,MAAM,EACzB,OAAO,GAAE,MAAmB,EAC5B,UAAU,CAAC,EAAE,MAAM,EACnB,MAAM,CAAC,EAAE,OAAO,GACf,OAAO,CAAC,aAAa,CAAC,CA2CxB"}

package/dist/core/accessControl/check.js

@@ -2,15 +2,42 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.checkAccessControl = checkAccessControl;
 const checkRun_1 = require("../../utils/checkRun");
+function delay(ms) {
+    return new Promise((resolve) => setTimeout(resolve, ms));
+}
 /**
  * Check access control syntax
+ *
+ * Retries once on transient `status='notProcessed'` with empty errors —
+ * observed on cloud trial under full-suite load, where the CHECK reporter
+ * occasionally returns has_errors=true without findings because async
+ * validation has not materialized yet (#20). After the retry, if the state
+ * persists with no real errors, downgrade to a warning and return the
+ * response instead of throwing with an empty message.
  */
-async function checkAccessControl(connection, accessControlName, version = 'inactive', sourceCode) {
-    const response = await (0, checkRun_1.runCheckRun)(connection, 'access_control', accessControlName, version, 'abapCheckRun', sourceCode);
-    const checkResult = (0, checkRun_1.parseCheckRunResponse)(response);
-    if (checkResult.has_errors) {
-        const errorMessages = checkResult.errors.map((err) => err.text).join('; ');
-        throw new Error(`Access control check failed: ${errorMessages}`);
+async function checkAccessControl(connection, accessControlName, version = 'inactive', sourceCode, logger) {
+    for (let attempt = 0; attempt < 2; attempt++) {
+        const response = await (0, checkRun_1.runCheckRun)(connection, 'access_control', accessControlName, version, 'abapCheckRun', sourceCode);
+        const checkResult = (0, checkRun_1.parseCheckRunResponse)(response);
+        if (!checkResult.has_errors) {
+            return response;
+        }
+        if (checkResult.errors.length > 0) {
+            const errorMessages = checkResult.errors
+                .map((err) => err.text)
+                .join('; ');
+            throw new Error(`Access control check failed: ${errorMessages}`);
+        }
+        // has_errors=true but errors is empty — driven by status='notProcessed'
+        // in parseCheckRunResponse. Likely transient under load.
+        if (attempt === 0) {
+            logger?.warn?.(`Access control check returned has_errors=true with empty errors (status=${checkResult.status}, message=${checkResult.message || 'none'}); retrying once`);
+            await delay(2000);
+            continue;
+        }
+        logger?.warn?.(`Access control check still has_errors=true with empty errors after retry (status=${checkResult.status}, message=${checkResult.message || 'none'}); treating as transient and continuing`);
+        return response;
     }
-    return response;
+    // Unreachable: loop returns on every path
+    throw new Error(`Access control check failed: unexpected control flow for ${accessControlName}`);
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mcp-abap-adt/adt-clients",
-  "version": "5.4.2",
+  "version": "5.4.3",
   "description": "ADT clients for SAP ABAP systems - AdtClient and AdtRuntimeClient",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",