@mcp-abap-adt/adt-clients 43.1.0 → 44.0.0

package/README.md

@@ -157,7 +157,7 @@ This package interacts with external packages **ONLY through interfaces**:
   | package | what this package takes from it |
   |---|---|
   | [`@mcp-abap-adt/interfaces-adt`](https://www.npmjs.com/package/@mcp-abap-adt/interfaces-adt) `^26.0.0` | the ADT type tables (`ADT_TYPES_ONPREM`, `ADT_TYPES_CLOUD`, `ADT_TYPES_BASIS_740`) and their code types (`AdtTypeCode`, …), the ABAP Unit run registry (`ABAP_UNIT_RUN_TYPES`, `AbapUnitRunObjectType`, `AbapUnitRunTarget`), the capability atoms, every object's config, the result-set contracts, `IAdtAnsweredObject`, `IAdtResponse`, `IAnalyse`, `IAdtAnalyseOptions`, `IAdtHeaders`, `IResultStrategy`, `ADT_NO_FAILURE`, `ADT_TASK_TYPE` |
-  | [`@mcp-abap-adt/interfaces-adt-connection`](https://www.npmjs.com/package/@mcp-abap-adt/interfaces-adt-connection) `^3.0.0` | `IAbapConnection`, `IAdtWireResponse`, `IAbapRequestOptions`, the connection capability atoms, `ADT_SESSION_ERROR` |
+  | [`@mcp-abap-adt/interfaces-adt-connection`](https://www.npmjs.com/package/@mcp-abap-adt/interfaces-adt-connection) `^4.0.0` | `IAbapConnection`, `IAdtWireResponse`, `IAbapRequestOptions`, the connection capability atoms, `ADT_SESSION_ERROR` |
   | [`@mcp-abap-adt/interfaces-network`](https://www.npmjs.com/package/@mcp-abap-adt/interfaces-network) `^2.0.1` | `IWebSocketTransport` and its four companions, `HttpError` |
   | [`@mcp-abap-adt/interfaces-utils`](https://www.npmjs.com/package/@mcp-abap-adt/interfaces-utils) `^1.1.1` | `ILogger`, `LogLevel`, `XmlNode` |
   | [`@mcp-abap-adt/interfaces-auth`](https://www.npmjs.com/package/@mcp-abap-adt/interfaces-auth) `^7.5.0` — **dev only** | `IAuthProvider`, for the test helpers that open a session |
@@ -891,12 +891,12 @@ npm run discovery:markdown -- --env /path/to/.env
 
 **Environment Variables:**
 The script uses the same environment variables as the main package:
-- `SAP_URL` - SAP system URL (required)
+- `SAP_URL` - SAP system URL (required over HTTP). The wire is the test configuration's required `environment.connection_type` (`"http"` or `"rfc"`, never guessed). Over RFC there is no URL: the address is stated instead — `SAP_ASHOST` and `SAP_SYSNR`, or `SAP_MSHOST` with `SAP_MSSERV` and/or `SAP_SYSID` and `SAP_GROUP` — with `SAP_LANGUAGE`, and `SAP_SAPROUTER` when needed; a `SAP_URL` beside it is refused
 - `SAP_AUTH_TYPE` - Authentication type: `'basic'`, `'jwt'` or `'xsuaa'` (required: a missing or other value is refused, naming the key)
 - `SAP_USERNAME` - Username for basic auth
 - `SAP_PASSWORD` - Password for basic auth
 - `SAP_JWT_TOKEN` - JWT token for JWT auth
-- `SAP_CLIENT` - Client number (optional)
+- `SAP_CLIENT` - Client number (optional over HTTP, required over RFC)
 
 **When to use:**
 - To explore available ADT API endpoints on your SAP system
@@ -1420,7 +1420,7 @@ everything else is not.
 
 ### Single Definition Site: the contract packages
 
-Since **7.5.0**, every contract type is **defined once**, in the contract packages — today `@mcp-abap-adt/interfaces-adt` (`^26.0.0`) for the ADT contracts and `@mcp-abap-adt/interfaces-adt-connection` (`^3.0.0`) for the connection. This package declares no copies of its own — every `IXxxConfig`, the capability atoms, the result-set contracts a factory accepts (`IClassResults`, …, since 38.0.0), the option and response types and the cross-cutting shared types all live there.
+Since **7.5.0**, every contract type is **defined once**, in the contract packages — today `@mcp-abap-adt/interfaces-adt` (`^26.0.0`) for the ADT contracts and `@mcp-abap-adt/interfaces-adt-connection` (`^4.0.0`) for the connection. This package declares no copies of its own — every `IXxxConfig`, the capability atoms, the result-set contracts a factory accepts (`IClassResults`, …, since 38.0.0), the option and response types and the cross-cutting shared types all live there.
 
 **Import them from the package that owns them:**
 
@@ -1641,6 +1641,7 @@ See [Architecture Documentation](docs/architecture/ARCHITECTURE.md#type-system-a
 One document per breaking release, each written for a consumer on the contract
 before it:
 
+- **[43.x → 44.0.0](docs/usage/MIGRATION-44.md)** — `@mcp-abap-adt/interfaces-adt-connection` 4: `getBaseUrl()` answers `Promise<string | undefined>` (`undefined` over RFC), `AdtBatchConnection` hands it on and `isCloudEnvironment` asks `systeminformation` without a URL; adt-strategies 0.21.0 and adt-clients-legacy 0.8.0 declare the same range. The test configuration states `environment.connection_type` (required, `"http"` or `"rfc"`); over RFC it states `SAP_ASHOST` + `SAP_SYSNR` (or the message-server keys), `SAP_CLIENT` and `SAP_LANGUAGE`, and no `SAP_URL`.
 - **[42.x → 43.0.0](docs/usage/MIGRATION-43.md)** — a create invents no language: given one, it writes `adtcore:language` / `adtcore:masterLanguage` and sends `sap-language`, one value, from the config else the system context; given none, neither (no `EN` default); `AdtFunctionModule.validate` requires `description`; class create takes no `abstract` and program create no program type (SAP ignores both on create); a run id of `.` or `..` is refused before anything is sent.
 - **[41.x → 42.0.0](docs/usage/MIGRATION-42.md)** — `create` of every handler whose request needs a package, and `validate` of `AdtProgram` / `AdtInclude`, take `packageName: string`, required, in the config type (SAP creates nothing without a package; program validation refuses an empty one); any other `validate` without a package sends `packagename` empty, never `undefined`; a call that passes a package sends the same request.
 - **[40.x → 41.0.0](docs/usage/MIGRATION-41.md)** — every handler class is generic over the values its result slots answer (`AdtClass<ResultValuesOf<typeof classDocuments>>`), not over the strategies (`AdtClass<typeof classDocuments>`); code that names a class's type parameter wraps it in `ResultValuesOf<…>`, and `getX()` / `getX(results)` calls and every request are unchanged.

package/dist/batch/AdtBatchConnection.d.ts

@@ -16,7 +16,7 @@ export declare class AdtBatchConnection implements IAbapConnection {
     });
     private wrappedSession;
     connect(): Promise<void>;
-    getBaseUrl(): Promise<string>;
+    getBaseUrl(): Promise<string | undefined>;
     getSessionId(): string | null;
     setSessionType(type: Session): void;
     getSessionType(): Session;

package/dist/batch/AdtBatchConnection.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"AdtBatchConnection.d.ts","sourceRoot":"","sources":["../../src/batch/AdtBatchConnection.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EACV,eAAe,EACf,mBAAmB,EACnB,gBAAgB,EACjB,MAAM,yCAAyC,CAAC;AACjD,OAAO,KAAK,EAAE,OAAO,EAAE,MAAM,gCAAgC,CAAC;AAM9D,KAAK,OAAO,GAAG,UAAU,GAAG,WAAW,CAAC;AAQxC,sFAAsF;AACtF,qBAAa,kBAAmB,YAAW,eAAe;IAOtD,OAAO,CAAC,QAAQ,CAAC,UAAU;IAC3B,OAAO,CAAC,QAAQ,CAAC,OAAO;IAP1B,OAAO,CAAC,KAAK,CAAiB;IAC9B,OAAO,CAAC,OAAO,CAAU;IACzB,OAAO,CAAC,QAAQ,CAAC,cAAc,CAAU;IACzC,OAAO,CAAC,iBAAiB,CAAC,CAAqB;IAC/C,OAAO,CAAC,SAAS,CAAS;gBAEP,UAAU,EAAE,eAAe,EAC3B,OAAO,EAAE;QACxB,QAAQ,EAAE,eAAe,GAAG,UAAU,CAAC;QACvC,MAAM,CAAC,EAAE,OAAO,CAAC;KAClB;IAQH,OAAO,CAAC,cAAc;IAWtB,OAAO,IAAI,OAAO,CAAC,IAAI,CAAC;IAGxB,UAAU,IAAI,OAAO,CAAC,MAAM,CAAC;IAG7B,YAAY,IAAI,MAAM,GAAG,IAAI;IAG7B,cAAc,CAAC,IAAI,EAAE,OAAO,GAAG,IAAI;IAGnC,cAAc,IAAI,OAAO;IAGzB,cAAc,CAAC,CAAC,GAAG,OAAO,EAAE,CAAC,GAAG,OAAO,EACrC,OAAO,EAAE,mBAAmB,GAC3B,OAAO,CAAC,gBAAgB,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC;IAuBlC,OAAO,CAAC,WAAW;IAkBnB,6EAA6E;IACvE,OAAO,IAAI,OAAO,CAAC,gBAAgB,CAAC;CAiH3C"}
+{"version":3,"file":"AdtBatchConnection.d.ts","sourceRoot":"","sources":["../../src/batch/AdtBatchConnection.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EACV,eAAe,EACf,mBAAmB,EACnB,gBAAgB,EACjB,MAAM,yCAAyC,CAAC;AACjD,OAAO,KAAK,EAAE,OAAO,EAAE,MAAM,gCAAgC,CAAC;AAM9D,KAAK,OAAO,GAAG,UAAU,GAAG,WAAW,CAAC;AAQxC,sFAAsF;AACtF,qBAAa,kBAAmB,YAAW,eAAe;IAOtD,OAAO,CAAC,QAAQ,CAAC,UAAU;IAC3B,OAAO,CAAC,QAAQ,CAAC,OAAO;IAP1B,OAAO,CAAC,KAAK,CAAiB;IAC9B,OAAO,CAAC,OAAO,CAAU;IACzB,OAAO,CAAC,QAAQ,CAAC,cAAc,CAAU;IACzC,OAAO,CAAC,iBAAiB,CAAC,CAAqB;IAC/C,OAAO,CAAC,SAAS,CAAS;gBAEP,UAAU,EAAE,eAAe,EAC3B,OAAO,EAAE;QACxB,QAAQ,EAAE,eAAe,GAAG,UAAU,CAAC;QACvC,MAAM,CAAC,EAAE,OAAO,CAAC;KAClB;IAQH,OAAO,CAAC,cAAc;IAWtB,OAAO,IAAI,OAAO,CAAC,IAAI,CAAC;IAGxB,UAAU,IAAI,OAAO,CAAC,MAAM,GAAG,SAAS,CAAC;IAGzC,YAAY,IAAI,MAAM,GAAG,IAAI;IAG7B,cAAc,CAAC,IAAI,EAAE,OAAO,GAAG,IAAI;IAGnC,cAAc,IAAI,OAAO;IAGzB,cAAc,CAAC,CAAC,GAAG,OAAO,EAAE,CAAC,GAAG,OAAO,EACrC,OAAO,EAAE,mBAAmB,GAC3B,OAAO,CAAC,gBAAgB,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC;IAuBlC,OAAO,CAAC,WAAW;IAkBnB,6EAA6E;IACvE,OAAO,IAAI,OAAO,CAAC,gBAAgB,CAAC;CAiH3C"}

package/docs/usage/MIGRATION-44.md

@@ -0,0 +1,72 @@
+# Migrating to 44.0.0
+
+44.0.0 moves to `@mcp-abap-adt/interfaces-adt-connection` `^4.0.0`, where
+`IAbapConnection.getBaseUrl()` answers `Promise<string | undefined>`: an RFC
+connection has no HTTP origin and answers `undefined`. It pairs with
+`@mcp-abap-adt/adt-strategies` 0.21.0 and `@mcp-abap-adt/adt-clients-legacy`
+0.8.0, which declare the same range. No request changes.
+
+- [`getBaseUrl()` may answer `undefined`](#getbaseurl-may-answer-undefined)
+- [The test configuration over RFC states its address](#the-test-configuration-over-rfc-states-its-address)
+
+## `getBaseUrl()` may answer `undefined`
+
+### What changed
+
+`AdtBatchConnection.getBaseUrl()` answers `Promise<string | undefined>` and
+hands on what the wrapped connection answers, `undefined` included.
+`isCloudEnvironment(connection)` already skipped a missing URL: with
+`undefined` it asks `systeminformation`, as it did for an empty one.
+
+### What to do
+
+A caller that reads `getBaseUrl()` from this package's types narrows before it
+uses the answer:
+
+```typescript
+const origin = await batch.getBaseUrl();
+if (origin !== undefined) {
+  // an HTTP connection: its origin
+}
+```
+
+Install `@mcp-abap-adt/interfaces-adt-connection@^4.0.0` beside this package
+(and `@mcp-abap-adt/connection` 20 for a concrete connection), so one copy of
+the contract is installed. A connection of your own that answers a string
+still conforms.
+
+## The test configuration over RFC states its address
+
+This concerns a run of this repository's tests, not the library.
+
+### What changed
+
+The test helpers take `@mcp-abap-adt/connection` 20, where an RFC config has
+no URL. With `environment.connection_type: "rfc"`, the session file names the
+address and no `SAP_URL`:
+
+```env
+SAP_ASHOST=saphost      # the host your SAP_URL named
+SAP_SYSNR=00            # the two digits of its 80NN port
+SAP_CLIENT=100
+SAP_LANGUAGE=EN
+```
+
+— or a message server: `SAP_MSHOST` with `SAP_MSSERV` and/or `SAP_SYSID` and
+`SAP_GROUP`. `SAP_SAPROUTER` is taken when stated. Nothing is derived from a URL
+and nothing is defaulted.
+
+`environment.connection_type` is required in the overlay: `"http"` or `"rfc"`,
+stated. Absent or another value is refused, naming the key; until 44.0.0 an
+absent one was read as HTTP.
+
+### What to do
+
+State `"environment.connection_type": "http"` (or `"rfc"`) in your
+`test-config.overlay.yaml`; an old full `test-config.yaml` that states none is
+not migrated (`npm run test-config:migrate` names the key). Remove `SAP_URL` from an RFC session file and add `SAP_ASHOST`, `SAP_SYSNR`,
+`SAP_CLIENT` and `SAP_LANGUAGE` (`000` and `EN` were the old defaults). The
+helper refuses, naming the keys, an RFC file that states `SAP_URL`, two
+addresses, none, an incomplete one, or no client or language; an HTTP file
+that states an RFC address key; and ABAP Cloud over RFC. See
+[RFC_TESTING.md](../development/RFC_TESTING.md).

package/docs/usage/RFC_CONNECTION.md

@@ -44,7 +44,7 @@ export LD_LIBRARY_PATH=$SAPNWRFC_HOME/lib:$LD_LIBRARY_PATH
 RFC transport is provided by `@mcp-abap-adt/sap-rfc-lite`, which is pulled in automatically as a dependency of `@mcp-abap-adt/connection`. Nothing needs to be added to `package.json` — `adt-clients` consumes the `IAbapConnection` interface and does not depend on any RFC library directly.
 
 It is an **optional** dependency with no install script (sap-rfc-lite 0.3.x,
-`@mcp-abap-adt/connection` 19 and later): `npm install` compiles nothing and needs
+`@mcp-abap-adt/connection` 19 and later; this package's tests use 20): `npm install` compiles nothing and needs
 no SDK. It ships prebuilt bindings for linux-x64 (glibc), win32-x64 and
 darwin-arm64. On any other platform the install succeeds without a binding and
 the RFC connection fails when it loads sap-rfc-lite; build the binding from
@@ -61,10 +61,13 @@ The SAP user needs `S_RFC` authorization for function module `SADT_REST_RFC_ENDP
 
 ### Connection Layer (`@mcp-abap-adt/connection`)
 
-RFC is a **transport**, not an auth type. `RfcAbapConnection` and
-`connectionType: 'rfc'` were both removed in `@mcp-abap-adt/connection` 6.0.0:
-the wire an on-prem system is reached over is now an argument, because that is
-what it always was.
+RFC is a **transport**, not an auth type: the wire an on-prem system is
+reached over is an argument (`RfcTransport`), as it has been since
+`@mcp-abap-adt/connection` 6.0.0. `connectionType: 'rfc'` is the config's
+discriminant since `@mcp-abap-adt/interfaces-auth-sap` 4 /
+`@mcp-abap-adt/connection` 20: `ISapConfig` is a union, and an RFC config
+(`SapRfcConfig`) states its own address, client and logon language and has no
+`url`.
 
 ```typescript
 import { BasicAuthProvider } from '@mcp-abap-adt/auth-providers';
@@ -72,29 +75,41 @@ import {
   AdtOnPremConnector,
   RfcTransport,
   rfcConversationFrom,
+  type SapRfcConfig,
 } from '@mcp-abap-adt/connection';
 
-const config = {
-  url: 'http://saphost:8000',   // hostname and port derive the RFC parameters
-  authType: 'basic' as const,
+const config: SapRfcConfig = {
+  connectionType: 'rfc',
+  ashost: 'saphost',  // the application server
+  sysnr: '00',        // its system number
   client: '100',
+  language: 'EN',
+  authType: 'basic',
   username: 'DEVELOPER',
   password: 'secret',
 };
 
 const connection = new AdtOnPremConnector(
   config,
-  new BasicAuthProvider(config.username, config.password),
+  new BasicAuthProvider('DEVELOPER', 'secret'),
   new RfcTransport(rfcConversationFrom(config)),
 );
 
 await connection.connect();
 ```
 
-`rfcConversationFrom(config)` derives the connection parameters from the URL:
-- `ashost` — parsed from URL hostname
-- `sysnr` — derived from port (80XX -> XX, e.g. 8000 -> 00, 8001 -> 01)
-- `client`, `user`, `passwd` — from config
+`rfcConversationFrom(config)` takes the address as stated:
+- an application server: `ashost` and `sysnr`;
+- or a message server: `mshost`, its service as `msserv`, `sysid` or both, and
+  the logon `group`;
+- `client` and `language` (sent as the SDK's `lang`), and `saprouter` when the
+  config states it;
+- the provider's logon parameters (`user`, `passwd`, or SNC) are spread over
+  that address at each open.
+
+Nothing is derived from a URL, nothing is defaulted (no `000`, `EN` or
+`PUBLIC`), and `SAP_SYSNR` is not read from the environment. An RFC
+connection's `getBaseUrl()` answers `undefined`: it has no HTTP origin.
 
 ### ADT Clients Layer (`@mcp-abap-adt/adt-clients`)
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mcp-abap-adt/adt-clients",
-  "version": "43.1.0",
+  "version": "44.0.0",
   "description": "ADT clients for SAP ABAP systems - AdtClient and AdtRuntimeClient",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
@@ -117,7 +117,7 @@
   },
   "dependencies": {
     "@mcp-abap-adt/interfaces-adt": "^26.0.0",
-    "@mcp-abap-adt/interfaces-adt-connection": "^3.0.0",
+    "@mcp-abap-adt/interfaces-adt-connection": "^4.0.0",
     "@mcp-abap-adt/interfaces-network": "^2.0.1",
     "@mcp-abap-adt/interfaces-utils": "^1.1.1",
     "@mcp-abap-adt/logger": "^0.4.1",
@@ -126,11 +126,11 @@
   },
   "devDependencies": {
     "@biomejs/biome": "^2.4.4",
-    "@mcp-abap-adt/adt-strategies": "^0.20.0",
+    "@mcp-abap-adt/adt-strategies": "^0.21.0",
     "@mcp-abap-adt/auth-providers": "^6.0.2",
-    "@mcp-abap-adt/connection": "^19.0.0",
+    "@mcp-abap-adt/connection": "^20.0.0",
     "@mcp-abap-adt/interfaces-auth": "^7.5.0",
-    "@mcp-abap-adt/interfaces-auth-sap": "^3.3.0",
+    "@mcp-abap-adt/interfaces-auth-sap": "^4.0.0",
     "@types/jest": "^30.0.0",
     "@types/node": "^25.3.3",
     "dotenv": "^17.3.1",