@mcp-abap-adt/adt-clients 3.9.0 → 3.9.2

package/dist/core/dataElement/update.d.ts

@@ -1,5 +1,8 @@
 /**
  * DataElement update operations
+ *
+ * Uses read-modify-write pattern: GET current XML → patch fields → PUT.
+ * This preserves all SAP-managed fields that would be lost if XML were built from scratch.
  */
 import type { IAdtResponse as AxiosResponse, IAbapConnection, ILogger } from '@mcp-abap-adt/interfaces';
 import type { IUpdateDataElementParams } from './types';
@@ -12,18 +15,17 @@ export declare function getDomainInfo(connection: IAbapConnection, domainName: s
     decimals: number;
 }>;
 /**
- * Update data element with new data
- * Requires object to be locked first (lockHandle must be provided)
+ * Update data element - atomic PUT operation (read-modify-write pattern)
+ * NOTE: Requires object to be locked first via lockDataElement()
+ * NOTE: Caller should call connection.setSessionType("stateful") before locking
+ */
+export declare function updateDataElement(connection: IAbapConnection, params: IUpdateDataElementParams, lockHandle: string, logger?: ILogger): Promise<AxiosResponse>;
+/**
+ * @deprecated Use updateDataElement directly. Kept for backward compatibility.
  */
-export declare function updateDataElementInternal(connection: IAbapConnection, args: IUpdateDataElementParams, lockHandle: string, username: string, _domainInfo: {
+export declare function updateDataElementInternal(connection: IAbapConnection, args: IUpdateDataElementParams, lockHandle: string, _username: string, _domainInfo: {
     dataType: string;
     length: number;
     decimals: number;
 }, logger?: ILogger): Promise<AxiosResponse>;
-/**
- * Update data element - atomic PUT operation
- * NOTE: Requires object to be locked first via lockDataElement()
- * NOTE: Caller should call connection.setSessionType("stateful") before locking
- */
-export declare function updateDataElement(connection: IAbapConnection, params: IUpdateDataElementParams, lockHandle: string, logger?: ILogger): Promise<AxiosResponse>;
 //# sourceMappingURL=update.d.ts.map

package/dist/core/dataElement/update.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"update.d.ts","sourceRoot":"","sources":["../../../src/core/dataElement/update.ts"],"names":[],"mappings":"AAAA;;GAEG;AAEH,OAAO,KAAK,EACV,YAAY,IAAI,aAAa,EAC7B,eAAe,EACf,OAAO,EACR,MAAM,0BAA0B,CAAC;AAYlC,OAAO,KAAK,EAAE,wBAAwB,EAAE,MAAM,SAAS,CAAC;AAIxD;;GAEG;AACH,wBAAsB,aAAa,CACjC,UAAU,EAAE,eAAe,EAC3B,UAAU,EAAE,MAAM,GACjB,OAAO,CAAC;IAAE,QAAQ,EAAE,MAAM,CAAC;IAAC,MAAM,EAAE,MAAM,CAAC;IAAC,QAAQ,EAAE,MAAM,CAAA;CAAE,CAAC,CAkCjE;AAkCD;;;GAGG;AACH,wBAAsB,yBAAyB,CAC7C,UAAU,EAAE,eAAe,EAC3B,IAAI,EAAE,wBAAwB,EAC9B,UAAU,EAAE,MAAM,EAClB,QAAQ,EAAE,MAAM,EAChB,WAAW,EAAE;IAAE,QAAQ,EAAE,MAAM,CAAC;IAAC,MAAM,EAAE,MAAM,CAAC;IAAC,QAAQ,EAAE,MAAM,CAAA;CAAE,EACnE,MAAM,CAAC,EAAE,OAAO,GACf,OAAO,CAAC,aAAa,CAAC,CA+LxB;AAED;;;;GAIG;AACH,wBAAsB,iBAAiB,CACrC,UAAU,EAAE,eAAe,EAC3B,MAAM,EAAE,wBAAwB,EAChC,UAAU,EAAE,MAAM,EAClB,MAAM,CAAC,EAAE,OAAO,GACf,OAAO,CAAC,aAAa,CAAC,CAgCxB"}
+{"version":3,"file":"update.d.ts","sourceRoot":"","sources":["../../../src/core/dataElement/update.ts"],"names":[],"mappings":"AAAA;;;;;GAKG;AAEH,OAAO,KAAK,EACV,YAAY,IAAI,aAAa,EAC7B,eAAe,EACf,OAAO,EACR,MAAM,0BAA0B,CAAC;AAgBlC,OAAO,KAAK,EAAE,wBAAwB,EAAE,MAAM,SAAS,CAAC;AAIxD;;GAEG;AACH,wBAAsB,aAAa,CACjC,UAAU,EAAE,eAAe,EAC3B,UAAU,EAAE,MAAM,GACjB,OAAO,CAAC;IAAE,QAAQ,EAAE,MAAM,CAAC;IAAC,MAAM,EAAE,MAAM,CAAC;IAAC,QAAQ,EAAE,MAAM,CAAA;CAAE,CAAC,CAmCjE;AAqID;;;;GAIG;AACH,wBAAsB,iBAAiB,CACrC,UAAU,EAAE,eAAe,EAC3B,MAAM,EAAE,wBAAwB,EAChC,UAAU,EAAE,MAAM,EAClB,MAAM,CAAC,EAAE,OAAO,GACf,OAAO,CAAC,aAAa,CAAC,CAkExB;AAED;;GAEG;AACH,wBAAsB,yBAAyB,CAC7C,UAAU,EAAE,eAAe,EAC3B,IAAI,EAAE,wBAAwB,EAC9B,UAAU,EAAE,MAAM,EAClB,SAAS,EAAE,MAAM,EACjB,WAAW,EAAE;IAAE,QAAQ,EAAE,MAAM,CAAC;IAAC,MAAM,EAAE,MAAM,CAAC;IAAC,QAAQ,EAAE,MAAM,CAAA;CAAE,EACnE,MAAM,CAAC,EAAE,OAAO,GACf,OAAO,CAAC,aAAa,CAAC,CAExB"}

package/dist/core/dataElement/update.js

@@ -1,21 +1,57 @@
 "use strict";
 /**
  * DataElement update operations
+ *
+ * Uses read-modify-write pattern: GET current XML → patch fields → PUT.
+ * This preserves all SAP-managed fields that would be lost if XML were built from scratch.
  */
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
+    Object.defineProperty(o, "default", { enumerable: true, value: v });
+}) : function(o, v) {
+    o["default"] = v;
+});
+var __importStar = (this && this.__importStar) || (function () {
+    var ownKeys = function(o) {
+        ownKeys = Object.getOwnPropertyNames || function (o) {
+            var ar = [];
+            for (var k in o) if (Object.prototype.hasOwnProperty.call(o, k)) ar[ar.length] = k;
+            return ar;
+        };
+        return ownKeys(o);
+    };
+    return function (mod) {
+        if (mod && mod.__esModule) return mod;
+        var result = {};
+        if (mod != null) for (var k = ownKeys(mod), i = 0; i < k.length; i++) if (k[i] !== "default") __createBinding(result, mod, k[i]);
+        __setModuleDefault(result, mod);
+        return result;
+    };
+})();
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.getDomainInfo = getDomainInfo;
-exports.updateDataElementInternal = updateDataElementInternal;
 exports.updateDataElement = updateDataElement;
-const fast_xml_parser_1 = require("fast-xml-parser");
+exports.updateDataElementInternal = updateDataElementInternal;
 const contentTypes_1 = require("../../constants/contentTypes");
 const internalUtils_1 = require("../../utils/internalUtils");
-const systemInfo_1 = require("../../utils/systemInfo");
 const timeouts_1 = require("../../utils/timeouts");
+const xmlPatch_1 = require("../../utils/xmlPatch");
 const debugEnabled = process.env.DEBUG_ADT_LIBS === 'true';
 /**
  * Get domain info to extract dataType, length, decimals
  */
 async function getDomainInfo(connection, domainName) {
+    const { XMLParser } = await Promise.resolve().then(() => __importStar(require('fast-xml-parser')));
     const domainNameEncoded = (0, internalUtils_1.encodeSapObjectName)(domainName.toLowerCase());
     const url = `/sap/bc/adt/ddic/domains/${domainNameEncoded}`;
     const headers = {
@@ -27,7 +63,7 @@ async function getDomainInfo(connection, domainName) {
         timeout: (0, timeouts_1.getTimeout)('default'),
         headers,
     });
-    const parser = new fast_xml_parser_1.XMLParser({
+    const parser = new XMLParser({
         ignoreAttributes: false,
         attributeNamePrefix: '',
     });
@@ -43,160 +79,106 @@ async function getDomainInfo(connection, domainName) {
     };
 }
 /**
- * Get data element to verify update
+ * Patch current data element XML with updated values.
+ * Only modifies fields that are explicitly provided in args.
  */
-async function _getDataElementForVerification(connection, dataElementName) {
-    const dataElementNameEncoded = (0, internalUtils_1.encodeSapObjectName)(dataElementName.toLowerCase());
-    const url = `/sap/bc/adt/ddic/dataelements/${dataElementNameEncoded}`;
-    const headers = {
-        Accept: contentTypes_1.ACCEPT_DATA_ELEMENT,
-    };
-    const response = await connection.makeAdtRequest({
-        url,
-        method: 'GET',
-        timeout: (0, timeouts_1.getTimeout)('default'),
-        headers,
-    });
-    const parser = new fast_xml_parser_1.XMLParser({
-        ignoreAttributes: false,
-        attributeNamePrefix: '',
-    });
-    const result = parser.parse(response.data);
-    return result['blue:wbobj'];
-}
-/**
- * Update data element with new data
- * Requires object to be locked first (lockHandle must be provided)
- */
-async function updateDataElementInternal(connection, args, lockHandle, username, _domainInfo, logger) {
-    const dataElementNameEncoded = (0, internalUtils_1.encodeSapObjectName)(args.data_element_name.toLowerCase());
-    const corrNrParam = args.transport_request
-        ? `&corrNr=${args.transport_request}`
-        : '';
-    const url = `/sap/bc/adt/ddic/dataelements/${dataElementNameEncoded}?lockHandle=${encodeURIComponent(lockHandle)}${corrNrParam}`;
-    if (!args.type_kind) {
-        throw new Error('type_kind is required. Must be one of: domain, predefinedAbapType, refToPredefinedAbapType, refToDictionaryType, refToClifType');
-    }
-    // Validate required parameters based on type_kind
-    // predefinedAbapType and refToPredefinedAbapType require data_type
-    // Other types (domain, refToDictionaryType, refToClifType) require type_name
-    if (args.type_kind === 'predefinedAbapType' ||
-        args.type_kind === 'refToPredefinedAbapType') {
-        if (!args.data_type) {
-            throw new Error(`data_type is required when type_kind is '${args.type_kind}'. Provide data type (e.g., CHAR, NUMC, INT4).`);
-        }
+function patchDataElementXml(currentXml, args) {
+    let xml = currentXml;
+    // Description
+    if (args.description) {
+        const description = (0, internalUtils_1.limitDescription)(args.description);
+        xml = (0, xmlPatch_1.patchXmlAttribute)(xml, 'adtcore:description', description);
     }
-    else {
-        // domain, refToDictionaryType, refToClifType require type_name
+    // Type information
+    xml = (0, xmlPatch_1.patchIf)(xml, args.type_kind, (x, val) => (0, xmlPatch_1.patchXmlElement)(x, 'dtel:typeKind', val));
+    // typeName — handle domain type: use type_name or data_type as domain name
+    if (args.type_kind || args.type_name || args.data_type) {
+        let typeName = '';
         if (args.type_kind === 'domain') {
-            // For domain, type_name (domain name) is required, but it will be used as data_type internally
-            if (!args.type_name && !args.data_type) {
-                throw new Error(`type_name (domain name) is required when type_kind is 'domain'. Provide domain name (e.g., ZOK_AUTH_ID).`);
-            }
+            typeName = (args.type_name || args.data_type || '').toUpperCase();
         }
-        else {
-            // refToDictionaryType, refToClifType
-            if (!args.type_name) {
-                throw new Error(`type_name is required when type_kind is '${args.type_kind}'. Provide ${args.type_kind === 'refToDictionaryType' ? 'data element name' : 'class name'}.`);
-            }
+        else if (args.type_name) {
+            typeName = args.type_name.toUpperCase();
+        }
+        if (typeName) {
+            xml = (0, xmlPatch_1.patchXmlElement)(xml, 'dtel:typeName', typeName);
         }
     }
-    const typeKind = args.type_kind;
-    // Use provided values directly - no automatic determination
-    // When typeKind is 'domain', dataType should contain the domain name, and it goes to typeName in XML
-    let typeName = '';
-    if (typeKind === 'domain') {
-        // For domain type, typeName is the domain name (type_name), not the underlying data type
-        typeName = (args.type_name || args.data_type || '').toUpperCase();
-    }
-    else {
-        // For other types, typeName comes from type_name parameter
-        typeName = args.type_name ? args.type_name.toUpperCase() : '';
-    }
-    // Use provided values directly
-    const dataType = args.data_type || '';
-    const dataTypeLength = args.length || 0;
-    const dataTypeDecimals = args.decimals || 0;
-    const shortMaxLength = 10;
-    const mediumMaxLength = 20;
-    const longMaxLength = 40;
-    const headingMaxLength = 55;
-    const shortLabel = (args.short_label || '').substring(0, shortMaxLength);
-    const mediumLabel = (args.medium_label || '').substring(0, mediumMaxLength);
-    const longLabel = (args.long_label || '').substring(0, longMaxLength);
-    const headingLabel = (args.heading_label || '').substring(0, headingMaxLength);
-    const shortLength = shortLabel.length || shortMaxLength;
-    const mediumLength = mediumLabel.length || mediumMaxLength;
-    const longLength = longLabel.length || longMaxLength;
-    const headingLength = headingLabel.length || headingMaxLength;
-    const searchHelp = args.search_help !== undefined ? args.search_help : '';
-    const searchHelpParameter = args.search_help_parameter !== undefined ? args.search_help_parameter : '';
-    const setGetParameter = args.set_get_parameter !== undefined ? args.set_get_parameter : '';
-    const defaultComponentName = args.default_component_name !== undefined
-        ? args.default_component_name
-        : '';
-    const deactivateInputHistory = args.deactivate_input_history !== undefined
-        ? args.deactivate_input_history
-        : false;
-    const changeDocument = args.change_document !== undefined ? args.change_document : false;
-    const leftToRightDirection = args.left_to_right_direction !== undefined
-        ? args.left_to_right_direction
-        : false;
-    const deactivateBIDIFiltering = args.deactivate_bidi_filtering !== undefined
-        ? args.deactivate_bidi_filtering
-        : false;
-    // Description is limited to 60 characters in SAP ADT
-    const description = (0, internalUtils_1.limitDescription)(args.description || args.data_element_name);
-    const responsibleAttr = username ? ` adtcore:responsible="${username}"` : '';
-    const xmlBody = `<?xml version="1.0" encoding="UTF-8"?>
-<blue:wbobj xmlns:blue="http://www.sap.com/wbobj/dictionary/dtel"
-            xmlns:adtcore="http://www.sap.com/adt/core"
-            xmlns:atom="http://www.w3.org/2005/Atom"
-            xmlns:dtel="http://www.sap.com/adt/dictionary/dataelements"
-            adtcore:description="${description}"
-            adtcore:language="EN"
-            adtcore:name="${args.data_element_name.toUpperCase()}"
-            adtcore:type="DTEL/DE"
-            adtcore:masterLanguage="EN"${responsibleAttr}>
-  <adtcore:packageRef adtcore:name="${args.package_name.toUpperCase()}"/>
-  <dtel:dataElement>
-    <dtel:typeKind>${typeKind}</dtel:typeKind>
-    ${typeName ? `<dtel:typeName>${typeName}</dtel:typeName>` : '<dtel:typeName/>'}
-    ${dataType ? `<dtel:dataType>${dataType}</dtel:dataType>` : '<dtel:dataType/>'}
-    <dtel:dataTypeLength>${String(dataTypeLength).padStart(6, '0')}</dtel:dataTypeLength>
-    <dtel:dataTypeDecimals>${String(dataTypeDecimals).padStart(6, '0')}</dtel:dataTypeDecimals>
-    <dtel:shortFieldLabel>${shortLabel}</dtel:shortFieldLabel>
-    <dtel:shortFieldLength>${shortLength}</dtel:shortFieldLength>
-    <dtel:shortFieldMaxLength>${shortMaxLength}</dtel:shortFieldMaxLength>
-    <dtel:mediumFieldLabel>${mediumLabel}</dtel:mediumFieldLabel>
-    <dtel:mediumFieldLength>${mediumLength}</dtel:mediumFieldLength>
-    <dtel:mediumFieldMaxLength>${mediumMaxLength}</dtel:mediumFieldMaxLength>
-    <dtel:longFieldLabel>${longLabel}</dtel:longFieldLabel>
-    <dtel:longFieldLength>${longLength}</dtel:longFieldLength>
-    <dtel:longFieldMaxLength>${longMaxLength}</dtel:longFieldMaxLength>
-    <dtel:headingFieldLabel>${headingLabel}</dtel:headingFieldLabel>
-    <dtel:headingFieldLength>${headingLength}</dtel:headingFieldLength>
-    <dtel:headingFieldMaxLength>${headingMaxLength}</dtel:headingFieldMaxLength>
-    ${searchHelp ? `<dtel:searchHelp>${searchHelp}</dtel:searchHelp>` : '<dtel:searchHelp/>'}
-    ${searchHelpParameter ? `<dtel:searchHelpParameter>${searchHelpParameter}</dtel:searchHelpParameter>` : '<dtel:searchHelpParameter/>'}
-    ${setGetParameter ? `<dtel:setGetParameter>${setGetParameter}</dtel:setGetParameter>` : '<dtel:setGetParameter/>'}
-    ${defaultComponentName ? `<dtel:defaultComponentName>${defaultComponentName}</dtel:defaultComponentName>` : '<dtel:defaultComponentName/>'}
-    <dtel:deactivateInputHistory>${deactivateInputHistory}</dtel:deactivateInputHistory>
-    <dtel:changeDocument>${changeDocument}</dtel:changeDocument>
-    <dtel:leftToRightDirection>${leftToRightDirection}</dtel:leftToRightDirection>
-    <dtel:deactivateBIDIFiltering>${deactivateBIDIFiltering}</dtel:deactivateBIDIFiltering>
-  </dtel:dataElement>
-</blue:wbobj>`;
-    const headers = {
-        Accept: contentTypes_1.ACCEPT_DATA_ELEMENT,
-        'Content-Type': 'application/vnd.sap.adt.dataelements.v2+xml; charset=utf-8',
-    };
-    // Debug: log XML when DEBUG_ADT_LIBS is enabled (formatted for readability)
+    xml = (0, xmlPatch_1.patchIf)(xml, args.data_type, (x, val) => (0, xmlPatch_1.patchXmlElement)(x, 'dtel:dataType', val));
+    xml = (0, xmlPatch_1.patchIf)(xml, args.length, (x, val) => (0, xmlPatch_1.patchXmlElement)(x, 'dtel:dataTypeLength', String(val).padStart(6, '0')));
+    xml = (0, xmlPatch_1.patchIf)(xml, args.decimals, (x, val) => (0, xmlPatch_1.patchXmlElement)(x, 'dtel:dataTypeDecimals', String(val).padStart(6, '0')));
+    // Labels
+    if (args.short_label !== undefined) {
+        xml = (0, xmlPatch_1.patchXmlElement)(xml, 'dtel:shortFieldLabel', args.short_label);
+        xml = (0, xmlPatch_1.patchXmlElement)(xml, 'dtel:shortFieldLength', String(args.short_label.length || 10));
+    }
+    if (args.medium_label !== undefined) {
+        xml = (0, xmlPatch_1.patchXmlElement)(xml, 'dtel:mediumFieldLabel', args.medium_label);
+        xml = (0, xmlPatch_1.patchXmlElement)(xml, 'dtel:mediumFieldLength', String(args.medium_label.length || 20));
+    }
+    if (args.long_label !== undefined) {
+        xml = (0, xmlPatch_1.patchXmlElement)(xml, 'dtel:longFieldLabel', args.long_label);
+        xml = (0, xmlPatch_1.patchXmlElement)(xml, 'dtel:longFieldLength', String(args.long_label.length || 40));
+    }
+    if (args.heading_label !== undefined) {
+        xml = (0, xmlPatch_1.patchXmlElement)(xml, 'dtel:headingFieldLabel', args.heading_label);
+        xml = (0, xmlPatch_1.patchXmlElement)(xml, 'dtel:headingFieldLength', String(args.heading_label.length || 55));
+    }
+    // Optional fields
+    if (args.search_help !== undefined) {
+        xml = (0, xmlPatch_1.patchXmlElement)(xml, 'dtel:searchHelp', args.search_help);
+    }
+    if (args.search_help_parameter !== undefined) {
+        xml = (0, xmlPatch_1.patchXmlElement)(xml, 'dtel:searchHelpParameter', args.search_help_parameter);
+    }
+    if (args.set_get_parameter !== undefined) {
+        xml = (0, xmlPatch_1.patchXmlElement)(xml, 'dtel:setGetParameter', args.set_get_parameter);
+    }
+    if (args.default_component_name !== undefined) {
+        xml = (0, xmlPatch_1.patchXmlElement)(xml, 'dtel:defaultComponentName', args.default_component_name);
+    }
+    if (args.deactivate_input_history !== undefined) {
+        xml = (0, xmlPatch_1.patchXmlElement)(xml, 'dtel:deactivateInputHistory', String(args.deactivate_input_history));
+    }
+    if (args.change_document !== undefined) {
+        xml = (0, xmlPatch_1.patchXmlElement)(xml, 'dtel:changeDocument', String(args.change_document));
+    }
+    if (args.left_to_right_direction !== undefined) {
+        xml = (0, xmlPatch_1.patchXmlElement)(xml, 'dtel:leftToRightDirection', String(args.left_to_right_direction));
+    }
+    if (args.deactivate_bidi_filtering !== undefined) {
+        xml = (0, xmlPatch_1.patchXmlElement)(xml, 'dtel:deactivateBIDIFiltering', String(args.deactivate_bidi_filtering));
+    }
+    return xml;
+}
+/**
+ * Update data element - atomic PUT operation (read-modify-write pattern)
+ * NOTE: Requires object to be locked first via lockDataElement()
+ * NOTE: Caller should call connection.setSessionType("stateful") before locking
+ */
+async function updateDataElement(connection, params, lockHandle, logger) {
+    if (!params.data_element_name) {
+        throw new Error('Data element name is required');
+    }
+    if (!params.package_name) {
+        throw new Error('Package name is required');
+    }
+    const dataElementNameEncoded = (0, internalUtils_1.encodeSapObjectName)(params.data_element_name.toLowerCase());
+    // 1. GET current XML
+    const currentResponse = await connection.makeAdtRequest({
+        url: `/sap/bc/adt/ddic/dataelements/${dataElementNameEncoded}`,
+        method: 'GET',
+        timeout: (0, timeouts_1.getTimeout)('default'),
+        headers: { Accept: contentTypes_1.ACCEPT_DATA_ELEMENT },
+    });
+    const currentXml = (0, xmlPatch_1.extractXmlString)(currentResponse.data);
+    // 2. Patch only changed fields
+    const updatedXml = patchDataElementXml(currentXml, params);
+    // Debug: log XML when DEBUG_ADT_LIBS is enabled
     if (debugEnabled) {
         logger?.debug?.('[UPDATE XML]');
-        // Format XML with indentation for readability
         try {
-            const { XMLParser, XMLBuilder } = require('fast-xml-parser');
+            const { XMLParser, XMLBuilder } = await Promise.resolve().then(() => __importStar(require('fast-xml-parser')));
             const parser = new XMLParser({
                 ignoreAttributes: false,
                 attributeNamePrefix: '',
@@ -207,46 +189,34 @@ async function updateDataElementInternal(connection, args, lockHandle, username,
                 format: true,
                 indentBy: '  ',
             });
-            const parsed = parser.parse(xmlBody);
+            const parsed = parser.parse(updatedXml);
             const formatted = builder.build(parsed);
             logger?.debug?.(formatted);
         }
         catch {
-            // If formatting fails, just log as-is
-            logger?.debug?.(xmlBody);
+            logger?.debug?.(updatedXml);
         }
     }
+    // 3. PUT
+    const corrNrParam = params.transport_request
+        ? `&corrNr=${params.transport_request}`
+        : '';
+    const url = `/sap/bc/adt/ddic/dataelements/${dataElementNameEncoded}?lockHandle=${encodeURIComponent(lockHandle)}${corrNrParam}`;
+    const headers = {
+        Accept: contentTypes_1.ACCEPT_DATA_ELEMENT,
+        'Content-Type': 'application/vnd.sap.adt.dataelements.v2+xml; charset=utf-8',
+    };
     return connection.makeAdtRequest({
         url,
         method: 'PUT',
         timeout: (0, timeouts_1.getTimeout)('default'),
-        data: xmlBody,
+        data: updatedXml,
         headers,
     });
 }
 /**
- * Update data element - atomic PUT operation
- * NOTE: Requires object to be locked first via lockDataElement()
- * NOTE: Caller should call connection.setSessionType("stateful") before locking
+ * @deprecated Use updateDataElement directly. Kept for backward compatibility.
  */
-async function updateDataElement(connection, params, lockHandle, logger) {
-    if (!params.data_element_name) {
-        throw new Error('Data element name is required');
-    }
-    if (!params.package_name) {
-        throw new Error('Package name is required');
-    }
-    if (!params.type_kind) {
-        throw new Error('type_kind is required. Must be one of: domain, predefinedAbapType, refToPredefinedAbapType, refToDictionaryType, refToClifType');
-    }
-    // Get system information for username
-    const systemInfo = await (0, systemInfo_1.getSystemInformation)(connection);
-    const username = systemInfo?.userName || '';
-    // Use provided values directly - no automatic determination
-    const domainInfo = {
-        dataType: params.data_type || '',
-        length: params.length || 0,
-        decimals: params.decimals || 0,
-    };
-    return updateDataElementInternal(connection, params, lockHandle, username, domainInfo, logger);
+async function updateDataElementInternal(connection, args, lockHandle, _username, _domainInfo, logger) {
+    return updateDataElement(connection, args, lockHandle, logger);
 }

package/dist/core/domain/update.d.ts

@@ -1,10 +1,13 @@
 /**
  * Domain update operations
+ *
+ * Uses read-modify-write pattern: GET current XML → patch fields → PUT.
+ * This preserves all SAP-managed fields that would be lost if XML were built from scratch.
  */
 import type { IAdtResponse as AxiosResponse, IAbapConnection } from '@mcp-abap-adt/interfaces';
 import type { IUpdateDomainParams } from './types';
 /**
- * Update domain with new data
+ * Update domain with new data (read-modify-write pattern)
  *
  * NOTE: Requires stateful session mode enabled via connection.setSessionType("stateful")
  */

package/dist/core/domain/update.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"update.d.ts","sourceRoot":"","sources":["../../../src/core/domain/update.ts"],"names":[],"mappings":"AAAA;;GAEG;AAEH,OAAO,KAAK,EACV,YAAY,IAAI,aAAa,EAC7B,eAAe,EAChB,MAAM,0BAA0B,CAAC;AAOlC,OAAO,KAAK,EAAE,mBAAmB,EAAE,MAAM,SAAS,CAAC;AAEnD;;;;GAIG;AACH,wBAAsB,YAAY,CAChC,UAAU,EAAE,eAAe,EAC3B,IAAI,EAAE,mBAAmB,EACzB,UAAU,EAAE,MAAM,GACjB,OAAO,CAAC,aAAa,CAAC,CA0ExB"}
+{"version":3,"file":"update.d.ts","sourceRoot":"","sources":["../../../src/core/domain/update.ts"],"names":[],"mappings":"AAAA;;;;;GAKG;AAEH,OAAO,KAAK,EACV,YAAY,IAAI,aAAa,EAC7B,eAAe,EAChB,MAAM,0BAA0B,CAAC;AAelC,OAAO,KAAK,EAAE,mBAAmB,EAAE,MAAM,SAAS,CAAC;AAsEnD;;;;GAIG;AACH,wBAAsB,YAAY,CAChC,UAAU,EAAE,eAAe,EAC3B,IAAI,EAAE,mBAAmB,EACzB,UAAU,EAAE,MAAM,GACjB,OAAO,CAAC,aAAa,CAAC,CAiCxB"}

package/dist/core/domain/update.js

@@ -1,72 +1,82 @@
 "use strict";
 /**
  * Domain update operations
+ *
+ * Uses read-modify-write pattern: GET current XML → patch fields → PUT.
+ * This preserves all SAP-managed fields that would be lost if XML were built from scratch.
  */
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.updateDomain = updateDomain;
 const contentTypes_1 = require("../../constants/contentTypes");
 const internalUtils_1 = require("../../utils/internalUtils");
 const timeouts_1 = require("../../utils/timeouts");
+const xmlPatch_1 = require("../../utils/xmlPatch");
+/**
+ * Patch current domain XML with updated values.
+ * Only modifies fields that are explicitly provided in args.
+ */
+function patchDomainXml(currentXml, args) {
+    let xml = currentXml;
+    // Description
+    if (args.description) {
+        const description = (0, internalUtils_1.limitDescription)(args.description);
+        xml = (0, xmlPatch_1.patchXmlAttribute)(xml, 'adtcore:description', description);
+    }
+    // Type information
+    xml = (0, xmlPatch_1.patchIf)(xml, args.datatype, (x, val) => (0, xmlPatch_1.patchXmlElement)(x, 'doma:datatype', val));
+    xml = (0, xmlPatch_1.patchIf)(xml, args.length, (x, val) => (0, xmlPatch_1.patchXmlElement)(x, 'doma:length', String(val)));
+    xml = (0, xmlPatch_1.patchIf)(xml, args.decimals, (x, val) => (0, xmlPatch_1.patchXmlElement)(x, 'doma:decimals', String(val)));
+    // Output information
+    if (args.conversion_exit !== undefined) {
+        xml = (0, xmlPatch_1.patchXmlElement)(xml, 'doma:conversionExit', args.conversion_exit || '');
+    }
+    if (args.sign_exists !== undefined) {
+        xml = (0, xmlPatch_1.patchXmlElement)(xml, 'doma:signExists', String(args.sign_exists));
+    }
+    if (args.lowercase !== undefined) {
+        xml = (0, xmlPatch_1.patchXmlElement)(xml, 'doma:lowercase', String(args.lowercase));
+    }
+    // Value table
+    if (args.value_table !== undefined) {
+        xml = (0, xmlPatch_1.patchXmlElementAttribute)(xml, 'doma:valueTableRef', 'adtcore:name', args.value_table || '');
+    }
+    // Fixed values — replace entire block
+    if (args.fixed_values !== undefined) {
+        if (args.fixed_values && args.fixed_values.length > 0) {
+            const fixValueItems = args.fixed_values
+                .map((fv) => `      <doma:fixValue>\n        <doma:low>${fv.low}</doma:low>\n        <doma:text>${fv.text}</doma:text>\n      </doma:fixValue>`)
+                .join('\n');
+            const fixValuesBlock = `<doma:fixValues>\n${fixValueItems}\n    </doma:fixValues>`;
+            xml = (0, xmlPatch_1.patchXmlBlock)(xml, 'doma:fixValues', fixValuesBlock);
+        }
+        else {
+            xml = (0, xmlPatch_1.patchXmlBlock)(xml, 'doma:fixValues', '<doma:fixValues/>');
+        }
+    }
+    return xml;
+}
 /**
- * Update domain with new data
+ * Update domain with new data (read-modify-write pattern)
  *
  * NOTE: Requires stateful session mode enabled via connection.setSessionType("stateful")
  */
 async function updateDomain(connection, args, lockHandle) {
     const domainNameEncoded = (0, internalUtils_1.encodeSapObjectName)(args.domain_name.toLowerCase());
+    // 1. GET current XML
+    const currentResponse = await connection.makeAdtRequest({
+        url: `/sap/bc/adt/ddic/domains/${domainNameEncoded}`,
+        method: 'GET',
+        timeout: (0, timeouts_1.getTimeout)('default'),
+        headers: { Accept: contentTypes_1.ACCEPT_DOMAIN },
+    });
+    const currentXml = (0, xmlPatch_1.extractXmlString)(currentResponse.data);
+    // 2. Patch only changed fields
+    const updatedXml = patchDomainXml(currentXml, args);
+    // 3. PUT
     const corrNrParam = args.transport_request
         ? `&corrNr=${args.transport_request}`
         : '';
     const url = `/sap/bc/adt/ddic/domains/${domainNameEncoded}?lockHandle=${encodeURIComponent(lockHandle)}${corrNrParam}`;
-    const datatype = args.datatype || 'CHAR';
-    const length = args.length || 100;
-    const decimals = args.decimals || 0;
-    let fixValuesXml = '';
-    if (args.fixed_values && args.fixed_values.length > 0) {
-        const fixValueItems = args.fixed_values
-            .map((fv) => `      <doma:fixValue>\n        <doma:low>${fv.low}</doma:low>\n        <doma:text>${fv.text}</doma:text>\n      </doma:fixValue>`)
-            .join('\n');
-        fixValuesXml = `    <doma:fixValues>\n${fixValueItems}\n    </doma:fixValues>`;
-    }
-    else {
-        fixValuesXml = '    <doma:fixValues/>';
-    }
-    // Description is limited to 60 characters in SAP ADT
-    const description = (0, internalUtils_1.limitDescription)(args.description || args.domain_name);
-    const masterSystemAttr = args.masterSystem
-        ? ` adtcore:masterSystem="${args.masterSystem}"`
-        : '';
-    const responsibleAttr = args.responsible
-        ? ` adtcore:responsible="${args.responsible}"`
-        : '';
-    const xmlBody = `<?xml version="1.0" encoding="UTF-8"?>
-<doma:domain xmlns:doma="http://www.sap.com/dictionary/domain"
-             xmlns:adtcore="http://www.sap.com/adt/core"
-             adtcore:description="${description}"
-             adtcore:language="EN"
-             adtcore:name="${args.domain_name.toUpperCase()}"
-             adtcore:type="DOMA/DD"
-             adtcore:masterLanguage="EN"${masterSystemAttr}${responsibleAttr}>
-  <adtcore:packageRef adtcore:name="${args.package_name.toUpperCase()}"/>
-  <doma:content>
-    <doma:typeInformation>
-      <doma:datatype>${datatype}</doma:datatype>
-      <doma:length>${length}</doma:length>
-      <doma:decimals>${decimals}</doma:decimals>
-    </doma:typeInformation>
-    <doma:outputInformation>
-      <doma:length>${length}</doma:length>
-      <doma:conversionExit>${args.conversion_exit || ''}</doma:conversionExit>
-      <doma:signExists>${args.sign_exists || false}</doma:signExists>
-      <doma:lowercase>${args.lowercase || false}</doma:lowercase>
-    </doma:outputInformation>
-    <doma:valueInformation>
-      <doma:valueTableRef adtcore:name="${args.value_table || ''}"/>
-      <doma:appendExists>false</doma:appendExists>
-${fixValuesXml}
-    </doma:valueInformation>
-  </doma:content>
-</doma:domain>`;
     const headers = {
         Accept: contentTypes_1.ACCEPT_DOMAIN,
         'Content-Type': 'application/vnd.sap.adt.domains.v2+xml; charset=utf-8',
@@ -75,7 +85,7 @@ ${fixValuesXml}
         url,
         method: 'PUT',
         timeout: (0, timeouts_1.getTimeout)('default'),
-        data: xmlBody,
+        data: updatedXml,
         headers,
     });
 }

package/dist/core/functionGroup/update.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"update.d.ts","sourceRoot":"","sources":["../../../src/core/functionGroup/update.ts"],"names":[],"mappings":"AAAA;;;;;GAKG;AAEH,OAAO,KAAK,EACV,YAAY,IAAI,aAAa,EAE7B,eAAe,EAChB,MAAM,0BAA0B,CAAC;AAQlC,OAAO,KAAK,EAAE,gBAAgB,EAAE,MAAM,wBAAwB,CAAC;AAG/D,OAAO,KAAK,EAAE,0BAA0B,EAAE,MAAM,SAAS,CAAC;AA2D1D;;;GAGG;AACH,wBAAsB,mBAAmB,CACvC,UAAU,EAAE,eAAe,EAC3B,MAAM,EAAE,0BAA0B,EAClC,YAAY,CAAC,EAAE,gBAAgB,GAC9B,OAAO,CAAC,aAAa,CAAC,CAkGxB"}
+{"version":3,"file":"update.d.ts","sourceRoot":"","sources":["../../../src/core/functionGroup/update.ts"],"names":[],"mappings":"AAAA;;;;;GAKG;AAEH,OAAO,KAAK,EACV,YAAY,IAAI,aAAa,EAE7B,eAAe,EAChB,MAAM,0BAA0B,CAAC;AAQlC,OAAO,KAAK,EAAE,gBAAgB,EAAE,MAAM,wBAAwB,CAAC;AAG/D,OAAO,KAAK,EAAE,0BAA0B,EAAE,MAAM,SAAS,CAAC;AA2C1D;;;GAGG;AACH,wBAAsB,mBAAmB,CACvC,UAAU,EAAE,eAAe,EAC3B,MAAM,EAAE,0BAA0B,EAClC,YAAY,CAAC,EAAE,gBAAgB,GAC9B,OAAO,CAAC,aAAa,CAAC,CAmGxB"}