@mcp-abap-adt/adt-clients 3.6.0 → 3.7.0

package/dist/core/unitTest/AdtUnitTestLegacy.d.ts

@@ -4,31 +4,41 @@
  * Extends AdtUnitTest and overrides run/status/result to use legacy endpoints:
  * - /sap/bc/adt/abapunit/testruns instead of /sap/bc/adt/abapunit/runs
  * - application/xml content types instead of versioned vnd.sap.adt.api.abapunit.* types
+ *
+ * Key difference: Legacy systems return results synchronously (aunit:runResult)
+ * from the POST to /testruns — no run ID, no async polling needed.
  */
 import type { IAdtResponse as AxiosResponse, IAbapConnection, IAdtOperationOptions, ILogger } from '@mcp-abap-adt/interfaces';
 import { AdtUnitTest } from './AdtUnitTest';
-import type { IUnitTestConfig, IUnitTestState } from './types';
+import type { IClassUnitTestDefinition, IClassUnitTestRunOptions, IUnitTestConfig, IUnitTestState } from './types';
 export declare class AdtUnitTestLegacy extends AdtUnitTest {
     constructor(connection: IAbapConnection, logger?: ILogger);
     /**
-     * Create unit test run using legacy endpoint
+     * Create unit test run using legacy endpoint.
+     * Legacy returns results synchronously — no run ID or polling needed.
      */
     create(config: IUnitTestConfig, _options?: IAdtOperationOptions): Promise<IUnitTestState>;
     /**
-     * Get unit test status using legacy endpoint
+     * Run unit tests — legacy returns results synchronously.
+     */
+    run(tests: IClassUnitTestDefinition[], options?: IClassUnitTestRunOptions): Promise<string>;
+    /**
+     * Get unit test status — legacy returns results synchronously,
+     * so this returns the cached response from create().
      */
-    getStatus(runId: string, withLongPolling?: boolean): Promise<AxiosResponse>;
+    getStatus(_runId: string, _withLongPolling?: boolean): Promise<AxiosResponse>;
     /**
-     * Get unit test result using legacy endpoint
+     * Get unit test result — legacy returns results synchronously,
+     * so this returns the cached response from create().
      */
-    getResult(runId: string, options?: {
+    getResult(_runId: string, _options?: {
         withNavigationUris?: boolean;
         format?: 'abapunit' | 'junit';
     }): Promise<AxiosResponse>;
     /**
-     * Extract run ID from legacy response
-     * Legacy uses /testruns/ in URIs instead of /runs/
+     * Read unit test — legacy returns results synchronously,
+     * so this returns the cached result from create().
      */
-    protected extractRunId(response: AxiosResponse): string | undefined;
+    read(_config: Partial<IUnitTestConfig>, _version?: 'active' | 'inactive'): Promise<IUnitTestState | undefined>;
 }
 //# sourceMappingURL=AdtUnitTestLegacy.d.ts.map

package/dist/core/unitTest/AdtUnitTestLegacy.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"AdtUnitTestLegacy.d.ts","sourceRoot":"","sources":["../../../src/core/unitTest/AdtUnitTestLegacy.ts"],"names":[],"mappings":"AAAA;;;;;;GAMG;AAEH,OAAO,KAAK,EACV,YAAY,IAAI,aAAa,EAC7B,eAAe,EACf,oBAAoB,EACpB,OAAO,EACR,MAAM,0BAA0B,CAAC;AAElC,OAAO,EAAE,WAAW,EAAE,MAAM,eAAe,CAAC;AAM5C,OAAO,KAAK,EAAE,eAAe,EAAE,cAAc,EAAE,MAAM,SAAS,CAAC;AAE/D,qBAAa,iBAAkB,SAAQ,WAAW;gBACpC,UAAU,EAAE,eAAe,EAAE,MAAM,CAAC,EAAE,OAAO;IAIzD;;OAEG;IACY,MAAM,CACnB,MAAM,EAAE,eAAe,EACvB,QAAQ,CAAC,EAAE,oBAAoB,GAC9B,OAAO,CAAC,cAAc,CAAC;IAuC1B;;OAEG;IACY,SAAS,CACtB,KAAK,EAAE,MAAM,EACb,eAAe,GAAE,OAAc,GAC9B,OAAO,CAAC,aAAa,CAAC;IAUzB;;OAEG;IACY,SAAS,CACtB,KAAK,EAAE,MAAM,EACb,OAAO,CAAC,EAAE;QAAE,kBAAkB,CAAC,EAAE,OAAO,CAAC;QAAC,MAAM,CAAC,EAAE,UAAU,GAAG,OAAO,CAAA;KAAE,GACxE,OAAO,CAAC,aAAa,CAAC;IAUzB;;;OAGG;cACgB,YAAY,CAAC,QAAQ,EAAE,aAAa,GAAG,MAAM,GAAG,SAAS;CAqC7E"}
+{"version":3,"file":"AdtUnitTestLegacy.d.ts","sourceRoot":"","sources":["../../../src/core/unitTest/AdtUnitTestLegacy.ts"],"names":[],"mappings":"AAAA;;;;;;;;;GASG;AAEH,OAAO,KAAK,EACV,YAAY,IAAI,aAAa,EAC7B,eAAe,EACf,oBAAoB,EACpB,OAAO,EACR,MAAM,0BAA0B,CAAC;AAClC,OAAO,EAAE,WAAW,EAAE,MAAM,eAAe,CAAC;AAE5C,OAAO,KAAK,EACV,wBAAwB,EACxB,wBAAwB,EACxB,eAAe,EACf,cAAc,EACf,MAAM,SAAS,CAAC;AAKjB,qBAAa,iBAAkB,SAAQ,WAAW;gBACpC,UAAU,EAAE,eAAe,EAAE,MAAM,CAAC,EAAE,OAAO;IAIzD;;;OAGG;IACY,MAAM,CACnB,MAAM,EAAE,eAAe,EACvB,QAAQ,CAAC,EAAE,oBAAoB,GAC9B,OAAO,CAAC,cAAc,CAAC;IAkC1B;;OAEG;IACY,GAAG,CAChB,KAAK,EAAE,wBAAwB,EAAE,EACjC,OAAO,CAAC,EAAE,wBAAwB,GACjC,OAAO,CAAC,MAAM,CAAC;IAKlB;;;OAGG;IACY,SAAS,CACtB,MAAM,EAAE,MAAM,EACd,gBAAgB,GAAE,OAAc,GAC/B,OAAO,CAAC,aAAa,CAAC;IASzB;;;OAGG;IACY,SAAS,CACtB,MAAM,EAAE,MAAM,EACd,QAAQ,CAAC,EAAE;QAAE,kBAAkB,CAAC,EAAE,OAAO,CAAC;QAAC,MAAM,CAAC,EAAE,UAAU,GAAG,OAAO,CAAA;KAAE,GACzE,OAAO,CAAC,aAAa,CAAC;IASzB;;;OAGG;IACY,IAAI,CACjB,OAAO,EAAE,OAAO,CAAC,eAAe,CAAC,EACjC,QAAQ,GAAE,QAAQ,GAAG,UAAqB,GACzC,OAAO,CAAC,cAAc,GAAG,SAAS,CAAC;CAWvC"}

package/dist/core/unitTest/AdtUnitTestLegacy.js

@@ -5,18 +5,23 @@
  * Extends AdtUnitTest and overrides run/status/result to use legacy endpoints:
  * - /sap/bc/adt/abapunit/testruns instead of /sap/bc/adt/abapunit/runs
  * - application/xml content types instead of versioned vnd.sap.adt.api.abapunit.* types
+ *
+ * Key difference: Legacy systems return results synchronously (aunit:runResult)
+ * from the POST to /testruns — no run ID, no async polling needed.
  */
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.AdtUnitTestLegacy = void 0;
-const internalUtils_1 = require("../../utils/internalUtils");
 const AdtUnitTest_1 = require("./AdtUnitTest");
 const runLegacy_1 = require("./runLegacy");
+/** Synthetic run ID for legacy synchronous results */
+const LEGACY_SYNC_RUN_ID = 'legacy-sync';
 class AdtUnitTestLegacy extends AdtUnitTest_1.AdtUnitTest {
     constructor(connection, logger) {
         super(connection, logger);
     }
     /**
-     * Create unit test run using legacy endpoint
+     * Create unit test run using legacy endpoint.
+     * Legacy returns results synchronously — no run ID or polling needed.
      */
     async create(config, _options) {
         if (!config.tests || config.tests.length === 0) {
@@ -26,16 +31,15 @@ class AdtUnitTestLegacy extends AdtUnitTest_1.AdtUnitTest {
             this.logger?.info?.('Starting unit test run (legacy)');
             const response = await (0, runLegacy_1.startClassUnitTestRunLegacy)(this.connection, config.tests, config.options);
             this.logger?.debug?.('Unit test run response status:', response.status);
-            const runId = this.extractRunId(response);
-            if (!runId) {
-                this.logger?.error?.('Failed to extract run ID from response. Response data:', response.data);
-                throw new Error('Failed to start unit test run: run ID not returned');
-            }
-            this.logger?.info?.('Unit test run started (legacy), run ID:', runId);
-            this.lastRunId = runId;
+            // Legacy returns results synchronously — store as both status and result
+            this.lastStatusResponse = response;
+            this.lastResultResponse = response;
+            this.lastRunId = LEGACY_SYNC_RUN_ID;
+            this.logger?.info?.('Unit test run completed (legacy, synchronous)');
             return {
                 createResult: response,
-                runId,
+                runId: LEGACY_SYNC_RUN_ID,
+                runResult: response.data,
                 errors: [],
             };
         }
@@ -45,57 +49,46 @@ class AdtUnitTestLegacy extends AdtUnitTest_1.AdtUnitTest {
         }
     }
     /**
-     * Get unit test status using legacy endpoint
+     * Run unit tests — legacy returns results synchronously.
      */
-    async getStatus(runId, withLongPolling = true) {
-        const response = await (0, runLegacy_1.getClassUnitTestStatusLegacy)(this.connection, runId, withLongPolling);
-        this.lastStatusResponse = response;
-        return response;
+    async run(tests, options) {
+        await this.create({ tests, options });
+        return LEGACY_SYNC_RUN_ID;
     }
     /**
-     * Get unit test result using legacy endpoint
+     * Get unit test status — legacy returns results synchronously,
+     * so this returns the cached response from create().
      */
-    async getResult(runId, options) {
-        const response = await (0, runLegacy_1.getClassUnitTestResultLegacy)(this.connection, runId, options);
-        this.lastResultResponse = response;
-        return response;
+    async getStatus(_runId, _withLongPolling = true) {
+        if (this.lastStatusResponse) {
+            return this.lastStatusResponse;
+        }
+        throw new Error('No status available. Legacy systems return results synchronously via create().');
     }
     /**
-     * Extract run ID from legacy response
-     * Legacy uses /testruns/ in URIs instead of /runs/
+     * Get unit test result — legacy returns results synchronously,
+     * so this returns the cached response from create().
      */
-    extractRunId(response) {
-        // Try headers first
-        const locationHeader = (0, internalUtils_1.headerValueToString)(response.headers?.location) ||
-            (0, internalUtils_1.headerValueToString)(response.headers?.['content-location']) ||
-            (0, internalUtils_1.headerValueToString)(response.headers?.['sap-adt-location']);
-        if (locationHeader) {
-            const match = locationHeader.match(/\/testruns\/([^/]+)/) ||
-                locationHeader.match(/\/runs\/([^/]+)/);
-            if (match) {
-                return match[1];
-            }
-        }
-        // Fallback: parse from response body (XML)
-        const data = response.data;
-        if (typeof data === 'string') {
-            const uriMatch = data.match(/uri="([^"]+)"/);
-            if (uriMatch) {
-                const uri = uriMatch[1];
-                const match = uri.match(/\/testruns\/([^/]+)/) || uri.match(/\/runs\/([^/]+)/);
-                if (match) {
-                    return match[1];
-                }
-            }
+    async getResult(_runId, _options) {
+        if (this.lastResultResponse) {
+            return this.lastResultResponse;
         }
-        else if (data?.uri) {
-            const match = data.uri.match(/\/testruns\/([^/]+)/) ||
-                data.uri.match(/\/runs\/([^/]+)/);
-            if (match) {
-                return match[1];
-            }
+        throw new Error('No result available. Legacy systems return results synchronously via create().');
+    }
+    /**
+     * Read unit test — legacy returns results synchronously,
+     * so this returns the cached result from create().
+     */
+    async read(_config, _version = 'active') {
+        if (!this.lastResultResponse) {
+            return undefined;
         }
-        return undefined;
+        return {
+            runId: LEGACY_SYNC_RUN_ID,
+            runStatus: this.lastStatusResponse?.data,
+            runResult: this.lastResultResponse.data,
+            errors: [],
+        };
     }
 }
 exports.AdtUnitTestLegacy = AdtUnitTestLegacy;

package/dist/core/unitTest/runLegacy.d.ts

@@ -9,9 +9,15 @@ import type { IAdtResponse as AxiosResponse, IAbapConnection } from '@mcp-abap-a
 import type { IClassUnitTestDefinition, IClassUnitTestRunOptions } from './types';
 /**
  * Start ABAP Unit test run on legacy systems
- * Uses /sap/bc/adt/abapunit/testruns endpoint with application/xml content type
+ * Uses /sap/bc/adt/abapunit/testruns endpoint with aunit:runConfiguration format
+ *
+ * Legacy format differs from modern:
+ * - Root element: aunit:runConfiguration (not aunit:run)
+ * - Namespace: http://www.sap.com/adt/aunit (not http://www.sap.com/adt/api/aunit)
+ * - Objects via adtcore:objectReferences with URI (not aunit:tests with containerClass/class)
+ * - Content-Type/Accept: application/xml (not versioned vnd.sap.adt.api.abapunit.*)
  */
-export declare function startClassUnitTestRunLegacy(connection: IAbapConnection, tests: IClassUnitTestDefinition[], options?: IClassUnitTestRunOptions): Promise<AxiosResponse>;
+export declare function startClassUnitTestRunLegacy(connection: IAbapConnection, tests: IClassUnitTestDefinition[], _options?: IClassUnitTestRunOptions): Promise<AxiosResponse>;
 export declare function getClassUnitTestStatusLegacy(connection: IAbapConnection, runId: string, withLongPolling?: boolean): Promise<AxiosResponse>;
 export declare function getClassUnitTestResultLegacy(connection: IAbapConnection, runId: string, options?: {
     withNavigationUris?: boolean;

package/dist/core/unitTest/runLegacy.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"runLegacy.d.ts","sourceRoot":"","sources":["../../../src/core/unitTest/runLegacy.ts"],"names":[],"mappings":"AAAA;;;;;;GAMG;AAEH,OAAO,KAAK,EACV,YAAY,IAAI,aAAa,EAC7B,eAAe,EAChB,MAAM,0BAA0B,CAAC;AAGlC,OAAO,KAAK,EACV,wBAAwB,EACxB,wBAAwB,EACzB,MAAM,SAAS,CAAC;AASjB;;;GAGG;AACH,wBAAsB,2BAA2B,CAC/C,UAAU,EAAE,eAAe,EAC3B,KAAK,EAAE,wBAAwB,EAAE,EACjC,OAAO,CAAC,EAAE,wBAAwB,GACjC,OAAO,CAAC,aAAa,CAAC,CAiDxB;AAED,wBAAsB,4BAA4B,CAChD,UAAU,EAAE,eAAe,EAC3B,KAAK,EAAE,MAAM,EACb,eAAe,GAAE,OAAc,GAC9B,OAAO,CAAC,aAAa,CAAC,CAaxB;AAED,wBAAsB,4BAA4B,CAChD,UAAU,EAAE,eAAe,EAC3B,KAAK,EAAE,MAAM,EACb,OAAO,CAAC,EAAE;IAAE,kBAAkB,CAAC,EAAE,OAAO,CAAA;CAAE,GACzC,OAAO,CAAC,aAAa,CAAC,CAkBxB"}
+{"version":3,"file":"runLegacy.d.ts","sourceRoot":"","sources":["../../../src/core/unitTest/runLegacy.ts"],"names":[],"mappings":"AAAA;;;;;;GAMG;AAEH,OAAO,KAAK,EACV,YAAY,IAAI,aAAa,EAC7B,eAAe,EAChB,MAAM,0BAA0B,CAAC;AAGlC,OAAO,KAAK,EACV,wBAAwB,EACxB,wBAAwB,EACzB,MAAM,SAAS,CAAC;AAKjB;;;;;;;;;GASG;AACH,wBAAsB,2BAA2B,CAC/C,UAAU,EAAE,eAAe,EAC3B,KAAK,EAAE,wBAAwB,EAAE,EACjC,QAAQ,CAAC,EAAE,wBAAwB,GAClC,OAAO,CAAC,aAAa,CAAC,CAmCxB;AAED,wBAAsB,4BAA4B,CAChD,UAAU,EAAE,eAAe,EAC3B,KAAK,EAAE,MAAM,EACb,eAAe,GAAE,OAAc,GAC9B,OAAO,CAAC,aAAa,CAAC,CAaxB;AAED,wBAAsB,4BAA4B,CAChD,UAAU,EAAE,eAAe,EAC3B,KAAK,EAAE,MAAM,EACb,OAAO,CAAC,EAAE;IAAE,kBAAkB,CAAC,EAAE,OAAO,CAAA;CAAE,GACzC,OAAO,CAAC,aAAa,CAAC,CAkBxB"}

package/dist/core/unitTest/runLegacy.js

@@ -14,45 +14,38 @@ const internalUtils_1 = require("../../utils/internalUtils");
 const timeouts_1 = require("../../utils/timeouts");
 const CT_XML = 'application/xml';
 const ACCEPT_XML = 'application/xml';
-function boolAttr(value, fallback) {
-    return (value ?? fallback) ? 'true' : 'false';
-}
 /**
  * Start ABAP Unit test run on legacy systems
- * Uses /sap/bc/adt/abapunit/testruns endpoint with application/xml content type
+ * Uses /sap/bc/adt/abapunit/testruns endpoint with aunit:runConfiguration format
+ *
+ * Legacy format differs from modern:
+ * - Root element: aunit:runConfiguration (not aunit:run)
+ * - Namespace: http://www.sap.com/adt/aunit (not http://www.sap.com/adt/api/aunit)
+ * - Objects via adtcore:objectReferences with URI (not aunit:tests with containerClass/class)
+ * - Content-Type/Accept: application/xml (not versioned vnd.sap.adt.api.abapunit.*)
  */
-async function startClassUnitTestRunLegacy(connection, tests, options) {
+async function startClassUnitTestRunLegacy(connection, tests, _options) {
     if (!tests.length) {
         throw new Error('At least one test definition is required');
     }
-    const scope = options?.scope ?? {
-        ownTests: true,
-        foreignTests: false,
-        addForeignTestsAsPreview: true,
-    };
-    const risk = options?.riskLevel ?? {
-        harmless: true,
-        dangerous: true,
-        critical: true,
-    };
-    const duration = options?.duration ?? {
-        short: true,
-        medium: true,
-        long: true,
-    };
-    const testsXml = tests
-        .map((test) => `<aunit:test containerClass="${(0, internalUtils_1.encodeSapObjectName)(test.containerClass).toUpperCase()}" class="${test.testClass}"/>`)
-        .join('');
-    const xml = `<?xml version="1.0" encoding="UTF-8"?><aunit:run xmlns:aunit="http://www.sap.com/adt/api/aunit" title="${options?.title || tests[0].testClass}" context="${options?.context || 'MCP ABAP ADT Client'}">
-  <aunit:options>
-    <aunit:scope ownTests="${boolAttr(scope.ownTests, true)}" foreignTests="${boolAttr(scope.foreignTests, false)}" addForeignTestsAsPreview="${boolAttr(scope.addForeignTestsAsPreview, true)}"/>
-    <aunit:riskLevel harmless="${boolAttr(risk.harmless, true)}" dangerous="${boolAttr(risk.dangerous, true)}" critical="${boolAttr(risk.critical, true)}"/>
-    <aunit:duration short="${boolAttr(duration.short, true)}" medium="${boolAttr(duration.medium, true)}" long="${boolAttr(duration.long, true)}"/>
-  </aunit:options>
-  <aunit:tests>
-    ${testsXml}
-  </aunit:tests>
-</aunit:run>`;
+    const objectRefs = tests
+        .map((test) => {
+        const className = (0, internalUtils_1.encodeSapObjectName)(test.containerClass).toLowerCase();
+        return `        <adtcore:objectReference adtcore:uri="/sap/bc/adt/oo/classes/${className}"/>`;
+    })
+        .join('\n');
+    const xml = `<?xml version="1.0" encoding="UTF-8"?><aunit:runConfiguration xmlns:aunit="http://www.sap.com/adt/aunit">
+  <external>
+    <coverage active="false"/>
+  </external>
+  <adtcore:objectSets xmlns:adtcore="http://www.sap.com/adt/core">
+    <objectSet kind="inclusive">
+      <adtcore:objectReferences>
+${objectRefs}
+      </adtcore:objectReferences>
+    </objectSet>
+  </adtcore:objectSets>
+</aunit:runConfiguration>`;
     return connection.makeAdtRequest({
         url: '/sap/bc/adt/abapunit/testruns',
         method: 'POST',

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mcp-abap-adt/adt-clients",
-  "version": "3.6.0",
+  "version": "3.7.0",
   "description": "ADT clients for SAP ABAP systems - AdtClient and AdtRuntimeClient",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",