@mcoda/core 0.1.18 → 0.1.20

package/dist/services/planning/RefineTasksService.d.ts

@@ -49,6 +49,7 @@ export declare class RefineTasksService {
     private parseTaskKeyParts;
     private ensureTaskExists;
     private buildStoryPrompt;
+    private buildOpenApiHintSummary;
     private summarizeDocs;
     private summarizeHistory;
     private logWarningsToTasks;

package/dist/services/planning/RefineTasksService.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"RefineTasksService.d.ts","sourceRoot":"","sources":["../../../src/services/planning/RefineTasksService.ts"],"names":[],"mappings":"AAEA,OAAO,EAAE,YAAY,EAAE,MAAM,eAAe,CAAC;AAC7C,OAAO,EAAE,YAAY,EAAE,MAAM,qBAAqB,CAAC;AAEnD,OAAO,EAAE,gBAAgB,EAA6C,mBAAmB,EAAE,MAAM,WAAW,CAAC;AAC7G,OAAO,EAIL,kBAAkB,EAClB,iBAAiB,EAKlB,MAAM,eAAe,CAAC;AACvB,OAAO,EAAE,mBAAmB,EAAE,MAAM,qCAAqC,CAAC;AAC1E,OAAO,EAAE,UAAU,EAAE,MAAM,uBAAuB,CAAC;AACnD,OAAO,EAAE,cAAc,EAAE,MAAM,6BAA6B,CAAC;AAC7D,OAAO,EAAE,kBAAkB,EAAE,MAAM,iCAAiC,CAAC;AAKrE,UAAU,kBAAmB,SAAQ,kBAAkB;IACrD,SAAS,EAAE,mBAAmB,CAAC;IAC/B,QAAQ,CAAC,EAAE,MAAM,CAAC;IAClB,SAAS,CAAC,EAAE,MAAM,CAAC;IACnB,WAAW,CAAC,EAAE,OAAO,CAAC;IACtB,UAAU,CAAC,EAAE,OAAO,CAAC;IACrB,MAAM,CAAC,EAAE,OAAO,CAAC;IACjB,UAAU,CAAC,EAAE,MAAM,CAAC;IACpB,WAAW,CAAC,EAAE,MAAM,CAAC;IACrB,KAAK,CAAC,EAAE,MAAM,CAAC;IACf,KAAK,CAAC,EAAE,OAAO,CAAC;IAChB,qBAAqB,CAAC,EAAE,OAAO,CAAC;IAChC,mBAAmB,CAAC,EAAE,OAAO,CAAC;IAC9B,UAAU,CAAC,EAAE,OAAO,CAAC;CACtB;AAwLD,qBAAa,kBAAkB;IAC7B,OAAO,CAAC,MAAM,CAAe;IAC7B,OAAO,CAAC,UAAU,CAAa;IAC/B,OAAO,CAAC,YAAY,CAAe;IACnC,OAAO,CAAC,IAAI,CAAmB;IAC/B,OAAO,CAAC,aAAa,CAAsB;IAC3C,OAAO,CAAC,cAAc,CAAiB;IACvC,OAAO,CAAC,SAAS,CAAsB;IACvC,OAAO,CAAC,aAAa,CAAC,CAAqB;gBAGzC,SAAS,EAAE,mBAAmB,EAC9B,IAAI,EAAE;QACJ,MAAM,EAAE,YAAY,CAAC;QACrB,UAAU,EAAE,UAAU,CAAC;QACvB,YAAY,EAAE,YAAY,CAAC;QAC3B,IAAI,EAAE,gBAAgB,CAAC;QACvB,aAAa,EAAE,mBAAmB,CAAC;QACnC,cAAc,EAAE,cAAc,CAAC;QAC/B,aAAa,CAAC,EAAE,kBAAkB,CAAC;KACpC;WAYU,MAAM,CAAC,SAAS,EAAE,mBAAmB,GAAG,OAAO,CAAC,kBAAkB,CAAC;IAuB1E,KAAK,IAAI,OAAO,CAAC,IAAI,CAAC;YAkBd,cAAc;YAWd,YAAY;YAwBZ,mBAAmB;IA4CjC,OAAO,CAAC,mBAAmB;YAYb,WAAW;IA4KzB,OAAO,CAAC,iBAAiB;YASX,gBAAgB;IAmK9B,OAAO,CAAC,gBAAgB;YA+BV,aAAa;YA+Db,gBAAgB;YA+BhB,kBAAkB;IAkChC,OAAO,CAAC,aAAa;IAKrB,OAAO,CAAC,kBAAkB;IAkB1B,OAAO,CAAC,iBAAiB;IA8EzB,OAAO,CAAC,WAAW;IA0BnB,OAAO,CAAC,iBAAiB;YAkBX,eAAe;YAqYf,WAAW;IAmGnB,WAAW,CAAC,OAAO,EAAE,kBAAkB,GAAG,OAAO,CAAC,iBAAiB,CAAC;CAma3E"}
+{"version":3,"file":"RefineTasksService.d.ts","sourceRoot":"","sources":["../../../src/services/planning/RefineTasksService.ts"],"names":[],"mappings":"AAGA,OAAO,EAAE,YAAY,EAAE,MAAM,eAAe,CAAC;AAC7C,OAAO,EAAE,YAAY,EAAE,MAAM,qBAAqB,CAAC;AAEnD,OAAO,EAAE,gBAAgB,EAA6C,mBAAmB,EAAE,MAAM,WAAW,CAAC;AAC7G,OAAO,EAIL,kBAAkB,EAClB,iBAAiB,EAKlB,MAAM,eAAe,CAAC;AACvB,OAAO,EAAE,mBAAmB,EAAE,MAAM,qCAAqC,CAAC;AAC1E,OAAO,EAAE,UAAU,EAAE,MAAM,uBAAuB,CAAC;AACnD,OAAO,EAAE,cAAc,EAAE,MAAM,6BAA6B,CAAC;AAC7D,OAAO,EAAE,kBAAkB,EAAE,MAAM,iCAAiC,CAAC;AAKrE,UAAU,kBAAmB,SAAQ,kBAAkB;IACrD,SAAS,EAAE,mBAAmB,CAAC;IAC/B,QAAQ,CAAC,EAAE,MAAM,CAAC;IAClB,SAAS,CAAC,EAAE,MAAM,CAAC;IACnB,WAAW,CAAC,EAAE,OAAO,CAAC;IACtB,UAAU,CAAC,EAAE,OAAO,CAAC;IACrB,MAAM,CAAC,EAAE,OAAO,CAAC;IACjB,UAAU,CAAC,EAAE,MAAM,CAAC;IACpB,WAAW,CAAC,EAAE,MAAM,CAAC;IACrB,KAAK,CAAC,EAAE,MAAM,CAAC;IACf,KAAK,CAAC,EAAE,OAAO,CAAC;IAChB,qBAAqB,CAAC,EAAE,OAAO,CAAC;IAChC,mBAAmB,CAAC,EAAE,OAAO,CAAC;IAC9B,UAAU,CAAC,EAAE,OAAO,CAAC;CACtB;AA6MD,qBAAa,kBAAkB;IAC7B,OAAO,CAAC,MAAM,CAAe;IAC7B,OAAO,CAAC,UAAU,CAAa;IAC/B,OAAO,CAAC,YAAY,CAAe;IACnC,OAAO,CAAC,IAAI,CAAmB;IAC/B,OAAO,CAAC,aAAa,CAAsB;IAC3C,OAAO,CAAC,cAAc,CAAiB;IACvC,OAAO,CAAC,SAAS,CAAsB;IACvC,OAAO,CAAC,aAAa,CAAC,CAAqB;gBAGzC,SAAS,EAAE,mBAAmB,EAC9B,IAAI,EAAE;QACJ,MAAM,EAAE,YAAY,CAAC;QACrB,UAAU,EAAE,UAAU,CAAC;QACvB,YAAY,EAAE,YAAY,CAAC;QAC3B,IAAI,EAAE,gBAAgB,CAAC;QACvB,aAAa,EAAE,mBAAmB,CAAC;QACnC,cAAc,EAAE,cAAc,CAAC;QAC/B,aAAa,CAAC,EAAE,kBAAkB,CAAC;KACpC;WAYU,MAAM,CAAC,SAAS,EAAE,mBAAmB,GAAG,OAAO,CAAC,kBAAkB,CAAC;IAuB1E,KAAK,IAAI,OAAO,CAAC,IAAI,CAAC;YAkBd,cAAc;YAYd,YAAY;YAwBZ,mBAAmB;IA4CjC,OAAO,CAAC,mBAAmB;YAYb,WAAW;IA4KzB,OAAO,CAAC,iBAAiB;YASX,gBAAgB;IAmK9B,OAAO,CAAC,gBAAgB;IA+BxB,OAAO,CAAC,uBAAuB;YA+CjB,aAAa;YA4Eb,gBAAgB;YA+BhB,kBAAkB;IAkChC,OAAO,CAAC,aAAa;IAKrB,OAAO,CAAC,kBAAkB;IAkB1B,OAAO,CAAC,iBAAiB;IA8EzB,OAAO,CAAC,WAAW;IA0BnB,OAAO,CAAC,iBAAiB;YAkBX,eAAe;YAqYf,WAAW;IAmGnB,WAAW,CAAC,OAAO,EAAE,kBAAkB,GAAG,OAAO,CAAC,iBAAiB,CAAC;CAma3E"}

package/dist/services/planning/RefineTasksService.js

@@ -1,5 +1,6 @@
 import path from "node:path";
 import { promises as fs } from "node:fs";
+import YAML from "yaml";
 import { AgentService } from "@mcoda/agents";
 import { DocdexClient } from "@mcoda/integrations";
 import { READY_TO_CODE_REVIEW } from "@mcoda/shared";
@@ -21,7 +22,31 @@ const normalizeCreateStatus = (status) => {
 const DEFAULT_MAX_TASKS = 250;
 const MAX_AGENT_OUTPUT_CHARS = 10000000;
 const PLANNING_DOC_HINT_PATTERN = /(sds|pdr|rfp|requirements|architecture|openapi|swagger|design)/i;
+const OPENAPI_METHODS = new Set(["get", "post", "put", "patch", "delete", "options", "head", "trace"]);
+const OPENAPI_HINTS_LIMIT = 20;
 const estimateTokens = (text) => Math.max(1, Math.ceil(text.length / 4));
+const isPlainObject = (value) => Boolean(value && typeof value === "object" && !Array.isArray(value));
+const parseStructuredDoc = (raw) => {
+    if (!raw || raw.trim().length === 0)
+        return undefined;
+    try {
+        const parsed = YAML.parse(raw);
+        if (isPlainObject(parsed))
+            return parsed;
+    }
+    catch {
+        // continue
+    }
+    try {
+        const parsed = JSON.parse(raw);
+        if (isPlainObject(parsed))
+            return parsed;
+    }
+    catch {
+        // ignore
+    }
+    return undefined;
+};
 const extractJson = (raw) => {
     const fencedMatches = [...raw.matchAll(/```json([\s\S]*?)```/g)].map((match) => match[1]);
     const stripped = raw.replace(/<think>[\s\S]*?<\/think>/g, "");
@@ -224,6 +249,7 @@ export class RefineTasksService {
         try {
             await ordering.orderTasks({
                 projectKey,
+                apply: true,
             });
         }
         finally {
@@ -606,16 +632,72 @@ export class RefineTasksService {
             "Return JSON ONLY matching: { \"operations\": [UpdateTaskOp | SplitTaskOp | MergeTasksOp | UpdateEstimateOp] } where each item has an `op` discriminator (update_task|split_task|merge_tasks|update_estimate).",
         ].join("\n\n");
     }
+    buildOpenApiHintSummary(docs) {
+        const lines = [];
+        for (const doc of docs ?? []) {
+            const raw = typeof doc?.content === "string" && doc.content.trim().length > 0
+                ? doc.content
+                : Array.isArray(doc?.segments)
+                    ? doc.segments
+                        .map((segment) => (typeof segment?.content === "string" ? segment.content : ""))
+                        .filter(Boolean)
+                        .join("\n\n")
+                    : "";
+            const parsed = parseStructuredDoc(raw);
+            if (!parsed)
+                continue;
+            const paths = parsed.paths;
+            if (!isPlainObject(paths))
+                continue;
+            for (const [apiPath, pathItem] of Object.entries(paths)) {
+                if (!isPlainObject(pathItem))
+                    continue;
+                for (const [method, operation] of Object.entries(pathItem)) {
+                    const normalizedMethod = method.toLowerCase();
+                    if (!OPENAPI_METHODS.has(normalizedMethod))
+                        continue;
+                    if (!isPlainObject(operation))
+                        continue;
+                    const hints = operation["x-mcoda-task-hints"];
+                    if (!isPlainObject(hints))
+                        continue;
+                    const service = typeof hints.service === "string" ? hints.service : "-";
+                    const capability = typeof hints.capability === "string" ? hints.capability : "-";
+                    const stage = typeof hints.stage === "string" ? hints.stage : "-";
+                    const complexity = typeof hints.complexity === "number" && Number.isFinite(hints.complexity)
+                        ? hints.complexity.toFixed(1)
+                        : "-";
+                    const countItems = (value) => Array.isArray(value) ? value.filter((item) => typeof item === "string").length : 0;
+                    const dependsOn = countItems(hints.depends_on_operations);
+                    const testRequirements = isPlainObject(hints.test_requirements) ? hints.test_requirements : undefined;
+                    lines.push(`- ${normalizedMethod.toUpperCase()} ${apiPath} :: service=${service}; capability=${capability}; stage=${stage}; complexity=${complexity}; deps=${dependsOn}; tests(u/c/i/a)=${countItems(testRequirements?.unit)}/${countItems(testRequirements?.component)}/${countItems(testRequirements?.integration)}/${countItems(testRequirements?.api)}`);
+                    if (lines.length >= OPENAPI_HINTS_LIMIT) {
+                        return lines.join("\n");
+                    }
+                }
+            }
+        }
+        return lines.join("\n");
+    }
     async summarizeDocs(projectKey, epicKey, storyKey) {
         const warnings = [];
         const startedAt = Date.now();
         try {
-            const query = [epicKey, storyKey, "sds requirements architecture"].filter(Boolean).join(" ");
+            const query = [epicKey, storyKey, "sds requirements architecture openapi swagger api contracts endpoints"]
+                .filter(Boolean)
+                .join(" ");
             let docs = await this.docdex.search({
                 projectKey,
                 profile: "sds",
                 query,
             });
+            if (!docs || docs.length === 0) {
+                docs = await this.docdex.search({
+                    projectKey,
+                    profile: "openapi",
+                    query,
+                });
+            }
             if (!docs || docs.length === 0) {
                 docs = await this.docdex.search({
                     projectKey,
@@ -648,6 +730,10 @@ export class RefineTasksService {
             })
                 .join("\n");
             const finalSummary = (summary || (selected.length ? selected.map((doc) => `- ${doc.title ?? doc.path ?? doc.id}`).join("\n") : "")).trim();
+            const openApiHintSummary = this.buildOpenApiHintSummary(selected);
+            const composedSummary = [finalSummary || "(no doc segments found)", openApiHintSummary ? `[OPENAPI_HINTS]\n${openApiHintSummary}` : ""]
+                .filter(Boolean)
+                .join("\n\n");
             const durationSeconds = (Date.now() - startedAt) / 1000;
             await this.jobService.recordTokenUsage({
                 workspaceId: this.workspace.workspaceId,
@@ -662,7 +748,7 @@ export class RefineTasksService {
                 timestamp: new Date().toISOString(),
                 metadata: { command: "refine-tasks", action: "docdex_search", projectKey, epicKey, storyKey },
             });
-            return { summary: finalSummary || "(no doc segments found)", warnings };
+            return { summary: composedSummary, warnings };
         }
         catch (error) {
             warnings.push(`Docdex lookup failed: ${error.message}`);

package/dist/services/review/CodeReviewService.d.ts

@@ -15,6 +15,8 @@ export interface CodeReviewRequest extends TaskSelectionFilters {
     agentStream?: boolean;
     rateAgents?: boolean;
     createFollowupTasks?: boolean;
+    executionContextPolicy?: "best_effort" | "require_any" | "require_sds_or_openapi";
+    emptyDiffApprovalPolicy?: "ready_to_qa" | "complete";
     resumeJobId?: string;
     abortSignal?: AbortSignal;
 }
@@ -88,6 +90,8 @@ export declare class CodeReviewService {
     private resolveAgent;
     private ensureRatingService;
     private resolveTaskComplexity;
+    private enforceExecutionContextPolicy;
+    private resolveExecutionPlanningContext;
     private selectTasksViaApi;
     private persistState;
     private loadState;
@@ -102,6 +106,8 @@ export declare class CodeReviewService {
     private resolveFindingSlug;
     private applyCommentResolutions;
     private extractPathsFromDiff;
+    private readOpenApiFileIfExists;
+    private resolveOpenApiContent;
     private buildOpenApiSlice;
     private buildDiff;
     private writeReviewSummaryComment;

package/dist/services/review/CodeReviewService.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"CodeReviewService.d.ts","sourceRoot":"","sources":["../../../src/services/review/CodeReviewService.ts"],"names":[],"mappings":"AAGA,OAAO,EAAE,YAAY,EAAE,MAAM,eAAe,CAAC;AAC7C,OAAO,EAAE,YAAY,EAAE,SAAS,EAAE,MAAM,qBAAqB,CAAC;AAC9D,OAAO,EACL,gBAAgB,EAChB,mBAAmB,EAMpB,MAAM,WAAW,CAAC;AASnB,OAAO,EAAE,mBAAmB,EAAE,MAAM,qCAAqC,CAAC;AAC1E,OAAO,EAAE,UAAU,EAAE,MAAM,uBAAuB,CAAC;AACnD,OAAO,EAAE,oBAAoB,EAAE,oBAAoB,EAAE,MAAM,sCAAsC,CAAC;AAClG,OAAO,EAAE,gBAAgB,EAAE,MAAM,kCAAkC,CAAC;AAIpE,OAAO,EAAE,cAAc,EAAsB,MAAM,6BAA6B,CAAC;AACjF,OAAO,EAAE,kBAAkB,EAAE,MAAM,iCAAiC,CAAC;AAkFrE,MAAM,WAAW,iBAAkB,SAAQ,oBAAoB;IAC7D,SAAS,EAAE,mBAAmB,CAAC;IAC/B,OAAO,CAAC,EAAE,MAAM,CAAC;IACjB,MAAM,CAAC,EAAE,OAAO,CAAC;IACjB,SAAS,CAAC,EAAE,MAAM,CAAC;IACnB,WAAW,CAAC,EAAE,OAAO,CAAC;IACtB,UAAU,CAAC,EAAE,OAAO,CAAC;IACrB,mBAAmB,CAAC,EAAE,OAAO,CAAC;IAC9B,WAAW,CAAC,EAAE,MAAM,CAAC;IACrB,WAAW,CAAC,EAAE,WAAW,CAAC;CAC3B;AAED,MAAM,WAAW,aAAa;IAC5B,IAAI,CAAC,EAAE,MAAM,CAAC;IACd,QAAQ,CAAC,EAAE,MAAM,CAAC;IAClB,IAAI,CAAC,EAAE,MAAM,CAAC;IACd,IAAI,CAAC,EAAE,MAAM,CAAC;IACd,OAAO,EAAE,MAAM,CAAC;IAChB,YAAY,CAAC,EAAE,MAAM,CAAC;CACvB;AAED,MAAM,WAAW,iBAAiB;IAChC,QAAQ,EAAE,SAAS,GAAG,mBAAmB,GAAG,OAAO,GAAG,WAAW,CAAC;IAClE,OAAO,CAAC,EAAE,MAAM,CAAC;IACjB,QAAQ,EAAE,aAAa,EAAE,CAAC;IAC1B,mBAAmB,CAAC,EAAE,MAAM,EAAE,CAAC;IAC/B,aAAa,CAAC,EAAE,MAAM,EAAE,CAAC;IACzB,eAAe,CAAC,EAAE,MAAM,EAAE,CAAC;IAC3B,GAAG,CAAC,EAAE,MAAM,CAAC;CACd;AAED,MAAM,WAAW,gBAAgB;IAC/B,MAAM,EAAE,MAAM,CAAC;IACf,OAAO,EAAE,MAAM,CAAC;IAChB,YAAY,EAAE,MAAM,CAAC;IACrB,WAAW,CAAC,EAAE,MAAM,CAAC;IACrB,QAAQ,CAAC,EAAE,iBAAiB,CAAC,UAAU,CAAC,CAAC;IACzC,QAAQ,EAAE,aAAa,EAAE,CAAC;IAC1B,KAAK,CAAC,EAAE,MAAM,CAAC;IACf,aAAa,CAAC,EAAE;QAAE,MAAM,EAAE,MAAM,CAAC;QAAC,OAAO,EAAE,MAAM,CAAC;QAAC,MAAM,EAAE,MAAM,CAAC;QAAC,WAAW,EAAE,MAAM,CAAC;QAAC,OAAO,CAAC,EAAE,OAAO,CAAA;KAAE,EAAE,CAAC;CAC/G;AAED,MAAM,WAAW,gBAAgB;IAC/B,KAAK,EAAE,MAAM,CAAC;IACd,YAAY,EAAE,MAAM,CAAC;IACrB,KAAK,EAAE,gBAAgB,EAAE,CAAC;IAC1B,QAAQ,EAAE,MAAM,EAAE,CAAC;CACpB;AA6QD,qBAAa,iBAAiB;IAS1B,OAAO,CAAC,SAAS;IACjB,OAAO,CAAC,IAAI;IATd,OAAO,CAAC,gBAAgB,CAAuB;IAC/C,OAAO,CAAC,YAAY,CAAmB;IACvC,OAAO,CAAC,GAAG,CAAY;IACvB,OAAO,CAAC,UAAU,CAA6B;IAC/C,OAAO,CAAC,cAAc,CAAiB;IACvC,OAAO,CAAC,aAAa,CAAC,CAAqB;gBAGjC,SAAS,EAAE,mBAAmB,EAC9B,IAAI,EAAE;QACZ,YAAY,EAAE,YAAY,CAAC;QAC3B,MAAM,EAAE,YAAY,CAAC;QACrB,UAAU,EAAE,UAAU,CAAC;QACvB,aAAa,EAAE,mBAAmB,CAAC;QACnC,gBAAgB,CAAC,EAAE,oBAAoB,CAAC;QACxC,YAAY,CAAC,EAAE,gBAAgB,CAAC;QAChC,IAAI,EAAE,gBAAgB,CAAC;QACvB,SAAS,CAAC,EAAE,SAAS,CAAC;QACtB,cAAc,EAAE,cAAc,CAAC;QAC/B,aAAa,CAAC,EAAE,kBAAkB,CAAC;KACpC;WASU,MAAM,CAAC,SAAS,EAAE,mBAAmB,GAAG,OAAO,CAAC,iBAAiB,CAAC;IA6BzE,KAAK,IAAI,OAAO,CAAC,IAAI,CAAC;IAkB5B,qBAAqB,CAAC,SAAS,EAAE,OAAO,EAAE,MAAM,CAAC,EAAE,MAAM,GAAG,IAAI;YAQlD,eAAe;YAkBf,WAAW;YAIX,WAAW;YAqCX,wBAAwB;YAuBxB,YAAY;IAiB1B,OAAO,CAAC,mBAAmB;IAY3B,OAAO,CAAC,qBAAqB;YAUf,iBAAiB;YAoCjB,YAAY;YAUZ,SAAS;YAST,eAAe;IAI7B,OAAO,CAAC,uBAAuB;YAiBjB,gBAAgB;IA6H9B,OAAO,CAAC,iBAAiB;YAkEX,mBAAmB;YA+BnB,kBAAkB;IAShC,OAAO,CAAC,cAAc;IAQtB,OAAO,CAAC,qBAAqB;IAW7B,OAAO,CAAC,kBAAkB;YAcZ,uBAAuB;IAoKrC,OAAO,CAAC,oBAAoB;YAWd,iBAAiB;YA6CjB,SAAS;YA+BT,yBAAyB;YAyCzB,cAAc;YAUd,WAAW;YA+BX,mBAAmB;IAQjC,OAAO,CAAC,kBAAkB;IAO1B,OAAO,CAAC,qBAAqB;IAO7B,OAAO,CAAC,wBAAwB;IAYhC,OAAO,CAAC,kBAAkB;IAQ1B,OAAO,CAAC,wBAAwB;YAalB,uBAAuB;YAkDvB,8BAA8B;IA2FtC,WAAW,CAAC,OAAO,EAAE,iBAAiB,GAAG,OAAO,CAAC,gBAAgB,CAAC;IAgpCxE,OAAO,CAAC,eAAe;CAMxB"}
+{"version":3,"file":"CodeReviewService.d.ts","sourceRoot":"","sources":["../../../src/services/review/CodeReviewService.ts"],"names":[],"mappings":"AAGA,OAAO,EAAE,YAAY,EAAE,MAAM,eAAe,CAAC;AAC7C,OAAO,EAAE,YAAY,EAAE,SAAS,EAAE,MAAM,qBAAqB,CAAC;AAC9D,OAAO,EACL,gBAAgB,EAChB,mBAAmB,EAMpB,MAAM,WAAW,CAAC;AASnB,OAAO,EAAE,mBAAmB,EAAE,MAAM,qCAAqC,CAAC;AAC1E,OAAO,EAAE,UAAU,EAAE,MAAM,uBAAuB,CAAC;AACnD,OAAO,EAAE,oBAAoB,EAAE,oBAAoB,EAAE,MAAM,sCAAsC,CAAC;AAClG,OAAO,EAAE,gBAAgB,EAAE,MAAM,kCAAkC,CAAC;AAIpE,OAAO,EAAE,cAAc,EAAsB,MAAM,6BAA6B,CAAC;AACjF,OAAO,EAAE,kBAAkB,EAAE,MAAM,iCAAiC,CAAC;AAyHrE,MAAM,WAAW,iBAAkB,SAAQ,oBAAoB;IAC7D,SAAS,EAAE,mBAAmB,CAAC;IAC/B,OAAO,CAAC,EAAE,MAAM,CAAC;IACjB,MAAM,CAAC,EAAE,OAAO,CAAC;IACjB,SAAS,CAAC,EAAE,MAAM,CAAC;IACnB,WAAW,CAAC,EAAE,OAAO,CAAC;IACtB,UAAU,CAAC,EAAE,OAAO,CAAC;IACrB,mBAAmB,CAAC,EAAE,OAAO,CAAC;IAC9B,sBAAsB,CAAC,EAAE,aAAa,GAAG,aAAa,GAAG,wBAAwB,CAAC;IAClF,uBAAuB,CAAC,EAAE,aAAa,GAAG,UAAU,CAAC;IACrD,WAAW,CAAC,EAAE,MAAM,CAAC;IACrB,WAAW,CAAC,EAAE,WAAW,CAAC;CAC3B;AAUD,MAAM,WAAW,aAAa;IAC5B,IAAI,CAAC,EAAE,MAAM,CAAC;IACd,QAAQ,CAAC,EAAE,MAAM,CAAC;IAClB,IAAI,CAAC,EAAE,MAAM,CAAC;IACd,IAAI,CAAC,EAAE,MAAM,CAAC;IACd,OAAO,EAAE,MAAM,CAAC;IAChB,YAAY,CAAC,EAAE,MAAM,CAAC;CACvB;AAED,MAAM,WAAW,iBAAiB;IAChC,QAAQ,EAAE,SAAS,GAAG,mBAAmB,GAAG,OAAO,GAAG,WAAW,CAAC;IAClE,OAAO,CAAC,EAAE,MAAM,CAAC;IACjB,QAAQ,EAAE,aAAa,EAAE,CAAC;IAC1B,mBAAmB,CAAC,EAAE,MAAM,EAAE,CAAC;IAC/B,aAAa,CAAC,EAAE,MAAM,EAAE,CAAC;IACzB,eAAe,CAAC,EAAE,MAAM,EAAE,CAAC;IAC3B,GAAG,CAAC,EAAE,MAAM,CAAC;CACd;AAED,MAAM,WAAW,gBAAgB;IAC/B,MAAM,EAAE,MAAM,CAAC;IACf,OAAO,EAAE,MAAM,CAAC;IAChB,YAAY,EAAE,MAAM,CAAC;IACrB,WAAW,CAAC,EAAE,MAAM,CAAC;IACrB,QAAQ,CAAC,EAAE,iBAAiB,CAAC,UAAU,CAAC,CAAC;IACzC,QAAQ,EAAE,aAAa,EAAE,CAAC;IAC1B,KAAK,CAAC,EAAE,MAAM,CAAC;IACf,aAAa,CAAC,EAAE;QAAE,MAAM,EAAE,MAAM,CAAC;QAAC,OAAO,EAAE,MAAM,CAAC;QAAC,MAAM,EAAE,MAAM,CAAC;QAAC,WAAW,EAAE,MAAM,CAAC;QAAC,OAAO,CAAC,EAAE,OAAO,CAAA;KAAE,EAAE,CAAC;CAC/G;AAED,MAAM,WAAW,gBAAgB;IAC/B,KAAK,EAAE,MAAM,CAAC;IACd,YAAY,EAAE,MAAM,CAAC;IACrB,KAAK,EAAE,gBAAgB,EAAE,CAAC;IAC1B,QAAQ,EAAE,MAAM,EAAE,CAAC;CACpB;AA6QD,qBAAa,iBAAiB;IAS1B,OAAO,CAAC,SAAS;IACjB,OAAO,CAAC,IAAI;IATd,OAAO,CAAC,gBAAgB,CAAuB;IAC/C,OAAO,CAAC,YAAY,CAAmB;IACvC,OAAO,CAAC,GAAG,CAAY;IACvB,OAAO,CAAC,UAAU,CAA6B;IAC/C,OAAO,CAAC,cAAc,CAAiB;IACvC,OAAO,CAAC,aAAa,CAAC,CAAqB;gBAGjC,SAAS,EAAE,mBAAmB,EAC9B,IAAI,EAAE;QACZ,YAAY,EAAE,YAAY,CAAC;QAC3B,MAAM,EAAE,YAAY,CAAC;QACrB,UAAU,EAAE,UAAU,CAAC;QACvB,aAAa,EAAE,mBAAmB,CAAC;QACnC,gBAAgB,CAAC,EAAE,oBAAoB,CAAC;QACxC,YAAY,CAAC,EAAE,gBAAgB,CAAC;QAChC,IAAI,EAAE,gBAAgB,CAAC;QACvB,SAAS,CAAC,EAAE,SAAS,CAAC;QACtB,cAAc,EAAE,cAAc,CAAC;QAC/B,aAAa,CAAC,EAAE,kBAAkB,CAAC;KACpC;WASU,MAAM,CAAC,SAAS,EAAE,mBAAmB,GAAG,OAAO,CAAC,iBAAiB,CAAC;IA6BzE,KAAK,IAAI,OAAO,CAAC,IAAI,CAAC;IAkB5B,qBAAqB,CAAC,SAAS,EAAE,OAAO,EAAE,MAAM,CAAC,EAAE,MAAM,GAAG,IAAI;YAQlD,eAAe;YAkBf,WAAW;YAIX,WAAW;YAqCX,wBAAwB;YAuBxB,YAAY;IAiB1B,OAAO,CAAC,mBAAmB;IAY3B,OAAO,CAAC,qBAAqB;IAU7B,OAAO,CAAC,6BAA6B;YAuBvB,+BAA+B;YA0C/B,iBAAiB;YAoCjB,YAAY;YAUZ,SAAS;YAST,eAAe;IAI7B,OAAO,CAAC,uBAAuB;YAiBjB,gBAAgB;IAqL9B,OAAO,CAAC,iBAAiB;YAkEX,mBAAmB;YA+BnB,kBAAkB;IAShC,OAAO,CAAC,cAAc;IAQtB,OAAO,CAAC,qBAAqB;IAW7B,OAAO,CAAC,kBAAkB;YAcZ,uBAAuB;IAoKrC,OAAO,CAAC,oBAAoB;YAWd,uBAAuB;YAYvB,qBAAqB;YAmErB,iBAAiB;YAmDjB,SAAS;YA+BT,yBAAyB;YAyCzB,cAAc;YAUd,WAAW;YA+BX,mBAAmB;IAQjC,OAAO,CAAC,kBAAkB;IAO1B,OAAO,CAAC,qBAAqB;IAO7B,OAAO,CAAC,wBAAwB;IAYhC,OAAO,CAAC,kBAAkB;IAQ1B,OAAO,CAAC,wBAAwB;YAalB,uBAAuB;YAkDvB,8BAA8B;IA2FtC,WAAW,CAAC,OAAO,EAAE,iBAAiB,GAAG,OAAO,CAAC,gBAAgB,CAAC;IAmrCxE,OAAO,CAAC,eAAe;CAMxB"}

package/dist/services/review/CodeReviewService.js

@@ -13,7 +13,7 @@ import yaml from "yaml";
 import { createTaskKeyGenerator } from "../planning/KeyHelpers.js";
 import { RoutingService } from "../agents/RoutingService.js";
 import { AgentRatingService } from "../agents/AgentRatingService.js";
-import { isDocContextExcluded, loadProjectGuidance, normalizeDocType } from "../shared/ProjectGuidance.js";
+import { ensureProjectGuidance, isDocContextExcluded, loadProjectGuidance, normalizeDocType, } from "../shared/ProjectGuidance.js";
 import { buildDocdexUsageGuidance } from "../shared/DocdexGuidance.js";
 import { createTaskCommentSlug, formatTaskCommentBody } from "../tasks/TaskCommentFormatter.js";
 import { AUTH_ERROR_REASON, isAuthErrorMessage } from "../shared/AuthErrors.js";
@@ -93,6 +93,34 @@ const filterOpenApiContext = (entries, hasOpenApiSnippet) => {
     }
     return filtered;
 };
+const normalizeExecutionContextPolicy = (value) => {
+    const normalized = (value ?? "").trim().toLowerCase();
+    if (normalized === "require_any" || normalized === "require_sds_or_openapi") {
+        return normalized;
+    }
+    return "best_effort";
+};
+const normalizeEmptyDiffApprovalPolicy = (value, fallback = "complete") => {
+    const normalized = (value ?? "").trim().toLowerCase();
+    if (normalized === "complete")
+        return "complete";
+    if (normalized === "ready_to_qa")
+        return "ready_to_qa";
+    return fallback;
+};
+const classifyReviewPlanningContextKind = (doc) => {
+    const docType = String(doc.docType ?? "").toUpperCase();
+    if (docType === "SDS")
+        return "sds";
+    if (docType === "OPENAPI")
+        return "openapi";
+    const ref = String(doc.path ?? doc.title ?? "").toLowerCase();
+    if (/docs\/sds|\/sds\.md$|(^|\/)sds\.md$/.test(ref))
+        return "sds";
+    if (/openapi|swagger|(^|\/)openapi\.ya?ml$/.test(ref))
+        return "openapi";
+    return "doc";
+};
 const estimateTokens = (text) => Math.max(1, Math.ceil((text ?? "").length / 4));
 const summarizeComments = (comments) => {
     if (!comments.length)
@@ -507,6 +535,63 @@ export class CodeReviewService {
             return undefined;
         return Math.min(10, Math.max(1, Math.round(candidate)));
     }
+    enforceExecutionContextPolicy(policy, context) {
+        if (policy === "best_effort")
+            return;
+        if (policy === "require_any") {
+            if (!context) {
+                throw new Error("Review context is required but no planning documents were resolved (policy=require_any).");
+            }
+            return;
+        }
+        if (!context) {
+            throw new Error("Review context requires SDS/OpenAPI sources, but none were resolved (policy=require_sds_or_openapi).");
+        }
+        if (context.kind !== "sds" && context.kind !== "openapi") {
+            throw new Error(`Review context policy require_sds_or_openapi rejected source '${context.source}' (kind=${context.kind}).`);
+        }
+    }
+    async resolveExecutionPlanningContext(projectKey, warnings) {
+        if (!projectKey)
+            return undefined;
+        const pickFirst = async (filter) => {
+            const docs = await this.deps.docdex.search({
+                profile: "workspace-code",
+                ...filter,
+            });
+            return docs[0];
+        };
+        try {
+            const sdsDoc = await pickFirst({ projectKey, docType: "SDS" });
+            if (sdsDoc) {
+                return {
+                    source: sdsDoc.id ?? sdsDoc.path ?? sdsDoc.title ?? "sds",
+                    kind: classifyReviewPlanningContextKind(sdsDoc),
+                };
+            }
+            const openapiDoc = await pickFirst({ projectKey, docType: "OPENAPI" });
+            if (openapiDoc) {
+                return {
+                    source: openapiDoc.id ?? openapiDoc.path ?? openapiDoc.title ?? "openapi",
+                    kind: classifyReviewPlanningContextKind(openapiDoc),
+                };
+            }
+            const fallbackDoc = await pickFirst({
+                projectKey,
+                query: "sds requirements architecture openapi swagger",
+            });
+            if (!fallbackDoc)
+                return undefined;
+            return {
+                source: fallbackDoc.id ?? fallbackDoc.path ?? fallbackDoc.title ?? "workspace-code",
+                kind: classifyReviewPlanningContextKind(fallbackDoc),
+            };
+        }
+        catch (error) {
+            warnings.push(`Review context preflight failed to query docdex: ${error.message}`);
+            return undefined;
+        }
+    }
     async selectTasksViaApi(filters) {
         // Prefer the backlog/task OpenAPI surface (via BacklogService) to mirror API filtering semantics.
         const backlog = await BacklogService.create(this.workspace);
@@ -570,7 +655,7 @@ export class CodeReviewService {
         }
         return Array.from(hints).slice(0, 8);
     }
-    async gatherDocContext(taskTitle, paths, acceptance, docLinks = []) {
+    async gatherDocContext(taskTitle, paths, acceptance, docLinks = [], projectKey) {
         const snippets = [];
         const warnings = [];
         if (typeof this.deps.docdex?.ensureRepoScope === "function") {
@@ -597,44 +682,74 @@ export class CodeReviewService {
             }
             return normalized.docType;
         };
-        for (const query of queries) {
+        const runSearch = async (filter, label) => {
             try {
-                const docs = await withTimeout(this.deps.docdex.search({
-                    query,
-                    profile: "workspace-code",
-                }), DOCDEX_TIMEOUT_MS, `docdex search for "${query}"`);
-                const filteredDocs = docs.filter((doc) => !isDocContextExcluded(doc.path ?? doc.title ?? doc.id, false));
-                snippets.push(...filteredDocs.slice(0, 2).map((doc) => {
-                    const content = (doc.segments?.[0]?.content ?? doc.content ?? "").slice(0, 400);
-                    const ref = doc.path ?? doc.id ?? doc.title ?? query;
-                    return `- [${resolveDocType(doc)}] ${ref}: ${content}`;
-                }));
+                return await withTimeout(this.deps.docdex.search(filter), DOCDEX_TIMEOUT_MS, label);
             }
             catch (error) {
                 if (!reindexed && typeof this.deps.docdex.reindex === "function") {
                     reindexed = true;
-                    try {
-                        await this.deps.docdex.reindex();
-                        const docs = await withTimeout(this.deps.docdex.search({
-                            query,
-                            profile: "workspace-code",
-                        }), DOCDEX_TIMEOUT_MS, `docdex search for "${query}" after reindex`);
-                        const filteredDocs = docs.filter((doc) => !isDocContextExcluded(doc.path ?? doc.title ?? doc.id, false));
-                        snippets.push(...filteredDocs.slice(0, 2).map((doc) => {
-                            const content = (doc.segments?.[0]?.content ?? doc.content ?? "").slice(0, 400);
-                            const ref = doc.path ?? doc.id ?? doc.title ?? query;
-                            return `- [${resolveDocType(doc)}] ${ref}: ${content}`;
-                        }));
-                        continue;
-                    }
-                    catch (retryError) {
-                        warnings.push(`docdex search failed after reindex for ${query}: ${retryError.message}`);
-                        continue;
-                    }
+                    await this.deps.docdex.reindex();
+                    return await withTimeout(this.deps.docdex.search(filter), DOCDEX_TIMEOUT_MS, `${label} after reindex`);
                 }
+                throw error;
+            }
+        };
+        const pushDocs = (docs, query) => {
+            const filteredDocs = docs.filter((doc) => !isDocContextExcluded(doc.path ?? doc.title ?? doc.id, false));
+            snippets.push(...filteredDocs.slice(0, 2).map((doc) => {
+                const content = (doc.segments?.[0]?.content ?? doc.content ?? "").slice(0, 400);
+                const ref = doc.path ?? doc.id ?? doc.title ?? query;
+                return `- [${resolveDocType(doc)}] ${ref}: ${content}`;
+            }));
+            return filteredDocs.length;
+        };
+        for (const query of queries) {
+            let structuredHits = 0;
+            try {
+                structuredHits += pushDocs(await runSearch({
+                    query,
+                    projectKey,
+                    docType: "SDS",
+                    profile: "workspace-code",
+                }, `docdex search for "${query}"`), query);
+            }
+            catch (error) {
+                warnings.push(`docdex search failed for SDS query ${query}: ${error.message}`);
+            }
+            try {
+                structuredHits += pushDocs(await runSearch({
+                    query,
+                    projectKey,
+                    docType: "OPENAPI",
+                    profile: "workspace-code",
+                }, `docdex search for "${query}"`), query);
+            }
+            catch (error) {
+                warnings.push(`docdex search failed for OPENAPI query ${query}: ${error.message}`);
+            }
+            if (structuredHits > 0) {
+                continue;
+            }
+            try {
+                pushDocs(await runSearch({
+                    query,
+                    projectKey,
+                    profile: "workspace-code",
+                }, `docdex search for "${query}"`), query);
+            }
+            catch (error) {
                 warnings.push(`docdex search failed for ${query}: ${error.message}`);
             }
         }
+        if (!snippets.length && projectKey) {
+            try {
+                pushDocs(await runSearch({ projectKey, query: "sds openapi requirements architecture", profile: "workspace-code" }, "docdex fallback search"), "fallback");
+            }
+            catch (error) {
+                warnings.push(`docdex fallback search failed: ${error.message}`);
+            }
+        }
         const normalizeDocLink = (value) => {
             const trimmed = value.trim();
             const stripped = trimmed.replace(/^docdex:/i, "").replace(/^doc:/i, "");
@@ -728,7 +843,7 @@ export class CodeReviewService {
     }
     async buildHistorySummary(taskId) {
         const comments = await this.deps.workspaceRepo.listTaskComments(taskId, {
-            sourceCommands: ["work-on-tasks", "code-review"],
+            sourceCommands: ["work-on-tasks", "code-review", "qa-tasks"],
             limit: 10,
         });
         const lastReview = await this.deps.workspaceRepo.getLatestTaskReview(taskId);
@@ -755,7 +870,7 @@ export class CodeReviewService {
     }
     async loadCommentContext(taskId) {
         const comments = await this.deps.workspaceRepo.listTaskComments(taskId, {
-            sourceCommands: ["code-review"],
+            sourceCommands: ["code-review", "qa-tasks"],
             limit: 50,
         });
         const unresolved = comments.filter((comment) => !comment.resolvedAt);
@@ -949,10 +1064,84 @@ export class CodeReviewService {
         }
         return Array.from(paths);
     }
-    async buildOpenApiSlice(changedPaths, acceptance) {
-        const openapiPath = path.join(this.workspace.workspaceRoot, "openapi", "mcoda.yaml");
+    async readOpenApiFileIfExists(targetPath) {
+        const absolutePath = path.isAbsolute(targetPath) ? targetPath : path.join(this.workspace.workspaceRoot, targetPath);
         try {
-            const content = await fs.readFile(openapiPath, "utf8");
+            const content = await fs.readFile(absolutePath, "utf8");
+            return { sourcePath: absolutePath, content };
+        }
+        catch {
+            return undefined;
+        }
+    }
+    async resolveOpenApiContent(task, projectKey) {
+        const metadata = task.metadata ?? {};
+        const metadataPath = (typeof metadata.openapi_path === "string" && metadata.openapi_path.trim()) ||
+            (typeof metadata.openapiPath === "string" && metadata.openapiPath.trim()) ||
+            undefined;
+        const configPath = (typeof this.workspace.config?.openapiPath === "string" && this.workspace.config.openapiPath.trim()) ||
+            (typeof this.workspace.config?.openapi === "string" && this.workspace.config.openapi.trim()) ||
+            undefined;
+        const docLinkPaths = Array.isArray(metadata.doc_links)
+            ? metadata.doc_links
+                .filter((entry) => typeof entry === "string")
+                .map((entry) => entry.replace(/^docdex:/i, "").replace(/^doc:/i, "").trim())
+                .filter((entry) => /\.(ya?ml|json)$/i.test(entry) && /openapi|swagger/i.test(entry))
+            : [];
+        const candidates = [
+            metadataPath,
+            configPath,
+            ...docLinkPaths,
+            "openapi/mcoda.yaml",
+            "openapi/openapi.yaml",
+            "openapi/openapi.yml",
+            "openapi.yaml",
+            "openapi.yml",
+            "docs/openapi.yaml",
+            "docs/openapi.yml",
+            "openapi/swagger.yaml",
+            "openapi/swagger.yml",
+        ].filter((entry) => Boolean(entry && entry.trim()));
+        const seen = new Set();
+        for (const candidate of candidates) {
+            if (seen.has(candidate))
+                continue;
+            seen.add(candidate);
+            const loaded = await this.readOpenApiFileIfExists(candidate);
+            if (loaded) {
+                return { source: loaded.sourcePath, content: loaded.content };
+            }
+        }
+        try {
+            const docs = await this.deps.docdex.search({
+                projectKey,
+                docType: "OPENAPI",
+                profile: "workspace-code",
+            });
+            for (const doc of docs) {
+                if (doc.path) {
+                    const loaded = await this.readOpenApiFileIfExists(doc.path);
+                    if (loaded) {
+                        return { source: loaded.sourcePath, content: loaded.content };
+                    }
+                }
+                const content = (doc.segments?.map((segment) => segment.content ?? "").join("\n") || doc.content || "").trim();
+                if (content.length > 0) {
+                    return { source: doc.path ?? doc.id ?? doc.title ?? "docdex:openapi", content };
+                }
+            }
+        }
+        catch {
+            // Best-effort fallback; no OpenAPI is acceptable for non-strict policies.
+        }
+        return undefined;
+    }
+    async buildOpenApiSlice(changedPaths, acceptance, task, projectKey) {
+        const resolved = await this.resolveOpenApiContent(task, projectKey);
+        if (!resolved)
+            return undefined;
+        try {
+            const content = resolved.content;
             const parsed = yaml.parse(content);
             const pathHints = this.componentHintsFromPaths(changedPaths);
             const criteriaHints = (acceptance ?? []).map((c) => c.toLowerCase()).slice(0, 5);
@@ -990,7 +1179,7 @@ export class CodeReviewService {
             return rendered.slice(0, 8000);
         }
         catch {
-            return undefined;
+            return resolved.content.slice(0, 4000);
         }
     }
     async buildDiff(task, baseRef, fileScope) {
@@ -1258,6 +1447,8 @@ export class CodeReviewService {
         await this.ensureMcoda();
         const agentStream = request.agentStream !== false;
         const baseRef = request.baseRef ?? this.workspace.config?.branch ?? DEFAULT_BASE_BRANCH;
+        let executionContextPolicy = normalizeExecutionContextPolicy(request.executionContextPolicy);
+        let emptyDiffApprovalPolicy = normalizeEmptyDiffApprovalPolicy(request.emptyDiffApprovalPolicy, "complete");
         const ignoreStatusFilter = Boolean(request.taskKeys?.length) || request.ignoreStatusFilter === true;
         const rawStatusFilter = ignoreStatusFilter
             ? []
@@ -1278,6 +1469,14 @@ export class CodeReviewService {
         if (rejected.length > 0 && !ignoreStatusFilter) {
             warnings.push(`code-review ignores unsupported statuses: ${rejected.join(", ")}. Allowed: ${REVIEW_ALLOWED_STATUSES.join(", ")}.`);
         }
+        const executionContext = await this.resolveExecutionPlanningContext(request.projectKey, warnings);
+        try {
+            this.enforceExecutionContextPolicy(executionContextPolicy, executionContext);
+        }
+        catch (error) {
+            await this.deps.jobService.finishCommandRun(commandRun.id, "failed", error instanceof Error ? error.message : String(error));
+            throw error;
+        }
         let allowFollowups = request.createFollowupTasks === true;
         let selectedTasks = [];
         if (request.resumeJobId) {
@@ -1358,6 +1557,9 @@ export class CodeReviewService {
                     agent: request.agentName,
                     agentStream,
                     createFollowupTasks: allowFollowups,
+                    executionContextPolicy,
+                    executionContext: executionContext ? { source: executionContext.source, kind: executionContext.kind } : undefined,
+                    emptyDiffApprovalPolicy,
                 },
                 totalItems: selectedTaskIds.length,
                 processedItems: 0,
@@ -1425,9 +1627,26 @@ export class CodeReviewService {
         }
         const prompts = await this.loadPrompts(agent.id);
         const extras = await this.loadRunbookAndChecklists();
-        const projectGuidance = await loadProjectGuidance(this.workspace.workspaceRoot, this.workspace.mcodaDir);
+        try {
+            const ensuredGuidance = await ensureProjectGuidance(this.workspace.workspaceRoot, {
+                mcodaDir: this.workspace.mcodaDir,
+                projectKey: request.projectKey,
+            });
+            for (const warning of ensuredGuidance.warnings ?? []) {
+                warnings.push(`project_guidance_warning:${warning}`);
+            }
+        }
+        catch (error) {
+            warnings.push(`project_guidance_bootstrap_failed:${error instanceof Error ? error.message : String(error)}`);
+        }
+        const projectGuidance = await loadProjectGuidance(this.workspace.workspaceRoot, this.workspace.mcodaDir, {
+            projectKey: request.projectKey,
+        });
         if (projectGuidance) {
             console.info(`[code-review] loaded project guidance from ${projectGuidance.source}`);
+            for (const warning of projectGuidance.warnings ?? []) {
+                warnings.push(`project_guidance_warning:${warning}`);
+            }
         }
         const guidanceBlock = projectGuidance?.content ? `Project Guidance (read first):\n${projectGuidance.content}` : undefined;
         const systemPrompts = [guidanceBlock, prompts.jobPrompt, prompts.characterPrompt, prompts.commandPrompt, ...extras].filter(Boolean);
@@ -1685,7 +1904,7 @@ export class CodeReviewService {
                 });
                 const changedPaths = this.extractPathsFromDiff(diff);
                 const diffMeta = { diffEmpty, changedPaths };
-                const docLinks = await this.gatherDocContext(task.title, changedPaths.length ? changedPaths : allowedFiles, task.acceptanceCriteria, Array.isArray(task.metadata?.doc_links) ? task.metadata.doc_links : []);
+                const docLinks = await this.gatherDocContext(task.title, changedPaths.length ? changedPaths : allowedFiles, task.acceptanceCriteria, Array.isArray(task.metadata?.doc_links) ? task.metadata.doc_links : [], request.projectKey);
                 if (docLinks.warnings.length)
                     warnings.push(...docLinks.warnings);
                 await this.deps.workspaceRepo.insertTaskLog({
@@ -1696,7 +1915,7 @@ export class CodeReviewService {
                     message: "Docdex context gathered",
                     details: { snippets: docLinks.snippets },
                 });
-                const openapiSnippet = await this.buildOpenApiSlice(changedPaths, task.acceptanceCriteria);
+                const openapiSnippet = await this.buildOpenApiSlice(changedPaths, task.acceptanceCriteria, task, request.projectKey);
                 if (!openapiSnippet) {
                     warnings.push("OpenAPI spec not found; proceeding without snippet");
                 }
@@ -2140,7 +2359,7 @@ export class CodeReviewService {
                 if (!request.dryRun) {
                     const approveDecision = parsed.decision === "approve" || parsed.decision === "info_only";
                     if (approveDecision) {
-                        if (diffEmpty) {
+                        if (diffEmpty && emptyDiffApprovalPolicy === "complete") {
                             await this.stateService.markCompleted(task, { review_no_changes: true }, statusContext);
                             taskStatusUpdate = "completed";
                         }