@mccaskie-labs/workbench-config 0.1.33 → 0.1.35

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # @mccaskie-labs/workbench-config
 
+## 0.1.35
+
+### Patch Changes
+
+- Skills: a must-ask table question (such as a choice's options) is asked on its own with "These are right", "Change some" or "Add or remove", and no recommended answer, so the client never accepts made-up options inside another question's "Accept all".
+
+## 0.1.34
+
+### Patch Changes
+
+- forms manifest: the same-verdict rule now says to draw a form with renderForm and add both scripts under the page nonce, never hand-written markup or a show-when script.
+
 ## 0.1.33
 
 ### Patch Changes

package/capabilities/forms.json

@@ -39,7 +39,7 @@
     {
       "id": "forms.same-verdict",
       "kind": "must",
-      "text": "Put the form on the page with embedConfig and FORMS_SCRIPT, never a second set of rules, so the page and the endpoint reach the same verdict.",
+      "text": "Draw the form with renderForm (its config block included), then add FORMS_SCRIPT and workbench-ui's FORM_SCRIPT, in that order, under the page's nonce. Never hand-write a form's markup, a second set of rules or a show-when script, so the page and the endpoint reach the same verdict.",
       "enforced_by": "review",
       "probe": "forms.browser"
     },

package/dist/capabilities.gen.d.ts

@@ -1,4 +1,4 @@
-export declare const MANIFEST_VERSION: "9b550a478838";
+export declare const MANIFEST_VERSION: "d5366f2127fb";
 export declare const capabilities: {
     readonly ai: {
         readonly $schema: "./schema.json";
@@ -1105,7 +1105,7 @@ export declare const capabilities: {
         }, {
             readonly id: "forms.same-verdict";
             readonly kind: "must";
-            readonly text: "Put the form on the page with embedConfig and FORMS_SCRIPT, never a second set of rules, so the page and the endpoint reach the same verdict.";
+            readonly text: "Draw the form with renderForm (its config block included), then add FORMS_SCRIPT and workbench-ui's FORM_SCRIPT, in that order, under the page's nonce. Never hand-write a form's markup, a second set of rules or a show-when script, so the page and the endpoint reach the same verdict.";
             readonly enforced_by: "review";
             readonly probe: "forms.browser";
         }, {

package/dist/capabilities.gen.js

@@ -1,6 +1,6 @@
 // Generated by `npm run capabilities:build` from capabilities/*.json. Do not edit.
 // check:capabilities fails in Checks when this file is stale.
-export const MANIFEST_VERSION = "9b550a478838";
+export const MANIFEST_VERSION = "d5366f2127fb";
 export const capabilities = {
     "ai": {
         "$schema": "./schema.json",
@@ -1518,7 +1518,7 @@ export const capabilities = {
             {
                 "id": "forms.same-verdict",
                 "kind": "must",
-                "text": "Put the form on the page with embedConfig and FORMS_SCRIPT, never a second set of rules, so the page and the endpoint reach the same verdict.",
+                "text": "Draw the form with renderForm (its config block included), then add FORMS_SCRIPT and workbench-ui's FORM_SCRIPT, in that order, under the page's nonce. Never hand-write a form's markup, a second set of rules or a show-when script, so the page and the endpoint reach the same verdict.",
                 "enforced_by": "review",
                 "probe": "forms.browser"
             },

package/dist/skills.js

@@ -26,7 +26,11 @@ function questionBlock(q, n) {
     if (q.must_ask)
         lines.push("**Must ask:** there is no safe default, so always ask it, even when the client accepts every recommendation.");
     lines.push("");
-    if (q.style === "table") {
+    if (q.style === "table" && q.must_ask) {
+        // No safe default means no recommended answer: the client confirms what only they know, on its own.
+        lines.push("Ask it on its own, never folded into another question's \"Accept all\": propose a value for each row as a starting point, show the table, then ask \"Are these right?\" with the answers \"These are right\", \"Change some\" and \"Add or remove\". None of them is recommended.");
+    }
+    else if (q.style === "table") {
         lines.push("Ask as a table: propose a value for each row, show the table, then ask one question with the answers \"Accept all (Recommended)\", \"Change some\" and \"Add or remove\".");
     }
     else {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mccaskie-labs/workbench-config",
-  "version": "0.1.33",
+  "version": "0.1.35",
   "description": "Workbench app configuration: WORKBENCH_ENV, typed variables that fail by name, secrets that are never printed, and the capabilities manifest.",
   "license": "UNLICENSED",
   "type": "module",