@maycombhq/atticus 2.0.0-beta.21 → 2.0.0-beta.23

package/dist/{chunk-K332XW7K.js → chunk-D6BVLTDV.js}

@@ -15,25 +15,25 @@ import {
   outsideKindOf,
   outsideSystemsOf,
   phaseGates,
-  statePhase
-} from "./chunk-HSZMPH5T.js";
+  statePhase,
+  wroteThis
+} from "./chunk-WZYM5M4U.js";
 import {
   daysBetween,
   knowledgeGaps,
   newestEvidence
-} from "./chunk-64AADMTW.js";
+} from "./chunk-4GAB5ZOZ.js";
 import {
   BREAKING_SPEC,
   INSTRUCTION_RULES,
   PERSONAL_DATA_SPEC,
   buildContextPack,
-  estimateTokens,
   personalItem,
   quarantineItems,
   screenText,
   settle,
   toRunSummary
-} from "./chunk-QHJJMZLX.js";
+} from "./chunk-3424TLIJ.js";
 import {
   ASKED_GAP_STEP,
   AgentDefinition,
@@ -59,6 +59,7 @@ import {
   callsOfQuestion,
   changesDirOf,
   changesRelOf,
+  estimateTokens,
   external_exports,
   fileJudgments,
   findingPath,
@@ -77,15 +78,17 @@ import {
   quotedIn,
   readQuestion,
   repoReadOf,
-  require_dist,
   runsDirOf,
   stateDirOf,
   toCanonicalYaml,
   writeQuestion
-} from "./chunk-PAINMSID.js";
+} from "./chunk-FPBUTZI5.js";
 import {
   writeFileAtomic
-} from "./chunk-ODMBPDDV.js";
+} from "./chunk-B4AEL3RF.js";
+import {
+  require_dist
+} from "./chunk-BQGDB6ZL.js";
 import {
   __toESM
 } from "./chunk-TV45EUGM.js";
@@ -1415,7 +1418,7 @@ var interfaceEndsInCatalog = {
         ["caller", h.caller],
         ["callee", h.callee]
       ]) {
-        if (!end || ctx.isKnown(end))
+        if (!end || ctx.isKnown(end) || ctx.planned.get(end) === "new")
           continue;
         hits.push({
           kind: "issue",
@@ -3010,6 +3013,46 @@ function layerRules(sources) {
 var layerRank = (l) => LAYER_RANK[l];
 var severityRank = (s) => SEVERITY_RANK[s];
 
+// packages/naysayer/dist/planned.js
+var import_yaml4 = __toESM(require_dist(), 1);
+function plannedInChange(files, known) {
+  const out = /* @__PURE__ */ new Map();
+  const isId = (s) => typeof s === "string" && /^[a-z0-9][a-z0-9._-]*$/.test(s);
+  for (const doc of files.flows ?? []) {
+    let d;
+    try {
+      d = (0, import_yaml4.parse)(doc.raw);
+    } catch {
+      continue;
+    }
+    if (!d || typeof d !== "object")
+      continue;
+    const x = d;
+    const c = x.runsOn?.component;
+    if (x.change === "new" && isId(c) && !known(c))
+      out.set(c, "new");
+    for (const s of Array.isArray(x.steps) ? x.steps : []) {
+      const to = s?.to?.component;
+      if (s?.op !== "remove" && s?.to?.new === true && isId(to) && !known(to) && !out.has(to))
+        out.set(to, "new");
+    }
+    const retired = typeof x.why === "string" ? /^Retires (\S+?):/.exec(x.why)?.[1] : void 0;
+    if (x.change === "remove" && isId(retired))
+      out.set(retired, "retire");
+  }
+  const proposal = files.docs.get("proposal.md")?.raw ?? "";
+  for (const m of proposal.matchAll(/^\|\s*`?([a-z0-9][\w.-]*)`?\s*\|\s*new\b/gim))
+    if (!known(m[1]) && !out.has(m[1]))
+      out.set(m[1], "new");
+  return out;
+}
+function plannedText(planned) {
+  return [
+    "Components this change plans, from its own target flows and proposal. They are planned in this change, not missing from the catalog: the catalog has them once their code lands and is read.",
+    ...[...planned].sort(([a], [b]) => a.localeCompare(b)).map(([id, a]) => `- ${id}: ${a === "new" ? "new in this change" : "retired by this change"}`)
+  ].join("\n");
+}
+
 // packages/naysayer/dist/context.js
 function buildContext(o) {
   const { lifecycle } = o;
@@ -3045,6 +3088,7 @@ function buildContext(o) {
     "confidential",
     "restricted"
   ];
+  const isKnown = (id) => get("Component", id) !== void 0 || get("System", id) !== void 0 || profileSystems.has(id) || endpointOwners.has(id);
   return {
     root: o.root,
     change: o.change,
@@ -3066,7 +3110,8 @@ function buildContext(o) {
     boundaryOf: (s) => get("System", s)?.boundary ?? profileSystems.get(s)?.boundary,
     outsideOf: (s) => outsideKindOf(outside, s, get("System", s)?.boundary ?? profileSystems.get(s)?.boundary),
     ownerOf: (s) => profileSystems.get(s)?.owner ?? get("System", s)?.owner,
-    isKnown: (id) => get("Component", id) !== void 0 || get("System", id) !== void 0 || profileSystems.has(id) || endpointOwners.has(id),
+    isKnown,
+    planned: plannedInChange(o.files, isKnown),
     namesOf: (id) => {
       const names = /* @__PURE__ */ new Set([id, id.replace(/-/g, " ")]);
       const sys = get("System", id) ?? void 0;
@@ -3236,12 +3281,12 @@ function evaluateNeeds(ctx, rule, examined) {
 }
 
 // packages/naysayer/dist/findings.js
-var import_yaml6 = __toESM(require_dist(), 1);
+var import_yaml7 = __toESM(require_dist(), 1);
 import { readdir as readdir4, readFile as readFile5 } from "node:fs/promises";
 import { join as join5 } from "node:path";
 
 // packages/naysayer/dist/answers.js
-var import_yaml4 = __toESM(require_dist(), 1);
+var import_yaml5 = __toESM(require_dist(), 1);
 import { readdir as readdir3, readFile as readFile3 } from "node:fs/promises";
 import { join as join3 } from "node:path";
 async function changeAnswers(root, change) {
@@ -3251,7 +3296,7 @@ async function changeAnswers(root, change) {
     if (!f.endsWith(".yaml"))
       continue;
     try {
-      const data = (0, import_yaml4.parse)(await readFile3(join3(stageDir, f), "utf8"));
+      const data = (0, import_yaml5.parse)(await readFile3(join3(stageDir, f), "utf8"));
       if (Array.isArray(data?.questions)) {
         for (const q of data.questions)
           if (typeof q === "string")
@@ -3333,7 +3378,7 @@ function recordedText(facts) {
 }
 
 // packages/naysayer/dist/proposals.js
-var import_yaml5 = __toESM(require_dist(), 1);
+var import_yaml6 = __toESM(require_dist(), 1);
 import { readFile as readFile4 } from "node:fs/promises";
 import { join as join4 } from "node:path";
 var Proposal = external_exports.strictObject({
@@ -3364,7 +3409,7 @@ async function readProposals(root, change, gate, round) {
   const text = await readFile4(fileOf(root, change, gate, round), "utf8").catch(() => void 0);
   if (text === void 0)
     return [];
-  const r = ProposalsFile.safeParse((0, import_yaml5.parse)(text));
+  const r = ProposalsFile.safeParse((0, import_yaml6.parse)(text));
   return r.success ? r.data.proposals : [];
 }
 async function writeProposals(root, change, gate, round, proposals) {
@@ -3564,7 +3609,8 @@ async function roundsOf(root, change, gate) {
 async function countedRounds(root, change, gate) {
   const out = [];
   for (const n of await roundsOf(root, change, gate)) {
-    const m = await readRoundMeta(root, change, gate, n);
+    const m0 = await readRoundMeta(root, change, gate, n);
+    const m = m0?.state === "in-progress" ? void 0 : m0;
     if (!m) {
       const r = await readRound(root, change, gate, n);
       if (!r.findings.length && !r.bad.length)
@@ -3633,7 +3679,7 @@ async function reviewedGates(root, change) {
 async function readRoundMeta(root, change, gate, round) {
   try {
     const text = await readFile5(join5(changeFolder(root, change), "review", gate, String(round), "meta", "round.yaml"), "utf8");
-    const m = (0, import_yaml6.parse)(text);
+    const m = (0, import_yaml7.parse)(text);
     if (!m || typeof m !== "object")
       return void 0;
     return {
@@ -3661,7 +3707,7 @@ async function readRound(root, change, gate, round) {
     const rel = `review/${gate}/${round}/${f}`;
     let data;
     try {
-      data = (0, import_yaml6.parse)(await readFile5(join5(dir, f), "utf8"));
+      data = (0, import_yaml7.parse)(await readFile5(join5(dir, f), "utf8"));
     } catch (e) {
       bad.push({ path: rel, message: `invalid YAML: ${e.message.split("\n")[0]}` });
       continue;
@@ -3726,7 +3772,7 @@ function criticModel(runtime, authorModel) {
 }
 
 // packages/naysayer/dist/ai.js
-var import_yaml7 = __toESM(require_dist(), 1);
+var import_yaml8 = __toESM(require_dist(), 1);
 
 // packages/naysayer/dist/code.js
 import { existsSync, readdirSync } from "node:fs";
@@ -4483,7 +4529,7 @@ function wordFor(line, quote) {
 function lensFindings(output) {
   let data;
   try {
-    data = (0, import_yaml7.parse)(output.replace(/^```(?:ya?ml)?\s*\n|\n```\s*$/g, ""));
+    data = (0, import_yaml8.parse)(output.replace(/^```(?:ya?ml)?\s*\n|\n```\s*$/g, ""));
   } catch (e) {
     return { problem: `the output is not YAML: ${e.message.split("\n")[0]}` };
   }
@@ -4814,6 +4860,15 @@ async function runLenses(ctx, rules, o) {
         classification: "internal",
         priority: 5
       });
+    if (ctx.planned.size)
+      estate.push({
+        id: "planned-in-change",
+        kind: "catalog",
+        origin: "the change's target flows and proposal",
+        text: plannedText(ctx.planned),
+        classification: "internal",
+        priority: 6
+      });
     if (ctx.answers?.length)
       sources.push({
         id: "answers-on-file",
@@ -5360,6 +5415,15 @@ async function runCritic(root, changeId, opts = {}) {
     problems.push(`Rule ${h.rule.id} produced a finding without evidence; it was discarded: ${h.hit.summary}`);
   const merged1 = mergeHits(l1.filter((h) => h.hit.evidence.length > 0), ctx.systemOf);
   const failed = new Set(merged1.filter((h) => h.hit.kind === "issue" && h.rule.severity === "blocking" && h.hit.artifact !== "catalog").map((h) => h.hit.artifact));
+  const metaDir = join10(changeFolder(root, change.id), "review", gate.id, String(round), "meta");
+  await writeFileAtomic(join10(metaDir, "round.yaml"), toCanonicalYaml({
+    schemaVersion: 1,
+    change: change.id,
+    gate: gate.id,
+    round,
+    createdAt: now,
+    state: "in-progress"
+  }, ROUND_LEADING));
   const lenses = opts.lenses ? questionsOf(opts.lenses) : [...CriticQuestion.options];
   const quarantined = [];
   const draft = opts.review ? await draftDocs(changeFolder(root, change.id), opts.review.files) : [];
@@ -5444,7 +5508,6 @@ async function runCritic(root, changeId, opts = {}) {
   ];
   await keepLensRecords(root, change.id, gate.id, round, ai.runs);
   const model = criticModel(lifecycle.orgPack.runtime, opts.authorModel);
-  const metaDir = join10(changeFolder(root, change.id), "review", gate.id, String(round), "meta");
   for (const r of ai.runs)
     if (r.summary)
       await writeFileAtomic(join10(metaDir, "runs", `${r.agent}.yaml`), toCanonicalYaml(r.summary, ["schemaVersion", "runId"]));
@@ -5661,10 +5724,9 @@ async function failLens(root, change, gate, round, runId, reason) {
 }
 
 // packages/naysayer/dist/act.js
-import { createHash } from "node:crypto";
 import { readdir as readdir7, readFile as readFile8 } from "node:fs/promises";
 import { join as join12, normalize, sep as sep2 } from "node:path";
-var import_yaml8 = __toESM(require_dist(), 1);
+var import_yaml9 = __toESM(require_dist(), 1);
 async function raiseAskedQuestion(root, f, askedOf, at) {
   const id = askedGapQuestionId(f.change, f);
   if (await readQuestion(root, id).catch(() => void 0))
@@ -5898,7 +5960,7 @@ async function renderedFrom(folder) {
   for (const s of stages.filter((x) => x.endsWith(".yaml")).sort()) {
     let loop;
     try {
-      loop = (0, import_yaml8.parse)(await readFile8(join12(folder, "stage", s), "utf8"));
+      loop = (0, import_yaml9.parse)(await readFile8(join12(folder, "stage", s), "utf8"));
     } catch {
       continue;
     }
@@ -5919,25 +5981,28 @@ function renderedRefusal(change, file, from) {
   return `${file} is written by the ${from.stage} stage from ${from.source}, so a fix there is lost the next time the stage writes it. Make the fix in ${from.source}, run ${stageRun(from.stage, change)} (it checks your edit as the stage's draft and writes ${file} again), then record it here with edit-and-apply --reason "<what you changed>".`;
 }
 async function editedByPerson(folder) {
-  const out = /* @__PURE__ */ new Set();
+  const byFile = /* @__PURE__ */ new Map();
   const stages = await readdir7(join12(folder, "stage")).catch(() => []);
   for (const s of stages.filter((x) => x.endsWith(".yaml")).sort()) {
     let written;
     try {
-      written = (0, import_yaml8.parse)(await readFile8(join12(folder, "stage", s), "utf8"))?.written;
+      written = (0, import_yaml9.parse)(await readFile8(join12(folder, "stage", s), "utf8"))?.written;
     } catch {
       continue;
     }
     if (!written || typeof written !== "object")
       continue;
-    for (const [file, hash] of Object.entries(written)) {
-      const now = await readFile8(join12(folder, ...file.split("/")), "utf8").catch(() => void 0);
-      const h = now !== void 0 ? createHash("sha256").update(now.replace(/\r\n?/g, "\n"), "utf8").digest("hex") : void 0;
-      if (h !== hash)
-        out.add(file);
-    }
+    for (const [file, hash] of Object.entries(written))
+      if (typeof hash === "string")
+        byFile.set(file, [...byFile.get(file) ?? [], hash]);
   }
-  return [...out].sort();
+  const out = [];
+  for (const [file, hashes] of byFile) {
+    const now = await readFile8(join12(folder, ...file.split("/")), "utf8").catch(() => void 0);
+    if (now === void 0 || !hashes.some((h) => wroteThis(file, now, h)))
+      out.push(file);
+  }
+  return out.sort();
 }
 
 // packages/naysayer/dist/stats.js
@@ -6145,6 +6210,8 @@ export {
   layerRules,
   layerRank,
   severityRank,
+  plannedInChange,
+  plannedText,
   buildContext,
   evaluateNeeds,
   changeAnswers,

package/dist/chunk-DCRYOMTM.js

@@ -0,0 +1,37 @@
+import { createRequire as __atticusCreateRequire } from "node:module";
+import { fileURLToPath as __atticusFileURLToPath } from "node:url";
+var require = __atticusCreateRequire(import.meta.url);
+var __atticusUrl = (p) => new URL("./" + p, import.meta.url).href;
+var __atticusPath = (p) => __atticusFileURLToPath(__atticusUrl(p));
+import {
+  RepoEditError,
+  branchCatalogFolder,
+  compareBranch,
+  editRepoBranches,
+  editRepoBuild,
+  editRepoDescription,
+  repoBranches
+} from "./chunk-BP33TBLI.js";
+import "./chunk-IKAW2KJU.js";
+import "./chunk-CZ2ZS7AT.js";
+import "./chunk-4GAB5ZOZ.js";
+import "./chunk-A4JXVO5O.js";
+import "./chunk-TDSCKP3V.js";
+import "./chunk-G6EFXTUO.js";
+import "./chunk-PQQKZPBU.js";
+import "./chunk-3EWKO457.js";
+import "./chunk-3424TLIJ.js";
+import "./chunk-QA4O2GGC.js";
+import "./chunk-FPBUTZI5.js";
+import "./chunk-B4AEL3RF.js";
+import "./chunk-BQGDB6ZL.js";
+import "./chunk-TV45EUGM.js";
+export {
+  RepoEditError,
+  branchCatalogFolder,
+  compareBranch,
+  editRepoBranches,
+  editRepoBuild,
+  editRepoDescription,
+  repoBranches
+};

package/dist/{chunk-G6X4YL4D.js → chunk-DHKDH464.js}

@@ -78,10 +78,11 @@ import {
   writeAssistantFiles,
   writeProbe,
   zeroInstallCommands
-} from "./chunk-3AQ2R5NL.js";
-import "./chunk-XOL3GFW2.js";
-import "./chunk-PAINMSID.js";
-import "./chunk-ODMBPDDV.js";
+} from "./chunk-J4CPHJUL.js";
+import "./chunk-3EWKO457.js";
+import "./chunk-FPBUTZI5.js";
+import "./chunk-B4AEL3RF.js";
+import "./chunk-BQGDB6ZL.js";
 import "./chunk-TV45EUGM.js";
 export {
   ABOUT_RULE,

package/dist/{chunk-JRVNXLZP.js → chunk-DSHRA72L.js}

@@ -7,28 +7,28 @@ import {
   acpStepRunner,
   copilotAcpAllowed,
   copilotAcpByDefault
-} from "./chunk-LIJJCBQI.js";
+} from "./chunk-66AQ2JIU.js";
 import {
   REF
-} from "./chunk-OKUB6RJA.js";
+} from "./chunk-TXNSQ24G.js";
 import {
   originOf
-} from "./chunk-THN26IEF.js";
+} from "./chunk-PXW2RZGQ.js";
 import {
   effectiveRules,
   exampleOf,
   ruleMatches,
   rulesDirOf
-} from "./chunk-GIFMBCTW.js";
+} from "./chunk-ZLQEQR3D.js";
 import {
   checkoutOf
-} from "./chunk-Q46QDDMF.js";
+} from "./chunk-73GFVW2L.js";
 import {
   estateRepos
-} from "./chunk-4SLBCEPD.js";
+} from "./chunk-IKAW2KJU.js";
 import {
   AcpSignInError
-} from "./chunk-QHJJMZLX.js";
+} from "./chunk-3424TLIJ.js";
 import {
   ReadingRule,
   ReadingRulesFile,
@@ -41,14 +41,16 @@ import {
   loadOrgPack,
   orgPackDirOf,
   parseCorrections,
-  parseFacts,
-  require_dist
-} from "./chunk-PAINMSID.js";
+  parseFacts
+} from "./chunk-FPBUTZI5.js";
 import {
   FileChangedError,
   writeFileAtomic,
   writeFileIfUnchanged
-} from "./chunk-ODMBPDDV.js";
+} from "./chunk-B4AEL3RF.js";
+import {
+  require_dist
+} from "./chunk-BQGDB6ZL.js";
 import {
   __toESM
 } from "./chunk-TV45EUGM.js";
@@ -460,7 +462,7 @@ async function rulesTryCommand(root, repo, o, io) {
   };
   if (o.compare)
     return show();
-  const { listFiles } = await import("./chunk-4CYTJ5TZ.js");
+  const { listFiles } = await import("./chunk-UALE35WK.js");
   const files = (await listFiles(dir)).filter((p) => ruleMatches(rule, p)).slice(0, o.files ?? 5);
   if (!files.length) {
     io.err(`No file of ${repo} is one ${rule.key} names (${(rule.files ?? []).join(", ")}).`);