@maycombhq/atticus 2.0.0-beta.18 → 2.0.0-beta.21

package/dist/{chunk-AZYBHPV4.js → chunk-GX74YWR7.js}

@@ -3,15 +3,15 @@ import { fileURLToPath as __atticusFileURLToPath } from "node:url";
 var require = __atticusCreateRequire(import.meta.url);
 var __atticusUrl = (p) => new URL("./" + p, import.meta.url).href;
 var __atticusPath = (p) => __atticusFileURLToPath(__atticusUrl(p));
-import {
-  intakeContext
-} from "./chunk-NGT5LLSE.js";
 import {
   headCommitOf
-} from "./chunk-U6EPS5PF.js";
+} from "./chunk-G6IQYM25.js";
 import {
   denyHashesAt
-} from "./chunk-RUOGHYSK.js";
+} from "./chunk-LPV6T362.js";
+import {
+  intakeContext
+} from "./chunk-TQ4TG57V.js";
 import {
   componentRenames,
   estateFacts,
@@ -19,22 +19,22 @@ import {
   hostAliases,
   joinReposOf,
   outsideProfileSystems
-} from "./chunk-EZBAS5BL.js";
+} from "./chunk-4SLBCEPD.js";
 import {
   sameCommit
-} from "./chunk-IPSFMTK2.js";
+} from "./chunk-JYMIB5XY.js";
 import {
   openApiContractSpecs,
   readContractSpecs,
   readRepoSpecs,
   readVendorSpec
-} from "./chunk-TNCROWPQ.js";
+} from "./chunk-CPK7QSBG.js";
 import {
   VERSION
-} from "./chunk-S5PSGAQ2.js";
+} from "./chunk-VUVGX5L2.js";
 import {
   createGit
-} from "./chunk-ZQC7MNQB.js";
+} from "./chunk-XOL3GFW2.js";
 import {
   SpecsFile,
   catalogDirOf,
@@ -48,10 +48,10 @@ import {
   orgPackDirOf,
   questionsDirOf,
   require_dist
-} from "./chunk-YK6CSODO.js";
+} from "./chunk-PAINMSID.js";
 import {
   writeFileAtomic
-} from "./chunk-MMB2OHUY.js";
+} from "./chunk-ODMBPDDV.js";
 import {
   __toESM
 } from "./chunk-TV45EUGM.js";
@@ -223,7 +223,7 @@ async function estateJoinOnFile(root, op, estate, stamp) {
   if (hit)
     return hit;
   await breathe();
-  const join2 = estateJoinOf(op, estate.repos, estate.targets);
+  const join2 = estateJoinOf(op, estate.repos, estate.targets, estate.pairs, estate.aiTargets);
   await writeCached(root, "estate-join", at, join2);
   return join2;
 }
@@ -315,6 +315,7 @@ async function workOutContractCheck(root, stamp) {
 
 export {
   writeRepoSpecs,
+  stampOf,
   estateJoinOnFile,
   contractCheckOf
 };

package/dist/{chunk-YY7VP7KW.js → chunk-HE3HRDNZ.js}

@@ -7,7 +7,7 @@ import {
   estateRepos,
   joinReposOf,
   outsideSystems
-} from "./chunk-EZBAS5BL.js";
+} from "./chunk-4SLBCEPD.js";
 import {
   factIdPart,
   factsDirOf,
@@ -16,7 +16,7 @@ import {
   loadOrgPack,
   orgPackDirOf,
   parseFacts
-} from "./chunk-YK6CSODO.js";
+} from "./chunk-PAINMSID.js";
 
 // packages/cli/dist/onboarding-queue.js
 import { readFile } from "node:fs/promises";

package/dist/{chunk-Z7HYYDZM.js → chunk-HGHRSF3E.js}

@@ -3,20 +3,20 @@ import { fileURLToPath as __atticusFileURLToPath } from "node:url";
 var require = __atticusCreateRequire(import.meta.url);
 var __atticusUrl = (p) => new URL("./" + p, import.meta.url).href;
 var __atticusPath = (p) => __atticusFileURLToPath(__atticusUrl(p));
+import {
+  upgradeCheck
+} from "./chunk-4B6BT75O.js";
 import {
   isMetarepo,
   notMetarepo
 } from "./chunk-3G4YI4ZU.js";
-import {
-  upgradeCheck
-} from "./chunk-MFUFB3LN.js";
 import {
   ASSISTANT_FORMATS,
   assistantTier,
   generateAssistantFiles,
   readProbes,
   tierLine
-} from "./chunk-BAXM3JFQ.js";
+} from "./chunk-3AQ2R5NL.js";
 import {
   BETA_FEATURES,
   OPENSPEC_PINNED,
@@ -26,22 +26,22 @@ import {
   openspecFeatures,
   openspecHasStores,
   readStoreMarker
-} from "./chunk-43E6XX67.js";
+} from "./chunk-D2WSW4GU.js";
 import {
   versionAtLeast
-} from "./chunk-S5PSGAQ2.js";
+} from "./chunk-VUVGX5L2.js";
 import {
   baseClonePath,
   createGit,
   isInPlace,
   loadRepos,
   remoteDefaultBranch
-} from "./chunk-ZQC7MNQB.js";
+} from "./chunk-XOL3GFW2.js";
 import {
   modelEnvOf,
   modelSourceWords,
   modelsByClass
-} from "./chunk-QNMLLYTN.js";
+} from "./chunk-QHJJMZLX.js";
 import {
   DEFAULT_PORT,
   STEP_CLASSES,
@@ -53,10 +53,10 @@ import {
   require_dist,
   retrievalOf,
   stepModelsOf
-} from "./chunk-YK6CSODO.js";
+} from "./chunk-PAINMSID.js";
 import {
   readLock
-} from "./chunk-MMB2OHUY.js";
+} from "./chunk-ODMBPDDV.js";
 import {
   __toESM
 } from "./chunk-TV45EUGM.js";
@@ -127,7 +127,7 @@ async function defaultFreeBytes(dir) {
 }
 function defaultOnPath(env, platform) {
   const exts = platform === "win32" ? (env.PATHEXT ?? ".EXE;.CMD;.BAT").split(";") : [""];
-  const dirs = (env.PATH ?? env.Path ?? "").split(platform === "win32" ? ";" : delimiter);
+  const dirs = (env.PATH ?? env.Path ?? "").split(platform === "win32" ? ";" : delimiter).map((d) => d.trim().replace(/^"(.*)"$/, "$1"));
   return (program) => dirs.some((d) => d && exts.some((e) => existsSync(join(d, program + e.toLowerCase())) || existsSync(join(d, program + e))));
 }
 var envName = (env, ...names) => names.find((n) => env[n] !== void 0 && env[n] !== "");
@@ -429,7 +429,7 @@ async function doctorChecks(root, deps = {}) {
   });
   if (rt.ai !== "off" && rt.modes.allowed.includes("copilot-acp")) {
     const command = copilotAcpOf(rt).command;
-    const probe = deps.copilotAcp ?? (async (o) => (await import("./chunk-EEWBTFRP.js")).copilotAcpProbe(o));
+    const probe = deps.copilotAcp ?? (async (o) => (await import("./chunk-GCS3FZOB.js")).copilotAcpProbe(o));
     const p = await probe({ command, cwd: root }).catch((e) => ({
       found: false,
       said: e.message
@@ -476,7 +476,7 @@ async function doctorChecks(root, deps = {}) {
     });
   }
   const lexical = "the context engine searches by words and names only";
-  const embed = await (deps.embed ?? (() => import("./chunk-TX4OGZKU.js")))().catch((e) => e);
+  const embed = await (deps.embed ?? (() => import("./chunk-LO3BLMVG.js")))().catch((e) => e);
   if (embed instanceof Error) {
     const model2 = retrievalOf(rt).embeddings.model;
     const off = process.env.ATTICUS_EMBEDDINGS === "off" || model2 === "off";
@@ -552,6 +552,7 @@ export {
   stepModelLine,
   MIN_NODE,
   MIN_GIT,
+  defaultOnPath,
   doctorChecks,
   doctorCommand
 };

package/dist/{chunk-Q2X4IREC.js → chunk-HK3VOHIE.js}

@@ -3,15 +3,6 @@ import { fileURLToPath as __atticusFileURLToPath } from "node:url";
 var require = __atticusCreateRequire(import.meta.url);
 var __atticusUrl = (p) => new URL("./" + p, import.meta.url).href;
 var __atticusPath = (p) => __atticusFileURLToPath(__atticusUrl(p));
-import {
-  readRound,
-  reviewedGates,
-  roundsOf
-} from "./chunk-VEJYZEPC.js";
-import {
-  changeFolder,
-  changeStore
-} from "./chunk-IOW6BF3U.js";
 import {
   QueryError,
   askLookup,
@@ -19,17 +10,27 @@ import {
   impact,
   openIndex,
   translate
-} from "./chunk-YXUIUOQZ.js";
+} from "./chunk-5WERBKLE.js";
+import {
+  readRound,
+  reviewedGates,
+  roundsOf
+} from "./chunk-K332XW7K.js";
+import {
+  changeFolder,
+  changeStore
+} from "./chunk-HSZMPH5T.js";
 import {
   baseClonePath,
   gitUser,
   loadRepos
-} from "./chunk-ZQC7MNQB.js";
+} from "./chunk-XOL3GFW2.js";
 import {
   API_VERSION,
   DEFAULT_PORT,
   Lens,
   RECORD_KINDS,
+  RecordId,
   Severity,
   catalogDirOf,
   factsDirOf,
@@ -46,10 +47,11 @@ import {
   runsDirOf,
   specsDirOf,
   withSignal
-} from "./chunk-YK6CSODO.js";
+} from "./chunk-PAINMSID.js";
 import {
+  FileChangedError,
   SCHEMA_VERSION
-} from "./chunk-MMB2OHUY.js";
+} from "./chunk-ODMBPDDV.js";
 
 // packages/server/dist/http.js
 var HttpError = class extends Error {
@@ -145,15 +147,23 @@ var JobManager = class {
   cancelledIds = /* @__PURE__ */ new Set();
   aborts = /* @__PURE__ */ new Map();
   seq = 0;
+  /** Round 41: every running job of a kind, in start order (a later one never hides an earlier). */
   running = /* @__PURE__ */ new Map();
   constructor(publish, now = () => /* @__PURE__ */ new Date()) {
     this.publish = publish;
     this.now = now;
   }
-  /** The running job of a kind, if any (one scan at a time: a second asks gets 409). */
+  /**
+   * A running job of a kind, if any: the earliest still running (one scan at a time: a second
+   * ask gets 409).
+   */
   runningOf(kind) {
-    const id = this.running.get(kind);
-    return id ? this.jobs.get(id) : void 0;
+    for (const id of this.running.get(kind) ?? []) {
+      const j = this.jobs.get(id);
+      if (j?.state === "running")
+        return j;
+    }
+    return void 0;
   }
   get(id) {
     return this.jobs.get(id);
@@ -169,7 +179,9 @@ var JobManager = class {
       errors: []
     };
     this.jobs.set(id, job);
-    this.running.set(kind, id);
+    const ofKind = this.running.get(kind) ?? /* @__PURE__ */ new Set();
+    ofKind.add(id);
+    this.running.set(kind, ofKind);
     const abort = new AbortController();
     this.aborts.set(id, abort);
     const cancelled = this.cancelledIds;
@@ -200,7 +212,8 @@ var JobManager = class {
       }
       this.aborts.delete(id);
       job.finishedAt = this.now().toISOString();
-      if (this.running.get(kind) === id)
+      ofKind.delete(id);
+      if (!ofKind.size && this.running.get(kind) === ofKind)
         this.running.delete(kind);
       this.publish({ type: "job.done", jobId: id, state: job.state });
     })();
@@ -315,6 +328,7 @@ function apiRoutes(r, ctx) {
       ...strParam(query, "status") ? { status: strParam(query, "status") } : {},
       ...strParam(query, "system") ? { system: strParam(query, "system") } : {},
       ...strParam(query, "q") ? { q: strParam(query, "q") } : {},
+      ...strParam(query, "confidence") ? { confidence: strParam(query, "confidence") } : {},
       ...strParam(query, "cursor") ? { cursor: strParam(query, "cursor") } : {},
       ...limit !== void 0 ? { limit } : {}
     };
@@ -372,7 +386,20 @@ function apiRoutes(r, ctx) {
     return { status: 200, body: await withIndex(root, (ix) => graph(ix, o)) };
   }).add("GET", "/api/impact/{id}", async ({ params, query }) => {
     const depth = intParam(query, "depth", 1, 10);
-    const res = await withIndex(root, (ix) => impact(ix, params.id, depth));
+    const res = await withIndex(root, (ix) => {
+      const r2 = impact(ix, params.id, depth);
+      if (!r2)
+        return void 0;
+      return {
+        ...r2,
+        affected: r2.affected.map((a) => {
+          const rec = ix.find(a.id)[0];
+          const ai = (rec?.evidence ?? []).find((e) => e.source === "ai");
+          const flagged = Array.isArray(rec?.flags) && rec.flags.includes("joined-by-ai");
+          return flagged || ai ? { ...a, byAi: true, ...ai?.run ? { run: ai.run } : {} } : a;
+        })
+      };
+    });
     if (!res)
       throw notFound(`There is no record ${params.id} in the catalog.`);
     return { status: 200, body: res };
@@ -463,6 +490,8 @@ function apiRoutes(r, ctx) {
     return { status: 200, body };
   }).add("GET", "/api/findings", async ({ query }) => {
     const change = strParam(query, "change");
+    if (change !== void 0 && !RecordId.safeParse(change).success)
+      throw badRequest(`${change} isn't a change id.`);
     const gate = strParam(query, "gate");
     const state = strParam(query, "state");
     const lens = enumParam(query, "lens", Lens.options);
@@ -476,6 +505,8 @@ function apiRoutes(r, ctx) {
           body.push(f);
     return { status: 200, body };
   }).add("GET", "/api/findings/{changeId}/{findingId}", async ({ params }) => {
+    if (!RecordId.safeParse(params.changeId).success)
+      throw badRequest(`${params.changeId} isn't a change id.`);
     const f = (await latestFindings(root, params.changeId)).find((x) => x.id === params.findingId);
     if (!f)
       throw notFound(`Change ${params.changeId} has no finding ${params.findingId}.`);
@@ -520,7 +551,7 @@ function apiRoutes(r, ctx) {
 
 // packages/server/dist/static.js
 import { readFile as readFile2, stat as stat2 } from "node:fs/promises";
-import { extname, join as join2, normalize, sep } from "node:path";
+import { extname, join as join2, normalize, resolve, sep } from "node:path";
 var TYPES = {
   ".html": "text/html; charset=utf-8",
   ".js": "text/javascript; charset=utf-8",
@@ -549,7 +580,8 @@ function appCsp(port, embed) {
   ].join("; ");
 }
 var escapeAttr = (s) => s.replace(/&/g, "&amp;").replace(/"/g, "&quot;").replace(/</g, "&lt;");
-async function staticFile(dir, path, token) {
+async function staticFile(givenDir, path, token) {
+  const dir = resolve(givenDir);
   let rel;
   try {
     rel = decodeURIComponent(path);
@@ -598,6 +630,14 @@ function watchMetarepo(o) {
   const delay = o.delayMs ?? 300;
   const maxPaths = o.maxPaths ?? 50;
   const watchers = /* @__PURE__ */ new Map();
+  const inodes = /* @__PURE__ */ new Map();
+  const inodeOf = (d) => {
+    try {
+      return statSync(d).ino;
+    } catch {
+      return void 0;
+    }
+  };
   const problems = [];
   const pending = /* @__PURE__ */ new Set();
   let timer;
@@ -658,21 +698,39 @@ function watchMetarepo(o) {
         note(name ? join3(dir, String(name)) : dir);
       });
       w.on("error", (e) => {
-        problems.push(`${posix(relative(root, dir)) || "."}: ${e.message}`);
         w.close();
+        if (watchers.get(dir) !== w)
+          return;
+        problems.push(`${posix(relative(root, dir)) || "."}: ${e.message}`);
         watchers.delete(dir);
+        inodes.delete(dir);
       });
       watchers.set(dir, w);
+      const ino = inodeOf(dir);
+      if (ino !== void 0)
+        inodes.set(dir, ino);
+      const label = `${posix(relative(root, dir)) || "."}: `;
+      for (let i = problems.length - 1; i >= 0; i--)
+        if (problems[i].startsWith(label))
+          problems.splice(i, 1);
     } catch (e) {
       problems.push(`${posix(relative(root, dir)) || "."}: ${e.message}`);
     }
   };
   const attach = () => {
+    for (const [d, w] of watchers) {
+      const ino = inodeOf(d);
+      if (ino === void 0 || inodes.has(d) && inodes.get(d) !== ino) {
+        w.close();
+        watchers.delete(d);
+        inodes.delete(d);
+      }
+    }
+    follow(root, false);
+    follow(join3(root, ".atticus"), false);
     for (const d of folders())
       follow(d, true);
   };
-  follow(root, false);
-  follow(join3(root, ".atticus"), false);
   attach();
   return {
     get following() {
@@ -692,6 +750,8 @@ function watchMetarepo(o) {
 
 // packages/server/dist/ws.js
 import { createHash } from "node:crypto";
+var MAX_CLIENT_FRAME = 64 * 1024;
+var MAX_CLIENT_BUFFER = 256 * 1024;
 var GUID = "258EAFA5-E914-47DA-95CA-C5AB0DC85B11";
 function acceptKey(key) {
   return createHash("sha1").update(key + GUID).digest("base64");
@@ -743,8 +803,14 @@ var Socket = class {
     this.closed = true;
     this.onClose(this);
   }
-  /** Client frames are masked; only control frames matter to us. */
+  /**
+   * Client frames are masked; only control frames matter to us. The page sends nothing but pings
+   * and a close, so a frame over MAX_CLIENT_FRAME, a buffer over MAX_CLIENT_BUFFER or an unmasked
+   * frame (RFC 6455 5.1) closes the connection rather than growing memory.
+   */
   read(d) {
+    if (this.buf.length + d.length > MAX_CLIENT_BUFFER)
+      return this.close();
     this.buf = Buffer.concat([this.buf, d]);
     while (this.buf.length >= 2) {
       const opcode = this.buf[0] & 15;
@@ -762,15 +828,15 @@ var Socket = class {
         len = Number(this.buf.readBigUInt64BE(2));
         off = 10;
       }
+      if (!masked || len > MAX_CLIENT_FRAME)
+        return this.close();
       const maskOff = off;
-      if (masked)
-        off += 4;
+      off += 4;
       if (this.buf.length < off + len)
         return;
       const payload = Buffer.from(this.buf.subarray(off, off + len));
-      if (masked)
-        for (let i = 0; i < payload.length; i++)
-          payload[i] ^= this.buf[maskOff + i % 4];
+      for (let i = 0; i < payload.length; i++)
+        payload[i] ^= this.buf[maskOff + i % 4];
       this.buf = this.buf.subarray(off + len);
       if (opcode === 8)
         return this.close();
@@ -961,14 +1027,18 @@ async function startServer(o) {
       send(res, out.status, out.body);
       done(out.status);
     } catch (e) {
-      const err = e instanceof HttpError ? e : new HttpError(500, "Something went wrong", e instanceof Error ? e.message : String(e));
+      const err = e instanceof HttpError ? e : e instanceof FileChangedError ? new HttpError(409, "The file changed meanwhile", e.message) : (
+        // The message stays in the log (onRequest gets the error): an fs error names the
+        // metarepo's absolute path, which the page has no use for.
+        new HttpError(500, "Something went wrong", "The app's log (.atticus/logs/atticus.log) has the details.")
+      );
       send(res, err.status, problem(err), "application/problem+json");
       done(err.status, err.status >= 500 && e instanceof Error ? e : void 0);
     }
   });
   server.on("upgrade", (req, sock) => {
-    const url = new URL(req.url ?? "/", "http://127.0.0.1");
     try {
+      const url = new URL(req.url ?? "/", "http://127.0.0.1");
       if (url.pathname !== "/api/events")
         throw new HttpError(404, "Not found");
       guard(req, url, true);
@@ -984,9 +1054,9 @@ Connection: close\r
     if (s)
       events.add(s);
   });
-  await new Promise((resolve, reject) => {
+  await new Promise((resolve2, reject) => {
     server.once("error", reject);
-    server.listen(o.port ?? DEFAULT_PORT, host, () => resolve());
+    server.listen(o.port ?? DEFAULT_PORT, host, () => resolve2());
   });
   port = server.address().port;
   const watcher = o.watch === false ? void 0 : watchMetarepo({ root: o.root, publish: (e) => events.publish(e) });
@@ -1000,11 +1070,11 @@ Connection: close\r
     get following() {
       return watcher?.following ?? [];
     },
-    close: () => new Promise((resolve) => {
+    close: () => new Promise((resolve2) => {
       watcher?.close();
       events.closeAll();
       server.closeAllConnections?.();
-      server.close(() => resolve());
+      server.close(() => resolve2());
     })
   };
 }

package/dist/{chunk-P5JYMO7Y.js → chunk-HS4BGB4G.js}

@@ -5,7 +5,7 @@ var __atticusUrl = (p) => new URL("./" + p, import.meta.url).href;
 var __atticusPath = (p) => __atticusFileURLToPath(__atticusUrl(p));
 import {
   upgradeCommand
-} from "./chunk-MFUFB3LN.js";
+} from "./chunk-4B6BT75O.js";
 import {
   AdoptError,
   absorb,
@@ -18,34 +18,34 @@ import {
   reposDiscover,
   unadopt,
   zeroInstallFiles
-} from "./chunk-RTUUX7PX.js";
+} from "./chunk-2HTEMYTB.js";
 import {
   assistantTier,
   readProbes,
   tierLine
-} from "./chunk-BAXM3JFQ.js";
-import "./chunk-XO5RQKNM.js";
-import "./chunk-L3T33FA7.js";
-import "./chunk-VEJYZEPC.js";
-import "./chunk-IOW6BF3U.js";
-import "./chunk-43E6XX67.js";
-import "./chunk-V3UEPUHT.js";
-import "./chunk-EZBAS5BL.js";
-import "./chunk-KCQS52TH.js";
-import "./chunk-IPSFMTK2.js";
-import "./chunk-TNCROWPQ.js";
-import "./chunk-7IM4BVVH.js";
-import "./chunk-RBXDHCN7.js";
-import "./chunk-YXUIUOQZ.js";
-import "./chunk-S5PSGAQ2.js";
-import "./chunk-ZQC7MNQB.js";
-import "./chunk-TLDL2ZZI.js";
-import "./chunk-QNMLLYTN.js";
+} from "./chunk-3AQ2R5NL.js";
+import "./chunk-BEPCKDCP.js";
+import "./chunk-HWD4JPU7.js";
+import "./chunk-5WERBKLE.js";
+import "./chunk-K332XW7K.js";
+import "./chunk-HSZMPH5T.js";
+import "./chunk-D2WSW4GU.js";
+import "./chunk-4KNOJC6J.js";
+import "./chunk-4SLBCEPD.js";
+import "./chunk-64AADMTW.js";
+import "./chunk-JYMIB5XY.js";
+import "./chunk-CPK7QSBG.js";
+import "./chunk-YO2PKTXT.js";
+import "./chunk-TWQRPM76.js";
+import "./chunk-VUVGX5L2.js";
+import "./chunk-XOL3GFW2.js";
+import "./chunk-QHJJMZLX.js";
+import "./chunk-7AB6OWTV.js";
 import {
   loadOrgPack,
   orgPackDirOf
-} from "./chunk-YK6CSODO.js";
-import "./chunk-MMB2OHUY.js";
+} from "./chunk-PAINMSID.js";
+import "./chunk-ODMBPDDV.js";
 import "./chunk-TV45EUGM.js";
 
 // packages/cli/dist/setup-commands.js