@maycombhq/atticus 2.0.0-beta.11 → 2.0.0-beta.12.1

package/dist/{chunk-KLKENMWQ.js → chunk-CUD4I2U6.js}

@@ -5,43 +5,41 @@ var __atticusUrl = (p) => new URL("./" + p, import.meta.url).href;
 var __atticusPath = (p) => __atticusFileURLToPath(__atticusUrl(p));
 import {
   repoTypeOf
-} from "./chunk-52WCHTVZ.js";
+} from "./chunk-CGF4LKXR.js";
 import {
   estateFreshness
-} from "./chunk-G3PBLW4K.js";
-import {
-  readPlanProgress
-} from "./chunk-LVBPY2M6.js";
-import "./chunk-EW7MRMD5.js";
+} from "./chunk-ZDZCUZ4N.js";
+import "./chunk-DIAYQLEY.js";
 import {
   writeRepoSpecs
-} from "./chunk-IA2RKC6I.js";
+} from "./chunk-WFJMKUTR.js";
 import {
-  checkoutOf
-} from "./chunk-ASKDCMW5.js";
-import "./chunk-LDIARP6F.js";
-import "./chunk-MYKQVS5W.js";
-import "./chunk-EBWIOODZ.js";
+  checkoutOf,
+  readPlanProgress
+} from "./chunk-6AYUBYK6.js";
+import "./chunk-7VNEDDCC.js";
+import "./chunk-BHHIHENP.js";
+import "./chunk-42L2WHP6.js";
 import {
   linkEvidenceAbout,
   linkEvidenceLines,
   loadLinkEvidence,
   writeRepoContracts
-} from "./chunk-BA5DTXHQ.js";
+} from "./chunk-MIOY6EXD.js";
 import {
   diffLines
-} from "./chunk-4URR24DD.js";
+} from "./chunk-BFZSO2TP.js";
 import {
   askHosts
-} from "./chunk-XR5DD5DQ.js";
+} from "./chunk-CYDJK34J.js";
 import "./chunk-3G4YI4ZU.js";
-import "./chunk-EI4KQYJ3.js";
-import "./chunk-6RGIM2ZH.js";
+import "./chunk-YSFIQGDK.js";
+import "./chunk-J22RSFKY.js";
 import "./chunk-VOGCSYOI.js";
-import "./chunk-T6ESD5KM.js";
-import "./chunk-3LU6YCSQ.js";
-import "./chunk-L7I5PKGD.js";
-import "./chunk-CAN3EBE5.js";
+import "./chunk-KPHPVOME.js";
+import "./chunk-G5SKNMPC.js";
+import "./chunk-JQG4VO47.js";
+import "./chunk-DW4BM73R.js";
 import {
   TARGETS_STEP,
   answerReconfirmed,
@@ -63,24 +61,25 @@ import {
   targetsFromAnswers,
   topicQuestionDrafts,
   writeCatalog
-} from "./chunk-IILZ7J3L.js";
-import "./chunk-TEBBD4XH.js";
+} from "./chunk-DBZNQAMN.js";
+import "./chunk-QR65C3DV.js";
 import {
   codeLinkerFor,
   frameworkFacts,
   frameworkGaps,
   renderMap,
   trustOf
-} from "./chunk-XPWSNKF3.js";
-import "./chunk-WIMOJMAK.js";
-import "./chunk-5V5BJACL.js";
-import "./chunk-GVFUEGGM.js";
+} from "./chunk-7VAMO66T.js";
+import "./chunk-HY2VVVFZ.js";
+import "./chunk-PJRMMWU4.js";
+import "./chunk-34NWVIBC.js";
+import "./chunk-M4D3VKAS.js";
 import {
   baseClonePath,
   loadRepos
-} from "./chunk-XZJE6WIT.js";
-import "./chunk-FMRMTI7W.js";
-import "./chunk-BKFGGJKA.js";
+} from "./chunk-RA64IK43.js";
+import "./chunk-MRLCNXXR.js";
+import "./chunk-CQD26SMZ.js";
 import {
   CALL_SECURITY_CHECK,
   SPEC_HEADER_SCHEMA_VERSION,
@@ -95,6 +94,7 @@ import {
   flowFiles,
   isAdopted,
   isGuessedJoin,
+  joinFlagsOf,
   listQuestions,
   loadOrgPack,
   mapDirOf,
@@ -117,7 +117,7 @@ import {
   termQuestionDrafts,
   writeFlow,
   writeSpecHeader
-} from "./chunk-JMOLB347.js";
+} from "./chunk-U25OX22K.js";
 import {
   LockHeldError,
   acquireLock,
@@ -152,7 +152,7 @@ async function readNotSettled(root, repo, o = {}) {
   if (gaps !== void 0 && (facts === void 0 || gaps >= facts))
     return `its second pass (atticus map ${repo} --gaps) is planned and not read yet`;
   const fresh = (await estateFreshness(root, { repos: [repo], ...o.git ? { git: o.git } : {} })).repos[0];
-  if (!fresh || fresh.state !== "fresh")
+  if (!fresh || fresh.state !== "fresh" && fresh.state !== "rules-changed")
     return `its facts aren't fresh (atticus estate fresh says ${fresh?.state ?? "not-read"})`;
   return void 0;
 }
@@ -265,13 +265,24 @@ var HOW_WORDS = {
 function linkChanges(repo, join3, before, after) {
   const mine = (xs) => (xs ?? []).filter((x) => x.call.repo === repo);
   const joined = mine(join3?.joins);
-  const how = new Map((join3?.joins ?? []).map((j) => [j.interface, j.how]));
+  const joinsOf = /* @__PURE__ */ new Map();
+  for (const j of [...joined, ...(join3?.joins ?? []).filter((x) => !joined.includes(x))])
+    joinsOf.set(j.interface, [...joinsOf.get(j.interface) ?? [], j]);
+  const howOf = (r) => {
+    const all = joinsOf.get(r.id) ?? [];
+    const own = all.filter((j) => joined.includes(j));
+    const best = own.find((j) => !isGuessedJoin(j)) ?? own[0] ?? all[0];
+    if (!best)
+      return void 0;
+    const byOther = r.confidence === "verified" && own.length > 0 && isGuessedJoin(best);
+    return { how: best.how, ...byOther ? { byOther, guesses: joinFlagsOf(best) } : {} };
+  };
   const ifaces = (rs) => new Map(rs.filter((r) => r.kind === "Interface").map((r) => [r.id, r]));
   const was = ifaces(before);
   const now = ifaces(after);
   const linked = new Set([...now.values()].flatMap((r) => r.evidence.filter((e) => e.side !== "callee").map((e) => `${e.repo}|${e.path}:${e.line}`)));
   const line = (r, found) => {
-    const h = found ? how.get(r.id) : void 0;
+    const h = found ? howOf(r) : void 0;
     return {
       id: r.id,
       from: r.from,
@@ -279,8 +290,9 @@ function linkChanges(repo, join3, before, after) {
       ...r.method ? { method: r.method } : {},
       path: r.normalizedPath,
       confidence: r.confidence,
-      ...h ? { how: h } : {},
-      ...r.flags?.length ? { flags: [...r.flags] } : {}
+      ...h ? { how: h.how } : {},
+      ...r.flags?.length ? { flags: [...r.flags] } : {},
+      ...h?.byOther ? { byOther: true, guesses: h.guesses } : {}
     };
   };
   const byId = (a, b) => a.id < b.id ? -1 : a.id > b.id ? 1 : 0;
@@ -326,6 +338,11 @@ function linkLines(l, report, o = {}) {
   const text = (sign, x) => {
     const what = [x.method, x.path].filter(Boolean).join(" ");
     const conf = x.was ? `${x.confidence}, was ${x.was.confidence}` : x.confidence;
+    if (x.byOther && x.how) {
+      const g = x.guesses?.join(", ");
+      const was = x.was ? `, was ${x.was.confidence}` : "";
+      return `    ${sign} ${x.from} \u2192 ${x.to} ${what} (${x.confidence} by another call${was}; this one by ${HOW_WORDS[x.how]}${g ? `: ${g}` : ""})`;
+    }
     const flags = x.flags?.join(", ");
     const found = x.how ? `found by ${HOW_WORDS[x.how]}${flags ? `: ${flags}` : ""}` : flags ?? "";
     return `    ${sign} ${x.from} \u2192 ${x.to} ${what} (${conf}${found ? `; ${found}` : ""})`;
@@ -585,19 +602,17 @@ async function writeFactsIntoCatalog(root, repo, facts, o, io) {
       estate: estate.repos,
       questions: everyTarget
     });
+    const refreshed = [];
     for (const t of drafted) {
-      const r = await raiseQuestions(root, [t.draft], {
-        step: TARGETS_STEP,
-        repo,
-        command: o.command,
-        rerun,
-        at
-      });
+      const r = await raiseQuestions(root, [t.draft], { step: TARGETS_STEP, repo, command: o.command, rerun, at }, { refresh: true });
+      refreshed.push(...r.refreshed);
       for (const q of r.raised) {
         raised.push(q);
         lines.push(t.factIds.length > 1 ? `${t.factIds.length} calls go the same way and name no target the estate has: asked once, ${q.id}: ${q.question} One answer names the target of all of them. Answer it: atticus questions answer ${q.id} --option <n>, then ${rerun}.` : named.has(t.factId) ? `A call names a target the estate doesn't have, and more than one entry serves it: asked ${q.id}: ${q.question} Answer it: atticus questions answer ${q.id} --option <n>, then ${rerun}.` : `A call names no target: asked ${q.id}: ${q.question} Answer it: atticus questions answer ${q.id} --option <n>, then ${rerun}.`);
       }
     }
+    if (refreshed.length)
+      lines.push(`Refreshed ${refreshed.length === 1 ? "1 open question" : `${refreshed.length} open questions`} asked before (${refreshed.map((q) => q.id).join(", ")}): the same id, with today's options, ranked by the estate as read now, each saying why it is suggested.`);
     for (const t of topicQuestionDrafts(repo, result.records)) {
       const r = await raiseQuestions(root, [t.draft], {
         step: TOPICS_STEP_ID,

package/dist/{chunk-5TY4DTHQ.js → chunk-CUX4GRTB.js}

@@ -15,13 +15,13 @@ import {
   releaseNotes,
   securityReview,
   writeEvidencePack
-} from "./chunk-7A7IG7OA.js";
+} from "./chunk-Y6LFFSRV.js";
 import {
   judgingRuntime
-} from "./chunk-NBGBMRIS.js";
+} from "./chunk-EREL3TQG.js";
 import {
   changeStore
-} from "./chunk-3LU6YCSQ.js";
+} from "./chunk-G5SKNMPC.js";
 
 // packages/cli/dist/release-commands.js
 import { resolve } from "node:path";

package/dist/{chunk-5NZSJ5ZG.js → chunk-CXY4YDXS.js}

@@ -28,8 +28,8 @@ import {
   stampEvidence,
   tooLargeMessage,
   withParseCache
-} from "./chunk-FMRMTI7W.js";
-import "./chunk-JMOLB347.js";
+} from "./chunk-MRLCNXXR.js";
+import "./chunk-U25OX22K.js";
 import "./chunk-MMB2OHUY.js";
 import "./chunk-TV45EUGM.js";
 export {

package/dist/{chunk-XR5DD5DQ.js → chunk-CYDJK34J.js}

@@ -4,16 +4,17 @@ var require = __atticusCreateRequire(import.meta.url);
 var __atticusUrl = (p) => new URL("./" + p, import.meta.url).href;
 var __atticusPath = (p) => __atticusFileURLToPath(__atticusUrl(p));
 import {
+  gatewayHostFix,
   hostQuestionDrafts,
   unknownHosts
-} from "./chunk-IILZ7J3L.js";
+} from "./chunk-DBZNQAMN.js";
 import {
   baseClonePath,
   loadRepos
-} from "./chunk-XZJE6WIT.js";
+} from "./chunk-RA64IK43.js";
 import {
   fsRepo
-} from "./chunk-FMRMTI7W.js";
+} from "./chunk-MRLCNXXR.js";
 import {
   HOSTS_NONE,
   HOSTS_OUTSIDE_INTERNAL,
@@ -25,7 +26,7 @@ import {
   raiseQuestions,
   retireQuestion,
   writeQuestion
-} from "./chunk-JMOLB347.js";
+} from "./chunk-U25OX22K.js";
 
 // packages/cli/dist/host-questions.js
 import { stat } from "node:fs/promises";
@@ -50,7 +51,11 @@ async function askHosts(root, records, o) {
   const at = (o.now ?? /* @__PURE__ */ new Date()).toISOString();
   const reasked = [];
   const OUTSIDE = /* @__PURE__ */ new Set([HOSTS_OUTSIDE_INTERNAL, HOSTS_OUTSIDE_VENDOR]);
-  for (const { repo, draft } of hostQuestionDrafts(asks)) {
+  const gateway = /* @__PURE__ */ new Map();
+  for (const { repo, draft, byPath } of hostQuestionDrafts(asks)) {
+    const host = hostOfQuestion(draft);
+    if (byPath?.length && host)
+      gateway.set(host, gatewayHostFix(host, byPath));
     if (asked.has(hostOfQuestion(draft))) {
       const old = before.find((q) => hostOfQuestion(q) === hostOfQuestion(draft));
       if (!old || old.state !== "open" || old.options.some((x) => OUTSIDE.has(x.label)))
@@ -91,11 +96,11 @@ async function askHosts(root, records, o) {
     lines.push(`Retired ${q.id} (${q.question}): ${why}.`);
   }
   for (const q of raised)
-    lines.push(`Calls to ${hostOfQuestion(q)} join no repo: no repo lists it under hosts. Asked ${q.id}: ${q.question} Answer it: atticus questions answer ${q.id} --option <n> (1 is ${q.options[0].label}). If several repos answer on it (a shared gateway or platform host), don't pick one: list it under hosts on each of them in repos.manifest.yaml (with each one's basePath where the path tells them apart), and the question retires itself. If a system outside the estate answers on it, pick an outside system (another team's or a vendor's): it goes into the profile with the host as its alias.`);
+    lines.push(gateway.has(hostOfQuestion(q)) ? `Calls to ${hostOfQuestion(q)} join no repo: no repo lists it under hosts. Asked ${q.id}: ${q.question} ${gateway.get(hostOfQuestion(q))}. If one repo alone answers on it, answer: atticus questions answer ${q.id} --option <n> (1 is ${q.options[0].label}).` : `Calls to ${hostOfQuestion(q)} join no repo: no repo lists it under hosts. Asked ${q.id}: ${q.question} Answer it: atticus questions answer ${q.id} --option <n> (1 is ${q.options[0].label}). If several repos answer on it (a shared gateway or platform host), don't pick one: list it under hosts on each of them in repos.manifest.yaml (with each one's basePath where the path tells them apart), and the question retires itself. If a system outside the estate answers on it, pick an outside system (another team's or a vendor's): it goes into the profile with the host as its alias.`);
   for (const q of reasked)
     lines.push(`Re-asked ${q.id} (${q.question}): it now offers an outside system, another team's or a vendor's, for a host no repo of the estate answers on.`);
   for (const q of open)
-    lines.push(`Still open: ${q.question} Answer it: atticus questions answer ${q.id} --option <n>, then ${o.rerun ?? HOSTS_RERUN}.`);
+    lines.push(`Still open: ${q.question}${gateway.has(hostOfQuestion(q)) ? ` ${gateway.get(hostOfQuestion(q))}.` : ""} Answer it: atticus questions answer ${q.id} --option <n>, then ${o.rerun ?? HOSTS_RERUN}.`);
   return { raised, reasked, open, lines };
 }
 

package/dist/{chunk-WKXOEIOY.js → chunk-DBVU45FY.js}

@@ -11,23 +11,23 @@ import {
   planJourney,
   recordCommitment,
   requestFromTeam
-} from "./chunk-Z46OXTBE.js";
+} from "./chunk-EOCZDNWU.js";
 import {
   table
 } from "./chunk-VOGCSYOI.js";
-import "./chunk-3LU6YCSQ.js";
-import "./chunk-L7I5PKGD.js";
-import "./chunk-CAN3EBE5.js";
-import "./chunk-IILZ7J3L.js";
-import "./chunk-TEBBD4XH.js";
-import "./chunk-XPWSNKF3.js";
-import "./chunk-WIMOJMAK.js";
-import "./chunk-5V5BJACL.js";
-import "./chunk-GVFUEGGM.js";
-import "./chunk-XZJE6WIT.js";
-import "./chunk-FMRMTI7W.js";
-import "./chunk-BKFGGJKA.js";
-import "./chunk-JMOLB347.js";
+import "./chunk-G5SKNMPC.js";
+import "./chunk-JQG4VO47.js";
+import "./chunk-DW4BM73R.js";
+import "./chunk-DBZNQAMN.js";
+import "./chunk-QR65C3DV.js";
+import "./chunk-7VAMO66T.js";
+import "./chunk-HY2VVVFZ.js";
+import "./chunk-PJRMMWU4.js";
+import "./chunk-34NWVIBC.js";
+import "./chunk-RA64IK43.js";
+import "./chunk-MRLCNXXR.js";
+import "./chunk-CQD26SMZ.js";
+import "./chunk-U25OX22K.js";
 import "./chunk-MMB2OHUY.js";
 import "./chunk-TV45EUGM.js";