@maxiaochao/pi-toolkit 0.10.0 → 0.10.2

package/packages/herdr-subagents/tests/run-tests.mjs

@@ -15,7 +15,7 @@ import { cancelActiveSubagentRuns, reconcileSubagentRuns } from "../src/reconcil
 import { continueQueuedRun } from "../src/continue-run.ts";
 import { CliHerdrAutomation } from "../src/herdr.ts";
 import { fleetEditorHasFocus, FleetSelection, fleetLines } from "../src/fleet.ts";
-import { HERDR_ACTIONS, validateToolParams } from "../src/validation.ts";
+import { HERDR_ACTIONS, validateControlParams, validateRunParams } from "../src/validation.ts";
 import { resultPathForAttempt } from "../src/result-path.ts";
 import { isSettledRunStatus, readTaskRecord } from "../src/records.ts";
 import { RunPaneAllocator } from "../src/run-pane-allocator.ts";
@@ -136,22 +136,18 @@ function latestRunDirectory() {
 }
 
 try {
-	check("flat mode validation accepts supported calls", [
+	check("run validation accepts one or more tasks", validateRunParams({ tasks: [{ name: "one", prompt: "do it" }], concurrency: 2, background: true }) === undefined);
+	check("control validation accepts supported calls", [
 		{ action: "list" }, { action: "history" }, { action: "cleanup", runId: "run" },
 		{ action: "respond", runId: "run", answer: "yes", task: 1 },
 		{ action: "resume", runId: "run", task: 1, prompt: "continue" },
-		{ prompt: "one task", agent: "worker", label: "one", model: "fake/model" },
-		{ tasks: [{ name: "one", prompt: "do it" }], concurrency: 2, background: true },
-	].every((params) => validateToolParams(params) === undefined));
+	].every((params) => validateControlParams(params) === undefined));
 	check("all supported actions have shared validation and rendering metadata", ["list", "history", "cleanup", "respond", "resume"].every((action) => action in HERDR_ACTIONS));
-	check("flat mode validation rejects ambiguous and extraneous fields", [
-		validateToolParams({ prompt: "one", tasks: [{ name: "two", prompt: "two" }] }),
-		validateToolParams({ action: "list", prompt: "not allowed" }),
-		validateToolParams({ action: "respond", runId: "run" }),
-		validateToolParams({ tasks: [{ name: "one", prompt: "one" }], agent: "worker" }),
-		validateToolParams({ prompt: "one", runId: "run" }),
-		validateToolParams({ prompt: "one", task: 1 }),
-		validateToolParams({ tasks: [{ name: "one", prompt: "one" }], answer: "extra" }),
+	check("split validation rejects missing tasks and invalid control fields", [
+		validateRunParams({ tasks: [] }),
+		validateControlParams({ action: "list", prompt: "not allowed" }),
+		validateControlParams({ action: "respond", runId: "run" }),
+		validateControlParams({ action: "resume", runId: "run", task: 1 }),
 	].every((message) => typeof message === "string" && message.length > 0));
 	const fleet = new FleetSelection();
 	const fleetBatch = { label: "reviews", activity: [
@@ -257,24 +253,30 @@ try {
 	mkdirSync(projectAgents, { recursive: true });
 	writeFileSync(join(packageAgents, "worker.md"), `---\nname: worker\ndescription: Package worker\naccess: write\nmodel: package/model\nskills: package-skill\n---\nPackage prompt.`);
 	writeFileSync(join(packageAgents, "explorer.md"), `---\nname: explorer\ndescription: Package explorer\naccess: read\n---\nExplore.`);
+	writeFileSync(join(packageAgents, "thinker.md"), `---\nname: thinker\ndescription: Package thinker\nthinking: minimal\n---\nThink.`);
 	writeFileSync(join(globalAgents, "worker.md"), `---\nname: worker\ndescription: Global worker\naccess: read\n---\nGlobal prompt.`);
 	writeFileSync(join(projectAgents, "worker.md"), `---\nname: worker\ndescription: Project worker\n---\nProject prompt.`);
 	const globalConfig = join(configRoot, "global.json");
 	const projectConfig = join(configRoot, "project.json");
-	writeFileSync(globalConfig, JSON.stringify({ maxConcurrency: 8, defaultModel: "global/default", personas: { worker: { model: "global/worker", thinking: "low", skills: ["global-skill"] } } }));
-	writeFileSync(projectConfig, JSON.stringify({ maxConcurrency: 3, personas: { worker: { model: "project/worker", thinking: "high", skills: ["project-skill"] } } }));
+	writeFileSync(globalConfig, JSON.stringify({ maxConcurrency: 8, defaultModel: "global/default", defaultThinking: "medium", personas: { worker: { model: "global/worker", thinking: "low", skills: ["global-skill"] } } }));
+	writeFileSync(projectConfig, JSON.stringify({ maxConcurrency: 3, defaultThinking: "high", personas: { worker: { model: "project/worker", thinking: "high", skills: ["project-skill"] } } }));
 	const configurationPaths = { globalConfig, projectConfig, globalAgents, projectAgents };
 	const configuration = loadSubagentConfiguration(configRoot, packageAgents, "parent/model", configurationPaths);
 	const configuredWorker = configuration.personas.find((persona) => persona.name === "worker");
 	const configuredExplorer = configuration.personas.find((persona) => persona.name === "explorer");
-	check("built-in settings recursively merge global then project", configuration.settings.defaultConcurrency === 1 && configuration.settings.maxConcurrency === 3 && configuration.settings.defaultModel === "global/default" && configuration.settingSources.maxConcurrency === "project");
+	const configuredThinker = configuration.personas.find((persona) => persona.name === "thinker");
+	check("built-in settings recursively merge global then project", configuration.settings.defaultConcurrency === 1 && configuration.settings.maxConcurrency === 3 && configuration.settings.defaultModel === "global/default" && configuration.settings.defaultThinking === "high" && configuration.settingSources.maxConcurrency === "project" && configuration.settingSources.defaultThinking === "project");
 	check("persona definitions use project global package precedence", configuredWorker?.source === "project" && configuredWorker.description === "Project worker" && configuredWorker.systemPrompt === "Project prompt." && configuredWorker.access === "write" && configuredExplorer?.source === "package" && configuredExplorer.access === "read");
 	check("persona configuration resolves model thinking and skills", configuredWorker?.model === "project/worker" && configuredWorker.modelSource === "project persona" && configuredWorker.thinking === "high" && configuredWorker.skills.join(",") === "project-skill");
-	writeFileSync(projectConfig, JSON.stringify({ personas: { worker: { model: 42, thinking: [], skills: "invalid" } } }));
+	check("project default thinking applies below persona settings", configuredExplorer?.thinking === "high" && configuredExplorer.thinkingSource === "project");
+	check("persona Markdown thinking overrides default thinking", configuredThinker?.thinking === "minimal" && configuredThinker.thinkingSource === "package persona");
+	writeFileSync(projectConfig, JSON.stringify({ defaultThinking: [], personas: { worker: { model: 42, thinking: [], skills: "invalid" } } }));
 	const invalidConfiguration = loadSubagentConfiguration(configRoot, packageAgents, "parent/model", configurationPaths);
 	const invalidWorker = invalidConfiguration.personas.find((persona) => persona.name === "worker");
 	check("invalid persona fields are diagnosed and ignored", invalidWorker?.model === "global/worker" && invalidWorker.thinking === "low" && invalidWorker.skills.join(",") === "global-skill" && invalidConfiguration.diagnostics.filter((message) => message.includes("persona 'worker'")).length === 3);
-	writeFileSync(projectConfig, JSON.stringify({ maxConcurrency: 3, personas: { worker: { model: "project/worker", thinking: "high", skills: ["project-skill"] } } }));
+	const invalidExplorer = invalidConfiguration.personas.find((persona) => persona.name === "explorer");
+	check("invalid project default thinking is diagnosed and global default remains effective", invalidExplorer?.thinking === "medium" && invalidExplorer.thinkingSource === "global" && invalidConfiguration.diagnostics.some((message) => message === "project defaultThinking must be a non-empty string"));
+	writeFileSync(projectConfig, JSON.stringify({ maxConcurrency: 3, defaultThinking: "high", personas: { worker: { model: "project/worker", thinking: "high", skills: ["project-skill"] } } }));
 	const configuredHerdr = fakeHerdr();
 	const configuredRun = await executeHerdrSubagents({ agent: "worker", model: "task/model", prompt: "Use configured values" }, undefined, undefined, { cwd: configRoot, model: { provider: "parent", id: "model" }, thinkingLevel: "medium" }, { agentsDirectory: packageAgents, configurationPaths, herdr: configuredHerdr });
 	const configuredStart = configuredHerdr.calls.find(([name]) => name === "startAgent")[1];
@@ -548,7 +550,7 @@ try {
 	const historyHerdr = fakeHerdr();
 	const historicalResume = await executeHerdrSubagents({ action: "resume", runId: backgroundId, task: 1, prompt: "follow up" }, undefined, undefined, { cwd: root, model: { provider: "fake", id: "model" } }, { agentsDirectory: join(process.cwd(), "agents"), herdr: historyHerdr });
 	const historyStartRequest = historyHerdr.calls.find(([name]) => name === "startAgent")[1];
-	check("historical resume preserves the saved Pi session and persona prompt", !historicalResume.isError && historyHerdr.calls[0][0] === "createTab" && historyStartRequest.args.includes(stableHistory.tasks[0].sessionFile) && historyStartRequest.args.includes("fake/model") && historyStartRequest.args.some((value) => String(value).includes("subagent_report")) && existsSync(join(stableHistory.tasks[0].recordDirectory, "turns", "02.json")) && readFileSync(join(stableHistory.tasks[0].recordDirectory, "followup-system-prompt.md"), "utf8").includes("Investigate the assigned question without modifying files"));
+	check("historical resume preserves the saved Pi session and persona prompt", !historicalResume.isError && historyHerdr.calls[0][0] === "createTab" && historyStartRequest.args.includes(stableHistory.tasks[0].sessionFile) && historyStartRequest.args.includes(stableHistory.tasks[0].model) && historyStartRequest.args.some((value) => String(value).includes("subagent_report")) && existsSync(join(stableHistory.tasks[0].recordDirectory, "turns", "02.json")) && readFileSync(join(stableHistory.tasks[0].recordDirectory, "followup-system-prompt.md"), "utf8").includes("Investigate the assigned question without modifying files"));
 	const historicalTaskRecord = JSON.parse(readFileSync(join(stableHistory.tasks[0].recordDirectory, "task.json"), "utf8"));
 	const historicalTurnRecord = JSON.parse(readFileSync(join(stableHistory.tasks[0].recordDirectory, "turns", "02.json"), "utf8"));
 	check("historical task and turn retain their tab identity", historicalTaskRecord.tabId === historicalResume.details.tabId && historicalTurnRecord.tabId === historicalResume.details.tabId);

package/skills/calldiff/LICENSE

@@ -1,21 +0,0 @@
-MIT License
-
-Copyright (c) 2026 Tanishq Kancharla
-
-Permission is hereby granted, free of charge, to any person obtaining a copy
-of this software and associated documentation files (the "Software"), to deal
-in the Software without restriction, including without limitation the rights
-to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-copies of the Software, and to permit persons to whom the Software is
-furnished to do so, subject to the following conditions:
-
-The above copyright notice and this permission notice shall be included in all
-copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
-SOFTWARE.

package/skills/calldiff/NOTICE

@@ -1,19 +0,0 @@
-calldiff Skill
-
-This directory is copied verbatim from the calldiff repository:
-https://github.com/tanishqkancharla/calldiff
-skills/calldiff/SKILL.md at commit 2086f6e4e9ed3c410bba7c94ca3dde77791b1956 (main)
-
-The upstream repository is licensed under the MIT License. A copy of that
-license is included in LICENSE.
-
-Upstream publishes no release tags, so this file is pinned to a main commit
-instead of a tag. The CLI can also write its own copy with `calldiff skills
-add` (to ~/.agents/skills/calldiff/SKILL.md), but that generated file is terser
-than the committed one — it leaves the --entry/--file descriptions empty and
-says 22 languages — so pi-toolkit ships the committed file.
-
-To refresh, copy skills/calldiff/SKILL.md and LICENSE from a newer upstream
-commit and update the commit above. The bundled commands were smoke-tested
-against calldiff 0.5.0 (`diff`, `tree`, `reach`, `--entry`, `--file`,
-`--maxDepth`/`--max-depth`, `--locs`, `--format json`).

package/skills/calldiff/SKILL.md

@@ -1,121 +0,0 @@
----
-name: calldiff
-description: Diff call stacks across git commits — like git diff, but for who-calls-whom. Shows which callees appeared, disappeared, or moved under an entrypoint across 23 languages (diff, tree, and reach). Use for agentic code review when call flow changed and line diffs bury the shape of the change.
-requires_bin: calldiff
-command: calldiff
----
-
-# calldiff diff
-
-Diff call stacks between two git trees
-
-## Arguments
-
-| Name | Type | Required | Description |
-|------|------|----------|-------------|
-| `from` | `string` | no | Before ref (default: HEAD) |
-| `to` | `string` | no | After ref (default: working tree) |
-| `paths` | `array` | no | Limit to these path prefixes |
-
-## Options
-
-| Flag | Type | Default | Description |
-|------|------|---------|-------------|
-| `--entry` | `unknown` |  | Entrypoint symbol(s): functionName or ClassName.method |
-| `--file` | `unknown` |  | Entrypoint file(s): indexed source path; expands to that file's exports |
-| `--maxDepth` | `number` | `12` | Max call-tree depth |
-| `--locs` | `boolean` | `false` | Show call-site source locations (file:line) |
-| `--from` | `string` |  | Left / "before" tree |
-| `--to` | `string` |  | Right / "after" tree |
-
-## Examples
-
-```sh
-# HEAD vs working tree
-calldiff diff
-
-# One ref vs working tree
-calldiff diff main
-
-# Two commits / branches
-calldiff diff abc123 def456
-
-# Force entrypoints
-calldiff diff main feature --entry createAgentSession
-
-# File expands to that file's exports
-calldiff diff main feature --file src/routes.ts
-```
-
-> Semantics match git diff: no refs → HEAD vs worktree; one ref → that vs worktree; two refs → compare those trees.
-
----
-
-# calldiff reach
-
-Find all call paths from an entrypoint to a target symbol
-
-## Arguments
-
-| Name | Type | Required | Description |
-|------|------|----------|-------------|
-| `ref` | `string` | no | Git ref (default: working tree) |
-| `paths` | `array` | no | Limit to these path prefixes |
-
-## Options
-
-| Flag | Type | Default | Description |
-|------|------|---------|-------------|
-| `--entry` | `unknown` |  | Entrypoint symbol(s): functionName or ClassName.method |
-| `--file` | `unknown` |  | Entrypoint file(s): indexed source path; expands to that file's exports |
-| `--to` | `string` |  | Target symbol to reach (functionName or ClassName.method) |
-| `--maxDepth` | `number` | `12` | Max call-tree depth |
-| `--locs` | `boolean` | `false` | Show call-site source locations (file:line) |
-
-## Examples
-
-```sh
-# Paths in the working tree
-calldiff reach --entry runCheckout --to sendEmail
-
-# Paths at a commit, limited to a directory
-calldiff reach HEAD examples/checkout --entry runCheckout --to sendEmail
-
-# Paths from every export in a file
-calldiff reach --file packages/api/src/flow.ts --to notify
-```
-
----
-
-# calldiff tree
-
-View a call tree (no diff) for one or more entrypoints
-
-## Arguments
-
-| Name | Type | Required | Description |
-|------|------|----------|-------------|
-| `ref` | `string` | no | Git ref (default: working tree) |
-| `paths` | `array` | no | Limit to these path prefixes |
-
-## Options
-
-| Flag | Type | Default | Description |
-|------|------|---------|-------------|
-| `--entry` | `unknown` |  | Entrypoint symbol(s): functionName or ClassName.method |
-| `--file` | `unknown` |  | Entrypoint file(s): indexed source path; expands to that file's exports |
-| `--maxDepth` | `number` | `12` | Max call-tree depth |
-| `--locs` | `boolean` | `false` | Show call-site source locations (file:line) |
-
-## Examples
-
-```sh
-# Tree from working tree
-calldiff tree --entry createAgentSession
-
-# Tree from a commit
-calldiff tree HEAD --entry PiService.createAgentSession
-
-# Every export in a file
-calldiff tree --file packages/api/src/routes.ts
-```