@maxiaochao/pi-toolkit 0.10.0 → 0.10.1

package/CHANGELOG.md

@@ -1,3 +1,14 @@
+## 2026-10-08 - v0.10.1
+
+- bundle herdr-subagents v0.2.1: add default thinking configuration and inline Herdr workflow video
+- remove the bundled `calldiff` skill
+- add merged global/project `defaultThinking` for Herdr Subagents, below persona-specific thinking and above parent-session fallback
+- embed the Herdr workflow video directly in the GitHub README, retain the reproducible WebM source, and remove the GIF preview
+- document every Herdr Subagents settings and persona option, accepted values, defaults, configuration paths, examples, and exact precedence
+- add a full real-time Herdr Subagents WebM recording that focuses every child Agent pane before returning to the parent summary
+
+- replace the rendered Herdr transcript demo with a real UI recording of a parent Pi conversation opening and completing three concurrent interactive Agent panes
+
 ## 2026-10-08 - v0.10.0
 
 - bundle herdr-subagents v0.2.0: replace Tiny Subagent with visible interactive Herdr agents and durable batch workflows

package/README.md

@@ -66,7 +66,6 @@ bash scripts/install.sh
 | `herdr` | Control Herdr workspaces, tabs, panes, and agents |
 | `agent-team` | Run cross-vendor adversarial review through Herdr |
 | `tapd` | Use the TAPD CLI for requirements, defects, tasks, and wikis |
-| `calldiff` | Diff call stacks across commits |
 
 Package-specific skills, such as `pi-worktree`, are documented by their child package.
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@maxiaochao/pi-toolkit",
-  "version": "0.10.0",
+  "version": "0.10.1",
   "description": "Personal pi coding agent toolkit: /todos, /btw, /cache_export and apply_patch extensions, browser automation, and bundled theme/skills.",
   "type": "module",
   "workspaces": [

package/packages/herdr-subagents/CHANGELOG.md

@@ -1,3 +1,12 @@
+## 2026-10-08 - v0.2.1
+
+- add default thinking configuration and inline Herdr workflow video
+- Add merged global/project `defaultThinking`, below persona-specific thinking and above parent-session fallback, with effective source reporting.
+- Embed the workflow video directly in the GitHub README, retain the reproducible WebM source, and remove the GIF preview.
+- Expand the README with every settings and persona option, accepted values, defaults, paths, examples, and exact model, thinking, skills, and definition precedence.
+- Add a full WebM recording that focuses all three live child Agent panes before returning to the parent summary.
+- Replace the rendered transcript media with a real Herdr UI recording that follows a parent Pi conversation through a three-Agent batch and final compact response.
+
 ## 2026-10-08 - v0.2.0
 
 - replace Tiny Subagent with visible interactive Herdr agents and durable batch workflows

package/packages/herdr-subagents/README.md

@@ -2,11 +2,16 @@
 
 A Pi extension that runs focused foreground or background work as normal interactive Pi Agents in visible Herdr panes. Full answers and sessions stay in project-local records while the parent receives only concise summaries and document paths.
 
-![Herdr Subagents production runner screenshot](docs/screenshot.png)
+![A parent Pi conversation running three visible Herdr Subagents panes](docs/screenshot.png)
 
 ## Demo
 
-![Herdr Subagents demo](docs/demo.gif)
+The recording shows a real Pi conversation invoking a three-task read-only batch, Herdr opening one interactive Agent pane per task, and the compact results returning to the parent.
+
+https://github.com/user-attachments/assets/8ddf3ae6-a11a-492b-9cae-d9496ba65b67
+
+The video starts a three-agent batch, focuses each live child pane in turn, then returns
+to the parent summary. The reproducible source recording is retained as [`docs/demo.webm`](docs/demo.webm).
 
 ## Requirements and install
 
@@ -98,49 +103,172 @@ The complete result is not copied into the parent model context. Each run is ret
 
 The task directory contains the full result, structured report, task metadata, system prompt, and persistent Pi session. Run-level metadata is stored in the parent run directory.
 
-## Personas
+## Configuration and personas
 
-The package includes `worker` (write access), `explorer` (read access), and `reviewer` (read access). Persona definitions are discovered in this order, with the first available higher-precedence definition replacing the lower one:
+Herdr Subagents loads settings and persona definitions from separate files:
 
-1. `.pi/herdr-subagents/agents/*.md` in the project
-2. `~/.pi/agent/herdr-subagents/agents/*.md` globally
-3. this package's `agents/*.md`
+| Scope | Settings | Persona definitions |
+| --- | --- | --- |
+| Project | `.pi/herdr-subagents.json` | `.pi/herdr-subagents/agents/*.md` |
+| Global | `~/.pi/agent/herdr-subagents.json` | `~/.pi/agent/herdr-subagents/agents/*.md` |
+| Package | built-in defaults | installed package `agents/*.md` |
 
-A custom persona without `access` is treated as write-capable. Definitions may set `access`, `model`, `thinking`, `tools`, and `skills` in frontmatter.
+Project JSON values recursively override global JSON values. The built-in setting defaults are `defaultConcurrency: 1`, `maxConcurrency: 4`, and `stalledWarningSeconds: 300`. `defaultModel` and `defaultThinking` are unset, so the parent Pi model and its thinking level are inherited unless another setting wins.
 
-The default `agents/worker.md` uses this format:
+### Settings file option reference
 
-```md
----
-name: worker
-description: General-purpose worker for one focused task
-tools: read, bash, edit, write, grep, find, ls
----
+These are all supported top-level fields in `herdr-subagents.json`:
 
-You are a focused worker subagent.
-```
+| Option | Accepted value | Default | Effect |
+| --- | --- | --- | --- |
+| `defaultConcurrency` | Positive integer | `1` | Number of read-only tasks allowed to run together when a batch call omits `concurrency`. It is capped to `maxConcurrency`. |
+| `maxConcurrency` | Positive integer | `4` | Hard ceiling for requested/default batch concurrency. A batch containing any write-capable persona still runs serially. |
+| `stalledWarningSeconds` | Positive integer | `300` | Seconds before a still-running child emits a warning. This is not a timeout and does not stop the child. |
+| `defaultModel` | Non-empty Pi model string, normally `provider/model` | Unset | Model used when neither JSON persona settings nor persona Markdown select one. If unset, the parent model is inherited. Use `/herdr-subagents models` to list authenticated models. |
+| `defaultThinking` | `off`, `minimal`, `low`, `medium`, `high`, `xhigh`, or `max` | Unset | Thinking level below persona-specific settings. Provider/model support can vary. If unset, parent thinking is inherited only when the parent model is also inherited. |
+| `personas` | Object keyed by an existing persona name | `{}` | Per-persona JSON overrides described below. This does not create a persona; a matching Markdown definition must exist. |
+
+Known fields with an invalid JSON type, an empty required string, or a non-positive integer are ignored with a diagnostic shown by `/herdr-subagents settings`. Model IDs, thinking-level compatibility, and skill availability are ultimately validated by Pi when the child starts. When `defaultConcurrency` exceeds `maxConcurrency`, the effective default is reduced to the maximum.
 
-Supported frontmatter:
+Each `personas.<name>` object supports exactly these overrides:
 
-- `name` and `description` are required.
-- `model` optionally selects a child model. A call-level `model` overrides it; otherwise the current session model is inherited.
-- `tools` optionally restricts built-in tools. `subagent_report` is always added so the child can settle the task.
-- `access` is `read` or `write`; omitted custom values default to `write`.
-- `thinking` and `skills` provide persona defaults.
+| Option | Accepted value | Effect |
+| --- | --- | --- |
+| `model` | Non-empty Pi model string | Overrides the model from the effective persona Markdown and `defaultModel`. |
+| `thinking` | `off`, `minimal`, `low`, `medium`, `high`, `xhigh`, or `max` | Overrides persona Markdown and `defaultThinking`. The value is passed to Pi's `--thinking` option. |
+| `skills` | Array of non-empty strings | Replaces the entire lower-precedence skill list. Use `[]` to clear inherited skills. Each item is passed to child Pi as `--skill`. |
 
-Global settings live at `~/.pi/agent/herdr-subagents.json`; project overrides live at `.pi/herdr-subagents.json`. Both support `defaultConcurrency`, `maxConcurrency`, `stalledWarningSeconds`, `defaultModel`, and a `personas` object whose entries can override `model`, `thinking`, and `skills`.
+JSON persona overrides cannot change `name`, `description`, `access`, `tools`, or the system prompt; define those in persona Markdown.
+
+A global configuration can establish shared defaults:
 
 ```json
 {
-  "defaultModel": "provider/model",
-  "maxConcurrency": 3,
+  "defaultConcurrency": 2,
+  "maxConcurrency": 4,
+  "stalledWarningSeconds": 300,
+  "defaultModel": "anthropic/claude-sonnet-4-5",
+  "defaultThinking": "medium",
   "personas": {
-    "reviewer": { "thinking": "high", "skills": ["code-review"] }
+    "explorer": {
+      "model": "anthropic/claude-haiku-4-5",
+      "thinking": "medium",
+      "skills": ["code-search"]
+    },
+    "reviewer": {
+      "thinking": "high",
+      "skills": ["code-review"]
+    }
   }
 }
 ```
 
-Project values override global values recursively. Model resolution is: task override, project persona setting, global persona setting, persona frontmatter, global/project default model, then parent model. Run `/herdr-subagents agents`, `/herdr-subagents models`, or `/herdr-subagents settings` to inspect effective values and their sources.
+The project file can override only the fields that differ. Persona fields are merged by persona name:
+
+```json
+{
+  "defaultConcurrency": 3,
+  "stalledWarningSeconds": 600,
+  "defaultThinking": "high",
+  "personas": {
+    "explorer": {
+      "model": "openai/gpt-5.2"
+    },
+    "reviewer": {
+      "skills": ["security-review", "code-review"]
+    }
+  }
+}
+```
+
+The package includes these personas:
+
+| Persona | Access | Built-in tools | Intended use |
+| --- | --- | --- | --- |
+| `worker` | write | `read`, `bash`, `edit`, `write`, `grep`, `find`, `ls` | Focused implementation work |
+| `explorer` | read | `read`, `bash`, `grep`, `find`, `ls` | Fast codebase investigation |
+| `reviewer` | read | `read`, `bash`, `grep`, `find`, `ls` | Correctness and maintainability review |
+
+Persona definitions use Markdown frontmatter followed by the child system prompt. For example, save this as `.pi/herdr-subagents/agents/security-reviewer.md`:
+
+```md
+---
+name: security-reviewer
+description: Read-only reviewer for security risks
+access: read
+model: anthropic/claude-sonnet-4-5
+thinking: high
+tools: read, bash, grep, find, ls
+skills: security-review, code-review
+---
+
+Review the assigned scope without modifying files. Report concrete risks and evidence.
+```
+
+Persona Markdown supports these frontmatter fields:
+
+| Field | Accepted value | Required/default | Effect |
+| --- | --- | --- | --- |
+| `name` | Non-empty string | Required | Persona identifier used by `agent`. Names must be unique within one persona directory. |
+| `description` | Non-empty string | Required | Description shown to the parent when agents are listed. |
+| `access` | `read` or `write` | `write` | Scheduling declaration. Any batch containing `write` is forced to concurrency one. `read` permits parallel scheduling but does not itself remove tools. |
+| `model` | Non-empty Pi model string | Unset | Persona model default. |
+| `thinking` | `off`, `minimal`, `low`, `medium`, `high`, `xhigh`, or `max` | Unset | Persona thinking default passed to Pi's `--thinking` option. |
+| `tools` | Non-empty comma-separated list, optionally bracketed | Child Pi defaults | Restricts built-in tools. Supported names are `read`, `bash`, `edit`, `write`, `grep`, `find`, `ls`, and `powershell`. `subagent_report` is always added. |
+| `skills` | Comma-separated list, optionally bracketed | None | Skills loaded explicitly into child Pi; automatic skill discovery is disabled. |
+
+The Markdown body after the frontmatter is the child system prompt and may be empty. To make a custom persona operationally read-only, set `access: read` **and** choose an appropriate `tools` allowlist; `access` alone is not a tool sandbox. Model names and skill values are passed to Pi, so they must be available in the installed Pi environment.
+
+Persona Markdown definitions use replacement precedence, not field merging. A same-name project definition replaces the entire global or package definition:
+
+1. project `.pi/herdr-subagents/agents/*.md`
+2. global `~/.pi/agent/herdr-subagents/agents/*.md`
+3. package built-ins
+
+### Model and persona-option precedence
+
+The child model is selected in this exact order:
+
+1. `model` on the task or call
+2. project `personas.<name>.model` JSON setting
+3. global `personas.<name>.model` JSON setting
+4. `model` in the effective persona Markdown frontmatter
+5. effective `defaultModel` JSON setting (project overrides global)
+6. parent Pi model
+
+The child thinking level is selected in this order:
+
+1. project `personas.<name>.thinking` JSON setting
+2. global `personas.<name>.thinking` JSON setting
+3. `thinking` in the effective persona Markdown frontmatter
+4. effective `defaultThinking` JSON setting (project overrides global)
+5. parent Pi thinking level when the child also inherits the parent model
+
+Thinking has no call-level override. `skills` uses the first three persona-level steps and has no global default; a project `skills` array replaces, rather than appends to, the global or Markdown list.
+
+Override the model for one task:
+
+```text
+herdr_subagents({
+  agent: "reviewer",
+  model: "anthropic/claude-opus-4-1:high",
+  prompt: "Review the authorization boundary"
+})
+```
+
+Each task in a batch can select its own model:
+
+```text
+herdr_subagents({
+  concurrency: 2,
+  tasks: [
+    { name: "map", agent: "explorer", model: "anthropic/claude-haiku-4-5", prompt: "Map the request flow" },
+    { name: "review", agent: "reviewer", model: "anthropic/claude-sonnet-4-5", prompt: "Review input validation" }
+  ]
+})
+```
+
+Run `/herdr-subagents agents`, `/herdr-subagents models`, or `/herdr-subagents settings` to inspect effective values and their sources.
 
 ## Recovery and failures
 

package/packages/herdr-subagents/TESTING.md

@@ -4,8 +4,9 @@
 
 1. `npm --prefix packages/herdr-subagents test` runs deterministic scheduler, recovery, and persona tests.
 2. `pi -ne -ns --no-session -e ./packages/herdr-subagents/extensions/herdr-subagents.ts` verifies extension loading.
-3. `npm pack ./packages/herdr-subagents --dry-run` verifies package contents.
-4. Verify the README example and the production-runner media `docs/screenshot.png` and `docs/demo.gif` are present in the tarball.
+3. From a visible X11 Herdr client with the GStreamer X11 and VP8 plugins installed, run `HERDR_MEDIA_WINDOW_ID=<window-id> node scripts/capture-package-media.mjs`. The Herdr capture must show a parent Pi conversation, a three-task run tab, each of the three real interactive Agent panes receiving focus in turn, and the final compact parent response.
+4. `npm pack ./packages/herdr-subagents --dry-run` verifies package contents.
+5. Verify the README renders the GitHub attachment video directly and live Herdr UI media `docs/screenshot.png` and `docs/demo.webm` are present in the tarball; `docs/demo.gif` must be absent. Inspect the WebM metadata and play it through once to confirm the parent → three focused children → parent sequence.
 
 ## Cases
 
@@ -21,4 +22,4 @@
 
 ## Latest baseline
 
-All 133 deterministic scheduler, recovery, process-boundary, schema-validation, navigation, and persona cases must pass. Release validation also requires extension loading and a real Herdr read-only batch smoke with distinct task panes and final tab cleanup. The latest smoke completed two concurrent tasks, retained its focused run tab through settlement, and closed it automatically after focus moved away.
+All 136 deterministic scheduler, recovery, process-boundary, schema-validation, navigation, and persona cases must pass. Release validation also requires extension loading and a real Herdr read-only batch smoke with distinct task panes and final tab cleanup. The latest smoke completed two concurrent tasks, retained its focused run tab through settlement, and closed it automatically after focus moved away.

package/packages/herdr-subagents/extensions/herdr-subagents.ts

@@ -92,7 +92,7 @@ async function handleHerdrCommand(args: string, ctx: ExtensionCommandContext, fl
 	}
 	if (section === "settings") {
 		const settings = configuration.settings;
-		const values: Record<string, string | number | undefined> = { defaultConcurrency: settings.defaultConcurrency, maxConcurrency: settings.maxConcurrency, stalledWarningSeconds: settings.stalledWarningSeconds, defaultModel: settings.defaultModel };
+		const values: Record<string, string | number | undefined> = { defaultConcurrency: settings.defaultConcurrency, maxConcurrency: settings.maxConcurrency, stalledWarningSeconds: settings.stalledWarningSeconds, defaultModel: settings.defaultModel, defaultThinking: settings.defaultThinking };
 		const lines = Object.entries(values).map(([key, value]) => `${key}=${String(value ?? "unset")} (${configuration.settingSources[key] ?? "built-in"})`);
 		if (configuration.diagnostics.length) lines.push("Diagnostics:", ...configuration.diagnostics);
 		ctx.ui.notify(lines.join("\n"), "info");

package/packages/herdr-subagents/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@maxiaochao/pi-herdr-subagents",
-  "version": "0.2.0",
+  "version": "0.2.1",
   "description": "Run inspectable interactive Pi subagent batches through Herdr.",
   "type": "module",
   "keywords": [

package/packages/herdr-subagents/src/config.ts

@@ -10,6 +10,7 @@ export interface SubagentConfig {
 	maxConcurrency: number;
 	stalledWarningSeconds: number;
 	defaultModel?: string;
+	defaultThinking?: string;
 	personas: Record<string, PersonaConfig>;
 }
 export interface EffectivePersona extends AgentDefinition {
@@ -33,6 +34,7 @@ interface ConfigFile {
 	maxConcurrency?: number;
 	stalledWarningSeconds?: number;
 	defaultModel?: string;
+	defaultThinking?: string;
 	personas?: Record<string, PersonaConfig>;
 }
 export interface ConfigurationPaths {
@@ -64,9 +66,11 @@ function mergeConfig(base: SubagentConfig, input: ConfigFile, source: string, so
 		result[key] = value as number;
 		sources[key] = source;
 	}
-	if (input.defaultModel !== undefined) {
-		if (typeof input.defaultModel === "string" && input.defaultModel.trim()) { result.defaultModel = input.defaultModel.trim(); sources.defaultModel = source; }
-		else diagnostics.push(`${source} defaultModel must be a non-empty string`);
+	for (const key of ["defaultModel", "defaultThinking"] as const) {
+		const value = input[key];
+		if (value === undefined) continue;
+		if (typeof value === "string" && value.trim()) { result[key] = value.trim(); sources[key] = source; }
+		else diagnostics.push(`${source} ${key} must be a non-empty string`);
 	}
 	if (input.personas !== undefined) {
 		if (!input.personas || typeof input.personas !== "object" || Array.isArray(input.personas)) diagnostics.push(`${source} personas must be an object`);
@@ -115,8 +119,8 @@ export function loadSubagentConfiguration(cwd: string, packageAgentsDirectory: s
 		const projectPersona = projectInput.personas?.[definition.name] ?? {};
 		const model = projectPersona.model ?? globalPersona.model ?? definition.model ?? settings.defaultModel ?? parentModel;
 		const modelSource = projectPersona.model ? "project persona" : globalPersona.model ? "global persona" : definition.model ? `${source} persona` : settings.defaultModel ? settingSources.defaultModel : parentModel ? "parent session" : "unresolved";
-		const thinking = projectPersona.thinking ?? globalPersona.thinking ?? definition.thinking;
-		const thinkingSource = projectPersona.thinking ? "project persona" : globalPersona.thinking ? "global persona" : definition.thinking ? `${source} persona` : "default";
+		const thinking = projectPersona.thinking ?? globalPersona.thinking ?? definition.thinking ?? settings.defaultThinking;
+		const thinkingSource = projectPersona.thinking ? "project persona" : globalPersona.thinking ? "global persona" : definition.thinking ? `${source} persona` : settings.defaultThinking ? settingSources.defaultThinking : "default";
 		const skills = projectPersona.skills ?? globalPersona.skills ?? definition.skills ?? [];
 		const skillsSource = projectPersona.skills ? "project persona" : globalPersona.skills ? "global persona" : definition.skills ? `${source} persona` : "none";
 		return { ...definition, source, access: definition.access ?? "write", model, modelSource, thinking, thinkingSource, skills, skillsSource };

package/packages/herdr-subagents/tests/run-tests.mjs

@@ -257,24 +257,30 @@ try {
 	mkdirSync(projectAgents, { recursive: true });
 	writeFileSync(join(packageAgents, "worker.md"), `---\nname: worker\ndescription: Package worker\naccess: write\nmodel: package/model\nskills: package-skill\n---\nPackage prompt.`);
 	writeFileSync(join(packageAgents, "explorer.md"), `---\nname: explorer\ndescription: Package explorer\naccess: read\n---\nExplore.`);
+	writeFileSync(join(packageAgents, "thinker.md"), `---\nname: thinker\ndescription: Package thinker\nthinking: minimal\n---\nThink.`);
 	writeFileSync(join(globalAgents, "worker.md"), `---\nname: worker\ndescription: Global worker\naccess: read\n---\nGlobal prompt.`);
 	writeFileSync(join(projectAgents, "worker.md"), `---\nname: worker\ndescription: Project worker\n---\nProject prompt.`);
 	const globalConfig = join(configRoot, "global.json");
 	const projectConfig = join(configRoot, "project.json");
-	writeFileSync(globalConfig, JSON.stringify({ maxConcurrency: 8, defaultModel: "global/default", personas: { worker: { model: "global/worker", thinking: "low", skills: ["global-skill"] } } }));
-	writeFileSync(projectConfig, JSON.stringify({ maxConcurrency: 3, personas: { worker: { model: "project/worker", thinking: "high", skills: ["project-skill"] } } }));
+	writeFileSync(globalConfig, JSON.stringify({ maxConcurrency: 8, defaultModel: "global/default", defaultThinking: "medium", personas: { worker: { model: "global/worker", thinking: "low", skills: ["global-skill"] } } }));
+	writeFileSync(projectConfig, JSON.stringify({ maxConcurrency: 3, defaultThinking: "high", personas: { worker: { model: "project/worker", thinking: "high", skills: ["project-skill"] } } }));
 	const configurationPaths = { globalConfig, projectConfig, globalAgents, projectAgents };
 	const configuration = loadSubagentConfiguration(configRoot, packageAgents, "parent/model", configurationPaths);
 	const configuredWorker = configuration.personas.find((persona) => persona.name === "worker");
 	const configuredExplorer = configuration.personas.find((persona) => persona.name === "explorer");
-	check("built-in settings recursively merge global then project", configuration.settings.defaultConcurrency === 1 && configuration.settings.maxConcurrency === 3 && configuration.settings.defaultModel === "global/default" && configuration.settingSources.maxConcurrency === "project");
+	const configuredThinker = configuration.personas.find((persona) => persona.name === "thinker");
+	check("built-in settings recursively merge global then project", configuration.settings.defaultConcurrency === 1 && configuration.settings.maxConcurrency === 3 && configuration.settings.defaultModel === "global/default" && configuration.settings.defaultThinking === "high" && configuration.settingSources.maxConcurrency === "project" && configuration.settingSources.defaultThinking === "project");
 	check("persona definitions use project global package precedence", configuredWorker?.source === "project" && configuredWorker.description === "Project worker" && configuredWorker.systemPrompt === "Project prompt." && configuredWorker.access === "write" && configuredExplorer?.source === "package" && configuredExplorer.access === "read");
 	check("persona configuration resolves model thinking and skills", configuredWorker?.model === "project/worker" && configuredWorker.modelSource === "project persona" && configuredWorker.thinking === "high" && configuredWorker.skills.join(",") === "project-skill");
-	writeFileSync(projectConfig, JSON.stringify({ personas: { worker: { model: 42, thinking: [], skills: "invalid" } } }));
+	check("project default thinking applies below persona settings", configuredExplorer?.thinking === "high" && configuredExplorer.thinkingSource === "project");
+	check("persona Markdown thinking overrides default thinking", configuredThinker?.thinking === "minimal" && configuredThinker.thinkingSource === "package persona");
+	writeFileSync(projectConfig, JSON.stringify({ defaultThinking: [], personas: { worker: { model: 42, thinking: [], skills: "invalid" } } }));
 	const invalidConfiguration = loadSubagentConfiguration(configRoot, packageAgents, "parent/model", configurationPaths);
 	const invalidWorker = invalidConfiguration.personas.find((persona) => persona.name === "worker");
 	check("invalid persona fields are diagnosed and ignored", invalidWorker?.model === "global/worker" && invalidWorker.thinking === "low" && invalidWorker.skills.join(",") === "global-skill" && invalidConfiguration.diagnostics.filter((message) => message.includes("persona 'worker'")).length === 3);
-	writeFileSync(projectConfig, JSON.stringify({ maxConcurrency: 3, personas: { worker: { model: "project/worker", thinking: "high", skills: ["project-skill"] } } }));
+	const invalidExplorer = invalidConfiguration.personas.find((persona) => persona.name === "explorer");
+	check("invalid project default thinking is diagnosed and global default remains effective", invalidExplorer?.thinking === "medium" && invalidExplorer.thinkingSource === "global" && invalidConfiguration.diagnostics.some((message) => message === "project defaultThinking must be a non-empty string"));
+	writeFileSync(projectConfig, JSON.stringify({ maxConcurrency: 3, defaultThinking: "high", personas: { worker: { model: "project/worker", thinking: "high", skills: ["project-skill"] } } }));
 	const configuredHerdr = fakeHerdr();
 	const configuredRun = await executeHerdrSubagents({ agent: "worker", model: "task/model", prompt: "Use configured values" }, undefined, undefined, { cwd: configRoot, model: { provider: "parent", id: "model" }, thinkingLevel: "medium" }, { agentsDirectory: packageAgents, configurationPaths, herdr: configuredHerdr });
 	const configuredStart = configuredHerdr.calls.find(([name]) => name === "startAgent")[1];

package/skills/calldiff/LICENSE

@@ -1,21 +0,0 @@
-MIT License
-
-Copyright (c) 2026 Tanishq Kancharla
-
-Permission is hereby granted, free of charge, to any person obtaining a copy
-of this software and associated documentation files (the "Software"), to deal
-in the Software without restriction, including without limitation the rights
-to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-copies of the Software, and to permit persons to whom the Software is
-furnished to do so, subject to the following conditions:
-
-The above copyright notice and this permission notice shall be included in all
-copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
-SOFTWARE.

package/skills/calldiff/NOTICE

@@ -1,19 +0,0 @@
-calldiff Skill
-
-This directory is copied verbatim from the calldiff repository:
-https://github.com/tanishqkancharla/calldiff
-skills/calldiff/SKILL.md at commit 2086f6e4e9ed3c410bba7c94ca3dde77791b1956 (main)
-
-The upstream repository is licensed under the MIT License. A copy of that
-license is included in LICENSE.
-
-Upstream publishes no release tags, so this file is pinned to a main commit
-instead of a tag. The CLI can also write its own copy with `calldiff skills
-add` (to ~/.agents/skills/calldiff/SKILL.md), but that generated file is terser
-than the committed one — it leaves the --entry/--file descriptions empty and
-says 22 languages — so pi-toolkit ships the committed file.
-
-To refresh, copy skills/calldiff/SKILL.md and LICENSE from a newer upstream
-commit and update the commit above. The bundled commands were smoke-tested
-against calldiff 0.5.0 (`diff`, `tree`, `reach`, `--entry`, `--file`,
-`--maxDepth`/`--max-depth`, `--locs`, `--format json`).

package/skills/calldiff/SKILL.md

@@ -1,121 +0,0 @@
----
-name: calldiff
-description: Diff call stacks across git commits — like git diff, but for who-calls-whom. Shows which callees appeared, disappeared, or moved under an entrypoint across 23 languages (diff, tree, and reach). Use for agentic code review when call flow changed and line diffs bury the shape of the change.
-requires_bin: calldiff
-command: calldiff
----
-
-# calldiff diff
-
-Diff call stacks between two git trees
-
-## Arguments
-
-| Name | Type | Required | Description |
-|------|------|----------|-------------|
-| `from` | `string` | no | Before ref (default: HEAD) |
-| `to` | `string` | no | After ref (default: working tree) |
-| `paths` | `array` | no | Limit to these path prefixes |
-
-## Options
-
-| Flag | Type | Default | Description |
-|------|------|---------|-------------|
-| `--entry` | `unknown` |  | Entrypoint symbol(s): functionName or ClassName.method |
-| `--file` | `unknown` |  | Entrypoint file(s): indexed source path; expands to that file's exports |
-| `--maxDepth` | `number` | `12` | Max call-tree depth |
-| `--locs` | `boolean` | `false` | Show call-site source locations (file:line) |
-| `--from` | `string` |  | Left / "before" tree |
-| `--to` | `string` |  | Right / "after" tree |
-
-## Examples
-
-```sh
-# HEAD vs working tree
-calldiff diff
-
-# One ref vs working tree
-calldiff diff main
-
-# Two commits / branches
-calldiff diff abc123 def456
-
-# Force entrypoints
-calldiff diff main feature --entry createAgentSession
-
-# File expands to that file's exports
-calldiff diff main feature --file src/routes.ts
-```
-
-> Semantics match git diff: no refs → HEAD vs worktree; one ref → that vs worktree; two refs → compare those trees.
-
----
-
-# calldiff reach
-
-Find all call paths from an entrypoint to a target symbol
-
-## Arguments
-
-| Name | Type | Required | Description |
-|------|------|----------|-------------|
-| `ref` | `string` | no | Git ref (default: working tree) |
-| `paths` | `array` | no | Limit to these path prefixes |
-
-## Options
-
-| Flag | Type | Default | Description |
-|------|------|---------|-------------|
-| `--entry` | `unknown` |  | Entrypoint symbol(s): functionName or ClassName.method |
-| `--file` | `unknown` |  | Entrypoint file(s): indexed source path; expands to that file's exports |
-| `--to` | `string` |  | Target symbol to reach (functionName or ClassName.method) |
-| `--maxDepth` | `number` | `12` | Max call-tree depth |
-| `--locs` | `boolean` | `false` | Show call-site source locations (file:line) |
-
-## Examples
-
-```sh
-# Paths in the working tree
-calldiff reach --entry runCheckout --to sendEmail
-
-# Paths at a commit, limited to a directory
-calldiff reach HEAD examples/checkout --entry runCheckout --to sendEmail
-
-# Paths from every export in a file
-calldiff reach --file packages/api/src/flow.ts --to notify
-```
-
----
-
-# calldiff tree
-
-View a call tree (no diff) for one or more entrypoints
-
-## Arguments
-
-| Name | Type | Required | Description |
-|------|------|----------|-------------|
-| `ref` | `string` | no | Git ref (default: working tree) |
-| `paths` | `array` | no | Limit to these path prefixes |
-
-## Options
-
-| Flag | Type | Default | Description |
-|------|------|---------|-------------|
-| `--entry` | `unknown` |  | Entrypoint symbol(s): functionName or ClassName.method |
-| `--file` | `unknown` |  | Entrypoint file(s): indexed source path; expands to that file's exports |
-| `--maxDepth` | `number` | `12` | Max call-tree depth |
-| `--locs` | `boolean` | `false` | Show call-site source locations (file:line) |
-
-## Examples
-
-```sh
-# Tree from working tree
-calldiff tree --entry createAgentSession
-
-# Tree from a commit
-calldiff tree HEAD --entry PiService.createAgentSession
-
-# Every export in a file
-calldiff tree --file packages/api/src/routes.ts
-```