@mavogel/awscdk-rootmail 0.1.22 → 0.1.23

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (53) hide show
  1. package/.jsii +3 -3
  2. package/lib/rootmail.js +1 -1
  3. package/lib/ses-receive.js +1 -1
  4. package/node_modules/@zone-eu/mailsplit/lib/headers.js +15 -4
  5. package/node_modules/@zone-eu/mailsplit/lib/message-splitter.js +34 -23
  6. package/node_modules/@zone-eu/mailsplit/lib/mime-node.js +61 -5
  7. package/node_modules/@zone-eu/mailsplit/package.json +3 -3
  8. package/node_modules/libmime/CHANGELOG.md +8 -0
  9. package/node_modules/libmime/lib/charset.js +14 -2
  10. package/node_modules/libmime/lib/libmime.js +30 -6
  11. package/node_modules/libmime/package.json +2 -2
  12. package/node_modules/libqp/.github/VULNERABILITY_REPORT.yml +75 -0
  13. package/node_modules/libqp/CHANGELOG.md +7 -0
  14. package/node_modules/libqp/SECURITY.md +147 -0
  15. package/node_modules/libqp/lib/libqp.js +96 -24
  16. package/node_modules/libqp/package.json +1 -1
  17. package/node_modules/libqp/test/libqp-test.js +108 -0
  18. package/node_modules/mailparser/.release-please-manifest.json +1 -1
  19. package/node_modules/mailparser/CHANGELOG.md +9 -0
  20. package/node_modules/mailparser/README.md +2 -1
  21. package/node_modules/mailparser/lib/mail-parser.js +160 -65
  22. package/node_modules/mailparser/lib/simple-parser.js +3 -3
  23. package/node_modules/mailparser/package.json +4 -4
  24. package/node_modules/nodemailer/CHANGELOG.md +7 -0
  25. package/node_modules/nodemailer/dist/cjs/dkim/index.js +3 -2
  26. package/node_modules/nodemailer/dist/cjs/fetch/index.d.ts +5 -0
  27. package/node_modules/nodemailer/dist/cjs/fetch/index.js +30 -0
  28. package/node_modules/nodemailer/dist/cjs/mailer/index.js +4 -1
  29. package/node_modules/nodemailer/dist/cjs/mailer/mail-message.d.ts +5 -1
  30. package/node_modules/nodemailer/dist/cjs/mime-funcs/index.js +25 -13
  31. package/node_modules/nodemailer/dist/cjs/mime-node/index.js +49 -6
  32. package/node_modules/nodemailer/dist/cjs/package-info.d.ts +1 -1
  33. package/node_modules/nodemailer/dist/cjs/package-info.js +1 -1
  34. package/node_modules/nodemailer/dist/cjs/smtp-connection/index.js +16 -1
  35. package/node_modules/nodemailer/dist/cjs/smtp-transport/index.js +12 -1
  36. package/node_modules/nodemailer/dist/cjs/well-known/services.js +7 -0
  37. package/node_modules/nodemailer/dist/cjs/xoauth2/index.js +8 -2
  38. package/node_modules/nodemailer/dist/esm/dkim/index.js +3 -2
  39. package/node_modules/nodemailer/dist/esm/fetch/index.d.ts +5 -0
  40. package/node_modules/nodemailer/dist/esm/fetch/index.js +30 -0
  41. package/node_modules/nodemailer/dist/esm/mailer/index.js +4 -1
  42. package/node_modules/nodemailer/dist/esm/mailer/mail-message.d.ts +5 -1
  43. package/node_modules/nodemailer/dist/esm/mime-funcs/index.js +25 -13
  44. package/node_modules/nodemailer/dist/esm/mime-node/index.js +49 -6
  45. package/node_modules/nodemailer/dist/esm/package-info.d.ts +1 -1
  46. package/node_modules/nodemailer/dist/esm/package-info.js +1 -1
  47. package/node_modules/nodemailer/dist/esm/smtp-connection/index.js +16 -1
  48. package/node_modules/nodemailer/dist/esm/smtp-transport/index.js +12 -1
  49. package/node_modules/nodemailer/dist/esm/well-known/services.js +7 -0
  50. package/node_modules/nodemailer/dist/esm/xoauth2/index.js +8 -2
  51. package/node_modules/nodemailer/dist/well-known/services.json +8 -0
  52. package/node_modules/nodemailer/package.json +1 -1
  53. package/package.json +2 -2
@@ -71,6 +71,13 @@ const PLAIN_ADDRESS = /^[^\s"(),:;<>@[\\\]]+@[^\s"(),:;<>@[\\\]]+$/;
71
71
  // unroutable garbage into mail for a domain the sender never named. None of these
72
72
  // characters are legal in a domain, so keep them away from the mapper.
73
73
  const URL_PARSER_UNSAFE = /[/\\?#%\x00-\x20\x7F]/;
74
+ // RFC 1035 bounds a label at 63 octets and a domain at 253. An A-label is never shorter than
75
+ // the code points it encodes, so anything past these bounds could not have become a valid
76
+ // domain whichever way it is encoded. The bundled codec is super-linear in the length of a
77
+ // label, a 60 KB label of distinct code points took seconds to encode, several times per
78
+ // address, so it is only handed what could be a domain
79
+ const MAX_DOMAIN_LENGTH = 253;
80
+ const MAX_LABEL_LENGTH = 63;
74
81
  // pipeline() needs a callback to not throw, the errors it sees reach the last stream anyway
75
82
  const PIPELINE_NOOP = () => false;
76
83
  // The error a node streaming into an output that was destroyed stops with
@@ -79,6 +86,27 @@ function abortedError() {
79
86
  err.code = errors.ESTREAM;
80
87
  return err;
81
88
  }
89
+ /**
90
+ * Checks a domain against the DNS length limits, counted in code points per label and in
91
+ * total. The label separators are the ones the bundled codec splits on.
92
+ *
93
+ * @param domain Domain to check
94
+ * @return true if a label or the domain as a whole is too long to be a valid domain
95
+ */
96
+ function exceedsDomainLimits(domain) {
97
+ let total = 0;
98
+ let label = 0;
99
+ for (const char of domain) {
100
+ total++;
101
+ if (char === '.' || char === '。' || char === '.' || char === '。') {
102
+ label = 0;
103
+ }
104
+ else if (++label > MAX_LABEL_LENGTH) {
105
+ return true;
106
+ }
107
+ }
108
+ return total > MAX_DOMAIN_LENGTH;
109
+ }
82
110
  /**
83
111
  * Encodes a domain the way browsers, the WHATWG URL Standard and DNS facing resolvers do,
84
112
  * which is with UTS-46 mapping applied before the Punycode step.
@@ -110,6 +138,10 @@ function normalizeDomain(domain, toUnicode) {
110
138
  return mapped;
111
139
  }
112
140
  }
141
+ if (exceedsDomainLimits(domain)) {
142
+ // too long to be a domain whichever way it is encoded, keep it as supplied
143
+ return domain;
144
+ }
113
145
  return toUnicode ? punycode.toUnicode(domain) : punycode.toASCII(domain);
114
146
  }
115
147
  /**
@@ -614,6 +646,17 @@ class MimeNode {
614
646
  /[\u0080-\uFFFF]/.test(this.content)) {
615
647
  structured.params.charset = 'utf-8';
616
648
  }
649
+ if (this.filename) {
650
+ // the name parameter is derived from the filename below, so a name that
651
+ // arrived inside the content type is dropped first (a plain parameter or
652
+ // rfc2231 continuation sections), otherwise the header carries two and a
653
+ // receiver that reads the first sees a name the filename does not match
654
+ for (const paramKey of Object.keys(structured.params)) {
655
+ if (/^name(\*|$)/i.test(paramKey)) {
656
+ delete structured.params[paramKey];
657
+ }
658
+ }
659
+ }
617
660
  value = mimeFuncs.buildHeaderValue(structured);
618
661
  if (this.filename) {
619
662
  // add support for non-compliant clients like QQ webmail
@@ -1223,12 +1266,12 @@ class MimeNode {
1223
1266
  _normalizeHeaderKey(key) {
1224
1267
  key = (key || '')
1225
1268
  .toString()
1226
- // no newlines in keys
1227
- .replace(/\r?\n|\r/g, ' ')
1228
- // a field name is printable ascii without the colon, so a control char or DEL
1229
- // can only be dropped, there is no quoting construct around a field name
1230
- .replace(/[\x00-\x1f\x7f]/g, '')
1231
- .trim()
1269
+ // a field name is printable ascii without the colon, so a control char, DEL,
1270
+ // whitespace or a colon can only be dropped, there is no quoting construct
1271
+ // around a field name. A colon or a space left in place ends the name early on
1272
+ // the wire: the key 'From: ceo@example.com (' with the value ')' was emitted as a
1273
+ // second From header that neither setHeader() nor the Bcc filter could match
1274
+ .replace(/[\s\x00-\x20\x7f:]/g, '')
1232
1275
  .toLowerCase()
1233
1276
  // use uppercase words, except MIME
1234
1277
  .replace(/^X-SMTPAPI$|^(MIME|DKIM|ARC|BIMI)\b|^[a-z]|-(SPF|FBL|ID|MD5)$|-[a-z]/gi, c => c.toUpperCase())
@@ -1,3 +1,3 @@
1
1
  export declare const name = "nodemailer";
2
- export declare const version = "10.1.1";
2
+ export declare const version = "10.1.2";
3
3
  export declare const homepage = "https://nodemailer.com/";
@@ -3,5 +3,5 @@
3
3
  Object.defineProperty(exports, "__esModule", { value: true });
4
4
  exports.homepage = exports.version = exports.name = void 0;
5
5
  exports.name = 'nodemailer';
6
- exports.version = '10.1.1';
6
+ exports.version = '10.1.2';
7
7
  exports.homepage = 'https://nodemailer.com/';
@@ -114,6 +114,21 @@ function isPartialResponse(str) {
114
114
  function isPartialLine(line) {
115
115
  return /^\d+-/.test(line);
116
116
  }
117
+ /**
118
+ * The log form of a command a custom authentication handler sends. Such a command carries
119
+ * the credentials in whatever shape its mechanism uses, so only an AUTH verb with its
120
+ * mechanism name is kept, the way the built-in mechanisms hide their own secrets.
121
+ *
122
+ * @param cmd Command the handler sends
123
+ * @return What the transaction log gets instead
124
+ */
125
+ function maskAuthCommand(cmd) {
126
+ const match = (cmd || '').toString().match(/^AUTH\s+[^\s]+/i);
127
+ if (!match) {
128
+ return '/* secret */';
129
+ }
130
+ return match[0].length === cmd.length ? cmd : match[0] + ' /* secret */';
131
+ }
117
132
  /**
118
133
  * Generates a SMTP connection object
119
134
  *
@@ -601,7 +616,7 @@ class SMTPConnection extends node_events_1.EventEmitter {
601
616
  }
602
617
  done(null, data);
603
618
  });
604
- setImmediate(() => this._sendCommand(cmd));
619
+ setImmediate(() => this._sendCommand(cmd, maskAuthCommand(cmd)));
605
620
  return promise;
606
621
  };
607
622
  const handlerResponse = handler({
@@ -43,6 +43,13 @@ const shared = __importStar(require("../shared/index.js"));
43
43
  const index_js_3 = __importDefault(require("../xoauth2/index.js"));
44
44
  const errors = __importStar(require("../errors.js"));
45
45
  const packageData = __importStar(require("../package-info.js"));
46
+ // The keys a message's `auth` may set on top of the transport's auth settings: the ones that
47
+ // say who logs in and with what. Everything else in the auth block (accessUrl, clientId,
48
+ // clientSecret, customHeaders, customParams, tls, privateKey, serviceClient and the rest)
49
+ // names the endpoint the credentials go to or is a secret of the application itself, and
50
+ // a message that could set `auth.accessUrl` and force a refresh would have the transport's
51
+ // client secret and refresh token posted to a URL of its choosing
52
+ const MESSAGE_AUTH_KEYS = ['type', 'user', 'pass', 'accessToken', 'refreshToken', 'expires'];
46
53
  /**
47
54
  * Creates a SMTP transport object for Nodemailer
48
55
  *
@@ -102,7 +109,11 @@ class SMTPTransport extends node_events_1.EventEmitter {
102
109
  }
103
110
  return this.auth;
104
111
  }
105
- const authData = Object.assign({}, this.options.auth && typeof this.options.auth === 'object' ? this.options.auth : {}, typeof authOpts === 'object' ? authOpts : {});
112
+ const authData = Object.assign({}, this.options.auth && typeof this.options.auth === 'object' ? this.options.auth : {});
113
+ if (typeof authOpts === 'object') {
114
+ // see MESSAGE_AUTH_KEYS
115
+ shared.copyOwnKeys(authData, authOpts, key => !MESSAGE_AUTH_KEYS.includes(key));
116
+ }
106
117
  if (Object.keys(authData).length === 0) {
107
118
  return false;
108
119
  }
@@ -363,6 +363,13 @@ exports.services = {
363
363
  "port": 587,
364
364
  "secure": false
365
365
  },
366
+ "Oveyon": {
367
+ "description": "Oveyon",
368
+ "host": "smtp.oveyon.com",
369
+ "port": 587,
370
+ "secure": false,
371
+ "requireTLS": true
372
+ },
366
373
  "Postmark": {
367
374
  "description": "Postmark",
368
375
  "aliases": [
@@ -264,8 +264,14 @@ class XOAuth2 extends node_stream_1.Stream {
264
264
  grant_type: 'refresh_token'
265
265
  };
266
266
  }
267
- Object.assign(urlOptions, this.options.customParams);
268
- Object.assign(loggedUrlOptions, this.options.customParams);
267
+ const customParams = this.options.customParams || {};
268
+ Object.assign(urlOptions, customParams);
269
+ // a custom param is as likely to be a client assertion or an API key as a tenant
270
+ // name, so the log gets the same glimpse of it that it gets of the client secret
271
+ for (const key of Object.keys(customParams)) {
272
+ const param = customParams[key];
273
+ loggedUrlOptions[key] = (param === undefined || param === null ? '' : String(param)).substr(0, 6) + '...';
274
+ }
269
275
  this.logger.debug({
270
276
  tnx: 'OAUTH2',
271
277
  user: this.options.user,
@@ -128,8 +128,9 @@ class DKIMSigner {
128
128
  }
129
129
  createWriteCache() {
130
130
  this.output.usingCache = true;
131
- // pipe remainings to cache file
132
- this.cache = fs.createWriteStream(this.cachePath);
131
+ // pipe remainings to cache file. It holds the message body and cacheDir is often a
132
+ // shared directory such as /tmp, so nobody but the owner gets to read it
133
+ this.cache = fs.createWriteStream(this.cachePath, { mode: 0o600 });
133
134
  this.cache.once('error', err => {
134
135
  // drain input
135
136
  this.relaxedBody.unpipe(this.cache);
@@ -27,6 +27,8 @@ export interface FetchOptions {
27
27
  } | undefined;
28
28
  /** Socket inactivity timeout in milliseconds, defaults to 60000, 0 disables it */
29
29
  timeout?: number | undefined;
30
+ /** Time limit for the whole request in milliseconds, redirects included, defaults to 120000, 0 disables it */
31
+ maxTime?: number | undefined;
30
32
  /** Maximum size of the (decoded) response body in bytes, defaults to 64 MB, Infinity disables the limit */
31
33
  maxBytes?: number | undefined;
32
34
  /** Maximum number of redirects to follow (default 5) */
@@ -37,6 +39,8 @@ export interface FetchOptions {
37
39
  redirects?: number | undefined;
38
40
  /** Response stream shared across redirects, set by nmfetch itself */
39
41
  fetchRes?: FetchResponse | undefined;
42
+ /** Timestamp the whole request has to be done by, shared across redirects, set by nmfetch itself */
43
+ deadline?: number | undefined;
40
44
  }
41
45
  /**
42
46
  * The stream nmfetch returns. The response body is piped into it, the status code and
@@ -50,6 +54,7 @@ declare function nmfetch(url: string, options?: FetchOptions): FetchResponse;
50
54
  declare namespace nmfetch {
51
55
  var Cookies: typeof import("./cookies.js").default;
52
56
  var DEFAULT_TIMEOUT: number;
57
+ var DEFAULT_MAX_TIME: number;
53
58
  }
54
59
  type CookiesJar = Cookies;
55
60
  /**
@@ -11,6 +11,10 @@ import { isProtoKey } from '../shared/objects.js';
11
11
  const MAX_REDIRECTS = 5;
12
12
  // a stalled server would otherwise hold the request, and whatever waits on it, open forever
13
13
  const DEFAULT_TIMEOUT = 60 * 1000;
14
+ // the inactivity timeout above is reset by every byte, so a server dripping one within each
15
+ // window could still hold the request, and the message being built from it, open for as
16
+ // long as it liked. The whole request, redirects included, has to be done within this
17
+ const DEFAULT_MAX_TIME = 2 * 60 * 1000;
14
18
  // the body is usually buffered in memory by the caller, so an unbounded download is refused
15
19
  const DEFAULT_MAX_BYTES = 64 * 1024 * 1024;
16
20
  // Only genuine TLS settings are taken from options.tls. That object reaches us straight
@@ -88,6 +92,12 @@ function nmfetch(url, options) {
88
92
  options.cookies = options.cookies || new Cookies();
89
93
  options.redirects = options.redirects || 0;
90
94
  options.maxRedirects = isNaN(options.maxRedirects) ? MAX_REDIRECTS : options.maxRedirects;
95
+ if (!options.deadline) {
96
+ options.maxTime = typeof options.maxTime === 'number' && options.maxTime >= 0 ? options.maxTime : DEFAULT_MAX_TIME;
97
+ // the one deadline is shared with the requests the redirects lead to, every hop
98
+ // gets the time that is left rather than starting over
99
+ options.deadline = options.maxTime ? Date.now() + options.maxTime : 0;
100
+ }
91
101
  const fetchRes = options.fetchRes;
92
102
  const parsed = parseFetchUrl(url);
93
103
  if (!parsed) {
@@ -233,12 +243,22 @@ function nmfetch(url, options) {
233
243
  });
234
244
  return fetchRes;
235
245
  }
246
+ // the whole request has to be done by options.deadline, see maxTime. The timer is
247
+ // released on every way out of the request, so it never outlives it
248
+ let deadlineTimer;
249
+ const clearDeadline = () => {
250
+ if (deadlineTimer) {
251
+ clearTimeout(deadlineTimer);
252
+ deadlineTimer = undefined;
253
+ }
254
+ };
236
255
  // reports the first failure of this request on fetchRes and releases the request
237
256
  const fail = (err, sourceUrl = url) => {
238
257
  if (finished) {
239
258
  return;
240
259
  }
241
260
  finished = true;
261
+ clearDeadline();
242
262
  setFetchCode(err);
243
263
  err.sourceUrl = sourceUrl;
244
264
  fetchRes.emit('error', err);
@@ -248,10 +268,16 @@ function nmfetch(url, options) {
248
268
  if (timeout) {
249
269
  req.setTimeout(timeout, () => fail(new Error('Request Timeout')));
250
270
  }
271
+ if (options.deadline) {
272
+ deadlineTimer = setTimeout(() => fail(new Error('Request exceeded the allowed ' + options.maxTime + ' ms')), Math.max(options.deadline - Date.now(), 1));
273
+ // a pending deadline is no reason to keep the process alive
274
+ deadlineTimer.unref();
275
+ }
251
276
  req.on('error', (err) => fail(err));
252
277
  // a consumer that destroys the response stream before it ended does not want the rest of
253
278
  // the body, release the request now instead of when the timeout fires
254
279
  fetchRes.once('close', () => {
280
+ clearDeadline();
255
281
  if (finished || fetchRes.readableEnded) {
256
282
  return;
257
283
  }
@@ -320,6 +346,7 @@ function nmfetch(url, options) {
320
346
  // this request is done with, release it so its socket and timeout do not
321
347
  // outlive it and report a late error on the shared fetchRes
322
348
  finished = true;
349
+ clearDeadline();
323
350
  res.resume();
324
351
  req.abort();
325
352
  return nmfetch(redirectUrl, options);
@@ -330,6 +357,8 @@ function nmfetch(url, options) {
330
357
  return fail(new Error('Invalid status code ' + res.statusCode));
331
358
  }
332
359
  res.on('error', (err) => fail(err));
360
+ // the response is in, whatever is left of it is in memory and no longer on the network
361
+ res.once('end', () => clearDeadline());
333
362
  const maxBytes = typeof options.maxBytes === 'number' && options.maxBytes > 0 ? options.maxBytes : DEFAULT_MAX_BYTES;
334
363
  const source = inflate || res;
335
364
  let received = 0;
@@ -367,4 +396,5 @@ function nmfetch(url, options) {
367
396
  }
368
397
  nmfetch.Cookies = Cookies;
369
398
  nmfetch.DEFAULT_TIMEOUT = DEFAULT_TIMEOUT;
399
+ nmfetch.DEFAULT_MAX_TIME = DEFAULT_MAX_TIME;
370
400
  export default nmfetch;
@@ -360,9 +360,12 @@ class Mail extends EventEmitter {
360
360
  return callback(err);
361
361
  }
362
362
  let cidCounter = 0;
363
+ // the media type is a bounded token: a quote, whitespace, '>' or '<' ends the
364
+ // attribute value and with it the type, so one img tag never scans ahead to a
365
+ // ';' that belongs to a later tag, which was quadratic
363
366
  html = (html || '')
364
367
  .toString()
365
- .replace(/(<img\b[^<>]{0,1024} src\s{0,20}=[\s"']{0,20})(data:([^;]+);[^"'>\s]+)/gi, (match, prefix, dataUri, mimeType) => {
368
+ .replace(/(<img\b[^<>]{0,1024} src\s{0,20}=[\s"']{0,20})(data:([^;"'<>\s]{1,255});[^"'>\s]+)/gi, (match, prefix, dataUri, mimeType) => {
366
369
  const cid = crypto.randomBytes(10).toString('hex') + '@localhost';
367
370
  if (!mail.data.attachments) {
368
371
  mail.data.attachments = [];
@@ -23,7 +23,11 @@ export interface SendMailOptions extends MailComposerOptions {
23
23
  dsn?: SMTPEnvelopeDsn | undefined;
24
24
  /** SMTP transports: RFC 8689, send the REQUIRETLS parameter with MAIL FROM */
25
25
  requireTLSExtensionEnabled?: boolean | undefined;
26
- /** SMTP transports: per-message authentication settings, used instead of the transport level auth */
26
+ /**
27
+ * SMTP transports: per-message authentication settings, used instead of the transport level auth.
28
+ * Only the credential fields are taken from it (type, user, pass, accessToken, refreshToken, expires),
29
+ * the token endpoint and client settings stay those of the transport
30
+ */
27
31
  auth?: SMTPTransportAuthOptions | undefined;
28
32
  /** SES transport: extra SendEmailCommand parameters merged into the API call */
29
33
  ses?: SESSendEmailRequest | undefined;
@@ -137,26 +137,38 @@ export function encodeWord(data, mimeWordEncoding, maxLength) {
137
137
  */
138
138
  export function encodeWords(value, mimeWordEncoding, maxLength, encodeAll) {
139
139
  maxLength = maxLength || 0;
140
- // find first word with a non-printable ascii or special symbol in it
141
- const firstMatch = value.match(/(?:^|\s)([^\s]*["\u0080-\uFFFF])/);
142
- if (!firstMatch) {
140
+ // find the first and the last character that needs encoding, a quote or anything outside
141
+ // printable ascii. A scan rather than a regex: matching the last such word with a
142
+ // backtracking pattern took quadratic time on a long word of non-ascii characters
143
+ let firstSpecial = -1;
144
+ let lastSpecial = -1;
145
+ for (let i = 0; i < value.length; i++) {
146
+ const code = value.charCodeAt(i);
147
+ if (code === 0x22 || code >= 0x80) {
148
+ if (firstSpecial < 0) {
149
+ firstSpecial = i;
150
+ }
151
+ lastSpecial = i;
152
+ }
153
+ }
154
+ if (firstSpecial < 0) {
143
155
  return value;
144
156
  }
145
157
  if (encodeAll) {
146
158
  // if it is requested to encode everything or the string contains something that resebles encoded word, then encode everything
147
159
  return encodeWord(value, mimeWordEncoding, maxLength);
148
160
  }
149
- // find the last word with a non-printable ascii in it
150
- const lastMatch = value.match(/(["\u0080-\uFFFF][^\s]*)[^"\u0080-\uFFFF]*$/);
151
- if (!lastMatch) {
152
- // should not happen
153
- return value;
161
+ // encode from the start of the word holding the first such character to the end of the
162
+ // word holding the last one, so the encoded words stay separated from the plain text by
163
+ // the whitespace that was already there
164
+ let startIndex = firstSpecial;
165
+ while (startIndex > 0 && !/\s/.test(value.charAt(startIndex - 1))) {
166
+ startIndex--;
167
+ }
168
+ let endIndex = lastSpecial + 1;
169
+ while (endIndex < value.length && !/\s/.test(value.charAt(endIndex))) {
170
+ endIndex++;
154
171
  }
155
- const startIndex = firstMatch.index +
156
- (firstMatch[0].match(/[^\s]/) || {
157
- index: 0
158
- }).index;
159
- const endIndex = lastMatch.index + (lastMatch[1] || '').length;
160
172
  return ((startIndex ? value.substr(0, startIndex) : '') +
161
173
  encodeWord(value.substring(startIndex, endIndex), mimeWordEncoding || 'Q', maxLength) +
162
174
  (endIndex < value.length ? value.substr(endIndex) : ''));
@@ -33,6 +33,13 @@ const PLAIN_ADDRESS = /^[^\s"(),:;<>@[\\\]]+@[^\s"(),:;<>@[\\\]]+$/;
33
33
  // unroutable garbage into mail for a domain the sender never named. None of these
34
34
  // characters are legal in a domain, so keep them away from the mapper.
35
35
  const URL_PARSER_UNSAFE = /[/\\?#%\x00-\x20\x7F]/;
36
+ // RFC 1035 bounds a label at 63 octets and a domain at 253. An A-label is never shorter than
37
+ // the code points it encodes, so anything past these bounds could not have become a valid
38
+ // domain whichever way it is encoded. The bundled codec is super-linear in the length of a
39
+ // label, a 60 KB label of distinct code points took seconds to encode, several times per
40
+ // address, so it is only handed what could be a domain
41
+ const MAX_DOMAIN_LENGTH = 253;
42
+ const MAX_LABEL_LENGTH = 63;
36
43
  // pipeline() needs a callback to not throw, the errors it sees reach the last stream anyway
37
44
  const PIPELINE_NOOP = () => false;
38
45
  // The error a node streaming into an output that was destroyed stops with
@@ -41,6 +48,27 @@ function abortedError() {
41
48
  err.code = errors.ESTREAM;
42
49
  return err;
43
50
  }
51
+ /**
52
+ * Checks a domain against the DNS length limits, counted in code points per label and in
53
+ * total. The label separators are the ones the bundled codec splits on.
54
+ *
55
+ * @param domain Domain to check
56
+ * @return true if a label or the domain as a whole is too long to be a valid domain
57
+ */
58
+ function exceedsDomainLimits(domain) {
59
+ let total = 0;
60
+ let label = 0;
61
+ for (const char of domain) {
62
+ total++;
63
+ if (char === '.' || char === '。' || char === '.' || char === '。') {
64
+ label = 0;
65
+ }
66
+ else if (++label > MAX_LABEL_LENGTH) {
67
+ return true;
68
+ }
69
+ }
70
+ return total > MAX_DOMAIN_LENGTH;
71
+ }
44
72
  /**
45
73
  * Encodes a domain the way browsers, the WHATWG URL Standard and DNS facing resolvers do,
46
74
  * which is with UTS-46 mapping applied before the Punycode step.
@@ -72,6 +100,10 @@ function normalizeDomain(domain, toUnicode) {
72
100
  return mapped;
73
101
  }
74
102
  }
103
+ if (exceedsDomainLimits(domain)) {
104
+ // too long to be a domain whichever way it is encoded, keep it as supplied
105
+ return domain;
106
+ }
75
107
  return toUnicode ? punycode.toUnicode(domain) : punycode.toASCII(domain);
76
108
  }
77
109
  /**
@@ -576,6 +608,17 @@ class MimeNode {
576
608
  /[\u0080-\uFFFF]/.test(this.content)) {
577
609
  structured.params.charset = 'utf-8';
578
610
  }
611
+ if (this.filename) {
612
+ // the name parameter is derived from the filename below, so a name that
613
+ // arrived inside the content type is dropped first (a plain parameter or
614
+ // rfc2231 continuation sections), otherwise the header carries two and a
615
+ // receiver that reads the first sees a name the filename does not match
616
+ for (const paramKey of Object.keys(structured.params)) {
617
+ if (/^name(\*|$)/i.test(paramKey)) {
618
+ delete structured.params[paramKey];
619
+ }
620
+ }
621
+ }
579
622
  value = mimeFuncs.buildHeaderValue(structured);
580
623
  if (this.filename) {
581
624
  // add support for non-compliant clients like QQ webmail
@@ -1185,12 +1228,12 @@ class MimeNode {
1185
1228
  _normalizeHeaderKey(key) {
1186
1229
  key = (key || '')
1187
1230
  .toString()
1188
- // no newlines in keys
1189
- .replace(/\r?\n|\r/g, ' ')
1190
- // a field name is printable ascii without the colon, so a control char or DEL
1191
- // can only be dropped, there is no quoting construct around a field name
1192
- .replace(/[\x00-\x1f\x7f]/g, '')
1193
- .trim()
1231
+ // a field name is printable ascii without the colon, so a control char, DEL,
1232
+ // whitespace or a colon can only be dropped, there is no quoting construct
1233
+ // around a field name. A colon or a space left in place ends the name early on
1234
+ // the wire: the key 'From: ceo@example.com (' with the value ')' was emitted as a
1235
+ // second From header that neither setHeader() nor the Bcc filter could match
1236
+ .replace(/[\s\x00-\x20\x7f:]/g, '')
1194
1237
  .toLowerCase()
1195
1238
  // use uppercase words, except MIME
1196
1239
  .replace(/^X-SMTPAPI$|^(MIME|DKIM|ARC|BIMI)\b|^[a-z]|-(SPF|FBL|ID|MD5)$|-[a-z]/gi, c => c.toUpperCase())
@@ -1,3 +1,3 @@
1
1
  export declare const name = "nodemailer";
2
- export declare const version = "10.1.1";
2
+ export declare const version = "10.1.2";
3
3
  export declare const homepage = "https://nodemailer.com/";
@@ -1,4 +1,4 @@
1
1
  // Generated by scripts/build.js from package.json. Do not edit by hand.
2
2
  export const name = 'nodemailer';
3
- export const version = '10.1.1';
3
+ export const version = '10.1.2';
4
4
  export const homepage = 'https://nodemailer.com/';
@@ -76,6 +76,21 @@ function isPartialResponse(str) {
76
76
  function isPartialLine(line) {
77
77
  return /^\d+-/.test(line);
78
78
  }
79
+ /**
80
+ * The log form of a command a custom authentication handler sends. Such a command carries
81
+ * the credentials in whatever shape its mechanism uses, so only an AUTH verb with its
82
+ * mechanism name is kept, the way the built-in mechanisms hide their own secrets.
83
+ *
84
+ * @param cmd Command the handler sends
85
+ * @return What the transaction log gets instead
86
+ */
87
+ function maskAuthCommand(cmd) {
88
+ const match = (cmd || '').toString().match(/^AUTH\s+[^\s]+/i);
89
+ if (!match) {
90
+ return '/* secret */';
91
+ }
92
+ return match[0].length === cmd.length ? cmd : match[0] + ' /* secret */';
93
+ }
79
94
  /**
80
95
  * Generates a SMTP connection object
81
96
  *
@@ -563,7 +578,7 @@ class SMTPConnection extends EventEmitter {
563
578
  }
564
579
  done(null, data);
565
580
  });
566
- setImmediate(() => this._sendCommand(cmd));
581
+ setImmediate(() => this._sendCommand(cmd, maskAuthCommand(cmd)));
567
582
  return promise;
568
583
  };
569
584
  const handlerResponse = handler({
@@ -5,6 +5,13 @@ import * as shared from '../shared/index.js';
5
5
  import XOAuth2 from '../xoauth2/index.js';
6
6
  import * as errors from '../errors.js';
7
7
  import * as packageData from '../package-info.js';
8
+ // The keys a message's `auth` may set on top of the transport's auth settings: the ones that
9
+ // say who logs in and with what. Everything else in the auth block (accessUrl, clientId,
10
+ // clientSecret, customHeaders, customParams, tls, privateKey, serviceClient and the rest)
11
+ // names the endpoint the credentials go to or is a secret of the application itself, and
12
+ // a message that could set `auth.accessUrl` and force a refresh would have the transport's
13
+ // client secret and refresh token posted to a URL of its choosing
14
+ const MESSAGE_AUTH_KEYS = ['type', 'user', 'pass', 'accessToken', 'refreshToken', 'expires'];
8
15
  /**
9
16
  * Creates a SMTP transport object for Nodemailer
10
17
  *
@@ -64,7 +71,11 @@ class SMTPTransport extends EventEmitter {
64
71
  }
65
72
  return this.auth;
66
73
  }
67
- const authData = Object.assign({}, this.options.auth && typeof this.options.auth === 'object' ? this.options.auth : {}, typeof authOpts === 'object' ? authOpts : {});
74
+ const authData = Object.assign({}, this.options.auth && typeof this.options.auth === 'object' ? this.options.auth : {});
75
+ if (typeof authOpts === 'object') {
76
+ // see MESSAGE_AUTH_KEYS
77
+ shared.copyOwnKeys(authData, authOpts, key => !MESSAGE_AUTH_KEYS.includes(key));
78
+ }
68
79
  if (Object.keys(authData).length === 0) {
69
80
  return false;
70
81
  }
@@ -360,6 +360,13 @@ export const services = {
360
360
  "port": 587,
361
361
  "secure": false
362
362
  },
363
+ "Oveyon": {
364
+ "description": "Oveyon",
365
+ "host": "smtp.oveyon.com",
366
+ "port": 587,
367
+ "secure": false,
368
+ "requireTLS": true
369
+ },
363
370
  "Postmark": {
364
371
  "description": "Postmark",
365
372
  "aliases": [
@@ -226,8 +226,14 @@ class XOAuth2 extends Stream {
226
226
  grant_type: 'refresh_token'
227
227
  };
228
228
  }
229
- Object.assign(urlOptions, this.options.customParams);
230
- Object.assign(loggedUrlOptions, this.options.customParams);
229
+ const customParams = this.options.customParams || {};
230
+ Object.assign(urlOptions, customParams);
231
+ // a custom param is as likely to be a client assertion or an API key as a tenant
232
+ // name, so the log gets the same glimpse of it that it gets of the client secret
233
+ for (const key of Object.keys(customParams)) {
234
+ const param = customParams[key];
235
+ loggedUrlOptions[key] = (param === undefined || param === null ? '' : String(param)).substr(0, 6) + '...';
236
+ }
231
237
  this.logger.debug({
232
238
  tnx: 'OAUTH2',
233
239
  user: this.options.user,
@@ -333,6 +333,14 @@
333
333
  "secure": false
334
334
  },
335
335
 
336
+ "Oveyon": {
337
+ "description": "Oveyon",
338
+ "host": "smtp.oveyon.com",
339
+ "port": 587,
340
+ "secure": false,
341
+ "requireTLS": true
342
+ },
343
+
336
344
  "Postmark": {
337
345
  "description": "Postmark",
338
346
  "aliases": ["PostmarkApp"],
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "nodemailer",
3
- "version": "10.1.1",
3
+ "version": "10.1.2",
4
4
  "description": "Easy as cake e-mail sending from your Node.js applications",
5
5
  "type": "module",
6
6
  "main": "./dist/cjs/nodemailer.js",
package/package.json CHANGED
@@ -87,7 +87,7 @@
87
87
  "@mavogel/mvc-projen": "^0.0.60",
88
88
  "cdk-nag": "^3.0.1",
89
89
  "constructs": "^10.5.1",
90
- "mailparser": "^3.9.39",
90
+ "mailparser": "^3.9.40",
91
91
  "uuid": "^14.0.3"
92
92
  },
93
93
  "bundledDependencies": [
@@ -122,7 +122,7 @@
122
122
  "publishConfig": {
123
123
  "access": "public"
124
124
  },
125
- "version": "0.1.22",
125
+ "version": "0.1.23",
126
126
  "jest": {
127
127
  "coverageProvider": "v8",
128
128
  "transformIgnorePatterns": [