@mate_tsaava/pr-review 1.0.1 → 1.0.3

package/LICENSE.md

@@ -0,0 +1,21 @@
+    MIT License
+
+    Copyright (c) Microsoft Corporation.
+
+    Permission is hereby granted, free of charge, to any person obtaining a copy
+    of this software and associated documentation files (the "Software"), to deal
+    in the Software without restriction, including without limitation the rights
+    to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+    copies of the Software, and to permit persons to whom the Software is
+    furnished to do so, subject to the following conditions:
+
+    The above copyright notice and this permission notice shall be included in all
+    copies or substantial portions of the Software.
+
+    THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+    IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+    FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+    AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+    LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+    OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+    SOFTWARE

package/dist/cli.js

@@ -58,14 +58,14 @@ yargs(hideBin(process.argv))
         default: false,
     })
         .option("max-tokens", {
-        describe: "Max tokens per batch (default: 150000)",
+        describe: "Max tokens per batch",
         type: "number",
-        default: 150000,
+        default: 40000,
     })
         .option("max-files", {
-        describe: "Max files per batch (default: 10)",
+        describe: "Max files per batch",
         type: "number",
-        default: 10,
+        default: 3,
     })
         .option("config", {
         alias: "c",
@@ -77,6 +77,11 @@ yargs(hideBin(process.argv))
         describe: "Show detailed logs (prompts, responses, API calls)",
         type: "boolean",
         default: false,
+    })
+        .option("review-context", {
+        describe: "Also flag issues in context lines (legacy code near changes)",
+        type: "boolean",
+        default: false,
     });
 }, async (argv) => {
     const { loadConfig } = await import("./config.js");
@@ -102,6 +107,7 @@ yargs(hideBin(process.argv))
             maxTokensPerBatch: argv.maxTokens,
             maxFilesPerBatch: argv.maxFiles,
             verbose: argv.verbose,
+            reviewContext: argv.reviewContext,
         });
         // Print summary
         console.log("\n" + chalk.bold("Result:"));

package/dist/llm/adapter.d.ts

@@ -10,4 +10,5 @@ export interface LLMAdapterConfig {
     model: string;
     endpoint?: string;
     verbose?: boolean;
+    reviewContext?: boolean;
 }

package/dist/llm/azure-openai.js

@@ -50,6 +50,7 @@ export class AzureOpenAIAdapter {
 - Author: ${prompt.prMetadata.author}
 - Source Branch: ${prompt.prMetadata.sourceBranch}
 - Target Branch: ${prompt.prMetadata.targetBranch}
+- Description: ${prompt.prMetadata.description || "No description"}
 
 ## File Diffs
 `;

package/dist/llm/claude.d.ts

@@ -4,6 +4,7 @@ export declare class ClaudeAdapter implements LLMAdapter {
     private client;
     private model;
     private verbose;
+    private reviewContext;
     constructor(config: LLMAdapterConfig);
     review(prompt: ReviewPrompt): Promise<ReviewResult>;
     private buildUserPrompt;

package/dist/llm/claude.js

@@ -1,25 +1,30 @@
 import Anthropic from "@anthropic-ai/sdk";
-const SYSTEM_PROMPT = `You are a Senior Principal Engineer conducting a code review. You are direct, blunt, and pragmatic.
+const SYSTEM_PROMPT_BASE = `You are a code reviewer. Follow the provided rules file EXACTLY.
 
-Your task is to review the PR diff and identify issues in the NEW CODE ONLY. For each issue, provide:
-- file: The EXACT file path from the diff header (e.g., "/CredoWebAPI/Controllers/ScoringController.cs")
-- line: The EXACT line number where the problem IS, not where the function starts. Point to the specific problematic line.
-- endLine: (optional) If the issue spans multiple lines, include the ending line number.
-- severity: BLOCK (must fix before merge), HIGH (should fix), or MEDIUM (nice to fix)
-- category: Type of issue (Security, Architecture, Naming, Performance, Clean Code, etc.)
-- codeSnippet: Quote the EXACT problematic code (1-3 lines max) so there's no ambiguity
-- message: A witty, memorable comment about the issue
-- fix: The specific action to fix the issue, referencing the exact lines
+STRICT RULES:
+1. NO DUPLICATES - Flag each issue ONCE only. If branch name is invalid, ONE issue. If PR title is invalid, ONE issue.
+2. ONLY FLAG PROBLEMS - Never create issues for correct code. If code is fine, don't mention it.
+3. LINE NUMBERS - Read from diff @@ header. Example: "@@ -120,6 +145,10 @@" means new code starts at line 145. Use the NEW file line number (after the +).
+4. For metadata issues: file="/_metadata", line=1 (branch) or line=2 (title)
 
-CRITICAL RULES:
-1. ONLY review lines starting with "+" (added or modified code). These are the NEW lines being introduced.
-2. NEVER comment on lines starting with "-" (deleted/old code). These are being REMOVED from the codebase.
-3. When a line is CHANGED, it appears as "-old" then "+new" - only review the "+new" version.
-4. The "file" field MUST be the exact path from the diff (starts with /)
-5. The "line" field MUST be a positive integer from the NEW code's line numbers (the + lines)
-6. If old problematic code is being deleted and replaced with better code, that is GOOD - do not flag the old code as an issue.
+"file" = exact path from diff header (starts with /)`;
+const DIFF_RULES_STRICT = `
 
-Return your response as valid JSON in this exact format:
+DIFF RULES (STRICT MODE - only review changed lines):
+- ONLY review "+" lines (new code being added)
+- NEVER flag "-" lines (old code being removed)
+- NEVER flag " " lines (context/unchanged code) - these existed before this PR
+- If code doesn't start with "+", SKIP IT completely`;
+const DIFF_RULES_WITH_CONTEXT = `
+
+DIFF RULES (CONTEXT MODE - review changes and surrounding code):
+- Review "+" lines (new code being added) - PRIMARY focus
+- Review " " lines (context) if they have issues near the changes
+- NEVER flag "-" lines (old code being removed)
+- For context issues, be helpful but less strict (use MEDIUM severity max)`;
+const JSON_FORMAT = `
+
+Return your response as valid JSON:
 {
   "issues": [
     {
@@ -45,14 +50,17 @@ export class ClaudeAdapter {
     client;
     model;
     verbose;
+    reviewContext;
     constructor(config) {
         this.client = new Anthropic({ apiKey: config.apiKey });
         this.model = config.model;
         this.verbose = config.verbose || false;
+        this.reviewContext = config.reviewContext || false;
     }
     async review(prompt) {
         const userPrompt = this.buildUserPrompt(prompt);
-        const systemPrompt = SYSTEM_PROMPT + "\n\n" + prompt.rules;
+        const diffRules = this.reviewContext ? DIFF_RULES_WITH_CONTEXT : DIFF_RULES_STRICT;
+        const systemPrompt = SYSTEM_PROMPT_BASE + diffRules + JSON_FORMAT + "\n\n" + prompt.rules;
         const maxRetries = 3;
         let lastError = null;
         if (this.verbose) {
@@ -73,7 +81,7 @@ export class ClaudeAdapter {
             try {
                 const response = await this.client.messages.create({
                     model: this.model,
-                    max_tokens: 4096,
+                    max_tokens: 8192,
                     system: systemPrompt,
                     messages: [
                         {

package/dist/llm/openai.js

@@ -50,6 +50,7 @@ export class OpenAIAdapter {
 - Author: ${prompt.prMetadata.author}
 - Source Branch: ${prompt.prMetadata.sourceBranch}
 - Target Branch: ${prompt.prMetadata.targetBranch}
+- Description: ${prompt.prMetadata.description || "No description"}
 
 ## File Diffs
 `;

package/dist/reviewer.d.ts

@@ -9,6 +9,7 @@ export interface ReviewOptions {
     maxTokensPerBatch?: number;
     maxFilesPerBatch?: number;
     verbose?: boolean;
+    reviewContext?: boolean;
 }
 export interface ReviewOutput {
     result: ReviewResult;

package/dist/reviewer.js

@@ -28,8 +28,8 @@ export class PRReviewer {
         // 2. Load review rules
         const rules = this.loadRules();
         // 3. Create batches
-        const maxTokens = options.maxTokensPerBatch || 150000;
-        const maxFiles = options.maxFilesPerBatch || 10;
+        const maxTokens = options.maxTokensPerBatch || 40000;
+        const maxFiles = options.maxFilesPerBatch || 3;
         const diffs = prDiff.diffs.map((d) => ({ path: d.path, diff: d.diff }));
         const totalTokens = estimateDiffTokens(diffs);
         const batches = createBatches(diffs, maxTokens, maxFiles);
@@ -42,6 +42,7 @@ export class PRReviewer {
             model: this.config.llm.model || "claude-sonnet-4-20250514",
             endpoint: this.config.llm.endpoint,
             verbose: options.verbose,
+            reviewContext: options.reviewContext,
         });
         const allIssues = [];
         try {
@@ -67,17 +68,51 @@ export class PRReviewer {
         catch (error) {
             throw new Error(`Failed to analyze PR with ${this.config.llm.provider}: ${error instanceof Error ? error.message : String(error)}`);
         }
-        // 5. Generate combined result
+        // 5. Deduplicate metadata issues (same metadata sent to each batch)
+        // Use line-only key since metadata line numbers uniquely identify the issue
+        // (line 1 = branch naming, line 2 = PR title, etc.)
+        const allMetadataIssues = allIssues.filter((i) => i.file === "/_metadata");
+        const allCodeIssues = allIssues.filter((i) => i.file !== "/_metadata");
+        const uniqueMetadata = new Map();
+        for (const issue of allMetadataIssues) {
+            const key = `${issue.line}`;
+            if (!uniqueMetadata.has(key)) {
+                uniqueMetadata.set(key, issue);
+            }
+        }
+        // 6. Generate combined result
+        const metadataIssues = [...uniqueMetadata.values()];
+        const codeIssues = allCodeIssues;
+        const deduplicatedIssues = [...metadataIssues, ...codeIssues];
         const result = {
-            issues: allIssues,
-            summary: this.generateSummary(allIssues),
+            issues: deduplicatedIssues,
+            summary: this.generateSummary(deduplicatedIssues),
         };
         // 4. Post comments (unless dry run)
         let postedComments = 0;
         let summaryPosted = false;
         if (!options.dryRun) {
             console.log("\nPosting comments...");
-            for (const issue of result.issues) {
+            // Post metadata issues as a single thread comment (not inline)
+            if (metadataIssues.length > 0) {
+                try {
+                    const metadataContent = metadataIssues
+                        .map((issue) => this.formatComment(issue))
+                        .join("\n\n---\n\n");
+                    await this.poster.postSummaryComment(options.repositoryId, options.pullRequestId, {
+                        content: `## ⚠️ PR Metadata Issues\n\n${metadataContent}`,
+                    });
+                    postedComments += metadataIssues.length;
+                    for (const issue of metadataIssues) {
+                        console.log(`  • ${issue.severity}: ${issue.category} (${issue.message.slice(0, 50)}...)`);
+                    }
+                }
+                catch (error) {
+                    console.error(`  ✗ Failed to post metadata comment: ${error instanceof Error ? error.message : String(error)}`);
+                }
+            }
+            // Post code issues as inline comments
+            for (const issue of codeIssues) {
                 try {
                     await this.poster.postInlineComment(options.repositoryId, options.pullRequestId, {
                         filePath: issue.file,
@@ -102,10 +137,21 @@ export class PRReviewer {
         }
         else {
             console.log("\nDry run - would post these comments:");
-            for (const issue of result.issues) {
-                console.log(`  [${issue.severity}] ${issue.category} (${issue.file}:${issue.line})`);
-                console.log(`    ${issue.message}`);
-                console.log(`    Fix: ${issue.fix}\n`);
+            if (metadataIssues.length > 0) {
+                console.log("\n  📋 METADATA ISSUES:");
+                for (const issue of metadataIssues) {
+                    console.log(`  [${issue.severity}] ${issue.category}`);
+                    console.log(`    ${issue.message}`);
+                    console.log(`    Fix: ${issue.fix}\n`);
+                }
+            }
+            if (codeIssues.length > 0) {
+                console.log("\n  📝 CODE ISSUES:");
+                for (const issue of codeIssues) {
+                    console.log(`  [${issue.severity}] ${issue.category} (${issue.file}:${issue.line})`);
+                    console.log(`    ${issue.message}`);
+                    console.log(`    Fix: ${issue.fix}\n`);
+                }
             }
             console.log(`Summary: ${result.summary}`);
         }

package/dist/utils/batcher.js

@@ -1,5 +1,5 @@
 import { estimateTokens } from "./tokens.js";
-export function createBatches(diffs, maxTokensPerBatch = 150000, maxFilesPerBatch = 10) {
+export function createBatches(diffs, maxTokensPerBatch = 40000, maxFilesPerBatch = 3) {
     // Add token estimates
     const filesWithTokens = diffs.map((d) => ({
         ...d,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mate_tsaava/pr-review",
-  "version": "1.0.1",
+  "version": "1.0.3",
   "description": "AI-powered code review CLI for Azure DevOps pull requests",
   "type": "module",
   "bin": {
@@ -17,12 +17,6 @@
   "files": [
     "dist"
   ],
-  "scripts": {
-    "build": "tsc && cp -r src/rules dist/",
-    "clean": "rm -rf dist",
-    "test": "vitest run",
-    "prepublishOnly": "npm run build"
-  },
   "keywords": [
     "azure-devops",
     "ado",
@@ -38,18 +32,23 @@
     "node": ">=18"
   },
   "dependencies": {
-    "@mate_tsaava/azure-devops-core": "workspace:*",
     "@anthropic-ai/sdk": "^0.39.0",
     "openai": "^4.77.0",
     "yargs": "^18.0.0",
     "zod": "^3.25.63",
     "chalk": "^5.4.1",
-    "dotenv": "^16.4.7"
+    "dotenv": "^16.4.7",
+    "@mate_tsaava/azure-devops-core": "1.0.1"
   },
   "devDependencies": {
     "@types/node": "^22.19.1",
     "@types/yargs": "^17.0.33",
     "typescript": "^5.9.3",
     "vitest": "^3.0.0"
+  },
+  "scripts": {
+    "build": "tsc && cp -r src/rules dist/",
+    "clean": "rm -rf dist",
+    "test": "vitest run"
   }
-}
+}