@mastra/mssql 1.0.0-beta.0 → 1.0.0-beta.1

package/CHANGELOG.md

@@ -1,5 +1,20 @@
 # @mastra/mssql
 
+## 1.0.0-beta.1
+
+### Patch Changes
+
+- Fixes MSSQL store test configuration and pagination issues: ([#9905](https://github.com/mastra-ai/mastra/pull/9905))
+
+  Adds missing id parameter to test configuration and updates documentation
+  Implements page validation to handle negative page numbers
+  Fixes sorting and pagination bugs in message listing (improves ORDER BY with seq_id secondary sort and corrects hasMore calculation)
+
+- Prevents double stringification for MSSQL jsonb columns by reusing incoming strings that already contain valid JSON while still stringifying other inputs as needed. ([#9901](https://github.com/mastra-ai/mastra/pull/9901))
+
+- Updated dependencies [[`465ac05`](https://github.com/mastra-ai/mastra/commit/465ac0526a91d175542091c675181f1a96c98c46)]:
+  - @mastra/core@1.0.0-beta.2
+
 ## 1.0.0-beta.0
 
 ### Major Changes

package/README.md

@@ -27,6 +27,7 @@ MSSQLStore supports multiple connection methods:
 import { MSSQLStore } from '@mastra/mssql';
 
 const store = new MSSQLStore({
+  id: 'mssql-storage',
   connectionString:
     'Server=localhost,1433;Database=mastra;User Id=sa;Password=yourPassword;Encrypt=true;TrustServerCertificate=true',
 });
@@ -36,6 +37,7 @@ const store = new MSSQLStore({
 
 ```typescript
 const store = new MSSQLStore({
+  id: 'mssql-storage',
   server: 'localhost',
   port: 1433,
   database: 'mastra',
@@ -49,6 +51,7 @@ const store = new MSSQLStore({
 
 ```typescript
 const store = new MSSQLStore({
+  id: 'mssql-storage',
   connectionString:
     'Server=localhost,1433;Database=mastra;User Id=sa;Password=yourPassword;Encrypt=true;TrustServerCertificate=true',
   schemaName: 'custom_schema', // Use custom schema (default: dbo)
@@ -103,6 +106,10 @@ const messages = await store.listMessages({ threadId: 'thread-123' });
 
 ## Configuration
 
+### Identifier
+
+- `id`: Unique identifier for this store instance (required)
+
 ### Connection Methods
 
 MSSQLStore supports multiple connection methods:
@@ -111,6 +118,7 @@ MSSQLStore supports multiple connection methods:
 
    ```typescript
    {
+     id: 'mssql-storage',
      connectionString: 'Server=localhost,1433;Database=mastra;User Id=sa;Password=yourPassword;Encrypt=true;TrustServerCertificate=true';
    }
    ```
@@ -118,6 +126,7 @@ MSSQLStore supports multiple connection methods:
 2. **Server/Port/Database**
    ```typescript
    {
+     id: 'mssql-storage',
      server: 'localhost',
      port: 1433,
      database: 'mastra',

package/dist/index.cjs

@@ -156,6 +156,18 @@ var MemoryMSSQL = class extends storage.MemoryStorage {
   }
   async listThreadsByResourceId(args) {
     const { resourceId, page = 0, perPage: perPageInput, orderBy } = args;
+    if (page < 0) {
+      throw new error.MastraError({
+        id: "MASTRA_STORAGE_MSSQL_STORE_INVALID_PAGE",
+        domain: error.ErrorDomain.STORAGE,
+        category: error.ErrorCategory.USER,
+        text: "Page number must be non-negative",
+        details: {
+          resourceId,
+          page
+        }
+      });
+    }
     const perPage = storage.normalizePerPage(perPageInput, 100);
     const { offset, perPage: perPageForResponse } = storage.calculatePagination(page, perPageInput, perPage);
     const { field, direction } = this.parseOrderBy(orderBy);
@@ -511,43 +523,59 @@ var MemoryMSSQL = class extends storage.MemoryStorage {
         new Error("threadId must be a non-empty string")
       );
     }
+    if (page < 0) {
+      throw new error.MastraError({
+        id: "MASTRA_STORAGE_MSSQL_STORE_INVALID_PAGE",
+        domain: error.ErrorDomain.STORAGE,
+        category: error.ErrorCategory.USER,
+        text: "Page number must be non-negative",
+        details: {
+          threadId,
+          page
+        }
+      });
+    }
     const perPage = storage.normalizePerPage(perPageInput, 40);
     const { offset, perPage: perPageForResponse } = storage.calculatePagination(page, perPageInput, perPage);
     try {
       const { field, direction } = this.parseOrderBy(orderBy, "ASC");
-      const orderByStatement = `ORDER BY [${field}] ${direction}`;
-      const selectStatement = `SELECT seq_id, id, content, role, type, [createdAt], thread_id AS threadId, resourceId`;
+      const orderByStatement = `ORDER BY [${field}] ${direction}, [seq_id] ${direction}`;
       const tableName = getTableName({ indexName: storage.TABLE_MESSAGES, schemaName: getSchemaName(this.schema) });
-      const conditions = ["[thread_id] = @threadId"];
-      const request = this.pool.request();
-      request.input("threadId", threadId);
-      if (resourceId) {
-        conditions.push("[resourceId] = @resourceId");
-        request.input("resourceId", resourceId);
-      }
-      if (filter?.dateRange?.start) {
-        conditions.push("[createdAt] >= @fromDate");
-        request.input("fromDate", filter.dateRange.start);
-      }
-      if (filter?.dateRange?.end) {
-        conditions.push("[createdAt] <= @toDate");
-        request.input("toDate", filter.dateRange.end);
-      }
-      const whereClause = `WHERE ${conditions.join(" AND ")}`;
-      const countQuery = `SELECT COUNT(*) as total FROM ${tableName} ${whereClause}`;
-      const countResult = await request.query(countQuery);
+      const baseQuery = `SELECT seq_id, id, content, role, type, [createdAt], thread_id AS threadId, resourceId FROM ${tableName}`;
+      const filters = {
+        thread_id: threadId,
+        ...resourceId ? { resourceId } : {},
+        ...buildDateRangeFilter(filter?.dateRange, "createdAt")
+      };
+      const { sql: actualWhereClause = "", params: whereParams } = prepareWhereClause(
+        filters);
+      const bindWhereParams = (req) => {
+        Object.entries(whereParams).forEach(([paramName, paramValue]) => req.input(paramName, paramValue));
+      };
+      const countRequest = this.pool.request();
+      bindWhereParams(countRequest);
+      const countResult = await countRequest.query(`SELECT COUNT(*) as total FROM ${tableName}${actualWhereClause}`);
       const total = parseInt(countResult.recordset[0]?.total, 10) || 0;
-      const limitValue = perPageInput === false ? total : perPage;
-      const dataQuery = `${selectStatement} FROM ${tableName} ${whereClause} ${orderByStatement} OFFSET @offset ROWS FETCH NEXT @limit ROWS ONLY`;
-      request.input("offset", offset);
-      if (limitValue > 2147483647) {
-        request.input("limit", sql2__default.default.BigInt, limitValue);
-      } else {
-        request.input("limit", limitValue);
-      }
-      const rowsResult = await request.query(dataQuery);
-      const rows = rowsResult.recordset || [];
-      const messages = [...rows];
+      const fetchBaseMessages = async () => {
+        const request = this.pool.request();
+        bindWhereParams(request);
+        if (perPageInput === false) {
+          const result2 = await request.query(`${baseQuery}${actualWhereClause} ${orderByStatement}`);
+          return result2.recordset || [];
+        }
+        request.input("offset", offset);
+        request.input("limit", perPage > 2147483647 ? sql2__default.default.BigInt : sql2__default.default.Int, perPage);
+        const result = await request.query(
+          `${baseQuery}${actualWhereClause} ${orderByStatement} OFFSET @offset ROWS FETCH NEXT @limit ROWS ONLY`
+        );
+        return result.recordset || [];
+      };
+      const baseRows = perPage === 0 ? [] : await fetchBaseMessages();
+      const messages = [...baseRows];
+      const seqById = /* @__PURE__ */ new Map();
+      messages.forEach((msg) => {
+        if (typeof msg.seq_id === "number") seqById.set(msg.id, msg.seq_id);
+      });
       if (total === 0 && messages.length === 0 && (!include || include.length === 0)) {
         return {
           messages: [],
@@ -557,28 +585,33 @@ var MemoryMSSQL = class extends storage.MemoryStorage {
           hasMore: false
         };
       }
-      const messageIds = new Set(messages.map((m) => m.id));
-      if (include && include.length > 0) {
+      if (include?.length) {
+        const messageIds = new Set(messages.map((m) => m.id));
         const includeMessages = await this._getIncludedMessages({ threadId, include });
-        if (includeMessages) {
-          for (const includeMsg of includeMessages) {
-            if (!messageIds.has(includeMsg.id)) {
-              messages.push(includeMsg);
-              messageIds.add(includeMsg.id);
-            }
+        includeMessages?.forEach((msg) => {
+          if (!messageIds.has(msg.id)) {
+            messages.push(msg);
+            messageIds.add(msg.id);
+            if (typeof msg.seq_id === "number") seqById.set(msg.id, msg.seq_id);
           }
-        }
+        });
       }
       const parsed = this._parseAndFormatMessages(messages, "v2");
-      let finalMessages = parsed;
-      finalMessages = finalMessages.sort((a, b) => {
-        const aValue = field === "createdAt" ? new Date(a.createdAt).getTime() : a[field];
-        const bValue = field === "createdAt" ? new Date(b.createdAt).getTime() : b[field];
-        return direction === "ASC" ? aValue - bValue : bValue - aValue;
+      const mult = direction === "ASC" ? 1 : -1;
+      const finalMessages = parsed.sort((a, b) => {
+        const aVal = field === "createdAt" ? new Date(a.createdAt).getTime() : a[field];
+        const bVal = field === "createdAt" ? new Date(b.createdAt).getTime() : b[field];
+        if (aVal == null || bVal == null) {
+          return aVal == null && bVal == null ? a.id.localeCompare(b.id) : aVal == null ? 1 : -1;
+        }
+        const diff = (typeof aVal === "number" && typeof bVal === "number" ? aVal - bVal : String(aVal).localeCompare(String(bVal))) * mult;
+        if (diff !== 0) return diff;
+        const seqA = seqById.get(a.id);
+        const seqB = seqById.get(b.id);
+        return seqA != null && seqB != null ? (seqA - seqB) * mult : a.id.localeCompare(b.id);
       });
-      const returnedThreadMessageIds = new Set(finalMessages.filter((m) => m.threadId === threadId).map((m) => m.id));
-      const allThreadMessagesReturned = returnedThreadMessageIds.size >= total;
-      const hasMore = perPageInput !== false && !allThreadMessagesReturned && offset + perPage < total;
+      const returnedThreadMessageCount = finalMessages.filter((m) => m.threadId === threadId).length;
+      const hasMore = perPageInput !== false && returnedThreadMessageCount < total && offset + perPage < total;
       return {
         messages: finalMessages,
         total,
@@ -1685,6 +1718,20 @@ ${columns}
       return value ? 1 : 0;
     }
     if (columnSchema?.type === "jsonb") {
+      if (typeof value === "string") {
+        const trimmed = value.trim();
+        if (trimmed.length > 0) {
+          try {
+            JSON.parse(trimmed);
+            return trimmed;
+          } catch {
+          }
+        }
+        return JSON.stringify(value);
+      }
+      if (typeof value === "bigint") {
+        return value.toString();
+      }
       return JSON.stringify(value);
     }
     if (typeof value === "object") {