@mastra/memory 1.5.0 → 1.5.1-alpha.0

package/CHANGELOG.md

@@ -1,5 +1,20 @@
 # @mastra/memory
 
+## 1.5.1-alpha.0
+
+### Patch Changes
+
+- **Fixed memory leak in Observational Memory** ([#13425](https://github.com/mastra-ai/mastra/pull/13425))
+
+  Fixed several memory management issues that could cause OOM crashes in long-running processes with Observational Memory enabled:
+  - **Shared tokenizer**: The default Tiktoken encoder (~80-120 MB heap) is now shared across all OM instances instead of being allocated per request. This is the primary fix — previously each request allocated two encoders that persisted in memory due to async buffering promise retention.
+  - **Cleanup key fix**: Fixed a bug where reflection cycle IDs were not properly cleaned up due to using the wrong map key in `cleanupStaticMaps`.
+
+- Fixed PostgreSQL deadlock when parallel agents with different threadIds share the same resourceId while using Observational Memory. Thread scope now requires a valid threadId and throws a clear error if one is missing. Also fixed the database lock ordering in synchronous observation to prevent lock inversions. ([#13436](https://github.com/mastra-ai/mastra/pull/13436))
+
+- Updated dependencies [[`24284ff`](https://github.com/mastra-ai/mastra/commit/24284ffae306ddf0ab83273e13f033520839ef40), [`f5097cc`](https://github.com/mastra-ai/mastra/commit/f5097cc8a813c82c3378882c31178320cadeb655), [`71e237f`](https://github.com/mastra-ai/mastra/commit/71e237fa852a3ad9a50a3ddb3b5f3b20b9a8181c), [`13a291e`](https://github.com/mastra-ai/mastra/commit/13a291ebb9f9bca80befa0d9166b916bb348e8e9), [`397af5a`](https://github.com/mastra-ai/mastra/commit/397af5a69f34d4157f51a7c8da3f1ded1e1d611c), [`d4701f7`](https://github.com/mastra-ai/mastra/commit/d4701f7e24822b081b70f9c806c39411b1a712e7), [`2b40831`](https://github.com/mastra-ai/mastra/commit/2b40831dcca2275c9570ddf09b7f25ba3e8dc7fc), [`6184727`](https://github.com/mastra-ai/mastra/commit/6184727e812bf7a65cee209bacec3a2f5a16e923), [`6f6385b`](https://github.com/mastra-ai/mastra/commit/6f6385be5b33687cd21e71fc27e972e6928bb34c), [`14aba61`](https://github.com/mastra-ai/mastra/commit/14aba61b9cff76d72bc7ef6f3a83ae2c5d059193), [`dd9dd1c`](https://github.com/mastra-ai/mastra/commit/dd9dd1c9ae32ae79093f8c4adde1732ac6357233)]:
+  - @mastra/core@1.7.0-alpha.0
+
 ## 1.5.0
 
 ### Minor Changes

package/dist/{chunk-DF7NDDSM.js → chunk-6PKWQ3GH.js}

@@ -909,6 +909,13 @@ function extractReflectorListItems(content) {
 function validateCompression(reflectedTokens, targetThreshold) {
   return reflectedTokens < targetThreshold;
 }
+var sharedDefaultEncoder;
+function getDefaultEncoder() {
+  if (!sharedDefaultEncoder) {
+    sharedDefaultEncoder = new Tiktoken(o200k_base);
+  }
+  return sharedDefaultEncoder;
+}
 var TokenCounter = class _TokenCounter {
   encoder;
   // Per-message overhead: accounts for role tokens, message framing, and separators.
@@ -918,7 +925,7 @@ var TokenCounter = class _TokenCounter {
   // Conversation-level overhead: system prompt framing, reply priming tokens, etc.
   static TOKENS_PER_CONVERSATION = 24;
   constructor(encoding) {
-    this.encoder = new Tiktoken(encoding || o200k_base);
+    this.encoder = encoding ? new Tiktoken(encoding) : getDefaultEncoder();
   }
   /**
    * Count tokens in a plain string
@@ -1373,7 +1380,7 @@ var ObservationalMemory = class _ObservationalMemory {
       _ObservationalMemory.lastBufferedBoundary.delete(reflBufKey);
       _ObservationalMemory.asyncBufferingOps.delete(obsBufKey);
       _ObservationalMemory.asyncBufferingOps.delete(reflBufKey);
-      _ObservationalMemory.reflectionBufferCycleIds.delete(obsBufKey);
+      _ObservationalMemory.reflectionBufferCycleIds.delete(reflBufKey);
     }
   }
   /**
@@ -1925,6 +1932,11 @@ Async buffering is enabled by default \u2014 this opt-out is only needed when us
         resourceId: resourceId ?? threadId
       };
     }
+    if (!threadId) {
+      throw new Error(
+        `ObservationalMemory (scope: 'thread') requires a threadId, but received an empty value. This is a bug \u2014 getThreadContext should have caught this earlier.`
+      );
+    }
     return {
       threadId,
       resourceId: resourceId ?? threadId
@@ -2683,6 +2695,11 @@ ${suggestedResponse}
         resourceId: serialized.memoryInfo.resourceId
       };
     }
+    if (this.scope === "thread") {
+      throw new Error(
+        `ObservationalMemory (scope: 'thread') requires a threadId, but none was found in RequestContext or MessageList. Ensure the agent is configured with Memory and a valid threadId is provided.`
+      );
+    }
     return null;
   }
   // ══════════════════════════════════════════════════════════════════════════
@@ -3759,13 +3776,6 @@ ${result.observations}` : result.observations;
       const newMessageIds = messagesToObserve.map((m) => m.id);
       const existingIds = freshRecord?.observedMessageIds ?? record.observedMessageIds ?? [];
       const allObservedIds = [.../* @__PURE__ */ new Set([...Array.isArray(existingIds) ? existingIds : [], ...newMessageIds])];
-      await this.storage.updateActiveObservations({
-        id: record.id,
-        observations: newObservations,
-        tokenCount: totalTokenCount,
-        lastObservedAt,
-        observedMessageIds: allObservedIds
-      });
       if (result.suggestedContinuation || result.currentTask) {
         const thread = await this.storage.getThreadById({ threadId });
         if (thread) {
@@ -3780,6 +3790,13 @@ ${result.observations}` : result.observations;
           });
         }
       }
+      await this.storage.updateActiveObservations({
+        id: record.id,
+        observations: newObservations,
+        tokenCount: totalTokenCount,
+        lastObservedAt,
+        observedMessageIds: allObservedIds
+      });
       const actualTokensObserved = this.tokenCounter.countMessages(messagesToObserve);
       if (lastMessage?.id) {
         const endMarker = this.createObservationEndMarker({
@@ -5048,5 +5065,5 @@ ${unreflectedContent}` : freshRecord.bufferedReflection;
 };
 
 export { OBSERVATIONAL_MEMORY_DEFAULTS, OBSERVATION_CONTEXT_INSTRUCTIONS, OBSERVATION_CONTEXT_PROMPT, OBSERVATION_CONTINUATION_HINT, OBSERVER_SYSTEM_PROMPT, ObservationalMemory, TokenCounter, buildObserverPrompt, buildObserverSystemPrompt, extractCurrentTask, formatMessagesForObserver, hasCurrentTaskSection, optimizeObservationsForContext, parseObserverOutput };
-//# sourceMappingURL=chunk-DF7NDDSM.js.map
-//# sourceMappingURL=chunk-DF7NDDSM.js.map
+//# sourceMappingURL=chunk-6PKWQ3GH.js.map
+//# sourceMappingURL=chunk-6PKWQ3GH.js.map