@mastra/github-signals 0.2.4 → 0.2.5-alpha.1

package/CHANGELOG.md

@@ -1,5 +1,25 @@
 # @mastra/github-signals
 
+## 0.2.5-alpha.1
+
+### Patch Changes
+
+- Fixed a shut-down provider continuing to poll GitHub. Stopping the provider now clears its per-thread polling timers, so a provider that is replaced or disabled stops calling GitHub and stops sending notifications. ([#20848](https://github.com/mastra-ai/mastra/pull/20848))
+
+- Fixed deferred notification deliveries failing with "No model selected" when the woken thread had no request context. The notification dispatch workflow re-sends deferred and summarized notifications long after the originating send, so any stream options attached to the original signal are gone; waking an idle thread then had no way to resolve a model. The notification delivery policy now drives the fix: `NotificationDeliveryDecision` accepts `streamOptions`, and the dispatcher re-runs the agent's delivery policy at delivery time (via the new `agent.resolveNotificationDeliveryDecision()`) to attach freshly resolved stream options to both individual and summary deliveries. Only `streamOptions` is honored at dispatch time; the record's persisted schedule still governs when and how it is delivered. Receipt-time sends also honor the policy's `streamOptions` now: an immediate deliver or summarize-now wake attaches them too, with caller-supplied stream options taking precedence. Mastra Code wires its session-based stream options resolver through the Code Agent's `deliveryPolicy.decide`, layered on the default decision logic. This fix applies to threads whose session is live in the current process; deliveries with no resolvable session fall back to a bare wake, and the "No model selected" error now distinguishes the case where a run started without any controller session context. This re-lands the capability removed by the #18637 revert in the policy-driven shape that revert called for, and the `@mastra/github-signals` bump only widens its `getNotificationStreamOptions` callback return type to allow `undefined`. ([#21113](https://github.com/mastra-ai/mastra/pull/21113))
+
+- Updated dependencies [[`b8ce7ec`](https://github.com/mastra-ai/mastra/commit/b8ce7ec96e39343c6c2f36d12d68a9ad816c09f7), [`a3a3624`](https://github.com/mastra-ai/mastra/commit/a3a3624f646b98e409424d8defccbd334da9e8b8), [`6246914`](https://github.com/mastra-ai/mastra/commit/62469146636911f3cbbe0880bd011c6a897a59a7), [`3f73c07`](https://github.com/mastra-ai/mastra/commit/3f73c076727e8c36b4fff7a1b40290fb68957fa8), [`7c1ebb1`](https://github.com/mastra-ai/mastra/commit/7c1ebb15690c4b3f0eabb19077cf8af573311e57), [`32980a3`](https://github.com/mastra-ai/mastra/commit/32980a3e2413d0274ac244d32c37d910edc13f00), [`4bcdfaf`](https://github.com/mastra-ai/mastra/commit/4bcdfaf0eac3199d7cb171b0a19a92c9c341eea4), [`af4636a`](https://github.com/mastra-ai/mastra/commit/af4636a74463275d71c1d13a38f7d2b738f128bf), [`a463cdf`](https://github.com/mastra-ai/mastra/commit/a463cdf1c95c3059e70f0bff27959e8558bb899d), [`0ea6b80`](https://github.com/mastra-ai/mastra/commit/0ea6b8001408ce02b56e8be0536b0fd8cbaf8ad2)]:
+  - @mastra/core@1.58.0-alpha.11
+
+## 0.2.5-alpha.0
+
+### Patch Changes
+
+- Fixed GitHub polling so stopping a poll prevents in-flight work from sending notifications or writing subscription state. ([#20593](https://github.com/mastra-ai/mastra/pull/20593))
+
+- Updated dependencies [[`cdd5c33`](https://github.com/mastra-ai/mastra/commit/cdd5c33ac6c7118a9f139e6dc0e14e6a8ae31658), [`d7cf7fa`](https://github.com/mastra-ai/mastra/commit/d7cf7fafc1ae1b50bd8462dd0e6c671a8606db93), [`0f9a448`](https://github.com/mastra-ai/mastra/commit/0f9a448502157e59f7b76f24360ad497168f5ef8), [`289f4ce`](https://github.com/mastra-ai/mastra/commit/289f4ce16e3293370440172132c52ee787cbc09f), [`4f16ff8`](https://github.com/mastra-ai/mastra/commit/4f16ff824bf2f9b0ddc93f210477c10c8a4fb1ab), [`1c67d85`](https://github.com/mastra-ai/mastra/commit/1c67d85e9da8285662f4dbbf47e0378c3fee0747), [`ba24be6`](https://github.com/mastra-ai/mastra/commit/ba24be662439c331ab23a600041f93803c89eca8), [`842b5fe`](https://github.com/mastra-ai/mastra/commit/842b5fe22b6a7fa811bd14e48eb9af523ac989f2), [`80bdf3a`](https://github.com/mastra-ai/mastra/commit/80bdf3ae16ade6ff63bde0cb16fa2df8ab7dd4dd), [`9ba1247`](https://github.com/mastra-ai/mastra/commit/9ba12470c77f1c03642d720ce67e517e878f666e), [`fd96298`](https://github.com/mastra-ai/mastra/commit/fd96298a8367622f4ebfcaa97b5b6c1fbbd14564), [`6a84954`](https://github.com/mastra-ai/mastra/commit/6a84954a2667f85b6d59da652dab1bbff007ccb0), [`52d8ef0`](https://github.com/mastra-ai/mastra/commit/52d8ef03801f1deb7ee48532fc4190dd4a33916c), [`cdd5c33`](https://github.com/mastra-ai/mastra/commit/cdd5c33ac6c7118a9f139e6dc0e14e6a8ae31658), [`efd5c81`](https://github.com/mastra-ai/mastra/commit/efd5c81cc25fde3c2ddd86fc1178deb4ec176e19), [`0976933`](https://github.com/mastra-ai/mastra/commit/0976933142333ec78451feef265b68bcb45aa5e7), [`242b945`](https://github.com/mastra-ai/mastra/commit/242b94558777bfbdeb42cbfea84afff0b6ad0633), [`fea5cae`](https://github.com/mastra-ai/mastra/commit/fea5caedc7e2cfea51784a15e015952692027abf), [`4b59f78`](https://github.com/mastra-ai/mastra/commit/4b59f786cbc9a7d1ef07a07517dbd4b96865e99d), [`7010c5d`](https://github.com/mastra-ai/mastra/commit/7010c5d15728bf9c5dfe4fb6b1bf80ce23bf143a)]:
+  - @mastra/core@1.58.0-alpha.3
+
 ## 0.2.4
 
 ### Patch Changes

package/dist/index.cjs

@@ -740,6 +740,8 @@ var GithubSignals = class extends _mastra_core_signals.SignalProvider {
 	#syncClient;
 	#repositoryResolver;
 	#polling = /* @__PURE__ */ new Map();
+	#pollingThreadGenerations = /* @__PURE__ */ new Map();
+	#pollingGeneration = 0;
 	#permissionCache = /* @__PURE__ */ new Map();
 	#agent;
 	#agentOptions = {};
@@ -813,6 +815,7 @@ var GithubSignals = class extends _mastra_core_signals.SignalProvider {
 		const key = this.#pollingKey(input);
 		for (const [pollingKey, state] of this.#polling.entries()) {
 			if (pollingKey === key) continue;
+			this.#invalidatePollingThread(pollingKey);
 			clearInterval(state.timer);
 			this.#polling.delete(pollingKey);
 		}
@@ -836,6 +839,7 @@ var GithubSignals = class extends _mastra_core_signals.SignalProvider {
 	}
 	stopPollingForThread(input) {
 		const key = this.#pollingKey(input);
+		this.#invalidatePollingThread(key);
 		const state = this.#polling.get(key);
 		if (!state) return;
 		clearInterval(state.timer);
@@ -851,9 +855,21 @@ var GithubSignals = class extends _mastra_core_signals.SignalProvider {
 		return this.#options.pollIntervalMs ?? 3e5;
 	}
 	stopAllPolling() {
+		this.#pollingGeneration++;
+		this.#pollingThreadGenerations.clear();
 		for (const state of this.#polling.values()) clearInterval(state.timer);
 		this.#polling.clear();
 	}
+	/**
+	* Shutdown hook. Per-thread polling lives in this provider's own timer map, not in the base
+	* class's single timer, so the inherited `stop()` would leave those intervals running: a
+	* provider that has been shut down would keep polling GitHub and keep notifying through the
+	* agent it was still connected to.
+	*/
+	stop() {
+		super.stop();
+		this.stopAllPolling();
+	}
 	async pollThreadNow(input) {
 		return this.#pollThread(input, { includeComments: true });
 	}
@@ -1044,6 +1060,9 @@ var GithubSignals = class extends _mastra_core_signals.SignalProvider {
 	#pollingKey(input) {
 		return `${input.resourceId}:${input.threadId}`;
 	}
+	#invalidatePollingThread(key) {
+		this.#pollingThreadGenerations.set(key, (this.#pollingThreadGenerations.get(key) ?? 0) + 1);
+	}
 	#getNotificationAgent(_input) {
 		if (this.#agent) return this.#agent;
 		const agentId = _input?.agentId ?? this.#options.agentId;
@@ -1063,6 +1082,9 @@ var GithubSignals = class extends _mastra_core_signals.SignalProvider {
 		const key = this.#pollingKey(input);
 		const state = this.#polling.get(key);
 		if (state?.running) return 0;
+		const generation = this.#pollingGeneration;
+		const threadGeneration = this.#pollingThreadGenerations.get(key) ?? 0;
+		const isCurrentGeneration = () => this.#pollingGeneration === generation && (this.#pollingThreadGenerations.get(key) ?? 0) === threadGeneration;
 		if (state) state.running = true;
 		this.#notifyPollingChanged({
 			threadId: input.threadId,
@@ -1071,6 +1093,7 @@ var GithubSignals = class extends _mastra_core_signals.SignalProvider {
 		});
 		try {
 			const { threadStore, loadedThread } = await this.#loadThread(input);
+			if (!isCurrentGeneration()) return 0;
 			const githubMetadata = getGithubMetadata(loadedThread.metadata);
 			if (githubMetadata.subscriptions.length === 0) {
 				this.stopPollingForThread(input);
@@ -1087,6 +1110,7 @@ var GithubSignals = class extends _mastra_core_signals.SignalProvider {
 					includeComments: options.includeComments
 				};
 				const syncResult = await this.#syncClient.syncPullRequest(syncInput);
+				if (!isCurrentGeneration()) return 0;
 				let snapshot;
 				let snapshotError;
 				if (syncResult.ok) try {
@@ -1094,7 +1118,9 @@ var GithubSignals = class extends _mastra_core_signals.SignalProvider {
 				} catch (error) {
 					snapshotError = error instanceof Error ? error.message : String(error);
 				}
-				if (snapshot) snapshot = await this.#filterUnauthorizedLatestComment(subscription.owner, subscription.repo, snapshot);
+				if (!isCurrentGeneration()) return 0;
+				if (snapshot) snapshot = await this.#filterUnauthorizedLatestComment(subscription.owner, subscription.repo, snapshot, isCurrentGeneration);
+				if (!isCurrentGeneration()) return 0;
 				const nextSubscription = {
 					...subscription,
 					updatedAt: now,
@@ -1117,15 +1143,17 @@ var GithubSignals = class extends _mastra_core_signals.SignalProvider {
 				const legacyAggregateChanged = previousContentHash && snapshot?.contentHash && previousContentHash !== snapshot.contentHash && !previousThreadContentHash && !previousHeadSha;
 				const changed = isFirstObservation || syncResult.ok && snapshot && (legacyAggregateChanged || latestCommentChanged || previousThreadContentHash && snapshot.threadContentHash && previousThreadContentHash !== snapshot.threadContentHash && !existingBotCommentEdited || previousHeadSha && snapshot.headSha && previousHeadSha !== snapshot.headSha || subscription.lastObservedState && snapshot.state && subscription.lastObservedState !== snapshot.state || hasMeaningfulMergeableStateChange(subscription.lastObservedMergeableState, snapshot.mergeableState) || subscription.lastObservedCiState && snapshot.ciState && subscription.lastObservedCiState !== snapshot.ciState || subscription.lastObservedReviewStateHash && snapshot.reviewStateHash && subscription.lastObservedReviewStateHash !== snapshot.reviewStateHash);
 				let shouldKeepSubscription = true;
-				if (changed && snapshot) {
+				if (changed && snapshot && isCurrentGeneration()) {
 					const notifications = await this.#sendActivityNotifications({
 						polling: input,
 						subscription,
 						snapshot,
 						previousGithubUpdatedAt,
 						previousContentHash,
-						latestCommentChanged
+						latestCommentChanged,
+						isCurrentGeneration
 					});
+					if (!isCurrentGeneration()) return 0;
 					const primaryNotification = notifications[0];
 					if (primaryNotification) {
 						nextSubscription.lastNotificationAt = now;
@@ -1137,6 +1165,7 @@ var GithubSignals = class extends _mastra_core_signals.SignalProvider {
 				}
 				if (shouldKeepSubscription) subscriptions.push(nextSubscription);
 			}
+			if (!isCurrentGeneration()) return 0;
 			await threadStore.saveThread({ thread: {
 				...loadedThread,
 				id: input.threadId,
@@ -1145,6 +1174,7 @@ var GithubSignals = class extends _mastra_core_signals.SignalProvider {
 				updatedAt: /* @__PURE__ */ new Date(),
 				metadata: setGithubMetadata(loadedThread.metadata, { subscriptions })
 			} });
+			if (!isCurrentGeneration()) return 0;
 			this.#notifySubscriptionsChanged({
 				threadId: input.threadId,
 				resourceId: input.resourceId,
@@ -1152,16 +1182,16 @@ var GithubSignals = class extends _mastra_core_signals.SignalProvider {
 			});
 			if (subscriptions.length === 0) this.stopPollingForThread(input);
 			return subscriptions.length;
-		} catch (error) {
-			throw error;
 		} finally {
 			const latestState = this.#polling.get(key);
-			if (latestState) latestState.running = false;
-			this.#notifyPollingChanged({
-				threadId: input.threadId,
-				resourceId: input.resourceId,
-				running: false
-			});
+			if (isCurrentGeneration()) {
+				if (latestState) latestState.running = false;
+				this.#notifyPollingChanged({
+					threadId: input.threadId,
+					resourceId: input.resourceId,
+					running: false
+				});
+			}
 		}
 	}
 	#createGithubNotificationInput(input) {
@@ -1253,18 +1283,19 @@ var GithubSignals = class extends _mastra_core_signals.SignalProvider {
 			dedupeSuffix: `baseline:${input.subscription.lastSubscribeSignalId}`
 		});
 	}
-	async #isAuthorizedAuthor(owner, repo, user, metadata = {}) {
+	async #isAuthorizedAuthor(owner, repo, user, metadata = {}, isCurrentGeneration) {
 		if (!user) return false;
 		const normalizedUser = user.toLowerCase();
 		if (metadata.isBot === true || metadata.authorType?.toLowerCase() === "bot" || normalizedUser.endsWith("[bot]")) {
 			if ((this.#options.ignoredBots ?? []).some((bot) => bot.toLowerCase() === normalizedUser)) return false;
 			return (this.#options.authorizedBots ?? DEFAULT_AUTHORIZED_BOTS).some((bot) => bot.toLowerCase() === normalizedUser);
 		}
-		const permission = await this.#loadAuthorPermission(owner, repo, user);
+		const permission = await this.#loadAuthorPermission(owner, repo, user, isCurrentGeneration);
+		if (isCurrentGeneration && !isCurrentGeneration()) return false;
 		const authorizedPermissions = this.#options.authorizedPermissions ?? DEFAULT_AUTHORIZED_PERMISSIONS;
 		return !!permission && authorizedPermissions.includes(permission);
 	}
-	async #filterUnauthorizedLatestComment(owner, repo, snapshot) {
+	async #filterUnauthorizedLatestComment(owner, repo, snapshot, isCurrentGeneration) {
 		const comments = snapshot.latestComments?.length ? snapshot.latestComments : [{
 			author: snapshot.latestCommentAuthor,
 			authorType: snapshot.latestCommentAuthorType,
@@ -1276,10 +1307,11 @@ var GithubSignals = class extends _mastra_core_signals.SignalProvider {
 		if (!comments.some((comment) => comment.author)) return snapshot;
 		if (!comments.some((comment) => comment.body || comment.url || comment.updatedAt)) return snapshot;
 		for (const comment of comments) {
+			if (isCurrentGeneration && !isCurrentGeneration()) return snapshot;
 			if (!await this.#isAuthorizedAuthor(owner, repo, comment.author, {
 				authorType: comment.authorType,
 				isBot: comment.isBot
-			})) continue;
+			}, isCurrentGeneration)) continue;
 			return {
 				...snapshot,
 				latestCommentAuthor: comment.author,
@@ -1300,7 +1332,7 @@ var GithubSignals = class extends _mastra_core_signals.SignalProvider {
 			latestCommentUpdatedAt: void 0
 		};
 	}
-	async #loadAuthorPermission(owner, repo, user) {
+	async #loadAuthorPermission(owner, repo, user, isCurrentGeneration) {
 		const cacheKey = `${owner}/${repo}:${user.toLowerCase()}`;
 		const cached = this.#permissionCache.get(cacheKey);
 		if (cached && cached.expiresAt > Date.now()) return cached.permission;
@@ -1325,10 +1357,11 @@ var GithubSignals = class extends _mastra_core_signals.SignalProvider {
 					"none"
 				].includes(raw) ? raw : void 0;
 			}
-			if (permission) this.#permissionCache.set(cacheKey, {
+			if (permission && (!isCurrentGeneration || isCurrentGeneration())) this.#permissionCache.set(cacheKey, {
 				permission,
 				expiresAt: Date.now() + PERMISSION_CACHE_TTL_MS
 			});
+			if (isCurrentGeneration && !isCurrentGeneration()) return void 0;
 			return permission;
 		} catch {
 			this.#permissionCache.delete(cacheKey);
@@ -1351,10 +1384,12 @@ var GithubSignals = class extends _mastra_core_signals.SignalProvider {
 		for (const notification of notifications.sort(compareGithubActivityNotifications)) {
 			if (!notification) continue;
 			if (AUTHOR_GATED_NOTIFICATION_KINDS.has(notification.kind)) {
-				if (!await this.#isAuthorizedAuthor(input.subscription.owner, input.subscription.repo, input.snapshot.latestCommentAuthor, {
+				const authorized = await this.#isAuthorizedAuthor(input.subscription.owner, input.subscription.repo, input.snapshot.latestCommentAuthor, {
 					authorType: input.snapshot.latestCommentAuthorType,
 					isBot: input.snapshot.latestCommentIsBot
-				})) continue;
+				}, input.isCurrentGeneration);
+				if (!input.isCurrentGeneration()) return [];
+				if (!authorized) continue;
 			}
 			notificationInputs.push(this.#createGithubNotificationInput({
 				subscription: input.subscription,
@@ -1371,11 +1406,14 @@ var GithubSignals = class extends _mastra_core_signals.SignalProvider {
 				resourceId: input.polling.resourceId,
 				threadId: input.polling.threadId
 			};
+			if (!input.isCurrentGeneration()) return [];
 			const streamOptions = await this.#agentOptions.getNotificationStreamOptions?.(target);
+			if (!input.isCurrentGeneration()) return [];
 			await agent.sendNotificationSignal(notificationInputs, streamOptions ? {
 				...target,
 				ifIdle: { streamOptions }
 			} : target);
+			if (!input.isCurrentGeneration()) return [];
 		}
 		return sent;
 	}