@mastra/github-signals 0.2.3 → 0.2.5-alpha.0

package/CHANGELOG.md

@@ -1,5 +1,23 @@
 # @mastra/github-signals
 
+## 0.2.5-alpha.0
+
+### Patch Changes
+
+- Fixed GitHub polling so stopping a poll prevents in-flight work from sending notifications or writing subscription state. ([#20593](https://github.com/mastra-ai/mastra/pull/20593))
+
+- Updated dependencies [[`cdd5c33`](https://github.com/mastra-ai/mastra/commit/cdd5c33ac6c7118a9f139e6dc0e14e6a8ae31658), [`d7cf7fa`](https://github.com/mastra-ai/mastra/commit/d7cf7fafc1ae1b50bd8462dd0e6c671a8606db93), [`0f9a448`](https://github.com/mastra-ai/mastra/commit/0f9a448502157e59f7b76f24360ad497168f5ef8), [`289f4ce`](https://github.com/mastra-ai/mastra/commit/289f4ce16e3293370440172132c52ee787cbc09f), [`4f16ff8`](https://github.com/mastra-ai/mastra/commit/4f16ff824bf2f9b0ddc93f210477c10c8a4fb1ab), [`1c67d85`](https://github.com/mastra-ai/mastra/commit/1c67d85e9da8285662f4dbbf47e0378c3fee0747), [`ba24be6`](https://github.com/mastra-ai/mastra/commit/ba24be662439c331ab23a600041f93803c89eca8), [`842b5fe`](https://github.com/mastra-ai/mastra/commit/842b5fe22b6a7fa811bd14e48eb9af523ac989f2), [`80bdf3a`](https://github.com/mastra-ai/mastra/commit/80bdf3ae16ade6ff63bde0cb16fa2df8ab7dd4dd), [`9ba1247`](https://github.com/mastra-ai/mastra/commit/9ba12470c77f1c03642d720ce67e517e878f666e), [`fd96298`](https://github.com/mastra-ai/mastra/commit/fd96298a8367622f4ebfcaa97b5b6c1fbbd14564), [`6a84954`](https://github.com/mastra-ai/mastra/commit/6a84954a2667f85b6d59da652dab1bbff007ccb0), [`52d8ef0`](https://github.com/mastra-ai/mastra/commit/52d8ef03801f1deb7ee48532fc4190dd4a33916c), [`cdd5c33`](https://github.com/mastra-ai/mastra/commit/cdd5c33ac6c7118a9f139e6dc0e14e6a8ae31658), [`efd5c81`](https://github.com/mastra-ai/mastra/commit/efd5c81cc25fde3c2ddd86fc1178deb4ec176e19), [`0976933`](https://github.com/mastra-ai/mastra/commit/0976933142333ec78451feef265b68bcb45aa5e7), [`242b945`](https://github.com/mastra-ai/mastra/commit/242b94558777bfbdeb42cbfea84afff0b6ad0633), [`fea5cae`](https://github.com/mastra-ai/mastra/commit/fea5caedc7e2cfea51784a15e015952692027abf), [`4b59f78`](https://github.com/mastra-ai/mastra/commit/4b59f786cbc9a7d1ef07a07517dbd4b96865e99d), [`7010c5d`](https://github.com/mastra-ai/mastra/commit/7010c5d15728bf9c5dfe4fb6b1bf80ce23bf143a)]:
+  - @mastra/core@1.58.0-alpha.3
+
+## 0.2.4
+
+### Patch Changes
+
+- Fixed duplicate GitHub signal notifications caused by transient mergeability checks and edits to already-observed bot comments. ([#20736](https://github.com/mastra-ai/mastra/pull/20736))
+
+- Updated dependencies [[`8d2399b`](https://github.com/mastra-ai/mastra/commit/8d2399b638f8e0945cf2cda0187dbea8dcf0b784), [`c8002da`](https://github.com/mastra-ai/mastra/commit/c8002da7775c468e2965b6ff5f82045450fa8cb9), [`92be47f`](https://github.com/mastra-ai/mastra/commit/92be47fbd26ffccec0e2131ef7c1d9e70dd5ef4a), [`89200ba`](https://github.com/mastra-ai/mastra/commit/89200bafa05444bb7949b363ce7b743e29867561), [`c950138`](https://github.com/mastra-ai/mastra/commit/c950138e72e4f317a40187e3800588731ab790ce), [`810c7e7`](https://github.com/mastra-ai/mastra/commit/810c7e74929989d8b8b5db52cd3af22cd0998af4), [`063c8b2`](https://github.com/mastra-ai/mastra/commit/063c8b2eb14e4e5ca021779bc33e8c3c031c8604), [`f9f9884`](https://github.com/mastra-ai/mastra/commit/f9f98848ee194dc71a787a709ec430b065cdc41b), [`e0904dc`](https://github.com/mastra-ai/mastra/commit/e0904dc538792e54e1806b70172e5900ac49bff4), [`9672fab`](https://github.com/mastra-ai/mastra/commit/9672fabfbcadb961a35c22a2d6722e077f7b24b9), [`f4e964c`](https://github.com/mastra-ai/mastra/commit/f4e964cad57057301d6bed5c55bcdd730175b941), [`1f7bbd7`](https://github.com/mastra-ai/mastra/commit/1f7bbd7785a8d230aad02454ecabeb4a0b2cc96f), [`e47ff36`](https://github.com/mastra-ai/mastra/commit/e47ff36945720f4ee4caa09f6e83514d7d188608), [`64d6781`](https://github.com/mastra-ai/mastra/commit/64d67814bccddd314f7e09643243821e57cb87b6), [`fb9a6ac`](https://github.com/mastra-ai/mastra/commit/fb9a6ac11c9560518742ece60b49d6b062845fd3), [`aa2cec8`](https://github.com/mastra-ai/mastra/commit/aa2cec8501f634d51c2f3ebfb3dd3aa7af8d2ca2), [`c848e65`](https://github.com/mastra-ai/mastra/commit/c848e655a64ff10331a8ceafafe7f18e70a0f092), [`2adf8eb`](https://github.com/mastra-ai/mastra/commit/2adf8eb4a70ed2b6cff2dd39281496ea0e025fac), [`0494489`](https://github.com/mastra-ai/mastra/commit/049448906e4c3d2d615bbe865b073a0d890ddb7c), [`8d1aeb8`](https://github.com/mastra-ai/mastra/commit/8d1aeb8acf7c20c4bb8e4d8e4bdc6569c83ac561), [`8264611`](https://github.com/mastra-ai/mastra/commit/8264611510e421b818bc7395dc2ae4d9c2d518b2), [`d8fa243`](https://github.com/mastra-ai/mastra/commit/d8fa2430d21113e330c4e676ac65e1235cf44f81), [`44fc98b`](https://github.com/mastra-ai/mastra/commit/44fc98b9d1242aa87a3ab44bdce9e9f12c44d8c9), [`f933ba3`](https://github.com/mastra-ai/mastra/commit/f933ba32700e1d0bf143311c1a08f88300b840b6), [`83065bf`](https://github.com/mastra-ai/mastra/commit/83065bfee9e47c3c6f09132a9034501f6cfb69cf), [`0f2ef41`](https://github.com/mastra-ai/mastra/commit/0f2ef4118da022e4f30dac4e9856cc3a8c97671c), [`01b162f`](https://github.com/mastra-ai/mastra/commit/01b162fe435295881aa7ea55f1759407ad5175ad)]:
+  - @mastra/core@1.57.0
+
 ## 0.2.3
 
 ### Patch Changes

package/dist/index.cjs

@@ -135,6 +135,9 @@ function getGithubMetadata(threadMetadata) {
 			...readString(rawSubscription.lastObservedMergeableState) ? { lastObservedMergeableState: readString(rawSubscription.lastObservedMergeableState) } : {},
 			...readString(rawSubscription.lastObservedCiState) ? { lastObservedCiState: readString(rawSubscription.lastObservedCiState) } : {},
 			...readString(rawSubscription.lastObservedReviewStateHash) ? { lastObservedReviewStateHash: readString(rawSubscription.lastObservedReviewStateHash) } : {},
+			...readString(rawSubscription.lastObservedCommentUrl) ? { lastObservedCommentUrl: readString(rawSubscription.lastObservedCommentUrl) } : {},
+			...readString(rawSubscription.lastObservedCommentAuthor) ? { lastObservedCommentAuthor: readString(rawSubscription.lastObservedCommentAuthor) } : {},
+			...typeof rawSubscription.lastObservedCommentIsBot === "boolean" ? { lastObservedCommentIsBot: rawSubscription.lastObservedCommentIsBot } : {},
 			...readString(rawSubscription.lastNotificationAt) ? { lastNotificationAt: readString(rawSubscription.lastNotificationAt) } : {},
 			...readString(rawSubscription.lastNotificationKind) ? { lastNotificationKind: readString(rawSubscription.lastNotificationKind) } : {},
 			...rawSubscription.lastNotificationPriority === "medium" || rawSubscription.lastNotificationPriority === "high" ? { lastNotificationPriority: rawSubscription.lastNotificationPriority } : {},
@@ -317,6 +320,16 @@ function normalizeGithubChecksForSnapshot(input) {
 function isBotOnlyActivity(snapshot) {
 	return snapshot.latestCommentIsBot === true && (!snapshot.ciState || snapshot.ciState === "unknown");
 }
+function isKnownMergeableState(state) {
+	return !!state && state.toLowerCase() !== "unknown";
+}
+function hasMeaningfulMergeableStateChange(previous, current) {
+	if (!isKnownMergeableState(current) || current === previous) return false;
+	return current === "dirty" || previous === "dirty" || isKnownMergeableState(previous);
+}
+function isExistingBotCommentEdit(subscription, snapshot) {
+	return snapshot.latestCommentIsBot === true && subscription.lastObservedCommentIsBot === true && !!snapshot.latestCommentUrl && snapshot.latestCommentUrl === subscription.lastObservedCommentUrl && !!snapshot.latestCommentAuthor && snapshot.latestCommentAuthor === subscription.lastObservedCommentAuthor;
+}
 function stringifyEvidence(value) {
 	if (typeof value === "string") return value;
 	try {
@@ -378,7 +391,7 @@ function classifyGithubActivityNotification(input) {
 		priority: "high",
 		summary: `${pr} has merge conflicts${input.snapshot.title ? `: ${input.snapshot.title}` : ""}`
 	};
-	if (input.snapshot.mergeableState && input.subscription.lastObservedMergeableState === "dirty" && input.snapshot.mergeableState !== "dirty") return {
+	if (isKnownMergeableState(input.snapshot.mergeableState) && input.subscription.lastObservedMergeableState === "dirty" && input.snapshot.mergeableState !== "dirty") return {
 		kind: "pull-request-conflict-resolved",
 		priority: "medium",
 		summary: `${pr} merge conflicts were resolved`
@@ -436,9 +449,12 @@ function applySnapshotCursor(subscription, snapshot) {
 	if (snapshot.threadContentHash) subscription.lastObservedThreadContentHash = snapshot.threadContentHash;
 	if (snapshot.headSha) subscription.lastObservedHeadSha = snapshot.headSha;
 	if (snapshot.state) subscription.lastObservedState = snapshot.state;
-	if (snapshot.mergeableState) subscription.lastObservedMergeableState = snapshot.mergeableState;
+	if (isKnownMergeableState(snapshot.mergeableState)) subscription.lastObservedMergeableState = snapshot.mergeableState;
 	if (snapshot.ciState) subscription.lastObservedCiState = snapshot.ciState;
 	if (snapshot.reviewStateHash) subscription.lastObservedReviewStateHash = snapshot.reviewStateHash;
+	if (snapshot.latestCommentUrl) subscription.lastObservedCommentUrl = snapshot.latestCommentUrl;
+	if (snapshot.latestCommentAuthor) subscription.lastObservedCommentAuthor = snapshot.latestCommentAuthor;
+	if (snapshot.latestCommentIsBot !== void 0) subscription.lastObservedCommentIsBot = snapshot.latestCommentIsBot;
 }
 function parseGitHubRemoteUrl(remoteUrl) {
 	const trimmed = remoteUrl.trim().replace(/\.git$/, "");
@@ -724,6 +740,8 @@ var GithubSignals = class extends _mastra_core_signals.SignalProvider {
 	#syncClient;
 	#repositoryResolver;
 	#polling = /* @__PURE__ */ new Map();
+	#pollingThreadGenerations = /* @__PURE__ */ new Map();
+	#pollingGeneration = 0;
 	#permissionCache = /* @__PURE__ */ new Map();
 	#agent;
 	#agentOptions = {};
@@ -797,6 +815,7 @@ var GithubSignals = class extends _mastra_core_signals.SignalProvider {
 		const key = this.#pollingKey(input);
 		for (const [pollingKey, state] of this.#polling.entries()) {
 			if (pollingKey === key) continue;
+			this.#invalidatePollingThread(pollingKey);
 			clearInterval(state.timer);
 			this.#polling.delete(pollingKey);
 		}
@@ -820,6 +839,7 @@ var GithubSignals = class extends _mastra_core_signals.SignalProvider {
 	}
 	stopPollingForThread(input) {
 		const key = this.#pollingKey(input);
+		this.#invalidatePollingThread(key);
 		const state = this.#polling.get(key);
 		if (!state) return;
 		clearInterval(state.timer);
@@ -835,6 +855,8 @@ var GithubSignals = class extends _mastra_core_signals.SignalProvider {
 		return this.#options.pollIntervalMs ?? 3e5;
 	}
 	stopAllPolling() {
+		this.#pollingGeneration++;
+		this.#pollingThreadGenerations.clear();
 		for (const state of this.#polling.values()) clearInterval(state.timer);
 		this.#polling.clear();
 	}
@@ -1028,6 +1050,9 @@ var GithubSignals = class extends _mastra_core_signals.SignalProvider {
 	#pollingKey(input) {
 		return `${input.resourceId}:${input.threadId}`;
 	}
+	#invalidatePollingThread(key) {
+		this.#pollingThreadGenerations.set(key, (this.#pollingThreadGenerations.get(key) ?? 0) + 1);
+	}
 	#getNotificationAgent(_input) {
 		if (this.#agent) return this.#agent;
 		const agentId = _input?.agentId ?? this.#options.agentId;
@@ -1047,6 +1072,9 @@ var GithubSignals = class extends _mastra_core_signals.SignalProvider {
 		const key = this.#pollingKey(input);
 		const state = this.#polling.get(key);
 		if (state?.running) return 0;
+		const generation = this.#pollingGeneration;
+		const threadGeneration = this.#pollingThreadGenerations.get(key) ?? 0;
+		const isCurrentGeneration = () => this.#pollingGeneration === generation && (this.#pollingThreadGenerations.get(key) ?? 0) === threadGeneration;
 		if (state) state.running = true;
 		this.#notifyPollingChanged({
 			threadId: input.threadId,
@@ -1055,6 +1083,7 @@ var GithubSignals = class extends _mastra_core_signals.SignalProvider {
 		});
 		try {
 			const { threadStore, loadedThread } = await this.#loadThread(input);
+			if (!isCurrentGeneration()) return 0;
 			const githubMetadata = getGithubMetadata(loadedThread.metadata);
 			if (githubMetadata.subscriptions.length === 0) {
 				this.stopPollingForThread(input);
@@ -1071,6 +1100,7 @@ var GithubSignals = class extends _mastra_core_signals.SignalProvider {
 					includeComments: options.includeComments
 				};
 				const syncResult = await this.#syncClient.syncPullRequest(syncInput);
+				if (!isCurrentGeneration()) return 0;
 				let snapshot;
 				let snapshotError;
 				if (syncResult.ok) try {
@@ -1078,7 +1108,9 @@ var GithubSignals = class extends _mastra_core_signals.SignalProvider {
 				} catch (error) {
 					snapshotError = error instanceof Error ? error.message : String(error);
 				}
-				if (snapshot) snapshot = await this.#filterUnauthorizedLatestComment(subscription.owner, subscription.repo, snapshot);
+				if (!isCurrentGeneration()) return 0;
+				if (snapshot) snapshot = await this.#filterUnauthorizedLatestComment(subscription.owner, subscription.repo, snapshot, isCurrentGeneration);
+				if (!isCurrentGeneration()) return 0;
 				const nextSubscription = {
 					...subscription,
 					updatedAt: now,
@@ -1093,21 +1125,25 @@ var GithubSignals = class extends _mastra_core_signals.SignalProvider {
 				const previousContentHash = subscription.lastObservedContentHash;
 				const previousThreadContentHash = subscription.lastObservedThreadContentHash;
 				const previousHeadSha = subscription.lastObservedHeadSha;
-				const latestCommentChanged = !!previousGithubUpdatedAt && !!snapshot?.latestCommentUpdatedAt && Date.parse(snapshot.latestCommentUpdatedAt) > Date.parse(previousGithubUpdatedAt);
+				const latestCommentTimestampChanged = !!previousGithubUpdatedAt && !!snapshot?.latestCommentUpdatedAt && Date.parse(snapshot.latestCommentUpdatedAt) > Date.parse(previousGithubUpdatedAt);
+				const existingBotCommentEdited = latestCommentTimestampChanged && !!snapshot && isExistingBotCommentEdit(subscription, snapshot);
+				const latestCommentChanged = latestCommentTimestampChanged && !existingBotCommentEdited;
 				if (snapshot) applySnapshotCursor(nextSubscription, snapshot);
 				const isFirstObservation = syncResult.ok && snapshot && !previousGithubUpdatedAt && !previousContentHash;
 				const legacyAggregateChanged = previousContentHash && snapshot?.contentHash && previousContentHash !== snapshot.contentHash && !previousThreadContentHash && !previousHeadSha;
-				const changed = isFirstObservation || syncResult.ok && snapshot && (legacyAggregateChanged || latestCommentChanged || previousThreadContentHash && snapshot.threadContentHash && previousThreadContentHash !== snapshot.threadContentHash || previousHeadSha && snapshot.headSha && previousHeadSha !== snapshot.headSha || subscription.lastObservedState && snapshot.state && subscription.lastObservedState !== snapshot.state || subscription.lastObservedMergeableState && snapshot.mergeableState && subscription.lastObservedMergeableState !== snapshot.mergeableState || subscription.lastObservedCiState && snapshot.ciState && subscription.lastObservedCiState !== snapshot.ciState || subscription.lastObservedReviewStateHash && snapshot.reviewStateHash && subscription.lastObservedReviewStateHash !== snapshot.reviewStateHash);
+				const changed = isFirstObservation || syncResult.ok && snapshot && (legacyAggregateChanged || latestCommentChanged || previousThreadContentHash && snapshot.threadContentHash && previousThreadContentHash !== snapshot.threadContentHash && !existingBotCommentEdited || previousHeadSha && snapshot.headSha && previousHeadSha !== snapshot.headSha || subscription.lastObservedState && snapshot.state && subscription.lastObservedState !== snapshot.state || hasMeaningfulMergeableStateChange(subscription.lastObservedMergeableState, snapshot.mergeableState) || subscription.lastObservedCiState && snapshot.ciState && subscription.lastObservedCiState !== snapshot.ciState || subscription.lastObservedReviewStateHash && snapshot.reviewStateHash && subscription.lastObservedReviewStateHash !== snapshot.reviewStateHash);
 				let shouldKeepSubscription = true;
-				if (changed && snapshot) {
+				if (changed && snapshot && isCurrentGeneration()) {
 					const notifications = await this.#sendActivityNotifications({
 						polling: input,
 						subscription,
 						snapshot,
 						previousGithubUpdatedAt,
 						previousContentHash,
-						latestCommentChanged
+						latestCommentChanged,
+						isCurrentGeneration
 					});
+					if (!isCurrentGeneration()) return 0;
 					const primaryNotification = notifications[0];
 					if (primaryNotification) {
 						nextSubscription.lastNotificationAt = now;
@@ -1119,6 +1155,7 @@ var GithubSignals = class extends _mastra_core_signals.SignalProvider {
 				}
 				if (shouldKeepSubscription) subscriptions.push(nextSubscription);
 			}
+			if (!isCurrentGeneration()) return 0;
 			await threadStore.saveThread({ thread: {
 				...loadedThread,
 				id: input.threadId,
@@ -1127,6 +1164,7 @@ var GithubSignals = class extends _mastra_core_signals.SignalProvider {
 				updatedAt: /* @__PURE__ */ new Date(),
 				metadata: setGithubMetadata(loadedThread.metadata, { subscriptions })
 			} });
+			if (!isCurrentGeneration()) return 0;
 			this.#notifySubscriptionsChanged({
 				threadId: input.threadId,
 				resourceId: input.resourceId,
@@ -1134,16 +1172,16 @@ var GithubSignals = class extends _mastra_core_signals.SignalProvider {
 			});
 			if (subscriptions.length === 0) this.stopPollingForThread(input);
 			return subscriptions.length;
-		} catch (error) {
-			throw error;
 		} finally {
 			const latestState = this.#polling.get(key);
-			if (latestState) latestState.running = false;
-			this.#notifyPollingChanged({
-				threadId: input.threadId,
-				resourceId: input.resourceId,
-				running: false
-			});
+			if (isCurrentGeneration()) {
+				if (latestState) latestState.running = false;
+				this.#notifyPollingChanged({
+					threadId: input.threadId,
+					resourceId: input.resourceId,
+					running: false
+				});
+			}
 		}
 	}
 	#createGithubNotificationInput(input) {
@@ -1235,18 +1273,19 @@ var GithubSignals = class extends _mastra_core_signals.SignalProvider {
 			dedupeSuffix: `baseline:${input.subscription.lastSubscribeSignalId}`
 		});
 	}
-	async #isAuthorizedAuthor(owner, repo, user, metadata = {}) {
+	async #isAuthorizedAuthor(owner, repo, user, metadata = {}, isCurrentGeneration) {
 		if (!user) return false;
 		const normalizedUser = user.toLowerCase();
 		if (metadata.isBot === true || metadata.authorType?.toLowerCase() === "bot" || normalizedUser.endsWith("[bot]")) {
 			if ((this.#options.ignoredBots ?? []).some((bot) => bot.toLowerCase() === normalizedUser)) return false;
 			return (this.#options.authorizedBots ?? DEFAULT_AUTHORIZED_BOTS).some((bot) => bot.toLowerCase() === normalizedUser);
 		}
-		const permission = await this.#loadAuthorPermission(owner, repo, user);
+		const permission = await this.#loadAuthorPermission(owner, repo, user, isCurrentGeneration);
+		if (isCurrentGeneration && !isCurrentGeneration()) return false;
 		const authorizedPermissions = this.#options.authorizedPermissions ?? DEFAULT_AUTHORIZED_PERMISSIONS;
 		return !!permission && authorizedPermissions.includes(permission);
 	}
-	async #filterUnauthorizedLatestComment(owner, repo, snapshot) {
+	async #filterUnauthorizedLatestComment(owner, repo, snapshot, isCurrentGeneration) {
 		const comments = snapshot.latestComments?.length ? snapshot.latestComments : [{
 			author: snapshot.latestCommentAuthor,
 			authorType: snapshot.latestCommentAuthorType,
@@ -1258,10 +1297,11 @@ var GithubSignals = class extends _mastra_core_signals.SignalProvider {
 		if (!comments.some((comment) => comment.author)) return snapshot;
 		if (!comments.some((comment) => comment.body || comment.url || comment.updatedAt)) return snapshot;
 		for (const comment of comments) {
+			if (isCurrentGeneration && !isCurrentGeneration()) return snapshot;
 			if (!await this.#isAuthorizedAuthor(owner, repo, comment.author, {
 				authorType: comment.authorType,
 				isBot: comment.isBot
-			})) continue;
+			}, isCurrentGeneration)) continue;
 			return {
 				...snapshot,
 				latestCommentAuthor: comment.author,
@@ -1282,7 +1322,7 @@ var GithubSignals = class extends _mastra_core_signals.SignalProvider {
 			latestCommentUpdatedAt: void 0
 		};
 	}
-	async #loadAuthorPermission(owner, repo, user) {
+	async #loadAuthorPermission(owner, repo, user, isCurrentGeneration) {
 		const cacheKey = `${owner}/${repo}:${user.toLowerCase()}`;
 		const cached = this.#permissionCache.get(cacheKey);
 		if (cached && cached.expiresAt > Date.now()) return cached.permission;
@@ -1307,10 +1347,11 @@ var GithubSignals = class extends _mastra_core_signals.SignalProvider {
 					"none"
 				].includes(raw) ? raw : void 0;
 			}
-			if (permission) this.#permissionCache.set(cacheKey, {
+			if (permission && (!isCurrentGeneration || isCurrentGeneration())) this.#permissionCache.set(cacheKey, {
 				permission,
 				expiresAt: Date.now() + PERMISSION_CACHE_TTL_MS
 			});
+			if (isCurrentGeneration && !isCurrentGeneration()) return void 0;
 			return permission;
 		} catch {
 			this.#permissionCache.delete(cacheKey);
@@ -1333,10 +1374,12 @@ var GithubSignals = class extends _mastra_core_signals.SignalProvider {
 		for (const notification of notifications.sort(compareGithubActivityNotifications)) {
 			if (!notification) continue;
 			if (AUTHOR_GATED_NOTIFICATION_KINDS.has(notification.kind)) {
-				if (!await this.#isAuthorizedAuthor(input.subscription.owner, input.subscription.repo, input.snapshot.latestCommentAuthor, {
+				const authorized = await this.#isAuthorizedAuthor(input.subscription.owner, input.subscription.repo, input.snapshot.latestCommentAuthor, {
 					authorType: input.snapshot.latestCommentAuthorType,
 					isBot: input.snapshot.latestCommentIsBot
-				})) continue;
+				}, input.isCurrentGeneration);
+				if (!input.isCurrentGeneration()) return [];
+				if (!authorized) continue;
 			}
 			notificationInputs.push(this.#createGithubNotificationInput({
 				subscription: input.subscription,
@@ -1353,11 +1396,14 @@ var GithubSignals = class extends _mastra_core_signals.SignalProvider {
 				resourceId: input.polling.resourceId,
 				threadId: input.polling.threadId
 			};
+			if (!input.isCurrentGeneration()) return [];
 			const streamOptions = await this.#agentOptions.getNotificationStreamOptions?.(target);
+			if (!input.isCurrentGeneration()) return [];
 			await agent.sendNotificationSignal(notificationInputs, streamOptions ? {
 				...target,
 				ifIdle: { streamOptions }
 			} : target);
+			if (!input.isCurrentGeneration()) return [];
 		}
 		return sent;
 	}
@@ -1392,7 +1438,10 @@ var GithubSignals = class extends _mastra_core_signals.SignalProvider {
 			...existing?.lastObservedState ? { lastObservedState: existing.lastObservedState } : {},
 			...existing?.lastObservedMergeableState ? { lastObservedMergeableState: existing.lastObservedMergeableState } : {},
 			...existing?.lastObservedCiState ? { lastObservedCiState: existing.lastObservedCiState } : {},
-			...existing?.lastObservedReviewStateHash ? { lastObservedReviewStateHash: existing.lastObservedReviewStateHash } : {}
+			...existing?.lastObservedReviewStateHash ? { lastObservedReviewStateHash: existing.lastObservedReviewStateHash } : {},
+			...existing?.lastObservedCommentUrl ? { lastObservedCommentUrl: existing.lastObservedCommentUrl } : {},
+			...existing?.lastObservedCommentAuthor ? { lastObservedCommentAuthor: existing.lastObservedCommentAuthor } : {},
+			...typeof existing?.lastObservedCommentIsBot === "boolean" ? { lastObservedCommentIsBot: existing.lastObservedCommentIsBot } : {}
 		};
 		let syncResult;
 		let baselineSnapshot;