@mastra/factory 0.18.0 → 0.19.0-alpha.1

package/dist/rules/dispatcher.js

@@ -8,10 +8,10 @@ import { moveCardToBoard } from "../boards/relocate.js";
 import { FactoryDispatchError, factoryDispatchFailureCode, factoryDispatchFailureMetadata } from "./dispatch-errors.js";
 import { isHumanActorId } from "../storage/domains/audit/actors.js";
 import { resolvePromptInvocation, resolveSkillInvocation, resolveSkillResumeInvocation } from "../skills/service.js";
+import { decisionOvertaken } from "./decision-applicability.js";
 import { FACTORY_OPEN_RUN_STALE_MS, heartbeatSessionOpenRun, isOpenRunLiveElsewhere, listSessionOpenRuns, recordSessionRunStart, waitForSessionRunAudit } from "../session/run-audit.js";
 import { withWorkItemFeed } from "../storage/domains/comments/feed-context.js";
 import { RequestContext } from "@mastra/core/request-context";
-import { randomUUID } from "crypto";
 //#region src/rules/dispatcher.ts
 const LEASE_MS = 3e4;
 const POLL_MS = 1e3;
@@ -34,6 +34,8 @@ const BOOKKEEPING_MAX_IN_FLIGHT = 4;
 const STALE_BINDING_SWEEP_INTERVAL_MS = 10 * 6e4;
 const STALE_BINDING_TTL_MS = 1440 * 6e4;
 const RECONCILE_INTERVAL_MS = 3e4;
+/** The card moved on before this run could act; it settles as superseded, not succeeded. */
+var FactoryDecisionSuperseded = class extends Error {};
 function isTerminalFailure(attempts, failureCode) {
 	return attempts >= MAX_ATTEMPTS || !factoryDispatchFailureMetadata(failureCode).canRetry;
 }
@@ -245,6 +247,7 @@ var FactoryDecisionDispatcher = class {
 	#refreshManagedMemorySettings;
 	#primeCredentials;
 	#feedReader;
+	#dismissStaleReviews;
 	#resolveLinkedWorkItemParentId;
 	#maxInFlight;
 	#staleBindingSweepIntervalMs;
@@ -269,7 +272,7 @@ var FactoryDecisionDispatcher = class {
 		this.#transitionService = options.transitionService;
 		this.#boards = options.boards ?? createBoardRegistry();
 		this.#storage = options.storage;
-		this.#ownerId = options.ownerId ?? `factory-dispatcher:${randomUUID()}`;
+		this.#ownerId = options.ownerId ?? `factory-dispatcher:${globalThis.crypto.randomUUID()}`;
 		this.#isAutoRunEnabled = options.isAutoRunEnabled;
 		this.#autoApprovePlans = options.autoApprovePlans;
 		this.#reconcileToolResults = options.reconcileToolResults;
@@ -277,6 +280,7 @@ var FactoryDecisionDispatcher = class {
 		this.#refreshManagedMemorySettings = options.refreshManagedMemorySettings;
 		this.#primeCredentials = options.primeCredentials;
 		this.#feedReader = options.feedReader;
+		this.#dismissStaleReviews = options.dismissStaleReviews;
 		this.#resolveLinkedWorkItemParentId = options.resolveLinkedWorkItemParentId;
 		const maxInFlight = options.maxInFlight ?? MAX_IN_FLIGHT;
 		this.#maxInFlight = Number.isFinite(maxInFlight) && maxInFlight > 0 ? Math.floor(maxInFlight) : MAX_IN_FLIGHT;
@@ -417,6 +421,10 @@ var FactoryDecisionDispatcher = class {
 			executionCompleted = true;
 			if (!await this.#storage.completeDeferredDecision(leaseIdentity(record, this.#ownerId), /* @__PURE__ */ new Date())) throw new Error("Factory decision lease was lost before completion.");
 		} catch (error) {
+			if (error instanceof FactoryDecisionSuperseded) {
+				await this.#storage.supersedeLeasedDecision(leaseIdentity(record, this.#ownerId), /* @__PURE__ */ new Date());
+				return;
+			}
 			const failureCode = factoryDispatchFailureCode(error);
 			const terminal = isTerminalFailure(record.attempts, failureCode);
 			const failed = await this.#storage.failDeferredDecision({
@@ -565,7 +573,7 @@ var FactoryDecisionDispatcher = class {
 				await this.#upsertLinkedItem(record, decision, nextChain);
 				return;
 			case "invokeSkill": {
-				if (await this.#roleSuperseded(record, decision.role)) return;
+				if (await this.#roleSuperseded(record, decision.role) || await this.#decisionOvertaken(record, decision.role)) throw new FactoryDecisionSuperseded();
 				const binding = await this.#requireOrPrepareBinding(record, decision.role);
 				await this.#withBindingSkillRun(binding.id, async () => {
 					const item = record.workItemId ? await this.#storage.get({
@@ -600,24 +608,7 @@ var FactoryDecisionDispatcher = class {
 					await this.#switchThread(session, binding);
 					const deliveryId = record.deliveryGeneration === 0 ? record.id : `${record.id}:retry:${record.deliveryGeneration}`;
 					const kickoffLanded = async () => (await session.thread.listActiveMessages()).some((message) => message.id === deliveryId);
-					const kickoffStale = async () => {
-						if (await this.#roleSuperseded(record, decision.role)) return true;
-						if ((await this.#findBinding(record, decision.role))?.id !== binding.id) return true;
-						if (!record.workItemId) return false;
-						const current = await this.#storage.get({
-							orgId: record.orgId,
-							id: record.workItemId
-						});
-						if (current === null) return true;
-						const decidedAt = record.createdAt.getTime();
-						const enteredSince = current.stageHistory.filter((entry) => entry.exitedAt === void 0 && new Date(entry.enteredAt).getTime() > decidedAt);
-						const board = boardForWorkItem(current);
-						const carriesRole = (stage) => resolvePhaseSemantics(this.#boards, board, stage)?.role === decision.role;
-						const movedOn = !current.stageHistory.some((entry) => new Date(entry.enteredAt).getTime() <= decidedAt && (entry.exitedAt === void 0 || new Date(entry.exitedAt).getTime() > decidedAt) && carriesRole(entry.stage)) ? enteredSince.filter((entry) => !carriesRole(entry.stage)) : enteredSince;
-						if (movedOn.length === 0) return false;
-						const siblingStages = new Set((await this.#storage.listDeferredDecisions(record.orgId, record.factoryProjectId)).filter((sibling) => sibling.evaluationId === record.evaluationId && sibling.decision.type === "transition").map((sibling) => sibling.decision.stage));
-						return movedOn.some((entry) => !siblingStages.has(entry.stage));
-					};
+					const kickoffStale = async () => await this.#roleSuperseded(record, decision.role) || (await this.#findBinding(record, decision.role))?.id !== binding.id || await this.#decisionOvertaken(record, decision.role);
 					const runStillActive = () => this.#controller.listActiveThreadRuns().some((active) => active.threadId === binding.threadId);
 					while (true) {
 						const openRun = watchRun(session, {
@@ -637,10 +628,10 @@ var FactoryDecisionDispatcher = class {
 						}
 						await waitForSessionRunAudit(session);
 					}
-					if (await this.#roleSuperseded(record, decision.role)) return;
+					if (await this.#roleSuperseded(record, decision.role)) throw new FactoryDecisionSuperseded();
 					if ((await this.#requireBinding(record, decision.role)).id !== binding.id) throw new FactoryDispatchError("session_unavailable", `Factory binding ${binding.id} changed while waiting for its open run to end.`);
 					if (await kickoffLanded()) return;
-					if (await kickoffStale()) return;
+					if (await kickoffStale()) throw new FactoryDecisionSuperseded();
 					const kickoffContents = await withWorkItemFeed(this.#feedReader, {
 						orgId: record.orgId,
 						factoryProjectId: record.factoryProjectId,
@@ -687,7 +678,7 @@ var FactoryDecisionDispatcher = class {
 							if (await kickoffLanded()) break;
 							if (!await run.wait()) throw new FactoryDispatchError("run_terminal_event_missing", "Factory skill invocation is waiting on a run whose terminal event was not observed.");
 							if (await kickoffLanded()) break;
-							if (await kickoffStale()) return;
+							if (await kickoffStale()) throw new FactoryDecisionSuperseded();
 							run.arm();
 							settled = await sendKickoff();
 						}
@@ -737,6 +728,10 @@ var FactoryDecisionDispatcher = class {
 				}), true);
 				return;
 			}
+			case "dismissStaleReviews":
+				if (!this.#dismissStaleReviews) throw new Error("GitHub review dismissal is not configured.");
+				await this.#dismissStaleReviews(decision);
+				return;
 			case "notify": {
 				const binding = await this.#requireBinding(record);
 				const session = await this.#requireSession(binding);
@@ -944,6 +939,20 @@ var FactoryDecisionDispatcher = class {
 	* fresh decision for the role (the card came back to it) must still dispatch
 	* even though an older revoked binding for that role is on record.
 	*/
+	async #decisionOvertaken(record, role) {
+		if (!record.workItemId) return false;
+		const [item, siblings] = await Promise.all([this.#storage.get({
+			orgId: record.orgId,
+			id: record.workItemId
+		}), this.#storage.listDecisionsForEvaluations(record.orgId, record.factoryProjectId, [record.evaluationId])]);
+		return decisionOvertaken({
+			boards: this.#boards,
+			item,
+			record,
+			role,
+			siblings
+		});
+	}
 	async #roleSuperseded(record, role) {
 		if (!record.workItemId) return false;
 		const bindings = await this.#storage.listRunBindings(record.orgId, record.factoryProjectId, record.workItemId);