@massu/core 2.5.5 → 2.5.6

package/CHANGELOG.md

@@ -10,6 +10,39 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).
 > redistributed under the **Apache License 2.0**. Full license + NOTICE:
 > `packages/core/assets/embedder/MODEL-LICENSE`.
 
+## [2.5.6] - 2026-11-09
+
+### Security
+
+- **The safety gate blocks again.** In 2.5.2 through 2.5.5 the PreToolUse gate that `massu init`
+  installs warned about everything it should have blocked and then let the call run: commands
+  that read `.env` and other secret files, piping a download into a shell, `rm -rf /`, disk
+  formatting and writes to `/etc/passwd`. Claude Code blocks a tool call only when the hook exits
+  with code 2; the gate printed "BLOCKED" and exited 0. It now exits 2 for every blocking
+  finding. **Upgrade, then run `massu init` again** so your settings pick up the change below.
+- **A gate that fails now blocks.** `massu init` sets Claude Code's `"onFailure": "block"`
+  (Claude Code 2.1.295 or later) on the gate, so a gate that crashes, times out or prints invalid
+  output blocks the call instead of letting it through. On older Claude Code, the `massu-hook`
+  launcher and `hook-runner` turn a crashed gate into a block.
+- **The older hook names decide too.** Settings written before 1.12.0 may still name the
+  `security-gate` and `pre-delete-check` hooks. They used to warn only; they now make the same
+  decision as the gate.
+- **More secret files are recognised:** secrets data files under any name, such as
+  `config.secrets.yaml` or `app.secret.json`. Source files such as `secrets.ts` are still allowed.
+
+### Fixed
+
+- **The gate no longer refuses good calls under load.** A slow-arriving tool call could be
+  denied as "Unexpected end of JSON input" and pass on retry. The gate now reads its whole
+  input before deciding.
+
+### Added
+
+- **`massu_cost_feature` reports real data.** Each session's priced cost is split across the
+  registered features whose files it touched, in proportion to those touches; activity on files
+  that belong to no registered feature is shown as `(no registered feature)`, so the rows add up
+  to the sessions' total. Sessions whose cost is unknown are left out.
+
 ## [2.5.5] - 2026-11-09
 
 ### Fixed

package/dist/cli.js

@@ -5893,6 +5893,42 @@ var init_hook_timeouts = __esm({
   }
 });
 
+// src/lib/hook-registry.ts
+function getExpectedHookFiles() {
+  return REGISTERED_HOOKS.map((name) => `${name}.js`);
+}
+var REGISTERED_HOOKS, DECISION_HOOKS;
+var init_hook_registry = __esm({
+  "src/lib/hook-registry.ts"() {
+    "use strict";
+    REGISTERED_HOOKS = [
+      "auto-learning-pipeline",
+      "classify-failure",
+      "cost-tracker",
+      "fix-detector",
+      "incident-pipeline",
+      "intent-suggester",
+      "memory-recall",
+      "post-edit-context",
+      "post-tool-use",
+      "pre-compact",
+      // P-E-019 (1.12.0): security-gate + pre-delete-check are kept registered
+      // for back-compat (operator settings.json may still reference them
+      // individually), but new installs emit only `pre-tool-use-gate` —
+      // the consolidated single-spawn PreToolUse hook.
+      "pre-delete-check",
+      "pre-tool-use-gate",
+      "quality-event",
+      "rule-enforcement-pipeline",
+      "security-gate",
+      "session-end",
+      "session-start",
+      "user-prompt"
+    ];
+    DECISION_HOOKS = ["pre-delete-check", "pre-tool-use-gate", "security-gate"];
+  }
+});
+
 // src/detect/manifest-registry.ts
 var manifest_registry_exports = {};
 __export(manifest_registry_exports, {
@@ -17102,6 +17138,22 @@ fi
 MASSU_VERSION="$1"
 shift
 MASSU_CLI="\${HOME}/.massu/runtime/\${MASSU_VERSION}/node_modules/@massu/core/dist/cli.js"
+# A DECIDING hook's exit code is its verdict: 0 allows, 2 denies. If the launch itself fails
+# (a runtime that cannot load exits 1), Claude Code would RUN the call, so for these hooks
+# any other status becomes a deny. Every other subcommand keeps the exec path below.
+if [ "\${1:-}" = hook-runner ]; then
+  case "\${2:-}" in
+    ${DECISION_HOOKS.join("|")})
+      if [ -f "$MASSU_CLI" ]; then node "$MASSU_CLI" "$@"; else npx -y "@massu/core@\${MASSU_VERSION}" "$@"; fi
+      st=$?
+      if [ "$st" -ne 0 ] && [ "$st" -ne 2 ]; then
+        echo "MASSU SECURITY GATE \u2014 BLOCKED: the $2 hook ended without a verdict (exit $st)" >&2
+        exit 2
+      fi
+      exit "$st"
+      ;;
+  esac
+fi
 if [ -f "$MASSU_CLI" ]; then
   exec node "$MASSU_CLI" "$@"
 fi
@@ -17149,6 +17201,7 @@ function getHookTimeout(name) {
 function hookEntry(version, name, shim) {
   const entry = { type: "command", command: hookCmd(version, name, shim), timeout: getHookTimeout(name) };
   if (BACKGROUND_HOOKS.has(name)) entry.async = true;
+  if (DECISION_HOOKS.includes(name)) entry.onFailure = "block";
   return entry;
 }
 function buildHooksConfig(_hooksDir, shim = resolveMassuShim()) {
@@ -17705,6 +17758,7 @@ var init_init = __esm({
     init_settings_local();
     init_memory_path();
     init_hook_timeouts();
+    init_hook_registry();
     init_detect();
     init_drift();
     __filename2 = fileURLToPath3(import.meta.url);
@@ -18291,41 +18345,6 @@ var init_license = __esm({
   }
 });
 
-// src/lib/hook-registry.ts
-function getExpectedHookFiles() {
-  return REGISTERED_HOOKS.map((name) => `${name}.js`);
-}
-var REGISTERED_HOOKS;
-var init_hook_registry = __esm({
-  "src/lib/hook-registry.ts"() {
-    "use strict";
-    REGISTERED_HOOKS = [
-      "auto-learning-pipeline",
-      "classify-failure",
-      "cost-tracker",
-      "fix-detector",
-      "incident-pipeline",
-      "intent-suggester",
-      "memory-recall",
-      "post-edit-context",
-      "post-tool-use",
-      "pre-compact",
-      // P-E-019 (1.12.0): security-gate + pre-delete-check are kept registered
-      // for back-compat (operator settings.json may still reference them
-      // individually), but new installs emit only `pre-tool-use-gate` —
-      // the consolidated single-spawn PreToolUse hook.
-      "pre-delete-check",
-      "pre-tool-use-gate",
-      "quality-event",
-      "rule-enforcement-pipeline",
-      "security-gate",
-      "session-end",
-      "session-start",
-      "user-prompt"
-    ];
-  }
-});
-
 // src/preflight.ts
 import { existsSync as existsSync22 } from "fs";
 function assertCodegraphUsable(dbPath) {
@@ -18412,6 +18431,7 @@ var init_preflight = __esm({
 var hook_runner_exports = {};
 __export(hook_runner_exports, {
   HOOK_NAME_TO_FILE: () => HOOK_NAME_TO_FILE,
+  decisionExitCode: () => decisionExitCode,
   resolveHookFile: () => resolveHookFile,
   runHookRunner: () => runHookRunner
 });
@@ -18443,6 +18463,16 @@ function resolveHookFile(hookName) {
     `Hook file not found for "${hookName}". Searched: ${candidates.join(", ")}. This indicates a broken @massu/core install. Re-run \`npx -y @massu/core init\`.`
   );
 }
+function decisionExitCode(hookName, code) {
+  if (!DECISION_HOOKS.includes(hookName) || code === 0 || code === 2) return code;
+  process.stderr.write(
+    `MASSU SECURITY GATE \u2014 BLOCKED
+
+The ${hookName} hook ended without a verdict (exit ${code}). A gate that did not decide has not approved this call.
+`
+  );
+  return 2;
+}
 async function runHookRunner(args2) {
   const hookName = args2[0];
   if (!hookName) {
@@ -18471,11 +18501,7 @@ Recognized: ${Object.keys(HOOK_NAME_TO_FILE).join(", ")}
       env: { ...process.env, MASSU_HOOK_RUNTIME: "1" }
     });
     child.on("exit", (code, signal) => {
-      if (signal) {
-        resolvePromise({ exitCode: 128 });
-        return;
-      }
-      resolvePromise({ exitCode: code ?? 0 });
+      resolvePromise({ exitCode: decisionExitCode(hookName, signal ? 128 : code ?? 0) });
     });
     child.on("error", (err) => {
       process.stderr.write(`massu hook-runner: failed to spawn hook "${hookName}": ${err.message}
@@ -33605,12 +33631,13 @@ function handleCostFeature(args2, db) {
     ORDER BY total_cost DESC
   `).all(`-${days} days`);
   if (rows.length === 0) {
-    return text7(`No feature cost data found in the last ${days} days. Feature costs are attributed automatically when sessions work on registered features. Ensure features are registered, then costs are tracked per-session. Try: ${p8("cost_trend")} { days: 30 } for session-level cost trends instead.`);
+    return text7(`No feature cost data found in the last ${days} days. Each session's priced cost is allocated across registered features (massu_sentinel_register) by the files it touched; sessions with unknown cost are skipped. Try: ${p8("cost_trend")} { days: 30 } for session-level cost trends instead.`);
   }
   const totalCost = rows.reduce((sum, r3) => sum + r3.total_cost, 0);
   const lines = [
     `## Feature Cost Attribution (${days} days)`,
-    `Total: $${totalCost.toFixed(2)} across ${rows.length} features`,
+    `Total: $${totalCost.toFixed(2)} across ${rows.length} feature row(s)`,
+    "Each session's priced cost is ALLOCATED across the registered features whose files it touched, in proportion to those touches. It is an allocation by activity, not a measured per-feature cost. Sessions with unknown cost are not included.",
     "",
     "| Feature | Cost | Tokens | Sessions | % of Total |",
     "|---------|------|--------|----------|------------|"