@massu/core 1.15.5 → 1.15.6

package/CHANGELOG.md

@@ -10,6 +10,36 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).
 > redistributed under the **Apache License 2.0**. Full license + NOTICE:
 > `packages/core/assets/embedder/MODEL-LICENSE`.
 
+## [1.15.6] - 2026-07-14
+
+### Fixed — the golden path's Deep Security Audit phase was missing entirely
+
+`references/phase-3.5-security-audit.md` — a full adversarial security audit loop over every file
+changed in a golden-path run (parallel red-team agents, iterating until the audit converges to ZERO
+findings). Its own text: *"This phase is NEVER skipped. Security is non-negotiable regardless of
+change size, type, or scope."*
+
+    0.6.1    SHIPS phase-3.5-security-audit.md
+    1.0.0    does NOT ship it
+    1.15.5   does NOT ship it
+
+**It exists in no commit in massu's history** — no deletion commit, no changelog entry, no trace.
+From v1.0.0 through v1.15.5, every user's golden path ran with **no security audit phase at all**.
+The only surviving copy was in a consumer repo that had committed its installed commands months ago.
+
+Restored, wired as **Phase 3.5** (after simplification, before pre-commit, exactly where its own
+spec says it belongs), and added to the reference table.
+
+**Why every guard missed it, and what changed:** the reference-link check asks *"does every
+reference file have a link?"* — and a file DELETED OUTRIGHT has no link to be missing. A check that
+only sees BROKEN things is structurally blind to ABSENT ones. The anti-vacuity suite now asserts,
+per subsystem, that the file **EXISTS** *and* is **LINKED** *and* is **INVOKED** — a conjunction no
+deletion can satisfy. Proven by attack: deleting the spec file goes RED; deleting the phase while
+keeping the file goes RED.
+
+This is the fifth quality subsystem found missing from the golden path in one day, and the only one
+deleted so completely it left no evidence anywhere in the repository.
+
 ## [1.15.5] - 2026-07-14
 
 ### Fixed — CRITICAL: `install-commands` could destroy your customizations

package/commands/massu-golden-path/references/phase-3.5-security-audit.md

@@ -0,0 +1,108 @@
+# Phase 3.5: Deep Security Audit
+
+> Reference doc for `/massu-golden-path`. Return to main file for overview.
+
+```
+[GOLDEN PATH -- PHASE 3.5: DEEP SECURITY AUDIT]
+```
+
+## Purpose
+
+Run a full adversarial security audit loop against ALL files changed in this golden path run. This is a deep, iterative audit with parallel red-team agents that converges to zero findings. It runs AFTER simplification (Phase 3) so the audit targets the final, cleaned-up code -- and BEFORE pre-commit verification (Phase 4) so all security fixes are included in the verification gates.
+
+**This phase is NEVER skipped.** Security is non-negotiable regardless of change size, type, or scope.
+
+---
+
+## 3.5.1 Determine Audit Scope
+
+Collect ALL files changed during this golden path run:
+
+```bash
+git diff --name-only HEAD
+```
+
+If files were already committed in earlier phases, also include:
+```bash
+git diff --name-only main...HEAD
+```
+
+The audit scope is the union of all changed files. Do NOT narrow scope -- every changed file gets audited.
+
+**Output:**
+```
+SECURITY AUDIT SCOPE:
+  Files: [N]
+  [list of files]
+```
+
+---
+
+## 3.5.2 Execute Deep Security Audit
+
+Run the full security audit protocol against the scoped files:
+
+1. **Launch 2-4 parallel adversarial reviewer agents** adapted to the codebase area:
+   - Backend/API code: 4 agents (Injection, Network/Leakage, DoS/Resources, Red Team Bypass)
+   - Frontend code: 3 agents (XSS/Injection, Auth/Data Exposure, Input Validation/Logic)
+   - Infrastructure/config: 2 agents (Secrets/Config, Dependencies/Supply Chain)
+
+2. **Consolidate findings** -- deduplicate across agents, take higher severity on disagreements
+
+3. **Fix ALL findings** -- CRITICAL first, then HIGH, MEDIUM, LOW. INFO documented only.
+
+4. **Verify fixes** -- import checks, input validation tests, functionality preserved
+
+5. **Loop until zero findings** -- max 5 iterations, escalate to user if still failing after 5
+
+---
+
+## 3.5.3 Attack Vector Coverage
+
+Every audit iteration MUST verify the complete attack vector checklist:
+
+### Universal
+- Hardcoded secrets / API keys / credentials
+- Error messages leaking internal details
+- Dependency vulnerabilities
+- Input validation on ALL external boundaries
+
+### Backend / API
+- SQL injection, command injection, path traversal
+- SSRF, authentication bypass, authorization bypass
+- DoS via unbounded inputs, memory leaks, race conditions
+- Response validation, type confusion
+
+### Frontend
+- XSS, open redirects, sensitive data in client state
+- CSRF, client-side auth bypass
+
+### LLM / AI Specific
+- Prompt injection, model output trust
+- Tool argument injection, vision/multimodal injection
+
+---
+
+## 3.5.4 Completion Gate
+
+The phase completes ONLY when the audit loop achieves a clean pass with zero findings.
+
+```
+SECURITY_AUDIT_GATE: PASS
+  Iterations: [N]
+  Total findings fixed: [N]
+  Breakdown: [X] CRITICAL, [X] HIGH, [X] MEDIUM, [X] LOW fixed
+  Clean pass: Iteration [N]
+```
+
+**Do NOT proceed to Phase 4 until SECURITY_AUDIT_GATE = PASS.**
+
+---
+
+## Rules
+
+1. **NEVER skip this phase** -- not for small changes, not for docs, not for config
+2. **NEVER proceed with findings unfixed** -- zero means zero
+3. **ALL severity levels get fixed** -- CRITICAL through LOW
+4. **No commit prompt** -- unlike standalone security audit commands, do NOT offer to commit here (Phase 4 handles commits)
+5. **Findings feed Phase 4** -- security fixes are verified by Phase 4's type check, build, lint, and secrets gates automatically

package/commands/massu-golden-path.md

@@ -150,6 +150,35 @@ Read `references/phase-3-simplify.md` for full details.
 
 ---
 
+## PHASE 3.5: DEEP SECURITY AUDIT
+
+Read `references/phase-3.5-security-audit.md` for full details.
+
+**Summary**: A full adversarial security audit loop against EVERY file changed in this run —
+parallel red-team agents, iterating until the audit converges to ZERO findings. It runs AFTER
+simplification (so it audits the final, cleaned-up code) and BEFORE pre-commit verification (so
+every security fix is caught by the Phase 4 gates).
+
+**THIS PHASE IS NEVER SKIPPED.** Security is non-negotiable regardless of the size, type, or scope
+of the change. Do not narrow the audit scope: every changed file gets audited.
+
+> **This phase SHIPPED in v0.6.1 and had vanished by v1.0.0.** It exists in no commit in this
+> repository's history — the only surviving copy on the machine was in a consumer repo that had
+> committed its installed commands back in April. So for every version from v1.0.0 to v1.15.5,
+> every user's golden path ran with **no security audit phase at all**, and nothing anywhere said
+> so.
+>
+> It was found by accident, on 2026-07-14, when a `git status` showed the file being deleted from
+> that consumer during a reinstall. **The reference-link guard could never have found it:** that
+> guard asks "does every reference file have a link?", and a file that has been deleted outright
+> has no link to be missing. A check that only sees *broken* things is blind to *absent* ones —
+> which is the same failure as a scanner that reports CLEAN because it scanned zero files.
+>
+> Restored and wired 2026-07-14. Guarded by `golden-path-quality-subsystems-wired.test.ts`, which
+> asserts the file EXISTS, is LINKED, and is INVOKED — a conjunction no deletion can satisfy.
+
+---
+
 ## PHASE 4: PRE-COMMIT VERIFICATION
 
 Read `references/phase-4-commit.md` for full details.
@@ -216,6 +245,7 @@ This skill is a folder. The following files are available for reference:
 | `references/vr-visual-calibration.md` | Score 5/3/1 calibration examples for VR-VISUAL weighted dimensions | Calibrating VR-VISUAL scoring in Phase 2.5 |
 | `references/phase-2.5-gap-analyzer.md` | Gap/enhancement analysis loop, 7 categories (incl. sprint-contract compliance), fix-and-repass until zero | After implementation, before simplification |
 | `references/phase-3-simplify.md` | Pattern scanner fast gate, dead code detection, parallel semantic review agents | Running simplification after implementation |
+| `references/phase-3.5-security-audit.md` | Adversarial red-team security audit loop over every changed file, iterating to ZERO findings | Phase 3.5 — after simplification, before pre-commit. NEVER skipped |
 | `references/phase-4-commit.md` | Auto-verification gates, quality scoring, commit format | Preparing a commit |
 | `references/phase-5-push.md` | Pre-flight, 4-tier push verification, regression detection | Preparing to push to remote |
 | `references/phase-5.5-production-verify.md` | Deployment landed, runtime logs clean, feature exercised against production with real data | Phase 5.5 — after push, before calling it done |

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@massu/core",
-  "version": "1.15.5",
+  "version": "1.15.6",
   "type": "module",
   "description": "AI Engineering Governance MCP Server - Session memory, knowledge system, feature registry, code intelligence, rule enforcement, tiered tooling (12 free / 73 total), 56 workflow commands, 11 agents, 20+ patterns",
   "main": "./dist/cli.js",