@masslessai/push-todo 3.10.9 → 4.0.1

package/lib/daemon-health.js

@@ -125,7 +125,7 @@ function killOrphanedDaemons() {
     const trackedPid = existsSync(PID_FILE)
       ? parseInt(readFileSync(PID_FILE, 'utf8').trim(), 10)
       : null;
-    const output = execFileSync('pgrep', ['-f', 'node.*daemon\\.js'], {
+    const output = execFileSync('pgrep', ['-f', 'push-todo.*daemon\\.js'], {
       encoding: 'utf8',
       timeout: 5000
     }).trim();

package/lib/daemon.js

@@ -78,6 +78,7 @@ const PID_FILE = join(PUSH_DIR, 'daemon.pid');
 const LOG_FILE = join(PUSH_DIR, 'daemon.log');
 const STATUS_FILE = join(PUSH_DIR, 'daemon_status.json');
 const VERSION_FILE = join(PUSH_DIR, 'daemon.version');
+const LOCK_FILE = join(PUSH_DIR, 'daemon.lock');
 const CONFIG_FILE = join(CONFIG_DIR, 'config');
 const MACHINE_ID_FILE = join(CONFIG_DIR, 'machine_id');
 const REGISTRY_FILE = join(CONFIG_DIR, 'projects.json');
@@ -90,12 +91,31 @@ const LOG_BACKUP_COUNT = 3;
 const runningTasks = new Map(); // displayNumber -> taskInfo
 const taskDetails = new Map();  // displayNumber -> details
 const completedToday = [];
+const COMPLETED_TODAY_MAX = 100;
+
+function trackCompleted(entry) {
+  completedToday.push(entry);
+  if (completedToday.length > COMPLETED_TODAY_MAX) {
+    completedToday.splice(0, completedToday.length - COMPLETED_TODAY_MAX);
+  }
+}
 const taskLastOutput = new Map(); // displayNumber -> timestamp
 const taskStdoutBuffer = new Map(); // displayNumber -> lines[]
 const taskStderrBuffer = new Map(); // displayNumber -> lines[]
 const taskProjectPaths = new Map(); // displayNumber -> projectPath
 let daemonStartTime = null;
 
+// ==================== Utilities ====================
+
+function parseJsonField(value) {
+  if (!value) return [];
+  if (Array.isArray(value)) return value;
+  if (typeof value === 'string') {
+    try { return JSON.parse(value); } catch { return []; }
+  }
+  return [];
+}
+
 // ==================== Logging ====================
 
 function rotateLogs() {
@@ -126,7 +146,7 @@ function rotateLogs() {
 
 function log(message, level = 'INFO') {
   const timestamp = new Date().toISOString();
-  const line = `[${timestamp}] [${level}] ${message}\n`;
+  const line = `[${timestamp}] [PID:${process.pid}] [${level}] ${message}\n`;
 
   if (process.env.PUSH_DAEMON !== '1') {
     process.stdout.write(line);
@@ -141,6 +161,38 @@ function logError(message) {
   log(message, 'ERROR');
 }
 
+// ==================== Lock File ====================
+
+function isProcessRunning(pid) {
+  try {
+    process.kill(pid, 0);
+    return true;
+  } catch {
+    return false;
+  }
+}
+
+function acquireLock() {
+  try {
+    if (existsSync(LOCK_FILE)) {
+      const holderPid = parseInt(readFileSync(LOCK_FILE, 'utf8').trim(), 10);
+      if (!isNaN(holderPid) && holderPid !== process.pid && isProcessRunning(holderPid)) {
+        return false;
+      }
+      // Holder is dead or is us — clean up stale lock
+      try { unlinkSync(LOCK_FILE); } catch {}
+    }
+    writeFileSync(LOCK_FILE, String(process.pid));
+    return true;
+  } catch {
+    return false;
+  }
+}
+
+function releaseLock() {
+  try { unlinkSync(LOCK_FILE); } catch {}
+}
+
 // ==================== Mac Notifications ====================
 
 function sendMacNotification(title, message, sound = 'default') {
@@ -1025,7 +1077,7 @@ async function autoHealExistingWork(displayNumber, summary, projectPath, taskId)
         }
       }
 
-      completedToday.push({
+      trackCompleted({
         displayNumber, summary,
         completedAt: new Date().toISOString(),
         duration: 0, status, prUrl
@@ -1062,7 +1114,7 @@ async function autoHealExistingWork(displayNumber, summary, projectPath, taskId)
         }
       }
 
-      completedToday.push({
+      trackCompleted({
         displayNumber, summary,
         completedAt: new Date().toISOString(),
         duration: 0, status, prUrl
@@ -1079,7 +1131,7 @@ async function autoHealExistingWork(displayNumber, summary, projectPath, taskId)
         await updateTaskStatus(displayNumber, 'session_finished', {
           summary: executionSummary
         });
-        completedToday.push({
+        trackCompleted({
           displayNumber, summary,
           completedAt: new Date().toISOString(),
           duration: 0, status: 'session_finished', prUrl: newPrUrl
@@ -1345,10 +1397,37 @@ async function executeTask(task) {
 
   taskProjectPaths.set(displayNumber, projectPath);
 
+  // Build attachment context for the prompt (screenshots, links)
+  let attachmentContext = '';
+  try {
+    const links = parseJsonField(task.linkAttachmentsJson || task.linkAttachments || task.link_attachments);
+    const screenshots = parseJsonField(task.screenshotAttachmentsJson || task.screenshotAttachments || task.screenshot_attachments);
+    const contextApp = task.contextApp || task.context_app || null;
+
+    const parts = [];
+    if (contextApp) {
+      parts.push(`Context app: ${contextApp}`);
+    }
+    if (links.length > 0) {
+      parts.push('Links:\n' + links.map(l => `  - ${l.url}${l.title ? ` (${l.title})` : ''}`).join('\n'));
+    }
+    if (screenshots.length > 0) {
+      parts.push('Screenshots:\n' + screenshots.map(s =>
+        `  - ${s.imageFilename || s.image_filename}${s.sourceApp ? ` (from ${s.sourceApp})` : ''}`
+      ).join('\n'));
+    }
+
+    if (parts.length > 0) {
+      attachmentContext = '\n\nAttachments:\n' + parts.join('\n');
+    }
+  } catch {
+    // Non-critical — continue without attachment context
+  }
+
   // Build prompt
   const prompt = `Work on Push task #${displayNumber}:
 
-${content}
+${content}${attachmentContext}
 
 IMPORTANT:
 1. If you need to understand the codebase, start by reading the CLAUDE.md file if it exists.
@@ -1364,6 +1443,7 @@ IMPORTANT:
     'Bash(git *)',
     'Bash(npm *)', 'Bash(npx *)', 'Bash(yarn *)',
     'Bash(python *)', 'Bash(python3 *)', 'Bash(pip *)', 'Bash(pip3 *)',
+    'Bash(push-todo *)',
     'Task'
   ].join(',');
 
@@ -1585,7 +1665,7 @@ async function handleTaskCompletion(displayNumber, exitCode) {
       }
     }
 
-    completedToday.push({
+    trackCompleted({
       displayNumber,
       summary,
       completedAt: new Date().toISOString(),
@@ -1621,7 +1701,7 @@ async function handleTaskCompletion(displayNumber, exitCode) {
       );
     }
 
-    completedToday.push({
+    trackCompleted({
       displayNumber,
       summary,
       completedAt: new Date().toISOString(),
@@ -1765,7 +1845,7 @@ async function checkTimeouts() {
       );
     }
 
-    completedToday.push({
+    trackCompleted({
       displayNumber,
       summary: info.summary || 'Unknown task',
       completedAt: new Date().toISOString(),
@@ -2043,6 +2123,7 @@ async function cleanup() {
   }
 
   // Clean up files
+  releaseLock();
   try { unlinkSync(PID_FILE); } catch {}
 
   // Update status
@@ -2072,6 +2153,15 @@ mkdirSync(CONFIG_DIR, { recursive: true });
 // Rotate logs
 rotateLogs();
 
+// Acquire lock (prevents zombie daemons from racing)
+if (!acquireLock()) {
+  const holderPid = parseInt(readFileSync(LOCK_FILE, 'utf8').trim(), 10);
+  // Log to file directly since log() may not work yet
+  const msg = `[${new Date().toISOString()}] [PID:${process.pid}] [INFO] Another daemon (PID ${holderPid}) holds the lock. Exiting.\n`;
+  try { appendFileSync(LOG_FILE, msg); } catch {}
+  process.exit(0);
+}
+
 // Write PID file
 writeFileSync(PID_FILE, String(process.pid));
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@masslessai/push-todo",
-  "version": "3.10.9",
+  "version": "4.0.1",
   "description": "Voice tasks from Push iOS app for Claude Code",
   "type": "module",
   "bin": {