@massa-ai/cursor-plugin 1.61.0 → 1.62.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/.cursor-plugin/plugin.json +1 -1
- package/README.md +2 -2
- package/agent-profiles/{heavy/massa-ai-builder.md → balanced/builder.md} +4 -4
- package/agent-profiles/balanced/code-explorer.md +102 -0
- package/agent-profiles/balanced/code-reviewer.md +134 -0
- package/agent-profiles/balanced/designer.md +84 -0
- package/agent-profiles/balanced/judge.md +147 -0
- package/agent-profiles/balanced/product-manager.md +108 -0
- package/agent-profiles/balanced/test-engineer.md +100 -0
- package/agent-profiles/cheap/{massa-ai-builder.md → builder.md} +4 -4
- package/agent-profiles/cheap/code-explorer.md +102 -0
- package/agent-profiles/cheap/code-reviewer.md +134 -0
- package/agent-profiles/cheap/designer.md +84 -0
- package/agent-profiles/cheap/judge.md +147 -0
- package/agent-profiles/cheap/product-manager.md +108 -0
- package/agent-profiles/cheap/test-engineer.md +100 -0
- package/agent-profiles/{balanced/massa-ai-builder.md → heavy/builder.md} +4 -4
- package/agent-profiles/heavy/code-explorer.md +102 -0
- package/agent-profiles/heavy/code-reviewer.md +134 -0
- package/agent-profiles/heavy/designer.md +84 -0
- package/agent-profiles/heavy/judge.md +147 -0
- package/agent-profiles/heavy/product-manager.md +108 -0
- package/agent-profiles/heavy/test-engineer.md +100 -0
- package/agent-profiles/home/{massa-ai-builder.md → builder.md} +4 -4
- package/agent-profiles/home/code-explorer.md +102 -0
- package/agent-profiles/home/code-reviewer.md +134 -0
- package/agent-profiles/home/designer.md +84 -0
- package/agent-profiles/home/judge.md +147 -0
- package/agent-profiles/home/product-manager.md +108 -0
- package/agent-profiles/home/test-engineer.md +100 -0
- package/agent-profiles/work/builder.md +63 -0
- package/agent-profiles/work/code-explorer.md +102 -0
- package/agent-profiles/work/code-reviewer.md +134 -0
- package/agent-profiles/work/designer.md +84 -0
- package/agent-profiles/work/judge.md +147 -0
- package/agent-profiles/work/product-manager.md +108 -0
- package/agent-profiles/work/test-engineer.md +100 -0
- package/agents/builder.md +63 -0
- package/agents/code-explorer.md +102 -0
- package/agents/code-reviewer.md +134 -0
- package/agents/designer.md +84 -0
- package/agents/judge.md +147 -0
- package/agents/product-manager.md +108 -0
- package/agents/test-engineer.md +100 -0
- package/hooks/massa-ai-hook +4 -4
- package/install.sh +110 -33
- package/package.json +1 -1
- package/skills/agents/builder/SKILL.md +3 -4
- package/skills/agents/code-explorer/SKILL.md +104 -0
- package/skills/agents/code-reviewer/SKILL.md +136 -0
- package/skills/agents/designer/SKILL.md +34 -17
- package/skills/agents/judge/SKILL.md +99 -48
- package/skills/agents/product-manager/SKILL.md +110 -0
- package/skills/agents/test-engineer/SKILL.md +57 -22
- package/skills/bootstrap/SKILL.md +4 -5
- package/skills/{adr → create-adr}/SKILL.md +3 -3
- package/skills/{to-prd → create-prd}/SKILL.md +3 -3
- package/skills/{rfc → create-rfc}/SKILL.md +3 -3
- package/skills/{tdd → create-tdd}/SKILL.md +3 -3
- package/skills/{ticket → create-ticket}/SKILL.md +3 -3
- package/skills/massa-ai/SKILL.md +26 -29
- package/skills/massa-ai/references/agent-orchestration.md +62 -58
- package/skills/massa-ai/references/audit-report-io.md +8 -87
- package/skills/massa-ai/references/code-reuse-scan.md +1 -1
- package/skills/massa-ai/references/{adr-authoring.md → create-adr.md} +3 -3
- package/skills/massa-ai/references/{rfc → create-rfc}/discovery-and-sizing.md +1 -1
- package/skills/massa-ai/references/{tdd → create-tdd}/calibrated-examples.md +3 -3
- package/skills/massa-ai/references/{tdd → create-tdd}/discovery-and-sizing.md +1 -1
- package/skills/massa-ai/references/{tdd → create-tdd}/quality-and-lifecycle.md +1 -1
- package/skills/massa-ai/references/{ticket → create-ticket}/intake-and-sources.md +1 -1
- package/skills/massa-ai/references/figma-pre-analysis.md +1 -1
- package/skills/massa-ai/references/furps/analyst-role.md +3 -3
- package/skills/massa-ai/references/furps/checklist.md +2 -2
- package/skills/massa-ai/references/furps/intake.md +7 -7
- package/skills/massa-ai/references/hook-enforcement.md +4 -8
- package/skills/massa-ai/references/implementation-delivery.md +2 -2
- package/skills/massa-ai/references/knowledge-verification-chain.md +0 -1
- package/skills/massa-ai/references/mobile-context.md +2 -5
- package/skills/massa-ai/references/pr-task-fix.md +1 -1
- package/skills/massa-ai/references/spec-driven/sub-agents.md +3 -3
- package/skills/massa-ai/references/spec-driven/validate.md +1 -1
- package/skills/massa-ai/references/subagent-design.md +6 -9
- package/skills/massa-ai/references/verification-ladder.md +2 -2
- package/skills/massa-ai/scripts/validate_audit_report.ts +3 -8
- package/skills/massa-ai/workflows/architecture/architecture-audit.md +4 -5
- package/skills/massa-ai/workflows/architecture/architecture-fix.md +5 -6
- package/skills/massa-ai/workflows/bugs/bugs-audit.md +2 -3
- package/skills/massa-ai/workflows/bugs/bugs-fix.md +4 -5
- package/skills/massa-ai/workflows/code-quality/code-quality-audit.md +2 -3
- package/skills/massa-ai/workflows/code-quality/code-quality-fix.md +4 -5
- package/skills/massa-ai/workflows/commit.md +3 -3
- package/skills/massa-ai/workflows/{adr.md → create-adr.md} +10 -10
- package/skills/massa-ai/workflows/{to-prd.md → create-prd.md} +4 -4
- package/skills/massa-ai/workflows/{rfc.md → create-rfc.md} +6 -6
- package/skills/massa-ai/workflows/{tdd.md → create-tdd.md} +11 -11
- package/skills/massa-ai/workflows/{ticket.md → create-ticket.md} +5 -5
- package/skills/massa-ai/workflows/debug.md +4 -5
- package/skills/massa-ai/workflows/design.md +2 -2
- package/skills/massa-ai/workflows/exploration.md +2 -2
- package/skills/massa-ai/workflows/feature.md +5 -6
- package/skills/massa-ai/workflows/implementation/implementation-audit.md +22 -3
- package/skills/massa-ai/workflows/implementation/implementation-fix.md +6 -7
- package/skills/massa-ai/workflows/judge-with-debate.md +14 -14
- package/skills/massa-ai/workflows/mobile-figma/mobile-figma-audit.md +2 -2
- package/skills/massa-ai/workflows/mobile-figma/mobile-figma-fix.md +10 -11
- package/skills/massa-ai/workflows/pr-review.md +31 -13
- package/skills/massa-ai/workflows/{discovery.md → product-discovery.md} +12 -12
- package/skills/massa-ai/workflows/refactor.md +4 -5
- package/skills/massa-ai/workflows/refinement/furps-refinement.md +7 -7
- package/skills/massa-ai/workflows/requirements/requirements-audit.md +2 -2
- package/skills/massa-ai/workflows/requirements/requirements-fix.md +5 -6
- package/skills/massa-ai/workflows/security/security-audit.md +2 -3
- package/skills/massa-ai/workflows/security/security-fix.md +3 -4
- package/skills/massa-ai/workflows/spec-driven.md +9 -10
- package/skills/massa-ai/workflows/tests/tests-audit.md +2 -2
- package/skills/massa-ai/workflows/tests/tests-fix.md +16 -6
- package/skills/massa-ai/workflows/the-fool.md +7 -7
- package/skills/{discovery → product-discovery}/SKILL.md +3 -3
- package/agent-profiles/balanced/massa-ai-architecture-specialist.md +0 -62
- package/agent-profiles/balanced/massa-ai-audit-specialist.md +0 -79
- package/agent-profiles/balanced/massa-ai-context-curator.md +0 -64
- package/agent-profiles/balanced/massa-ai-designer.md +0 -66
- package/agent-profiles/balanced/massa-ai-documentation-agent.md +0 -61
- package/agent-profiles/balanced/massa-ai-furps-analyst.md +0 -68
- package/agent-profiles/balanced/massa-ai-investigator.md +0 -65
- package/agent-profiles/balanced/massa-ai-judge.md +0 -95
- package/agent-profiles/balanced/massa-ai-meta-judge.md +0 -84
- package/agent-profiles/balanced/massa-ai-mobile-specialist.md +0 -79
- package/agent-profiles/balanced/massa-ai-navigator.md +0 -72
- package/agent-profiles/balanced/massa-ai-plan-critic.md +0 -87
- package/agent-profiles/balanced/massa-ai-planner.md +0 -62
- package/agent-profiles/balanced/massa-ai-requirements-analyst.md +0 -61
- package/agent-profiles/balanced/massa-ai-reviewer.md +0 -63
- package/agent-profiles/balanced/massa-ai-test-engineer.md +0 -63
- package/agent-profiles/balanced/massa-ai-verification-agent.md +0 -62
- package/agent-profiles/cheap/massa-ai-architecture-specialist.md +0 -62
- package/agent-profiles/cheap/massa-ai-audit-specialist.md +0 -79
- package/agent-profiles/cheap/massa-ai-context-curator.md +0 -64
- package/agent-profiles/cheap/massa-ai-designer.md +0 -66
- package/agent-profiles/cheap/massa-ai-documentation-agent.md +0 -61
- package/agent-profiles/cheap/massa-ai-furps-analyst.md +0 -68
- package/agent-profiles/cheap/massa-ai-investigator.md +0 -65
- package/agent-profiles/cheap/massa-ai-judge.md +0 -95
- package/agent-profiles/cheap/massa-ai-meta-judge.md +0 -84
- package/agent-profiles/cheap/massa-ai-mobile-specialist.md +0 -79
- package/agent-profiles/cheap/massa-ai-navigator.md +0 -72
- package/agent-profiles/cheap/massa-ai-plan-critic.md +0 -87
- package/agent-profiles/cheap/massa-ai-planner.md +0 -62
- package/agent-profiles/cheap/massa-ai-requirements-analyst.md +0 -61
- package/agent-profiles/cheap/massa-ai-reviewer.md +0 -63
- package/agent-profiles/cheap/massa-ai-test-engineer.md +0 -63
- package/agent-profiles/cheap/massa-ai-verification-agent.md +0 -62
- package/agent-profiles/heavy/massa-ai-architecture-specialist.md +0 -62
- package/agent-profiles/heavy/massa-ai-audit-specialist.md +0 -79
- package/agent-profiles/heavy/massa-ai-context-curator.md +0 -64
- package/agent-profiles/heavy/massa-ai-designer.md +0 -66
- package/agent-profiles/heavy/massa-ai-documentation-agent.md +0 -61
- package/agent-profiles/heavy/massa-ai-furps-analyst.md +0 -68
- package/agent-profiles/heavy/massa-ai-investigator.md +0 -65
- package/agent-profiles/heavy/massa-ai-judge.md +0 -95
- package/agent-profiles/heavy/massa-ai-meta-judge.md +0 -84
- package/agent-profiles/heavy/massa-ai-mobile-specialist.md +0 -79
- package/agent-profiles/heavy/massa-ai-navigator.md +0 -72
- package/agent-profiles/heavy/massa-ai-plan-critic.md +0 -87
- package/agent-profiles/heavy/massa-ai-planner.md +0 -62
- package/agent-profiles/heavy/massa-ai-requirements-analyst.md +0 -61
- package/agent-profiles/heavy/massa-ai-reviewer.md +0 -63
- package/agent-profiles/heavy/massa-ai-test-engineer.md +0 -63
- package/agent-profiles/heavy/massa-ai-verification-agent.md +0 -62
- package/agent-profiles/home/massa-ai-architecture-specialist.md +0 -62
- package/agent-profiles/home/massa-ai-audit-specialist.md +0 -79
- package/agent-profiles/home/massa-ai-context-curator.md +0 -64
- package/agent-profiles/home/massa-ai-designer.md +0 -66
- package/agent-profiles/home/massa-ai-documentation-agent.md +0 -61
- package/agent-profiles/home/massa-ai-furps-analyst.md +0 -68
- package/agent-profiles/home/massa-ai-investigator.md +0 -65
- package/agent-profiles/home/massa-ai-judge.md +0 -95
- package/agent-profiles/home/massa-ai-meta-judge.md +0 -84
- package/agent-profiles/home/massa-ai-mobile-specialist.md +0 -79
- package/agent-profiles/home/massa-ai-navigator.md +0 -72
- package/agent-profiles/home/massa-ai-plan-critic.md +0 -87
- package/agent-profiles/home/massa-ai-planner.md +0 -62
- package/agent-profiles/home/massa-ai-requirements-analyst.md +0 -61
- package/agent-profiles/home/massa-ai-reviewer.md +0 -63
- package/agent-profiles/home/massa-ai-test-engineer.md +0 -63
- package/agent-profiles/home/massa-ai-verification-agent.md +0 -62
- package/agent-profiles/work/massa-ai-architecture-specialist.md +0 -62
- package/agent-profiles/work/massa-ai-audit-specialist.md +0 -79
- package/agent-profiles/work/massa-ai-builder.md +0 -63
- package/agent-profiles/work/massa-ai-context-curator.md +0 -64
- package/agent-profiles/work/massa-ai-designer.md +0 -66
- package/agent-profiles/work/massa-ai-documentation-agent.md +0 -61
- package/agent-profiles/work/massa-ai-furps-analyst.md +0 -68
- package/agent-profiles/work/massa-ai-investigator.md +0 -65
- package/agent-profiles/work/massa-ai-judge.md +0 -95
- package/agent-profiles/work/massa-ai-meta-judge.md +0 -84
- package/agent-profiles/work/massa-ai-mobile-specialist.md +0 -79
- package/agent-profiles/work/massa-ai-navigator.md +0 -72
- package/agent-profiles/work/massa-ai-plan-critic.md +0 -87
- package/agent-profiles/work/massa-ai-planner.md +0 -62
- package/agent-profiles/work/massa-ai-requirements-analyst.md +0 -61
- package/agent-profiles/work/massa-ai-reviewer.md +0 -63
- package/agent-profiles/work/massa-ai-test-engineer.md +0 -63
- package/agent-profiles/work/massa-ai-verification-agent.md +0 -62
- package/agents/massa-ai-architecture-specialist.md +0 -62
- package/agents/massa-ai-audit-specialist.md +0 -79
- package/agents/massa-ai-builder.md +0 -63
- package/agents/massa-ai-context-curator.md +0 -64
- package/agents/massa-ai-designer.md +0 -66
- package/agents/massa-ai-documentation-agent.md +0 -61
- package/agents/massa-ai-furps-analyst.md +0 -68
- package/agents/massa-ai-investigator.md +0 -65
- package/agents/massa-ai-judge.md +0 -95
- package/agents/massa-ai-meta-judge.md +0 -84
- package/agents/massa-ai-mobile-specialist.md +0 -79
- package/agents/massa-ai-navigator.md +0 -72
- package/agents/massa-ai-plan-critic.md +0 -87
- package/agents/massa-ai-planner.md +0 -62
- package/agents/massa-ai-requirements-analyst.md +0 -61
- package/agents/massa-ai-reviewer.md +0 -63
- package/agents/massa-ai-test-engineer.md +0 -63
- package/agents/massa-ai-verification-agent.md +0 -62
- package/skills/agents/architecture-specialist/SKILL.md +0 -66
- package/skills/agents/audit-specialist/SKILL.md +0 -83
- package/skills/agents/context-curator/SKILL.md +0 -68
- package/skills/agents/documentation-agent/SKILL.md +0 -66
- package/skills/agents/furps-analyst/SKILL.md +0 -71
- package/skills/agents/investigator/SKILL.md +0 -69
- package/skills/agents/meta-judge/SKILL.md +0 -87
- package/skills/agents/mobile-specialist/SKILL.md +0 -83
- package/skills/agents/navigator/SKILL.md +0 -76
- package/skills/agents/plan-critic/SKILL.md +0 -90
- package/skills/agents/planner/SKILL.md +0 -66
- package/skills/agents/requirements-analyst/SKILL.md +0 -65
- package/skills/agents/reviewer/SKILL.md +0 -67
- package/skills/agents/verification-agent/SKILL.md +0 -66
- package/skills/general/SKILL.md +0 -14
- package/skills/maestro/SKILL.md +0 -14
- package/skills/maestro-audit/SKILL.md +0 -14
- package/skills/maestro-fix/SKILL.md +0 -14
- package/skills/massa-ai/personas/README.md +0 -35
- package/skills/massa-ai/personas/ai-native-nodejs-cli-architect.md +0 -47
- package/skills/massa-ai/personas/catalog.json +0 -7
- package/skills/massa-ai/personas/context-skill-harness-engineer-architect.md +0 -47
- package/skills/massa-ai/personas/product-manager.md +0 -65
- package/skills/massa-ai/personas/senior-mobile-engineer.md +0 -46
- package/skills/massa-ai/personas/senior-mobile-qa-automation-engineer.md +0 -51
- package/skills/massa-ai/personas/signals/ai-native-nodejs-cli-architect.json +0 -20
- package/skills/massa-ai/personas/signals/context-skill-harness-engineer-architect.json +0 -20
- package/skills/massa-ai/personas/signals/product-manager.json +0 -21
- package/skills/massa-ai/personas/signals/senior-mobile-engineer.json +0 -18
- package/skills/massa-ai/personas/signals/senior-mobile-qa-automation-engineer.json +0 -18
- package/skills/massa-ai/references/maestro/artifacts-reports.md +0 -69
- package/skills/massa-ai/references/maestro/cli-device.md +0 -65
- package/skills/massa-ai/references/maestro/cloud.md +0 -69
- package/skills/massa-ai/references/maestro/config-env-output.md +0 -76
- package/skills/massa-ai/references/maestro/fact-ledger.md +0 -73
- package/skills/massa-ai/references/maestro/js-scripting.md +0 -70
- package/skills/massa-ai/references/maestro/mcp.md +0 -59
- package/skills/massa-ai/references/maestro/patterns.md +0 -102
- package/skills/massa-ai/references/maestro/selectors.md +0 -91
- package/skills/massa-ai/references/maestro/workspace-execution.md +0 -81
- package/skills/massa-ai/references/maestro/yaml-commands.md +0 -203
- package/skills/massa-ai/references/maestro.md +0 -31
- package/skills/massa-ai/workflows/general.md +0 -88
- package/skills/massa-ai/workflows/maestro/maestro-audit.md +0 -64
- package/skills/massa-ai/workflows/maestro/maestro-fix.md +0 -111
- package/skills/massa-ai/workflows/maestro/maestro.md +0 -80
- package/skills/persona-router/SKILL.md +0 -52
- package/skills/persona-router/references/routing-details.md +0 -98
- /package/skills/massa-ai/references/{rfc → create-rfc}/ATTRIBUTION.md +0 -0
- /package/skills/massa-ai/references/{rfc → create-rfc}/document-contract.md +0 -0
- /package/skills/massa-ai/references/{rfc → create-rfc}/quality-and-lifecycle.md +0 -0
- /package/skills/massa-ai/references/{tdd → create-tdd}/document-contract.md +0 -0
- /package/skills/massa-ai/references/{ticket → create-ticket}/atlassian-fix.md +0 -0
- /package/skills/massa-ai/references/{ticket → create-ticket}/templates-and-quality.md +0 -0
|
@@ -50,20 +50,19 @@ Findings-only: do not edit code unless the user separately asks for fixes.
|
|
|
50
50
|
- Do not report strong coupling as a defect when strength is local, stable, or cohesive and no change friction is shown.
|
|
51
51
|
- Do not recommend ports/adapters, service extraction, VSA migration, or new seams unless evidence shows real variation, volatility, external dependency pressure, or boundary friction.
|
|
52
52
|
- Drop candidates disproven by evidence, downgrade candidates with partial mitigation, and mark judgment-heavy conclusions as `suspect`.
|
|
53
|
-
- When you reject a refactor candidate, record its load-bearing reason in ruled-out candidates; if likely to be re-proposed, offer an ADR via `workflows/adr.md` so the rejection is not re-litigated next audit.
|
|
53
|
+
- When you reject a refactor candidate, record its load-bearing reason in ruled-out candidates; if likely to be re-proposed, offer an ADR via `workflows/create-adr.md` so the rejection is not re-litigated next audit.
|
|
54
54
|
8. Use agent orchestration only when it improves signal. Dispatch per `references/agent-orchestration.md`:
|
|
55
55
|
|
|
56
|
-
> **Dispatch: `
|
|
56
|
+
> **Dispatch: `code-reviewer`** (role: `code-reviewer`, mode: `audit`) — charter `skills/agents/code-reviewer/SKILL.md`
|
|
57
57
|
> - trigger: large scope, explicit parallel/subagent request, PR subagent invocation, isolated audit slice, or independent verification of high-impact finding
|
|
58
58
|
> - scope: exact files/modules/boundaries in the audit target
|
|
59
|
-
> -
|
|
60
|
-
> - inputs: shared scope packet; lens sub-mode (`domain` for bounded-context mapping, `coupling` for dependency-graph/strength/distance/volatility, `deepening` for module-depth opportunities); recalled ADRs and rejected refactors
|
|
59
|
+
> - inputs: shared scope packet; `lens: architecture` with optional `sub-mode` (`domain` for bounded-context mapping, `coupling` for dependency-graph/strength/distance/volatility, `deepening` for module-depth opportunities); recalled ADRs and rejected refactors
|
|
61
60
|
> - sensors: `search_definitions` / `get_references` for exported surfaces and dependency direction; source inspection against current files
|
|
62
61
|
> - output: findings with lens-specific evidence, provisional severity, tradeoff, and what would disprove it
|
|
63
62
|
> - firewall: raw dependency graphs, generated reports, and broad search output summarized, not returned raw
|
|
64
63
|
> - memory: suggest-only; main agent persists accepted constraints/rejected refactors
|
|
65
64
|
|
|
66
|
-
> **Dispatch: `
|
|
65
|
+
> **Dispatch: `code-reviewer`** (role: `code-reviewer`, mode: `verify`) — charter `skills/agents/code-reviewer/SKILL.md`
|
|
67
66
|
> - trigger: independent verification of a high-impact architecture finding
|
|
68
67
|
> - scope: the specific finding's claimed evidence and affected boundary/module
|
|
69
68
|
> - inputs: the candidate finding, its source evidence, ADRs, accepted exceptions, and the verification suggestion
|
|
@@ -63,7 +63,7 @@ Not for findings-only architecture review — route to `workflows/architecture/a
|
|
|
63
63
|
- Coupling: reduce strength before distance; replace internal model sharing with explicit contracts, remove cross-boundary knowledge of internals, invert dependencies at stable seams, keep cohesive local coupling close, and avoid cycles.
|
|
64
64
|
- Deepening: delete shallow pass-through modules, merge split concepts when locality improves, deepen useful interfaces by hiding invariants and ordering, test through the interface, and clarify seams only where variation, dependency direction, external I/O, or test substitution justifies it.
|
|
65
65
|
- When a deepening candidate has two or more viable interface shapes, load the Interface Design Method from `references/architecture-deepening-lens.md` (Design It Twice) and pick by leverage and locality before editing.
|
|
66
|
-
- When you decide not to apply a reported refactor, record the load-bearing reason; if likely to recur, offer an ADR via `workflows/adr.md` so the rejection is not re-litigated.
|
|
66
|
+
- When you decide not to apply a reported refactor, record the load-bearing reason; if likely to recur, offer an ADR via `workflows/create-adr.md` so the rejection is not re-litigated.
|
|
67
67
|
- Prefer move, merge, inline, or clarify existing seams before adding new abstractions.
|
|
68
68
|
- Use ports/adapters or anti-corruption layers only when the report evidence shows real volatility, boundary pressure, external dependency pressure, model leakage, or at least two real adapters such as production plus test.
|
|
69
69
|
- Do not turn a local code-quality concern into an architecture migration; route broad new design, VSA migration, new service boundaries, or unclear ownership to `workflows/spec-driven.md`.
|
|
@@ -73,7 +73,7 @@ Not for findings-only architecture review — route to `workflows/architecture/a
|
|
|
73
73
|
- Update tests, docs, and imports only where required by the architecture fix.
|
|
74
74
|
10. Use agent orchestration only when it improves signal — except the verifier dispatch below, which is tier-gated mandatory rather than discretionary, carved out under `references/agent-orchestration.md`'s Independent Verification Exception. Dispatch per `references/agent-orchestration.md`:
|
|
75
75
|
|
|
76
|
-
> **Dispatch: `
|
|
76
|
+
> **Dispatch: `builder`** (role: `builder`) — charter `skills/agents/builder/SKILL.md`
|
|
77
77
|
> - trigger: large/high-risk finding, disjoint implementation slice, or explicit subagent request
|
|
78
78
|
> - scope: one isolated architecture finding with a disjoint write set
|
|
79
79
|
> - permissions: write (disjoint write set)
|
|
@@ -83,17 +83,16 @@ Not for findings-only architecture review — route to `workflows/architecture/a
|
|
|
83
83
|
> - firewall: raw diffs/logs summarized
|
|
84
84
|
> - memory: suggest-only; main agent persists reusable architecture patterns
|
|
85
85
|
|
|
86
|
-
> **Dispatch: `
|
|
86
|
+
> **Dispatch: `code-reviewer`** (role: `code-reviewer`, mode: `review`) — charter `skills/agents/code-reviewer/SKILL.md`
|
|
87
87
|
> - trigger: implementation of the architecture finding complete, before the verification gate — never optional
|
|
88
88
|
> - scope: the fix's diff surface and its task/AC context
|
|
89
|
-
> - permissions: read-only
|
|
90
89
|
> - inputs: diff, ARCH acceptance context, recalled code-quality conventions
|
|
91
90
|
> - sensors: bugs, regressions, missing edge cases, smells introduced by the diff
|
|
92
91
|
> - output: ranked findings, blocking vs advisory; blocking findings become architecture fix items before verification runs
|
|
93
92
|
> - firewall: summarized findings only, never raw diff dumps
|
|
94
93
|
> - memory: suggest-only; main agent persists review outcomes for the architecture fix
|
|
95
94
|
|
|
96
|
-
> **Dispatch: `
|
|
95
|
+
> **Dispatch: `code-reviewer`** (role: `code-reviewer`, mode: `verify`) — charter `skills/agents/code-reviewer/SKILL.md`
|
|
97
96
|
> - trigger: mandatory at Standard+/Spec-driven-sized findings or high/critical severity, per the Independent Verification Mandate in `references/verification-ladder.md`'s Mandatory Verification Fix Gate; Quick-tier findings take the fallback below instead
|
|
98
97
|
> - scope: the fixed finding's dependency direction, seam/adapter shape, tests, imports, and report claim closure
|
|
99
98
|
> - inputs: the finding, the applied fix, the verification suggestion, dependency-direction/import-cycle evidence, and validation assets
|
|
@@ -107,7 +106,7 @@ Not for findings-only architecture review — route to `workflows/architecture/a
|
|
|
107
106
|
- If verification found a reusable signal (`ac_gap`, `surviving_mutant`, `spec_precision_gap`, `spec_deviation`, `gate_fail`), record it via `references/lessons.md`:
|
|
108
107
|
`bun skills/massa-ai/scripts/lessons.ts --root . add --feature "<slug>" --signal "<signal>" --source "<ref>" --text "<one terse lesson>"`
|
|
109
108
|
- Apply the Mandatory Verification Fix Gate from `references/verification-ladder.md`: run the report's Verification Suggestion or an equivalent deterministic command/artifact check for each selected finding or coherent group.
|
|
110
|
-
- Run the sensors at the mandate's own tier gate: dispatch the
|
|
109
|
+
- Run the sensors at the mandate's own tier gate: dispatch the `code-reviewer` `verify` block above at Standard+/Spec-driven size or high/critical severity; a Quick-tier finding runs its fallback fresh-eyes self-check instead — the hop is skippable, the check never is.
|
|
111
110
|
- A surviving mutant on the discrimination sensor marks the finding's Closure Matrix row `blocked` and records a `surviving_mutant` signal via `references/lessons.md`.
|
|
112
111
|
- The fix→re-verify loop is capped per `references/verification-ladder.md`'s Bounded Fix→Re-verify Loop; exhausting it also marks the row `blocked`.
|
|
113
112
|
- A finding cannot be marked `fixed` when a target-relevant command or artifact check exists but was not attempted; if verification cannot run, mark it `blocked`, `deferred`, or `skipped` with an allowed skipped-check reason.
|
|
@@ -28,12 +28,11 @@ Findings-only: do not edit code unless the user separately asks for fixes.
|
|
|
28
28
|
- Apply the Memory Freshness Gate from `references/audit-scope.md`; recalled exceptions are leads, not proof.
|
|
29
29
|
4. Establish the investigation scope: select the scope type and build or accept the shared scope packet per `references/audit-scope.md`, which owns the supported scope types, the ask-when-vague rule, and the packet fields. Carry the packet into the report.
|
|
30
30
|
5. Resolve the selected branch's mechanics (modified files, commit range, codebase area, explicit-files/branch/symbol/feature/whole-repo, or implementation parent scope) per `references/audit-scope.md` (Lens Audit Scope Resolution Procedure, Bugs row of Per-Lens Scope Deltas).
|
|
31
|
-
6. Investigation pass. Dispatch `
|
|
31
|
+
6. Investigation pass. Dispatch `code-reviewer` (`audit` mode) per `references/agent-orchestration.md` when the scope justifies an isolated read-only subagent:
|
|
32
32
|
|
|
33
|
-
> **Dispatch: `
|
|
33
|
+
> **Dispatch: `code-reviewer`** (role: `code-reviewer`, mode: `audit`) — charter `skills/agents/code-reviewer/SKILL.md`
|
|
34
34
|
> - trigger: large scope, explicit parallel/subagent request, PR subagent invocation, or independent verification of high-impact finding
|
|
35
35
|
> - scope: the bugs audit target — files, diffs, suspicious paths
|
|
36
|
-
> - permissions: read-only
|
|
37
36
|
> - inputs: shared scope packet; `lens: bugs`; recalled regressions, known bug patterns, accepted exceptions
|
|
38
37
|
> - sensors: trace input -> transformation -> output; check diffs, callers/callees, tests, config, migrations; prioritize correctness bugs, crashes, data loss, security regressions, broken contracts, async/race issues
|
|
39
38
|
> - output: findings with bug category, location, evidence, trigger, severity, confidence, simplest fix direction, verification suggestion
|
|
@@ -62,7 +62,7 @@ Not for findings-only bug discovery — route to `workflows/bugs/bugs-audit.md`.
|
|
|
62
62
|
- Do not weaken tests, fixtures, snapshots, types, or public contracts to make the fix pass.
|
|
63
63
|
9. Use agent orchestration only when it improves signal, except independent verification of the bug fix, which is mandated at the tiers named in `references/agent-orchestration.md`'s Independent Verification Exception. Dispatch per `references/agent-orchestration.md`:
|
|
64
64
|
|
|
65
|
-
> **Dispatch: `
|
|
65
|
+
> **Dispatch: `builder`** (role: `builder`) — charter `skills/agents/builder/SKILL.md`
|
|
66
66
|
> - trigger: large/high-risk finding, disjoint implementation slice, or explicit subagent request
|
|
67
67
|
> - scope: one isolated bug finding with a disjoint write set
|
|
68
68
|
> - permissions: write (disjoint write set)
|
|
@@ -72,17 +72,16 @@ Not for findings-only bug discovery — route to `workflows/bugs/bugs-audit.md`.
|
|
|
72
72
|
> - firewall: raw diffs/logs summarized
|
|
73
73
|
> - memory: suggest-only; main agent persists reusable bug patterns
|
|
74
74
|
|
|
75
|
-
> **Dispatch: `
|
|
75
|
+
> **Dispatch: `code-reviewer`** (role: `code-reviewer`, mode: `review`) — charter `skills/agents/code-reviewer/SKILL.md`
|
|
76
76
|
> - trigger: implementation complete, before the verification gate — never optional
|
|
77
77
|
> - scope: the fix's diff surface and its task/AC context
|
|
78
|
-
> - permissions: read-only
|
|
79
78
|
> - inputs: diff, acceptance context, recalled code-quality conventions
|
|
80
79
|
> - sensors: bugs, regressions, missing edge cases, smells introduced by the diff
|
|
81
80
|
> - output: ranked findings, blocking vs advisory; blocking findings become fix items before verification runs
|
|
82
81
|
> - firewall: summarized findings only, never raw diff dumps
|
|
83
82
|
> - memory: suggest-only; main agent persists
|
|
84
83
|
|
|
85
|
-
> **Dispatch: `
|
|
84
|
+
> **Dispatch: `code-reviewer`** (role: `code-reviewer`, mode: `verify`) — charter `skills/agents/code-reviewer/SKILL.md`
|
|
86
85
|
> - trigger: mandatory at Standard+/Spec-driven bug-fix size or high/critical bug severity, per the Independent Verification Mandate tier gate in `references/verification-ladder.md`
|
|
87
86
|
> - scope: the fixed bug finding's repro path, regression tests, and report claim closure
|
|
88
87
|
> - inputs: the bug finding, the applied root-cause fix, the verification suggestion, and validation assets
|
|
@@ -100,7 +99,7 @@ Not for findings-only bug discovery — route to `workflows/bugs/bugs-audit.md`.
|
|
|
100
99
|
- A finding cannot be marked `fixed` when a target-relevant command or artifact check exists but was not attempted; if verification cannot run, mark it `blocked`, `deferred`, or `skipped` with an allowed skipped-check reason.
|
|
101
100
|
- Run the report's verification suggestion when available.
|
|
102
101
|
- The red→green reproduction proves the regression test catches this bug; the discrimination sensor proves that same assertion would also discriminate against a future wrong implementation — complementary, and both required at Standard+.
|
|
103
|
-
- At the tiers named in the
|
|
102
|
+
- At the tiers named in the `code-reviewer` `verify` dispatch's trigger above, run the discrimination sensor per `references/discrimination-sensor.md` against the divergence-point fix; a surviving mutant marks the finding's closure row `blocked` and records the `surviving_mutant` lessons signal even when the reproduction test is green.
|
|
104
103
|
- The fix→re-verify cycle is capped per `references/verification-ladder.md`'s Bounded Fix→Re-verify Loop.
|
|
105
104
|
- Run focused regression tests first, then relevant lint/type/build/test commands when feasible.
|
|
106
105
|
- Confirm validation assets were not weakened.
|
|
@@ -42,12 +42,11 @@ Findings-only: do not edit code unless the user separately asks for fixes.
|
|
|
42
42
|
- Load it only for large PRs, codebase-wide audits, explicit parallel/subagent requests, or independent verification of judgment-heavy findings.
|
|
43
43
|
- Keep the audit local for small scopes, unresolved user intent, tightly coupled code without clear owners, or platforms that do not permit subagents.
|
|
44
44
|
- The main agent still owns scope, memory recall, static leads, synthesis, final report, persistence, and Evidence Gate.
|
|
45
|
-
- If delegating, dispatch `
|
|
45
|
+
- If delegating, dispatch `code-reviewer` in `audit` mode with `lens: code-quality` per `references/agent-orchestration.md`:
|
|
46
46
|
|
|
47
|
-
> **Dispatch: `
|
|
47
|
+
> **Dispatch: `code-reviewer`** (role: `code-reviewer`, mode: `audit`) — charter `skills/agents/code-reviewer/SKILL.md`
|
|
48
48
|
> - trigger: large PR, codebase-wide audit, explicit parallel/subagent request, or independent verification of judgment-heavy finding
|
|
49
49
|
> - scope: bounded read-only slice of the audit target
|
|
50
|
-
> - permissions: read-only
|
|
51
50
|
> - inputs: shared scope packet; `lens: code-quality`; quality dimensions (SOLID, Clean Code, KISS/YAGNI, DRY, maintainability)
|
|
52
51
|
> - sensors: static scans for type-tag branches, concrete construction, half-finished surfaces; source inspection
|
|
53
52
|
> - output: findings with smell category, location, evidence, severity, confidence, and simplest fix direction
|
|
@@ -60,9 +60,9 @@ Not for findings-only SOLID, Clean Code, KISS, YAGNI, DRY, maintainability, or o
|
|
|
60
60
|
- Run or identify characterization tests before changing behavior-adjacent code.
|
|
61
61
|
- Do not weaken tests, fixtures, snapshots, types, or public contracts to make cleanup pass.
|
|
62
62
|
- Prefer small reversible edits; verify after each finding or coherent group.
|
|
63
|
-
10. Use agent orchestration only when it improves signal — except the
|
|
63
|
+
10. Use agent orchestration only when it improves signal — except the `code-reviewer` `verify` dispatch below, which `references/agent-orchestration.md`'s Independent Verification Exception mandates at the tiers named in its trigger regardless of signal improvement. Dispatch per `references/agent-orchestration.md`:
|
|
64
64
|
|
|
65
|
-
> **Dispatch: `
|
|
65
|
+
> **Dispatch: `builder`** (role: `builder`) — charter `skills/agents/builder/SKILL.md`
|
|
66
66
|
> - trigger: large/high-risk finding, disjoint implementation slice, or explicit subagent request
|
|
67
67
|
> - scope: one isolated code-quality finding or disjoint file group
|
|
68
68
|
> - permissions: write (disjoint write set)
|
|
@@ -72,17 +72,16 @@ Not for findings-only SOLID, Clean Code, KISS, YAGNI, DRY, maintainability, or o
|
|
|
72
72
|
> - firewall: raw diffs/logs summarized
|
|
73
73
|
> - memory: suggest-only; main agent persists reusable code-quality patterns
|
|
74
74
|
|
|
75
|
-
> **Dispatch: `
|
|
75
|
+
> **Dispatch: `code-reviewer`** (role: `code-reviewer`, mode: `review`) — charter `skills/agents/code-reviewer/SKILL.md`
|
|
76
76
|
> - trigger: implementation of the CQ finding complete, before the verification gate — never optional
|
|
77
77
|
> - scope: the fix's diff surface and its task/AC context
|
|
78
|
-
> - permissions: read-only
|
|
79
78
|
> - inputs: diff, CQ acceptance context, recalled code-quality conventions
|
|
80
79
|
> - sensors: bugs, regressions, missing edge cases, smells introduced by the diff
|
|
81
80
|
> - output: ranked findings, blocking vs advisory; blocking findings become CQ fix items before verification runs
|
|
82
81
|
> - firewall: summarized findings only, never raw diff dumps
|
|
83
82
|
> - memory: suggest-only; main agent persists review outcomes for the code-quality fix
|
|
84
83
|
|
|
85
|
-
> **Dispatch: `
|
|
84
|
+
> **Dispatch: `code-reviewer`** (role: `code-reviewer`, mode: `verify`) — charter `skills/agents/code-reviewer/SKILL.md`
|
|
86
85
|
> - trigger: mandatory per the verification-ladder's Independent Verification Mandate at Standard+/Spec-driven finding size or high/critical severity; at Quick size the subagent hop is skipped and the standalone fresh-eyes check below runs instead
|
|
87
86
|
> - scope: the fixed finding's behavior-preservation claim over the moved/transformed code, its call sites/imports, and report claim closure
|
|
88
87
|
> - inputs: the finding, the applied fix, the verification suggestion, and validation assets
|
|
@@ -12,7 +12,7 @@ Use when the user wants to draft a commit message, prepare a commit, or commit c
|
|
|
12
12
|
|
|
13
13
|
Load `references/project-context.md` (intake sweep) before the first substantive read.
|
|
14
14
|
|
|
15
|
-
Not for Jira ticket creation, release notes, changelogs, PR descriptions, or history rewriting. Route Jira issue work to `workflows/ticket.md`. Route broad release documentation to the relevant feature
|
|
15
|
+
Not for Jira ticket creation, release notes, changelogs, PR descriptions, or history rewriting. Route Jira issue work to `workflows/create-ticket.md`. Route broad release documentation to the relevant feature or RFC workflow.
|
|
16
16
|
|
|
17
17
|
## Workflow
|
|
18
18
|
|
|
@@ -24,8 +24,8 @@ Not for Jira ticket creation, release notes, changelogs, PR descriptions, or his
|
|
|
24
24
|
- unstaged changed paths from `git diff --name-only`
|
|
25
25
|
- status summary from `git status --short`
|
|
26
26
|
- staged diff when anything is staged; otherwise the unstaged diff for allowed paths
|
|
27
|
-
4. Extract the first Jira key from the branch with case-insensitive regex `(?<![A-Z0-9])([A-Z][A-Z0-9]{1,9}-[0-9]+)(?![A-Z0-9])`. Normalize to uppercase. If no key is found, proceed without a prefix and do not ask. An explicit task key (from `workflows/ticket.md` for phased work, or from the user) takes precedence over the branch-derived key.
|
|
28
|
-
- **Phased work — one commit per task, prefixed with the task's sub-task key.** When committing phased work sourced from `workflows/ticket.md`, each Task inside a Phase/Wave is exactly **one atomic commit** (never batched; the one-commit-per-task cadence is owned by the Implementation Delivery Protocol, Stage 2). Prefix that commit's subject with the Task's Jira **sub-task** key as `[XXX-YYYY]`, e.g. `[SA-142] feat(auth): reject expired tokens` — same `[<KEY>] ` rule below, sub-task key replacing the generic branch key.
|
|
27
|
+
4. Extract the first Jira key from the branch with case-insensitive regex `(?<![A-Z0-9])([A-Z][A-Z0-9]{1,9}-[0-9]+)(?![A-Z0-9])`. Normalize to uppercase. If no key is found, proceed without a prefix and do not ask. An explicit task key (from `workflows/create-ticket.md` for phased work, or from the user) takes precedence over the branch-derived key.
|
|
28
|
+
- **Phased work — one commit per task, prefixed with the task's sub-task key.** When committing phased work sourced from `workflows/create-ticket.md`, each Task inside a Phase/Wave is exactly **one atomic commit** (never batched; the one-commit-per-task cadence is owned by the Implementation Delivery Protocol, Stage 2). Prefix that commit's subject with the Task's Jira **sub-task** key as `[XXX-YYYY]`, e.g. `[SA-142] feat(auth): reject expired tokens` — same `[<KEY>] ` rule below, sub-task key replacing the generic branch key.
|
|
29
29
|
5. Resolve commit scope:
|
|
30
30
|
- If files are already staged, treat staged files as the user-selected commit scope and do not stage additional files.
|
|
31
31
|
- If nothing is staged and the user explicitly asked to commit, stage only allowed changed files one path at a time with pathspec-safe commands.
|
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
---
|
|
2
|
-
name: adr
|
|
3
|
-
description: "Use this workflow to record a finalized or being-finalized architecture decision; route open options to rfc and implementation planning to tdd."
|
|
2
|
+
name: create-adr
|
|
3
|
+
description: "Use this workflow to record a finalized or being-finalized architecture decision; route open options to create-rfc and implementation planning to create-tdd."
|
|
4
4
|
license: MIT
|
|
5
5
|
metadata:
|
|
6
6
|
version: "1.1.0"
|
|
@@ -8,17 +8,17 @@ metadata:
|
|
|
8
8
|
|
|
9
9
|
### 📜 ADR (Architecture Decision Record)
|
|
10
10
|
|
|
11
|
-
Record a finalized or being-finalized architecture decision. Not for deciding among open options — route undecided proposals to `workflows/rfc.md`. Not for implementation planning — route that to `workflows/tdd.md`.
|
|
11
|
+
Record a finalized or being-finalized architecture decision. Not for deciding among open options — route undecided proposals to `workflows/create-rfc.md`. Not for implementation planning — route that to `workflows/create-tdd.md`.
|
|
12
12
|
|
|
13
13
|
Load `references/project-context.md` (intake sweep) before the first substantive read.
|
|
14
14
|
|
|
15
|
-
1. Resolve/reuse `projectId` and `workflowSessionId`: `adr-[entity]`.
|
|
15
|
+
1. Resolve/reuse `projectId` and `workflowSessionId`: `create-adr-[entity]`.
|
|
16
16
|
2. Load shared references:
|
|
17
|
-
- `references/adr
|
|
17
|
+
- `references/create-adr.md` always.
|
|
18
18
|
- `references/context-firewall.md` before reading large Markdown files, Atlassian pages, NotebookLM outputs, Figma exports, broad research, or verbose source output.
|
|
19
19
|
- `references/mobile-context.md` only when ADR context touches KMP, iOS, Android, native bridges, mobile lifecycle, offline sync, permissions, push/background behavior, local persistence, or backend-mobile contracts.
|
|
20
20
|
3. `recall` -> load previous decisions, related RFCs, PRDs, discussions, superseded ADRs, accepted constraints, rejected options, and project-specific ADR conventions for the entity.
|
|
21
|
-
4. Gather source context using `references/adr
|
|
21
|
+
4. Gather source context using `references/create-adr.md`:
|
|
22
22
|
- Use explicitly provided Markdown files and prompt context first.
|
|
23
23
|
- Use ADR templates, PRDs, and RFCs from Markdown or Atlassian MCP when provided.
|
|
24
24
|
- Use optional complementary-stack ADRs (Markdown or Atlassian MCP) as cross-stack context only when they affect contracts, constraints, dependencies, risks, or links.
|
|
@@ -27,12 +27,12 @@ Load `references/project-context.md` (intake sweep) before the first substantive
|
|
|
27
27
|
- When Figma links, nodes, desktop selections, or screenshots materially affect the decision, use `workflows/design.md` as optional child context for mobile UI implications only; the ADR still owns the decision record. Screenshots are context-only unless paired with structured Figma evidence.
|
|
28
28
|
- Use NotebookLM only when the user provides one or more notebook IDs; query each relevant notebook separately, preserve attribution, and do not assume a default notebook.
|
|
29
29
|
- Corroborate with massa-ai search, current repo docs, existing ADRs, and code when the decision depends on current project reality.
|
|
30
|
-
5. Run the ADR readiness gate from `references/adr
|
|
30
|
+
5. Run the ADR readiness gate from `references/create-adr.md`:
|
|
31
31
|
- If a needed PRD, RFC, template, decision detail, or source fact is absent, ask for the missing context instead of inventing it.
|
|
32
|
-
- If an RFC is needed but absent and the user does not know the missing context, assume the decision is not made and route to `workflows/rfc.md`.
|
|
32
|
+
- If an RFC is needed but absent and the user does not know the missing context, assume the decision is not made and route to `workflows/create-rfc.md`.
|
|
33
33
|
- Require a source-backed or user-confirmed title, date, status, context, decision, consequences, links, and supersession status before drafting.
|
|
34
|
-
6. Draft the ADR using the project's template when available; otherwise use the format selected via `references/adr
|
|
35
|
-
7. Run the configured Plan Challenge Gate before saving. ADR decisions require the full gate under the default policy (`adr` is named in the full-gate set of the canonical Plan Challenge Policy); revise valid critical or high findings before the record is written, especially a decision presented without its rejected alternatives, consequences stated only as benefits, an unstated assumption the decision depends on, and status quo or sunk-cost bias in the framing. A challenge that invalidates the decision means the decision is not final — route to `workflows/rfc.md` rather than recording it.
|
|
34
|
+
6. Draft the ADR using the project's template when available; otherwise use the format selected via `references/create-adr.md`'s fallback questions. Tie claims to source confidence: confirmed, user-provided, recalled, inferred, or unresolved.
|
|
35
|
+
7. Run the configured Plan Challenge Gate before saving. ADR decisions require the full gate under the default policy (`create-adr` is named in the full-gate set of the canonical Plan Challenge Policy); revise valid critical or high findings before the record is written, especially a decision presented without its rejected alternatives, consequences stated only as benefits, an unstated assumption the decision depends on, and status quo or sunk-cost bias in the framing. A challenge that invalidates the decision means the decision is not final — route to `workflows/create-rfc.md` rather than recording it.
|
|
36
36
|
8. Save the generated ADR using the selected output target:
|
|
37
37
|
- Default: write to the project's standard ADR directory in Default mode. In Plan Mode, propose the path and content without writing.
|
|
38
38
|
- Confluence: when requested and a parent page link is provided, write a child page through Atlassian MCP and report the resulting page link.
|
|
@@ -1,12 +1,12 @@
|
|
|
1
1
|
---
|
|
2
|
-
name:
|
|
2
|
+
name: create-prd
|
|
3
3
|
description: "Turn the current conversation into a PRD. Use when the user asks to create, synthesize, or convert existing discussion and codebase context into a Product Requirements Document without another interview. Do NOT use for implementation plans, architecture design docs, RFCs, TDDs, or discovery interviews that require new product questioning."
|
|
4
4
|
license: MIT
|
|
5
5
|
metadata:
|
|
6
6
|
version: "1.2.0"
|
|
7
7
|
---
|
|
8
8
|
|
|
9
|
-
###
|
|
9
|
+
### Create-PRD (Conversation → Product Requirements Document)
|
|
10
10
|
|
|
11
11
|
This skill takes the current conversation context and codebase understanding and produces a PRD. Do NOT interview the user — just synthesize what you already know. The PRD follows the same pattern as `references/spec-driven/specify.md`: definitions, required sections, and directions are shared so a PRD produced here is structurally consistent with a feature spec produced by spec-driven Specify.
|
|
12
12
|
|
|
@@ -180,10 +180,10 @@ Apply the `ready-for-agent` triage label — no need for additional triage.
|
|
|
180
180
|
|
|
181
181
|
## Done
|
|
182
182
|
|
|
183
|
-
|
|
183
|
+
Create-PRD is done when every requirement has an ID, acceptance criteria are testable EARS statements, edge cases are named, out-of-scope boundaries are explicit, implicit-requirement dimensions are resolved or marked `N/A because <reason>`, the Requirement Closure Gate is satisfied, and `validate_spec.ts` exits clean (or the no-code-execution-tool fallback was applied).
|
|
184
184
|
|
|
185
185
|
## Massa-ai Integration
|
|
186
186
|
|
|
187
187
|
- **Code analysis:** Use massa-ai tools first (`list_projects`, `search`, `project_map`, `optimized_context`) before `ast-grep`/`rg`/`grep` for the explore step. Current source overrides a stale index or memory (source-precedence rule).
|
|
188
|
-
- **Memory:** Persist verified outcomes worth reusing with `remember`, tagging `project:<id>`, `session:<id>`, `workflow:
|
|
188
|
+
- **Memory:** Persist verified outcomes worth reusing with `remember`, tagging `project:<id>`, `session:<id>`, `workflow:create-prd`, `entity:<slug>`, `memory:working|episodic|semantic|procedural`.
|
|
189
189
|
- **Validation:** Evidence-or-zero. Every requirement resolved and assumption logged is checked against current source.
|
|
@@ -1,5 +1,5 @@
|
|
|
1
1
|
---
|
|
2
|
-
name: rfc
|
|
2
|
+
name: create-rfc
|
|
3
3
|
description: "Use this workflow when a significant technical, process, product, vendor, tool, or policy decision is still open and stakeholders need a structured proposal before committing."
|
|
4
4
|
license: MIT
|
|
5
5
|
metadata:
|
|
@@ -8,16 +8,16 @@ metadata:
|
|
|
8
8
|
|
|
9
9
|
### RFC (Request for Comments)
|
|
10
10
|
|
|
11
|
-
Use when a significant technical, process, product, vendor, tool, or policy decision is still open and stakeholders need a structured proposal before committing to a direction. Route a finalized architecture decision to `workflows/adr.md`, settled implementation design to `workflows/tdd.md`, and broad requirements-through-delivery work to `workflows/spec-driven.md`.
|
|
11
|
+
Use when a significant technical, process, product, vendor, tool, or policy decision is still open and stakeholders need a structured proposal before committing to a direction. Route a finalized architecture decision to `workflows/create-adr.md`, settled implementation design to `workflows/create-tdd.md`, and broad requirements-through-delivery work to `workflows/spec-driven.md`.
|
|
12
12
|
|
|
13
13
|
Load `references/project-context.md` (intake sweep) before the first substantive read.
|
|
14
14
|
|
|
15
15
|
## Workflow
|
|
16
16
|
|
|
17
|
-
1. Resolve or reuse `projectId` and `workflowSessionId=rfc-[entity]`.
|
|
17
|
+
1. Resolve or reuse `projectId` and `workflowSessionId=create-rfc-[entity]`.
|
|
18
18
|
2. Establish evidence before asking questions:
|
|
19
19
|
- `recall` relevant constraints, existing architecture or process, related proposals, prior attempts, rejected options, stakeholder expectations, and verification patterns.
|
|
20
|
-
- Load `references/rfc/discovery-and-sizing.md`.
|
|
20
|
+
- Load `references/create-rfc/discovery-and-sizing.md`.
|
|
21
21
|
- Inspect current source, project instructions, existing RFC conventions, decision records, tickets, and supplied research. Current source and approved project artifacts override stale memory.
|
|
22
22
|
- When supplied Figma links, nodes, desktop selections, or screenshots materially affect mobile UI options, use `workflows/design.md` as optional child context for visual feasibility only; the RFC still owns option comparison and recommendation. Screenshots are context-only unless paired with structured Figma evidence.
|
|
23
23
|
- Load `references/synapse-policy.md` when two or more related searches are expected and `references/context-firewall.md` before broad or verbose source inspection.
|
|
@@ -27,7 +27,7 @@ Load `references/project-context.md` (intake sweep) before the first substantive
|
|
|
27
27
|
- Ask concise conversational questions when `AskQuestion` is unavailable.
|
|
28
28
|
- Require title, background, full RACI roles, impact, urgency or due date, assumptions with confidence and invalidation triggers, weighted decision criteria, at least two options, and a recommendation.
|
|
29
29
|
- Reuse supplied or discoverable facts; do not ask for information already present.
|
|
30
|
-
5. Load `references/rfc/document-contract.md` and draft the RFC in the same language as the user's request.
|
|
30
|
+
5. Load `references/create-rfc/document-contract.md` and draft the RFC in the same language as the user's request.
|
|
31
31
|
- Preserve the 7 mandatory and 4 recommended sections, numeric criterion weights, honest option comparison, generated cost and effort estimates, status quo consideration, action items, and outcome placeholder.
|
|
32
32
|
- Tailor conditional concerns to technical/architecture, process/workflow, product/feature, vendor/tool, or policy/compliance proposals.
|
|
33
33
|
- Mark generated estimates as estimates and state their assumptions when exact project data is unavailable.
|
|
@@ -35,7 +35,7 @@ Load `references/project-context.md` (intake sweep) before the first substantive
|
|
|
35
35
|
- If the target exists, update it only when the user explicitly requested an update; otherwise ask before overwriting.
|
|
36
36
|
- When file mutation is unavailable or the user requested plan-only output, present the complete draft and intended path without writing.
|
|
37
37
|
7. Run the full configured Plan Challenge Gate. Preserve all required RFC fields while revising valid critical or high findings, especially one-sided options, unsupported claims, hidden assumptions, status quo bias, weak cost estimates, and criteria chosen to justify a predetermined conclusion.
|
|
38
|
-
8. Load `references/rfc/quality-and-lifecycle.md`, validate every required behavior, and resolve blocking gaps. Keep unresolved facts explicit instead of silently removing mandatory fields.
|
|
38
|
+
8. Load `references/create-rfc/quality-and-lifecycle.md`, validate every required behavior, and resolve blocking gaps. Keep unresolved facts explicit instead of silently removing mandatory fields.
|
|
39
39
|
9. Save the proposal with status `NOT STARTED` or `IN PROGRESS`. Set `COMPLETE` and fill the Outcome section only when an explicit human decision or authoritative project record is available.
|
|
40
40
|
10. Persist proposal state after recall, deduplication, and scoring:
|
|
41
41
|
- Pending or in-review proposal: scored `conversation` memory with `memory:working`.
|
|
@@ -1,5 +1,5 @@
|
|
|
1
1
|
---
|
|
2
|
-
name: tdd
|
|
2
|
+
name: create-tdd
|
|
3
3
|
description: "Use this workflow to write a Technical Design Document once one product direction is selected and no unresolved API, data, security, or rollout decision blocks implementation."
|
|
4
4
|
license: MIT
|
|
5
5
|
metadata:
|
|
@@ -8,25 +8,25 @@ metadata:
|
|
|
8
8
|
|
|
9
9
|
### TDD (Technical Design Document)
|
|
10
10
|
|
|
11
|
-
Use when the readiness checklist is true: one product direction is selected, a named requirements source exists, and no unresolved API, data, security/privacy, migration, rollout, or public compatibility decision blocks implementation design. Route unresolved proposals or competing directions to `workflows/rfc.md`, isolated finalized architecture decisions to `workflows/adr.md`, and broad requirements-to-delivery work to `workflows/spec-driven.md`.
|
|
11
|
+
Use when the readiness checklist is true: one product direction is selected, a named requirements source exists, and no unresolved API, data, security/privacy, migration, rollout, or public compatibility decision blocks implementation design. Route unresolved proposals or competing directions to `workflows/create-rfc.md`, isolated finalized architecture decisions to `workflows/create-adr.md`, and broad requirements-to-delivery work to `workflows/spec-driven.md`.
|
|
12
12
|
|
|
13
13
|
Load `references/project-context.md` (intake sweep) before the first substantive read.
|
|
14
14
|
|
|
15
15
|
## Workflow
|
|
16
16
|
|
|
17
|
-
1. Resolve or reuse `projectId` and `workflowSessionId=tdd-[entity]`.
|
|
17
|
+
1. Resolve or reuse `projectId` and `workflowSessionId=create-tdd-[entity]`.
|
|
18
18
|
2. Establish evidence before asking questions:
|
|
19
19
|
- `recall` approved RFCs, ADRs, prior TDD decisions, constraints, rejected approaches, and verification patterns.
|
|
20
|
-
- Load `references/tdd/discovery-and-sizing.md`.
|
|
20
|
+
- Load `references/create-tdd/discovery-and-sizing.md`.
|
|
21
21
|
- Inspect current source, tests, source sets, project instructions, architecture documents, and existing design artifacts. Current source and approved project artifacts override stale memory.
|
|
22
22
|
- For testing plans, find whether each planned test file already exists and which source set owns it before choosing a location such as `commonTest`, `androidUnitTest`, `unitTest`, or the repository's actual equivalent.
|
|
23
23
|
- For UI/UX-affecting method, class, enum, sealed type, mapper, or state changes, enumerate parallel rendering surfaces and mappers that consume the affected symbol.
|
|
24
24
|
- When supplied Figma links, nodes, desktop selections, or screenshots materially affect supported Android, iOS, or KMP Compose Multiplatform UI design, use `workflows/design.md` as optional child context and keep this TDD as the owner of architecture, contracts, rollout, and verification strategy. Screenshots are context-only unless paired with structured Figma evidence.
|
|
25
25
|
- Run a pre-TDD `Strings Audit` when mappers branch on a type and call `stringResource`; record affected string keys/resources, branches, fallback behavior, and surfaces before proposing string changes.
|
|
26
26
|
- Load `references/synapse-policy.md` when two or more related searches are expected and `references/context-firewall.md` before broad or verbose source inspection.
|
|
27
|
-
3. Confirm workflow fit with the readiness checklist in `references/tdd/discovery-and-sizing.md` and classify the document as Compact, Standard, or High-Risk from the exact sizing rules there. Do not size by guessed calendar duration.
|
|
28
|
-
- Record a `project_type` intake tag from this taxonomy: `integration`, `feature`, `refactor`, `infrastructure`, `payment`, `auth`, `data`. The `project_type` selects which conditional concerns in `references/tdd/document-contract.md` apply and which calibrated reference values from `references/tdd/calibrated-examples.md` are relevant; it does not mandate section counts or a fixed document shape.
|
|
29
|
-
- Apply the critical-section MANDATORY trigger mapping below. These are workflow-level selectors that point at the Conditional Concerns table in `references/tdd/document-contract.md`; they do not duplicate that table. When a trigger fires, the matching concerns are mandatory, not optional:
|
|
27
|
+
3. Confirm workflow fit with the readiness checklist in `references/create-tdd/discovery-and-sizing.md` and classify the document as Compact, Standard, or High-Risk from the exact sizing rules there. Do not size by guessed calendar duration.
|
|
28
|
+
- Record a `project_type` intake tag from this taxonomy: `integration`, `feature`, `refactor`, `infrastructure`, `payment`, `auth`, `data`. The `project_type` selects which conditional concerns in `references/create-tdd/document-contract.md` apply and which calibrated reference values from `references/create-tdd/calibrated-examples.md` are relevant; it does not mandate section counts or a fixed document shape.
|
|
29
|
+
- Apply the critical-section MANDATORY trigger mapping below. These are workflow-level selectors that point at the Conditional Concerns table in `references/create-tdd/document-contract.md`; they do not duplicate that table. When a trigger fires, the matching concerns are mandatory, not optional:
|
|
30
30
|
- `payment`, `auth`, PII, or regulated data → Security is mandatory.
|
|
31
31
|
- production or customer-facing rollout → Monitoring and Rollback are mandatory.
|
|
32
32
|
- external or cross-service integration → Dependencies and Security are mandatory.
|
|
@@ -35,7 +35,7 @@ Load `references/project-context.md` (intake sweep) before the first substantive
|
|
|
35
35
|
- Group related questions naturally, in the user's language — no numeric cap; ask as many as the open decisions require.
|
|
36
36
|
- Distinguish verified facts, evidence-backed inferences, proposed decisions, and unresolved questions.
|
|
37
37
|
- Never invent owners, links, APIs, schemas, vendors, dates, thresholds, estimates, approvals, or project facts to complete a template.
|
|
38
|
-
5. Load `references/tdd/document-contract.md`, plus `references/naming-standards.md` when the design names proposed components, modules, states, events, schemas, or fields, and draft the smallest decision-complete TDD for the selected depth.
|
|
38
|
+
5. Load `references/create-tdd/document-contract.md`, plus `references/naming-standards.md` when the design names proposed components, modules, states, events, schemas, or fields, and draft the smallest decision-complete TDD for the selected depth.
|
|
39
39
|
- Write in the user's language while preserving established project terminology and technical identifiers.
|
|
40
40
|
- Focus on architecture, ownership boundaries, stable interfaces, data flow, failure behavior, and implementation strategy.
|
|
41
41
|
- Include implementation detail when it defines a contract or removes material ambiguity; exclude production implementation code and incidental framework syntax.
|
|
@@ -49,12 +49,12 @@ Load `references/project-context.md` (intake sweep) before the first substantive
|
|
|
49
49
|
- If the target exists, treat the request as an update only when the user explicitly requested one; otherwise ask before overwriting it.
|
|
50
50
|
- When file mutation is unavailable or the user requested plan-only output, present the complete draft and intended path without writing.
|
|
51
51
|
7. Run the configured Plan Challenge Gate. TDD plans require the full gate under the default policy; revise valid critical or high findings before finalization.
|
|
52
|
-
8. Load `references/tdd/quality-and-lifecycle.md`, validate the document, and resolve blocking gaps. Keep non-blocking unknowns explicit with owners or decision points when known.
|
|
52
|
+
8. Load `references/create-tdd/quality-and-lifecycle.md`, validate the document, and resolve blocking gaps. Keep non-blocking unknowns explicit with owners or decision points when known.
|
|
53
53
|
9. If the implementation task table is stable and validated, discover whether Atlassian MCP has readable Jira project metadata and issue-creation capability.
|
|
54
54
|
- If Atlassian MCP is unavailable or read-only, leave the table's `Jira Key` values as `Unavailable` and report that ticket creation was skipped.
|
|
55
55
|
- If Atlassian MCP is available, ask whether the user wants to create Jira tickets now. If declined, set `Jira Key` to `Not requested`.
|
|
56
|
-
- If the user accepts, invoke `workflows/ticket.md`; Jira creation remains owned solely by the ticket workflow. Create one standard Jira issue per PR group. Create row-level sub-tasks only when the selected ticket hierarchy requires them.
|
|
57
|
-
- Update `Jira Key` only with confirmed Jira keys returned by the ticket workflow. Use `Pending` for approved-but-uncreated PR groups and never fabricate keys.
|
|
56
|
+
- If the user accepts, invoke `workflows/create-ticket.md`; Jira creation remains owned solely by the `create-ticket` workflow. Create one standard Jira issue per PR group. Create row-level sub-tasks only when the selected ticket hierarchy requires them.
|
|
57
|
+
- Update `Jira Key` only with confirmed Jira keys returned by the create-ticket workflow. Use `Pending` for approved-but-uncreated PR groups and never fabricate keys.
|
|
58
58
|
10. Save the document as `Draft` or `In Review`. Never mark it `Approved`, invent sign-off, or begin downstream implementation without the required human decision.
|
|
59
59
|
11. Persist only durable architecture constraints, accepted trade-offs, rejected approaches, compatibility requirements, and verification recipes through `remember` after recall, deduplication, and scoring. Use `decision` with `memory:semantic` for the architectural blueprint.
|
|
60
60
|
12. Complete `references/evidence-gate.md` and report the artifact path, included conditional sections, unresolved questions, Jira creation outcome, memory outcome, and residual risk.
|
|
@@ -1,5 +1,5 @@
|
|
|
1
1
|
---
|
|
2
|
-
name: ticket
|
|
2
|
+
name: create-ticket
|
|
3
3
|
description: "Use this workflow to draft, review, create, or resume creation of Jira Epics, issues, or sub-tasks through Atlassian MCP, the only tracker and mutation path."
|
|
4
4
|
license: MIT
|
|
5
5
|
metadata:
|
|
@@ -14,12 +14,12 @@ Load `references/project-context.md` (intake sweep) before the first substantive
|
|
|
14
14
|
|
|
15
15
|
## Workflow
|
|
16
16
|
|
|
17
|
-
1. Resolve or reuse `projectId` and `workflowSessionId=ticket-<entity>`.
|
|
17
|
+
1. Resolve or reuse `projectId` and `workflowSessionId=create-ticket-<entity>`.
|
|
18
18
|
2. Recall durable project conventions, prior Jira constraints, and ticket-writing decisions through `recall`. Treat recalled facts as leads until confirmed by the user or current Jira metadata.
|
|
19
19
|
3. Load the focused contracts:
|
|
20
|
-
- `references/ticket/intake-and-sources.md` for ordered questions, reference-ticket isolation, DoR/DoD inputs, and bounded code exploration.
|
|
21
|
-
- `references/ticket/templates-and-quality.md` for title prefixes, built-in templates, decomposition, and draft validation.
|
|
22
|
-
- `references/ticket/atlassian-fix.md` before tool discovery, preflight, approval, Jira creation, resume, or cleanup.
|
|
20
|
+
- `references/create-ticket/intake-and-sources.md` for ordered questions, reference-ticket isolation, DoR/DoD inputs, and bounded code exploration.
|
|
21
|
+
- `references/create-ticket/templates-and-quality.md` for title prefixes, built-in templates, decomposition, and draft validation.
|
|
22
|
+
- `references/create-ticket/atlassian-fix.md` before tool discovery, preflight, approval, Jira creation, resume, or cleanup.
|
|
23
23
|
- `references/context-firewall.md` when Jira, Confluence, supplied files, or exploration output could flood context.
|
|
24
24
|
4. Discover Atlassian MCP capabilities dynamically. Require readable Jira project metadata and issue-creation capability before promising creation. If Atlassian MCP is missing or read-only, drafting may continue, but stop before approval-to-create and report the unavailable capability. Never substitute a CLI or tracker.
|
|
25
25
|
5. Run ordered intake from `intake-and-sources.md`. Ask only for information not already supplied or discoverable from Atlassian metadata. Validate the exact project key without silently correcting it.
|
|
@@ -67,17 +67,16 @@ Before the first repository mutation, load `references/implementation-delivery.m
|
|
|
67
67
|
- (a) write the test first, asserting the exact previously-broken behavior at the divergence point
|
|
68
68
|
- (b) at Standard+, prove the coverage discriminates: run the sensor in `references/discrimination-sensor.md` against the just-fixed code; a surviving mutant means the regression test does not yet prove the fix
|
|
69
69
|
|
|
70
|
-
> **Dispatch: `
|
|
70
|
+
> **Dispatch: `code-reviewer`** (role: `code-reviewer`, mode: `review`) — charter `skills/agents/code-reviewer/SKILL.md`
|
|
71
71
|
> - trigger: implementation complete, before the verification gate — never optional
|
|
72
72
|
> - scope: the fix's diff surface and its task/AC context
|
|
73
|
-
> - permissions: read-only
|
|
74
73
|
> - inputs: diff, acceptance context, recalled code-quality conventions
|
|
75
74
|
> - sensors: bugs, regressions, missing edge cases, smells introduced by the diff
|
|
76
75
|
> - output: ranked findings, blocking vs advisory; blocking findings become fix items before verification runs
|
|
77
76
|
> - firewall: summarized findings only, never raw diff dumps
|
|
78
77
|
> - memory: suggest-only; main agent persists
|
|
79
78
|
|
|
80
|
-
> **Dispatch: `
|
|
79
|
+
> **Dispatch: `code-reviewer`** (role: `code-reviewer`, mode: `verify`) — charter `skills/agents/code-reviewer/SKILL.md`
|
|
81
80
|
> - trigger: mandatory at Standard+/Spec-driven fix size, per the Independent Verification Mandate tier gate in `references/verification-ladder.md`; a Quick-tier fix takes the fallback below instead
|
|
82
81
|
> - scope: the fixed divergence point from step 13, its reproduction path, and the regression test added in step 14
|
|
83
82
|
> - inputs: the root cause, the reproduction evidence, the regression test, and the changed files — not spec acceptance criteria
|
|
@@ -116,7 +115,7 @@ Before the first repository mutation, load `references/implementation-delivery.m
|
|
|
116
115
|
|
|
117
116
|
- `.specs/debug/<slug>/` unwritable at Standard+: block the `REPORT.md` write and record the blocker; never substitute a memory write or chat summary for the canonical debug artifact.
|
|
118
117
|
- Fix → re-verify loop reaches the `references/verification-ladder.md` cap: stop the session `Blocked`, preserve the collected reproduction and verification evidence, and ask the user for direction.
|
|
119
|
-
- Discrimination sensor mutation on the fixed divergence point is not safely reversible: mark `Blocked` unless the
|
|
118
|
+
- Discrimination sensor mutation on the fixed divergence point is not safely reversible: mark `Blocked` unless the `code-reviewer` verifier can show equivalent discrimination from an existing deterministic mutation fixture.
|
|
120
119
|
|
|
121
120
|
## Example
|
|
122
121
|
|
|
@@ -129,4 +128,4 @@ User asks: "The login route returns 500 after deploy."
|
|
|
129
128
|
5. Trace request → auth middleware → session lookup → response, then fix the divergence point closest to the root cause.
|
|
130
129
|
6. Define the verification recipe: rerun the original route check, add or update regression coverage at the failing seam, and confirm validation assets were not weakened.
|
|
131
130
|
7. If root cause is a missing `DATABASE_URL`, persist via `remember`: a semantic decision memory for the root cause and a procedural pattern memory for the deploy-env verification command.
|
|
132
|
-
8. At Standard+ size, dispatch `
|
|
131
|
+
8. At Standard+ size, dispatch `code-reviewer` in `verify` mode to independently re-run the reproduction against the `DATABASE_URL` fix and confirm the regression test kills a mutant on the restored connection check before closing.
|
|
@@ -28,9 +28,9 @@ Not for Flutter, React Native, web UI, generic Figma exploration, variable-only
|
|
|
28
28
|
6. Persist only durable token/component mappings, approved deviations, source-set ownership rules, asset-pipeline rules, or reusable render recipes after Importance Calibration. Use `workflow:design` and required project/session/entity/memory tags.
|
|
29
29
|
7. Complete `references/evidence-gate.md`. Model visual judgment alone cannot satisfy completion.
|
|
30
30
|
|
|
31
|
-
**Screen work —
|
|
31
|
+
**Screen work — unconditional in this workflow:** every task here implements a user-facing screen, so the `designer` dispatch below always runs; it is not gated on a screen-work condition (Screen Implementation Exception in `references/agent-orchestration.md`).
|
|
32
32
|
|
|
33
|
-
> **Dispatch: `
|
|
33
|
+
> **Dispatch: `designer`** (role: `designer`, mode: `implement`) — charter `skills/agents/designer/SKILL.md`
|
|
34
34
|
> - scope: the screens, views, components, layouts, styles, and design tokens in this task's UI surface — never the whole repository
|
|
35
35
|
> - permissions: write, scoped to UI-layer files only with a disjoint write set
|
|
36
36
|
> - output: per-element conformance table (element, expected, actual, verdict, severity) plus the UI files written; a missing or unreachable design source is listed as a skipped sensor, never a silent pass
|
|
@@ -51,9 +51,9 @@ When researching or resolving any technical question during exploration, follow
|
|
|
51
51
|
- per step, state a `verify:` criterion — what concrete evidence confirms that step succeeded (a read signature, a matched call graph, a resolved data path) before moving on
|
|
52
52
|
- define what evidence would be enough to answer the user
|
|
53
53
|
- ask only if the objective or scope cannot be inferred from local context
|
|
54
|
-
6. Recon with progressive disclosure. Dispatch `
|
|
54
|
+
6. Recon with progressive disclosure. Dispatch `code-explorer` per `references/agent-orchestration.md` when the investigation justifies an isolated read-only subagent:
|
|
55
55
|
|
|
56
|
-
> **Dispatch: `
|
|
56
|
+
> **Dispatch: `code-explorer`** (role: `code-explorer`, mode: `trace`) — charter `skills/agents/code-explorer/SKILL.md`
|
|
57
57
|
> - trigger: isolated read-only investigation justified; large scope, repeated searches, or context-firewall threshold exceeded
|
|
58
58
|
> - scope: the exploration target — symbols, files, routes, commands, docs, or runtime artifacts to inspect
|
|
59
59
|
> - permissions: read-only
|
|
@@ -54,25 +54,24 @@ Before the first repository mutation, load `references/implementation-delivery.m
|
|
|
54
54
|
- When every group has a confirmed Jira key, follow the optional stacked branch flow in `references/pr-task-fix.md` (Jira-Key Stacked Branches).
|
|
55
55
|
- All PR groups decomposed under this feature share one feature-level delivery go-ahead: no individual group seeks or receives its own Stage 3 sign-off — see `references/implementation-delivery.md` Stage 3.
|
|
56
56
|
|
|
57
|
-
**Screen work — before writing or judging any user-facing screen:** when this task creates or modifies a screen, the `
|
|
57
|
+
**Screen work — before writing or judging any user-facing screen:** when this task creates or modifies a screen, the `designer` dispatch below is mandatory rather than discretionary, carved out of ordinary delegation gating by the Screen Implementation Exception in `references/agent-orchestration.md`. It does not fire when the task touches no screen surface.
|
|
58
58
|
|
|
59
|
-
> **Dispatch: `
|
|
59
|
+
> **Dispatch: `designer`** (role: `designer`, mode: `implement`) — charter `skills/agents/designer/SKILL.md`
|
|
60
60
|
> - scope: the screens, views, components, layouts, styles, and design tokens in this task's UI surface — never the whole repository
|
|
61
61
|
> - permissions: write, scoped to UI-layer files only with a disjoint write set
|
|
62
62
|
> - output: per-element conformance table (element, expected, actual, verdict, severity) plus the UI files written; a missing or unreachable design source is listed as a skipped sensor, never a silent pass
|
|
63
63
|
|
|
64
|
-
> **Dispatch: `
|
|
64
|
+
> **Dispatch: `code-reviewer`** (role: `code-reviewer`, mode: `review`) — charter `skills/agents/code-reviewer/SKILL.md`
|
|
65
65
|
> - trigger: implementation complete, before the verification gate — never optional
|
|
66
66
|
> - scope: the feature's diff surface and its task/AC context
|
|
67
|
-
> - permissions: read-only
|
|
68
67
|
> - inputs: diff, acceptance context, recalled code-quality conventions
|
|
69
68
|
> - sensors: bugs, regressions, missing edge cases, smells introduced by the diff
|
|
70
69
|
> - output: ranked findings, blocking vs advisory; blocking findings become fix items before verification runs
|
|
71
70
|
> - firewall: summarized findings only, never raw diff dumps
|
|
72
71
|
> - memory: suggest-only; main agent persists
|
|
73
72
|
|
|
74
|
-
> **Dispatch: `
|
|
75
|
-
> - trigger: Standard tier or above per the Independent Verification Mandate in `references/verification-ladder.md` — mandatory once every implemented PR group has cleared reviewer fix items; Quick tier substitutes the fallback below
|
|
73
|
+
> **Dispatch: `code-reviewer`** (role: `code-reviewer`, mode: `verify`) — charter `skills/agents/code-reviewer/SKILL.md`
|
|
74
|
+
> - trigger: Standard tier or above per the Independent Verification Mandate in `references/verification-ladder.md` — mandatory once every implemented PR group has cleared `code-reviewer` review fix items; Quick tier substitutes the fallback below
|
|
76
75
|
> - scope: the new code landed across this feature's PR groups from step 12, plus the tests and validation assets those groups touch
|
|
77
76
|
> - inputs: the 1-5 acceptance criteria captured in step 11 (or the referenced spec artifact) as the outcome source, the feature's diff surface across all PR groups, and its test suite
|
|
78
77
|
> - sensors: check the diff and tests against each acceptance criterion; discrimination sensor per `references/discrimination-sensor.md` (mutate the feature's new code, one PR group at a time — covering tests must kill each mutant or that group is not verified)
|
|
@@ -38,11 +38,30 @@ Not for a single requested audit lens — route directly to that lens. Do not ed
|
|
|
38
38
|
- For a broad/full audit, run Correctness, Architecture, Code Quality, Security, and Tests. Run Requirements only when a requirements source is available.
|
|
39
39
|
- Supported lenses: Correctness -> `workflows/bugs/bugs-audit.md`; Architecture -> `workflows/architecture/architecture-audit.md`; Code Quality -> `workflows/code-quality/code-quality-audit.md`; Security -> `workflows/security/security-audit.md`; Requirements -> `workflows/requirements/requirements-audit.md`; Tests -> `workflows/tests/tests-audit.md`.
|
|
40
40
|
- When a broad audit lacks requirements, ask for a source when interactive and not forbidden; otherwise mark Requirements `not evaluated: missing source`. Never report a requirements all-clear without a source.
|
|
41
|
-
7. Establish child contracts and dispatch
|
|
41
|
+
7. Establish child contracts and dispatch one agent per lens through `references/agent-orchestration.md`: `code-reviewer` for Correctness (`lens: bugs`), Architecture, Code Quality, and Security; `product-manager` for Requirements; `test-engineer` for Tests.
|
|
42
42
|
|
|
43
|
-
> **Dispatch: `
|
|
43
|
+
> **Dispatch: `code-reviewer`** (role: `code-reviewer`, mode: `audit`) — charter `skills/agents/code-reviewer/SKILL.md`
|
|
44
44
|
> - trigger: broad/full audit requiring multiple lenses, or explicit multi-lens request
|
|
45
|
-
> - scope: one lens per dispatch against the shared implementation scope packet (Correctness
|
|
45
|
+
> - scope: one lens per dispatch against the shared implementation scope packet (Correctness as `lens: bugs`, Architecture as `lens: architecture`, Code Quality as `lens: code-quality`, Security as `lens: security`)
|
|
46
|
+
> - inputs: exact `projectId`, parent `workflowSessionId`, child workflow, lens name, shared scope packet, resolved files/diff summary, relevant recalled facts, allowed surrounding-code depth, deterministic sensors, context-firewall limits, and output contract
|
|
47
|
+
> - sensors: target-relevant deterministic commands (tests, builds, lint, type checks, static checks, import checks) per lens
|
|
48
|
+
> - output: `Status`, `Scope checked`, `Evidence`, `Findings`, `Verification/Test Fidelity Checklist`, `Risks and skipped checks`, and `Exact next step`
|
|
49
|
+
> - firewall: raw diffs/logs/search output summarized, not returned raw
|
|
50
|
+
> - memory: suggest-only; children must not persist broad project memory unless assigned
|
|
51
|
+
|
|
52
|
+
> **Dispatch: `product-manager`** (role: `product-manager`, mode: `audit`) — charter `skills/agents/product-manager/SKILL.md`
|
|
53
|
+
> - trigger: the Requirements lens is in scope and a requirements source is available
|
|
54
|
+
> - scope: the Requirements lens (`lens: requirements`) against the shared implementation scope packet and the resolved requirements source
|
|
55
|
+
> - permissions: read-only
|
|
56
|
+
> - inputs: exact `projectId`, parent `workflowSessionId`, child workflow, lens name, shared scope packet, resolved files/diff summary, relevant recalled facts, allowed surrounding-code depth, deterministic sensors, context-firewall limits, and output contract
|
|
57
|
+
> - sensors: target-relevant deterministic commands (tests, builds, lint, type checks, static checks, import checks) per lens
|
|
58
|
+
> - output: `Status`, `Scope checked`, `Evidence`, `Findings`, `Verification/Test Fidelity Checklist`, `Risks and skipped checks`, and `Exact next step`
|
|
59
|
+
> - firewall: raw diffs/logs/search output summarized, not returned raw
|
|
60
|
+
> - memory: suggest-only; children must not persist broad project memory unless assigned
|
|
61
|
+
|
|
62
|
+
> **Dispatch: `test-engineer`** (role: `test-engineer`, mode: `audit`) — charter `skills/agents/test-engineer/SKILL.md`
|
|
63
|
+
> - trigger: the Tests lens is in scope
|
|
64
|
+
> - scope: the Tests lens (`lens: tests`) against the shared implementation scope packet
|
|
46
65
|
> - permissions: read-only
|
|
47
66
|
> - inputs: exact `projectId`, parent `workflowSessionId`, child workflow, lens name, shared scope packet, resolved files/diff summary, relevant recalled facts, allowed surrounding-code depth, deterministic sensors, context-firewall limits, and output contract
|
|
48
67
|
> - sensors: target-relevant deterministic commands (tests, builds, lint, type checks, static checks, import checks) per lens
|