@massa-ai/cursor-plugin 1.60.1 → 1.62.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/.cursor-plugin/plugin.json +1 -1
- package/README.md +2 -2
- package/agent-profiles/{heavy/massa-ai-builder.md → balanced/builder.md} +4 -4
- package/agent-profiles/balanced/code-explorer.md +102 -0
- package/agent-profiles/balanced/code-reviewer.md +134 -0
- package/agent-profiles/balanced/designer.md +84 -0
- package/agent-profiles/balanced/judge.md +147 -0
- package/agent-profiles/balanced/product-manager.md +108 -0
- package/agent-profiles/balanced/test-engineer.md +100 -0
- package/agent-profiles/cheap/{massa-ai-builder.md → builder.md} +4 -4
- package/agent-profiles/cheap/code-explorer.md +102 -0
- package/agent-profiles/cheap/code-reviewer.md +134 -0
- package/agent-profiles/cheap/designer.md +84 -0
- package/agent-profiles/cheap/judge.md +147 -0
- package/agent-profiles/cheap/product-manager.md +108 -0
- package/agent-profiles/cheap/test-engineer.md +100 -0
- package/agent-profiles/{balanced/massa-ai-builder.md → heavy/builder.md} +4 -4
- package/agent-profiles/heavy/code-explorer.md +102 -0
- package/agent-profiles/heavy/code-reviewer.md +134 -0
- package/agent-profiles/heavy/designer.md +84 -0
- package/agent-profiles/heavy/judge.md +147 -0
- package/agent-profiles/heavy/product-manager.md +108 -0
- package/agent-profiles/heavy/test-engineer.md +100 -0
- package/agent-profiles/home/{massa-ai-builder.md → builder.md} +4 -4
- package/agent-profiles/home/code-explorer.md +102 -0
- package/agent-profiles/home/code-reviewer.md +134 -0
- package/agent-profiles/home/designer.md +84 -0
- package/agent-profiles/home/judge.md +147 -0
- package/agent-profiles/home/product-manager.md +108 -0
- package/agent-profiles/home/test-engineer.md +100 -0
- package/agent-profiles/work/builder.md +63 -0
- package/agent-profiles/work/code-explorer.md +102 -0
- package/agent-profiles/work/code-reviewer.md +134 -0
- package/agent-profiles/work/designer.md +84 -0
- package/agent-profiles/work/judge.md +147 -0
- package/agent-profiles/work/product-manager.md +108 -0
- package/agent-profiles/work/test-engineer.md +100 -0
- package/agents/builder.md +63 -0
- package/agents/code-explorer.md +102 -0
- package/agents/code-reviewer.md +134 -0
- package/agents/designer.md +84 -0
- package/agents/judge.md +147 -0
- package/agents/product-manager.md +108 -0
- package/agents/test-engineer.md +100 -0
- package/hooks/massa-ai-hook +4 -4
- package/install.sh +110 -33
- package/package.json +1 -1
- package/skills/agents/builder/SKILL.md +3 -5
- package/skills/agents/code-explorer/SKILL.md +104 -0
- package/skills/agents/code-reviewer/SKILL.md +136 -0
- package/skills/agents/designer/SKILL.md +34 -18
- package/skills/agents/judge/SKILL.md +101 -51
- package/skills/agents/product-manager/SKILL.md +110 -0
- package/skills/agents/test-engineer/SKILL.md +57 -23
- package/skills/bootstrap/SKILL.md +4 -5
- package/skills/{adr → create-adr}/SKILL.md +3 -3
- package/skills/{to-prd → create-prd}/SKILL.md +3 -3
- package/skills/{rfc → create-rfc}/SKILL.md +3 -3
- package/skills/{tdd → create-tdd}/SKILL.md +3 -3
- package/skills/{ticket → create-ticket}/SKILL.md +3 -3
- package/skills/massa-ai/SKILL.md +26 -29
- package/skills/massa-ai/references/agent-orchestration.md +69 -66
- package/skills/massa-ai/references/audit-report-io.md +8 -87
- package/skills/massa-ai/references/code-reuse-scan.md +1 -1
- package/skills/massa-ai/references/{adr-authoring.md → create-adr.md} +3 -3
- package/skills/massa-ai/references/{rfc → create-rfc}/discovery-and-sizing.md +1 -1
- package/skills/massa-ai/references/{tdd → create-tdd}/calibrated-examples.md +3 -3
- package/skills/massa-ai/references/{tdd → create-tdd}/discovery-and-sizing.md +1 -1
- package/skills/massa-ai/references/{tdd → create-tdd}/quality-and-lifecycle.md +1 -1
- package/skills/massa-ai/references/{ticket → create-ticket}/intake-and-sources.md +1 -1
- package/skills/massa-ai/references/figma-pre-analysis.md +1 -1
- package/skills/massa-ai/references/furps/analyst-role.md +3 -3
- package/skills/massa-ai/references/furps/checklist.md +2 -2
- package/skills/massa-ai/references/furps/intake.md +7 -7
- package/skills/massa-ai/references/hook-enforcement.md +4 -8
- package/skills/massa-ai/references/implementation-delivery.md +2 -2
- package/skills/massa-ai/references/knowledge-verification-chain.md +0 -1
- package/skills/massa-ai/references/mobile-context.md +2 -5
- package/skills/massa-ai/references/pr-task-fix.md +1 -1
- package/skills/massa-ai/references/spec-driven/sub-agents.md +5 -5
- package/skills/massa-ai/references/spec-driven/validate.md +1 -1
- package/skills/massa-ai/references/subagent-design.md +6 -9
- package/skills/massa-ai/references/synapse-policy.md +2 -2
- package/skills/massa-ai/references/verification-ladder.md +2 -2
- package/skills/massa-ai/scripts/validate_audit_report.ts +3 -8
- package/skills/massa-ai/workflows/architecture/architecture-audit.md +4 -5
- package/skills/massa-ai/workflows/architecture/architecture-fix.md +5 -6
- package/skills/massa-ai/workflows/bugs/bugs-audit.md +2 -3
- package/skills/massa-ai/workflows/bugs/bugs-fix.md +4 -5
- package/skills/massa-ai/workflows/code-quality/code-quality-audit.md +2 -3
- package/skills/massa-ai/workflows/code-quality/code-quality-fix.md +4 -5
- package/skills/massa-ai/workflows/commit.md +3 -3
- package/skills/massa-ai/workflows/{adr.md → create-adr.md} +10 -10
- package/skills/massa-ai/workflows/{to-prd.md → create-prd.md} +4 -4
- package/skills/massa-ai/workflows/{rfc.md → create-rfc.md} +6 -6
- package/skills/massa-ai/workflows/{tdd.md → create-tdd.md} +11 -11
- package/skills/massa-ai/workflows/{ticket.md → create-ticket.md} +5 -5
- package/skills/massa-ai/workflows/debug.md +4 -5
- package/skills/massa-ai/workflows/design.md +2 -2
- package/skills/massa-ai/workflows/exploration.md +2 -2
- package/skills/massa-ai/workflows/feature.md +5 -6
- package/skills/massa-ai/workflows/implementation/implementation-audit.md +22 -3
- package/skills/massa-ai/workflows/implementation/implementation-fix.md +6 -7
- package/skills/massa-ai/workflows/judge-with-debate.md +14 -14
- package/skills/massa-ai/workflows/mobile-figma/mobile-figma-audit.md +2 -2
- package/skills/massa-ai/workflows/mobile-figma/mobile-figma-fix.md +10 -11
- package/skills/massa-ai/workflows/pr-review.md +31 -13
- package/skills/massa-ai/workflows/{discovery.md → product-discovery.md} +12 -12
- package/skills/massa-ai/workflows/refactor.md +4 -5
- package/skills/massa-ai/workflows/refinement/furps-refinement.md +7 -7
- package/skills/massa-ai/workflows/requirements/requirements-audit.md +2 -2
- package/skills/massa-ai/workflows/requirements/requirements-fix.md +5 -6
- package/skills/massa-ai/workflows/security/security-audit.md +2 -3
- package/skills/massa-ai/workflows/security/security-fix.md +3 -4
- package/skills/massa-ai/workflows/spec-driven.md +9 -10
- package/skills/massa-ai/workflows/tests/tests-audit.md +2 -2
- package/skills/massa-ai/workflows/tests/tests-fix.md +16 -6
- package/skills/massa-ai/workflows/the-fool.md +7 -7
- package/skills/{discovery → product-discovery}/SKILL.md +3 -3
- package/agent-profiles/balanced/massa-ai-architecture-specialist.md +0 -62
- package/agent-profiles/balanced/massa-ai-audit-specialist.md +0 -79
- package/agent-profiles/balanced/massa-ai-context-curator.md +0 -64
- package/agent-profiles/balanced/massa-ai-designer.md +0 -66
- package/agent-profiles/balanced/massa-ai-documentation-agent.md +0 -61
- package/agent-profiles/balanced/massa-ai-furps-analyst.md +0 -68
- package/agent-profiles/balanced/massa-ai-investigator.md +0 -65
- package/agent-profiles/balanced/massa-ai-judge.md +0 -95
- package/agent-profiles/balanced/massa-ai-meta-judge.md +0 -83
- package/agent-profiles/balanced/massa-ai-mobile-specialist.md +0 -79
- package/agent-profiles/balanced/massa-ai-navigator.md +0 -72
- package/agent-profiles/balanced/massa-ai-plan-critic.md +0 -87
- package/agent-profiles/balanced/massa-ai-planner.md +0 -62
- package/agent-profiles/balanced/massa-ai-requirements-analyst.md +0 -61
- package/agent-profiles/balanced/massa-ai-reviewer.md +0 -63
- package/agent-profiles/balanced/massa-ai-test-engineer.md +0 -63
- package/agent-profiles/balanced/massa-ai-verification-agent.md +0 -62
- package/agent-profiles/cheap/massa-ai-architecture-specialist.md +0 -62
- package/agent-profiles/cheap/massa-ai-audit-specialist.md +0 -79
- package/agent-profiles/cheap/massa-ai-context-curator.md +0 -64
- package/agent-profiles/cheap/massa-ai-designer.md +0 -66
- package/agent-profiles/cheap/massa-ai-documentation-agent.md +0 -61
- package/agent-profiles/cheap/massa-ai-furps-analyst.md +0 -68
- package/agent-profiles/cheap/massa-ai-investigator.md +0 -65
- package/agent-profiles/cheap/massa-ai-judge.md +0 -95
- package/agent-profiles/cheap/massa-ai-meta-judge.md +0 -83
- package/agent-profiles/cheap/massa-ai-mobile-specialist.md +0 -79
- package/agent-profiles/cheap/massa-ai-navigator.md +0 -72
- package/agent-profiles/cheap/massa-ai-plan-critic.md +0 -87
- package/agent-profiles/cheap/massa-ai-planner.md +0 -62
- package/agent-profiles/cheap/massa-ai-requirements-analyst.md +0 -61
- package/agent-profiles/cheap/massa-ai-reviewer.md +0 -63
- package/agent-profiles/cheap/massa-ai-test-engineer.md +0 -63
- package/agent-profiles/cheap/massa-ai-verification-agent.md +0 -62
- package/agent-profiles/heavy/massa-ai-architecture-specialist.md +0 -62
- package/agent-profiles/heavy/massa-ai-audit-specialist.md +0 -79
- package/agent-profiles/heavy/massa-ai-context-curator.md +0 -64
- package/agent-profiles/heavy/massa-ai-designer.md +0 -66
- package/agent-profiles/heavy/massa-ai-documentation-agent.md +0 -61
- package/agent-profiles/heavy/massa-ai-furps-analyst.md +0 -68
- package/agent-profiles/heavy/massa-ai-investigator.md +0 -65
- package/agent-profiles/heavy/massa-ai-judge.md +0 -95
- package/agent-profiles/heavy/massa-ai-meta-judge.md +0 -83
- package/agent-profiles/heavy/massa-ai-mobile-specialist.md +0 -79
- package/agent-profiles/heavy/massa-ai-navigator.md +0 -72
- package/agent-profiles/heavy/massa-ai-plan-critic.md +0 -87
- package/agent-profiles/heavy/massa-ai-planner.md +0 -62
- package/agent-profiles/heavy/massa-ai-requirements-analyst.md +0 -61
- package/agent-profiles/heavy/massa-ai-reviewer.md +0 -63
- package/agent-profiles/heavy/massa-ai-test-engineer.md +0 -63
- package/agent-profiles/heavy/massa-ai-verification-agent.md +0 -62
- package/agent-profiles/home/massa-ai-architecture-specialist.md +0 -62
- package/agent-profiles/home/massa-ai-audit-specialist.md +0 -79
- package/agent-profiles/home/massa-ai-context-curator.md +0 -64
- package/agent-profiles/home/massa-ai-designer.md +0 -66
- package/agent-profiles/home/massa-ai-documentation-agent.md +0 -61
- package/agent-profiles/home/massa-ai-furps-analyst.md +0 -68
- package/agent-profiles/home/massa-ai-investigator.md +0 -65
- package/agent-profiles/home/massa-ai-judge.md +0 -95
- package/agent-profiles/home/massa-ai-meta-judge.md +0 -83
- package/agent-profiles/home/massa-ai-mobile-specialist.md +0 -79
- package/agent-profiles/home/massa-ai-navigator.md +0 -72
- package/agent-profiles/home/massa-ai-plan-critic.md +0 -87
- package/agent-profiles/home/massa-ai-planner.md +0 -62
- package/agent-profiles/home/massa-ai-requirements-analyst.md +0 -61
- package/agent-profiles/home/massa-ai-reviewer.md +0 -63
- package/agent-profiles/home/massa-ai-test-engineer.md +0 -63
- package/agent-profiles/home/massa-ai-verification-agent.md +0 -62
- package/agent-profiles/work/massa-ai-architecture-specialist.md +0 -62
- package/agent-profiles/work/massa-ai-audit-specialist.md +0 -79
- package/agent-profiles/work/massa-ai-builder.md +0 -63
- package/agent-profiles/work/massa-ai-context-curator.md +0 -64
- package/agent-profiles/work/massa-ai-designer.md +0 -66
- package/agent-profiles/work/massa-ai-documentation-agent.md +0 -61
- package/agent-profiles/work/massa-ai-furps-analyst.md +0 -68
- package/agent-profiles/work/massa-ai-investigator.md +0 -65
- package/agent-profiles/work/massa-ai-judge.md +0 -95
- package/agent-profiles/work/massa-ai-meta-judge.md +0 -83
- package/agent-profiles/work/massa-ai-mobile-specialist.md +0 -79
- package/agent-profiles/work/massa-ai-navigator.md +0 -72
- package/agent-profiles/work/massa-ai-plan-critic.md +0 -87
- package/agent-profiles/work/massa-ai-planner.md +0 -62
- package/agent-profiles/work/massa-ai-requirements-analyst.md +0 -61
- package/agent-profiles/work/massa-ai-reviewer.md +0 -63
- package/agent-profiles/work/massa-ai-test-engineer.md +0 -63
- package/agent-profiles/work/massa-ai-verification-agent.md +0 -62
- package/agents/massa-ai-architecture-specialist.md +0 -62
- package/agents/massa-ai-audit-specialist.md +0 -79
- package/agents/massa-ai-builder.md +0 -63
- package/agents/massa-ai-context-curator.md +0 -64
- package/agents/massa-ai-designer.md +0 -66
- package/agents/massa-ai-documentation-agent.md +0 -61
- package/agents/massa-ai-furps-analyst.md +0 -68
- package/agents/massa-ai-investigator.md +0 -65
- package/agents/massa-ai-judge.md +0 -95
- package/agents/massa-ai-meta-judge.md +0 -83
- package/agents/massa-ai-mobile-specialist.md +0 -79
- package/agents/massa-ai-navigator.md +0 -72
- package/agents/massa-ai-plan-critic.md +0 -87
- package/agents/massa-ai-planner.md +0 -62
- package/agents/massa-ai-requirements-analyst.md +0 -61
- package/agents/massa-ai-reviewer.md +0 -63
- package/agents/massa-ai-test-engineer.md +0 -63
- package/agents/massa-ai-verification-agent.md +0 -62
- package/skills/agents/architecture-specialist/SKILL.md +0 -67
- package/skills/agents/audit-specialist/SKILL.md +0 -84
- package/skills/agents/context-curator/SKILL.md +0 -69
- package/skills/agents/documentation-agent/SKILL.md +0 -67
- package/skills/agents/furps-analyst/SKILL.md +0 -72
- package/skills/agents/investigator/SKILL.md +0 -70
- package/skills/agents/meta-judge/SKILL.md +0 -87
- package/skills/agents/mobile-specialist/SKILL.md +0 -84
- package/skills/agents/navigator/SKILL.md +0 -77
- package/skills/agents/plan-critic/SKILL.md +0 -91
- package/skills/agents/planner/SKILL.md +0 -67
- package/skills/agents/requirements-analyst/SKILL.md +0 -66
- package/skills/agents/reviewer/SKILL.md +0 -68
- package/skills/agents/verification-agent/SKILL.md +0 -67
- package/skills/general/SKILL.md +0 -14
- package/skills/maestro/SKILL.md +0 -14
- package/skills/maestro-audit/SKILL.md +0 -14
- package/skills/maestro-fix/SKILL.md +0 -14
- package/skills/massa-ai/personas/README.md +0 -35
- package/skills/massa-ai/personas/ai-native-nodejs-cli-architect.md +0 -47
- package/skills/massa-ai/personas/catalog.json +0 -7
- package/skills/massa-ai/personas/context-skill-harness-engineer-architect.md +0 -47
- package/skills/massa-ai/personas/product-manager.md +0 -65
- package/skills/massa-ai/personas/senior-mobile-engineer.md +0 -46
- package/skills/massa-ai/personas/senior-mobile-qa-automation-engineer.md +0 -51
- package/skills/massa-ai/personas/signals/ai-native-nodejs-cli-architect.json +0 -20
- package/skills/massa-ai/personas/signals/context-skill-harness-engineer-architect.json +0 -20
- package/skills/massa-ai/personas/signals/product-manager.json +0 -21
- package/skills/massa-ai/personas/signals/senior-mobile-engineer.json +0 -18
- package/skills/massa-ai/personas/signals/senior-mobile-qa-automation-engineer.json +0 -18
- package/skills/massa-ai/references/maestro/artifacts-reports.md +0 -69
- package/skills/massa-ai/references/maestro/cli-device.md +0 -65
- package/skills/massa-ai/references/maestro/cloud.md +0 -69
- package/skills/massa-ai/references/maestro/config-env-output.md +0 -76
- package/skills/massa-ai/references/maestro/fact-ledger.md +0 -73
- package/skills/massa-ai/references/maestro/js-scripting.md +0 -70
- package/skills/massa-ai/references/maestro/mcp.md +0 -59
- package/skills/massa-ai/references/maestro/patterns.md +0 -102
- package/skills/massa-ai/references/maestro/selectors.md +0 -91
- package/skills/massa-ai/references/maestro/workspace-execution.md +0 -81
- package/skills/massa-ai/references/maestro/yaml-commands.md +0 -203
- package/skills/massa-ai/references/maestro.md +0 -31
- package/skills/massa-ai/workflows/general.md +0 -88
- package/skills/massa-ai/workflows/maestro/maestro-audit.md +0 -64
- package/skills/massa-ai/workflows/maestro/maestro-fix.md +0 -111
- package/skills/massa-ai/workflows/maestro/maestro.md +0 -80
- package/skills/persona-router/SKILL.md +0 -52
- package/skills/persona-router/references/routing-details.md +0 -98
- /package/skills/massa-ai/references/{rfc → create-rfc}/ATTRIBUTION.md +0 -0
- /package/skills/massa-ai/references/{rfc → create-rfc}/document-contract.md +0 -0
- /package/skills/massa-ai/references/{rfc → create-rfc}/quality-and-lifecycle.md +0 -0
- /package/skills/massa-ai/references/{tdd → create-tdd}/document-contract.md +0 -0
- /package/skills/massa-ai/references/{ticket → create-ticket}/atlassian-fix.md +0 -0
- /package/skills/massa-ai/references/{ticket → create-ticket}/templates-and-quality.md +0 -0
|
@@ -38,11 +38,30 @@ Not for a single requested audit lens — route directly to that lens. Do not ed
|
|
|
38
38
|
- For a broad/full audit, run Correctness, Architecture, Code Quality, Security, and Tests. Run Requirements only when a requirements source is available.
|
|
39
39
|
- Supported lenses: Correctness -> `workflows/bugs/bugs-audit.md`; Architecture -> `workflows/architecture/architecture-audit.md`; Code Quality -> `workflows/code-quality/code-quality-audit.md`; Security -> `workflows/security/security-audit.md`; Requirements -> `workflows/requirements/requirements-audit.md`; Tests -> `workflows/tests/tests-audit.md`.
|
|
40
40
|
- When a broad audit lacks requirements, ask for a source when interactive and not forbidden; otherwise mark Requirements `not evaluated: missing source`. Never report a requirements all-clear without a source.
|
|
41
|
-
7. Establish child contracts and dispatch
|
|
41
|
+
7. Establish child contracts and dispatch one agent per lens through `references/agent-orchestration.md`: `code-reviewer` for Correctness (`lens: bugs`), Architecture, Code Quality, and Security; `product-manager` for Requirements; `test-engineer` for Tests.
|
|
42
42
|
|
|
43
|
-
> **Dispatch: `
|
|
43
|
+
> **Dispatch: `code-reviewer`** (role: `code-reviewer`, mode: `audit`) — charter `skills/agents/code-reviewer/SKILL.md`
|
|
44
44
|
> - trigger: broad/full audit requiring multiple lenses, or explicit multi-lens request
|
|
45
|
-
> - scope: one lens per dispatch against the shared implementation scope packet (Correctness
|
|
45
|
+
> - scope: one lens per dispatch against the shared implementation scope packet (Correctness as `lens: bugs`, Architecture as `lens: architecture`, Code Quality as `lens: code-quality`, Security as `lens: security`)
|
|
46
|
+
> - inputs: exact `projectId`, parent `workflowSessionId`, child workflow, lens name, shared scope packet, resolved files/diff summary, relevant recalled facts, allowed surrounding-code depth, deterministic sensors, context-firewall limits, and output contract
|
|
47
|
+
> - sensors: target-relevant deterministic commands (tests, builds, lint, type checks, static checks, import checks) per lens
|
|
48
|
+
> - output: `Status`, `Scope checked`, `Evidence`, `Findings`, `Verification/Test Fidelity Checklist`, `Risks and skipped checks`, and `Exact next step`
|
|
49
|
+
> - firewall: raw diffs/logs/search output summarized, not returned raw
|
|
50
|
+
> - memory: suggest-only; children must not persist broad project memory unless assigned
|
|
51
|
+
|
|
52
|
+
> **Dispatch: `product-manager`** (role: `product-manager`, mode: `audit`) — charter `skills/agents/product-manager/SKILL.md`
|
|
53
|
+
> - trigger: the Requirements lens is in scope and a requirements source is available
|
|
54
|
+
> - scope: the Requirements lens (`lens: requirements`) against the shared implementation scope packet and the resolved requirements source
|
|
55
|
+
> - permissions: read-only
|
|
56
|
+
> - inputs: exact `projectId`, parent `workflowSessionId`, child workflow, lens name, shared scope packet, resolved files/diff summary, relevant recalled facts, allowed surrounding-code depth, deterministic sensors, context-firewall limits, and output contract
|
|
57
|
+
> - sensors: target-relevant deterministic commands (tests, builds, lint, type checks, static checks, import checks) per lens
|
|
58
|
+
> - output: `Status`, `Scope checked`, `Evidence`, `Findings`, `Verification/Test Fidelity Checklist`, `Risks and skipped checks`, and `Exact next step`
|
|
59
|
+
> - firewall: raw diffs/logs/search output summarized, not returned raw
|
|
60
|
+
> - memory: suggest-only; children must not persist broad project memory unless assigned
|
|
61
|
+
|
|
62
|
+
> **Dispatch: `test-engineer`** (role: `test-engineer`, mode: `audit`) — charter `skills/agents/test-engineer/SKILL.md`
|
|
63
|
+
> - trigger: the Tests lens is in scope
|
|
64
|
+
> - scope: the Tests lens (`lens: tests`) against the shared implementation scope packet
|
|
46
65
|
> - permissions: read-only
|
|
47
66
|
> - inputs: exact `projectId`, parent `workflowSessionId`, child workflow, lens name, shared scope packet, resolved files/diff summary, relevant recalled facts, allowed surrounding-code depth, deterministic sensors, context-firewall limits, and output contract
|
|
48
67
|
> - sensors: target-relevant deterministic commands (tests, builds, lint, type checks, static checks, import checks) per lens
|
|
@@ -32,7 +32,7 @@ Do not execute from chat summaries, inline review comments, remembered findings,
|
|
|
32
32
|
- `references/discrimination-sensor.md` before closing any finding at the tiers the verification-ladder's Independent Verification Mandate names.
|
|
33
33
|
- `references/knowledge-verification-chain.md` when a finding's fix depends on external library/API behavior not already verified this session.
|
|
34
34
|
- `references/brownfield-mapping.md` (Minimum Bar only) for Standard+ findings when recall returns no hit for the target and no gate command is derivable from the report's evidence.
|
|
35
|
-
- `references/agent-orchestration.md` for high-risk findings or disjoint implementation slices; the mandated
|
|
35
|
+
- `references/agent-orchestration.md` for high-risk findings or disjoint implementation slices; the mandated `code-reviewer` `verify` dispatch below is carved out of this trigger by agent-orchestration's Independent Verification Exception and always attempts dispatch at its own tier gate.
|
|
36
36
|
3. `recall` -> load prior implementation audit decisions, known regressions, architecture/security boundaries, accepted exceptions, testing conventions, and reusable verification recipes for the target.
|
|
37
37
|
4. Select the report with an explicit execution focus:
|
|
38
38
|
- Establish report selector, target focus, and optional source-qualified finding IDs before selecting a report.
|
|
@@ -62,14 +62,14 @@ Do not execute from chat summaries, inline review comments, remembered findings,
|
|
|
62
62
|
9. Size each finding with `references/verification-ladder.md`. Quick findings may proceed locally; Standard findings require characterization and an explicit recipe; ambiguous, cross-boundary, migration-heavy, or broad redesign findings pause and route to `spec-driven`.
|
|
63
63
|
10. Orchestrate conservatively. The main agent owns report parsing, scope/freshness, prioritization, questions, memory, and final evidence. Dispatch per `references/agent-orchestration.md`:
|
|
64
64
|
|
|
65
|
-
**Screen work — before writing or judging any user-facing screen:** when this task creates or modifies a screen, the `
|
|
65
|
+
**Screen work — before writing or judging any user-facing screen:** when this task creates or modifies a screen, the `designer` dispatch below is mandatory rather than discretionary, carved out of ordinary delegation gating by the Screen Implementation Exception in `references/agent-orchestration.md`. It does not fire when the task touches no screen surface.
|
|
66
66
|
|
|
67
|
-
> **Dispatch: `
|
|
67
|
+
> **Dispatch: `designer`** (role: `designer`, mode: `implement`) — charter `skills/agents/designer/SKILL.md`
|
|
68
68
|
> - scope: the screens, views, components, layouts, styles, and design tokens in this task's UI surface — never the whole repository
|
|
69
69
|
> - permissions: write, scoped to UI-layer files only with a disjoint write set
|
|
70
70
|
> - output: per-element conformance table (element, expected, actual, verdict, severity) plus the UI files written; a missing or unreachable design source is listed as a skipped sensor, never a silent pass
|
|
71
71
|
|
|
72
|
-
> **Dispatch: `
|
|
72
|
+
> **Dispatch: `builder`** (role: `builder`) — charter `skills/agents/builder/SKILL.md`
|
|
73
73
|
> - trigger: isolated finding with disjoint write set and concrete verification
|
|
74
74
|
> - scope: one isolated implementation finding with a disjoint write set
|
|
75
75
|
> - permissions: write (disjoint write set)
|
|
@@ -81,17 +81,16 @@ Do not execute from chat summaries, inline review comments, remembered findings,
|
|
|
81
81
|
|
|
82
82
|
Never run parallel writers against shared files or contracts.
|
|
83
83
|
|
|
84
|
-
> **Dispatch: `
|
|
84
|
+
> **Dispatch: `code-reviewer`** (role: `code-reviewer`, mode: `review`) — charter `skills/agents/code-reviewer/SKILL.md`
|
|
85
85
|
> - trigger: implementation complete, before the verification gate — never optional
|
|
86
86
|
> - scope: the fix's diff surface and its task/AC context
|
|
87
|
-
> - permissions: read-only
|
|
88
87
|
> - inputs: diff, acceptance context, recalled code-quality conventions
|
|
89
88
|
> - sensors: bugs, regressions, missing edge cases, smells introduced by the diff
|
|
90
89
|
> - output: ranked findings, blocking vs advisory; blocking findings become fix items before verification runs
|
|
91
90
|
> - firewall: summarized findings only, never raw diff dumps
|
|
92
91
|
> - memory: suggest-only; main agent persists
|
|
93
92
|
|
|
94
|
-
> **Dispatch: `
|
|
93
|
+
> **Dispatch: `code-reviewer`** (role: `code-reviewer`, mode: `verify`) — charter `skills/agents/code-reviewer/SKILL.md`
|
|
95
94
|
> - trigger: an `Area/PREFIX-N` finding's closure meets the verification-ladder's Independent Verification Mandate tier gate — Standard+/Spec-driven size or any high/critical-severity finding
|
|
96
95
|
> - scope: the closed `Area/PREFIX-N` finding's fix diff, its source-lens claim, and the validation assets the fix touches
|
|
97
96
|
> - inputs: the source-qualified finding ID, the applied fix diff, the report's Verification Suggestion, and the pending closure-matrix row
|
|
@@ -12,10 +12,10 @@ Use when the user explicitly asks to evaluate an artifact through multi-judge
|
|
|
12
12
|
debate — "judge this", "judge-with-debate", "evaluate with debate", "run the judges on X". The
|
|
13
13
|
user supplies artifact path(s) plus a task description (what the artifact was supposed to
|
|
14
14
|
accomplish) and optionally evaluation context. Standalone, explicit-route workflow: never
|
|
15
|
-
auto-selected by the router for generic review work (use `reviewer`, `*-audit`, or
|
|
16
|
-
`plan-
|
|
15
|
+
auto-selected by the router for generic review work (use `code-reviewer`, `*-audit`, or
|
|
16
|
+
the Plan Challenge `judge` `plan-critique` dispatch for those).
|
|
17
17
|
|
|
18
|
-
The protocol:
|
|
18
|
+
The protocol: one `judge` in `spec-author` mode authors a tailored evaluation specification **once**; three
|
|
19
19
|
independent judges score the artifact against it with quoted evidence; the judges debate their
|
|
20
20
|
disagreements over **up to 3 rounds**; the panel converges on a consensus verdict or reports an
|
|
21
21
|
honest no-consensus. Ported from the NeoLabHQ `judge-with-debate` pattern; this file is the
|
|
@@ -57,7 +57,7 @@ Check whether the host supports **dispatch-time model selection** (a per-dispatc
|
|
|
57
57
|
parameter on the task/subagent tool). This probe runs on every invocation — when a host gains
|
|
58
58
|
the capability, per-slot diversity activates automatically with no harness edit.
|
|
59
59
|
|
|
60
|
-
- Probe positive → request per-slot models at dispatch:
|
|
60
|
+
- Probe positive → request per-slot models at dispatch: spec-author `kimi-k3`, Judge 1
|
|
61
61
|
`deepseek-v4-pro`, Judge 2 `minimax-m3`, Judge 3 `GLM-5.2`.
|
|
62
62
|
- Probe negative (all four hosts today) → dispatch the charter-default artifacts and record the
|
|
63
63
|
unmet per-slot requests. Every fallback is named; if any slot fell back the consensus file and
|
|
@@ -66,12 +66,12 @@ the capability, per-slot diversity activates automatically with no harness edit.
|
|
|
66
66
|
- A pinned-but-unavailable model falls back to the host default for that slot, named loudly in
|
|
67
67
|
the same way.
|
|
68
68
|
|
|
69
|
-
## Step 1 —
|
|
69
|
+
## Step 1 — Spec-author (exactly once)
|
|
70
70
|
|
|
71
|
-
Dispatch `
|
|
71
|
+
Dispatch `judge` in `spec-author` mode (read-only) with the task description, artifact type, context,
|
|
72
72
|
and artifact paths. Model request: `kimi-k3` (see Step 0.5).
|
|
73
73
|
|
|
74
|
-
> **Dispatch: `
|
|
74
|
+
> **Dispatch: `judge`** (role: `judge`, mode: `spec-author`) — charter `skills/agents/judge/SKILL.md`
|
|
75
75
|
> - trigger: judge-with-debate Step 1; runs exactly once per evaluation
|
|
76
76
|
> - scope: the artifact under evaluation (paths supplied), task description, artifact type
|
|
77
77
|
> - permissions: read-only
|
|
@@ -94,23 +94,23 @@ Validate the returned evaluation specification in two stages, in order; a retry
|
|
|
94
94
|
`rubric` with anchors for scores 1, 3, 5, and a `checklist` with ≥1 item. Parseable but
|
|
95
95
|
invalid specs (e.g. `scale.max: 7`) fail here, not at stage 1.
|
|
96
96
|
|
|
97
|
-
On failure: retry the
|
|
98
|
-
stop `Blocked`. The
|
|
97
|
+
On failure: retry the spec-author **once** with the failed stage + check name. Second failure →
|
|
98
|
+
stop `Blocked`. The spec-author runs exactly once per evaluation — never re-run between rounds,
|
|
99
99
|
never edited by the orchestrator; the YAML passes to all judges in all rounds **verbatim**.
|
|
100
100
|
|
|
101
|
-
Feedback: `🤖 [Agent Started]
|
|
101
|
+
Feedback: `🤖 [Agent Started] Judge (spec-author) is authoring the evaluation specification.`
|
|
102
102
|
then `🤖 [Agent Done]` or `🤖 [Agent Blocked]` with the one-line reason.
|
|
103
103
|
|
|
104
104
|
## Step 2 — Independent analysis (3 judges in parallel)
|
|
105
105
|
|
|
106
|
-
Dispatch three `
|
|
106
|
+
Dispatch three `judge` agents in `scorer` mode **in parallel** (round 0), one per judge number, each
|
|
107
107
|
with: the verbatim specification YAML, task description, artifact paths, its own report path,
|
|
108
108
|
`round: 0`, and its model request (Step 0.5). The fixed panel of 3 sits inside the wave cap of
|
|
109
109
|
4 concurrent subagents (`references/agent-orchestration.md`, Orchestrator Working Memory).
|
|
110
110
|
Each judge writes its own `audits/judge/<...> judge-N.md` per the report contract and returns
|
|
111
111
|
the reply block:
|
|
112
112
|
|
|
113
|
-
> **Dispatch: `
|
|
113
|
+
> **Dispatch: `judge`** (role: `judge`, mode: `scorer`) — charter `skills/agents/judge/SKILL.md` — 3 per panel, rounds 0..3
|
|
114
114
|
> - trigger: judge-with-debate Steps 2 and 4; panel of exactly 3, never more
|
|
115
115
|
> - scope: the artifact under evaluation, the verbatim specification YAML, own report path; debate rounds add all three report paths as peer paths and `round: R`
|
|
116
116
|
> - permissions: read-only except appending to its own judge-N report file
|
|
@@ -159,7 +159,7 @@ Step 5. If no consensus and rounds remain → Step 4. If no consensus after roun
|
|
|
159
159
|
|
|
160
160
|
## Step 4 — Debate round (rounds 1..3, max 3)
|
|
161
161
|
|
|
162
|
-
Increment the round. Dispatch three `
|
|
162
|
+
Increment the round. Dispatch three `judge` agents **in parallel** again, each with:
|
|
163
163
|
the verbatim specification YAML (unchanged), task description, artifact paths, its own report
|
|
164
164
|
path, **all three** report paths as peer paths, and `round: R`. Each judge:
|
|
165
165
|
|
|
@@ -198,7 +198,7 @@ did not reach.**
|
|
|
198
198
|
|
|
199
199
|
## Pitfalls (each is a rule, not advice)
|
|
200
200
|
|
|
201
|
-
- Never skip the
|
|
201
|
+
- Never skip the spec-author; never let judges score without the shared specification.
|
|
202
202
|
- Never modify or regenerate the specification between rounds — verbatim, every round.
|
|
203
203
|
- Never let a debate judge create a new report file — append-only `## Debate Round {R}` sections.
|
|
204
204
|
- Never relay reports between judges through the orchestrator — filesystem channel only.
|
|
@@ -58,9 +58,9 @@ Do not edit code. Route direct design implementation to `design`. Not for Flutte
|
|
|
58
58
|
16. Persist only durable token/component mappings, source-set ownership rules, approved accessibility/platform deviations, asset-pipeline rules, or reusable render recipes after Importance Calibration. Use `workflow:mobile-figma-audit` and required tags. Never persist screenshots, hierarchy dumps, raw logs, device IDs, or user data.
|
|
59
59
|
17. Complete `references/evidence-gate.md`. A model visual impression cannot satisfy the gate.
|
|
60
60
|
|
|
61
|
-
**Screen work —
|
|
61
|
+
**Screen work — unconditional in this workflow:** every task here judges a user-facing screen, so the `designer` dispatch below always runs; it is not gated on a screen-work condition (Screen Implementation Exception in `references/agent-orchestration.md`).
|
|
62
62
|
|
|
63
|
-
> **Dispatch: `
|
|
63
|
+
> **Dispatch: `designer`** (role: `designer`, mode: `audit`) — charter `skills/agents/designer/SKILL.md`
|
|
64
64
|
> - scope: the screens, views, components, layouts, styles, and design tokens under audit — never the whole repository, and no edits
|
|
65
65
|
> - permissions: read-only — this workflow is findings-only; the charter permits writes only when explicitly scoped, and its Restrictions win over the packet, so read-only governs
|
|
66
66
|
> - output: per-element conformance table (element, expected, actual, verdict, severity) feeding `MFM-*` findings; a missing or unreachable design source is listed as a skipped sensor, never a silent pass
|
|
@@ -32,7 +32,7 @@ Do not execute from chat summaries, screenshots alone, remembered findings, or a
|
|
|
32
32
|
- `references/audit-scope.md` and `references/codebase-investigation.md` for freshness and current source.
|
|
33
33
|
- `references/verification-ladder.md` before edits.
|
|
34
34
|
- `references/context-firewall.md` before large design/runtime artifacts.
|
|
35
|
-
- `references/agent-orchestration.md` for the tier-gated
|
|
35
|
+
- `references/agent-orchestration.md` for the designer/builder dispatches and the tier-gated `code-reviewer` `verify` dispatch in the fix loop below.
|
|
36
36
|
- `references/discrimination-sensor.md` before closing any finding under the Mandatory Verification Fix Gate — the mobile-Figma token/value instantiation lives in `references/mobile-figma-matcher/core.md`'s Discrimination Sensor for Visual Parity section.
|
|
37
37
|
- `references/knowledge-verification-chain.md` when a selected finding's fix direction depends on platform-API or external-library technique rather than the Figma-defined value.
|
|
38
38
|
- `references/brownfield-mapping.md` (Minimum Bar only — the gate-command packet, `TESTING.md`-equivalent) when recall returns no hit for the target surface/module and no gate command is derivable from the report's evidence, for Standard+ findings; the report's Verification/Test Fidelity Checklist already carries the risk surface, so `CONCERNS.md` is satisfied-by-citation from that checklist rather than derived fresh.
|
|
@@ -58,36 +58,35 @@ Do not execute from chat summaries, screenshots alone, remembered findings, or a
|
|
|
58
58
|
- Keep XML/Compose, UIKit/SwiftUI, and KMP/native interoperability explicit. Do not duplicate one visual rule across layers when an established shared source owns it.
|
|
59
59
|
- Do not weaken screenshot tests, previews, fixtures, assertions, test tags, resource IDs, content descriptions, or Maestro selectors to hide a mismatch.
|
|
60
60
|
- Modify tracked Maestro flows only when the selected finding explicitly identifies the flow as incorrect or missing and the user-approved scope includes that change.
|
|
61
|
-
9. Dispatch per `references/agent-orchestration.md`; the
|
|
61
|
+
9. Dispatch per `references/agent-orchestration.md`; the `code-reviewer` `verify` block below is tier-gated mandatory, not merely discretionary — carved out of ordinary delegation gating by that reference's Independent Verification Exception:
|
|
62
62
|
|
|
63
|
-
**Screen work —
|
|
63
|
+
**Screen work — unconditional in this workflow:** every task here fixes a user-facing screen, so the `designer` dispatch below always runs; it is not gated on a screen-work condition (Screen Implementation Exception in `references/agent-orchestration.md`). `designer` implements every UI-layer `MFM-*` fix; `builder` is dispatched only for an `MFM-*` finding whose fix needs non-UI-layer changes (navigation, data, resource or build wiring), with a write set disjoint from the designer's.
|
|
64
64
|
|
|
65
|
-
> **Dispatch: `
|
|
65
|
+
> **Dispatch: `designer`** (role: `designer`, mode: `implement`) — charter `skills/agents/designer/SKILL.md`
|
|
66
66
|
> - scope: the screens, views, components, layouts, styles, and design tokens in this task's UI surface — never the whole repository
|
|
67
67
|
> - permissions: write, scoped to UI-layer files only with a disjoint write set
|
|
68
68
|
> - output: per-element conformance table (element, expected, actual, verdict, severity) plus the UI files written; a missing or unreachable design source is listed as a skipped sensor, never a silent pass
|
|
69
69
|
|
|
70
|
-
> **Dispatch: `
|
|
71
|
-
> - trigger: a selected `MFM-*` finding
|
|
72
|
-
> - scope: one `MFM-*` finding, or a coherent surface group sharing one KMP root cause, with a disjoint
|
|
73
|
-
> - permissions: write (disjoint write set,
|
|
70
|
+
> **Dispatch: `builder`** (role: `builder`) — charter `skills/agents/builder/SKILL.md`
|
|
71
|
+
> - trigger: a selected `MFM-*` finding whose fix needs non-UI-layer changes (navigation, data, resource or build wiring) — never for a UI-layer fix, which belongs to `designer`
|
|
72
|
+
> - scope: the non-UI-layer part of one `MFM-*` finding, or of a coherent surface group sharing one KMP root cause, with a write set disjoint from the designer's
|
|
73
|
+
> - permissions: write (disjoint write set, non-UI-layer files only)
|
|
74
74
|
> - inputs: the finding's Surface ID, Figma value, resolved token/resource/asset chain, current implementation value, and simplest fix direction
|
|
75
75
|
> - sensors: the remediation matrix's assigned runtime sensor and optional Maestro packet for the surface
|
|
76
76
|
> - output: implementation summary, changed files, commands run, per-surface render evidence
|
|
77
77
|
> - firewall: raw diffs and screenshots summarized
|
|
78
78
|
> - memory: suggest-only; main agent persists reusable token/mapping patterns
|
|
79
79
|
|
|
80
|
-
> **Dispatch: `
|
|
80
|
+
> **Dispatch: `code-reviewer`** (role: `code-reviewer`, mode: `review`) — charter `skills/agents/code-reviewer/SKILL.md`
|
|
81
81
|
> - trigger: implementation complete, before the verification gate — never optional
|
|
82
82
|
> - scope: the fix's diff surface and its task/AC context
|
|
83
|
-
> - permissions: read-only
|
|
84
83
|
> - inputs: diff, acceptance context, recalled code-quality conventions
|
|
85
84
|
> - sensors: bugs, regressions, missing edge cases, smells introduced by the diff
|
|
86
85
|
> - output: ranked findings, blocking vs advisory; blocking findings become fix items before verification runs
|
|
87
86
|
> - firewall: summarized findings only, never raw diff dumps
|
|
88
87
|
> - memory: suggest-only; main agent persists
|
|
89
88
|
|
|
90
|
-
> **Dispatch: `
|
|
89
|
+
> **Dispatch: `code-reviewer`** (role: `code-reviewer`, mode: `verify`) — charter `skills/agents/code-reviewer/SKILL.md`
|
|
91
90
|
> - trigger: mandatory at Standard+/Spec-driven size or high/critical severity per the Independent Verification Mandate in `references/verification-ladder.md`; a Quick-tier finding runs the fallback fresh-eyes self-check below instead
|
|
92
91
|
> - scope: the fixed `MFM-*` finding's surface, resolved token/value, comparison-matrix row, and closure claim
|
|
93
92
|
> - inputs: the finding, the applied fix, the comparison-matrix row, the render sensor used, and validation assets
|
|
@@ -17,7 +17,7 @@ conflict with the base.
|
|
|
17
17
|
Use when the user explicitly asks to review a hosted PR (Pull Request, GitHub) or
|
|
18
18
|
MR (Merge Request, GitLab) — "review PR 128", "review this MR", "check pull request
|
|
19
19
|
42". Explicit route only: never auto-trigger during coding. Local working-tree diff
|
|
20
|
-
review stays with the audit workflows and `
|
|
20
|
+
review stays with the audit workflows and `code-reviewer`; this workflow exists
|
|
21
21
|
to **post findings back to the host**.
|
|
22
22
|
|
|
23
23
|
Load `references/project-context.md` (intake sweep) before the first substantive
|
|
@@ -142,19 +142,28 @@ the severity labels, and the reply contract.
|
|
|
142
142
|
|
|
143
143
|
| # | Dimension | Agent | Packet delta (lens / scope) | Marker `{type}` |
|
|
144
144
|
| --- | --- | --- | --- | --- |
|
|
145
|
-
| 1 | Security | `
|
|
146
|
-
| 2 | Requirements & DoD (Definition of Done) | `
|
|
147
|
-
| 3 | Architecture & conventions | `
|
|
148
|
-
| 4 | Performance | `
|
|
149
|
-
| 5 | Test coverage | `
|
|
150
|
-
| 6 | Regression & hallucination | `
|
|
145
|
+
| 1 | Security | `code-reviewer` | `lens: security` — secrets, authn/authz on new endpoints, injection, unsafe deserialization, PII in logs, permissive CORS, leaking payload fields | `security` |
|
|
146
|
+
| 2 | Requirements & DoD (Definition of Done) | `product-manager` | `mode: audit` — score merged Track A + Track B criteria against the diff, evidence-or-zero: ✅ implemented (`path:line`) / 🟡 partial / ❌ missing; no source ⇒ report "requirements verification skipped" | `requirements` |
|
|
147
|
+
| 3 | Architecture & conventions | `code-reviewer` | `lens: architecture` — extract every explicit rule from the profile's CONVENTIONS/REVIEW_SKILLS docs into a numbered matrix, grade each changed file PASS/VIOLATION/N/A; no docs ⇒ minimal generic boundary sweep, stated | `architecture` |
|
|
148
|
+
| 4 | Performance | `code-reviewer` | `lens: performance` — only issues clearly visible in the diff: N+1 queries, unbounded fetches, per-row lazy I/O, sequential awaits of independent calls, loop-invariant recomputation, unbatched writes | `performance` |
|
|
149
|
+
| 5 | Test coverage | `test-engineer` | `mode: audit` (dedicated tests lens: coverage, regression protection, assertion quality, variation — `tests-audit.md` precedent) — new/changed behavior with no test, wrong level (unit vs integration), placement/naming vs profile TEST row, missing negative case, missing variation beyond the fixture example, assertions that exercise but never assert | `tests` |
|
|
150
|
+
| 6 | Regression & hallucination | `code-reviewer` | `mode: review` — diff review — unrelated deletions, references to symbols absent from the repo, wrong signature/arity, duplicated existing logic, weakened error handling or assertions, leftover TODO/stub, dead code | `regression` |
|
|
151
151
|
|
|
152
152
|
Consolidation check (≥ 5 subagents): recorded in the feature design — rows 4 and 5
|
|
153
153
|
share only the lens label, not a knowledge domain; they stay separate dispatches.
|
|
154
154
|
|
|
155
|
-
> **Dispatch: `
|
|
156
|
-
> - trigger: pr-review Step 2, dimension rows 1
|
|
157
|
-
> - scope: the PR/MR diff and surrounding context for one dimension row; never the whole repository
|
|
155
|
+
> **Dispatch: `code-reviewer`** (role: `code-reviewer`, mode: `audit`) — charter `skills/agents/code-reviewer/SKILL.md`
|
|
156
|
+
> - trigger: pr-review Step 2, dimension rows 1, 3, and 4 (one dispatch per row)
|
|
157
|
+
> - scope: the PR/MR diff and surrounding context for one dimension row; never the whole repository; no host CLI calls, no posting
|
|
158
|
+
> - inputs: exact `projectId`, parent `workflowSessionId`, dimension row (lens + scope), DISCOVERY MAP, PR/MR intent, trimmed diff, existing-comment inventory, severity labels, reply contract
|
|
159
|
+
> - sensors: second-pass sweep — re-read the full trimmed diff, list every file/hunk not commented on, and state per file why it is clean for this dimension before returning
|
|
160
|
+
> - output: structured reply block — findings rows `{path, head-line, severity, marker type, title, body ≤ 6 lines, recommendation}` + exactly one positive highlight + files-swept-clean list; when uncertain a finding is real, withhold it (the source protocol's high-confidence bar, applied qualitatively)
|
|
161
|
+
> - firewall: raw diff/log/search output summarized, never returned raw
|
|
162
|
+
> - memory: suggest-only; the main agent persists durable outcomes
|
|
163
|
+
|
|
164
|
+
> **Dispatch: `product-manager`** (role: `product-manager`, mode: `audit`) — charter `skills/agents/product-manager/SKILL.md`
|
|
165
|
+
> - trigger: pr-review Step 2, dimension row 2 (requirements & DoD)
|
|
166
|
+
> - scope: the PR/MR diff and surrounding context for dimension row 2; never the whole repository
|
|
158
167
|
> - permissions: read-only; no host CLI calls, no posting
|
|
159
168
|
> - inputs: exact `projectId`, parent `workflowSessionId`, dimension row (lens + scope), DISCOVERY MAP, PR/MR intent, trimmed diff, existing-comment inventory, severity labels, reply contract
|
|
160
169
|
> - sensors: second-pass sweep — re-read the full trimmed diff, list every file/hunk not commented on, and state per file why it is clean for this dimension before returning
|
|
@@ -162,10 +171,19 @@ share only the lens label, not a knowledge domain; they stay separate dispatches
|
|
|
162
171
|
> - firewall: raw diff/log/search output summarized, never returned raw
|
|
163
172
|
> - memory: suggest-only; the main agent persists durable outcomes
|
|
164
173
|
|
|
165
|
-
> **Dispatch: `
|
|
166
|
-
> - trigger: pr-review Step 2, dimension row
|
|
167
|
-
> - scope: the
|
|
174
|
+
> **Dispatch: `test-engineer`** (role: `test-engineer`, mode: `audit`) — charter `skills/agents/test-engineer/SKILL.md`
|
|
175
|
+
> - trigger: pr-review Step 2, dimension row 5 (test coverage)
|
|
176
|
+
> - scope: the PR/MR diff and surrounding context for dimension row 5; never the whole repository
|
|
168
177
|
> - permissions: read-only; no host CLI calls, no posting
|
|
178
|
+
> - inputs: exact `projectId`, parent `workflowSessionId`, dimension row (lens + scope), DISCOVERY MAP, PR/MR intent, trimmed diff, existing-comment inventory, severity labels, reply contract
|
|
179
|
+
> - sensors: second-pass sweep — re-read the full trimmed diff, list every file/hunk not commented on, and state per file why it is clean for this dimension before returning
|
|
180
|
+
> - output: structured reply block — findings rows `{path, head-line, severity, marker type, title, body ≤ 6 lines, recommendation}` + exactly one positive highlight + files-swept-clean list; when uncertain a finding is real, withhold it (the source protocol's high-confidence bar, applied qualitatively)
|
|
181
|
+
> - firewall: raw diff/log/search output summarized, never returned raw
|
|
182
|
+
> - memory: suggest-only; the main agent persists durable outcomes
|
|
183
|
+
|
|
184
|
+
> **Dispatch: `code-reviewer`** (role: `code-reviewer`, mode: `review`) — charter `skills/agents/code-reviewer/SKILL.md`
|
|
185
|
+
> - trigger: pr-review Step 2, dimension row 6 (regression & hallucination)
|
|
186
|
+
> - scope: the full PR/MR diff against the repository's real symbol surface; no host CLI calls, no posting
|
|
169
187
|
> - inputs: exact `projectId`, parent `workflowSessionId`, dimension row 6, DISCOVERY MAP, PR/MR intent, full diff, existing-comment inventory, severity labels, reply contract
|
|
170
188
|
> - sensors: verify referenced symbols exist (`search_definitions`/`get_references` when INDEX is fresh, else grep); second-pass sweep as above
|
|
171
189
|
> - output: structured reply block — findings rows tagged `{unrelated-deletion | phantom-reference | wrong-signature | duplicate | weakened-check | dead-code}` + one positive highlight + files-swept-clean list; withhold uncertain findings
|
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
---
|
|
2
|
-
name: discovery
|
|
3
|
-
description: "Product discovery and brainstorming workflow — act as a sharp product thinking partner to explore problem spaces, generate and stress-test ideas, and spar on strategy before anything is spec-ready, ending with a mandatory offer to synthesize the conversation into a PRD via the
|
|
2
|
+
name: product-discovery
|
|
3
|
+
description: "Product discovery and brainstorming workflow — act as a sharp product thinking partner to explore problem spaces, generate and stress-test ideas, and spar on strategy before anything is spec-ready, ending with a mandatory offer to synthesize the conversation into a PRD via the create-prd workflow. Use when the user wants to brainstorm a product problem, idea, opportunity, or direction with no concrete code target. Do NOT use for codebase understanding (exploration), converting a finished discussion into a PRD (create-prd), or any implementation work."
|
|
4
4
|
license: Apache-2.0
|
|
5
5
|
metadata:
|
|
6
6
|
version: "1.0.0"
|
|
@@ -10,7 +10,7 @@ metadata:
|
|
|
10
10
|
|
|
11
11
|
Attribution: adapted from the `product-brainstorming` skill in
|
|
12
12
|
`anthropics/knowledge-work-plugins` (Apache-2.0). massa-ai session/memory
|
|
13
|
-
binding, router integration, and the
|
|
13
|
+
binding, router integration, and the create-prd handoff are additions.
|
|
14
14
|
|
|
15
15
|
Act as a sharp product thinking partner — the experienced PM (Product
|
|
16
16
|
Manager) or design lead who challenges assumptions, asks hard questions, and
|
|
@@ -22,7 +22,7 @@ have reached alone.
|
|
|
22
22
|
This is a read-only conversation workflow: it never mutates the repository
|
|
23
23
|
and writes no `.specs/` artifacts. Its only outputs are the conversation
|
|
24
24
|
itself, durable memories at Capture, and — on explicit acceptance — a routed
|
|
25
|
-
handoff to `
|
|
25
|
+
handoff to `create-prd`.
|
|
26
26
|
|
|
27
27
|
Load `references/project-context.md` (intake sweep) before the first
|
|
28
28
|
substantive read when the conversation touches an existing product or
|
|
@@ -30,7 +30,7 @@ codebase; product context grounds the brainstorm in what exists today.
|
|
|
30
30
|
|
|
31
31
|
## Session And Memory
|
|
32
32
|
|
|
33
|
-
- `workflowSessionId`: `discovery-<entity>` (e.g., `discovery-onboarding-dropoff`),
|
|
33
|
+
- `workflowSessionId`: `product-discovery-<entity>` (e.g., `product-discovery-onboarding-dropoff`),
|
|
34
34
|
stable for the whole conversation.
|
|
35
35
|
- Start with a budgeted `recall` (limit ≤ 3, minImportance ≥ 0.7, types
|
|
36
36
|
`critical`/`decision`/`pattern`): prior product decisions, rejected
|
|
@@ -121,25 +121,25 @@ name the stage transition when it helps the user follow.
|
|
|
121
121
|
At Capture, persist the durable subset via `remember`: chosen directions
|
|
122
122
|
with their why and rejected directions with reasons as `decision`, reusable
|
|
123
123
|
framings or cross-session insights as `pattern` — tagged
|
|
124
|
-
`project:<projectId>`, `session:discovery-<entity>`, `workflow:discovery`,
|
|
124
|
+
`project:<projectId>`, `session:product-discovery-<entity>`, `workflow:product-discovery`,
|
|
125
125
|
`entity:<name>`, and a memory-tier tag. Persist only what transcends the
|
|
126
126
|
session; never fabricate memories to satisfy process. If the server is
|
|
127
127
|
unavailable, the capture summary in conversation is the record.
|
|
128
128
|
|
|
129
|
-
## PRD Handoff (
|
|
129
|
+
## PRD Handoff (create-prd)
|
|
130
130
|
|
|
131
131
|
End every Capture with an explicit offer — this step is mandatory, the PRD
|
|
132
132
|
is not:
|
|
133
133
|
|
|
134
134
|
> "Want me to turn this into a PRD (Product Requirements Document)? I'd
|
|
135
|
-
> synthesize this conversation through the `
|
|
135
|
+
> synthesize this conversation through the `create-prd` workflow — no new
|
|
136
136
|
> interview."
|
|
137
137
|
|
|
138
|
-
- **Accepted** → route to `workflows/
|
|
139
|
-
the explicit request `
|
|
138
|
+
- **Accepted** → route to `workflows/create-prd.md`. The user's acceptance is
|
|
139
|
+
the explicit request `create-prd`'s routing requires. Carry the current
|
|
140
140
|
conversation context — Capture's output (chosen directions, assumptions,
|
|
141
141
|
set-asides) feeds the PRD's problem statement, decisions, and out-of-scope
|
|
142
|
-
sections directly; `
|
|
142
|
+
sections directly; `create-prd` does not re-interview.
|
|
143
143
|
- **Declined** → the capture summary stays in conversation and the durable
|
|
144
144
|
memories from Capture remain the only persistence. Offer nothing else.
|
|
145
145
|
|
|
@@ -200,5 +200,5 @@ Discovery completes at Capture plus the PRD offer. Before claiming the
|
|
|
200
200
|
session complete, apply `references/evidence-gate.md`: the evidence here is
|
|
201
201
|
the capture summary (ideas, assumptions, next steps, set-asides), the memory
|
|
202
202
|
outcome (what was persisted or why persistence was skipped), and the
|
|
203
|
-
recorded PRD-offer disposition (accepted →
|
|
203
|
+
recorded PRD-offer disposition (accepted → create-prd, declined, or
|
|
204
204
|
not-PRD-shaped with the named research gap).
|
|
@@ -61,23 +61,22 @@ Before the first repository mutation, load `references/implementation-delivery.m
|
|
|
61
61
|
- Before PR creation, run `bun skills/massa-ai/scripts/check_specs_delivered.ts <slug> --kind refactor` (`--kind quick` for Quick-sized work) — a non-zero exit blocks Propose. If no code-execution tool is available, run the same checks by reading the artifact (graceful degradation preserved).
|
|
62
62
|
10. Include file-integrity checks when tests, specs, benchmarks, fixtures, or snapshots are validation assets. If verification found a reusable signal (`ac_gap`, `surviving_mutant`, `spec_precision_gap`, `spec_deviation`, `gate_fail`), record it via `references/lessons.md`:
|
|
63
63
|
`bun skills/massa-ai/scripts/lessons.ts --root . add --feature "<slug>" --signal "<signal>" --source "<ref>" --text "<one terse lesson>"`
|
|
64
|
-
11. Use `references/agent-orchestration.md` for isolated implementation slices; the
|
|
64
|
+
11. Use `references/agent-orchestration.md` for isolated implementation slices; the `code-reviewer` `verify` dispatch below is not discretionary at Standard+ sizing or PR-group execution — that reference's Independent Verification Exception makes it a standing requirement, not a per-task judgment call.
|
|
65
65
|
12. At completion, persist (run the scoring rubric from `references/decision-engine.md`):
|
|
66
66
|
- Refactored architectural decisions via `remember` as scored `decision` memories
|
|
67
67
|
- Identified and decoupled anti-patterns via `remember` as scored `pattern` memories
|
|
68
68
|
|
|
69
|
-
> **Dispatch: `
|
|
69
|
+
> **Dispatch: `code-reviewer`** (role: `code-reviewer`, mode: `review`) — charter `skills/agents/code-reviewer/SKILL.md`
|
|
70
70
|
> - trigger: implementation complete, before the verification gate — never optional
|
|
71
71
|
> - scope: the change's diff surface and its task/AC context
|
|
72
|
-
> - permissions: read-only
|
|
73
72
|
> - inputs: diff, acceptance context, recalled code-quality conventions
|
|
74
73
|
> - sensors: bugs, regressions, missing edge cases, smells introduced by the diff
|
|
75
74
|
> - output: ranked findings, blocking vs advisory; blocking findings become fix items before verification runs
|
|
76
75
|
> - firewall: summarized findings only, never raw diff dumps
|
|
77
76
|
> - memory: suggest-only; main agent persists
|
|
78
77
|
|
|
79
|
-
> **Dispatch: `
|
|
80
|
-
> - trigger: Standard+ refactor sizing or any PR-group execution per the Independent Verification Mandate in `references/verification-ladder.md` — mandatory once reviewer fix items are resolved; Quick-sized refactors dispatch only when validation assets were touched, otherwise run the fresh-eyes fallback below and record the skip reason
|
|
78
|
+
> **Dispatch: `code-reviewer`** (role: `code-reviewer`, mode: `verify`) — charter `skills/agents/code-reviewer/SKILL.md`
|
|
79
|
+
> - trigger: Standard+ refactor sizing or any PR-group execution per the Independent Verification Mandate in `references/verification-ladder.md` — mandatory once `code-reviewer` review fix items are resolved; Quick-sized refactors dispatch only when validation assets were touched, otherwise run the fresh-eyes fallback below and record the skip reason
|
|
81
80
|
> - scope: the moved/transformed code across this refactor's PR groups and the characterization tests that must protect it
|
|
82
81
|
> - inputs: the characterization baseline from step 6 (and step 7 for mobile refactors), the diff of moved code per PR group, and the PR-group map from step 9
|
|
83
82
|
> - sensors: confirm the characterization tests still pass against the moved code's preserved behavior; discrimination sensor per `references/discrimination-sensor.md` (mutate the moved code — never new code — in scratch, one PR group at a time; characterization tests must kill each mutant)
|
|
@@ -12,7 +12,7 @@ Findings-only refinement of a Product Requirements Document (PRD) and/or Archite
|
|
|
12
12
|
|
|
13
13
|
Load `references/project-context.md` (intake sweep) before the first substantive read.
|
|
14
14
|
|
|
15
|
-
Not for authoring a new PRD (use `
|
|
15
|
+
Not for authoring a new PRD (use `create-prd` or `spec-driven` Specify), authoring an ADR (use `create-adr`), proposing change (use `create-rfc`), auditing implementation against requirements (use `requirements-audit`), or auditing code/security/architecture. It refines the document itself; it does not edit code.
|
|
16
16
|
|
|
17
17
|
Findings-only: do not edit the PRD/ADR unless the user separately asks.
|
|
18
18
|
|
|
@@ -21,7 +21,7 @@ Findings-only: do not edit the PRD/ADR unless the user separately asks.
|
|
|
21
21
|
- `references/furps/intake.md` before intake and sub-agent dispatch
|
|
22
22
|
- `references/furps/checklist.md` for the per-dimension check items
|
|
23
23
|
- `references/furps/report-contract.md` before writing the report
|
|
24
|
-
- `references/furps/analyst-role.md` and `skills/agents/
|
|
24
|
+
- `references/furps/analyst-role.md` and `skills/agents/product-manager/SKILL.md` before dispatching `product-manager` in `furps` mode
|
|
25
25
|
- `references/agent-orchestration.md` and `references/context-firewall.md` before dispatch
|
|
26
26
|
- `references/audit-report-io.md` before writing the final report
|
|
27
27
|
- `references/synapse-policy.md` when repeated massa-ai searches are expected
|
|
@@ -33,17 +33,17 @@ Findings-only: do not edit the PRD/ADR unless the user separately asks.
|
|
|
33
33
|
- If the source is missing or ambiguous, ask once before proceeding.
|
|
34
34
|
4. The Fool pre-validation (sub-agents, one per mode):
|
|
35
35
|
- Load `workflows/the-fool.md`. Treat the PRD/ADR as the challenged thesis (direct challenge; inherit `projectId`/`workflowSessionId`).
|
|
36
|
-
- Dispatch a
|
|
37
|
-
- Then dispatch a `
|
|
36
|
+
- Dispatch a `judge` sub-agent in `plan-critique` mode (full depth, `fool_mode: evidence_audit`; it writes nothing) with the document packet, DoR, and recalled facts.
|
|
37
|
+
- Then dispatch a `judge` sub-agent in `plan-critique` mode (full depth, `fool_mode: pre_mortem`), passing the `evidence_audit` summary as input.
|
|
38
38
|
- Collect the compact validation: source-confidence gaps, unsourceable claims, and execution-phase failure assumptions.
|
|
39
39
|
- Gate: if `evidence_audit` surfaces critical gaps that block meaningful FURPS analysis, ask the user whether to proceed-with-caveats or pause for document completion. Otherwise attach the Fool summary to the FURPS packets.
|
|
40
40
|
5. FURPS+ dimension analysis (sub-agents, one per dimension, parallel):
|
|
41
|
-
- Dispatch six `
|
|
41
|
+
- Dispatch six `product-manager` sub-agents in `furps` mode: F, U, R, P, S, X (X = FURPS+ Extensions).
|
|
42
42
|
- Each receives its `checklist.md` section, the bounded document packet, the DoR, and the Fool summary.
|
|
43
43
|
- Each returns per check-item status (`covered|partial|missing|unclear`), `FR-<letter>-<N>` findings, and contributions to Open Questions / Suggestions / Insights / Risks / DoR-gaps.
|
|
44
44
|
- Dispatch the six dimensions in waves of at most 4 concurrent analysts (e.g. 4 then 2), per the wave cap in `references/agent-orchestration.md` (Orchestrator Working Memory). Dimension analyses are order-independent, so wave order does not matter. Each gets its own ephemeral Synapse session only if it performs >=2 searches.
|
|
45
45
|
|
|
46
|
-
> **Dispatch: `
|
|
46
|
+
> **Dispatch: `product-manager`** (role: `product-manager`, mode: `furps`) — charter `skills/agents/product-manager/SKILL.md` — 6 dispatches, one per dimension, waves of ≤4
|
|
47
47
|
> - trigger: furps-refinement step 5; one analyst per FURPS+ dimension (F, U, R, P, S, X)
|
|
48
48
|
> - scope: exactly one dimension's `checklist.md` section against the bounded document packet
|
|
49
49
|
> - permissions: read-only
|
|
@@ -84,7 +84,7 @@ User asks: "Refine this PRD against FURPS before we start building."
|
|
|
84
84
|
1. `workflowSessionId=furps-refinement-<entity>`.
|
|
85
85
|
2. Ingest the PRD file; resolve DoR from a linked Confluence page via Atlassian MCP.
|
|
86
86
|
3. Run The Fool (`evidence_audit` then `pre_mortem`); proceed (no critical blocker).
|
|
87
|
-
4. Fan out six `
|
|
87
|
+
4. Fan out six `product-manager` sub-agents in `furps` mode (F, U, R, P, S, X) in parallel.
|
|
88
88
|
5. Synthesize; write `audits/refinement/<date> furps-refinement.md`; summarize in chat.
|
|
89
89
|
|
|
90
90
|
User asks: "Run a FURPS+ analysis on ADR-007."
|
|
@@ -30,9 +30,9 @@ Findings-only: do not edit code unless the user separately asks for fixes.
|
|
|
30
30
|
- Requirements source scope: use provided prompt text, PR description, issue text, task file, spec, RFC, ADR, acceptance criteria, or README section as the expected behavior source.
|
|
31
31
|
- If requirements source is missing after checking the prompt, PR description, task file, spec, issue text, and repo docs, ask for the requirements source before proceeding.
|
|
32
32
|
5. Resolve the selected branch's mechanics (modified files, commit range, codebase area, explicit-files/branch/symbol/feature/whole-repo, or implementation parent scope) per `references/audit-scope.md` (Lens Audit Scope Resolution Procedure, Requirements row of Per-Lens Scope Deltas). Implementation parent scope additionally carries the requirement source from `implementation-audit`.
|
|
33
|
-
6. Investigation pass. Dispatch `
|
|
33
|
+
6. Investigation pass. Dispatch `product-manager` (`audit` mode) per `references/agent-orchestration.md` when the scope justifies an isolated read-only subagent:
|
|
34
34
|
|
|
35
|
-
> **Dispatch: `
|
|
35
|
+
> **Dispatch: `product-manager`** (role: `product-manager`, mode: `audit`) — charter `skills/agents/product-manager/SKILL.md`
|
|
36
36
|
> - trigger: large scope, explicit parallel/subagent request, PR subagent invocation, or independent verification of high-impact finding
|
|
37
37
|
> - scope: the requirements audit target — files, contracts, specs, acceptance criteria
|
|
38
38
|
> - permissions: read-only
|
|
@@ -64,9 +64,9 @@ Not for findings-only requirements review — route to `workflows/requirements/r
|
|
|
64
64
|
- Preserve non-goals and explicit constraints.
|
|
65
65
|
- `references/knowledge-verification-chain.md`'s Step 5 settles technical facts only (library/API behavior), never product intent; a product decision gap still stops here regardless of how the chain resolved.
|
|
66
66
|
- If a finding exposes a product decision gap, stop and ask rather than inventing policy.
|
|
67
|
-
10. Use agent orchestration only when it improves signal, with one carve-out: the
|
|
67
|
+
10. Use agent orchestration only when it improves signal, with one carve-out: the `code-reviewer` `verify` dispatch below is mandatory at its tier gate rather than discretionary, per `references/agent-orchestration.md`'s Independent Verification Exception. Dispatch per `references/agent-orchestration.md`:
|
|
68
68
|
|
|
69
|
-
> **Dispatch: `
|
|
69
|
+
> **Dispatch: `builder`** (role: `builder`) — charter `skills/agents/builder/SKILL.md`
|
|
70
70
|
> - trigger: large/high-risk finding, disjoint implementation slice, or explicit subagent request
|
|
71
71
|
> - scope: one isolated requirements finding with a disjoint write set
|
|
72
72
|
> - permissions: write (disjoint write set)
|
|
@@ -76,17 +76,16 @@ Not for findings-only requirements review — route to `workflows/requirements/r
|
|
|
76
76
|
> - firewall: raw diffs/logs summarized
|
|
77
77
|
> - memory: suggest-only; main agent persists reusable requirements patterns
|
|
78
78
|
|
|
79
|
-
> **Dispatch: `
|
|
79
|
+
> **Dispatch: `code-reviewer`** (role: `code-reviewer`, mode: `review`) — charter `skills/agents/code-reviewer/SKILL.md`
|
|
80
80
|
> - trigger: implementation complete, before the verification gate — never optional
|
|
81
81
|
> - scope: the fix's diff surface and its task/AC context
|
|
82
|
-
> - permissions: read-only
|
|
83
82
|
> - inputs: diff, acceptance context, recalled code-quality conventions
|
|
84
83
|
> - sensors: bugs, regressions, missing edge cases, smells introduced by the diff
|
|
85
84
|
> - output: ranked findings, blocking vs advisory; blocking findings become fix items before verification runs
|
|
86
85
|
> - firewall: summarized findings only, never raw diff dumps
|
|
87
86
|
> - memory: suggest-only; main agent persists
|
|
88
87
|
|
|
89
|
-
> **Dispatch: `
|
|
88
|
+
> **Dispatch: `code-reviewer`** (role: `code-reviewer`, mode: `verify`) — charter `skills/agents/code-reviewer/SKILL.md`
|
|
90
89
|
> - trigger: mandatory at Standard+/Spec-driven REQ-fix size or high/critical requirement severity, per the Independent Verification Mandate tier gate in `references/verification-ladder.md`'s Mandatory Verification Fix Gate; a Quick-tier REQ finding takes the fallback below instead
|
|
91
90
|
> - scope: the closed REQ row's Requirement Source alignment, acceptance evidence, and report claim closure
|
|
92
91
|
> - inputs: the finding, its Requirement Source and Requirement ID or Quote, the applied fix, the verification suggestion, and validation assets
|
|
@@ -101,7 +100,7 @@ Not for findings-only requirements review — route to `workflows/requirements/r
|
|
|
101
100
|
- If verification found a reusable signal (`ac_gap`, `surviving_mutant`, `spec_precision_gap`, `spec_deviation`, `gate_fail`), record it via `references/lessons.md`:
|
|
102
101
|
`bun skills/massa-ai/scripts/lessons.ts --root . add --feature "<slug>" --signal "<signal>" --source "<ref>" --text "<one terse lesson>"`
|
|
103
102
|
- Apply the Mandatory Verification Fix Gate from `references/verification-ladder.md`: run the report's Verification Suggestion or an equivalent deterministic command/artifact check for each selected finding or coherent group.
|
|
104
|
-
- Dispatch the
|
|
103
|
+
- Dispatch the `code-reviewer` `verify` block above once a REQ finding reaches Standard+/Spec-driven size or high/critical severity; a Quick-tier finding instead runs the listed fallback self-check — the tier gate decides the hop, never the check itself.
|
|
105
104
|
- A surviving mutant on the discrimination sensor blocks the row: mark the finding's Closure Matrix status `blocked` and log a `surviving_mutant` signal through `references/lessons.md`.
|
|
106
105
|
- `references/verification-ladder.md`'s Bounded Fix→Re-verify Loop caps re-verify cycles per REQ finding at 3; exhausting it also lands `blocked`.
|
|
107
106
|
- A finding cannot be marked `fixed` when a target-relevant command or artifact check exists but was not attempted; if verification cannot run, mark it `blocked`, `deferred`, or `skipped` with an allowed skipped-check reason.
|
|
@@ -29,12 +29,11 @@ Findings-only: do not edit code unless the user separately asks for fixes.
|
|
|
29
29
|
- Apply the Memory Freshness Gate from `references/audit-scope.md`; recalled exceptions are leads, not proof.
|
|
30
30
|
4. Establish the investigation scope: select the scope type and build the shared scope packet per `references/audit-scope.md`, which owns the supported scope types, the ask-when-vague rule, and the packet fields. Carry the packet into the report.
|
|
31
31
|
5. Resolve the selected branch's mechanics (modified files, commit range, codebase area, explicit-files/branch/symbol/feature/whole-repo, or implementation parent scope) per `references/audit-scope.md` (Lens Audit Scope Resolution Procedure, Security row of Per-Lens Scope Deltas).
|
|
32
|
-
6. Investigation pass. Dispatch `
|
|
32
|
+
6. Investigation pass. Dispatch `code-reviewer` (`audit` mode) per `references/agent-orchestration.md` when the scope justifies an isolated read-only subagent:
|
|
33
33
|
|
|
34
|
-
> **Dispatch: `
|
|
34
|
+
> **Dispatch: `code-reviewer`** (role: `code-reviewer`, mode: `audit`) — charter `skills/agents/code-reviewer/SKILL.md`
|
|
35
35
|
> - trigger: large scope, explicit parallel/subagent request, PR subagent invocation, or independent verification of high-impact finding
|
|
36
36
|
> - scope: the security audit target — files, trust boundaries, auth paths, validators
|
|
37
|
-
> - permissions: read-only
|
|
38
37
|
> - inputs: shared scope packet; `lens: security`; recalled security decisions, auth boundaries, validation rules, accepted exceptions
|
|
39
38
|
> - sensors: trace untrusted input -> validation -> authorization -> transformation -> persistence; authn/authz, object ownership, tenant isolation, input validation, secret handling, injection risks
|
|
40
39
|
> - output: findings with security boundary, asset, trigger/exploit path, severity, confidence, evidence, simplest fix direction, verification suggestion
|