@massa-ai/codex-plugin 1.61.0 → 1.62.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/.codex-plugin/plugin.json +1 -1
- package/README.md +1 -1
- package/{agents/massa-ai-builder.toml → agent-profiles/balanced/builder.toml} +3 -4
- package/agent-profiles/balanced/code-explorer.toml +101 -0
- package/agent-profiles/balanced/code-reviewer.toml +133 -0
- package/agent-profiles/balanced/{massa-ai-designer.toml → designer.toml} +34 -17
- package/agent-profiles/balanced/judge.toml +147 -0
- package/agent-profiles/balanced/product-manager.toml +107 -0
- package/agent-profiles/balanced/test-engineer.toml +100 -0
- package/agent-profiles/cheap/{massa-ai-builder.toml → builder.toml} +3 -4
- package/agent-profiles/cheap/code-explorer.toml +101 -0
- package/agent-profiles/cheap/code-reviewer.toml +133 -0
- package/agent-profiles/cheap/{massa-ai-designer.toml → designer.toml} +34 -17
- package/agent-profiles/cheap/judge.toml +147 -0
- package/agent-profiles/cheap/product-manager.toml +107 -0
- package/agent-profiles/cheap/test-engineer.toml +100 -0
- package/agent-profiles/{work/massa-ai-builder.toml → heavy/builder.toml} +3 -4
- package/agent-profiles/heavy/code-explorer.toml +101 -0
- package/agent-profiles/heavy/code-reviewer.toml +133 -0
- package/agent-profiles/{work/massa-ai-designer.toml → heavy/designer.toml} +34 -17
- package/agent-profiles/heavy/judge.toml +147 -0
- package/agent-profiles/heavy/product-manager.toml +107 -0
- package/agent-profiles/heavy/test-engineer.toml +100 -0
- package/agent-profiles/home/{massa-ai-builder.toml → builder.toml} +3 -4
- package/agent-profiles/home/code-explorer.toml +101 -0
- package/agent-profiles/home/code-reviewer.toml +133 -0
- package/{agents/massa-ai-designer.toml → agent-profiles/home/designer.toml} +34 -17
- package/agent-profiles/home/judge.toml +147 -0
- package/agent-profiles/home/product-manager.toml +107 -0
- package/agent-profiles/home/test-engineer.toml +100 -0
- package/agent-profiles/{heavy/massa-ai-builder.toml → work/builder.toml} +3 -4
- package/agent-profiles/work/code-explorer.toml +101 -0
- package/agent-profiles/work/code-reviewer.toml +133 -0
- package/agent-profiles/{heavy/massa-ai-designer.toml → work/designer.toml} +34 -17
- package/agent-profiles/work/judge.toml +147 -0
- package/agent-profiles/work/product-manager.toml +107 -0
- package/agent-profiles/work/test-engineer.toml +100 -0
- package/{agent-profiles/balanced/massa-ai-builder.toml → agents/builder.toml} +3 -4
- package/agents/code-explorer.toml +101 -0
- package/agents/code-reviewer.toml +133 -0
- package/{agent-profiles/home/massa-ai-designer.toml → agents/designer.toml} +34 -17
- package/agents/judge.toml +147 -0
- package/agents/product-manager.toml +107 -0
- package/agents/test-engineer.toml +100 -0
- package/hooks/massa-ai-hook +4 -4
- package/install.sh +98 -24
- package/package.json +1 -1
- package/skills/agents/builder/SKILL.md +3 -4
- package/skills/agents/code-explorer/SKILL.md +104 -0
- package/skills/agents/code-reviewer/SKILL.md +136 -0
- package/skills/agents/designer/SKILL.md +34 -17
- package/skills/agents/judge/SKILL.md +99 -48
- package/skills/agents/product-manager/SKILL.md +110 -0
- package/skills/agents/test-engineer/SKILL.md +57 -22
- package/skills/bootstrap/SKILL.md +4 -5
- package/skills/{adr.md → create-adr.md} +3 -3
- package/skills/{to-prd.md → create-prd.md} +3 -3
- package/skills/{rfc.md → create-rfc.md} +3 -3
- package/skills/{tdd.md → create-tdd.md} +3 -3
- package/skills/{ticket.md → create-ticket.md} +3 -3
- package/skills/massa-ai/SKILL.md +26 -29
- package/skills/massa-ai/references/agent-orchestration.md +62 -58
- package/skills/massa-ai/references/audit-report-io.md +8 -87
- package/skills/massa-ai/references/code-reuse-scan.md +1 -1
- package/skills/massa-ai/references/{adr-authoring.md → create-adr.md} +3 -3
- package/skills/massa-ai/references/{rfc → create-rfc}/discovery-and-sizing.md +1 -1
- package/skills/massa-ai/references/{tdd → create-tdd}/calibrated-examples.md +3 -3
- package/skills/massa-ai/references/{tdd → create-tdd}/discovery-and-sizing.md +1 -1
- package/skills/massa-ai/references/{tdd → create-tdd}/quality-and-lifecycle.md +1 -1
- package/skills/massa-ai/references/{ticket → create-ticket}/intake-and-sources.md +1 -1
- package/skills/massa-ai/references/figma-pre-analysis.md +1 -1
- package/skills/massa-ai/references/furps/analyst-role.md +3 -3
- package/skills/massa-ai/references/furps/checklist.md +2 -2
- package/skills/massa-ai/references/furps/intake.md +7 -7
- package/skills/massa-ai/references/hook-enforcement.md +4 -8
- package/skills/massa-ai/references/implementation-delivery.md +2 -2
- package/skills/massa-ai/references/knowledge-verification-chain.md +0 -1
- package/skills/massa-ai/references/mobile-context.md +2 -5
- package/skills/massa-ai/references/pr-task-fix.md +1 -1
- package/skills/massa-ai/references/spec-driven/sub-agents.md +3 -3
- package/skills/massa-ai/references/spec-driven/validate.md +1 -1
- package/skills/massa-ai/references/subagent-design.md +6 -9
- package/skills/massa-ai/references/verification-ladder.md +2 -2
- package/skills/massa-ai/scripts/validate_audit_report.ts +3 -8
- package/skills/massa-ai/workflows/architecture/architecture-audit.md +4 -5
- package/skills/massa-ai/workflows/architecture/architecture-fix.md +5 -6
- package/skills/massa-ai/workflows/bugs/bugs-audit.md +2 -3
- package/skills/massa-ai/workflows/bugs/bugs-fix.md +4 -5
- package/skills/massa-ai/workflows/code-quality/code-quality-audit.md +2 -3
- package/skills/massa-ai/workflows/code-quality/code-quality-fix.md +4 -5
- package/skills/massa-ai/workflows/commit.md +3 -3
- package/skills/massa-ai/workflows/{adr.md → create-adr.md} +10 -10
- package/skills/massa-ai/workflows/{to-prd.md → create-prd.md} +4 -4
- package/skills/massa-ai/workflows/{rfc.md → create-rfc.md} +6 -6
- package/skills/massa-ai/workflows/{tdd.md → create-tdd.md} +11 -11
- package/skills/massa-ai/workflows/{ticket.md → create-ticket.md} +5 -5
- package/skills/massa-ai/workflows/debug.md +4 -5
- package/skills/massa-ai/workflows/design.md +2 -2
- package/skills/massa-ai/workflows/exploration.md +2 -2
- package/skills/massa-ai/workflows/feature.md +5 -6
- package/skills/massa-ai/workflows/implementation/implementation-audit.md +22 -3
- package/skills/massa-ai/workflows/implementation/implementation-fix.md +6 -7
- package/skills/massa-ai/workflows/judge-with-debate.md +14 -14
- package/skills/massa-ai/workflows/mobile-figma/mobile-figma-audit.md +2 -2
- package/skills/massa-ai/workflows/mobile-figma/mobile-figma-fix.md +10 -11
- package/skills/massa-ai/workflows/pr-review.md +31 -13
- package/skills/massa-ai/workflows/{discovery.md → product-discovery.md} +12 -12
- package/skills/massa-ai/workflows/refactor.md +4 -5
- package/skills/massa-ai/workflows/refinement/furps-refinement.md +7 -7
- package/skills/massa-ai/workflows/requirements/requirements-audit.md +2 -2
- package/skills/massa-ai/workflows/requirements/requirements-fix.md +5 -6
- package/skills/massa-ai/workflows/security/security-audit.md +2 -3
- package/skills/massa-ai/workflows/security/security-fix.md +3 -4
- package/skills/massa-ai/workflows/spec-driven.md +9 -10
- package/skills/massa-ai/workflows/tests/tests-audit.md +2 -2
- package/skills/massa-ai/workflows/tests/tests-fix.md +16 -6
- package/skills/massa-ai/workflows/the-fool.md +7 -7
- package/skills/{discovery.md → product-discovery.md} +3 -3
- package/agent-profiles/balanced/massa-ai-architecture-specialist.toml +0 -62
- package/agent-profiles/balanced/massa-ai-audit-specialist.toml +0 -79
- package/agent-profiles/balanced/massa-ai-context-curator.toml +0 -64
- package/agent-profiles/balanced/massa-ai-documentation-agent.toml +0 -62
- package/agent-profiles/balanced/massa-ai-furps-analyst.toml +0 -68
- package/agent-profiles/balanced/massa-ai-investigator.toml +0 -65
- package/agent-profiles/balanced/massa-ai-judge.toml +0 -96
- package/agent-profiles/balanced/massa-ai-meta-judge.toml +0 -84
- package/agent-profiles/balanced/massa-ai-mobile-specialist.toml +0 -79
- package/agent-profiles/balanced/massa-ai-navigator.toml +0 -72
- package/agent-profiles/balanced/massa-ai-plan-critic.toml +0 -87
- package/agent-profiles/balanced/massa-ai-planner.toml +0 -62
- package/agent-profiles/balanced/massa-ai-requirements-analyst.toml +0 -61
- package/agent-profiles/balanced/massa-ai-reviewer.toml +0 -63
- package/agent-profiles/balanced/massa-ai-test-engineer.toml +0 -64
- package/agent-profiles/balanced/massa-ai-verification-agent.toml +0 -62
- package/agent-profiles/cheap/massa-ai-architecture-specialist.toml +0 -62
- package/agent-profiles/cheap/massa-ai-audit-specialist.toml +0 -79
- package/agent-profiles/cheap/massa-ai-context-curator.toml +0 -64
- package/agent-profiles/cheap/massa-ai-documentation-agent.toml +0 -62
- package/agent-profiles/cheap/massa-ai-furps-analyst.toml +0 -68
- package/agent-profiles/cheap/massa-ai-investigator.toml +0 -65
- package/agent-profiles/cheap/massa-ai-judge.toml +0 -96
- package/agent-profiles/cheap/massa-ai-meta-judge.toml +0 -84
- package/agent-profiles/cheap/massa-ai-mobile-specialist.toml +0 -79
- package/agent-profiles/cheap/massa-ai-navigator.toml +0 -72
- package/agent-profiles/cheap/massa-ai-plan-critic.toml +0 -87
- package/agent-profiles/cheap/massa-ai-planner.toml +0 -62
- package/agent-profiles/cheap/massa-ai-requirements-analyst.toml +0 -61
- package/agent-profiles/cheap/massa-ai-reviewer.toml +0 -63
- package/agent-profiles/cheap/massa-ai-test-engineer.toml +0 -64
- package/agent-profiles/cheap/massa-ai-verification-agent.toml +0 -62
- package/agent-profiles/heavy/massa-ai-architecture-specialist.toml +0 -62
- package/agent-profiles/heavy/massa-ai-audit-specialist.toml +0 -79
- package/agent-profiles/heavy/massa-ai-context-curator.toml +0 -64
- package/agent-profiles/heavy/massa-ai-documentation-agent.toml +0 -62
- package/agent-profiles/heavy/massa-ai-furps-analyst.toml +0 -68
- package/agent-profiles/heavy/massa-ai-investigator.toml +0 -65
- package/agent-profiles/heavy/massa-ai-judge.toml +0 -96
- package/agent-profiles/heavy/massa-ai-meta-judge.toml +0 -84
- package/agent-profiles/heavy/massa-ai-mobile-specialist.toml +0 -79
- package/agent-profiles/heavy/massa-ai-navigator.toml +0 -72
- package/agent-profiles/heavy/massa-ai-plan-critic.toml +0 -87
- package/agent-profiles/heavy/massa-ai-planner.toml +0 -62
- package/agent-profiles/heavy/massa-ai-requirements-analyst.toml +0 -61
- package/agent-profiles/heavy/massa-ai-reviewer.toml +0 -63
- package/agent-profiles/heavy/massa-ai-test-engineer.toml +0 -64
- package/agent-profiles/heavy/massa-ai-verification-agent.toml +0 -62
- package/agent-profiles/home/massa-ai-architecture-specialist.toml +0 -62
- package/agent-profiles/home/massa-ai-audit-specialist.toml +0 -79
- package/agent-profiles/home/massa-ai-context-curator.toml +0 -64
- package/agent-profiles/home/massa-ai-documentation-agent.toml +0 -62
- package/agent-profiles/home/massa-ai-furps-analyst.toml +0 -68
- package/agent-profiles/home/massa-ai-investigator.toml +0 -65
- package/agent-profiles/home/massa-ai-judge.toml +0 -96
- package/agent-profiles/home/massa-ai-meta-judge.toml +0 -84
- package/agent-profiles/home/massa-ai-mobile-specialist.toml +0 -79
- package/agent-profiles/home/massa-ai-navigator.toml +0 -72
- package/agent-profiles/home/massa-ai-plan-critic.toml +0 -87
- package/agent-profiles/home/massa-ai-planner.toml +0 -62
- package/agent-profiles/home/massa-ai-requirements-analyst.toml +0 -61
- package/agent-profiles/home/massa-ai-reviewer.toml +0 -63
- package/agent-profiles/home/massa-ai-test-engineer.toml +0 -64
- package/agent-profiles/home/massa-ai-verification-agent.toml +0 -62
- package/agent-profiles/work/massa-ai-architecture-specialist.toml +0 -62
- package/agent-profiles/work/massa-ai-audit-specialist.toml +0 -79
- package/agent-profiles/work/massa-ai-context-curator.toml +0 -64
- package/agent-profiles/work/massa-ai-documentation-agent.toml +0 -62
- package/agent-profiles/work/massa-ai-furps-analyst.toml +0 -68
- package/agent-profiles/work/massa-ai-investigator.toml +0 -65
- package/agent-profiles/work/massa-ai-judge.toml +0 -96
- package/agent-profiles/work/massa-ai-meta-judge.toml +0 -84
- package/agent-profiles/work/massa-ai-mobile-specialist.toml +0 -79
- package/agent-profiles/work/massa-ai-navigator.toml +0 -72
- package/agent-profiles/work/massa-ai-plan-critic.toml +0 -87
- package/agent-profiles/work/massa-ai-planner.toml +0 -62
- package/agent-profiles/work/massa-ai-requirements-analyst.toml +0 -61
- package/agent-profiles/work/massa-ai-reviewer.toml +0 -63
- package/agent-profiles/work/massa-ai-test-engineer.toml +0 -64
- package/agent-profiles/work/massa-ai-verification-agent.toml +0 -62
- package/agents/massa-ai-architecture-specialist.toml +0 -62
- package/agents/massa-ai-audit-specialist.toml +0 -79
- package/agents/massa-ai-context-curator.toml +0 -64
- package/agents/massa-ai-documentation-agent.toml +0 -62
- package/agents/massa-ai-furps-analyst.toml +0 -68
- package/agents/massa-ai-investigator.toml +0 -65
- package/agents/massa-ai-judge.toml +0 -96
- package/agents/massa-ai-meta-judge.toml +0 -84
- package/agents/massa-ai-mobile-specialist.toml +0 -79
- package/agents/massa-ai-navigator.toml +0 -72
- package/agents/massa-ai-plan-critic.toml +0 -87
- package/agents/massa-ai-planner.toml +0 -62
- package/agents/massa-ai-requirements-analyst.toml +0 -61
- package/agents/massa-ai-reviewer.toml +0 -63
- package/agents/massa-ai-test-engineer.toml +0 -64
- package/agents/massa-ai-verification-agent.toml +0 -62
- package/skills/agents/architecture-specialist/SKILL.md +0 -66
- package/skills/agents/audit-specialist/SKILL.md +0 -83
- package/skills/agents/context-curator/SKILL.md +0 -68
- package/skills/agents/documentation-agent/SKILL.md +0 -66
- package/skills/agents/furps-analyst/SKILL.md +0 -71
- package/skills/agents/investigator/SKILL.md +0 -69
- package/skills/agents/meta-judge/SKILL.md +0 -87
- package/skills/agents/mobile-specialist/SKILL.md +0 -83
- package/skills/agents/navigator/SKILL.md +0 -76
- package/skills/agents/plan-critic/SKILL.md +0 -90
- package/skills/agents/planner/SKILL.md +0 -66
- package/skills/agents/requirements-analyst/SKILL.md +0 -65
- package/skills/agents/reviewer/SKILL.md +0 -67
- package/skills/agents/verification-agent/SKILL.md +0 -66
- package/skills/general.md +0 -14
- package/skills/maestro-audit.md +0 -14
- package/skills/maestro-fix.md +0 -14
- package/skills/maestro.md +0 -14
- package/skills/massa-ai/personas/README.md +0 -35
- package/skills/massa-ai/personas/ai-native-nodejs-cli-architect.md +0 -47
- package/skills/massa-ai/personas/catalog.json +0 -7
- package/skills/massa-ai/personas/context-skill-harness-engineer-architect.md +0 -47
- package/skills/massa-ai/personas/product-manager.md +0 -65
- package/skills/massa-ai/personas/senior-mobile-engineer.md +0 -46
- package/skills/massa-ai/personas/senior-mobile-qa-automation-engineer.md +0 -51
- package/skills/massa-ai/personas/signals/ai-native-nodejs-cli-architect.json +0 -20
- package/skills/massa-ai/personas/signals/context-skill-harness-engineer-architect.json +0 -20
- package/skills/massa-ai/personas/signals/product-manager.json +0 -21
- package/skills/massa-ai/personas/signals/senior-mobile-engineer.json +0 -18
- package/skills/massa-ai/personas/signals/senior-mobile-qa-automation-engineer.json +0 -18
- package/skills/massa-ai/references/maestro/artifacts-reports.md +0 -69
- package/skills/massa-ai/references/maestro/cli-device.md +0 -65
- package/skills/massa-ai/references/maestro/cloud.md +0 -69
- package/skills/massa-ai/references/maestro/config-env-output.md +0 -76
- package/skills/massa-ai/references/maestro/fact-ledger.md +0 -73
- package/skills/massa-ai/references/maestro/js-scripting.md +0 -70
- package/skills/massa-ai/references/maestro/mcp.md +0 -59
- package/skills/massa-ai/references/maestro/patterns.md +0 -102
- package/skills/massa-ai/references/maestro/selectors.md +0 -91
- package/skills/massa-ai/references/maestro/workspace-execution.md +0 -81
- package/skills/massa-ai/references/maestro/yaml-commands.md +0 -203
- package/skills/massa-ai/references/maestro.md +0 -31
- package/skills/massa-ai/workflows/general.md +0 -88
- package/skills/massa-ai/workflows/maestro/maestro-audit.md +0 -64
- package/skills/massa-ai/workflows/maestro/maestro-fix.md +0 -111
- package/skills/massa-ai/workflows/maestro/maestro.md +0 -80
- package/skills/persona-router/SKILL.md +0 -52
- package/skills/persona-router/references/routing-details.md +0 -98
- /package/skills/massa-ai/references/{rfc → create-rfc}/ATTRIBUTION.md +0 -0
- /package/skills/massa-ai/references/{rfc → create-rfc}/document-contract.md +0 -0
- /package/skills/massa-ai/references/{rfc → create-rfc}/quality-and-lifecycle.md +0 -0
- /package/skills/massa-ai/references/{tdd → create-tdd}/document-contract.md +0 -0
- /package/skills/massa-ai/references/{ticket → create-ticket}/atlassian-fix.md +0 -0
- /package/skills/massa-ai/references/{ticket → create-ticket}/templates-and-quality.md +0 -0
|
@@ -1,5 +1,5 @@
|
|
|
1
1
|
---
|
|
2
|
-
name: rfc
|
|
2
|
+
name: create-rfc
|
|
3
3
|
description: "Use this workflow when a significant technical, process, product, vendor, tool, or policy decision is still open and stakeholders need a structured proposal before committing."
|
|
4
4
|
license: MIT
|
|
5
5
|
metadata:
|
|
@@ -8,16 +8,16 @@ metadata:
|
|
|
8
8
|
|
|
9
9
|
### RFC (Request for Comments)
|
|
10
10
|
|
|
11
|
-
Use when a significant technical, process, product, vendor, tool, or policy decision is still open and stakeholders need a structured proposal before committing to a direction. Route a finalized architecture decision to `workflows/adr.md`, settled implementation design to `workflows/tdd.md`, and broad requirements-through-delivery work to `workflows/spec-driven.md`.
|
|
11
|
+
Use when a significant technical, process, product, vendor, tool, or policy decision is still open and stakeholders need a structured proposal before committing to a direction. Route a finalized architecture decision to `workflows/create-adr.md`, settled implementation design to `workflows/create-tdd.md`, and broad requirements-through-delivery work to `workflows/spec-driven.md`.
|
|
12
12
|
|
|
13
13
|
Load `references/project-context.md` (intake sweep) before the first substantive read.
|
|
14
14
|
|
|
15
15
|
## Workflow
|
|
16
16
|
|
|
17
|
-
1. Resolve or reuse `projectId` and `workflowSessionId=rfc-[entity]`.
|
|
17
|
+
1. Resolve or reuse `projectId` and `workflowSessionId=create-rfc-[entity]`.
|
|
18
18
|
2. Establish evidence before asking questions:
|
|
19
19
|
- `recall` relevant constraints, existing architecture or process, related proposals, prior attempts, rejected options, stakeholder expectations, and verification patterns.
|
|
20
|
-
- Load `references/rfc/discovery-and-sizing.md`.
|
|
20
|
+
- Load `references/create-rfc/discovery-and-sizing.md`.
|
|
21
21
|
- Inspect current source, project instructions, existing RFC conventions, decision records, tickets, and supplied research. Current source and approved project artifacts override stale memory.
|
|
22
22
|
- When supplied Figma links, nodes, desktop selections, or screenshots materially affect mobile UI options, use `workflows/design.md` as optional child context for visual feasibility only; the RFC still owns option comparison and recommendation. Screenshots are context-only unless paired with structured Figma evidence.
|
|
23
23
|
- Load `references/synapse-policy.md` when two or more related searches are expected and `references/context-firewall.md` before broad or verbose source inspection.
|
|
@@ -27,7 +27,7 @@ Load `references/project-context.md` (intake sweep) before the first substantive
|
|
|
27
27
|
- Ask concise conversational questions when `AskQuestion` is unavailable.
|
|
28
28
|
- Require title, background, full RACI roles, impact, urgency or due date, assumptions with confidence and invalidation triggers, weighted decision criteria, at least two options, and a recommendation.
|
|
29
29
|
- Reuse supplied or discoverable facts; do not ask for information already present.
|
|
30
|
-
5. Load `references/rfc/document-contract.md` and draft the RFC in the same language as the user's request.
|
|
30
|
+
5. Load `references/create-rfc/document-contract.md` and draft the RFC in the same language as the user's request.
|
|
31
31
|
- Preserve the 7 mandatory and 4 recommended sections, numeric criterion weights, honest option comparison, generated cost and effort estimates, status quo consideration, action items, and outcome placeholder.
|
|
32
32
|
- Tailor conditional concerns to technical/architecture, process/workflow, product/feature, vendor/tool, or policy/compliance proposals.
|
|
33
33
|
- Mark generated estimates as estimates and state their assumptions when exact project data is unavailable.
|
|
@@ -35,7 +35,7 @@ Load `references/project-context.md` (intake sweep) before the first substantive
|
|
|
35
35
|
- If the target exists, update it only when the user explicitly requested an update; otherwise ask before overwriting.
|
|
36
36
|
- When file mutation is unavailable or the user requested plan-only output, present the complete draft and intended path without writing.
|
|
37
37
|
7. Run the full configured Plan Challenge Gate. Preserve all required RFC fields while revising valid critical or high findings, especially one-sided options, unsupported claims, hidden assumptions, status quo bias, weak cost estimates, and criteria chosen to justify a predetermined conclusion.
|
|
38
|
-
8. Load `references/rfc/quality-and-lifecycle.md`, validate every required behavior, and resolve blocking gaps. Keep unresolved facts explicit instead of silently removing mandatory fields.
|
|
38
|
+
8. Load `references/create-rfc/quality-and-lifecycle.md`, validate every required behavior, and resolve blocking gaps. Keep unresolved facts explicit instead of silently removing mandatory fields.
|
|
39
39
|
9. Save the proposal with status `NOT STARTED` or `IN PROGRESS`. Set `COMPLETE` and fill the Outcome section only when an explicit human decision or authoritative project record is available.
|
|
40
40
|
10. Persist proposal state after recall, deduplication, and scoring:
|
|
41
41
|
- Pending or in-review proposal: scored `conversation` memory with `memory:working`.
|
|
@@ -1,5 +1,5 @@
|
|
|
1
1
|
---
|
|
2
|
-
name: tdd
|
|
2
|
+
name: create-tdd
|
|
3
3
|
description: "Use this workflow to write a Technical Design Document once one product direction is selected and no unresolved API, data, security, or rollout decision blocks implementation."
|
|
4
4
|
license: MIT
|
|
5
5
|
metadata:
|
|
@@ -8,25 +8,25 @@ metadata:
|
|
|
8
8
|
|
|
9
9
|
### TDD (Technical Design Document)
|
|
10
10
|
|
|
11
|
-
Use when the readiness checklist is true: one product direction is selected, a named requirements source exists, and no unresolved API, data, security/privacy, migration, rollout, or public compatibility decision blocks implementation design. Route unresolved proposals or competing directions to `workflows/rfc.md`, isolated finalized architecture decisions to `workflows/adr.md`, and broad requirements-to-delivery work to `workflows/spec-driven.md`.
|
|
11
|
+
Use when the readiness checklist is true: one product direction is selected, a named requirements source exists, and no unresolved API, data, security/privacy, migration, rollout, or public compatibility decision blocks implementation design. Route unresolved proposals or competing directions to `workflows/create-rfc.md`, isolated finalized architecture decisions to `workflows/create-adr.md`, and broad requirements-to-delivery work to `workflows/spec-driven.md`.
|
|
12
12
|
|
|
13
13
|
Load `references/project-context.md` (intake sweep) before the first substantive read.
|
|
14
14
|
|
|
15
15
|
## Workflow
|
|
16
16
|
|
|
17
|
-
1. Resolve or reuse `projectId` and `workflowSessionId=tdd-[entity]`.
|
|
17
|
+
1. Resolve or reuse `projectId` and `workflowSessionId=create-tdd-[entity]`.
|
|
18
18
|
2. Establish evidence before asking questions:
|
|
19
19
|
- `recall` approved RFCs, ADRs, prior TDD decisions, constraints, rejected approaches, and verification patterns.
|
|
20
|
-
- Load `references/tdd/discovery-and-sizing.md`.
|
|
20
|
+
- Load `references/create-tdd/discovery-and-sizing.md`.
|
|
21
21
|
- Inspect current source, tests, source sets, project instructions, architecture documents, and existing design artifacts. Current source and approved project artifacts override stale memory.
|
|
22
22
|
- For testing plans, find whether each planned test file already exists and which source set owns it before choosing a location such as `commonTest`, `androidUnitTest`, `unitTest`, or the repository's actual equivalent.
|
|
23
23
|
- For UI/UX-affecting method, class, enum, sealed type, mapper, or state changes, enumerate parallel rendering surfaces and mappers that consume the affected symbol.
|
|
24
24
|
- When supplied Figma links, nodes, desktop selections, or screenshots materially affect supported Android, iOS, or KMP Compose Multiplatform UI design, use `workflows/design.md` as optional child context and keep this TDD as the owner of architecture, contracts, rollout, and verification strategy. Screenshots are context-only unless paired with structured Figma evidence.
|
|
25
25
|
- Run a pre-TDD `Strings Audit` when mappers branch on a type and call `stringResource`; record affected string keys/resources, branches, fallback behavior, and surfaces before proposing string changes.
|
|
26
26
|
- Load `references/synapse-policy.md` when two or more related searches are expected and `references/context-firewall.md` before broad or verbose source inspection.
|
|
27
|
-
3. Confirm workflow fit with the readiness checklist in `references/tdd/discovery-and-sizing.md` and classify the document as Compact, Standard, or High-Risk from the exact sizing rules there. Do not size by guessed calendar duration.
|
|
28
|
-
- Record a `project_type` intake tag from this taxonomy: `integration`, `feature`, `refactor`, `infrastructure`, `payment`, `auth`, `data`. The `project_type` selects which conditional concerns in `references/tdd/document-contract.md` apply and which calibrated reference values from `references/tdd/calibrated-examples.md` are relevant; it does not mandate section counts or a fixed document shape.
|
|
29
|
-
- Apply the critical-section MANDATORY trigger mapping below. These are workflow-level selectors that point at the Conditional Concerns table in `references/tdd/document-contract.md`; they do not duplicate that table. When a trigger fires, the matching concerns are mandatory, not optional:
|
|
27
|
+
3. Confirm workflow fit with the readiness checklist in `references/create-tdd/discovery-and-sizing.md` and classify the document as Compact, Standard, or High-Risk from the exact sizing rules there. Do not size by guessed calendar duration.
|
|
28
|
+
- Record a `project_type` intake tag from this taxonomy: `integration`, `feature`, `refactor`, `infrastructure`, `payment`, `auth`, `data`. The `project_type` selects which conditional concerns in `references/create-tdd/document-contract.md` apply and which calibrated reference values from `references/create-tdd/calibrated-examples.md` are relevant; it does not mandate section counts or a fixed document shape.
|
|
29
|
+
- Apply the critical-section MANDATORY trigger mapping below. These are workflow-level selectors that point at the Conditional Concerns table in `references/create-tdd/document-contract.md`; they do not duplicate that table. When a trigger fires, the matching concerns are mandatory, not optional:
|
|
30
30
|
- `payment`, `auth`, PII, or regulated data → Security is mandatory.
|
|
31
31
|
- production or customer-facing rollout → Monitoring and Rollback are mandatory.
|
|
32
32
|
- external or cross-service integration → Dependencies and Security are mandatory.
|
|
@@ -35,7 +35,7 @@ Load `references/project-context.md` (intake sweep) before the first substantive
|
|
|
35
35
|
- Group related questions naturally, in the user's language — no numeric cap; ask as many as the open decisions require.
|
|
36
36
|
- Distinguish verified facts, evidence-backed inferences, proposed decisions, and unresolved questions.
|
|
37
37
|
- Never invent owners, links, APIs, schemas, vendors, dates, thresholds, estimates, approvals, or project facts to complete a template.
|
|
38
|
-
5. Load `references/tdd/document-contract.md`, plus `references/naming-standards.md` when the design names proposed components, modules, states, events, schemas, or fields, and draft the smallest decision-complete TDD for the selected depth.
|
|
38
|
+
5. Load `references/create-tdd/document-contract.md`, plus `references/naming-standards.md` when the design names proposed components, modules, states, events, schemas, or fields, and draft the smallest decision-complete TDD for the selected depth.
|
|
39
39
|
- Write in the user's language while preserving established project terminology and technical identifiers.
|
|
40
40
|
- Focus on architecture, ownership boundaries, stable interfaces, data flow, failure behavior, and implementation strategy.
|
|
41
41
|
- Include implementation detail when it defines a contract or removes material ambiguity; exclude production implementation code and incidental framework syntax.
|
|
@@ -49,12 +49,12 @@ Load `references/project-context.md` (intake sweep) before the first substantive
|
|
|
49
49
|
- If the target exists, treat the request as an update only when the user explicitly requested one; otherwise ask before overwriting it.
|
|
50
50
|
- When file mutation is unavailable or the user requested plan-only output, present the complete draft and intended path without writing.
|
|
51
51
|
7. Run the configured Plan Challenge Gate. TDD plans require the full gate under the default policy; revise valid critical or high findings before finalization.
|
|
52
|
-
8. Load `references/tdd/quality-and-lifecycle.md`, validate the document, and resolve blocking gaps. Keep non-blocking unknowns explicit with owners or decision points when known.
|
|
52
|
+
8. Load `references/create-tdd/quality-and-lifecycle.md`, validate the document, and resolve blocking gaps. Keep non-blocking unknowns explicit with owners or decision points when known.
|
|
53
53
|
9. If the implementation task table is stable and validated, discover whether Atlassian MCP has readable Jira project metadata and issue-creation capability.
|
|
54
54
|
- If Atlassian MCP is unavailable or read-only, leave the table's `Jira Key` values as `Unavailable` and report that ticket creation was skipped.
|
|
55
55
|
- If Atlassian MCP is available, ask whether the user wants to create Jira tickets now. If declined, set `Jira Key` to `Not requested`.
|
|
56
|
-
- If the user accepts, invoke `workflows/ticket.md`; Jira creation remains owned solely by the ticket workflow. Create one standard Jira issue per PR group. Create row-level sub-tasks only when the selected ticket hierarchy requires them.
|
|
57
|
-
- Update `Jira Key` only with confirmed Jira keys returned by the ticket workflow. Use `Pending` for approved-but-uncreated PR groups and never fabricate keys.
|
|
56
|
+
- If the user accepts, invoke `workflows/create-ticket.md`; Jira creation remains owned solely by the `create-ticket` workflow. Create one standard Jira issue per PR group. Create row-level sub-tasks only when the selected ticket hierarchy requires them.
|
|
57
|
+
- Update `Jira Key` only with confirmed Jira keys returned by the create-ticket workflow. Use `Pending` for approved-but-uncreated PR groups and never fabricate keys.
|
|
58
58
|
10. Save the document as `Draft` or `In Review`. Never mark it `Approved`, invent sign-off, or begin downstream implementation without the required human decision.
|
|
59
59
|
11. Persist only durable architecture constraints, accepted trade-offs, rejected approaches, compatibility requirements, and verification recipes through `remember` after recall, deduplication, and scoring. Use `decision` with `memory:semantic` for the architectural blueprint.
|
|
60
60
|
12. Complete `references/evidence-gate.md` and report the artifact path, included conditional sections, unresolved questions, Jira creation outcome, memory outcome, and residual risk.
|
|
@@ -1,5 +1,5 @@
|
|
|
1
1
|
---
|
|
2
|
-
name: ticket
|
|
2
|
+
name: create-ticket
|
|
3
3
|
description: "Use this workflow to draft, review, create, or resume creation of Jira Epics, issues, or sub-tasks through Atlassian MCP, the only tracker and mutation path."
|
|
4
4
|
license: MIT
|
|
5
5
|
metadata:
|
|
@@ -14,12 +14,12 @@ Load `references/project-context.md` (intake sweep) before the first substantive
|
|
|
14
14
|
|
|
15
15
|
## Workflow
|
|
16
16
|
|
|
17
|
-
1. Resolve or reuse `projectId` and `workflowSessionId=ticket-<entity>`.
|
|
17
|
+
1. Resolve or reuse `projectId` and `workflowSessionId=create-ticket-<entity>`.
|
|
18
18
|
2. Recall durable project conventions, prior Jira constraints, and ticket-writing decisions through `recall`. Treat recalled facts as leads until confirmed by the user or current Jira metadata.
|
|
19
19
|
3. Load the focused contracts:
|
|
20
|
-
- `references/ticket/intake-and-sources.md` for ordered questions, reference-ticket isolation, DoR/DoD inputs, and bounded code exploration.
|
|
21
|
-
- `references/ticket/templates-and-quality.md` for title prefixes, built-in templates, decomposition, and draft validation.
|
|
22
|
-
- `references/ticket/atlassian-fix.md` before tool discovery, preflight, approval, Jira creation, resume, or cleanup.
|
|
20
|
+
- `references/create-ticket/intake-and-sources.md` for ordered questions, reference-ticket isolation, DoR/DoD inputs, and bounded code exploration.
|
|
21
|
+
- `references/create-ticket/templates-and-quality.md` for title prefixes, built-in templates, decomposition, and draft validation.
|
|
22
|
+
- `references/create-ticket/atlassian-fix.md` before tool discovery, preflight, approval, Jira creation, resume, or cleanup.
|
|
23
23
|
- `references/context-firewall.md` when Jira, Confluence, supplied files, or exploration output could flood context.
|
|
24
24
|
4. Discover Atlassian MCP capabilities dynamically. Require readable Jira project metadata and issue-creation capability before promising creation. If Atlassian MCP is missing or read-only, drafting may continue, but stop before approval-to-create and report the unavailable capability. Never substitute a CLI or tracker.
|
|
25
25
|
5. Run ordered intake from `intake-and-sources.md`. Ask only for information not already supplied or discoverable from Atlassian metadata. Validate the exact project key without silently correcting it.
|
|
@@ -67,17 +67,16 @@ Before the first repository mutation, load `references/implementation-delivery.m
|
|
|
67
67
|
- (a) write the test first, asserting the exact previously-broken behavior at the divergence point
|
|
68
68
|
- (b) at Standard+, prove the coverage discriminates: run the sensor in `references/discrimination-sensor.md` against the just-fixed code; a surviving mutant means the regression test does not yet prove the fix
|
|
69
69
|
|
|
70
|
-
> **Dispatch: `
|
|
70
|
+
> **Dispatch: `code-reviewer`** (role: `code-reviewer`, mode: `review`) — charter `skills/agents/code-reviewer/SKILL.md`
|
|
71
71
|
> - trigger: implementation complete, before the verification gate — never optional
|
|
72
72
|
> - scope: the fix's diff surface and its task/AC context
|
|
73
|
-
> - permissions: read-only
|
|
74
73
|
> - inputs: diff, acceptance context, recalled code-quality conventions
|
|
75
74
|
> - sensors: bugs, regressions, missing edge cases, smells introduced by the diff
|
|
76
75
|
> - output: ranked findings, blocking vs advisory; blocking findings become fix items before verification runs
|
|
77
76
|
> - firewall: summarized findings only, never raw diff dumps
|
|
78
77
|
> - memory: suggest-only; main agent persists
|
|
79
78
|
|
|
80
|
-
> **Dispatch: `
|
|
79
|
+
> **Dispatch: `code-reviewer`** (role: `code-reviewer`, mode: `verify`) — charter `skills/agents/code-reviewer/SKILL.md`
|
|
81
80
|
> - trigger: mandatory at Standard+/Spec-driven fix size, per the Independent Verification Mandate tier gate in `references/verification-ladder.md`; a Quick-tier fix takes the fallback below instead
|
|
82
81
|
> - scope: the fixed divergence point from step 13, its reproduction path, and the regression test added in step 14
|
|
83
82
|
> - inputs: the root cause, the reproduction evidence, the regression test, and the changed files — not spec acceptance criteria
|
|
@@ -116,7 +115,7 @@ Before the first repository mutation, load `references/implementation-delivery.m
|
|
|
116
115
|
|
|
117
116
|
- `.specs/debug/<slug>/` unwritable at Standard+: block the `REPORT.md` write and record the blocker; never substitute a memory write or chat summary for the canonical debug artifact.
|
|
118
117
|
- Fix → re-verify loop reaches the `references/verification-ladder.md` cap: stop the session `Blocked`, preserve the collected reproduction and verification evidence, and ask the user for direction.
|
|
119
|
-
- Discrimination sensor mutation on the fixed divergence point is not safely reversible: mark `Blocked` unless the
|
|
118
|
+
- Discrimination sensor mutation on the fixed divergence point is not safely reversible: mark `Blocked` unless the `code-reviewer` verifier can show equivalent discrimination from an existing deterministic mutation fixture.
|
|
120
119
|
|
|
121
120
|
## Example
|
|
122
121
|
|
|
@@ -129,4 +128,4 @@ User asks: "The login route returns 500 after deploy."
|
|
|
129
128
|
5. Trace request → auth middleware → session lookup → response, then fix the divergence point closest to the root cause.
|
|
130
129
|
6. Define the verification recipe: rerun the original route check, add or update regression coverage at the failing seam, and confirm validation assets were not weakened.
|
|
131
130
|
7. If root cause is a missing `DATABASE_URL`, persist via `remember`: a semantic decision memory for the root cause and a procedural pattern memory for the deploy-env verification command.
|
|
132
|
-
8. At Standard+ size, dispatch `
|
|
131
|
+
8. At Standard+ size, dispatch `code-reviewer` in `verify` mode to independently re-run the reproduction against the `DATABASE_URL` fix and confirm the regression test kills a mutant on the restored connection check before closing.
|
|
@@ -28,9 +28,9 @@ Not for Flutter, React Native, web UI, generic Figma exploration, variable-only
|
|
|
28
28
|
6. Persist only durable token/component mappings, approved deviations, source-set ownership rules, asset-pipeline rules, or reusable render recipes after Importance Calibration. Use `workflow:design` and required project/session/entity/memory tags.
|
|
29
29
|
7. Complete `references/evidence-gate.md`. Model visual judgment alone cannot satisfy completion.
|
|
30
30
|
|
|
31
|
-
**Screen work —
|
|
31
|
+
**Screen work — unconditional in this workflow:** every task here implements a user-facing screen, so the `designer` dispatch below always runs; it is not gated on a screen-work condition (Screen Implementation Exception in `references/agent-orchestration.md`).
|
|
32
32
|
|
|
33
|
-
> **Dispatch: `
|
|
33
|
+
> **Dispatch: `designer`** (role: `designer`, mode: `implement`) — charter `skills/agents/designer/SKILL.md`
|
|
34
34
|
> - scope: the screens, views, components, layouts, styles, and design tokens in this task's UI surface — never the whole repository
|
|
35
35
|
> - permissions: write, scoped to UI-layer files only with a disjoint write set
|
|
36
36
|
> - output: per-element conformance table (element, expected, actual, verdict, severity) plus the UI files written; a missing or unreachable design source is listed as a skipped sensor, never a silent pass
|
|
@@ -51,9 +51,9 @@ When researching or resolving any technical question during exploration, follow
|
|
|
51
51
|
- per step, state a `verify:` criterion — what concrete evidence confirms that step succeeded (a read signature, a matched call graph, a resolved data path) before moving on
|
|
52
52
|
- define what evidence would be enough to answer the user
|
|
53
53
|
- ask only if the objective or scope cannot be inferred from local context
|
|
54
|
-
6. Recon with progressive disclosure. Dispatch `
|
|
54
|
+
6. Recon with progressive disclosure. Dispatch `code-explorer` per `references/agent-orchestration.md` when the investigation justifies an isolated read-only subagent:
|
|
55
55
|
|
|
56
|
-
> **Dispatch: `
|
|
56
|
+
> **Dispatch: `code-explorer`** (role: `code-explorer`, mode: `trace`) — charter `skills/agents/code-explorer/SKILL.md`
|
|
57
57
|
> - trigger: isolated read-only investigation justified; large scope, repeated searches, or context-firewall threshold exceeded
|
|
58
58
|
> - scope: the exploration target — symbols, files, routes, commands, docs, or runtime artifacts to inspect
|
|
59
59
|
> - permissions: read-only
|
|
@@ -54,25 +54,24 @@ Before the first repository mutation, load `references/implementation-delivery.m
|
|
|
54
54
|
- When every group has a confirmed Jira key, follow the optional stacked branch flow in `references/pr-task-fix.md` (Jira-Key Stacked Branches).
|
|
55
55
|
- All PR groups decomposed under this feature share one feature-level delivery go-ahead: no individual group seeks or receives its own Stage 3 sign-off — see `references/implementation-delivery.md` Stage 3.
|
|
56
56
|
|
|
57
|
-
**Screen work — before writing or judging any user-facing screen:** when this task creates or modifies a screen, the `
|
|
57
|
+
**Screen work — before writing or judging any user-facing screen:** when this task creates or modifies a screen, the `designer` dispatch below is mandatory rather than discretionary, carved out of ordinary delegation gating by the Screen Implementation Exception in `references/agent-orchestration.md`. It does not fire when the task touches no screen surface.
|
|
58
58
|
|
|
59
|
-
> **Dispatch: `
|
|
59
|
+
> **Dispatch: `designer`** (role: `designer`, mode: `implement`) — charter `skills/agents/designer/SKILL.md`
|
|
60
60
|
> - scope: the screens, views, components, layouts, styles, and design tokens in this task's UI surface — never the whole repository
|
|
61
61
|
> - permissions: write, scoped to UI-layer files only with a disjoint write set
|
|
62
62
|
> - output: per-element conformance table (element, expected, actual, verdict, severity) plus the UI files written; a missing or unreachable design source is listed as a skipped sensor, never a silent pass
|
|
63
63
|
|
|
64
|
-
> **Dispatch: `
|
|
64
|
+
> **Dispatch: `code-reviewer`** (role: `code-reviewer`, mode: `review`) — charter `skills/agents/code-reviewer/SKILL.md`
|
|
65
65
|
> - trigger: implementation complete, before the verification gate — never optional
|
|
66
66
|
> - scope: the feature's diff surface and its task/AC context
|
|
67
|
-
> - permissions: read-only
|
|
68
67
|
> - inputs: diff, acceptance context, recalled code-quality conventions
|
|
69
68
|
> - sensors: bugs, regressions, missing edge cases, smells introduced by the diff
|
|
70
69
|
> - output: ranked findings, blocking vs advisory; blocking findings become fix items before verification runs
|
|
71
70
|
> - firewall: summarized findings only, never raw diff dumps
|
|
72
71
|
> - memory: suggest-only; main agent persists
|
|
73
72
|
|
|
74
|
-
> **Dispatch: `
|
|
75
|
-
> - trigger: Standard tier or above per the Independent Verification Mandate in `references/verification-ladder.md` — mandatory once every implemented PR group has cleared reviewer fix items; Quick tier substitutes the fallback below
|
|
73
|
+
> **Dispatch: `code-reviewer`** (role: `code-reviewer`, mode: `verify`) — charter `skills/agents/code-reviewer/SKILL.md`
|
|
74
|
+
> - trigger: Standard tier or above per the Independent Verification Mandate in `references/verification-ladder.md` — mandatory once every implemented PR group has cleared `code-reviewer` review fix items; Quick tier substitutes the fallback below
|
|
76
75
|
> - scope: the new code landed across this feature's PR groups from step 12, plus the tests and validation assets those groups touch
|
|
77
76
|
> - inputs: the 1-5 acceptance criteria captured in step 11 (or the referenced spec artifact) as the outcome source, the feature's diff surface across all PR groups, and its test suite
|
|
78
77
|
> - sensors: check the diff and tests against each acceptance criterion; discrimination sensor per `references/discrimination-sensor.md` (mutate the feature's new code, one PR group at a time — covering tests must kill each mutant or that group is not verified)
|
|
@@ -38,11 +38,30 @@ Not for a single requested audit lens — route directly to that lens. Do not ed
|
|
|
38
38
|
- For a broad/full audit, run Correctness, Architecture, Code Quality, Security, and Tests. Run Requirements only when a requirements source is available.
|
|
39
39
|
- Supported lenses: Correctness -> `workflows/bugs/bugs-audit.md`; Architecture -> `workflows/architecture/architecture-audit.md`; Code Quality -> `workflows/code-quality/code-quality-audit.md`; Security -> `workflows/security/security-audit.md`; Requirements -> `workflows/requirements/requirements-audit.md`; Tests -> `workflows/tests/tests-audit.md`.
|
|
40
40
|
- When a broad audit lacks requirements, ask for a source when interactive and not forbidden; otherwise mark Requirements `not evaluated: missing source`. Never report a requirements all-clear without a source.
|
|
41
|
-
7. Establish child contracts and dispatch
|
|
41
|
+
7. Establish child contracts and dispatch one agent per lens through `references/agent-orchestration.md`: `code-reviewer` for Correctness (`lens: bugs`), Architecture, Code Quality, and Security; `product-manager` for Requirements; `test-engineer` for Tests.
|
|
42
42
|
|
|
43
|
-
> **Dispatch: `
|
|
43
|
+
> **Dispatch: `code-reviewer`** (role: `code-reviewer`, mode: `audit`) — charter `skills/agents/code-reviewer/SKILL.md`
|
|
44
44
|
> - trigger: broad/full audit requiring multiple lenses, or explicit multi-lens request
|
|
45
|
-
> - scope: one lens per dispatch against the shared implementation scope packet (Correctness
|
|
45
|
+
> - scope: one lens per dispatch against the shared implementation scope packet (Correctness as `lens: bugs`, Architecture as `lens: architecture`, Code Quality as `lens: code-quality`, Security as `lens: security`)
|
|
46
|
+
> - inputs: exact `projectId`, parent `workflowSessionId`, child workflow, lens name, shared scope packet, resolved files/diff summary, relevant recalled facts, allowed surrounding-code depth, deterministic sensors, context-firewall limits, and output contract
|
|
47
|
+
> - sensors: target-relevant deterministic commands (tests, builds, lint, type checks, static checks, import checks) per lens
|
|
48
|
+
> - output: `Status`, `Scope checked`, `Evidence`, `Findings`, `Verification/Test Fidelity Checklist`, `Risks and skipped checks`, and `Exact next step`
|
|
49
|
+
> - firewall: raw diffs/logs/search output summarized, not returned raw
|
|
50
|
+
> - memory: suggest-only; children must not persist broad project memory unless assigned
|
|
51
|
+
|
|
52
|
+
> **Dispatch: `product-manager`** (role: `product-manager`, mode: `audit`) — charter `skills/agents/product-manager/SKILL.md`
|
|
53
|
+
> - trigger: the Requirements lens is in scope and a requirements source is available
|
|
54
|
+
> - scope: the Requirements lens (`lens: requirements`) against the shared implementation scope packet and the resolved requirements source
|
|
55
|
+
> - permissions: read-only
|
|
56
|
+
> - inputs: exact `projectId`, parent `workflowSessionId`, child workflow, lens name, shared scope packet, resolved files/diff summary, relevant recalled facts, allowed surrounding-code depth, deterministic sensors, context-firewall limits, and output contract
|
|
57
|
+
> - sensors: target-relevant deterministic commands (tests, builds, lint, type checks, static checks, import checks) per lens
|
|
58
|
+
> - output: `Status`, `Scope checked`, `Evidence`, `Findings`, `Verification/Test Fidelity Checklist`, `Risks and skipped checks`, and `Exact next step`
|
|
59
|
+
> - firewall: raw diffs/logs/search output summarized, not returned raw
|
|
60
|
+
> - memory: suggest-only; children must not persist broad project memory unless assigned
|
|
61
|
+
|
|
62
|
+
> **Dispatch: `test-engineer`** (role: `test-engineer`, mode: `audit`) — charter `skills/agents/test-engineer/SKILL.md`
|
|
63
|
+
> - trigger: the Tests lens is in scope
|
|
64
|
+
> - scope: the Tests lens (`lens: tests`) against the shared implementation scope packet
|
|
46
65
|
> - permissions: read-only
|
|
47
66
|
> - inputs: exact `projectId`, parent `workflowSessionId`, child workflow, lens name, shared scope packet, resolved files/diff summary, relevant recalled facts, allowed surrounding-code depth, deterministic sensors, context-firewall limits, and output contract
|
|
48
67
|
> - sensors: target-relevant deterministic commands (tests, builds, lint, type checks, static checks, import checks) per lens
|
|
@@ -32,7 +32,7 @@ Do not execute from chat summaries, inline review comments, remembered findings,
|
|
|
32
32
|
- `references/discrimination-sensor.md` before closing any finding at the tiers the verification-ladder's Independent Verification Mandate names.
|
|
33
33
|
- `references/knowledge-verification-chain.md` when a finding's fix depends on external library/API behavior not already verified this session.
|
|
34
34
|
- `references/brownfield-mapping.md` (Minimum Bar only) for Standard+ findings when recall returns no hit for the target and no gate command is derivable from the report's evidence.
|
|
35
|
-
- `references/agent-orchestration.md` for high-risk findings or disjoint implementation slices; the mandated
|
|
35
|
+
- `references/agent-orchestration.md` for high-risk findings or disjoint implementation slices; the mandated `code-reviewer` `verify` dispatch below is carved out of this trigger by agent-orchestration's Independent Verification Exception and always attempts dispatch at its own tier gate.
|
|
36
36
|
3. `recall` -> load prior implementation audit decisions, known regressions, architecture/security boundaries, accepted exceptions, testing conventions, and reusable verification recipes for the target.
|
|
37
37
|
4. Select the report with an explicit execution focus:
|
|
38
38
|
- Establish report selector, target focus, and optional source-qualified finding IDs before selecting a report.
|
|
@@ -62,14 +62,14 @@ Do not execute from chat summaries, inline review comments, remembered findings,
|
|
|
62
62
|
9. Size each finding with `references/verification-ladder.md`. Quick findings may proceed locally; Standard findings require characterization and an explicit recipe; ambiguous, cross-boundary, migration-heavy, or broad redesign findings pause and route to `spec-driven`.
|
|
63
63
|
10. Orchestrate conservatively. The main agent owns report parsing, scope/freshness, prioritization, questions, memory, and final evidence. Dispatch per `references/agent-orchestration.md`:
|
|
64
64
|
|
|
65
|
-
**Screen work — before writing or judging any user-facing screen:** when this task creates or modifies a screen, the `
|
|
65
|
+
**Screen work — before writing or judging any user-facing screen:** when this task creates or modifies a screen, the `designer` dispatch below is mandatory rather than discretionary, carved out of ordinary delegation gating by the Screen Implementation Exception in `references/agent-orchestration.md`. It does not fire when the task touches no screen surface.
|
|
66
66
|
|
|
67
|
-
> **Dispatch: `
|
|
67
|
+
> **Dispatch: `designer`** (role: `designer`, mode: `implement`) — charter `skills/agents/designer/SKILL.md`
|
|
68
68
|
> - scope: the screens, views, components, layouts, styles, and design tokens in this task's UI surface — never the whole repository
|
|
69
69
|
> - permissions: write, scoped to UI-layer files only with a disjoint write set
|
|
70
70
|
> - output: per-element conformance table (element, expected, actual, verdict, severity) plus the UI files written; a missing or unreachable design source is listed as a skipped sensor, never a silent pass
|
|
71
71
|
|
|
72
|
-
> **Dispatch: `
|
|
72
|
+
> **Dispatch: `builder`** (role: `builder`) — charter `skills/agents/builder/SKILL.md`
|
|
73
73
|
> - trigger: isolated finding with disjoint write set and concrete verification
|
|
74
74
|
> - scope: one isolated implementation finding with a disjoint write set
|
|
75
75
|
> - permissions: write (disjoint write set)
|
|
@@ -81,17 +81,16 @@ Do not execute from chat summaries, inline review comments, remembered findings,
|
|
|
81
81
|
|
|
82
82
|
Never run parallel writers against shared files or contracts.
|
|
83
83
|
|
|
84
|
-
> **Dispatch: `
|
|
84
|
+
> **Dispatch: `code-reviewer`** (role: `code-reviewer`, mode: `review`) — charter `skills/agents/code-reviewer/SKILL.md`
|
|
85
85
|
> - trigger: implementation complete, before the verification gate — never optional
|
|
86
86
|
> - scope: the fix's diff surface and its task/AC context
|
|
87
|
-
> - permissions: read-only
|
|
88
87
|
> - inputs: diff, acceptance context, recalled code-quality conventions
|
|
89
88
|
> - sensors: bugs, regressions, missing edge cases, smells introduced by the diff
|
|
90
89
|
> - output: ranked findings, blocking vs advisory; blocking findings become fix items before verification runs
|
|
91
90
|
> - firewall: summarized findings only, never raw diff dumps
|
|
92
91
|
> - memory: suggest-only; main agent persists
|
|
93
92
|
|
|
94
|
-
> **Dispatch: `
|
|
93
|
+
> **Dispatch: `code-reviewer`** (role: `code-reviewer`, mode: `verify`) — charter `skills/agents/code-reviewer/SKILL.md`
|
|
95
94
|
> - trigger: an `Area/PREFIX-N` finding's closure meets the verification-ladder's Independent Verification Mandate tier gate — Standard+/Spec-driven size or any high/critical-severity finding
|
|
96
95
|
> - scope: the closed `Area/PREFIX-N` finding's fix diff, its source-lens claim, and the validation assets the fix touches
|
|
97
96
|
> - inputs: the source-qualified finding ID, the applied fix diff, the report's Verification Suggestion, and the pending closure-matrix row
|
|
@@ -12,10 +12,10 @@ Use when the user explicitly asks to evaluate an artifact through multi-judge
|
|
|
12
12
|
debate — "judge this", "judge-with-debate", "evaluate with debate", "run the judges on X". The
|
|
13
13
|
user supplies artifact path(s) plus a task description (what the artifact was supposed to
|
|
14
14
|
accomplish) and optionally evaluation context. Standalone, explicit-route workflow: never
|
|
15
|
-
auto-selected by the router for generic review work (use `reviewer`, `*-audit`, or
|
|
16
|
-
`plan-
|
|
15
|
+
auto-selected by the router for generic review work (use `code-reviewer`, `*-audit`, or
|
|
16
|
+
the Plan Challenge `judge` `plan-critique` dispatch for those).
|
|
17
17
|
|
|
18
|
-
The protocol:
|
|
18
|
+
The protocol: one `judge` in `spec-author` mode authors a tailored evaluation specification **once**; three
|
|
19
19
|
independent judges score the artifact against it with quoted evidence; the judges debate their
|
|
20
20
|
disagreements over **up to 3 rounds**; the panel converges on a consensus verdict or reports an
|
|
21
21
|
honest no-consensus. Ported from the NeoLabHQ `judge-with-debate` pattern; this file is the
|
|
@@ -57,7 +57,7 @@ Check whether the host supports **dispatch-time model selection** (a per-dispatc
|
|
|
57
57
|
parameter on the task/subagent tool). This probe runs on every invocation — when a host gains
|
|
58
58
|
the capability, per-slot diversity activates automatically with no harness edit.
|
|
59
59
|
|
|
60
|
-
- Probe positive → request per-slot models at dispatch:
|
|
60
|
+
- Probe positive → request per-slot models at dispatch: spec-author `kimi-k3`, Judge 1
|
|
61
61
|
`deepseek-v4-pro`, Judge 2 `minimax-m3`, Judge 3 `GLM-5.2`.
|
|
62
62
|
- Probe negative (all four hosts today) → dispatch the charter-default artifacts and record the
|
|
63
63
|
unmet per-slot requests. Every fallback is named; if any slot fell back the consensus file and
|
|
@@ -66,12 +66,12 @@ the capability, per-slot diversity activates automatically with no harness edit.
|
|
|
66
66
|
- A pinned-but-unavailable model falls back to the host default for that slot, named loudly in
|
|
67
67
|
the same way.
|
|
68
68
|
|
|
69
|
-
## Step 1 —
|
|
69
|
+
## Step 1 — Spec-author (exactly once)
|
|
70
70
|
|
|
71
|
-
Dispatch `
|
|
71
|
+
Dispatch `judge` in `spec-author` mode (read-only) with the task description, artifact type, context,
|
|
72
72
|
and artifact paths. Model request: `kimi-k3` (see Step 0.5).
|
|
73
73
|
|
|
74
|
-
> **Dispatch: `
|
|
74
|
+
> **Dispatch: `judge`** (role: `judge`, mode: `spec-author`) — charter `skills/agents/judge/SKILL.md`
|
|
75
75
|
> - trigger: judge-with-debate Step 1; runs exactly once per evaluation
|
|
76
76
|
> - scope: the artifact under evaluation (paths supplied), task description, artifact type
|
|
77
77
|
> - permissions: read-only
|
|
@@ -94,23 +94,23 @@ Validate the returned evaluation specification in two stages, in order; a retry
|
|
|
94
94
|
`rubric` with anchors for scores 1, 3, 5, and a `checklist` with ≥1 item. Parseable but
|
|
95
95
|
invalid specs (e.g. `scale.max: 7`) fail here, not at stage 1.
|
|
96
96
|
|
|
97
|
-
On failure: retry the
|
|
98
|
-
stop `Blocked`. The
|
|
97
|
+
On failure: retry the spec-author **once** with the failed stage + check name. Second failure →
|
|
98
|
+
stop `Blocked`. The spec-author runs exactly once per evaluation — never re-run between rounds,
|
|
99
99
|
never edited by the orchestrator; the YAML passes to all judges in all rounds **verbatim**.
|
|
100
100
|
|
|
101
|
-
Feedback: `🤖 [Agent Started]
|
|
101
|
+
Feedback: `🤖 [Agent Started] Judge (spec-author) is authoring the evaluation specification.`
|
|
102
102
|
then `🤖 [Agent Done]` or `🤖 [Agent Blocked]` with the one-line reason.
|
|
103
103
|
|
|
104
104
|
## Step 2 — Independent analysis (3 judges in parallel)
|
|
105
105
|
|
|
106
|
-
Dispatch three `
|
|
106
|
+
Dispatch three `judge` agents in `scorer` mode **in parallel** (round 0), one per judge number, each
|
|
107
107
|
with: the verbatim specification YAML, task description, artifact paths, its own report path,
|
|
108
108
|
`round: 0`, and its model request (Step 0.5). The fixed panel of 3 sits inside the wave cap of
|
|
109
109
|
4 concurrent subagents (`references/agent-orchestration.md`, Orchestrator Working Memory).
|
|
110
110
|
Each judge writes its own `audits/judge/<...> judge-N.md` per the report contract and returns
|
|
111
111
|
the reply block:
|
|
112
112
|
|
|
113
|
-
> **Dispatch: `
|
|
113
|
+
> **Dispatch: `judge`** (role: `judge`, mode: `scorer`) — charter `skills/agents/judge/SKILL.md` — 3 per panel, rounds 0..3
|
|
114
114
|
> - trigger: judge-with-debate Steps 2 and 4; panel of exactly 3, never more
|
|
115
115
|
> - scope: the artifact under evaluation, the verbatim specification YAML, own report path; debate rounds add all three report paths as peer paths and `round: R`
|
|
116
116
|
> - permissions: read-only except appending to its own judge-N report file
|
|
@@ -159,7 +159,7 @@ Step 5. If no consensus and rounds remain → Step 4. If no consensus after roun
|
|
|
159
159
|
|
|
160
160
|
## Step 4 — Debate round (rounds 1..3, max 3)
|
|
161
161
|
|
|
162
|
-
Increment the round. Dispatch three `
|
|
162
|
+
Increment the round. Dispatch three `judge` agents **in parallel** again, each with:
|
|
163
163
|
the verbatim specification YAML (unchanged), task description, artifact paths, its own report
|
|
164
164
|
path, **all three** report paths as peer paths, and `round: R`. Each judge:
|
|
165
165
|
|
|
@@ -198,7 +198,7 @@ did not reach.**
|
|
|
198
198
|
|
|
199
199
|
## Pitfalls (each is a rule, not advice)
|
|
200
200
|
|
|
201
|
-
- Never skip the
|
|
201
|
+
- Never skip the spec-author; never let judges score without the shared specification.
|
|
202
202
|
- Never modify or regenerate the specification between rounds — verbatim, every round.
|
|
203
203
|
- Never let a debate judge create a new report file — append-only `## Debate Round {R}` sections.
|
|
204
204
|
- Never relay reports between judges through the orchestrator — filesystem channel only.
|
|
@@ -58,9 +58,9 @@ Do not edit code. Route direct design implementation to `design`. Not for Flutte
|
|
|
58
58
|
16. Persist only durable token/component mappings, source-set ownership rules, approved accessibility/platform deviations, asset-pipeline rules, or reusable render recipes after Importance Calibration. Use `workflow:mobile-figma-audit` and required tags. Never persist screenshots, hierarchy dumps, raw logs, device IDs, or user data.
|
|
59
59
|
17. Complete `references/evidence-gate.md`. A model visual impression cannot satisfy the gate.
|
|
60
60
|
|
|
61
|
-
**Screen work —
|
|
61
|
+
**Screen work — unconditional in this workflow:** every task here judges a user-facing screen, so the `designer` dispatch below always runs; it is not gated on a screen-work condition (Screen Implementation Exception in `references/agent-orchestration.md`).
|
|
62
62
|
|
|
63
|
-
> **Dispatch: `
|
|
63
|
+
> **Dispatch: `designer`** (role: `designer`, mode: `audit`) — charter `skills/agents/designer/SKILL.md`
|
|
64
64
|
> - scope: the screens, views, components, layouts, styles, and design tokens under audit — never the whole repository, and no edits
|
|
65
65
|
> - permissions: read-only — this workflow is findings-only; the charter permits writes only when explicitly scoped, and its Restrictions win over the packet, so read-only governs
|
|
66
66
|
> - output: per-element conformance table (element, expected, actual, verdict, severity) feeding `MFM-*` findings; a missing or unreachable design source is listed as a skipped sensor, never a silent pass
|
|
@@ -32,7 +32,7 @@ Do not execute from chat summaries, screenshots alone, remembered findings, or a
|
|
|
32
32
|
- `references/audit-scope.md` and `references/codebase-investigation.md` for freshness and current source.
|
|
33
33
|
- `references/verification-ladder.md` before edits.
|
|
34
34
|
- `references/context-firewall.md` before large design/runtime artifacts.
|
|
35
|
-
- `references/agent-orchestration.md` for the tier-gated
|
|
35
|
+
- `references/agent-orchestration.md` for the designer/builder dispatches and the tier-gated `code-reviewer` `verify` dispatch in the fix loop below.
|
|
36
36
|
- `references/discrimination-sensor.md` before closing any finding under the Mandatory Verification Fix Gate — the mobile-Figma token/value instantiation lives in `references/mobile-figma-matcher/core.md`'s Discrimination Sensor for Visual Parity section.
|
|
37
37
|
- `references/knowledge-verification-chain.md` when a selected finding's fix direction depends on platform-API or external-library technique rather than the Figma-defined value.
|
|
38
38
|
- `references/brownfield-mapping.md` (Minimum Bar only — the gate-command packet, `TESTING.md`-equivalent) when recall returns no hit for the target surface/module and no gate command is derivable from the report's evidence, for Standard+ findings; the report's Verification/Test Fidelity Checklist already carries the risk surface, so `CONCERNS.md` is satisfied-by-citation from that checklist rather than derived fresh.
|
|
@@ -58,36 +58,35 @@ Do not execute from chat summaries, screenshots alone, remembered findings, or a
|
|
|
58
58
|
- Keep XML/Compose, UIKit/SwiftUI, and KMP/native interoperability explicit. Do not duplicate one visual rule across layers when an established shared source owns it.
|
|
59
59
|
- Do not weaken screenshot tests, previews, fixtures, assertions, test tags, resource IDs, content descriptions, or Maestro selectors to hide a mismatch.
|
|
60
60
|
- Modify tracked Maestro flows only when the selected finding explicitly identifies the flow as incorrect or missing and the user-approved scope includes that change.
|
|
61
|
-
9. Dispatch per `references/agent-orchestration.md`; the
|
|
61
|
+
9. Dispatch per `references/agent-orchestration.md`; the `code-reviewer` `verify` block below is tier-gated mandatory, not merely discretionary — carved out of ordinary delegation gating by that reference's Independent Verification Exception:
|
|
62
62
|
|
|
63
|
-
**Screen work —
|
|
63
|
+
**Screen work — unconditional in this workflow:** every task here fixes a user-facing screen, so the `designer` dispatch below always runs; it is not gated on a screen-work condition (Screen Implementation Exception in `references/agent-orchestration.md`). `designer` implements every UI-layer `MFM-*` fix; `builder` is dispatched only for an `MFM-*` finding whose fix needs non-UI-layer changes (navigation, data, resource or build wiring), with a write set disjoint from the designer's.
|
|
64
64
|
|
|
65
|
-
> **Dispatch: `
|
|
65
|
+
> **Dispatch: `designer`** (role: `designer`, mode: `implement`) — charter `skills/agents/designer/SKILL.md`
|
|
66
66
|
> - scope: the screens, views, components, layouts, styles, and design tokens in this task's UI surface — never the whole repository
|
|
67
67
|
> - permissions: write, scoped to UI-layer files only with a disjoint write set
|
|
68
68
|
> - output: per-element conformance table (element, expected, actual, verdict, severity) plus the UI files written; a missing or unreachable design source is listed as a skipped sensor, never a silent pass
|
|
69
69
|
|
|
70
|
-
> **Dispatch: `
|
|
71
|
-
> - trigger: a selected `MFM-*` finding
|
|
72
|
-
> - scope: one `MFM-*` finding, or a coherent surface group sharing one KMP root cause, with a disjoint
|
|
73
|
-
> - permissions: write (disjoint write set,
|
|
70
|
+
> **Dispatch: `builder`** (role: `builder`) — charter `skills/agents/builder/SKILL.md`
|
|
71
|
+
> - trigger: a selected `MFM-*` finding whose fix needs non-UI-layer changes (navigation, data, resource or build wiring) — never for a UI-layer fix, which belongs to `designer`
|
|
72
|
+
> - scope: the non-UI-layer part of one `MFM-*` finding, or of a coherent surface group sharing one KMP root cause, with a write set disjoint from the designer's
|
|
73
|
+
> - permissions: write (disjoint write set, non-UI-layer files only)
|
|
74
74
|
> - inputs: the finding's Surface ID, Figma value, resolved token/resource/asset chain, current implementation value, and simplest fix direction
|
|
75
75
|
> - sensors: the remediation matrix's assigned runtime sensor and optional Maestro packet for the surface
|
|
76
76
|
> - output: implementation summary, changed files, commands run, per-surface render evidence
|
|
77
77
|
> - firewall: raw diffs and screenshots summarized
|
|
78
78
|
> - memory: suggest-only; main agent persists reusable token/mapping patterns
|
|
79
79
|
|
|
80
|
-
> **Dispatch: `
|
|
80
|
+
> **Dispatch: `code-reviewer`** (role: `code-reviewer`, mode: `review`) — charter `skills/agents/code-reviewer/SKILL.md`
|
|
81
81
|
> - trigger: implementation complete, before the verification gate — never optional
|
|
82
82
|
> - scope: the fix's diff surface and its task/AC context
|
|
83
|
-
> - permissions: read-only
|
|
84
83
|
> - inputs: diff, acceptance context, recalled code-quality conventions
|
|
85
84
|
> - sensors: bugs, regressions, missing edge cases, smells introduced by the diff
|
|
86
85
|
> - output: ranked findings, blocking vs advisory; blocking findings become fix items before verification runs
|
|
87
86
|
> - firewall: summarized findings only, never raw diff dumps
|
|
88
87
|
> - memory: suggest-only; main agent persists
|
|
89
88
|
|
|
90
|
-
> **Dispatch: `
|
|
89
|
+
> **Dispatch: `code-reviewer`** (role: `code-reviewer`, mode: `verify`) — charter `skills/agents/code-reviewer/SKILL.md`
|
|
91
90
|
> - trigger: mandatory at Standard+/Spec-driven size or high/critical severity per the Independent Verification Mandate in `references/verification-ladder.md`; a Quick-tier finding runs the fallback fresh-eyes self-check below instead
|
|
92
91
|
> - scope: the fixed `MFM-*` finding's surface, resolved token/value, comparison-matrix row, and closure claim
|
|
93
92
|
> - inputs: the finding, the applied fix, the comparison-matrix row, the render sensor used, and validation assets
|
|
@@ -17,7 +17,7 @@ conflict with the base.
|
|
|
17
17
|
Use when the user explicitly asks to review a hosted PR (Pull Request, GitHub) or
|
|
18
18
|
MR (Merge Request, GitLab) — "review PR 128", "review this MR", "check pull request
|
|
19
19
|
42". Explicit route only: never auto-trigger during coding. Local working-tree diff
|
|
20
|
-
review stays with the audit workflows and `
|
|
20
|
+
review stays with the audit workflows and `code-reviewer`; this workflow exists
|
|
21
21
|
to **post findings back to the host**.
|
|
22
22
|
|
|
23
23
|
Load `references/project-context.md` (intake sweep) before the first substantive
|
|
@@ -142,19 +142,28 @@ the severity labels, and the reply contract.
|
|
|
142
142
|
|
|
143
143
|
| # | Dimension | Agent | Packet delta (lens / scope) | Marker `{type}` |
|
|
144
144
|
| --- | --- | --- | --- | --- |
|
|
145
|
-
| 1 | Security | `
|
|
146
|
-
| 2 | Requirements & DoD (Definition of Done) | `
|
|
147
|
-
| 3 | Architecture & conventions | `
|
|
148
|
-
| 4 | Performance | `
|
|
149
|
-
| 5 | Test coverage | `
|
|
150
|
-
| 6 | Regression & hallucination | `
|
|
145
|
+
| 1 | Security | `code-reviewer` | `lens: security` — secrets, authn/authz on new endpoints, injection, unsafe deserialization, PII in logs, permissive CORS, leaking payload fields | `security` |
|
|
146
|
+
| 2 | Requirements & DoD (Definition of Done) | `product-manager` | `mode: audit` — score merged Track A + Track B criteria against the diff, evidence-or-zero: ✅ implemented (`path:line`) / 🟡 partial / ❌ missing; no source ⇒ report "requirements verification skipped" | `requirements` |
|
|
147
|
+
| 3 | Architecture & conventions | `code-reviewer` | `lens: architecture` — extract every explicit rule from the profile's CONVENTIONS/REVIEW_SKILLS docs into a numbered matrix, grade each changed file PASS/VIOLATION/N/A; no docs ⇒ minimal generic boundary sweep, stated | `architecture` |
|
|
148
|
+
| 4 | Performance | `code-reviewer` | `lens: performance` — only issues clearly visible in the diff: N+1 queries, unbounded fetches, per-row lazy I/O, sequential awaits of independent calls, loop-invariant recomputation, unbatched writes | `performance` |
|
|
149
|
+
| 5 | Test coverage | `test-engineer` | `mode: audit` (dedicated tests lens: coverage, regression protection, assertion quality, variation — `tests-audit.md` precedent) — new/changed behavior with no test, wrong level (unit vs integration), placement/naming vs profile TEST row, missing negative case, missing variation beyond the fixture example, assertions that exercise but never assert | `tests` |
|
|
150
|
+
| 6 | Regression & hallucination | `code-reviewer` | `mode: review` — diff review — unrelated deletions, references to symbols absent from the repo, wrong signature/arity, duplicated existing logic, weakened error handling or assertions, leftover TODO/stub, dead code | `regression` |
|
|
151
151
|
|
|
152
152
|
Consolidation check (≥ 5 subagents): recorded in the feature design — rows 4 and 5
|
|
153
153
|
share only the lens label, not a knowledge domain; they stay separate dispatches.
|
|
154
154
|
|
|
155
|
-
> **Dispatch: `
|
|
156
|
-
> - trigger: pr-review Step 2, dimension rows 1
|
|
157
|
-
> - scope: the PR/MR diff and surrounding context for one dimension row; never the whole repository
|
|
155
|
+
> **Dispatch: `code-reviewer`** (role: `code-reviewer`, mode: `audit`) — charter `skills/agents/code-reviewer/SKILL.md`
|
|
156
|
+
> - trigger: pr-review Step 2, dimension rows 1, 3, and 4 (one dispatch per row)
|
|
157
|
+
> - scope: the PR/MR diff and surrounding context for one dimension row; never the whole repository; no host CLI calls, no posting
|
|
158
|
+
> - inputs: exact `projectId`, parent `workflowSessionId`, dimension row (lens + scope), DISCOVERY MAP, PR/MR intent, trimmed diff, existing-comment inventory, severity labels, reply contract
|
|
159
|
+
> - sensors: second-pass sweep — re-read the full trimmed diff, list every file/hunk not commented on, and state per file why it is clean for this dimension before returning
|
|
160
|
+
> - output: structured reply block — findings rows `{path, head-line, severity, marker type, title, body ≤ 6 lines, recommendation}` + exactly one positive highlight + files-swept-clean list; when uncertain a finding is real, withhold it (the source protocol's high-confidence bar, applied qualitatively)
|
|
161
|
+
> - firewall: raw diff/log/search output summarized, never returned raw
|
|
162
|
+
> - memory: suggest-only; the main agent persists durable outcomes
|
|
163
|
+
|
|
164
|
+
> **Dispatch: `product-manager`** (role: `product-manager`, mode: `audit`) — charter `skills/agents/product-manager/SKILL.md`
|
|
165
|
+
> - trigger: pr-review Step 2, dimension row 2 (requirements & DoD)
|
|
166
|
+
> - scope: the PR/MR diff and surrounding context for dimension row 2; never the whole repository
|
|
158
167
|
> - permissions: read-only; no host CLI calls, no posting
|
|
159
168
|
> - inputs: exact `projectId`, parent `workflowSessionId`, dimension row (lens + scope), DISCOVERY MAP, PR/MR intent, trimmed diff, existing-comment inventory, severity labels, reply contract
|
|
160
169
|
> - sensors: second-pass sweep — re-read the full trimmed diff, list every file/hunk not commented on, and state per file why it is clean for this dimension before returning
|
|
@@ -162,10 +171,19 @@ share only the lens label, not a knowledge domain; they stay separate dispatches
|
|
|
162
171
|
> - firewall: raw diff/log/search output summarized, never returned raw
|
|
163
172
|
> - memory: suggest-only; the main agent persists durable outcomes
|
|
164
173
|
|
|
165
|
-
> **Dispatch: `
|
|
166
|
-
> - trigger: pr-review Step 2, dimension row
|
|
167
|
-
> - scope: the
|
|
174
|
+
> **Dispatch: `test-engineer`** (role: `test-engineer`, mode: `audit`) — charter `skills/agents/test-engineer/SKILL.md`
|
|
175
|
+
> - trigger: pr-review Step 2, dimension row 5 (test coverage)
|
|
176
|
+
> - scope: the PR/MR diff and surrounding context for dimension row 5; never the whole repository
|
|
168
177
|
> - permissions: read-only; no host CLI calls, no posting
|
|
178
|
+
> - inputs: exact `projectId`, parent `workflowSessionId`, dimension row (lens + scope), DISCOVERY MAP, PR/MR intent, trimmed diff, existing-comment inventory, severity labels, reply contract
|
|
179
|
+
> - sensors: second-pass sweep — re-read the full trimmed diff, list every file/hunk not commented on, and state per file why it is clean for this dimension before returning
|
|
180
|
+
> - output: structured reply block — findings rows `{path, head-line, severity, marker type, title, body ≤ 6 lines, recommendation}` + exactly one positive highlight + files-swept-clean list; when uncertain a finding is real, withhold it (the source protocol's high-confidence bar, applied qualitatively)
|
|
181
|
+
> - firewall: raw diff/log/search output summarized, never returned raw
|
|
182
|
+
> - memory: suggest-only; the main agent persists durable outcomes
|
|
183
|
+
|
|
184
|
+
> **Dispatch: `code-reviewer`** (role: `code-reviewer`, mode: `review`) — charter `skills/agents/code-reviewer/SKILL.md`
|
|
185
|
+
> - trigger: pr-review Step 2, dimension row 6 (regression & hallucination)
|
|
186
|
+
> - scope: the full PR/MR diff against the repository's real symbol surface; no host CLI calls, no posting
|
|
169
187
|
> - inputs: exact `projectId`, parent `workflowSessionId`, dimension row 6, DISCOVERY MAP, PR/MR intent, full diff, existing-comment inventory, severity labels, reply contract
|
|
170
188
|
> - sensors: verify referenced symbols exist (`search_definitions`/`get_references` when INDEX is fresh, else grep); second-pass sweep as above
|
|
171
189
|
> - output: structured reply block — findings rows tagged `{unrelated-deletion | phantom-reference | wrong-signature | duplicate | weakened-check | dead-code}` + one positive highlight + files-swept-clean list; withhold uncertain findings
|