@massa-ai/codex-plugin 1.35.0 → 1.35.1

package/skills/massa-ai/workflows/security/security-fix.md

@@ -3,7 +3,7 @@ name: security-fix
 description: "Executes fixes from a saved security audit report; not for findings-only security review or generic correctness fixes outside an exploitable path."
 license: MIT
 metadata:
-  version: "1.1.0"
+  version: "1.2.0"
 ---
 
 ### Security Fix
@@ -12,7 +12,7 @@ Execute fixes from a security audit markdown report only.
 
 Load `references/project-context.md` (intake sweep) before the first substantive read.
 
-Before the first repository mutation, load `references/implementation-delivery.md` (delivery chain: worktree, atomic commits, PR, CI watch, merge gate) and `references/code-annotation.md` (doc blocks, rationale, test coverage). After two consecutive failed fixes on one symptom, stop editing and load `references/root-cause-scripts.md`.
+Before the first repository mutation, load `references/implementation-delivery.md` (delivery chain: worktree, atomic commits, PR, CI watch, merge gate — its Stage 3 delivery-authorization scope covers one go-ahead through PR creation; force-push/deploy/merge stay separately gated) and `references/code-annotation.md` (doc blocks, rationale, test coverage). After two consecutive failed fixes on one symptom, stop editing and load `references/root-cause-scripts.md`.
 
 **Isolation Gate — before the first file edit:** execute `references/implementation-delivery.md` Stage 0–1 now (fetch base, create the worktree + branch, work inside it) and record the worktree path + branch — or one of Stage 1's two legal skip reasons, verbatim — before any repository mutation.
 
@@ -22,11 +22,14 @@ Not for findings-only security review — route to `workflows/security/security-
 2. Load shared references:
    - `references/audit-report-io.md` before any code change
    - `references/lessons.md` to load confirmed project lessons
-   - `references/codebase-investigation.md` before changing unfamiliar security boundaries
+   - `references/codebase-investigation.md` before changing unfamiliar security boundaries; that trigger also gates `.specs/project/onboarding/CONCERNS.md` — consult it before working the finding
    - `references/mobile-context.md` when the report target touches KMP, iOS, Android, native bridges, mobile permissions, secure storage, biometrics, deep links, push/background behavior, local persistence, offline queues, logs/crash privacy, or backend-mobile contracts
    - `references/verification-ladder.md` before non-trivial edits
    - `references/context-firewall.md` before inspecting large diffs, logs, generated reports, or broad search output
    - `references/agent-orchestration.md` only for large/high-risk findings, disjoint implementation slices, or independent verification
+   - `references/discrimination-sensor.md` before closing any SEC finding under the Mandatory Verification Fix Gate — its Mutation Target table names the guard just added as the security row
+   - `references/knowledge-verification-chain.md` when a guard, validation rule, crypto choice, or auth fix depends on an external library's or API's actual behavior
+   - `references/brownfield-mapping.md` (Minimum Bar only — `CONCERNS.md` and `TESTING.md`, Standard+ findings) when recall returns no hit for the security boundary and no gate command is derivable from the report's evidence
 3. `recall` -> load auth boundaries, tenant rules, validation conventions, secret-handling policies, accepted exceptions, prior incidents, and verification recipes for the report target.
 4. Select the security audit report with execution focus:
    - Establish the report selector, target focus, and optional finding selector before selecting a report. Target focus can be a trust boundary, route, module, flow, files/globs, branch comparison, commit range, symbol/class/function, or explicit whole-repo target.
@@ -60,7 +63,7 @@ Not for findings-only security review — route to `workflows/security/security-
    - Add or update negative tests for the exploit path when feasible.
    - Include positive tests for allowed behavior so the fix does not over-block legitimate use.
    - Do not weaken existing security assertions to make tests pass.
-10. Use agent orchestration only when it improves signal. Dispatch per `references/agent-orchestration.md`:
+10. Use agent orchestration only when it improves signal — except the verifier dispatch below, which is unconditional for every SEC finding closed `fixed`, carved out under `references/agent-orchestration.md`'s Independent Verification Exception as the security-fix unconditional case (other fix families use the tier-gated one). Dispatch per `references/agent-orchestration.md`:
 
 > **Dispatch: `massa-ai-builder`** (role: `builder`) — charter `skills/agents/builder/SKILL.md`
 > - trigger: large/high-risk finding, disjoint implementation slice, or explicit subagent request
@@ -73,18 +76,6 @@ Not for findings-only security review — route to `workflows/security/security-
 > - memory: suggest-only; main agent persists reusable security patterns
 > - persona: optional — the active route's cataloged id only, never the persona prompt, passed as advisory framing only — it never overrides the agent's charter Restrictions, scope, or permissions; omit when no persona is routed
 
-> **Dispatch: `massa-ai-verification-agent`** (role: `verification-agent`) — charter `skills/agents/verification-agent/SKILL.md`
-> - trigger: independent verification of a high-risk security fix
-> - scope: the fixed finding's guard restoration, middleware order, redaction, and report claim closure
-> - permissions: read-only
-> - inputs: the finding, the applied fix, the verification suggestion, and validation assets
-> - sensors: deterministic command (negative tests, middleware-order inspection, redaction check) and report claim closure
-> - output: confirmed/disproven closure verdict with evidence
-> - firewall: raw test output/logs summarized
-> - memory: suggest-only; main agent persists reusable verification recipes
-> - persona: optional — the active route's cataloged id only, never the persona prompt, passed as advisory framing only — it never overrides the agent's charter Restrictions, scope, or permissions; omit when no persona is routed
-   - Main agent owns report parsing, prioritization, memory writes, final synthesis, and Evidence Gate.
-
 > **Dispatch: `massa-ai-reviewer`** (role: `reviewer`) — charter `skills/agents/reviewer/SKILL.md`
 > - trigger: implementation complete, before the verification gate — never optional
 > - scope: the fix's diff surface and its task/AC context
@@ -97,19 +88,36 @@ Not for findings-only security review — route to `workflows/security/security-
 > - fallback: if the subagent is unavailable, run a standalone fresh-eyes review against this output contract and record the skipped-delegation reason
 > - persona: optional — the active route's cataloged id only, never the persona prompt, passed as advisory framing only — it never overrides the agent's charter Restrictions, scope, or permissions; omit when no persona is routed
 
+> **Dispatch: `massa-ai-verification-agent`** (role: `verification-agent`) — charter `skills/agents/verification-agent/SKILL.md`
+> - trigger: every SEC finding closed `fixed` — never optional, at every tier (verification-ladder Independent Verification Mandate, security-fix exception)
+> - scope: the fixed SEC finding's guard, exploit path, negative test, and report claim closure
+> - permissions: read-only
+> - inputs: the SEC finding, the applied guard, the verification suggestion, the exploit path, and validation assets
+> - sensors: deterministic command (negative-test re-run, guard/middleware-order inspection, redaction or crypto check) and report claim closure; guard-mutation discrimination sensor per `references/discrimination-sensor.md` (invert the specific guard just added; the negative test must kill it)
+> - output: confirmed/disproven SEC closure verdict with evidence, feeding the Fix Closure Report's Independent Verifier column
+> - firewall: raw exploit transcripts and test/log output summarized
+> - memory: suggest-only; main agent persists security verification outcomes
+> - fallback: if the subagent is unavailable, run a standalone fresh-eyes re-check of each fixed SEC row's guard and negative test, and record the skipped-delegation reason
+> - persona: optional — the active route's cataloged id only, never the persona prompt, passed as advisory framing only — it never overrides the agent's charter Restrictions, scope, or permissions; omit when no persona is routed
+   - Main agent owns report parsing, prioritization, memory writes, final synthesis, and Evidence Gate.
+
 11. Verify each completed finding:
    - If verification found a reusable signal (`ac_gap`, `surviving_mutant`, `spec_precision_gap`, `spec_deviation`, `gate_fail`), record it via `references/lessons.md`:
      `bun skills/massa-ai/scripts/lessons.ts --root . add --feature "<slug>" --signal "<signal>" --source "<ref>" --text "<one terse lesson>"`
    - Apply the Mandatory Verification Fix Gate from `references/verification-ladder.md`: run the report's Verification Suggestion or an equivalent deterministic command/artifact check for each selected finding or coherent group.
    - A finding cannot be marked `fixed` when a target-relevant command or artifact check exists but was not attempted; if verification cannot run, mark it `blocked`, `deferred`, or `skipped` with an allowed skipped-check reason.
    - Run the report's verification suggestion when available.
+   - At Standard+ size or high/critical severity, run the guard-mutation discrimination sensor per `references/discrimination-sensor.md`: invert the specific guard just added and confirm the negative test kills it; a surviving mutant marks the finding's Closure Matrix row `blocked` and records the `surviving_mutant` lessons signal even when the exploit-path test is green.
+   - The fix→re-verify cycle is capped per `references/verification-ladder.md`'s Bounded Fix→Re-verify Loop at 3 iterations; that counter is separate from the two-consecutive-failed-fixes breaker into `references/root-cause-scripts.md` named in this file's preamble, which fires inside a single edit iteration and neither consumes nor resets the loop count.
    - Run targeted tests for negative and positive paths, plus lint/type/build checks relevant to touched files.
    - Inspect logs/config/errors when the finding involves data exposure.
    - Record command/artifact, result, skipped reason or `none`, highest Verification Ladder level reached, validation assets protected, and residual risk.
 12. At completion, persist only durable knowledge:
    - Security boundary decisions, accepted exceptions, reusable exploit-path tests, or incident-prevention patterns after scoring with the Importance Calibration System.
+   - When step 2's unfamiliar-security-boundary trigger fired for this finding, append any newly discovered security hotspot to `.specs/project/onboarding/CONCERNS.md` — the same wiring that required consulting it before working the finding.
    - Use required tags: `project:<projectId>`, `session:<workflowSessionId>`, `workflow:security-fix`, `entity:<entity>`, and one `memory:<tier>` tag.
-13. Complete the Evidence Gate from `references/evidence-gate.md`.
+13. Write the Fix Closure Report per `references/audit-report-io.md`'s Fix Closure Report Contract, at `audits/security/<YYYY-MM-DD security-fix-closure>.md`, sibling of the consumed audit report; then run `bun skills/massa-ai/scripts/check_fix_closure.ts <closure.md> --family security` before Propose and the Evidence Gate — a non-zero exit blocks both. If no code-execution tool is available, run the same checks by reading the artifact (graceful degradation preserved).
+14. Complete the Evidence Gate from `references/evidence-gate.md`. Urgency does not expand delivery authorization: hotfix pressure never widens the Stage 3 one-go-ahead-through-PR-creation scope named in this file's preamble, and force-push, deploy, and merge stay separately gated regardless of severity.
 
 ## Examples
 
@@ -120,3 +128,6 @@ User asks: "Use security-fix to fix latest audit findings for user routes."
 3. Fix critical/high exploit paths first.
 4. Add negative tests for denied access, invalid input, or redacted output.
 5. Run deterministic tests and report residual security risk.
+
+<!-- validator anchors: every SEC finding closed `fixed` — never optional, at every tier | guard-mutation discrimination sensor | Fix Closure Report Contract | security-fix-closure | consult it before working the finding | append any newly discovered security hotspot | Urgency does not expand delivery authorization | Bounded Fix→Re-verify Loop | graceful degradation preserved -->
+

package/skills/massa-ai/workflows/spec-driven.md

@@ -136,7 +136,7 @@ Quick artifacts live under `.specs/quick/NNN-slug/` with a `TASK.md` (one-line i
 > - persona: optional — the active route's cataloged id only, never the persona prompt, passed as advisory framing only — it never overrides the agent's charter Restrictions, scope, or permissions; omit when no persona is routed
 
     - The verification-agent re-derives coverage independently using evidence-or-zero and does not inherit the author's mental model.
-   - The fix → re-verify loop is capped at 3 iterations before escalating to `Blocked`.
+   - The fix → re-verify loop is bounded by the Bounded Fix→Re-verify Loop rule in `references/verification-ladder.md` (cap reached → `Blocked`).
    - Distill lesson signals through `references/lessons.md` when validation produces grounded reusable failures.
 7. Before the delivery chain's Propose stage (PR creation), write and commit `.specs/project/STATE.md`, `.specs/HANDOFF.md`, and `.specs/project/FEATURES.json` on the branch — not merely "after meaningful progress" during Execute, but committed before `gh pr create`. **Deterministic backing (run it, do not eyeball it):** `bun skills/massa-ai/scripts/check_specs_delivered.ts <feature> [--root .]` — a non-zero exit blocks Propose (see `references/implementation-delivery.md` stage 3.5 and GATE-02). If no code-execution tool is available, run the same checks by reading the artifact (graceful degradation preserved). Record decisions, blockers, handoff, and completion evidence per `references/spec-driven/memory.md`'s write triggers.
 8. When the user splits planning and implementation across clean chats, resume from the canonical `.specs/` artifacts — `.specs/project/STATE.md`, `.specs/project/FEATURES.json`, `.specs/HANDOFF.md`, and the feature's phase files. This workflow owns the spec phase contracts on both sides of the split; there is no separate save/load procedure.
@@ -164,32 +164,15 @@ Quick artifacts live under `.specs/quick/NNN-slug/` with a `TASK.md` (one-line i
 - Validation command unavailable: record the missing command/tool in `validation.md` and mark `Blocked`.
 - Discrimination sensor cannot be made safely reversible: mark `Blocked` unless the verification-agent can prove equivalent discrimination with an existing deterministic mutation fixture.
 - Validation conflict: stop for user resolution when a validation asset conflicts with an approved specification.
-- Fix loop exceeds 3 iterations: stop with `Blocked`, preserve evidence, and ask for direction.
+- Fix loop reaches the `references/verification-ladder.md` cap: stop with `Blocked`, preserve evidence, and ask for direction.
 
 ## Knowledge Verification Chain
 
-When researching, designing, or making any technical decision, follow this chain in strict order. Never skip steps.
-
-```
-Step 1: Codebase → existing code, conventions, patterns already in use
-Step 2: Project docs (leads, not truth) → README, docs/, inline comments, .specs/project/STATE.md (Decisions) — verify against current source before relying
-Step 3: Context7 MCP → resolve library ID, then query for current API/patterns
-Step 4: Web search → official docs, reputable sources, community patterns
-Step 5: Flag as uncertain → "I'm not certain about X — here's my reasoning, but verify"
-```
-
-- If a chain step's tool is unavailable (Context7 MCP not registered, no web
-  access), record it as a skipped sensor with its reason and continue to the next
-  step. An unavailable step is skipped, never silently treated as answered.
-- Never skip to Step 5 if Steps 1-4 are available.
-- Step 5 is always flagged uncertain — never presented as fact.
-- Never assume or fabricate. If no answer is found, say "I don't know" or "I couldn't find documentation for this". Uncertainty is always preferable to fabrication; invented APIs/patterns cause cascading failures across design → tasks → implementation.
+When researching, designing, or making any technical decision, follow the 5-step chain in `references/knowledge-verification-chain.md` in strict order — codebase, project docs, Context7 MCP, web search, then flag-as-uncertain. Never skip steps, record an unavailable step as a skipped sensor with its reason, and never present Step 5 output as fact.
 
 ## Brownfield Onboarding — 7-Doc Codebase Mapping
 
-When the spec-driven work targets a codebase the agent has not yet mapped (brownfield, new repo, or cold project), derive the 7-doc codebase map from `references/spec-driven/brownfield-mapping.md` before Specify closes — not busywork, each doc feeds a downstream phase.
-
-Minimum bar: derive at least **`CONCERNS.md`** (risk surface — drives risk-domain escalation and validation focus) and **`TESTING.md`** (gate derivation — exact commands the Execute gate will run). If time or access is constrained, these two are non-negotiable; the other five are derived as the work needs them. Record the map under `.specs/features/<slug>/` (or the project onboarding dir) and confirm it against current source, not memory or external summaries.
+When the spec-driven work targets a codebase the agent has not yet mapped (brownfield, new repo, or cold project), derive the 7-doc codebase map from `references/brownfield-mapping.md` before Specify closes — not busywork, each doc feeds a downstream phase. That reference's **Minimum Bar** (CONCERNS.md + TESTING.md non-negotiable) applies; record the map under `.specs/features/<slug>/` per its output-path rule.
 
 ## Commands
 

package/skills/massa-ai/workflows/tests/tests-fix.md

@@ -3,7 +3,7 @@ name: tests-fix
 description: "Executes fixes from a saved tests audit report; not for findings-only coverage review or generic test-writing work without an audit report."
 license: MIT
 metadata:
-  version: "1.1.0"
+  version: "1.2.0"
 ---
 
 ### Tests Fix
@@ -12,7 +12,7 @@ Execute fixes from a tests audit markdown report only.
 
 Load `references/project-context.md` (intake sweep) before the first substantive read.
 
-Before the first repository mutation, load `references/implementation-delivery.md` (delivery chain: worktree, atomic commits, PR, CI watch, merge gate) and `references/code-annotation.md` (doc blocks, rationale, test coverage). After two consecutive failed fixes on one symptom, stop editing and load `references/root-cause-scripts.md`.
+Before the first repository mutation, load `references/implementation-delivery.md` (delivery chain: worktree, atomic commits, PR, CI watch, merge gate — one go-ahead covers local commits through PR creation only, force-push/deploy/merge stay separately gated per `references/audit-report-io.md`'s Execution Report Input) and `references/code-annotation.md` (doc blocks, rationale, test coverage). After two consecutive failed fixes on one symptom, stop editing and load `references/root-cause-scripts.md`.
 
 **Isolation Gate — before the first file edit:** execute `references/implementation-delivery.md` Stage 0–1 now (fetch base, create the worktree + branch, work inside it) and record the worktree path + branch — or one of Stage 1's two legal skip reasons, verbatim — before any repository mutation.
 
@@ -25,8 +25,11 @@ Not for findings-only test coverage, assertion quality, fixture health, flakines
    - `references/codebase-investigation.md` before changing unfamiliar tests or fixtures
    - `references/mobile-context.md` when the report target touches KMP, iOS, Android, native bridges, mobile lifecycle, offline sync, permissions, local persistence, UI snapshots/screenshots, or backend-mobile contracts
    - `references/verification-ladder.md` before non-trivial edits
+   - `references/discrimination-sensor.md` before closing a TST finding at Standard+/Spec-driven size or high/critical severity, to size the mutation-target sensor against the new or repaired test's subject code
+   - `references/knowledge-verification-chain.md` when the fix direction depends on an external test framework's or assertion library's current behavior rather than in-repo convention
    - `references/context-firewall.md` before inspecting large logs, snapshots, generated reports, or broad search output
    - `references/agent-orchestration.md` only for large/high-risk findings, disjoint implementation slices, or independent verification
+   - `references/brownfield-mapping.md` (Minimum Bar's `TESTING.md` only — the report's `Regression Risk` field already covers `CONCERNS.md`) when recall returns no hit for the target test suite/harness and no gate command is derivable from the report's evidence, for Standard+ findings
 3. `recall` -> load testing conventions, mock boundaries, test frameworks, prior flaky tests, known regressions, accepted exceptions, and reusable verification recipes for the report target.
 4. Select the tests audit report with execution focus:
    - Establish the report selector, target focus, and optional finding selector before selecting a report. Target focus can be a behavior, flow, module, test suite, files/globs, branch comparison, commit range, symbol/class/function, or explicit whole-repo target.
@@ -41,8 +44,9 @@ Not for findings-only test coverage, assertion quality, fixture health, flakines
    - If the user supplied finding IDs, extract only those IDs after validating they exist and match the current target focus.
    - Rank by regression risk, severity, dependency order, and determinism.
 6. Build a coverage execution map before editing:
-   - Finding ID -> behavior under test, missing/weak assertion, fixture/mock boundary, deterministic harness, validation asset, expected failure before fix when possible, and verification command.
+   - Finding ID -> behavior under test, missing/weak assertion, fixture/mock boundary, deterministic harness, validation asset, expected failure before fix when possible, verification command, and discrimination sensor result.
    - Separate missing coverage, weak assertion, fixture drift, flakiness, skipped test, and missing deterministic sensor findings.
+   - Keep this map current through closure: filled in, it is the pre-edit draft of the Fix Closure Report's Closure Matrix, one row per finding.
    - For mobile findings, include KMP/shared vs platform-specific boundary, native bridge payload or backend-mobile contract, Android/iOS harness, device matrix or simulator/emulator assumptions, platform parity expectation, and skipped platform checks from `references/mobile-context.md`.
 7. Size each finding with `references/verification-ladder.md`:
    - Quick: local test addition, assertion strengthening, fixture field correction, or focused skipped-test restoration.
@@ -73,6 +77,18 @@ Not for findings-only test coverage, assertion quality, fixture health, flakines
 > - fallback: if the subagent is unavailable, run a standalone fresh-eyes review against this output contract and record the skipped-delegation reason
 > - persona: optional — the active route's cataloged id only, never the persona prompt, passed as advisory framing only — it never overrides the agent's charter Restrictions, scope, or permissions; omit when no persona is routed
 
+> **Dispatch: `massa-ai-verification-agent`** (role: `verification-agent`) — charter `skills/agents/verification-agent/SKILL.md`
+> - trigger: mandatory per the verification-ladder's Independent Verification Mandate for any TST finding closed at Standard+/Spec-driven size or high/critical severity; at Quick size the subagent hop is skipped and the standalone fresh-eyes assertion re-check below runs instead
+> - scope: the fixed TST finding's assertion strength, fixture/mock boundary, coverage-execution-map row, and report claim closure
+> - permissions: read-only
+> - inputs: the finding, the applied test change, the coverage execution map row, the verification command, and validation assets
+> - sensors: deterministic command (focused test run, assertion inspection, fixture-not-weakened check) against the coverage execution map row; discrimination sensor per `references/discrimination-sensor.md` (mutate the new/repaired test's subject; the test must kill it)
+> - output: confirmed/disproven TST closure verdict with assertion evidence
+> - firewall: raw test output/logs summarized
+> - memory: suggest-only; main agent persists tests-closure verification outcomes
+> - fallback: if the subagent is unavailable, run a standalone fresh-eyes re-check of each TST closure row's assertion evidence and record the skipped-delegation reason
+> - persona: optional — the active route's cataloged id only, never the persona prompt, passed as advisory framing only — it never overrides the agent's charter Restrictions, scope, or permissions; omit when no persona is routed
+
 10. Use strict harness sensors:
    - Never rely on AI subjective evaluation.
    - If verification found a reusable signal (`ac_gap`, `surviving_mutant`, `spec_precision_gap`, `spec_deviation`, `gate_fail`), record it via `references/lessons.md`:
@@ -82,7 +98,10 @@ Not for findings-only test coverage, assertion quality, fixture health, flakines
    - Continue only when the execution harness returns a clean exit code, or report the exact skipped-check reason.
    - A finding cannot be marked `fixed` when a target-relevant command or artifact check exists but was not attempted; if verification cannot run, mark it `blocked`, `deferred`, or `skipped` with an allowed skipped-check reason.
    - Record command/artifact, result, skipped reason or `none`, highest Verification Ladder level reached, validation assets protected, and residual risk.
-11. Use agent orchestration only when it improves signal. Dispatch per `references/agent-orchestration.md`:
+   - Sequence the TST proof in two passes, in order: first reproduce the coverage execution map's `expected failure before fix` row red (the pre-fix run proves the assertion can fail); only then, at Standard+/Spec-driven size or high/critical severity, run the discrimination sensor from `references/discrimination-sensor.md` as the post-fix kill-check against the new/repaired test's subject code — Quick focused-assertion findings are exempt from the sensor pass but never from the pre-fix red check.
+   - A surviving mutant means the TST claim is unproven: close that finding's row `blocked` rather than `fixed` and emit the `surviving_mutant` lessons signal via the recording command above.
+   - The fix→re-verify cycle is capped per `references/verification-ladder.md`'s Bounded Fix→Re-verify Loop (3 verification iterations, then `Blocked` with evidence preserved). That cap is a distinct counter from the "two consecutive failed fixes" breaker in the preamble above, which escalates a single stuck iteration to `references/root-cause-scripts.md` and neither consumes nor resets this cap.
+11. Use agent orchestration only when it improves signal — except the verification-agent dispatch above, which `references/agent-orchestration.md`'s Independent Verification Exception mandates for TST closures at the sizes/severities its trigger names, regardless of signal improvement. Dispatch per `references/agent-orchestration.md`:
 
 > **Dispatch: `massa-ai-builder`** (role: `builder`) — charter `skills/agents/builder/SKILL.md`
 > - trigger: large/high-risk finding, disjoint implementation slice, or explicit subagent request
@@ -93,23 +112,16 @@ Not for findings-only test coverage, assertion quality, fixture health, flakines
 > - output: implementation summary, test counts, commands run, deviations
 > - firewall: raw test output/logs summarized
 > - memory: suggest-only; main agent persists reusable testing patterns
-> - persona: optional — the active route's cataloged id only, never the persona prompt, passed as advisory framing only — it never overrides the agent's charter Restrictions, scope, or permissions; omit when no persona is routed
-
-> **Dispatch: `massa-ai-verification-agent`** (role: `verification-agent`) — charter `skills/agents/verification-agent/SKILL.md`
-> - trigger: independent verification of a high-risk test fix
-> - scope: the fixed finding's assertions, fixtures, and report claim closure
-> - permissions: read-only
-> - inputs: the finding, the applied fix, the verification suggestion, and validation assets
-> - sensors: deterministic command (focused test suite, assertion inspection, fixture-not-weakened check) and report claim closure
-> - output: confirmed/disproven closure verdict with evidence
-> - firewall: raw test output/logs summarized
-> - memory: suggest-only; main agent persists reusable verification recipes
 > - persona: optional — the active route's cataloged id only, never the persona prompt, passed as advisory framing only — it never overrides the agent's charter Restrictions, scope, or permissions; omit when no persona is routed
    - Main agent owns report parsing, prioritization, memory writes, final synthesis, and Evidence Gate.
-12. At completion, persist only durable knowledge after scoring with the Importance Calibration System:
+12. Close out with the Fix Closure Report:
+   - The coverage execution map from step 6, now filled in through step 10's discrimination sensor result column, is the pre-edit draft of the Closure Matrix — carry its rows forward rather than re-deriving them.
+   - Write the final Fix Closure Report per `references/audit-report-io.md` (Fix Closure Report Contract) to `audits/tests/<YYYY-MM-DD tests-fix-closure>.md`, one Closure Matrix row per selected TST finding.
+   - Run `bun skills/massa-ai/scripts/check_fix_closure.ts <closure.md> --family tests` before Propose/Evidence Gate; a non-zero exit blocks Propose. If no code-execution tool is available, run the same checks by reading the artifact (graceful degradation preserved).
+13. At completion, persist only durable knowledge after scoring with the Importance Calibration System:
    - Testing conventions, deterministic harness recipes, flaky-test root causes, accepted exceptions, or reusable edge-case coverage patterns.
    - Use required tags: `project:<projectId>`, `session:<workflowSessionId>`, `workflow:tests-fix`, `entity:<entity>`, and one `memory:<tier>` tag.
-13. Complete the Evidence Gate from `references/evidence-gate.md`; do not mark tests complete without a clean deterministic exit code or explicit skipped-check reason.
+14. Complete the Evidence Gate from `references/evidence-gate.md`; do not mark tests complete without a clean deterministic exit code or explicit skipped-check reason.
 
 ## Examples
 
@@ -120,3 +132,5 @@ User asks: "Use tests-fix to fix latest audit findings for report scheduling."
 3. Map each finding to missing coverage, weak assertions, fixture drift, flakiness, or missing sensor work.
 4. Add or repair deterministic tests without weakening validation assets.
 5. Run focused tests and report broader skipped checks when needed.
+
+<!-- validator anchors: references/discrimination-sensor.md | references/knowledge-verification-chain.md | references/brownfield-mapping.md (Minimum Bar's TESTING.md only) | Independent Verification Exception | mandatory per the verification-ladder's Independent Verification Mandate for any TST finding | discrimination sensor per references/discrimination-sensor.md (mutate the new/repaired test's subject; the test must kill it) | Sequence the TST proof in two passes | surviving_mutant lessons signal | Bounded Fix→Re-verify Loop | Fix Closure Report Contract | audits/tests/<YYYY-MM-DD tests-fix-closure>.md | bun skills/massa-ai/scripts/check_fix_closure.ts <closure.md> --family tests | graceful degradation preserved -->

package/skills/massa-ai/references/spec-driven/brownfield-mapping.md

@@ -1,16 +0,0 @@
-# Brownfield Onboarding — 7-Doc Codebase Mapping
-
-Use from `workflows/spec-driven.md` when the target codebase
-has not yet been mapped (brownfield, new repo, or cold project). The map is
-the shared factual ground for requirements, design, and task derivation;
-each doc feeds a downstream phase.
-
-| Doc | Derives | Feeds |
-| --- | --- | --- |
-| `STACK.md` | languages, runtimes, frameworks, key libraries | Design constraints, verification commands |
-| `ARCHITECTURE.md` | layers, modules, boundaries, data flow | Design, risk surface |
-| `CONVENTIONS.md` | naming, file layout, commit/test conventions | Tasks, Execute |
-| `STRUCTURE.md` | directory map, where new code goes | Tasks, file placement |
-| `TESTING.md` | test runner, how to run gates, coverage tooling | Gate Check Commands, verification recipe |
-| `INTEGRATIONS.md` | external services, APIs, contracts, auth | Discuss, risk escalation |
-| `CONCERNS.md` | known risks, tech debt, migration landmines, security/privacy hotspots | Risk-domain escalation, validation focus |