@massa-ai/claude-plugin 1.62.0 → 1.63.1
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/.claude-plugin/plugin.json +1 -1
- package/README.md +1 -1
- package/agent-profiles/balanced/code-explorer.md +11 -22
- package/agent-profiles/balanced/code-reviewer.md +21 -51
- package/agent-profiles/balanced/designer.md +22 -35
- package/agent-profiles/balanced/judge.md +21 -81
- package/agent-profiles/balanced/product-manager.md +11 -24
- package/agent-profiles/balanced/{builder.md → senior-engineer.md} +3 -3
- package/agent-profiles/balanced/test-engineer.md +11 -47
- package/agent-profiles/cheap/code-explorer.md +11 -22
- package/agent-profiles/cheap/code-reviewer.md +21 -51
- package/agent-profiles/cheap/designer.md +22 -35
- package/agent-profiles/cheap/judge.md +21 -81
- package/agent-profiles/cheap/product-manager.md +11 -24
- package/agent-profiles/cheap/{builder.md → senior-engineer.md} +3 -3
- package/agent-profiles/cheap/test-engineer.md +11 -47
- package/agent-profiles/heavy/code-explorer.md +11 -22
- package/agent-profiles/heavy/code-reviewer.md +21 -51
- package/agent-profiles/heavy/designer.md +22 -35
- package/agent-profiles/heavy/judge.md +21 -81
- package/agent-profiles/heavy/product-manager.md +11 -24
- package/agent-profiles/{work/builder.md → heavy/senior-engineer.md} +3 -3
- package/agent-profiles/heavy/test-engineer.md +11 -47
- package/agent-profiles/home/code-explorer.md +11 -22
- package/agent-profiles/home/code-reviewer.md +21 -51
- package/agent-profiles/home/designer.md +22 -35
- package/agent-profiles/home/judge.md +21 -81
- package/agent-profiles/home/product-manager.md +11 -24
- package/{agents/builder.md → agent-profiles/home/senior-engineer.md} +3 -3
- package/agent-profiles/home/test-engineer.md +11 -47
- package/agent-profiles/work/code-explorer.md +11 -22
- package/agent-profiles/work/code-reviewer.md +21 -51
- package/agent-profiles/work/designer.md +22 -35
- package/agent-profiles/work/judge.md +21 -81
- package/agent-profiles/work/product-manager.md +11 -24
- package/agent-profiles/{heavy/builder.md → work/senior-engineer.md} +3 -3
- package/agent-profiles/work/test-engineer.md +11 -47
- package/agents/code-explorer.md +11 -22
- package/agents/code-reviewer.md +21 -51
- package/agents/designer.md +22 -35
- package/agents/judge.md +21 -81
- package/agents/product-manager.md +11 -24
- package/{agent-profiles/home/builder.md → agents/senior-engineer.md} +3 -3
- package/agents/test-engineer.md +11 -47
- package/install.sh +6 -6
- package/package.json +1 -1
- package/skills/agents/code-explorer/SKILL.md +11 -22
- package/skills/agents/code-reviewer/SKILL.md +21 -51
- package/skills/agents/designer/SKILL.md +22 -35
- package/skills/agents/judge/SKILL.md +21 -81
- package/skills/agents/product-manager/SKILL.md +11 -24
- package/skills/agents/{builder → senior-engineer}/SKILL.md +3 -3
- package/skills/agents/test-engineer/SKILL.md +11 -47
- package/skills/massa-ai/SKILL.md +61 -204
- package/skills/massa-ai/references/agent-modes/designer/audit.md +22 -0
- package/skills/massa-ai/references/agent-modes/designer/implement.md +29 -0
- package/skills/massa-ai/references/agent-modes/designer/trace.md +41 -0
- package/skills/massa-ai/references/agent-modes/judge/plan-critique-full.md +13 -0
- package/skills/massa-ai/references/agent-modes/judge/plan-critique-lite.md +13 -0
- package/skills/massa-ai/references/agent-modes/judge/scorer.md +31 -0
- package/skills/massa-ai/references/agent-modes/judge/spec-author.md +28 -0
- package/skills/massa-ai/references/agent-modes/test-engineer/audit.md +17 -0
- package/skills/massa-ai/references/agent-modes/test-engineer/fix.md +14 -0
- package/skills/massa-ai/references/agent-orchestration.md +5 -4
- package/skills/massa-ai/references/figma-pre-analysis.md +1 -1
- package/skills/massa-ai/references/spec-driven/specify.md +1 -1
- package/skills/massa-ai/references/spec-driven/sub-agents.md +1 -0
- package/skills/massa-ai/references/subagent-design.md +1 -0
- package/skills/massa-ai/references/verification-ladder.md +1 -1
- package/skills/massa-ai/workflows/architecture/architecture-fix.md +3 -3
- package/skills/massa-ai/workflows/bugs/bugs-fix.md +3 -3
- package/skills/massa-ai/workflows/code-quality/code-quality-fix.md +3 -3
- package/skills/massa-ai/workflows/debug.md +2 -2
- package/skills/massa-ai/workflows/feature.md +3 -3
- package/skills/massa-ai/workflows/implementation/implementation-fix.md +3 -3
- package/skills/massa-ai/workflows/mobile-figma/mobile-figma-fix.md +5 -5
- package/skills/massa-ai/workflows/pr-review.md +3 -3
- package/skills/massa-ai/workflows/refactor.md +3 -3
- package/skills/massa-ai/workflows/requirements/requirements-fix.md +3 -3
- package/skills/massa-ai/workflows/security/security-fix.md +3 -3
- package/skills/massa-ai/workflows/spec-driven.md +13 -3
- package/skills/massa-ai/workflows/tests/tests-fix.md +3 -3
- package/skills/profile/SKILL.md +0 -39
|
@@ -73,7 +73,7 @@ Not for findings-only architecture review — route to `workflows/architecture/a
|
|
|
73
73
|
- Update tests, docs, and imports only where required by the architecture fix.
|
|
74
74
|
10. Use agent orchestration only when it improves signal — except the verifier dispatch below, which is tier-gated mandatory rather than discretionary, carved out under `references/agent-orchestration.md`'s Independent Verification Exception. Dispatch per `references/agent-orchestration.md`:
|
|
75
75
|
|
|
76
|
-
> **Dispatch: `
|
|
76
|
+
> **Dispatch: `senior-engineer`** (role: `senior-engineer`) — charter `skills/agents/senior-engineer/SKILL.md`
|
|
77
77
|
> - trigger: large/high-risk finding, disjoint implementation slice, or explicit subagent request
|
|
78
78
|
> - scope: one isolated architecture finding with a disjoint write set
|
|
79
79
|
> - permissions: write (disjoint write set)
|
|
@@ -83,10 +83,10 @@ Not for findings-only architecture review — route to `workflows/architecture/a
|
|
|
83
83
|
> - firewall: raw diffs/logs summarized
|
|
84
84
|
> - memory: suggest-only; main agent persists reusable architecture patterns
|
|
85
85
|
|
|
86
|
-
> **Dispatch: `code-reviewer`** (role: `code-reviewer`, mode: `
|
|
86
|
+
> **Dispatch: `code-reviewer`** (role: `code-reviewer`, mode: `audit`) — charter `skills/agents/code-reviewer/SKILL.md`
|
|
87
87
|
> - trigger: implementation of the architecture finding complete, before the verification gate — never optional
|
|
88
88
|
> - scope: the fix's diff surface and its task/AC context
|
|
89
|
-
> - inputs: diff, ARCH acceptance context, recalled code-quality conventions
|
|
89
|
+
> - inputs: `lens: diff`; diff, ARCH acceptance context, recalled code-quality conventions
|
|
90
90
|
> - sensors: bugs, regressions, missing edge cases, smells introduced by the diff
|
|
91
91
|
> - output: ranked findings, blocking vs advisory; blocking findings become architecture fix items before verification runs
|
|
92
92
|
> - firewall: summarized findings only, never raw diff dumps
|
|
@@ -62,7 +62,7 @@ Not for findings-only bug discovery — route to `workflows/bugs/bugs-audit.md`.
|
|
|
62
62
|
- Do not weaken tests, fixtures, snapshots, types, or public contracts to make the fix pass.
|
|
63
63
|
9. Use agent orchestration only when it improves signal, except independent verification of the bug fix, which is mandated at the tiers named in `references/agent-orchestration.md`'s Independent Verification Exception. Dispatch per `references/agent-orchestration.md`:
|
|
64
64
|
|
|
65
|
-
> **Dispatch: `
|
|
65
|
+
> **Dispatch: `senior-engineer`** (role: `senior-engineer`) — charter `skills/agents/senior-engineer/SKILL.md`
|
|
66
66
|
> - trigger: large/high-risk finding, disjoint implementation slice, or explicit subagent request
|
|
67
67
|
> - scope: one isolated bug finding with a disjoint write set
|
|
68
68
|
> - permissions: write (disjoint write set)
|
|
@@ -72,10 +72,10 @@ Not for findings-only bug discovery — route to `workflows/bugs/bugs-audit.md`.
|
|
|
72
72
|
> - firewall: raw diffs/logs summarized
|
|
73
73
|
> - memory: suggest-only; main agent persists reusable bug patterns
|
|
74
74
|
|
|
75
|
-
> **Dispatch: `code-reviewer`** (role: `code-reviewer`, mode: `
|
|
75
|
+
> **Dispatch: `code-reviewer`** (role: `code-reviewer`, mode: `audit`) — charter `skills/agents/code-reviewer/SKILL.md`
|
|
76
76
|
> - trigger: implementation complete, before the verification gate — never optional
|
|
77
77
|
> - scope: the fix's diff surface and its task/AC context
|
|
78
|
-
> - inputs: diff, acceptance context, recalled code-quality conventions
|
|
78
|
+
> - inputs: `lens: diff`; diff, acceptance context, recalled code-quality conventions
|
|
79
79
|
> - sensors: bugs, regressions, missing edge cases, smells introduced by the diff
|
|
80
80
|
> - output: ranked findings, blocking vs advisory; blocking findings become fix items before verification runs
|
|
81
81
|
> - firewall: summarized findings only, never raw diff dumps
|
|
@@ -62,7 +62,7 @@ Not for findings-only SOLID, Clean Code, KISS, YAGNI, DRY, maintainability, or o
|
|
|
62
62
|
- Prefer small reversible edits; verify after each finding or coherent group.
|
|
63
63
|
10. Use agent orchestration only when it improves signal — except the `code-reviewer` `verify` dispatch below, which `references/agent-orchestration.md`'s Independent Verification Exception mandates at the tiers named in its trigger regardless of signal improvement. Dispatch per `references/agent-orchestration.md`:
|
|
64
64
|
|
|
65
|
-
> **Dispatch: `
|
|
65
|
+
> **Dispatch: `senior-engineer`** (role: `senior-engineer`) — charter `skills/agents/senior-engineer/SKILL.md`
|
|
66
66
|
> - trigger: large/high-risk finding, disjoint implementation slice, or explicit subagent request
|
|
67
67
|
> - scope: one isolated code-quality finding or disjoint file group
|
|
68
68
|
> - permissions: write (disjoint write set)
|
|
@@ -72,10 +72,10 @@ Not for findings-only SOLID, Clean Code, KISS, YAGNI, DRY, maintainability, or o
|
|
|
72
72
|
> - firewall: raw diffs/logs summarized
|
|
73
73
|
> - memory: suggest-only; main agent persists reusable code-quality patterns
|
|
74
74
|
|
|
75
|
-
> **Dispatch: `code-reviewer`** (role: `code-reviewer`, mode: `
|
|
75
|
+
> **Dispatch: `code-reviewer`** (role: `code-reviewer`, mode: `audit`) — charter `skills/agents/code-reviewer/SKILL.md`
|
|
76
76
|
> - trigger: implementation of the CQ finding complete, before the verification gate — never optional
|
|
77
77
|
> - scope: the fix's diff surface and its task/AC context
|
|
78
|
-
> - inputs: diff, CQ acceptance context, recalled code-quality conventions
|
|
78
|
+
> - inputs: `lens: diff`; diff, CQ acceptance context, recalled code-quality conventions
|
|
79
79
|
> - sensors: bugs, regressions, missing edge cases, smells introduced by the diff
|
|
80
80
|
> - output: ranked findings, blocking vs advisory; blocking findings become CQ fix items before verification runs
|
|
81
81
|
> - firewall: summarized findings only, never raw diff dumps
|
|
@@ -67,10 +67,10 @@ Before the first repository mutation, load `references/implementation-delivery.m
|
|
|
67
67
|
- (a) write the test first, asserting the exact previously-broken behavior at the divergence point
|
|
68
68
|
- (b) at Standard+, prove the coverage discriminates: run the sensor in `references/discrimination-sensor.md` against the just-fixed code; a surviving mutant means the regression test does not yet prove the fix
|
|
69
69
|
|
|
70
|
-
> **Dispatch: `code-reviewer`** (role: `code-reviewer`, mode: `
|
|
70
|
+
> **Dispatch: `code-reviewer`** (role: `code-reviewer`, mode: `audit`) — charter `skills/agents/code-reviewer/SKILL.md`
|
|
71
71
|
> - trigger: implementation complete, before the verification gate — never optional
|
|
72
72
|
> - scope: the fix's diff surface and its task/AC context
|
|
73
|
-
> - inputs: diff, acceptance context, recalled code-quality conventions
|
|
73
|
+
> - inputs: `lens: diff`; diff, acceptance context, recalled code-quality conventions
|
|
74
74
|
> - sensors: bugs, regressions, missing edge cases, smells introduced by the diff
|
|
75
75
|
> - output: ranked findings, blocking vs advisory; blocking findings become fix items before verification runs
|
|
76
76
|
> - firewall: summarized findings only, never raw diff dumps
|
|
@@ -61,17 +61,17 @@ Before the first repository mutation, load `references/implementation-delivery.m
|
|
|
61
61
|
> - permissions: write, scoped to UI-layer files only with a disjoint write set
|
|
62
62
|
> - output: per-element conformance table (element, expected, actual, verdict, severity) plus the UI files written; a missing or unreachable design source is listed as a skipped sensor, never a silent pass
|
|
63
63
|
|
|
64
|
-
> **Dispatch: `code-reviewer`** (role: `code-reviewer`, mode: `
|
|
64
|
+
> **Dispatch: `code-reviewer`** (role: `code-reviewer`, mode: `audit`) — charter `skills/agents/code-reviewer/SKILL.md`
|
|
65
65
|
> - trigger: implementation complete, before the verification gate — never optional
|
|
66
66
|
> - scope: the feature's diff surface and its task/AC context
|
|
67
|
-
> - inputs: diff, acceptance context, recalled code-quality conventions
|
|
67
|
+
> - inputs: `lens: diff`; diff, acceptance context, recalled code-quality conventions
|
|
68
68
|
> - sensors: bugs, regressions, missing edge cases, smells introduced by the diff
|
|
69
69
|
> - output: ranked findings, blocking vs advisory; blocking findings become fix items before verification runs
|
|
70
70
|
> - firewall: summarized findings only, never raw diff dumps
|
|
71
71
|
> - memory: suggest-only; main agent persists
|
|
72
72
|
|
|
73
73
|
> **Dispatch: `code-reviewer`** (role: `code-reviewer`, mode: `verify`) — charter `skills/agents/code-reviewer/SKILL.md`
|
|
74
|
-
> - trigger: Standard tier or above per the Independent Verification Mandate in `references/verification-ladder.md` — mandatory once every implemented PR group has cleared
|
|
74
|
+
> - trigger: Standard tier or above per the Independent Verification Mandate in `references/verification-ladder.md` — mandatory once every implemented PR group has cleared diff-audit fix items; Quick tier substitutes the fallback below
|
|
75
75
|
> - scope: the new code landed across this feature's PR groups from step 12, plus the tests and validation assets those groups touch
|
|
76
76
|
> - inputs: the 1-5 acceptance criteria captured in step 11 (or the referenced spec artifact) as the outcome source, the feature's diff surface across all PR groups, and its test suite
|
|
77
77
|
> - sensors: check the diff and tests against each acceptance criterion; discrimination sensor per `references/discrimination-sensor.md` (mutate the feature's new code, one PR group at a time — covering tests must kill each mutant or that group is not verified)
|
|
@@ -69,7 +69,7 @@ Do not execute from chat summaries, inline review comments, remembered findings,
|
|
|
69
69
|
> - permissions: write, scoped to UI-layer files only with a disjoint write set
|
|
70
70
|
> - output: per-element conformance table (element, expected, actual, verdict, severity) plus the UI files written; a missing or unreachable design source is listed as a skipped sensor, never a silent pass
|
|
71
71
|
|
|
72
|
-
> **Dispatch: `
|
|
72
|
+
> **Dispatch: `senior-engineer`** (role: `senior-engineer`) — charter `skills/agents/senior-engineer/SKILL.md`
|
|
73
73
|
> - trigger: isolated finding with disjoint write set and concrete verification
|
|
74
74
|
> - scope: one isolated implementation finding with a disjoint write set
|
|
75
75
|
> - permissions: write (disjoint write set)
|
|
@@ -81,10 +81,10 @@ Do not execute from chat summaries, inline review comments, remembered findings,
|
|
|
81
81
|
|
|
82
82
|
Never run parallel writers against shared files or contracts.
|
|
83
83
|
|
|
84
|
-
> **Dispatch: `code-reviewer`** (role: `code-reviewer`, mode: `
|
|
84
|
+
> **Dispatch: `code-reviewer`** (role: `code-reviewer`, mode: `audit`) — charter `skills/agents/code-reviewer/SKILL.md`
|
|
85
85
|
> - trigger: implementation complete, before the verification gate — never optional
|
|
86
86
|
> - scope: the fix's diff surface and its task/AC context
|
|
87
|
-
> - inputs: diff, acceptance context, recalled code-quality conventions
|
|
87
|
+
> - inputs: `lens: diff`; diff, acceptance context, recalled code-quality conventions
|
|
88
88
|
> - sensors: bugs, regressions, missing edge cases, smells introduced by the diff
|
|
89
89
|
> - output: ranked findings, blocking vs advisory; blocking findings become fix items before verification runs
|
|
90
90
|
> - firewall: summarized findings only, never raw diff dumps
|
|
@@ -32,7 +32,7 @@ Do not execute from chat summaries, screenshots alone, remembered findings, or a
|
|
|
32
32
|
- `references/audit-scope.md` and `references/codebase-investigation.md` for freshness and current source.
|
|
33
33
|
- `references/verification-ladder.md` before edits.
|
|
34
34
|
- `references/context-firewall.md` before large design/runtime artifacts.
|
|
35
|
-
- `references/agent-orchestration.md` for the designer/
|
|
35
|
+
- `references/agent-orchestration.md` for the designer/senior-engineer dispatches and the tier-gated `code-reviewer` `verify` dispatch in the fix loop below.
|
|
36
36
|
- `references/discrimination-sensor.md` before closing any finding under the Mandatory Verification Fix Gate — the mobile-Figma token/value instantiation lives in `references/mobile-figma-matcher/core.md`'s Discrimination Sensor for Visual Parity section.
|
|
37
37
|
- `references/knowledge-verification-chain.md` when a selected finding's fix direction depends on platform-API or external-library technique rather than the Figma-defined value.
|
|
38
38
|
- `references/brownfield-mapping.md` (Minimum Bar only — the gate-command packet, `TESTING.md`-equivalent) when recall returns no hit for the target surface/module and no gate command is derivable from the report's evidence, for Standard+ findings; the report's Verification/Test Fidelity Checklist already carries the risk surface, so `CONCERNS.md` is satisfied-by-citation from that checklist rather than derived fresh.
|
|
@@ -60,14 +60,14 @@ Do not execute from chat summaries, screenshots alone, remembered findings, or a
|
|
|
60
60
|
- Modify tracked Maestro flows only when the selected finding explicitly identifies the flow as incorrect or missing and the user-approved scope includes that change.
|
|
61
61
|
9. Dispatch per `references/agent-orchestration.md`; the `code-reviewer` `verify` block below is tier-gated mandatory, not merely discretionary — carved out of ordinary delegation gating by that reference's Independent Verification Exception:
|
|
62
62
|
|
|
63
|
-
**Screen work — unconditional in this workflow:** every task here fixes a user-facing screen, so the `designer` dispatch below always runs; it is not gated on a screen-work condition (Screen Implementation Exception in `references/agent-orchestration.md`). `designer` implements every UI-layer `MFM-*` fix; `
|
|
63
|
+
**Screen work — unconditional in this workflow:** every task here fixes a user-facing screen, so the `designer` dispatch below always runs; it is not gated on a screen-work condition (Screen Implementation Exception in `references/agent-orchestration.md`). `designer` implements every UI-layer `MFM-*` fix; `senior-engineer` is dispatched only for an `MFM-*` finding whose fix needs non-UI-layer changes (navigation, data, resource or build wiring), with a write set disjoint from the designer's.
|
|
64
64
|
|
|
65
65
|
> **Dispatch: `designer`** (role: `designer`, mode: `implement`) — charter `skills/agents/designer/SKILL.md`
|
|
66
66
|
> - scope: the screens, views, components, layouts, styles, and design tokens in this task's UI surface — never the whole repository
|
|
67
67
|
> - permissions: write, scoped to UI-layer files only with a disjoint write set
|
|
68
68
|
> - output: per-element conformance table (element, expected, actual, verdict, severity) plus the UI files written; a missing or unreachable design source is listed as a skipped sensor, never a silent pass
|
|
69
69
|
|
|
70
|
-
> **Dispatch: `
|
|
70
|
+
> **Dispatch: `senior-engineer`** (role: `senior-engineer`) — charter `skills/agents/senior-engineer/SKILL.md`
|
|
71
71
|
> - trigger: a selected `MFM-*` finding whose fix needs non-UI-layer changes (navigation, data, resource or build wiring) — never for a UI-layer fix, which belongs to `designer`
|
|
72
72
|
> - scope: the non-UI-layer part of one `MFM-*` finding, or of a coherent surface group sharing one KMP root cause, with a write set disjoint from the designer's
|
|
73
73
|
> - permissions: write (disjoint write set, non-UI-layer files only)
|
|
@@ -77,10 +77,10 @@ Do not execute from chat summaries, screenshots alone, remembered findings, or a
|
|
|
77
77
|
> - firewall: raw diffs and screenshots summarized
|
|
78
78
|
> - memory: suggest-only; main agent persists reusable token/mapping patterns
|
|
79
79
|
|
|
80
|
-
> **Dispatch: `code-reviewer`** (role: `code-reviewer`, mode: `
|
|
80
|
+
> **Dispatch: `code-reviewer`** (role: `code-reviewer`, mode: `audit`) — charter `skills/agents/code-reviewer/SKILL.md`
|
|
81
81
|
> - trigger: implementation complete, before the verification gate — never optional
|
|
82
82
|
> - scope: the fix's diff surface and its task/AC context
|
|
83
|
-
> - inputs: diff, acceptance context, recalled code-quality conventions
|
|
83
|
+
> - inputs: `lens: diff`; diff, acceptance context, recalled code-quality conventions
|
|
84
84
|
> - sensors: bugs, regressions, missing edge cases, smells introduced by the diff
|
|
85
85
|
> - output: ranked findings, blocking vs advisory; blocking findings become fix items before verification runs
|
|
86
86
|
> - firewall: summarized findings only, never raw diff dumps
|
|
@@ -147,7 +147,7 @@ the severity labels, and the reply contract.
|
|
|
147
147
|
| 3 | Architecture & conventions | `code-reviewer` | `lens: architecture` — extract every explicit rule from the profile's CONVENTIONS/REVIEW_SKILLS docs into a numbered matrix, grade each changed file PASS/VIOLATION/N/A; no docs ⇒ minimal generic boundary sweep, stated | `architecture` |
|
|
148
148
|
| 4 | Performance | `code-reviewer` | `lens: performance` — only issues clearly visible in the diff: N+1 queries, unbounded fetches, per-row lazy I/O, sequential awaits of independent calls, loop-invariant recomputation, unbatched writes | `performance` |
|
|
149
149
|
| 5 | Test coverage | `test-engineer` | `mode: audit` (dedicated tests lens: coverage, regression protection, assertion quality, variation — `tests-audit.md` precedent) — new/changed behavior with no test, wrong level (unit vs integration), placement/naming vs profile TEST row, missing negative case, missing variation beyond the fixture example, assertions that exercise but never assert | `tests` |
|
|
150
|
-
| 6 | Regression & hallucination | `code-reviewer` | `mode:
|
|
150
|
+
| 6 | Regression & hallucination | `code-reviewer` | `mode: audit`, `lens: diff` — diff review — unrelated deletions, references to symbols absent from the repo, wrong signature/arity, duplicated existing logic, weakened error handling or assertions, leftover TODO/stub, dead code | `regression` |
|
|
151
151
|
|
|
152
152
|
Consolidation check (≥ 5 subagents): recorded in the feature design — rows 4 and 5
|
|
153
153
|
share only the lens label, not a knowledge domain; they stay separate dispatches.
|
|
@@ -181,10 +181,10 @@ share only the lens label, not a knowledge domain; they stay separate dispatches
|
|
|
181
181
|
> - firewall: raw diff/log/search output summarized, never returned raw
|
|
182
182
|
> - memory: suggest-only; the main agent persists durable outcomes
|
|
183
183
|
|
|
184
|
-
> **Dispatch: `code-reviewer`** (role: `code-reviewer`, mode: `
|
|
184
|
+
> **Dispatch: `code-reviewer`** (role: `code-reviewer`, mode: `audit`) — charter `skills/agents/code-reviewer/SKILL.md`
|
|
185
185
|
> - trigger: pr-review Step 2, dimension row 6 (regression & hallucination)
|
|
186
186
|
> - scope: the full PR/MR diff against the repository's real symbol surface; no host CLI calls, no posting
|
|
187
|
-
> - inputs: exact `projectId`, parent `workflowSessionId`, dimension row 6, DISCOVERY MAP, PR/MR intent, full diff, existing-comment inventory, severity labels, reply contract
|
|
187
|
+
> - inputs: `lens: diff`; exact `projectId`, parent `workflowSessionId`, dimension row 6, DISCOVERY MAP, PR/MR intent, full diff, existing-comment inventory, severity labels, reply contract
|
|
188
188
|
> - sensors: verify referenced symbols exist (`search_definitions`/`get_references` when INDEX is fresh, else grep); second-pass sweep as above
|
|
189
189
|
> - output: structured reply block — findings rows tagged `{unrelated-deletion | phantom-reference | wrong-signature | duplicate | weakened-check | dead-code}` + one positive highlight + files-swept-clean list; withhold uncertain findings
|
|
190
190
|
> - firewall: raw diff/log/search output summarized, never returned raw
|
|
@@ -66,17 +66,17 @@ Before the first repository mutation, load `references/implementation-delivery.m
|
|
|
66
66
|
- Refactored architectural decisions via `remember` as scored `decision` memories
|
|
67
67
|
- Identified and decoupled anti-patterns via `remember` as scored `pattern` memories
|
|
68
68
|
|
|
69
|
-
> **Dispatch: `code-reviewer`** (role: `code-reviewer`, mode: `
|
|
69
|
+
> **Dispatch: `code-reviewer`** (role: `code-reviewer`, mode: `audit`) — charter `skills/agents/code-reviewer/SKILL.md`
|
|
70
70
|
> - trigger: implementation complete, before the verification gate — never optional
|
|
71
71
|
> - scope: the change's diff surface and its task/AC context
|
|
72
|
-
> - inputs: diff, acceptance context, recalled code-quality conventions
|
|
72
|
+
> - inputs: `lens: diff`; diff, acceptance context, recalled code-quality conventions
|
|
73
73
|
> - sensors: bugs, regressions, missing edge cases, smells introduced by the diff
|
|
74
74
|
> - output: ranked findings, blocking vs advisory; blocking findings become fix items before verification runs
|
|
75
75
|
> - firewall: summarized findings only, never raw diff dumps
|
|
76
76
|
> - memory: suggest-only; main agent persists
|
|
77
77
|
|
|
78
78
|
> **Dispatch: `code-reviewer`** (role: `code-reviewer`, mode: `verify`) — charter `skills/agents/code-reviewer/SKILL.md`
|
|
79
|
-
> - trigger: Standard+ refactor sizing or any PR-group execution per the Independent Verification Mandate in `references/verification-ladder.md` — mandatory once
|
|
79
|
+
> - trigger: Standard+ refactor sizing or any PR-group execution per the Independent Verification Mandate in `references/verification-ladder.md` — mandatory once diff-audit fix items are resolved; Quick-sized refactors dispatch only when validation assets were touched, otherwise run the fresh-eyes fallback below and record the skip reason
|
|
80
80
|
> - scope: the moved/transformed code across this refactor's PR groups and the characterization tests that must protect it
|
|
81
81
|
> - inputs: the characterization baseline from step 6 (and step 7 for mobile refactors), the diff of moved code per PR group, and the PR-group map from step 9
|
|
82
82
|
> - sensors: confirm the characterization tests still pass against the moved code's preserved behavior; discrimination sensor per `references/discrimination-sensor.md` (mutate the moved code — never new code — in scratch, one PR group at a time; characterization tests must kill each mutant)
|
|
@@ -66,7 +66,7 @@ Not for findings-only requirements review — route to `workflows/requirements/r
|
|
|
66
66
|
- If a finding exposes a product decision gap, stop and ask rather than inventing policy.
|
|
67
67
|
10. Use agent orchestration only when it improves signal, with one carve-out: the `code-reviewer` `verify` dispatch below is mandatory at its tier gate rather than discretionary, per `references/agent-orchestration.md`'s Independent Verification Exception. Dispatch per `references/agent-orchestration.md`:
|
|
68
68
|
|
|
69
|
-
> **Dispatch: `
|
|
69
|
+
> **Dispatch: `senior-engineer`** (role: `senior-engineer`) — charter `skills/agents/senior-engineer/SKILL.md`
|
|
70
70
|
> - trigger: large/high-risk finding, disjoint implementation slice, or explicit subagent request
|
|
71
71
|
> - scope: one isolated requirements finding with a disjoint write set
|
|
72
72
|
> - permissions: write (disjoint write set)
|
|
@@ -76,10 +76,10 @@ Not for findings-only requirements review — route to `workflows/requirements/r
|
|
|
76
76
|
> - firewall: raw diffs/logs summarized
|
|
77
77
|
> - memory: suggest-only; main agent persists reusable requirements patterns
|
|
78
78
|
|
|
79
|
-
> **Dispatch: `code-reviewer`** (role: `code-reviewer`, mode: `
|
|
79
|
+
> **Dispatch: `code-reviewer`** (role: `code-reviewer`, mode: `audit`) — charter `skills/agents/code-reviewer/SKILL.md`
|
|
80
80
|
> - trigger: implementation complete, before the verification gate — never optional
|
|
81
81
|
> - scope: the fix's diff surface and its task/AC context
|
|
82
|
-
> - inputs: diff, acceptance context, recalled code-quality conventions
|
|
82
|
+
> - inputs: `lens: diff`; diff, acceptance context, recalled code-quality conventions
|
|
83
83
|
> - sensors: bugs, regressions, missing edge cases, smells introduced by the diff
|
|
84
84
|
> - output: ranked findings, blocking vs advisory; blocking findings become fix items before verification runs
|
|
85
85
|
> - firewall: summarized findings only, never raw diff dumps
|
|
@@ -68,7 +68,7 @@ Not for findings-only security review — route to `workflows/security/security-
|
|
|
68
68
|
- Do not weaken existing security assertions to make tests pass.
|
|
69
69
|
10. Use agent orchestration only when it improves signal — except the verifier dispatch below, which is unconditional for every SEC finding closed `fixed`, carved out under `references/agent-orchestration.md`'s Independent Verification Exception as the security-fix unconditional case (other fix families use the tier-gated one). Dispatch per `references/agent-orchestration.md`:
|
|
70
70
|
|
|
71
|
-
> **Dispatch: `
|
|
71
|
+
> **Dispatch: `senior-engineer`** (role: `senior-engineer`) — charter `skills/agents/senior-engineer/SKILL.md`
|
|
72
72
|
> - trigger: large/high-risk finding, disjoint implementation slice, or explicit subagent request
|
|
73
73
|
> - scope: one isolated security finding with a disjoint write set
|
|
74
74
|
> - permissions: write (disjoint write set)
|
|
@@ -78,10 +78,10 @@ Not for findings-only security review — route to `workflows/security/security-
|
|
|
78
78
|
> - firewall: raw diffs/logs summarized
|
|
79
79
|
> - memory: suggest-only; main agent persists reusable security patterns
|
|
80
80
|
|
|
81
|
-
> **Dispatch: `code-reviewer`** (role: `code-reviewer`, mode: `
|
|
81
|
+
> **Dispatch: `code-reviewer`** (role: `code-reviewer`, mode: `audit`) — charter `skills/agents/code-reviewer/SKILL.md`
|
|
82
82
|
> - trigger: implementation complete, before the verification gate — never optional
|
|
83
83
|
> - scope: the fix's diff surface and its task/AC context
|
|
84
|
-
> - inputs: diff, acceptance context, recalled code-quality conventions
|
|
84
|
+
> - inputs: `lens: diff`; diff, acceptance context, recalled code-quality conventions
|
|
85
85
|
> - sensors: bugs, regressions, missing edge cases, smells introduced by the diff
|
|
86
86
|
> - output: ranked findings, blocking vs advisory; blocking findings become fix items before verification runs
|
|
87
87
|
> - firewall: summarized findings only, never raw diff dumps
|
|
@@ -96,9 +96,19 @@ Quick artifacts live under `.specs/quick/NNN-slug/` with a `TASK.md` (one-line i
|
|
|
96
96
|
3. Run `Specify` with `references/spec-driven/specify.md`.
|
|
97
97
|
- Capture stable requirement IDs, testable acceptance criteria, edge cases, and explicit out-of-scope items.
|
|
98
98
|
- Run `references/spec-driven/discuss.md` inside Specify when gray areas, implicit requirements, persistence/state, external calls, auth, payments, concurrency, or state transitions affect behavior.
|
|
99
|
+
|
|
100
|
+
> **Dispatch: `product-manager`** (role: `product-manager`, mode: `audit`) — charter `skills/agents/product-manager/SKILL.md`
|
|
101
|
+
> - trigger: every Specify run, once `spec.md` is drafted, before the Requirement Closure Gate
|
|
102
|
+
> - scope: the drafted `spec.md`
|
|
103
|
+
> - permissions: read-only
|
|
104
|
+
> - inputs: `lens: requirements`; the drafted spec; recalled requirement decisions
|
|
105
|
+
> - output: findings — ambiguity, gap, contradiction, implicit-requirement, and uncovered-scenario lists — that the main agent resolves with the user or records as an accepted assumption in the Requirement Closure Gate
|
|
106
|
+
> - firewall: raw spec text summarized, not returned raw
|
|
107
|
+
> - memory: suggest-only; main agent persists reusable requirements patterns
|
|
108
|
+
|
|
99
109
|
- For Android, iOS, or KMP Compose Multiplatform UI work, run the optional design-source intake gate from `references/mobile-context.md` (Design-Source Intake Gate).
|
|
100
110
|
- WHERE one or more Figma links or node IDs are supplied for this work (any platform), lazily load `references/figma-pre-analysis.md`, `references/figma-wiring.md`, and `references/design-implementation.md` before Design/Tasks close; mobile targets additionally keep the Design-Source Intake Gate above.
|
|
101
|
-
- Apply the Requirement Closure Gate: every open requirement question is resolved with the user or recorded as an accepted assumption before execution begins.
|
|
111
|
+
- Apply the Requirement Closure Gate: every open requirement question is resolved with the user or recorded as an accepted assumption before execution begins, incorporating the `product-manager` `audit` findings above.
|
|
102
112
|
**Reuse Scan — before writing new implementation code:** run the mandatory reuse scan per `references/code-reuse-scan.md` (separate read-only subagents; the reuse map's use/extend/new decisions are consumed before new code is planned or written) — or record its inline-fallback reason, verbatim.
|
|
103
113
|
|
|
104
114
|
4. Decide whether `Design` is required. If yes, run `references/spec-driven/design.md`, including its deterministic validation before presenting `design.md` for confirmation; if no, record why the skip is valid. When Design is skipped and a design concern appears later, stop and create `design.md` before continuing.
|
|
@@ -123,10 +133,10 @@ Quick artifacts live under `.specs/quick/NNN-slug/` with a `TASK.md` (one-line i
|
|
|
123
133
|
> - permissions: write, scoped to UI-layer files only with a disjoint write set
|
|
124
134
|
> - output: per-element conformance table (element, expected, actual, verdict, severity) plus the UI files written; a missing or unreachable design source is listed as a skipped sensor, never a silent pass
|
|
125
135
|
|
|
126
|
-
> **Dispatch: `code-reviewer`** (role: `code-reviewer`, mode: `
|
|
136
|
+
> **Dispatch: `code-reviewer`** (role: `code-reviewer`, mode: `audit`) — charter `skills/agents/code-reviewer/SKILL.md`
|
|
127
137
|
> - trigger: implementation complete, before the verification gate — never optional
|
|
128
138
|
> - scope: the task's diff surface and its task/AC context
|
|
129
|
-
> - inputs: diff, acceptance context, recalled code-quality conventions
|
|
139
|
+
> - inputs: `lens: diff`; diff, acceptance context, recalled code-quality conventions
|
|
130
140
|
> - sensors: bugs, regressions, missing edge cases, smells introduced by the diff
|
|
131
141
|
> - output: ranked findings, blocking vs advisory; blocking findings become fix items before verification runs
|
|
132
142
|
> - firewall: summarized findings only, never raw diff dumps
|
|
@@ -68,10 +68,10 @@ Not for findings-only test coverage, assertion quality, fixture health, flakines
|
|
|
68
68
|
- Do not delete coverage, snapshots, fixtures, or benchmarks unless the audit report explicitly calls them obsolete and behavior remains protected elsewhere.
|
|
69
69
|
- Prefer production-code changes only when required to expose a deterministic seam or fix a real bug found while writing the audited test.
|
|
70
70
|
|
|
71
|
-
> **Dispatch: `code-reviewer`** (role: `code-reviewer`, mode: `
|
|
71
|
+
> **Dispatch: `code-reviewer`** (role: `code-reviewer`, mode: `audit`) — charter `skills/agents/code-reviewer/SKILL.md`
|
|
72
72
|
> - trigger: implementation complete, before the verification gate — never optional
|
|
73
73
|
> - scope: the fix's diff surface and its task/AC context
|
|
74
|
-
> - inputs: diff, acceptance context, recalled code-quality conventions
|
|
74
|
+
> - inputs: `lens: diff`; diff, acceptance context, recalled code-quality conventions
|
|
75
75
|
> - sensors: bugs, regressions, missing edge cases, smells introduced by the diff
|
|
76
76
|
> - output: ranked findings, blocking vs advisory; blocking findings become fix items before verification runs
|
|
77
77
|
> - firewall: summarized findings only, never raw diff dumps
|
|
@@ -111,7 +111,7 @@ Not for findings-only test coverage, assertion quality, fixture health, flakines
|
|
|
111
111
|
> - firewall: raw test output/logs summarized
|
|
112
112
|
> - memory: suggest-only; main agent persists reusable testing patterns
|
|
113
113
|
|
|
114
|
-
> **Dispatch: `
|
|
114
|
+
> **Dispatch: `senior-engineer`** (role: `senior-engineer`) — charter `skills/agents/senior-engineer/SKILL.md`
|
|
115
115
|
> - trigger: a selected TST finding whose fix needs a production seam for deterministic testing (step 7 Standard) — never for a test-file change, which belongs to `test-engineer`, and never for a production behavior change, which routes to `workflows/spec-driven.md`
|
|
116
116
|
> - scope: the seam-only production change for one TST finding, with a write set disjoint from the `test-engineer` test files
|
|
117
117
|
> - permissions: write (disjoint write set, production seam files only; no behavior change)
|
package/skills/profile/SKILL.md
DELETED
|
@@ -1,39 +0,0 @@
|
|
|
1
|
-
---
|
|
2
|
-
name: profile
|
|
3
|
-
description: Switch the installed massa-ai agents to a registry model profile (e.g. "work", "cheap", "home") or report the currently active profile per host. Use when the user asks to change/switch the model profile, asks which models the agents currently use, or asks to preview a profile switch. Do NOT use for editing the model registry itself (a registry edit is a massa-ai repository change, not a runtime switch) and do NOT claim the new profile is active before the user restarts the host session.
|
|
4
|
-
license: MIT
|
|
5
|
-
metadata:
|
|
6
|
-
author: Luiz Massa
|
|
7
|
-
version: 1.0.0
|
|
8
|
-
---
|
|
9
|
-
|
|
10
|
-
# Profile Switch Skill
|
|
11
|
-
|
|
12
|
-
## Mission
|
|
13
|
-
Drive the one massa-ai model-profile switch engine and relay its report — never a second implementation.
|
|
14
|
-
|
|
15
|
-
## When To Use
|
|
16
|
-
- The user asks to switch, change, or set the model profile (by name, e.g. "work", "cheap", "home", "balanced").
|
|
17
|
-
- The user asks what profile is currently active, or which profiles are shipped.
|
|
18
|
-
- The user asks to preview a switch without applying it.
|
|
19
|
-
|
|
20
|
-
## How To Drive It
|
|
21
|
-
There is exactly one switch implementation (`@massa-ai/shared`'s switch engine); every front — this skill, the MCP tools, and both `massa-ai-config` CLIs — calls the same engine and returns the same per-host report shape. Prefer whichever front is already available in the session:
|
|
22
|
-
|
|
23
|
-
- **MCP tools** (preferred when the massa-ai MCP server is connected): call `profile_list` to report shipped profiles + per-host active profile + bundle version, and `profile_set` to switch (`{profile, host?, dryRun?}`).
|
|
24
|
-
- **CLI fallback**: `massa-ai-config profile list` / `massa-ai-config profile show` / `massa-ai-config profile set <name> [--host <h>] [--dry-run]`.
|
|
25
|
-
|
|
26
|
-
Default to a dry run first when the user has not explicitly asked to apply the switch immediately — `dryRun: true` (MCP) or `--dry-run` (CLI) previews the per-host plan and changes nothing.
|
|
27
|
-
|
|
28
|
-
## Relaying The Result
|
|
29
|
-
Always relay the per-host outcome and the restart notice verbatim in substance, not just "done":
|
|
30
|
-
|
|
31
|
-
- Report each host as switched / skipped (with its reason) / unsupported (with its reason) / failed (with its reason). Cursor is always reported skipped — every tier resolves to inherit, so switching it is a no-op by design, not an error.
|
|
32
|
-
- When at least one host switched (non-dry-run), state explicitly that a session restart of that host is required before the new models take effect — hosts load agent definitions at session start; there is no live in-session switch.
|
|
33
|
-
- On a dry run, say so and that no files changed.
|
|
34
|
-
- On a fully failed request (e.g. unknown profile name), relay the named error and the list of profiles the report says are actually available — never guess a profile name.
|
|
35
|
-
|
|
36
|
-
## Restrictions
|
|
37
|
-
- Never invent a profile name; only use names the engine's own report lists as shipped/available.
|
|
38
|
-
- Never claim a profile switch is "live" before the affected host's session restarts.
|
|
39
|
-
- Never edit the model-profile registry (`skills/model-profiles.json`) to satisfy a switch request — that is a build-time registry change owned by a different workflow, not a runtime switch.
|