@martinffx/atelier 3.3.0 → 3.5.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/CHANGELOG.md +25 -16
- package/README.md +9 -4
- package/agents/architect.md +3 -2
- package/package.json +5 -2
- package/skills/atelier-orchestrator/SKILL.md +14 -7
- package/skills/code-review/SKILL.md +55 -30
- package/skills/code-review/references/output.md +128 -46
- package/skills/code-review/references/personas.md +345 -0
- package/skills/code-review/references/roles/author.md +97 -0
- package/skills/code-review/references/roles/critic.md +179 -0
- package/skills/code-review/references/roles/judge.md +96 -0
- package/skills/code-review/references/roles/triage.md +54 -0
- package/skills/code-review/references/rq.md +173 -457
- package/skills/code-review/references/rs.md +28 -7
- package/skills/code-subagents/SKILL.md +5 -4
- package/skills/code-subagents/references/batch-reviewer-prompt.md +2 -2
- package/skills/code-subagents/references/implementor-prompt.md +5 -3
- package/skills/oracle-codebase-design/SKILL.md +129 -0
- package/skills/oracle-codebase-design/references/deepening.md +37 -0
- package/skills/oracle-codebase-design/references/design-it-twice.md +44 -0
- package/skills/oracle-codebase-design/references/principles.md +205 -0
- package/skills/oracle-codebase-design/references/red-flags.md +32 -0
- package/skills/oracle-debug/SKILL.md +2 -2
- package/skills/oracle-grill-me/SKILL.md +2 -1
- package/skills/spec-brainstorm/SKILL.md +8 -4
- package/skills/spec-finish/SKILL.md +4 -3
- package/skills/spec-implement/SKILL.md +4 -1
- package/skills/spec-loop/SKILL.md +91 -0
- package/skills/spec-plan/SKILL.md +2 -2
- package/skills/code-review/references/reviewers.md +0 -921
package/CHANGELOG.md
CHANGED
|
@@ -4,16 +4,39 @@
|
|
|
4
4
|
|
|
5
5
|
- **breaking:** rename the `recon` agent to `sentinel`. Existing Atelier configuration is migrated automatically and legacy generated files are removed during the next command.
|
|
6
6
|
|
|
7
|
+
## [3.5.0](https://github.com/martinffx/atelier/compare/v3.4.0...v3.5.0) (2026-10-18)
|
|
8
|
+
|
|
9
|
+
|
|
10
|
+
### Features
|
|
11
|
+
|
|
12
|
+
* **code-review:** run rq as a critique, defense and ruling debate ([45ccfce](https://github.com/martinffx/atelier/commit/45ccfce6673f4eae8fc60dea5c5e0c61a28de510))
|
|
13
|
+
* **code-review:** run simplicity on every review and consolidate reviewer prompts ([35b5927](https://github.com/martinffx/atelier/commit/35b59278eb6b690baa9cd95d68095e92e11d39e9))
|
|
14
|
+
* **skills:** add spec-loop to run a Spec-backed Plan to a PR ([368afab](https://github.com/martinffx/atelier/commit/368afabe5e591e41bd7e0e05e118f35b775002c8))
|
|
15
|
+
* **skills:** require explicit agent selection for subagents ([81dd276](https://github.com/martinffx/atelier/commit/81dd2764006b3af292cb7fb0893e091da81bba4e))
|
|
16
|
+
|
|
17
|
+
|
|
18
|
+
### Bug Fixes
|
|
19
|
+
|
|
20
|
+
* **code-review:** close debate protocol gaps from review ([a370713](https://github.com/martinffx/atelier/commit/a370713903f48b93ebb65f51d35001c9fecad5e5))
|
|
21
|
+
* **code-review:** narrow when a finding counts as mechanical ([80551b7](https://github.com/martinffx/atelier/commit/80551b7002f6f1911f029e3710e6beb602abfa1a))
|
|
22
|
+
* **spec-loop:** align Finish with the debate review ([ed671a9](https://github.com/martinffx/atelier/commit/ed671a9feb6cef7f7d2ae95bf15ff9a60622dfd8))
|
|
23
|
+
* **spec-loop:** stop on blocking findings to match spec-finish ([7301061](https://github.com/martinffx/atelier/commit/7301061902d68c4a8db173fba2410986bafba414))
|
|
24
|
+
|
|
25
|
+
## [3.4.0](https://github.com/martinffx/atelier/compare/v3.3.0...v3.4.0) (2026-10-09)
|
|
26
|
+
|
|
27
|
+
|
|
28
|
+
### Features
|
|
29
|
+
|
|
30
|
+
* **skills:** add oracle-codebase-design ([#80](https://github.com/martinffx/atelier/issues/80)) ([3672e9c](https://github.com/martinffx/atelier/commit/3672e9c655fa93d704473ebba8d2c194605f39c7))
|
|
31
|
+
|
|
7
32
|
## [3.3.0](https://github.com/martinffx/atelier/compare/v3.2.1...v3.3.0) (2026-10-09)
|
|
8
33
|
|
|
9
34
|
|
|
10
35
|
### Features
|
|
11
36
|
|
|
12
|
-
* **agents:** let the harness select agents from descriptions ([5fb7eba](https://github.com/martinffx/atelier/commit/5fb7eba11f96f7af9c48f8663c6e853f22de6149))
|
|
13
37
|
* **agents:** let the harness select agents from descriptions ([6793dde](https://github.com/martinffx/atelier/commit/6793dde9afebb7ccbc6efb3efa3e3e1e24bd2fa5))
|
|
14
38
|
* **claude:** oracle on opus/xhigh and claude.ai opt-outs in user settings ([#76](https://github.com/martinffx/atelier/issues/76)) ([d79208f](https://github.com/martinffx/atelier/commit/d79208fec17801dd041e202ee9ba6738f0071724))
|
|
15
39
|
* **claude:** support graded thinking for Haiku 5.5 ([#77](https://github.com/martinffx/atelier/issues/77)) ([6cc6992](https://github.com/martinffx/atelier/commit/6cc699274e08ef9ff116ffa22e895194b85fbb06))
|
|
16
|
-
* **skills:** authorise delegation without naming agents ([d63e4c2](https://github.com/martinffx/atelier/commit/d63e4c27d24bf7fe82722546bb28e913a1af6b01))
|
|
17
40
|
* **skills:** authorise delegation without naming agents ([81af084](https://github.com/martinffx/atelier/commit/81af08494f736375e10fcdedb44192cfe0299d87))
|
|
18
41
|
|
|
19
42
|
## [3.2.1](https://github.com/martinffx/atelier/compare/v3.2.0...v3.2.1) (2026-10-03)
|
|
@@ -22,7 +45,6 @@
|
|
|
22
45
|
### Bug Fixes
|
|
23
46
|
|
|
24
47
|
* **code-review:** align simplicity trust boundary and aggregation ([04ad861](https://github.com/martinffx/atelier/commit/04ad861aaef0d5048b11a4945c53628dc99f102c))
|
|
25
|
-
* **code-review:** run simplicity gate once and add trust boundary ([4d34d2a](https://github.com/martinffx/atelier/commit/4d34d2af7612fac1cb907681800fc6d1a9493e4c))
|
|
26
48
|
* **code-review:** run simplicity gate once and add trust boundary ([fe09d49](https://github.com/martinffx/atelier/commit/fe09d49c5ce230859f81591783e88650d25a85bb)), closes [#67](https://github.com/martinffx/atelier/issues/67) [#68](https://github.com/martinffx/atelier/issues/68)
|
|
27
49
|
|
|
28
50
|
## [3.2.0](https://github.com/martinffx/atelier/compare/v3.1.2...v3.2.0) (2026-09-28)
|
|
@@ -30,7 +52,6 @@
|
|
|
30
52
|
|
|
31
53
|
### Features
|
|
32
54
|
|
|
33
|
-
* **config:** add per-model thinking defaults across adapters ([756e698](https://github.com/martinffx/atelier/commit/756e698ccc0c466dc496a07c32c2e92508a58149))
|
|
34
55
|
* **config:** add per-model thinking defaults across adapters ([319196e](https://github.com/martinffx/atelier/commit/319196eb0e37454551a3589a712ca8650fd8e57f))
|
|
35
56
|
* **models:** update sonnet to 5.5 ([781d99f](https://github.com/martinffx/atelier/commit/781d99ff58600cb3ade16183f62814e40b7b73ee))
|
|
36
57
|
|
|
@@ -126,10 +147,8 @@
|
|
|
126
147
|
### Features
|
|
127
148
|
|
|
128
149
|
* **code-pull-request:** add comment and merge workflows with progressive disclosure ([53e8957](https://github.com/martinffx/atelier/commit/53e89574ae1c37d0c3e868c7bbecee560e38c573))
|
|
129
|
-
* **code:** add code-pull-request skill for PR creation ([62e32a6](https://github.com/martinffx/atelier/commit/62e32a6373be02cfad5fd3cb3fa248efcf3cc06c))
|
|
130
150
|
* **code:** add code-pull-request skill for PR creation ([e4d2475](https://github.com/martinffx/atelier/commit/e4d24752f610177d6706cf382f3db3c9f5406355))
|
|
131
151
|
* **skills:** split oracle-grillme into oracle-grill-me and oracle-domain-modelling ([#40](https://github.com/martinffx/atelier/issues/40)) ([e373c12](https://github.com/martinffx/atelier/commit/e373c12d05d9cde3ddb02fb0fc26ee770fb959a2))
|
|
132
|
-
* **spec-brainstorm:** add section-by-section design approval ([f66eb62](https://github.com/martinffx/atelier/commit/f66eb6275780768300218d329bff8882b6d20e5d))
|
|
133
152
|
* **spec-brainstorm:** add section-by-section design approval ([9cfb7e7](https://github.com/martinffx/atelier/commit/9cfb7e732fe20c546c2465218a8392dcba7859ad))
|
|
134
153
|
|
|
135
154
|
|
|
@@ -144,7 +163,6 @@
|
|
|
144
163
|
|
|
145
164
|
### Bug Fixes
|
|
146
165
|
|
|
147
|
-
* **skills:** remove user-invocable from code-docs ([beaaaee](https://github.com/martinffx/atelier/commit/beaaaee03d64955a3e8092d250cd4ab318c5d55d))
|
|
148
166
|
* **skills:** remove user-invocable from code-docs ([00a2a82](https://github.com/martinffx/atelier/commit/00a2a82ce064bf0a88d2d13de796c4c7e120e472))
|
|
149
167
|
|
|
150
168
|
## [1.2.1](https://github.com/martinffx/atelier/compare/v1.2.0...v1.2.1) (2026-05-23)
|
|
@@ -153,7 +171,6 @@
|
|
|
153
171
|
### Bug Fixes
|
|
154
172
|
|
|
155
173
|
* **cli:** correct skills directory path and add legacy config migration ([14f9611](https://github.com/martinffx/atelier/commit/14f9611bf4d8876844ef86ccc3fce55b203f2bed))
|
|
156
|
-
* register missing skills in marketplace.json ([06da766](https://github.com/martinffx/atelier/commit/06da76647ed7c6721a2bc283f9bbd1c212b08456))
|
|
157
174
|
* register missing skills in marketplace.json ([9f48099](https://github.com/martinffx/atelier/commit/9f48099e0be5de184c6200105e9b0b839fbcda1a))
|
|
158
175
|
|
|
159
176
|
## [1.2.0](https://github.com/martinffx/atelier/compare/v1.1.0...v1.2.0) (2026-05-23)
|
|
@@ -161,15 +178,10 @@
|
|
|
161
178
|
|
|
162
179
|
### Features
|
|
163
180
|
|
|
164
|
-
* **code-debug:** upgrade to six-phase diagnose workflow ([62dec10](https://github.com/martinffx/atelier/commit/62dec1045555947462a447f4579e83b0dee63d17))
|
|
165
181
|
* **code-debug:** upgrade to six-phase diagnose workflow ([8df277d](https://github.com/martinffx/atelier/commit/8df277d425ca16dfa63a8bf1949003e3e6aaf87c))
|
|
166
|
-
* **code-handoff:** add code-handoff skill ([5ab6f5f](https://github.com/martinffx/atelier/commit/5ab6f5f5d890b024718e3b69103b23c3eb1205ef))
|
|
167
|
-
* **oracle-architect:** add vocabulary, evaluation heuristics, and interface design reference ([7c528d3](https://github.com/martinffx/atelier/commit/7c528d308ebc98929cfc6be17e8d5c7444b36607))
|
|
168
182
|
* **oracle-architect:** add vocabulary, evaluation heuristics, and interface design reference ([63ee753](https://github.com/martinffx/atelier/commit/63ee75380c4d4be92708539173534566f2033dea))
|
|
169
|
-
* **oracle-security:** add security architecture and threat modeling skill ([8fcbd87](https://github.com/martinffx/atelier/commit/8fcbd87943bcb23d51480ed9e9bd702f19817096))
|
|
170
183
|
* **oracle-security:** add security architecture and threat modeling skill ([69b6fdc](https://github.com/martinffx/atelier/commit/69b6fdcdf1f2b7732fb339cbf1d64c1fb7252eb7))
|
|
171
184
|
* **skills:** add code-handoff skill ([012f467](https://github.com/martinffx/atelier/commit/012f4676d48c7f6799361ca6bdfef12f33a8849e))
|
|
172
|
-
* **skills:** add oracle-doubt skill ([adf118b](https://github.com/martinffx/atelier/commit/adf118be197da43195c9ddd052b53f8c714405b5))
|
|
173
185
|
* **skills:** add oracle-doubt skill for adversarial review ([447673e](https://github.com/martinffx/atelier/commit/447673eb7904e4d28306360f64329f7874db5b2b))
|
|
174
186
|
|
|
175
187
|
## [1.1.0](https://github.com/martinffx/atelier/compare/v1.0.2...v1.1.0) (2026-05-23)
|
|
@@ -177,7 +189,6 @@
|
|
|
177
189
|
|
|
178
190
|
### Features
|
|
179
191
|
|
|
180
|
-
* **skills:** add oracle-grillme socratic interrogation skill ([6ad5ce5](https://github.com/martinffx/atelier/commit/6ad5ce52428863b51fec83880ce8083bb80aa3a0))
|
|
181
192
|
* **skills:** add oracle-grillme socratic interrogation skill ([fd21606](https://github.com/martinffx/atelier/commit/fd2160639b82ba335963bec3128d9c6a5b5801b6))
|
|
182
193
|
* **skills:** add PR creation workflow to code-commit ([25bb826](https://github.com/martinffx/atelier/commit/25bb8264364cb1c5ee843baea0127eaba3935c78))
|
|
183
194
|
|
|
@@ -186,7 +197,6 @@
|
|
|
186
197
|
|
|
187
198
|
### Bug Fixes
|
|
188
199
|
|
|
189
|
-
* **package:** remove publish script to prevent recursive npm publish ([cbb1420](https://github.com/martinffx/atelier/commit/cbb14200785f0bf73c6e9f60714e3bf774bac5dd))
|
|
190
200
|
* **package:** remove publish script to prevent recursive npm publish in CI ([d2a62dc](https://github.com/martinffx/atelier/commit/d2a62dc3c40301abdf7ddfce86db71c60724b575))
|
|
191
201
|
|
|
192
202
|
## [1.0.1](https://github.com/martinffx/atelier/compare/v1.0.0...v1.0.1) (2026-05-23)
|
|
@@ -194,7 +204,6 @@
|
|
|
194
204
|
|
|
195
205
|
### Bug Fixes
|
|
196
206
|
|
|
197
|
-
* **ci:** resolve npm publish authentication failure ([7c57b85](https://github.com/martinffx/atelier/commit/7c57b8504e1f8045b9efeb7ccc5aebfb98e80050))
|
|
198
207
|
* **ci:** resolve npm publish authentication failure in release workflow ([5e584bb](https://github.com/martinffx/atelier/commit/5e584bb7bea0f261152cc057dfab444e4c9c1402))
|
|
199
208
|
|
|
200
209
|
## 1.0.0 (2026-05-22)
|
package/README.md
CHANGED
|
@@ -63,6 +63,9 @@ flowchart TD
|
|
|
63
63
|
SI --> CR[code-review]
|
|
64
64
|
CR --> F[spec-finish]
|
|
65
65
|
F --> PR[code-pull-request]
|
|
66
|
+
PS -->|Unattended run| SL[spec-loop]
|
|
67
|
+
SL -->|Per-batch review| SL
|
|
68
|
+
SL --> F
|
|
66
69
|
SI -.->|Revise plan| P
|
|
67
70
|
SI -.->|Revisit design| B
|
|
68
71
|
F -.->|Issues found| SI
|
|
@@ -70,7 +73,7 @@ flowchart TD
|
|
|
70
73
|
|
|
71
74
|
The workflow is deliberately harder to rush than an unstructured agent session. `spec-brainstorm` writes only `design.md`, and `spec-plan` writes only its selected plan output. Each skill then stops. The developer starts planning and implementation with separate requests. This records decisions when they need to survive the conversation, keeps implementation tied to an approved plan, and requires evidence before calling the work complete.
|
|
72
75
|
|
|
73
|
-
Before a plan is presented, `spec-plan` runs a design review and a critical challenge as parallel subagents and notes what changed. During implementation, `spec-implement` hands tasks whose design is already settled to a subagent, keeping design-sensitive work in the main thread.
|
|
76
|
+
Before a plan is presented, `spec-plan` runs a design review and a critical challenge as parallel subagents and notes what changed. During implementation, `spec-implement` hands tasks whose design is already settled to a subagent, keeping design-sensitive work in the main thread. The main agent explicitly selects the agent for each step by the kind of work, per `atelier-orchestrator`.
|
|
74
77
|
|
|
75
78
|
## Grill the idea
|
|
76
79
|
|
|
@@ -84,7 +87,7 @@ Grill me on this migration plan
|
|
|
84
87
|
|
|
85
88
|
## Review the code
|
|
86
89
|
|
|
87
|
-
[`code-review`](skills/code-review/SKILL.md) runs a
|
|
90
|
+
[`code-review`](skills/code-review/SKILL.md) runs a review as a debate rather than asking one agent for a general opinion. A read-only scout triages the diff, specialist Critics (always including a simplicity check) raise findings in parallel, an Author defends the change against each one, and Critics concede or maintain with evidence. A Judge rules only on what is still contested. Findings are labelled issue, suggestion, question, nitpick or praise, and as blocking or not; quotes are checked mechanically and the main agent audits what each turn did. See [the research notes](docs/research/multi-agent-debate.md).
|
|
88
91
|
|
|
89
92
|
```text
|
|
90
93
|
rq # Review the diff to main
|
|
@@ -101,7 +104,7 @@ Atelier installs a focused set of skills for the full development loop:
|
|
|
101
104
|
| Area | Capabilities |
|
|
102
105
|
|------|--------------|
|
|
103
106
|
| Spec workflow | Discovery, research, planning, implementation, validation, and finishing |
|
|
104
|
-
| Thinking | Root-cause debugging, decision grilling,
|
|
107
|
+
| Thinking | Root-cause debugging, decision grilling, domain modelling, and codebase design |
|
|
105
108
|
| Delivery | Multi-agent review, subagent coordination, commits, handoffs, and pull requests |
|
|
106
109
|
|
|
107
110
|
The CLI also configures four specialist agents for Claude Code, OpenCode, Codex, or Cursor:
|
|
@@ -113,7 +116,7 @@ The CLI also configures four specialist agents for Claude Code, OpenCode, Codex,
|
|
|
113
116
|
| **Architect** | Domain modelling, system design, and architecture review |
|
|
114
117
|
| **Keymaker** | Fast scaffolding of files and boilerplate from templates and existing patterns |
|
|
115
118
|
|
|
116
|
-
|
|
119
|
+
Each subagent launch explicitly selects one of these four by matching the task to its description; the harness default is never used. Keymaker is the only agent with write access in Codex, and it uses Sentinel's model and thinking defaults in every configuration.
|
|
117
120
|
|
|
118
121
|
Run `npx @martinffx/atelier@latest --help` for CLI commands and options. Each skill contains its own operating instructions and loads when its context applies.
|
|
119
122
|
|
|
@@ -174,11 +177,13 @@ Some Atelier skills have more direct lineage:
|
|
|
174
177
|
| [`spec-brainstorm`](skills/spec-brainstorm/SKILL.md) | Superpowers [`brainstorming`](https://github.com/obra/superpowers/tree/main/skills/brainstorming) | Adapted from its conversational discovery and section-by-section design approval. |
|
|
175
178
|
| [`spec-plan`](skills/spec-plan/SKILL.md) | Superpowers [`writing-plans`](https://github.com/obra/superpowers/tree/main/skills/writing-plans) | Inspired by its explicit, verifiable implementation plans. |
|
|
176
179
|
| [`spec-implement`](skills/spec-implement/SKILL.md) | Superpowers [`executing-plans`](https://github.com/obra/superpowers/tree/main/skills/executing-plans) and [`test-driven-development`](https://github.com/obra/superpowers/tree/main/skills/test-driven-development) | Inspired by plan-driven execution and test-first feedback loops. |
|
|
180
|
+
| [`spec-loop`](skills/spec-loop/SKILL.md) | Superpowers [`subagent-driven-development`](https://github.com/obra/superpowers/tree/main/skills/subagent-driven-development) | Inspired by its fresh implementer per task, review after each unit, and final whole-branch review. Atelier reviews per batch. |
|
|
177
181
|
| [`spec-finish`](skills/spec-finish/SKILL.md) | Superpowers [`finishing-a-development-branch`](https://github.com/obra/superpowers/tree/main/skills/finishing-a-development-branch) and [`verification-before-completion`](https://github.com/obra/superpowers/tree/main/skills/verification-before-completion) | Inspired by its validation and completion workflow. |
|
|
178
182
|
| [`code-subagents`](skills/code-subagents/SKILL.md) | Superpowers [`subagent-driven-development`](https://github.com/obra/superpowers/tree/main/skills/subagent-driven-development) and [`dispatching-parallel-agents`](https://github.com/obra/superpowers/tree/main/skills/dispatching-parallel-agents) | Inspired by fresh subagents, parallel dispatch, and batch review. |
|
|
179
183
|
| [`code-handoff`](skills/code-handoff/SKILL.md) | Matt Pocock's [`handoff`](https://github.com/mattpocock/skills/tree/main/skills/productivity/handoff) | Adapted from its context-preserving handoff format. |
|
|
180
184
|
| [`oracle-grill-me`](skills/oracle-grill-me/SKILL.md) | Matt Pocock's [`grilling`](https://github.com/mattpocock/skills/tree/main/skills/productivity/grilling) and [`grill-with-docs`](https://github.com/mattpocock/skills/tree/main/skills/engineering/grill-with-docs) | Adapted from its rigorous interview loop and integration with living domain documentation. |
|
|
181
185
|
| [`oracle-domain-modelling`](skills/oracle-domain-modelling/SKILL.md) | Matt Pocock's [`domain-modeling`](https://github.com/mattpocock/skills/tree/main/skills/engineering/domain-modeling) | Adapted from its active domain-modelling discipline, `CONTEXT.md`, and lightweight ADRs. |
|
|
186
|
+
| [`oracle-codebase-design`](skills/oracle-codebase-design/SKILL.md) | Matt Pocock's [`codebase-design`](https://github.com/mattpocock/skills/tree/main/skills/engineering/codebase-design) and John Ousterhout's *A Philosophy of Software Design* | Adapted from its deep-module vocabulary, deletion test, and design-it-twice. Extended with Ousterhout's principles and red flags, plus Alexis King's "parse, don't validate", Yaron Minsky's "make illegal states unrepresentable", and Gary Bernhardt's "functional core, imperative shell". |
|
|
182
187
|
| [`oracle-debug`](skills/oracle-debug/SKILL.md) | Superpowers [`systematic-debugging`](https://github.com/obra/superpowers/tree/main/skills/systematic-debugging) and Matt Pocock's [`diagnosing-bugs`](https://github.com/mattpocock/skills/tree/main/skills/engineering/diagnosing-bugs) | Adapted from their root-cause-first debugging workflows. |
|
|
183
188
|
|
|
184
189
|
[`code-commit`](skills/code-commit/SKILL.md) follows the [Conventional Commits](https://www.conventionalcommits.org/) specification.
|
package/agents/architect.md
CHANGED
|
@@ -14,7 +14,7 @@ You are the **Architect**, a senior technical designer and systems thinker. Your
|
|
|
14
14
|
|
|
15
15
|
## Skills
|
|
16
16
|
|
|
17
|
-
Before beginning work, scan your environment for relevant skills and load any that apply to the task at hand. Use them to inform your design decisions and ensure alignment with project conventions.
|
|
17
|
+
Before beginning work, scan your environment for relevant skills and load any that apply to the task at hand. Always load `oracle-codebase-design` when available. Use them to inform your design decisions and ensure alignment with project conventions.
|
|
18
18
|
|
|
19
19
|
## Checklist
|
|
20
20
|
|
|
@@ -23,7 +23,8 @@ Before finishing, confirm you have:
|
|
|
23
23
|
- [ ] Identified all entities, value objects, aggregates, and their relationships
|
|
24
24
|
- [ ] Defined properties, types, and validation rules for each model
|
|
25
25
|
- [ ] Specified API endpoints with methods, paths, and request/response contracts
|
|
26
|
-
- [ ] Listed error cases and handling strategy
|
|
26
|
+
- [ ] Listed error cases and handling strategy (defined away where possible, otherwise returned as values)
|
|
27
|
+
- [ ] Identified where untrusted input is parsed into domain types (the external seam)
|
|
27
28
|
- [ ] For Spec-backed Plan work, provided dependency-ordered task recommendations (entity → repository → service → router)
|
|
28
29
|
- [ ] For Spec-backed Plan work, written or updated the Technical Design section in `design.md`
|
|
29
30
|
|
package/package.json
CHANGED
|
@@ -1,12 +1,15 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "@martinffx/atelier",
|
|
3
|
-
"version": "3.
|
|
3
|
+
"version": "3.5.0",
|
|
4
4
|
"description": "Personal development toolkit - spec-driven development, code quality, deep thinking, and ecosystem patterns",
|
|
5
5
|
"type": "module",
|
|
6
6
|
"bin": {
|
|
7
7
|
"atelier": "dist/atelier.js"
|
|
8
8
|
},
|
|
9
|
-
"repository":
|
|
9
|
+
"repository": {
|
|
10
|
+
"type": "git",
|
|
11
|
+
"url": "git+https://github.com/martinffx/atelier.git"
|
|
12
|
+
},
|
|
10
13
|
"keywords": [
|
|
11
14
|
"cli",
|
|
12
15
|
"claude-code",
|
|
@@ -97,6 +97,7 @@ spec-brainstorm → Spec-backed discovery + design → only design.md → stop
|
|
|
97
97
|
spec-plan → Inline conversation or only plan.json → stop
|
|
98
98
|
spec-implement → Execute approved Spec-backed Plans; track tasks
|
|
99
99
|
spec-finish → Post-implementation validation for Spec-backed Plans
|
|
100
|
+
spec-loop → Run an approved Spec-backed Plan unattended to a draft PR
|
|
100
101
|
code-subagents → Parallel dispatch for Spec-backed Plan tasks
|
|
101
102
|
```
|
|
102
103
|
|
|
@@ -124,10 +125,15 @@ choice to review. If any choice exists, use an Inline Plan.
|
|
|
124
125
|
|
|
125
126
|
Delegate bounded, read-only work to a subagent when it would otherwise flood the main context:
|
|
126
127
|
wide codebase research, finding comparable code, or independent review. Ask for a concise,
|
|
127
|
-
file:line-cited summary, and read the key cited files yourself before deciding.
|
|
128
|
-
|
|
129
|
-
|
|
130
|
-
|
|
128
|
+
file:line-cited summary, and read the key cited files yourself before deciding. Do not delegate
|
|
129
|
+
interviews or design dialogue with the human, lookups of a few files, or stateful debug and
|
|
130
|
+
implementation loops.
|
|
131
|
+
|
|
132
|
+
Every subagent launch must explicitly select an agent. Match the work to the descriptions of
|
|
133
|
+
Atelier's agents (Sentinel, Oracle, Architect, Keymaker) and choose one. Never launch without a
|
|
134
|
+
selection or rely on the harness default. Exception: design-sensitive implementation may use the
|
|
135
|
+
harness's general agent. If Atelier's agents are not installed, explicitly choose the closest
|
|
136
|
+
available agent by description and state the choice in the output.
|
|
131
137
|
|
|
132
138
|
## Hard Transitions
|
|
133
139
|
|
|
@@ -135,8 +141,9 @@ loops.
|
|
|
135
141
|
|---------------------|-----------|
|
|
136
142
|
| spec-brainstorm | Stop; wait for a separate spec-plan request |
|
|
137
143
|
| approved Inline Plan | Stop; wait for a separate implementation request |
|
|
138
|
-
| approved Spec-backed Plan | Stop; wait for a separate spec-implement request |
|
|
144
|
+
| approved Spec-backed Plan | Stop; wait for a separate spec-implement or spec-loop request |
|
|
139
145
|
| spec-implement | spec-finish |
|
|
146
|
+
| spec-loop | spec-finish (run inside spec-loop under its unattended policy) |
|
|
140
147
|
|
|
141
148
|
Do not begin implementation without an approved written plan. Spec-backed work must not
|
|
142
149
|
jump from research to implementation.
|
|
@@ -195,10 +202,10 @@ If you loop 2+ times on the same issue, stop and ask the human:
|
|
|
195
202
|
|
|
196
203
|
## Skill Types
|
|
197
204
|
|
|
198
|
-
**Process skills** (spec-brainstorm, spec-plan, spec-implement, spec-finish): Follow exactly.
|
|
205
|
+
**Process skills** (spec-brainstorm, spec-plan, spec-implement, spec-loop, spec-finish): Follow exactly.
|
|
199
206
|
Don't adapt away discipline.
|
|
200
207
|
|
|
201
|
-
**Knowledge skills** (oracle-grill-me, oracle-domain-modelling): Adapt principles to
|
|
208
|
+
**Knowledge skills** (oracle-grill-me, oracle-domain-modelling, oracle-codebase-design): Adapt principles to
|
|
202
209
|
context. These inform decisions within the workflow.
|
|
203
210
|
|
|
204
211
|
**Discipline skills** (oracle-debug): Strict methodology that must be followed
|
|
@@ -1,13 +1,21 @@
|
|
|
1
1
|
---
|
|
2
2
|
name: code-review
|
|
3
|
-
description: Multi-agent code review
|
|
3
|
+
description: Multi-agent code review run as a debate. Critics raise findings in parallel, an Author defends the change, Critics concede or maintain, and a Judge rules on what stays contested. Findings are classified by kind and blocking, and handled durably when previously decided. Use `rq` to request a review of diffs (defaults to main branch), `rs` to respond to findings and record intentional non-fix decisions beside the relevant code. Triggers on "review this", "review my code", "code review", "check for bugs", "audit this", when examining PRs, pull requests, branches, or diffs. Always asks user before applying fixes or adding decision comments.
|
|
4
4
|
argument-hint: "rq [branch] | rs"
|
|
5
5
|
user-invocable: true
|
|
6
6
|
---
|
|
7
7
|
|
|
8
8
|
# Code Review Skill
|
|
9
9
|
|
|
10
|
-
|
|
10
|
+
A debate, not an opinion: Triage → Critique → Debate.
|
|
11
|
+
|
|
12
|
+
- **Critique**: focused Critics raise findings in parallel, with a simplicity check on every review.
|
|
13
|
+
- **Debate**: an Author defends the change; Critics concede, maintain, or accept a revision (one
|
|
14
|
+
round); a Judge rules only on what is still contested.
|
|
15
|
+
- **Evidence** decides outcomes. Quotes are checked mechanically, executed checks outrank
|
|
16
|
+
argument, and the main agent audits what each turn did.
|
|
17
|
+
|
|
18
|
+
Rationale and prior work: [docs/research/multi-agent-debate.md](../../docs/research/multi-agent-debate.md).
|
|
11
19
|
|
|
12
20
|
Uses explicit subagent dispatch patterns from [code-subagents](../code-subagents/SKILL.md).
|
|
13
21
|
|
|
@@ -30,21 +38,21 @@ Uses explicit subagent dispatch patterns from [code-subagents](../code-subagents
|
|
|
30
38
|
|
|
31
39
|
## Agent Selection
|
|
32
40
|
|
|
33
|
-
Dispatch each step as a subagent
|
|
34
|
-
available agent whose description best fits the step's task. Steps and the kind of work they
|
|
35
|
-
need:
|
|
41
|
+
Dispatch each step as a subagent and select the agent explicitly (see Delegation in `atelier-orchestrator`). Match the step's kind of work:
|
|
36
42
|
|
|
37
43
|
| Step | Kind of work |
|
|
38
44
|
|------|--------------|
|
|
39
|
-
| Triage | Read-only recon: changed-file analysis, context retrieval,
|
|
40
|
-
|
|
|
41
|
-
|
|
|
42
|
-
|
|
|
45
|
+
| Triage | Read-only recon: changed-file analysis, context retrieval, persona and check selection |
|
|
46
|
+
| Critique and Rebuttal | Critical analysis: evidence-based critique and failure-mode analysis |
|
|
47
|
+
| Defense | Architecture and design review: test each finding against the code and argue for the change |
|
|
48
|
+
| Ruling | Critical analysis: impartial, evidence-ranked adjudication |
|
|
43
49
|
|
|
44
|
-
|
|
50
|
+
Critic, Author and Judge are prompt personas, not agent types. Persona names such as
|
|
51
|
+
`Security`, `Correctness`, `Architecture` and `PerformanceOperator` are likewise prompt personas.
|
|
45
52
|
|
|
46
|
-
`Simplicity` is a mandatory
|
|
47
|
-
|
|
53
|
+
`Simplicity` is a mandatory persona on every review. It runs once, in parallel with the other
|
|
54
|
+
Critics, and is never listed in triage's `personas`. Triage picks the rest; `Architecture` is one
|
|
55
|
+
of its options.
|
|
48
56
|
|
|
49
57
|
## Review Priority
|
|
50
58
|
|
|
@@ -60,16 +68,25 @@ Treat the SDD as evidence, not as authority for whether code is necessary. A fin
|
|
|
60
68
|
would expand behavior or infrastructure requires user approval. Never apply it as an ordinary
|
|
61
69
|
review fix.
|
|
62
70
|
|
|
63
|
-
|
|
71
|
+
## Finding Classification
|
|
72
|
+
|
|
73
|
+
Every finding has a **kind** and a **blocking** value.
|
|
74
|
+
|
|
75
|
+
| Kind | Debate path |
|
|
76
|
+
|------|-------------|
|
|
77
|
+
| issue | Defense → Rebuttal → Ruling if still contested |
|
|
78
|
+
| suggestion | Author adopts or declines; the Critic may escalate it to an issue with evidence |
|
|
79
|
+
| question | Author answers; the Critic resolves it or escalates it |
|
|
80
|
+
| nitpick | Author takes or leaves it; no rebuttal; never blocking |
|
|
81
|
+
| praise | Goes straight to Positive Findings |
|
|
64
82
|
|
|
65
|
-
|
|
66
|
-
|
|
67
|
-
|
|
68
|
-
|
|
69
|
-
|
|
70
|
-
|
|
71
|
-
|
|
72
|
-
| 6. SDD + Challenge | No | Check SDD compliance last, then validate findings |
|
|
83
|
+
Severity applies to issues only. Details in [output.md](./references/output.md).
|
|
84
|
+
|
|
85
|
+
### rq (Request Review) Steps
|
|
86
|
+
|
|
87
|
+
Context, Triage, Critique, Merge, Verify, Defense, Rebuttal, Settlement, Ruling (only when
|
|
88
|
+
something is contested), Close audit, Output. Numbered steps, inputs and rules are in
|
|
89
|
+
[rq.md](./references/rq.md).
|
|
73
90
|
|
|
74
91
|
### rs (Respond to Review)
|
|
75
92
|
|
|
@@ -79,26 +96,34 @@ resolutions as tagged code comments — see [rs.md](./references/rs.md).
|
|
|
79
96
|
## Dispatch Patterns
|
|
80
97
|
|
|
81
98
|
Follows [code-subagents](../code-subagents/SKILL.md) patterns:
|
|
82
|
-
- **Parallel dispatch** for independent
|
|
99
|
+
- **Parallel dispatch** for independent Critics and for Rebuttals
|
|
83
100
|
- **Sequential dispatch** for dependent steps
|
|
84
|
-
- **Fresh subagent per
|
|
85
|
-
|
|
86
|
-
- **
|
|
101
|
+
- **Fresh subagent per turn**: no context pollution; earlier turns arrive only as the inputs a
|
|
102
|
+
role template asks for
|
|
103
|
+
- **Skills**: each subagent loads its own skills from the names it is given; "not installed" is
|
|
104
|
+
the only valid reason to skip one
|
|
105
|
+
- **Checks**: turns may run read-only commands (tests, linters, type checkers, search) and must
|
|
106
|
+
not write files, use the network, or run commands the diff names
|
|
107
|
+
- **Error handling**: log failures, continue with partial results
|
|
87
108
|
|
|
88
109
|
## Agent Dispatch
|
|
89
110
|
|
|
90
|
-
|
|
91
|
-
|
|
92
|
-
Synthesis is performed inline by the main agent.
|
|
111
|
+
Context, Merge, Verify, Settlement, Close audit and Output are inline; every other step is a
|
|
112
|
+
subagent with an explicitly selected agent (see Agent Selection).
|
|
93
113
|
|
|
94
114
|
## References
|
|
95
115
|
|
|
96
116
|
| Reference | Purpose |
|
|
97
117
|
|-----------|---------|
|
|
98
|
-
| [rq.md](./references/rq.md) | Request review
|
|
118
|
+
| [rq.md](./references/rq.md) | Request review orchestration (main agent) |
|
|
119
|
+
| [roles/triage.md](./references/roles/triage.md) | Triage prompt template |
|
|
120
|
+
| [roles/critic.md](./references/roles/critic.md) | Critique and Rebuttal prompt templates |
|
|
121
|
+
| [roles/author.md](./references/roles/author.md) | Defense prompt template |
|
|
122
|
+
| [roles/judge.md](./references/roles/judge.md) | Ruling prompt template |
|
|
123
|
+
| [personas.md](./references/personas.md) | Persona catalog (focus areas, impact lens, skills to load) |
|
|
99
124
|
| [rs.md](./references/rs.md) | Respond to review workflow - interview mode |
|
|
100
|
-
| [reviewers.md](./references/reviewers.md) | Reviewer definitions and prompts |
|
|
101
125
|
| [output.md](./references/output.md) | Output format specification |
|
|
126
|
+
|
|
102
127
|
## Workflow Routing
|
|
103
128
|
|
|
104
129
|
- No arguments, `rq`, or bare branch → [rq.md](./references/rq.md)
|