@martian-engineering/lossless-claw 0.5.2 → 0.6.0

package/src/plugin/lcm-doctor-shared.ts

@@ -0,0 +1,210 @@
+import type { DatabaseSync } from "node:sqlite";
+
+export const FALLBACK_SUMMARY_MARKER = "[LCM fallback summary; truncated for context management]";
+export const TRUNCATED_SUMMARY_PREFIX = "[Truncated from ";
+export const TRUNCATED_SUMMARY_WINDOW = 40;
+export const FALLBACK_SUMMARY_WINDOW = 80;
+
+export type DoctorMarkerKind = "old" | "new" | "fallback";
+
+export type DoctorSummaryCandidate = {
+  conversationId: number;
+  summaryId: string;
+  markerKind: DoctorMarkerKind;
+};
+
+export type DoctorConversationCounts = {
+  total: number;
+  old: number;
+  truncated: number;
+  fallback: number;
+};
+
+export type DoctorSummaryStats = {
+  candidates: DoctorSummaryCandidate[];
+  total: number;
+  old: number;
+  truncated: number;
+  fallback: number;
+  byConversation: Map<number, DoctorConversationCounts>;
+};
+
+export type DoctorTargetRecord = {
+  conversationId: number;
+  summaryId: string;
+  kind: string;
+  depth: number;
+  tokenCount: number;
+  content: string;
+  createdAt: string;
+  childCount: number;
+  markerKind: DoctorMarkerKind;
+};
+
+type DoctorTargetRow = {
+  conversation_id: number;
+  summary_id: string;
+  kind: string;
+  depth: number;
+  token_count: number;
+  content: string;
+  created_at: string;
+  child_count: number | null;
+};
+
+/**
+ * Detect broken summary markers that doctor should flag or repair.
+ */
+export function detectDoctorMarker(content: string): DoctorMarkerKind | null {
+  if (content.startsWith(FALLBACK_SUMMARY_MARKER)) {
+    return "old";
+  }
+
+  const truncatedIndex = content.indexOf(TRUNCATED_SUMMARY_PREFIX);
+  if (truncatedIndex >= 0 && content.length - truncatedIndex < TRUNCATED_SUMMARY_WINDOW) {
+    return "new";
+  }
+
+  const fallbackIndex = content.indexOf(FALLBACK_SUMMARY_MARKER);
+  if (fallbackIndex >= 0 && content.length - fallbackIndex < FALLBACK_SUMMARY_WINDOW) {
+    return "fallback";
+  }
+
+  return null;
+}
+
+/**
+ * Load doctor targets for one conversation or the whole DB.
+ */
+export function loadDoctorTargets(
+  db: DatabaseSync,
+  conversationId?: number,
+): DoctorTargetRecord[] {
+  const statement = conversationId === undefined
+    ? db.prepare(
+        `SELECT
+           s.conversation_id,
+           s.summary_id,
+           s.kind,
+           COALESCE(s.depth, 0) AS depth,
+           COALESCE(s.token_count, 0) AS token_count,
+           COALESCE(s.content, '') AS content,
+           COALESCE(s.created_at, '') AS created_at,
+           COALESCE(spc.child_count, 0) AS child_count
+         FROM summaries s
+         LEFT JOIN (
+           SELECT summary_id, COUNT(*) AS child_count
+           FROM summary_parents
+           GROUP BY summary_id
+         ) spc ON spc.summary_id = s.summary_id
+         WHERE INSTR(COALESCE(s.content, ''), ?) > 0
+            OR INSTR(COALESCE(s.content, ''), ?) > 0
+         ORDER BY s.conversation_id ASC, COALESCE(s.depth, 0) ASC, s.created_at ASC, s.summary_id ASC`,
+      )
+    : db.prepare(
+        `SELECT
+           s.conversation_id,
+           s.summary_id,
+           s.kind,
+           COALESCE(s.depth, 0) AS depth,
+           COALESCE(s.token_count, 0) AS token_count,
+           COALESCE(s.content, '') AS content,
+           COALESCE(s.created_at, '') AS created_at,
+           COALESCE(spc.child_count, 0) AS child_count
+         FROM summaries s
+         LEFT JOIN (
+           SELECT summary_id, COUNT(*) AS child_count
+           FROM summary_parents
+           GROUP BY summary_id
+         ) spc ON spc.summary_id = s.summary_id
+         WHERE s.conversation_id = ?
+           AND (
+             INSTR(COALESCE(s.content, ''), ?) > 0
+             OR INSTR(COALESCE(s.content, ''), ?) > 0
+           )
+         ORDER BY COALESCE(s.depth, 0) ASC, s.created_at ASC, s.summary_id ASC`,
+      );
+
+  const rows = (conversationId === undefined
+    ? statement.all(FALLBACK_SUMMARY_MARKER, TRUNCATED_SUMMARY_PREFIX)
+    : statement.all(conversationId, FALLBACK_SUMMARY_MARKER, TRUNCATED_SUMMARY_PREFIX)) as DoctorTargetRow[];
+
+  const targets: DoctorTargetRecord[] = [];
+  for (const row of rows) {
+    const markerKind = detectDoctorMarker(row.content);
+    if (!markerKind) {
+      continue;
+    }
+    targets.push({
+      conversationId: row.conversation_id,
+      summaryId: row.summary_id,
+      kind: row.kind,
+      depth: Math.max(0, Math.floor(row.depth ?? 0)),
+      tokenCount: Math.max(0, Math.floor(row.token_count ?? 0)),
+      content: row.content,
+      createdAt: row.created_at,
+      childCount:
+        typeof row.child_count === "number" && Number.isFinite(row.child_count)
+          ? Math.max(0, Math.floor(row.child_count))
+          : 0,
+      markerKind,
+    });
+  }
+  return targets;
+}
+
+/**
+ * Aggregate doctor counts from target rows.
+ */
+export function getDoctorSummaryStats(
+  db: DatabaseSync,
+  conversationId?: number,
+): DoctorSummaryStats {
+  const targets = loadDoctorTargets(db, conversationId);
+  const candidates: DoctorSummaryCandidate[] = [];
+  const byConversation = new Map<number, DoctorConversationCounts>();
+  let old = 0;
+  let truncated = 0;
+  let fallback = 0;
+
+  for (const target of targets) {
+    const current = byConversation.get(target.conversationId) ?? {
+      total: 0,
+      old: 0,
+      truncated: 0,
+      fallback: 0,
+    };
+    current.total += 1;
+
+    switch (target.markerKind) {
+      case "old":
+        old += 1;
+        current.old += 1;
+        break;
+      case "new":
+        truncated += 1;
+        current.truncated += 1;
+        break;
+      case "fallback":
+        fallback += 1;
+        current.fallback += 1;
+        break;
+    }
+
+    byConversation.set(target.conversationId, current);
+    candidates.push({
+      conversationId: target.conversationId,
+      summaryId: target.summaryId,
+      markerKind: target.markerKind,
+    });
+  }
+
+  return {
+    candidates,
+    total: candidates.length,
+    old,
+    truncated,
+    fallback,
+    byConversation,
+  };
+}

package/src/store/conversation-store.ts

@@ -2,6 +2,7 @@ import type { DatabaseSync } from "node:sqlite";
 import { randomUUID } from "node:crypto";
 import { sanitizeFts5Query } from "./fts5-sanitize.js";
 import { buildLikeSearchPlan, containsCjk, createFallbackSnippet } from "./full-text-fallback.js";
+import { parseUtcTimestamp, parseUtcTimestampOrNull } from "./parse-utc-timestamp.js";
 
 export type ConversationId = number;
 export type MessageId = number;
@@ -69,12 +70,16 @@ export type CreateConversationInput = {
   sessionId: string;
   sessionKey?: string;
   title?: string;
+  active?: boolean;
+  archivedAt?: Date | null;
 };
 
 export type ConversationRecord = {
   conversationId: ConversationId;
   sessionId: string;
   sessionKey: string | null;
+  active: boolean;
+  archivedAt: Date | null;
   title: string | null;
   bootstrappedAt: Date | null;
   createdAt: Date;
@@ -105,6 +110,8 @@ interface ConversationRow {
   conversation_id: number;
   session_id: string;
   session_key: string | null;
+  active: number;
+  archived_at: string | null;
   title: string | null;
   bootstrapped_at: string | null;
   created_at: string;
@@ -159,10 +166,12 @@ function toConversationRecord(row: ConversationRow): ConversationRecord {
     conversationId: row.conversation_id,
     sessionId: row.session_id,
     sessionKey: row.session_key ?? null,
+    active: row.active === 1,
+    archivedAt: parseUtcTimestampOrNull(row.archived_at),
     title: row.title,
-    bootstrappedAt: row.bootstrapped_at ? new Date(row.bootstrapped_at) : null,
-    createdAt: new Date(row.created_at),
-    updatedAt: new Date(row.updated_at),
+    bootstrappedAt: parseUtcTimestampOrNull(row.bootstrapped_at),
+    createdAt: parseUtcTimestamp(row.created_at),
+    updatedAt: parseUtcTimestamp(row.updated_at),
   };
 }
 
@@ -174,7 +183,7 @@ function toMessageRecord(row: MessageRow): MessageRecord {
     role: row.role,
     content: row.content,
     tokenCount: row.token_count,
-    createdAt: new Date(row.created_at),
+    createdAt: parseUtcTimestamp(row.created_at),
   };
 }
 
@@ -184,7 +193,7 @@ function toSearchResult(row: MessageSearchRow): MessageSearchResult {
     conversationId: row.conversation_id,
     role: row.role,
     snippet: row.snippet,
-    createdAt: new Date(row.created_at),
+    createdAt: parseUtcTimestamp(row.created_at),
     rank: row.rank,
   };
 }
@@ -276,12 +285,21 @@ export class ConversationStore {
 
   async createConversation(input: CreateConversationInput): Promise<ConversationRecord> {
     const result = this.db
-      .prepare(`INSERT INTO conversations (session_id, session_key, title) VALUES (?, ?, ?)`)
-      .run(input.sessionId, input.sessionKey ?? null, input.title ?? null);
+      .prepare(
+        `INSERT INTO conversations (session_id, session_key, active, archived_at, title)
+         VALUES (?, ?, ?, ?, ?)`,
+      )
+      .run(
+        input.sessionId,
+        input.sessionKey ?? null,
+        input.active === false ? 0 : 1,
+        input.archivedAt?.toISOString() ?? null,
+        input.title ?? null,
+      );
 
     const row = this.db
       .prepare(
-        `SELECT conversation_id, session_id, session_key, title, bootstrapped_at, created_at, updated_at
+        `SELECT conversation_id, session_id, session_key, active, archived_at, title, bootstrapped_at, created_at, updated_at
        FROM conversations WHERE conversation_id = ?`,
       )
       .get(Number(result.lastInsertRowid)) as unknown as ConversationRow;
@@ -292,7 +310,7 @@ export class ConversationStore {
   async getConversation(conversationId: ConversationId): Promise<ConversationRecord | null> {
     const row = this.db
       .prepare(
-        `SELECT conversation_id, session_id, session_key, title, bootstrapped_at, created_at, updated_at
+        `SELECT conversation_id, session_id, session_key, active, archived_at, title, bootstrapped_at, created_at, updated_at
        FROM conversations WHERE conversation_id = ?`,
       )
       .get(conversationId) as unknown as ConversationRow | undefined;
@@ -303,10 +321,10 @@ export class ConversationStore {
   async getConversationBySessionId(sessionId: string): Promise<ConversationRecord | null> {
     const row = this.db
       .prepare(
-        `SELECT conversation_id, session_id, session_key, title, bootstrapped_at, created_at, updated_at
+        `SELECT conversation_id, session_id, session_key, active, archived_at, title, bootstrapped_at, created_at, updated_at
        FROM conversations
        WHERE session_id = ?
-       ORDER BY created_at DESC
+       ORDER BY active DESC, created_at DESC
        LIMIT 1`,
       )
       .get(sessionId) as unknown as ConversationRow | undefined;
@@ -317,9 +335,11 @@ export class ConversationStore {
   async getConversationBySessionKey(sessionKey: string): Promise<ConversationRecord | null> {
     const row = this.db
       .prepare(
-        `SELECT conversation_id, session_id, session_key, title, bootstrapped_at, created_at, updated_at
+        `SELECT conversation_id, session_id, session_key, active, archived_at, title, bootstrapped_at, created_at, updated_at
        FROM conversations
        WHERE session_key = ?
+         AND active = 1
+       ORDER BY created_at DESC
        LIMIT 1`,
       )
       .get(sessionKey) as unknown as ConversationRow | undefined;
@@ -353,8 +373,9 @@ export class ConversationStore {
     titleOrOpts?: string | { title?: string; sessionKey?: string },
   ): Promise<ConversationRecord> {
     const opts = typeof titleOrOpts === "string" ? { title: titleOrOpts } : titleOrOpts ?? {};
-    if (opts.sessionKey) {
-      const byKey = await this.getConversationBySessionKey(opts.sessionKey);
+    const normalizedSessionKey = opts.sessionKey?.trim();
+    if (normalizedSessionKey) {
+      const byKey = await this.getConversationBySessionKey(normalizedSessionKey);
       if (byKey) {
         if (byKey.sessionId !== sessionId) {
           this.db
@@ -370,18 +391,24 @@ export class ConversationStore {
 
     const existing = await this.getConversationBySessionId(sessionId);
     if (existing) {
-      if (opts.sessionKey && !existing.sessionKey) {
+      if (!normalizedSessionKey) {
+        return existing;
+      }
+      if (existing.active && !existing.sessionKey) {
         this.db
           .prepare(
             `UPDATE conversations SET session_key = ?, updated_at = datetime('now') WHERE conversation_id = ?`,
           )
-          .run(opts.sessionKey, existing.conversationId);
-        existing.sessionKey = opts.sessionKey;
+          .run(normalizedSessionKey, existing.conversationId);
+        existing.sessionKey = normalizedSessionKey;
+        return existing;
+      }
+      if (existing.active && existing.sessionKey === normalizedSessionKey) {
+        return existing;
       }
-      return existing;
     }
 
-    return this.createConversation({ sessionId, title: opts.title, sessionKey: opts.sessionKey });
+    return this.createConversation({ sessionId, title: opts.title, sessionKey: normalizedSessionKey });
   }
 
   async markConversationBootstrapped(conversationId: ConversationId): Promise<void> {
@@ -395,6 +422,18 @@ export class ConversationStore {
       .run(conversationId);
   }
 
+  async archiveConversation(conversationId: ConversationId): Promise<void> {
+    this.db
+      .prepare(
+        `UPDATE conversations
+       SET active = 0,
+           archived_at = COALESCE(archived_at, datetime('now')),
+           updated_at = datetime('now')
+       WHERE conversation_id = ?`,
+      )
+      .run(conversationId);
+  }
+
   // ── Message operations ────────────────────────────────────────────────────
 
   async createMessage(input: CreateMessageInput): Promise<MessageRecord> {
@@ -817,7 +856,7 @@ export class ConversationStore {
           conversationId: row.conversation_id,
           role: row.role,
           snippet: createFallbackSnippet(normalizedContent, plan.terms),
-          createdAt: new Date(row.created_at),
+          createdAt: parseUtcTimestamp(row.created_at),
           rank: 0,
         };
       })
@@ -882,7 +921,7 @@ export class ConversationStore {
           conversationId: row.conversation_id,
           role: row.role,
           snippet: match[0],
-          createdAt: new Date(row.created_at),
+          createdAt: parseUtcTimestamp(row.created_at),
           rank: 0,
         });
       }

package/src/store/parse-utc-timestamp.ts

@@ -0,0 +1,25 @@
+/**
+ * Parse a SQLite UTC timestamp string into a Date object.
+ * SQLite stores timestamps via datetime('now') without a Z suffix,
+ * which causes JS to parse them as local time instead of UTC.
+ * See: https://github.com/Martian-Engineering/lossless-claw/issues/216
+ */
+export function parseUtcTimestamp(value: string): Date {
+  const s = value.trim();
+  if (/(?:[zZ]|[+-]\d{2}:\d{2})$/.test(s)) {
+    return new Date(s);
+  }
+
+  const normalized = s.includes("T") ? s : s.replace(" ", "T");
+  return new Date(`${normalized}Z`);
+}
+
+/**
+ * Parse a nullable SQLite UTC timestamp string into a Date object.
+ */
+export function parseUtcTimestampOrNull(
+  value: string | null | undefined,
+): Date | null {
+  if (value == null) return null;
+  return parseUtcTimestamp(value);
+}