@mars-stack/cli 8.0.1 → 8.0.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mars-stack/cli",
-  "version": "8.0.1",
+  "version": "8.0.2",
   "description": "MARS CLI: scaffold, configure, and maintain SaaS apps",
   "license": "MIT",
   "repository": {

package/template/.cursor/rules/mars-testing.mdc

@@ -27,4 +27,4 @@ alwaysApply: false
 
 End-to-end specs live in **`e2e/`** (`yarn test:e2e`). When you add or materially change **user-facing** behaviour (pages, flows, CLI-generated features), extend **`e2e/*.spec.ts`** so at least one **stable happy path** is covered. Prefer role/label selectors; avoid sleep-only assertions.
 
-**Mars monorepo:** The template’s catalog and CLI-wide CI expectations are defined in **`docs/design-docs/scaffold-testing-strategy.md`** (Decision 7) and ticket **MARS-041**; update **`template/e2e/`** and its README when you change generators or template routes.
+**Mars monorepo:** Catalog and CI expectations are in **`docs/design-docs/scaffold-testing-strategy.md`** (Decision 7). Update **`template/e2e/`** (baseline), **`template/e2e-kitchen-sink/`** (kitchen-sink catalog), and **`template/e2e/README.md`** when you change generators or template routes. See **MARS-041** (done).

package/template/e2e/README.md

@@ -10,7 +10,54 @@ Browser-level tests for user-visible behaviour. Run: `yarn test:e2e` from the pr
 
 Monorepo CI runs this on pull requests via the `template-e2e` job in `.github/workflows/ci.yml` (Postgres service + `E2E_USE_CI_SERVER=1` + `scripts/start-e2e-server.mjs`).
 
-### CI recipe for generated apps
+## Kitchen-sink CLI catalog (MARS-041, Option A)
+
+Full **`mars generate`** surface is exercised against a **materialized kitchen-sink fixture** (not the bare template tree):
+
+| Mechanism | Location |
+|-----------|----------|
+| Spec + Playwright config (source) | `template/e2e-kitchen-sink/` |
+| Runner (materialize → copy spec → build → Playwright) | `scripts/run-kitchen-sink-e2e.ts` |
+| Shared materialization (also used by Tier 2 matrix) | `scripts/scaffold-fixture-materialize.ts` |
+| Local / CI | `yarn test:e2e:kitchen-sink` — CI job `kitchen-sink-e2e` on PRs when `template/`, `packages/cli/`, or runner scripts change |
+
+## `mars generate` subcommands — inventory
+
+Canonical list: `packages/cli/src/index.ts` (`generate` subcommands). **Status** points to where behaviour is covered.
+
+| CLI command | Spec file(s) | Status |
+|-------------|--------------|--------|
+| _(baseline)_ | `auth.spec.ts`, `public.spec.ts`, `api.spec.ts`, `smoke.spec.ts` | Partial — template auth, public, API, CSRF smoke |
+| `blog` | `blog-disabled.spec.ts` (template: feature off → 404) | **Kitchen-sink:** `e2e-kitchen-sink/kitchen-sink-catalog.spec.ts` |
+| `dark-mode` | — | **Kitchen-sink** catalog |
+| `notifications` | — | **Kitchen-sink** catalog |
+| `analytics` | — | **Kitchen-sink** catalog (ConsentBanner) |
+| `command-palette` | — | **Kitchen-sink** catalog |
+| `onboarding` | — | **Kitchen-sink** catalog |
+| `search` | — | **Kitchen-sink** catalog |
+| `realtime` | — | **Kitchen-sink** catalog (SSE open) |
+| `ai` | — | **Kitchen-sink** catalog (UI + no-key / disabled send) |
+| `cookie-consent` | — | **Kitchen-sink** catalog |
+| `coming-soon` | — | **Kitchen-sink** catalog |
+| `sentry` | — | **Kitchen-sink** catalog (no client `pageerror`) |
+| `feature-flags` | — | **Kitchen-sink** catalog (protected GET JSON) |
+
+## Scaffold-time features (`mars create`, user-visible)
+
+| Area | Spec file(s) | Status |
+|------|--------------|--------|
+| Billing | — | **Kitchen-sink** catalog (`/pricing`) |
+| File upload | — | **Kitchen-sink** catalog (`/files`) |
+
+## Waivers
+
+| Item | Reason |
+|------|--------|
+| **`mars add` subcommands** | Out of scope for MARS-041 — no required new specs per ticket non-goals |
+| **Generators with no stable UI** | None in the MARS-041 table; if added, document here with rationale |
+| **Mobile project in CI** | `playwright.config.ts` includes **mobile** for local runs; **`template-e2e`** and **`kitchen-sink-e2e`** run **desktop Chromium only** in CI to control minutes — intentional |
+
+## CI recipe for generated apps
 
 Copy the **`template-e2e`** job from the Mars repo’s `.github/workflows/ci.yml` into your project workflow, or mirror its steps:
 
@@ -22,44 +69,14 @@ Copy the **`template-e2e`** job from the Mars repo’s `.github/workflows/ci.yml
 
 If `DATABASE_URL` is missing or wrong, API routes fail at runtime and mutations can surface as 500s instead of deterministic CSRF 403s — fix env before interpreting smoke failures.
 
-## Monorepo constraint (MARS-041)
-
-The Mars **template package** in this repo is the pre-generator baseline. Most `mars generate` features are **not** present under `template/src/features/` until generators run (as in `scripts/test-scaffold-matrix.ts` with the **kitchen-sink** fixture). Full CLI catalog E2E in CI therefore requires **Option A** from MARS-041: scaffold a max-feature app to a working directory, provision `JWT_SECRET` / `DATABASE_URL`, then run Playwright from **that** tree. Specs in this folder exercise whatever the committed template actually contains (today: auth, public, API baseline); the README inventory below tracks **target** coverage once the scaffolded-app E2E job exists.
-
 ## When to update
 
 Whenever you add or change a feature that ships **UI or routes** (including features originally added via the Mars CLI’s `generate` commands), add or extend a spec here and update the tables below.
 
-**Mars monorepo contributors:** Follow **Decision 7** in `docs/design-docs/scaffold-testing-strategy.md` and ticket **MARS-041** (CLI-wide E2E coverage + CI). Keep this inventory in sync with `packages/cli/src/index.ts` `generate` subcommands.
+**Mars monorepo contributors:** Follow **Decision 7** in `docs/design-docs/scaffold-testing-strategy.md`. For CLI-only surfaces, update **`template/e2e-kitchen-sink/kitchen-sink-catalog.spec.ts`** and keep this inventory in sync.
 
 Use **local / console / `none`** providers so tests do not require paid third-party accounts.
 
-## `mars generate` subcommands (catalog)
-
-| CLI command | Spec file(s) | Status |
-|-------------|--------------|--------|
-| _(baseline)_ | `auth.spec.ts`, `public.spec.ts`, `api.spec.ts` | Partial (auth, public, API smoke) |
-| `blog` | — | Missing |
-| `dark-mode` | — | Missing |
-| `notifications` | — | Missing |
-| `analytics` | — | Missing |
-| `command-palette` | — | Missing |
-| `onboarding` | — | Missing |
-| `search` | — | Missing |
-| `realtime` | — | Missing |
-| `ai` | — | Missing |
-| `cookie-consent` | — | Missing |
-| `coming-soon` | — | Missing |
-| `sentry` | — | Missing |
-| `feature-flags` | — | Missing |
-
-## Scaffold-time features (`mars create`, user-visible)
-
-| Area | Spec file(s) | Status |
-|------|--------------|--------|
-| Billing | — | Missing |
-| File upload | — | Missing |
-
-## Waivers
+## Non-goals (MARS-041)
 
-Document here if a feature intentionally has **no** E2E (e.g. server-only with no stable UI) and why.
+- `mars add page|model|component|email` — no required new specs in MARS-041; defer to future tickets.

package/template/e2e/blog-disabled.spec.ts

@@ -0,0 +1,12 @@
+import { test, expect } from '@playwright/test';
+
+/**
+ * Baseline template ships with blog feature off — /blog must not exist (no crash).
+ * Kitchen-sink catalog (MARS-041) covers blog when generators run.
+ */
+test.describe('Feature disabled: blog (template baseline)', () => {
+  test('blog route shows not-found when feature not generated', async ({ page }) => {
+    await page.goto('/blog');
+    await expect(page.getByRole('heading', { name: 'Page not found' })).toBeVisible();
+  });
+});

package/template/e2e-kitchen-sink/kitchen-sink-catalog.spec.ts

@@ -0,0 +1,179 @@
+import { test, expect } from '@playwright/test';
+import type { Page } from '@playwright/test';
+
+const SEEDED_USER_EMAIL = 'user@example.com';
+const SEEDED_USER_PASSWORD = 'Password123!';
+
+/**
+ * Kitchen-sink enables onboarding + dashboard redirect until flow completes.
+ */
+async function signInWithSeededUser(page: Page): Promise<void> {
+  await page.goto('/sign-in');
+  await page.getByLabel('Email Address').fill(SEEDED_USER_EMAIL);
+  await page.getByLabel('Password', { exact: true }).fill(SEEDED_USER_PASSWORD);
+  await page.getByRole('button', { name: /^sign in$/i }).click();
+  await page.waitForURL(/\/dashboard|\/onboarding/, { timeout: 60_000 });
+
+  for (let i = 0; i < 10 && page.url().includes('/onboarding'); i++) {
+    const complete = page.getByRole('button', { name: 'Complete Step' });
+    await expect(complete).toBeVisible({ timeout: 30_000 });
+    await complete.click();
+    await page.waitForURL(/\/dashboard|\/onboarding/, { timeout: 60_000 });
+  }
+
+  await expect(page).toHaveURL(/\/dashboard/);
+}
+
+test.describe('Kitchen-sink CLI catalog (MARS-041)', () => {
+  test.describe.configure({ timeout: 120_000 });
+
+  test('blog: listing page shows Blog heading', async ({ page }) => {
+    await page.goto('/blog');
+    await expect(page.getByRole('heading', { name: 'Blog' })).toBeVisible();
+  });
+
+  test('dark-mode: theme toggle is present and clickable', async ({ page }) => {
+    await page.goto('/');
+    const toggle = page.getByRole('button', { name: /switch to .* theme/i });
+    await expect(toggle.first()).toBeVisible();
+    await toggle.first().click();
+  });
+
+  test('notifications: bell control is visible', async ({ page }) => {
+    await page.goto('/dashboard');
+    await expect(page.getByRole('button', { name: /^Notifications/i })).toBeVisible();
+  });
+
+  test('analytics: consent banner accept dismisses banner', async ({ page }) => {
+    await page.goto('/');
+    await expect(page.getByText('Cookie usage')).toBeVisible();
+    await page.getByRole('button', { name: 'Accept' }).click();
+    await expect(page.getByText('Cookie usage')).not.toBeVisible();
+  });
+
+  test('command-palette: Ctrl+K opens palette and navigation action works', async ({ page }) => {
+    await page.goto('/dashboard');
+    await page.keyboard.press('Control+K');
+    await expect(page.getByPlaceholder('Type a command or search...')).toBeVisible();
+    await page.getByPlaceholder('Type a command or search...').fill('settings');
+    await page.getByRole('option', { name: /go to settings/i }).click();
+    await expect(page).toHaveURL(/\/settings/);
+  });
+
+  test('onboarding: new user completes steps and reaches dashboard', async ({ page }) => {
+    await page.goto('/sign-in');
+    await page.getByLabel('Email Address').fill(SEEDED_USER_EMAIL);
+    await page.getByLabel('Password', { exact: true }).fill(SEEDED_USER_PASSWORD);
+    await page.getByRole('button', { name: /^sign in$/i }).click();
+    await page.waitForURL(/\/dashboard|\/onboarding/, { timeout: 60_000 });
+    if (page.url().includes('/onboarding')) {
+      await expect(
+        page.getByRole('heading', { name: /welcome! let's get you set up/i }),
+      ).toBeVisible();
+    }
+    await signInWithSeededUser(page);
+  });
+
+  test('search: nav search input accepts text (debounce surface)', async ({ page }) => {
+    await page.goto('/dashboard');
+    const search = page.getByPlaceholder('Search…');
+    await expect(search).toBeVisible();
+    await search.fill('test query');
+    await expect(search).toHaveValue('test query');
+  });
+
+  test('realtime: authenticated EventSource opens SSE stream', async ({ page }) => {
+    await signInWithSeededUser(page);
+    const result = await page.evaluate(() => {
+      return new Promise<'open' | 'error'>((resolve) => {
+        const es = new EventSource('/api/protected/realtime/stream?channel=e2e-smoke');
+        const timer = window.setTimeout(() => {
+          es.close();
+          resolve('error');
+        }, 20_000);
+        es.onopen = () => {
+          window.clearTimeout(timer);
+          es.close();
+          resolve('open');
+        };
+        es.onerror = () => {
+          window.clearTimeout(timer);
+          es.close();
+          resolve('error');
+        };
+      });
+    });
+    expect(result).toBe('open');
+  });
+
+  test('ai: chat page shows UI; send disabled or missing-key error (no live LLM)', async ({
+    page,
+  }) => {
+    await signInWithSeededUser(page);
+    await page.goto('/ai');
+    await expect(page.getByRole('heading', { name: 'AI Assistant' })).toBeVisible();
+    await expect(page.getByText(/send a message to begin chatting/i)).toBeVisible();
+    const send = page.getByRole('button', { name: 'Send message' });
+    const errorBanner = page.getByText(/OPENAI_API_KEY|API key|not set/i);
+    await expect(send.or(errorBanner).first()).toBeVisible();
+    if (await send.isVisible()) {
+      await expect(send).toBeDisabled();
+    }
+  });
+
+  test('cookie-consent: decline dismisses banner', async ({ page, context }) => {
+    await context.clearCookies();
+    await page.goto('/');
+    await expect(page.getByText('Cookie usage')).toBeVisible();
+    await page.getByRole('button', { name: 'Decline' }).click();
+    await expect(page.getByText('Cookie usage')).not.toBeVisible();
+  });
+
+  test('coming-soon: waitlist form submits and shows thanks', async ({ page }) => {
+    await page.goto('/coming-soon');
+    await expect(page.getByRole('heading', { name: 'Coming Soon' })).toBeVisible();
+    await page.getByPlaceholder('Enter your email').fill('waitlist-e2e@example.com');
+    await page.getByRole('button', { name: /join waitlist/i }).click();
+    await expect(page.getByText(/thanks for joining/i)).toBeVisible();
+  });
+
+  test('sentry: home page loads without client error overlay', async ({ page }) => {
+    const errors: string[] = [];
+    page.on('pageerror', (e) => errors.push(e.message));
+    await page.goto('/');
+    await expect(page.locator('h1').first()).toBeVisible();
+    expect(errors, errors.join('; ')).toHaveLength(0);
+  });
+
+  test('feature-flags: authenticated flag API returns JSON', async ({ page }) => {
+    await signInWithSeededUser(page);
+    const data = await page.evaluate(async () => {
+      const res = await fetch('/api/protected/feature-flags?key=nonexistent-flag-e2e', {
+        credentials: 'include',
+      });
+      const json: unknown = await res.json();
+      return { status: res.status, json };
+    });
+    expect(data.status).toBe(200);
+    expect(data.json).toMatchObject({ value: false });
+  });
+
+  test('billing: pricing page loads when billing enabled', async ({ page }) => {
+    await page.goto('/pricing');
+    await expect(page.getByRole('heading', { name: 'Simple, transparent pricing' })).toBeVisible();
+  });
+
+  test('file upload: files page loads', async ({ page }) => {
+    await signInWithSeededUser(page);
+    await page.goto('/files');
+    await expect(page.getByRole('heading', { name: 'Files' })).toBeVisible();
+  });
+
+  test('auth: unauthenticated user cannot access dashboard', async ({ browser }) => {
+    const context = await browser.newContext();
+    const page = await context.newPage();
+    await page.goto('/dashboard');
+    await expect(page).toHaveURL(/sign-in/);
+    await context.close();
+  });
+});

package/template/e2e-kitchen-sink/playwright.config.ts

@@ -0,0 +1,33 @@
+import { defineConfig, devices } from '@playwright/test';
+
+/**
+ * Playwright config for MARS-041 kitchen-sink scaffold E2E.
+ * Invoked from repo root via `scripts/run-kitchen-sink-e2e.ts` with cwd = materialized project dir.
+ */
+export default defineConfig({
+  testDir: '.',
+  testMatch: 'kitchen-sink-catalog.spec.ts',
+  fullyParallel: false,
+  forbidOnly: !!process.env.CI,
+  retries: process.env.CI ? 2 : 0,
+  workers: 1,
+  reporter: process.env.CI ? 'line' : 'html',
+  use: {
+    baseURL: 'http://localhost:3000',
+    trace: 'on-first-retry',
+    screenshot: 'only-on-failure',
+  },
+  projects: [
+    {
+      name: 'chromium',
+      use: { ...devices['Desktop Chrome'] },
+    },
+  ],
+  webServer: {
+    command: 'node scripts/start-e2e-server.mjs',
+    url: 'http://localhost:3000',
+    reuseExistingServer: false,
+    timeout: 240_000,
+    env: { ...process.env, MARS_CI_KITCHEN_SINK_E2E: '1' },
+  },
+});