@mars-sea/dsh-commandcode-provider 0.11.3 → 0.11.5

package/CHANGELOG.md

@@ -6,6 +6,20 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 
 ## [Unreleased]
 
+## [0.11.5] - 2026-09-18
+
+### Fixed
+- **The composer session-cost figure survives dsh 0.1.6-alpha.2.** That release deleted the `data-composer-stats` marker from the shipped stats row (`StatsPills`) while leaving the row's markup otherwise identical, and the readout's pill lookup *required* that attribute — so there the lookup matched nothing on every sync and the amount silently stopped appearing beside the token pill (after three misses it logged a single console line), leaving only the usage dialog still carrying per-row prices. `STATS_ROOT` is now a PREFERENCE: when the attribute is absent the lookup falls back to the dock OUTLET (`[data-slot="conversation.composer.dock"]`), the `display:contents` div holding exactly that slot's entries — the shipped `stats` cell and ours — whose LAST dialog trigger is therefore still the token pill. The fallback is deliberately the outlet and never the outlet's PARENT: the same release moved the composer's context-usage ring out of the card into a new footer `div` beside the dock, and that ring's trigger is itself a `button[aria-haspopup="dialog"]` rendered AFTER the dock, so the parent-scoped lookup this previously depended on would have appended the cost to the context meter instead. `tests/session-cost-display.test.ts` now builds both the unmarked 0.1.6-alpha.2 row and a footer-sibling meter, and fails if the cost stops landing on the token pill or the meter becomes the host; the earlier suite constructed its own marked row and accepted a missing anchor as a no-op, which is exactly why the deletion could go dark with every check green.
+- **A second composer's usage dialog can no longer be priced with this session's figures.** dsh 0.1.6-alpha.2 mounts an embedded Conversation in the sidebar, so two composers — each with its own session, dock and dialog — can be live and open at once. The dialog is portaled onto `body` and carries no id or `aria-controls` tying it back to its trigger, so the document-level lookup was exact only while a single composer was guaranteed: the per-row shape confirmation compares against THIS entry's counts, so a dialog belonging to the other session that happened to match would have been decorated with the wrong figures. `resolveDialog()` now decorates only while the document holds EXACTLY ONE `[data-session-stats-usage]` and otherwise declines — the same rule the shape check already follows one level down. Pinned by two tests: with two dialogs open neither is priced, and the survivor is priced once the other composer's dialog unmounts.
+
+### Added
+- **dsh 0.1.6-alpha.2 is a declared-compatible engine.** The engine's other changes need no adapter work, and each was verified against the installed release rather than inferred: the Typert strict result codec's member swap (`schema` → the lazy `create()` factory) was already covered by 0.11.4's two-member codec — both the Host and Client contributions register on that release's real registry, which is worth restating because 0.1.6-alpha.2 is the first PUBLISHED engine to require `create()`; `npm run test:engine` passes against it (the bundle links and evaluates there, and the request-image policy is the durable one); every slot this plugin registers into or re-states (`conversation.composer.dock`, `main`, `sidebar.footer.action`, `settings.section`, `settings.models.provider-card`) has an unchanged declaration and the dock still supplies `sessionId`/`useProjection`/`useChat`; the platform seed table, the host packages this plugin imports and the sidebar/footer class stems are unchanged; and the release's new plugin-management page asks nothing of a plugin whose registrations are already cordis effects — which is also what its runtime unload needs. The one genuinely new surface it exposes, a sidebar-mounted embedded Conversation, is what the second fix above defends against.
+
+## [0.11.4] - 2026-09-17
+
+### Fixed
+- **The Command Code Remotes keep registering on the next Harness generation** ([#49](https://github.com/Mars-Sea/dsh-commandcode-provider/issues/49)). The Typert protocol changed the strict result codec's shape inside the same `mode: 'strict'` tag: every released engine (`0.1.2-rc.1` … `0.1.6-alpha.1`, all 21 published versions) declares `schema: TypertSchema` and refuses registration with `strict codec has no parse() method` without it, while master after `e459e3263` replaced that member with the lazy factory `create: () => TypertSchema` and refuses with `strict codec has no create() factory`. All six Command Code Remotes (`report`, `models`, `prices`, `loginBegin`, `loginStatus`, `loginCancel`) come from one descriptor factory that carried `schema` alone, so on that newer generation none of them registers: the settings page's account card, the plans & quota panel, the price table and the browser login all lose their Host data. `makeRemoteDescriptor()` now carries both members, where `create: () => schema` names the same hand-rolled validator rather than a second copy, so the two generations can never validate against different rules. This is a version-agnostic fix instead of a runtime probe: neither generation inspects the member it does not know, and the member the running engine ignores is inert — which matters because a single-member codec is broken in either direction, and the one-line patch the issue proposed (`schema` → `create`) would have fixed unreleased master by breaking every install that exists today. `tests/wire-shared.test.ts` pins it by running both generations' real validators over every shipped descriptor, with negative controls proving that a codec carrying only one member is rejected by the other generation. The helper is inlined into both `lib/index.js` and `lib/client.js`, so a fix is dead until the bundle is rebuilt — hence the rebuilt bundles in this release.
+
 ## [0.11.3] - 2026-09-16
 
 ### Added

package/lib/client.js

@@ -1678,6 +1678,12 @@ window.__ModuleLoader__.load({
 		* only its own facts.
 		*/
 		function makeRemoteDescriptor(endpoint, method, typeSymbol, schema) {
+			const result = {
+				mode: "strict",
+				typeSymbol,
+				schema,
+				create: () => schema
+			};
 			return {
 				id: `${REMOTE_PACKAGE}#${endpoint}`,
 				service: REMOTE_SERVICE,
@@ -1685,11 +1691,7 @@ window.__ModuleLoader__.load({
 				method,
 				invocation: { kind: "direct" },
 				parameters: [],
-				result: {
-					mode: "strict",
-					typeSymbol,
-					schema
-				}
+				result
 			};
 		}
 		//#endregion
@@ -2155,7 +2157,7 @@ window.__ModuleLoader__.load({
 		}
 		//#endregion
 		//#region package.json
-		var version = "0.11.3";
+		var version = "0.11.5";
 		var repository = {
 			"type": "git",
 			"url": "git+https://github.com/Mars-Sea/dsh-commandcode-provider.git"
@@ -5203,12 +5205,25 @@ window.__ModuleLoader__.load({
 		}
 		//#endregion
 		//#region src/client/session-cost-display.ts
-		/** The shipped composer stats row (dsh-client-ui-chat `StatsPills`). */
+		/**
+		* The shipped composer stats row (dsh-client-ui-chat `StatsPills`).
+		*
+		* A PREFERENCE, not a requirement: 0.1.6-alpha.2 dropped this attribute from the
+		* row's root while leaving the rest of the markup identical, so a lookup that
+		* insisted on it would silently stop finding the row on that engine. When it is
+		* absent the search falls back to the dock OUTLET — deliberately the outlet and
+		* never the outlet's parent, because from 0.1.6-alpha.2 the parent is the new
+		* composer footer, which holds the `ContextMeter` as well, and that meter's
+		* trigger is itself a `button[aria-haspopup="dialog"]` rendered AFTER the dock.
+		* A parent-scoped "last trigger wins" would therefore append the cost to the
+		* context ring instead of the token pill.
+		*/
 		const STATS_ROOT = "[data-composer-stats]";
 		/**
-		* The shipped token-usage dialog's `<dl>`. Unique in the whole of
-		* `dsh-client-ui-chat`: the per-message turn-usage panel has its own dialog with
-		* different markup, so the composer's is unambiguous.
+		* The shipped token-usage dialog's `<dl>`. Unique WITHIN one `StatsPills`
+		* render: the per-message turn-usage panel has its own dialog with different
+		* markup, so a single composer's usage dialog is unambiguous. It is not unique
+		* across the document once two composers are live — see {@link resolveDialog}.
 		*/
 		const USAGE_DIALOG = "[data-session-stats-usage]";
 		/**
@@ -5309,7 +5324,7 @@ window.__ModuleLoader__.load({
 					const button = this.resolvePillButton();
 					if (button === null) {
 						this.pillMisses += 1;
-						if (this.pillMisses === MISSES_BEFORE_WARNING) console.warn(`[dsh-commandcode-provider] no ${STATS_ROOT} row to append the session cost to; the figure stays in the usage dialog only`);
+						if (this.pillMisses === MISSES_BEFORE_WARNING) console.warn("[dsh-commandcode-provider] no shipped token pill in this composer's dock outlet to append the session cost to; the figure stays in the usage dialog only");
 						return;
 					}
 					this.pillMisses = 0;
@@ -5333,11 +5348,24 @@ window.__ModuleLoader__.load({
 					if (this.pillA11y.textContent !== described) this.pillA11y.textContent = described;
 				}
 			}
-			/** The shipped token pill, scoped to this entry's own composer. */
+			/**
+			* The shipped token pill, scoped to this entry's own composer.
+			*
+			* The scope is the dock OUTLET (`display: contents`, one per slot), which holds
+			* exactly that slot's entries — the shipped `stats` cell and ours, in their
+			* registration order. {@link STATS_ROOT} narrows that to the stats row on the
+			* engines that still mark it; on the engines that do not, the outlet is
+			* already the narrowest correct container, because the composer footer's
+			* `ContextMeter` sits BESIDE the outlet rather than inside it.
+			*
+			* A missing scope is "no pill", never a document-wide search: the outlet is
+			* what makes this lookup per-composer, and a second composer can be live at
+			* once (0.1.6-alpha.2 mounts an embedded Conversation in the sidebar).
+			*/
 			resolvePillButton() {
-				const root = (this.scope() ?? this.doc).querySelector(STATS_ROOT);
-				if (root === null) return null;
-				const triggers = root.querySelectorAll(DIALOG_TRIGGER);
+				const scope = this.scope();
+				if (scope === null) return null;
+				const triggers = (scope.querySelector(STATS_ROOT) ?? scope).querySelectorAll(DIALOG_TRIGGER);
 				return triggers.length === 0 ? null : triggers[triggers.length - 1] ?? null;
 			}
 			/**
@@ -5460,18 +5488,30 @@ window.__ModuleLoader__.load({
 				this.dialogPrices.delete(dd);
 			}
 			/**
-			* The shipped usage dialog, or null while it is closed.
+			* The shipped usage dialog, or null while it is closed (or ambiguous).
 			*
 			* The dialog is portaled onto `body`, so unlike the pill it cannot be scoped
-			* from this entry; DSH renders one composer, and the attribute is unique in
-			* the chat client, so a document-level lookup is exact. Should a future build
-			* mount two composers at once, both dialogs would describe whichever session
-			* this entry belongs to — noted rather than defended against.
+			* from this entry, and the attribute is unique per DIALOG rather than per
+			* document. While one composer was guaranteed, a document-level lookup was
+			* exact. 0.1.6-alpha.2 ends that guarantee: it mounts an embedded Conversation
+			* in the sidebar, so a second composer — with its own session, its own dock
+			* and its own dialog — can be live and open at the same time.
+			*
+			* There is no DOM link from a dialog back to its trigger (the portaled panel
+			* carries no id and no `aria-controls`), so with two dialogs open document
+			* order says nothing about ownership. The shape confirmation in
+			* {@link dialogShapeMatches} would usually reject the stranger, but it compares
+			* against THIS entry's counts, so a coincidentally matching dialog would be
+			* priced with another session's figures. Ambiguity is therefore answered by
+			* declining to decorate at all — the same rule the shape check already
+			* follows, applied one level up: a dialog we cannot prove is ours is left
+			* alone.
 			*/
 			resolveDialog() {
 				if (this.dialogHost?.isConnected === true) return this.dialogHost;
 				this.clearDialog();
-				return this.doc.querySelector(USAGE_DIALOG);
+				const dialogs = this.doc.querySelectorAll(USAGE_DIALOG);
+				return dialogs.length === 1 ? dialogs[0] ?? null : null;
 			}
 			/** Give the dialog back: every price removed, every hidden row restored. */
 			clearDialog() {
@@ -5542,7 +5582,17 @@ window.__ModuleLoader__.load({
 		}
 		//#endregion
 		//#region src/client/session-cost-view.tsx
-		/** The dock outlet this entry renders inside, i.e. what it can scope itself from. */
+		/**
+		* The dock outlet this entry renders inside, i.e. what it scopes itself from.
+		*
+		* The OUTLET itself, not its parent. The outlet is one `display:contents` div
+		* holding exactly this slot's entries (the shipped `stats` cell and ours), so it
+		* is the narrowest container that is still per-composer. Its parent is NOT:
+		* from 0.1.6-alpha.2 the composer stacks the dock inside a footer that also
+		* holds the `ContextMeter`, whose trigger is another
+		* `button[aria-haspopup="dialog"]` rendered after the dock — scoping to the
+		* parent would let the cost land on the context ring.
+		*/
 		const DOCK_ANCHOR = "[data-slot=\"conversation.composer.dock\"]";
 		/** Module-level constant so the marker's `style` prop never diffs. */
 		const HIDDEN_STYLE = { display: "none" };
@@ -5580,7 +5630,7 @@ window.__ModuleLoader__.load({
 				if (typeof document === "undefined") return;
 				const display = new SessionCostDisplay({
 					doc: document,
-					scope: () => markerRef.current?.closest(DOCK_ANCHOR)?.parentElement ?? null
+					scope: () => markerRef.current?.closest(DOCK_ANCHOR) ?? null
 				});
 				displayRef.current = display;
 				display.start();