@marmooo/midy 0.1.1 → 0.1.2

package/script/midy-GMLite.js

@@ -147,8 +147,8 @@ class MidyGMLite {
         });
         this.audioContext = audioContext;
         this.masterGain = new GainNode(audioContext);
-        this.masterGain.connect(audioContext.destination);
         this.channels = this.createChannels(audioContext);
+        this.masterGain.connect(audioContext.destination);
         this.GM1SystemOn();
     }
     initSoundFontTable() {
@@ -192,6 +192,7 @@ class MidyGMLite {
         const merger = new ChannelMergerNode(audioContext, { numberOfInputs: 2 });
         gainL.connect(merger, 0, 0);
         gainR.connect(merger, 0, 1);
+        merger.connect(this.masterGain);
         return {
             gainL,
             gainR,
@@ -494,10 +495,6 @@ class MidyGMLite {
         }
         return noteList[0];
     }
-    connectEffects(channel, gainNode) {
-        gainNode.connect(channel.merger);
-        merger.connect(this.masterGain);
-    }
     cbToRatio(cb) {
         return Math.pow(10, cb / 200);
     }
@@ -511,14 +508,10 @@ class MidyGMLite {
         return instrumentKey.playbackRate(noteNumber) *
             Math.pow(2, semitoneOffset / 12);
     }
-    setVolumeEnvelope(channel, note) {
-        const { instrumentKey, startTime, velocity } = note;
+    setVolumeEnvelope(note) {
+        const { instrumentKey, startTime } = note;
         note.gainNode = new GainNode(this.audioContext, { gain: 0 });
-        let volume = (velocity / 127) * channel.volume * channel.expression;
-        if (volume === 0)
-            volume = 1e-6; // exponentialRampToValueAtTime() requires a non-zero value
-        const attackVolume = this.cbToRatio(-instrumentKey.initialAttenuation) *
-            volume;
+        const attackVolume = this.cbToRatio(-instrumentKey.initialAttenuation);
         const sustainVolume = attackVolume * (1 - instrumentKey.volSustain);
         const volDelay = startTime + instrumentKey.volDelay;
         const volAttack = volDelay + instrumentKey.volAttack;
@@ -578,7 +571,7 @@ class MidyGMLite {
         const note = new Note(noteNumber, velocity, startTime, instrumentKey);
         note.bufferSource = await this.createNoteBufferNode(instrumentKey, isSF3);
         note.bufferSource.playbackRate.value = this.calcPlaybackRate(instrumentKey, noteNumber, semitoneOffset);
-        this.setVolumeEnvelope(channel, note);
+        this.setVolumeEnvelope(note);
         this.setFilterEnvelope(channel, note);
         if (channel.modulation > 0) {
             const delayModLFO = startTime + instrumentKey.delayModLFO;
@@ -601,7 +594,8 @@ class MidyGMLite {
         if (!instrumentKey)
             return;
         const note = await this.createNote(channel, instrumentKey, noteNumber, velocity, startTime, isSF3);
-        this.connectEffects(channel, note.gainNode);
+        note.gainNode.connect(channel.gainL);
+        note.gainNode.connect(channel.gainR);
         const scheduledNotes = channel.scheduledNotes;
         if (scheduledNotes.has(noteNumber)) {
             scheduledNotes.get(noteNumber).push(note);
@@ -704,13 +698,13 @@ class MidyGMLite {
         channel.program = program;
     }
     handlePitchBendMessage(channelNumber, lsb, msb) {
-        const pitchBend = msb * 128 + lsb;
+        const pitchBend = msb * 128 + lsb - 8192;
         this.setPitchBend(channelNumber, pitchBend);
     }
     setPitchBend(channelNumber, pitchBend) {
         const channel = this.channels[channelNumber];
         const prevPitchBend = channel.pitchBend;
-        channel.pitchBend = (pitchBend - 8192) / 8192;
+        channel.pitchBend = pitchBend / 8192;
         const detuneChange = (channel.pitchBend - prevPitchBend) *
             channel.pitchBendRange * 100;
         this.updateDetune(channel, detuneChange);
@@ -880,7 +874,7 @@ class MidyGMLite {
         channel.scheduledNotes.forEach((noteList) => {
             const activeNote = this.getActiveNote(noteList, now);
             if (activeNote) {
-                const notePromise = this.scheduleNoteRelease(channelNumber, noteNumber, velocity, now, stopPedal);
+                const notePromise = this.scheduleNoteRelease(channelNumber, activeNote.noteNumber, velocity, now, stopPedal);
                 promises.push(notePromise);
             }
         });

package/script/midy.d.ts

@@ -93,6 +93,19 @@ export class Midy {
     };
     masterGain: any;
     channels: any[];
+    reverbEffect: {
+        input: any;
+        output: any;
+    };
+    chorusEffect: {
+        input: any;
+        output: any;
+        sendGain: any;
+        lfo: any;
+        lfoGain: any;
+        delayNodes: any[];
+        feedbackGains: any[];
+    };
     initSoundFontTable(): any[];
     addSoundFont(soundFont: any): void;
     loadSoundFont(soundFontUrl: any): Promise<void>;
@@ -101,19 +114,6 @@ export class Midy {
         gainL: any;
         gainR: any;
         merger: any;
-        reverbEffect: {
-            input: any;
-            output: any;
-        };
-        chorusEffect: {
-            input: any;
-            output: any;
-            sendGain: any;
-            lfo: any;
-            lfoGain: any;
-            delayNodes: any[];
-            feedbackGains: any[];
-        };
     };
     createChannels(audioContext: any): any[];
     createNoteBuffer(instrumentKey: any, isSF3: any): Promise<any>;
@@ -147,7 +147,7 @@ export class Midy {
     createCombFilter(audioContext: any, input: any, delay: any, feedback: any): any;
     createAllpassFilter(audioContext: any, input: any, delay: any, feedback: any): any;
     generateDistributedArray(center: any, count: any, varianceRatio?: number, randomness?: number): any[];
-    createSchroederReverb(audioContext: any, combDelays: any, combFeedbacks: any, allpassDelays: any, allpassFeedbacks: any): {
+    createSchroederReverb(audioContext: any, combFeedbacks: any, combDelays: any, allpassFeedbacks: any, allpassDelays: any): {
         input: any;
         output: any;
     };
@@ -160,12 +160,11 @@ export class Midy {
         delayNodes: any[];
         feedbackGains: any[];
     };
-    connectEffects(channel: any, gainNode: any): void;
     cbToRatio(cb: any): number;
     centToHz(cent: any): number;
     calcSemitoneOffset(channel: any): any;
     calcPlaybackRate(instrumentKey: any, noteNumber: any, semitoneOffset: any): number;
-    setVolumeEnvelope(channel: any, note: any): void;
+    setVolumeEnvelope(note: any): void;
     setFilterEnvelope(channel: any, note: any): void;
     startModulation(channel: any, note: any, time: any): void;
     startVibrato(channel: any, note: any, time: any): void;

package/script/midy.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"midy.d.ts","sourceRoot":"","sources":["../src/midy.js"],"names":[],"mappings":"AAuBA;IAkCE;;;;;;;;;;;;;;;;;;;;MAoBE;IAEF;;;;;;;;;;;MAWE;IAEF;;;;;;;MAOE;IAgCF;;;;;OAOC;IAlHD,qBAAmB;IACnB,kBAAc;IACd,yBAAqB;IACrB,2BAAuB;IACvB;;;MAGE;IACF;;;;;;MAME;IACF,cAAa;IACb,cAAa;IACb,0BAAwB;IACxB,kBAAc;IACd,mBAAiB;IACjB,kBAAc;IACd,mBAAe;IACf,kBAAgB;IAChB,sBAA2C;IAC3C,mBAAkB;IAClB,mBAAkB;IAClB,kBAAiB;IACjB,oBAAmB;IACnB,mBAAkB;IAClB,gBAAc;IACd,mBAAiB;IACjB,oBAAkB;IA8ClB;;;;;MA4BE;IAGA,kBAAgC;IAChC;;;;;MAAqD;IACrD,gBAA4C;IAE5C,gBAAiD;IAInD,4BAMC;IAED,mCASC;IAED,gDAMC;IAED,sCASC;IAED;;;;;;;;;;;;;;;;;MAkBC;IAED,yCAiBC;IAED,+DAyBC;IAED,mEAWC;IAED,qDAOC;IAED,2EAyDC;IAED,mCAOC;IAED,0BA+CC;IAED,uDAEC;IAED,wDAEC;IAED;;;MAgGC;IAED,4BAsBC;IAED,uBAKC;IAED,aAGC;IAED,cAKC;IAED,wBAIC;IAED,0BAKC;IAED,wBAOC;IAED,sBAGC;IAED,uDASC;IAED,6CAQC;IAED,kFAuBC;IAED;;;;MAWC;IAED,gFAUC;IAED,mFAYC;IAED,sGAcC;IAID;;;MA+BC;IAED;;;;;;;;MA0CC;IAED,kDAcC;IAED,2BAEC;IAED,4BAEC;IAED,sCAKC;IAED,mFAGC;IAED,iDAiBC;IAED,iDAiCC;IAED,0DAmBC;IAED,uDAcC;IAED,wHAqCC;IAED,gDAQC;IAED,kGAgCC;IAED,0EAGC;IAED,sIAiDC;IAED,0FAGC;IAED,kEAeC;IAED,oEAYC;IAED,wFAqBC;IAED,sFAcC;IAED,4DAIC;IAED,+DAcC;IAED,qEAGC;IAED,uDAOC;IAED,mFAkEC;IAED,+CAEC;IAED,qCAcC;IAED,yDAIC;IAED,iEAEC;IAED,iDAIC;IAED;;;MAMC;IAED,2CAIC;IAED,yDAIC;IAED,+CAEC;IAED,mDAGC;IAED,sCAUC;IAED,sDAMC;IAGD,oDAEC;IAED,mEAOC;IAED,mEAOC;IAED,wDAWC;IAED,uDAGC;IAED,2DAGC;IAED,6DAGC;IAED,6DASC;IAED,kFAeC;IAED,2DAMC;IAED,gDAyBC;IAED,wCAEC;IAED,wCAEC;IAED,gDAEC;IAED,gDAEC;IAED,mDAGC;IAED,oDAUC;IAED,kDAKC;IAED,iEAOC;IAED,8CAKC;IAED,yDAMC;IAED,gDAKC;IAED,6DAMC;IAED,wDAKC;IAED,6EAKC;IAED,uCAoBC;IAED,8CAEC;IAED,uCAoBC;IAED,gBAEC;IAED,eAEC;IAED,eAEC;IAED,eAEC;IAED,4DAmBC;IAED,oBAQC;IAED,oBAQC;IAED,yDAiDC;IAED,yCAGC;IAED,mCAQC;IAED,6CAGC;IAED,2CAMC;IAED,+CAGC;IAED,+CAMC;IAED,mDAeC;IAED,4CAOC;IAED,+BAOC;IAED,qDAiBC;IAED,gCAMC;IAED,kCAEC;IA6BD,4CAEC;IAED,4CAaC;IAED,+BAiBC;IAED,wFAKC;IAED,mCAQC;IAED,qCAEC;IAED,oCAUC;IAED,sCAEC;IAED,oCAaC;IAED,sCAEC;IAED,wCAUC;IAED,0CAEC;IAED,wCAEC;IAED,6BASC;IAED,0DAUC;CACF;AAx2DD;IASE,gFAKC;IAbD,kBAAa;IACb,cAAS;IACT,gBAAW;IACX,YAAO;IACP,gBAAW;IACX,YAAO;IACP,gBAAW;IAGT,gBAA4B;IAC5B,cAAwB;IACxB,eAA0B;IAC1B,mBAAkC;CAErC"}
+{"version":3,"file":"midy.d.ts","sourceRoot":"","sources":["../src/midy.js"],"names":[],"mappings":"AAuBA;IAkCE;;;;;;;;;;;;;;;;;;;;MAoBE;IAEF;;;;;;;;;;;MAWE;IAEF;;;;;;;MAOE;IAgCF;;;;;OAWC;IAtHD,qBAAmB;IACnB,kBAAc;IACd,yBAAqB;IACrB,2BAAuB;IACvB;;;MAGE;IACF;;;;;;MAME;IACF,cAAa;IACb,cAAa;IACb,0BAAwB;IACxB,kBAAc;IACd,mBAAiB;IACjB,kBAAc;IACd,mBAAe;IACf,kBAAgB;IAChB,sBAA2C;IAC3C,mBAAkB;IAClB,mBAAkB;IAClB,kBAAiB;IACjB,oBAAmB;IACnB,mBAAkB;IAClB,gBAAc;IACd,mBAAiB;IACjB,oBAAkB;IA8ClB;;;;;MA4BE;IAGA,kBAAgC;IAChC;;;;;MAAqD;IACrD,gBAA4C;IAC5C,gBAAiD;IACjD;;;MAA8D;IAC9D;;;;;;;;MAAyD;IAO3D,4BAMC;IAED,mCASC;IAED,gDAMC;IAED,sCASC;IAED;;;;MAeC;IAED,yCAiBC;IAED,+DAyBC;IAED,mEAWC;IAED,qDAOC;IAED,2EAyDC;IAED,mCAOC;IAED,0BA+CC;IAED,uDAEC;IAED,wDAEC;IAED;;;MAgGC;IAED,4BAsBC;IAED,uBAKC;IAED,aAGC;IAED,cAKC;IAED,wBAIC;IAED,0BAKC;IAED,wBAOC;IAED,sBAGC;IAED,uDASC;IAED,6CAQC;IAED,kFAuBC;IAED;;;;MAWC;IAED,gFAUC;IAED,mFAYC;IAED,sGAcC;IAID;;;MA+BC;IAED;;;;;;;;MA0CC;IAED,2BAEC;IAED,4BAEC;IAED,sCAKC;IAED,mFAGC;IAED,mCAcC;IAED,iDAiCC;IAED,0DAmBC;IAED,uDAcC;IAED,wHAqCC;IAED,gDAQC;IAED,kGAgCC;IAED,0EAGC;IAED,sIAiDC;IAED,0FAGC;IAED,kEAeC;IAED,oEAYC;IAED,wFAqBC;IAED,sFAcC;IAED,4DAIC;IAED,+DAcC;IAED,qEAGC;IAED,uDAOC;IAED,mFAkEC;IAED,+CAEC;IAED,qCAcC;IAED,yDAIC;IAED,iEAEC;IAED,iDAIC;IAED;;;MAMC;IAED,2CAIC;IAED,yDAIC;IAED,+CAEC;IAED,mDAGC;IAED,sCAUC;IAED,sDAMC;IAGD,oDAEC;IAED,mEAWC;IAED,mEAWC;IAED,wDAWC;IAED,uDAGC;IAED,2DAGC;IAED,6DAGC;IAED,6DASC;IAED,kFAeC;IAED,2DAMC;IAED,gDAyBC;IAED,wCAEC;IAED,wCAEC;IAED,gDAEC;IAED,gDAEC;IAED,mDAGC;IAED,oDAUC;IAED,kDAKC;IAED,iEAOC;IAED,8CAKC;IAED,yDAMC;IAED,gDAKC;IAED,6DAMC;IAED,wDAKC;IAED,6EAKC;IAED,uCAoBC;IAED,8CAEC;IAED,uCAoBC;IAED,gBAEC;IAED,eAEC;IAED,eAEC;IAED,eAEC;IAED,4DAmBC;IAED,oBAQC;IAED,oBAQC;IAED,yDAiDC;IAED,yCAGC;IAED,mCAQC;IAED,6CAGC;IAED,2CAMC;IAED,+CAGC;IAED,+CAMC;IAED,mDAeC;IAED,4CAOC;IAED,+BAKC;IAED,qDAiBC;IAED,gCAMC;IAED,kCAEC;IA6BD,4CAEC;IAED,4CAaC;IAED,+BAiBC;IAED,wFAKC;IAED,mCAQC;IAED,qCAEC;IAED,oCAUC;IAED,sCAEC;IAED,oCAaC;IAED,sCAEC;IAED,wCAWC;IAED,0CAEC;IAED,wCAEC;IAED,6BASC;IAED,0DAUC;CACF;AA71DD;IASE,gFAKC;IAbD,kBAAa;IACb,cAAS;IACT,gBAAW;IACX,YAAO;IACP,gBAAW;IACX,YAAO;IACP,gBAAW;IAGT,gBAA4B;IAC5B,cAAwB;IACxB,eAA0B;IAC1B,mBAAkC;CAErC"}

package/script/midy.js

@@ -85,7 +85,7 @@ class Midy {
             writable: true,
             value: {
                 time: this.getReverbTime(64),
-                feedback: 0.25,
+                feedback: 0.8,
             }
         });
         Object.defineProperty(this, "chorus", {
@@ -227,8 +227,12 @@ class Midy {
         this.audioContext = audioContext;
         this.options = { ...this.defaultOptions, ...options };
         this.masterGain = new GainNode(audioContext);
-        this.masterGain.connect(audioContext.destination);
         this.channels = this.createChannels(audioContext);
+        this.reverbEffect = this.options.reverbAlgorithm(audioContext);
+        this.chorusEffect = this.createChorusEffect(audioContext);
+        this.chorusEffect.output.connect(this.masterGain);
+        this.reverbEffect.output.connect(this.masterGain);
+        this.masterGain.connect(audioContext.destination);
         this.GM2SystemOn();
     }
     initSoundFontTable() {
@@ -272,14 +276,11 @@ class Midy {
         const merger = new ChannelMergerNode(audioContext, { numberOfInputs: 2 });
         gainL.connect(merger, 0, 0);
         gainR.connect(merger, 0, 1);
-        const reverbEffect = this.options.reverbAlgorithm(audioContext);
-        const chorusEffect = this.createChorusEffect(audioContext);
+        merger.connect(this.masterGain);
         return {
             gainL,
             gainR,
             merger,
-            reverbEffect,
-            chorusEffect,
         };
     }
     createChannels(audioContext) {
@@ -695,7 +696,7 @@ class Midy {
     }
     // https://hajim.rochester.edu/ece/sites/zduan/teaching/ece472/reading/Schroeder_1962.pdf
     //   M.R.Schroeder, "Natural Sounding Artificial Reverberation", J.Audio Eng. Soc., vol.10, p.219, 1962
-    createSchroederReverb(audioContext, combDelays, combFeedbacks, allpassDelays, allpassFeedbacks) {
+    createSchroederReverb(audioContext, combFeedbacks, combDelays, allpassFeedbacks, allpassDelays) {
         const input = new GainNode(audioContext);
         const output = new GainNode(audioContext);
         const mergerGain = new GainNode(audioContext);
@@ -754,21 +755,6 @@ class Midy {
             feedbackGains,
         };
     }
-    connectEffects(channel, gainNode) {
-        gainNode.connect(channel.merger);
-        channel.merger.connect(this.masterGain);
-        if (0 < channel.reverbSendLevel) {
-            channel.merger.connect(channel.reverbEffect.input);
-            channel.reverbEffect.output.connect(this.masterGain);
-        }
-        if (0 < channel.chorusSendLevel) {
-            channel.merger.connect(channel.chorusEffect.input);
-            channel.reverbEffect.output.connect(this.masterGain);
-        }
-        if (0 < this.chorus.sendToReverb) {
-            channel.chorusEffect.sendGain.connect(channel.reverbEffect.input);
-        }
-    }
     cbToRatio(cb) {
         return Math.pow(10, cb / 200);
     }
@@ -785,14 +771,10 @@ class Midy {
         return instrumentKey.playbackRate(noteNumber) *
             Math.pow(2, semitoneOffset / 12);
     }
-    setVolumeEnvelope(channel, note) {
-        const { instrumentKey, startTime, velocity } = note;
+    setVolumeEnvelope(note) {
+        const { instrumentKey, startTime } = note;
         note.gainNode = new GainNode(this.audioContext, { gain: 0 });
-        let volume = (velocity / 127) * channel.volume * channel.expression;
-        if (volume === 0)
-            volume = 1e-6; // exponentialRampToValueAtTime() requires a non-zero value
-        const attackVolume = this.cbToRatio(-instrumentKey.initialAttenuation) *
-            volume;
+        const attackVolume = this.cbToRatio(-instrumentKey.initialAttenuation);
         const sustainVolume = attackVolume * (1 - instrumentKey.volSustain);
         const volDelay = startTime + instrumentKey.volDelay;
         const volAttack = volDelay + instrumentKey.volAttack;
@@ -865,7 +847,7 @@ class Midy {
         const note = new Note(noteNumber, velocity, startTime, instrumentKey);
         note.bufferSource = await this.createNoteBufferNode(instrumentKey, isSF3);
         note.bufferSource.playbackRate.value = this.calcPlaybackRate(instrumentKey, noteNumber, semitoneOffset);
-        this.setVolumeEnvelope(channel, note);
+        this.setVolumeEnvelope(note);
         this.setFilterEnvelope(channel, note);
         if (channel.modulation > 0) {
             const delayModLFO = startTime + instrumentKey.delayModLFO;
@@ -905,7 +887,8 @@ class Midy {
         if (!instrumentKey)
             return;
         const note = await this.createNote(channel, instrumentKey, noteNumber, velocity, startTime, isSF3);
-        this.connectEffects(channel, note.gainNode);
+        note.gainNode.connect(channel.gainL);
+        note.gainNode.connect(channel.gainR);
         if (channel.sostenutoPedal) {
             channel.sostenutoNotes.set(noteNumber, note);
         }
@@ -1065,13 +1048,13 @@ class Midy {
         }
     }
     handlePitchBendMessage(channelNumber, lsb, msb) {
-        const pitchBend = msb * 128 + lsb;
+        const pitchBend = msb * 128 + lsb - 8192;
         this.setPitchBend(channelNumber, pitchBend);
     }
     setPitchBend(channelNumber, pitchBend) {
         const channel = this.channels[channelNumber];
         const prevPitchBend = channel.pitchBend;
-        channel.pitchBend = (pitchBend - 8192) / 8192;
+        channel.pitchBend = pitchBend / 8192;
         const detuneChange = (channel.pitchBend - prevPitchBend) *
             channel.pitchBendRange * 100;
         this.updateDetune(channel, detuneChange);
@@ -1217,20 +1200,30 @@ class Midy {
         this.channels[channelNumber].portamento = value >= 64;
     }
     setReverbSendLevel(channelNumber, reverbSendLevel) {
-        const now = this.audioContext.currentTime;
         const channel = this.channels[channelNumber];
-        const reverbEffect = channel.reverbEffect;
-        channel.reverbSendLevel = reverbSendLevel / 127;
-        reverbEffect.output.gain.cancelScheduledValues(now);
-        reverbEffect.output.gain.setValueAtTime(channel.reverbSendLevel, now);
+        const reverbEffect = this.reverbEffect;
+        if (0 < reverbSendLevel) {
+            const now = this.audioContext.currentTime;
+            channel.reverbSendLevel = reverbSendLevel / 127;
+            reverbEffect.output.gain.cancelScheduledValues(now);
+            reverbEffect.output.gain.setValueAtTime(channel.reverbSendLevel, now);
+        }
+        else if (channel.reverbSendLevel !== 0) {
+            channel.merger.disconnect(reverbEffect.input);
+        }
     }
     setChorusSendLevel(channelNumber, chorusSendLevel) {
-        const now = this.audioContext.currentTime;
         const channel = this.channels[channelNumber];
-        const chorusEffect = channel.chorusEffect;
-        channel.chorusSendLevel = chorusSendLevel / 127;
-        chorusEffect.output.gain.cancelScheduledValues(now);
-        chorusEffect.output.gain.setValueAtTime(channel.chorusSendLevel, now);
+        const chorusEffect = this.chorusEffect;
+        if (0 < chorusSendLevel) {
+            const now = this.audioContext.currentTime;
+            channel.chorusSendLevel = chorusSendLevel / 127;
+            chorusEffect.output.gain.cancelScheduledValues(now);
+            chorusEffect.output.gain.setValueAtTime(channel.chorusSendLevel, now);
+        }
+        else if (channel.chorusSendLevel !== 0) {
+            channel.merger.disconnect(chorusEffect.input);
+        }
     }
     setSostenutoPedal(channelNumber, value) {
         const isOn = value >= 64;
@@ -1423,7 +1416,7 @@ class Midy {
         channel.scheduledNotes.forEach((noteList) => {
             const activeNote = this.getActiveNote(noteList, now);
             if (activeNote) {
-                const notePromise = this.scheduleNoteRelease(channelNumber, noteNumber, velocity, now, stopPedal);
+                const notePromise = this.scheduleNoteRelease(channelNumber, activeNote.noteNumber, velocity, now, stopPedal);
                 promises.push(notePromise);
             }
         });
@@ -1592,11 +1585,9 @@ class Midy {
     }
     setReverbType(type) {
         this.reverb.time = this.getReverbTimeFromType(type);
-        this.reverb.feedback = (type === 8) ? 0.1 : 0.2;
-        const { audioContext, channels, options } = this;
-        for (let i = 0; i < channels.length; i++) {
-            channels[i].reverbEffect = options.reverbAlgorithm(audioContext);
-        }
+        this.reverb.feedback = (type === 8) ? 0.9 : 0.8;
+        const { audioContext, options } = this;
+        this.reverbEffect = options.reverbAlgorithm(audioContext);
     }
     getReverbTimeFromType(type) {
         switch (type) {
@@ -1738,15 +1729,17 @@ class Midy {
         return value * 0.00763;
     }
     setChorusSendToReverb(value) {
-        const now = this.audioContext.currentTime;
         const sendToReverb = this.getChorusSendToReverb(value);
-        this.chorus.sendToReverb = sendToReverb;
-        for (let i = 0; i < this.channels.length; i++) {
-            const chorusEffect = this.channels[i].chorusEffect;
-            chorusEffect.sendGain.gain
+        if (0 < sendToReverb) {
+            const now = this.audioContext.currentTime;
+            this.chorus.sendToReverb = sendToReverb;
+            this.chorusEffect.sendGain.gain
                 .cancelScheduledValues(now)
                 .setValueAtTime(sendToReverb, now);
         }
+        else if (this.chorus.sendToReverb !== 0) {
+            this.chorusEffect.sendGain.disconnect(this.reverbEffect.input);
+        }
     }
     getChorusSendToReverb(value) {
         return value * 0.00787;