@marmooo/midy 0.1.0 → 0.1.1

package/script/midy.js

@@ -85,7 +85,7 @@ class Midy {
             writable: true,
             value: {
                 time: this.getReverbTime(64),
-                feedback: 0.2,
+                feedback: 0.25,
             }
         });
         Object.defineProperty(this, "chorus", {
@@ -93,10 +93,11 @@ class Midy {
             configurable: true,
             writable: true,
             value: {
-                modRate: 3 * 0.122,
-                modDepth: (3 + 1) / 3.2,
-                feedback: 8 * 0.763,
-                sendToReverb: 0 * 0.787,
+                modRate: this.getChorusModRate(3),
+                modDepth: this.getChorusModDepth(19),
+                feedback: this.getChorusFeedback(8),
+                sendToReverb: this.getChorusSendToReverb(0),
+                delayTimes: this.generateDistributedArray(0.02, 2, 0.5),
             }
         });
         Object.defineProperty(this, "mono", {
@@ -697,9 +698,7 @@ class Midy {
     createSchroederReverb(audioContext, combDelays, combFeedbacks, allpassDelays, allpassFeedbacks) {
         const input = new GainNode(audioContext);
         const output = new GainNode(audioContext);
-        const mergerGain = new GainNode(audioContext, {
-            gain: 1 / (combDelays.length * 2),
-        });
+        const mergerGain = new GainNode(audioContext);
         for (let i = 0; i < combDelays.length; i++) {
             const comb = this.createCombFilter(audioContext, input, combDelays[i], combFeedbacks[i]);
             comb.connect(mergerGain);
@@ -712,60 +711,62 @@ class Midy {
         allpasses.at(-1).connect(output);
         return { input, output };
     }
-    createChorusEffect(audioContext, options = {}) {
-        const { chorusCount = 2, chorusRate = 0.6, chorusDepth = 0.15, delay = 0.01, variance = delay * 0.1, } = options;
-        const lfo = new OscillatorNode(audioContext, { frequency: chorusRate });
-        const lfoGain = new GainNode(audioContext, { gain: chorusDepth });
+    createChorusEffect(audioContext) {
+        const input = new GainNode(audioContext);
         const output = new GainNode(audioContext);
-        const chorusGains = [];
+        const sendGain = new GainNode(audioContext);
+        const lfo = new OscillatorNode(audioContext, {
+            frequency: this.chorus.modRate,
+        });
+        const lfoGain = new GainNode(audioContext, {
+            gain: this.chorus.modDepth / 2,
+        });
+        const delayTimes = this.chorus.delayTimes;
         const delayNodes = [];
-        const baseGain = 1 / chorusCount;
-        for (let i = 0; i < chorusCount; i++) {
-            const randomDelayFactor = (Math.random() - 0.5) * variance;
-            const delayTime = (i + 1) * delay + randomDelayFactor;
+        const feedbackGains = [];
+        for (let i = 0; i < delayTimes.length; i++) {
+            const delayTime = delayTimes[i];
             const delayNode = new DelayNode(audioContext, {
-                maxDelayTime: delayTime,
+                maxDelayTime: 0.1, // generally, 5ms < delayTime < 50ms
+                delayTime,
+            });
+            const feedbackGain = new GainNode(audioContext, {
+                gain: this.chorus.feedback,
             });
-            const chorusGain = new GainNode(audioContext, { gain: baseGain });
             delayNodes.push(delayNode);
-            chorusGains.push(chorusGain);
+            feedbackGains.push(feedbackGain);
+            input.connect(delayNode);
             lfoGain.connect(delayNode.delayTime);
-            delayNode.connect(chorusGain);
-            chorusGain.connect(output);
+            delayNode.connect(feedbackGain);
+            feedbackGain.connect(delayNode);
+            delayNode.connect(output);
         }
+        output.connect(sendGain);
         lfo.connect(lfoGain);
         lfo.start();
         return {
+            input,
+            output,
+            sendGain,
             lfo,
             lfoGain,
             delayNodes,
-            chorusGains,
-            output,
+            feedbackGains,
         };
     }
     connectEffects(channel, gainNode) {
         gainNode.connect(channel.merger);
         channel.merger.connect(this.masterGain);
-        if (channel.reverbSendLevel === 0) {
-            if (channel.chorusSendLevel !== 0) { // chorus
-                channel.chorusEffect.delayNodes.forEach((delayNode) => {
-                    channel.merger.connect(delayNode);
-                });
-                channel.chorusEffect.output.connect(this.masterGain);
-            }
+        if (0 < channel.reverbSendLevel) {
+            channel.merger.connect(channel.reverbEffect.input);
+            channel.reverbEffect.output.connect(this.masterGain);
         }
-        else {
-            if (channel.chorusSendLevel === 0) { // reverb
-                channel.merger.connect(channel.reverbEffect.input);
-                channel.reverbEffect.output.connect(this.masterGain);
-            }
-            else { // reverb + chorus
-                channel.chorusEffect.delayNodes.forEach((delayNode) => {
-                    channel.merger.connect(delayNode);
-                });
-                channel.merger.connect(channel.reverbEffect.input);
-                channel.reverbEffect.output.connect(this.masterGain);
-            }
+        if (0 < channel.chorusSendLevel) {
+            channel.merger.connect(channel.chorusEffect.input);
+            channel.reverbEffect.output.connect(this.masterGain);
+        }
+        if (0 < this.chorus.sendToReverb) {
+            channel.chorusEffect.sendGain.connect(channel.reverbEffect.input);
         }
     }
     cbToRatio(cb) {
@@ -1224,9 +1225,12 @@ class Midy {
         reverbEffect.output.gain.setValueAtTime(channel.reverbSendLevel, now);
     }
     setChorusSendLevel(channelNumber, chorusSendLevel) {
+        const now = this.audioContext.currentTime;
         const channel = this.channels[channelNumber];
+        const chorusEffect = channel.chorusEffect;
         channel.chorusSendLevel = chorusSendLevel / 127;
-        channel.chorusEffect.lfoGain = channel.chorusSendLevel;
+        chorusEffect.output.gain.cancelScheduledValues(now);
+        chorusEffect.output.gain.setValueAtTime(channel.chorusSendLevel, now);
     }
     setSostenutoPedal(channelNumber, value) {
         const isOn = value >= 64;
@@ -1486,7 +1490,7 @@ class Midy {
                     case 4: // https://amei.or.jp/midistandardcommittee/Recommended_Practice/e/ca25.pdf
                         return this.handleMasterCoarseTuningSysEx(data);
                     case 5:
-                        return this.handleGlobalParameterControl(data);
+                        return this.handleGlobalParameterControlSysEx(data);
                     default:
                         console.warn(`Unsupported Exclusive Message: ${data}`);
                 }
@@ -1563,13 +1567,13 @@ class Midy {
             this.masterCoarseTuning = coarseTuning - 64;
         }
     }
-    handleGlobalParameterControl(data) {
-        if (data[5] === 1) {
-            switch (data[6]) {
+    handleGlobalParameterControlSysEx(data) {
+        if (data[7] === 1) {
+            switch (data[8]) {
                 case 1:
-                    return this.handleReverbParameter(data);
+                    return this.handleReverbParameterSysEx(data);
                 case 2:
-                    return this.handleChorusParameter(data);
+                    return this.handleChorusParameterSysEx(data);
                 default:
                     console.warn(`Unsupported Global Parameter Control Message: ${data}`);
             }
@@ -1578,12 +1582,12 @@ class Midy {
             console.warn(`Unsupported Global Parameter Control Message: ${data}`);
         }
     }
-    handleReverbParameter(data) {
-        switch (data[7]) {
+    handleReverbParameterSysEx(data) {
+        switch (data[9]) {
             case 0:
-                return this.setReverbType(data[8]);
+                return this.setReverbType(data[10]);
             case 1:
-                return this.setReverbTime(data[8]);
+                return this.setReverbTime(data[10]);
         }
     }
     setReverbType(type) {
@@ -1643,41 +1647,109 @@ class Midy {
     //   RT60 = -3 * delay / Math.log10(feedback)
     //   feedback = Math.pow(10, -3 * delay / RT60)
     // delay estimation using ideal feedback
-    //   A suitable average sound absorption coefficient is 0.18-0.28.
-    //   Since the structure of the hall is complex,
-    //   It would be easier to determine the delay based on the ideal feedback.
+    //   The structure of a concert hall is complex,
+    //   so estimates based on mean free path are unstable.
+    //   It is easier to determine the delay based on ideal feedback.
+    //   The average sound absorption coefficient
+    //   suitable for playing musical instruments is 0.18 to 0.28.
     //   delay = -RT60 * Math.log10(feedback) / 3
     calcDelay(rt60, feedback) {
         return -rt60 * Math.log10(feedback) / 3;
     }
-    handleChorusParameter(data) {
-        switch (data[7]) {
+    handleChorusParameterSysEx(data) {
+        switch (data[9]) {
             case 0:
-                return this.setChorusType(data[8]);
+                return this.setChorusType(data[10]);
             case 1:
-                return this.setChorusModRate(data[8]);
+                return this.setChorusModRate(data[10]);
             case 2:
-                return this.setChorusModDepth(data[8]);
+                return this.setChorusModDepth(data[10]);
             case 3:
-                return this.setChorusFeedback(data[8]);
+                return this.setChorusFeedback(data[10]);
             case 4:
-                return this.setChorusSendToReverb(data[8]);
+                return this.setChorusSendToReverb(data[10]);
         }
     }
     setChorusType(type) {
-        // TODO
+        switch (type) {
+            case 0:
+                return this.setChorusParameter(3, 5, 0, 0);
+            case 1:
+                return this.setChorusParameter(9, 19, 5, 0);
+            case 2:
+                return this.setChorusParameter(3, 19, 8, 0);
+            case 3:
+                return this.setChorusParameter(9, 16, 16, 0);
+            case 4:
+                return this.setChorusParameter(2, 24, 64, 0);
+            case 5:
+                return this.setChorusParameter(1, 5, 112, 0);
+            default:
+                console.warn(`Unsupported Chorus Type: ${type}`);
+        }
+    }
+    setChorusParameter(modRate, modDepth, feedback, sendToReverb) {
+        this.setChorusModRate(modRate);
+        this.setChorusModDepth(modDepth);
+        this.setChorusFeedback(feedback);
+        this.setChorusSendToReverb(sendToReverb);
     }
     setChorusModRate(value) {
-        // TODO
+        const now = this.audioContext.currentTime;
+        const modRate = this.getChorusModRate(value);
+        this.chorus.modRate = modRate;
+        for (let i = 0; i < this.channels.length; i++) {
+            const lfo = this.channels[i].chorusEffect.lfo;
+            lfo.frequency.setValueAtTime(modRate, now);
+        }
+    }
+    getChorusModRate(value) {
+        return value * 0.122; // Hz
     }
     setChorusModDepth(value) {
-        // TODO
+        const now = this.audioContext.currentTime;
+        const modDepth = this.getChorusModDepth(value);
+        this.chorus.modDepth = modDepth;
+        for (let i = 0; i < this.channels.length; i++) {
+            const chorusEffect = this.channels[i].chorusEffect;
+            chorusEffect.lfoGain.gain
+                .cancelScheduledValues(now)
+                .setValueAtTime(modDepth / 2, now);
+        }
+    }
+    getChorusModDepth(value) {
+        return (value + 1) / 3200; // second
     }
     setChorusFeedback(value) {
-        // TODO
+        const now = this.audioContext.currentTime;
+        const feedback = this.getChorusFeedback(value);
+        this.chorus.feedback = feedback;
+        for (let i = 0; i < this.channels.length; i++) {
+            const chorusEffect = this.channels[i].chorusEffect;
+            for (let j = 0; j < chorusEffect.feedbackGains.length; j++) {
+                const feedbackGain = chorusEffect.feedbackGains[j];
+                feedbackGain.gain
+                    .cancelScheduledValues(now)
+                    .setValueAtTime(feedback, now);
+            }
+        }
+    }
+    getChorusFeedback(value) {
+        return value * 0.00763;
     }
     setChorusSendToReverb(value) {
-        // TODO
+        const now = this.audioContext.currentTime;
+        const sendToReverb = this.getChorusSendToReverb(value);
+        this.chorus.sendToReverb = sendToReverb;
+        for (let i = 0; i < this.channels.length; i++) {
+            const chorusEffect = this.channels[i].chorusEffect;
+            chorusEffect.sendGain.gain
+                .cancelScheduledValues(now)
+                .setValueAtTime(sendToReverb, now);
+        }
+    }
+    getChorusSendToReverb(value) {
+        return value * 0.00787;
     }
     handleExclusiveMessage(data) {
         console.warn(`Unsupported Exclusive Message: ${data}`);