@markw65/monkeyc-optimizer 1.0.38 → 1.0.39

package/build/api.cjs

@@ -1,8 +1,8 @@
-0 && (module.exports = {collectNamespaces,findUsingForNode,formatAst,getApiFunctionInfo,getApiMapping,hasProperty,isLookupCandidate,isStateNode,markInvokeClassMethod,sameLookupResult,traverseAst,variableDeclarationName,visitReferences});
+0 && (module.exports = {collectNamespaces,findUsingForNode,formatAst,getApiFunctionInfo,getApiMapping,hasProperty,isLookupCandidate,isStateNode,markInvokeClassMethod,sameLookupResult,traverseAst,variableDeclarationName,visitReferences,visitorNode});
 /******/ (() => { // webpackBootstrap
 /******/ 	var __webpack_modules__ = ({
 
-/***/ 2789:
+/***/ 789:
 /***/ ((module) => {
 
 /**
@@ -270,7 +270,8 @@ __webpack_require__.d(__webpack_exports__, {
   "sameLookupResult": () => (/* binding */ api_sameLookupResult),
   "traverseAst": () => (/* reexport */ ast_traverseAst),
   "variableDeclarationName": () => (/* binding */ api_variableDeclarationName),
-  "visitReferences": () => (/* reexport */ visitor_visitReferences)
+  "visitReferences": () => (/* reexport */ visitor_visitReferences),
+  "visitorNode": () => (/* reexport */ visitorNode)
 });
 
 ;// CONCATENATED MODULE: external "@markw65/prettier-plugin-monkeyc"
@@ -1205,6 +1206,9 @@ function inliner_unused(expression, top) {
             if (expression.computed) {
                 return inliner_unused(expression.object).concat(inliner_unused(expression.property));
             }
+            if (expression.object.type === "NewExpression") {
+                break;
+            }
             return inliner_unused(expression.object);
         case "ArrayExpression":
             return expression.elements.map((e) => inliner_unused(e)).flat(1);
@@ -2126,7 +2130,7 @@ function getPreOrder(head) {
 }
 
 // EXTERNAL MODULE: ./node_modules/priorityqueuejs/index.js
-var priorityqueuejs = __webpack_require__(2789);
+var priorityqueuejs = __webpack_require__(789);
 ;// CONCATENATED MODULE: ./src/pre.ts
 
 
@@ -3119,6 +3123,13 @@ function unused_exprs_cleanupUnusedVars(state, node) {
                     if (hasProperty(toRemove, name)) {
                         const rep = vdecl.init ? unused(vdecl.init) : [];
                         if (rep.length) {
+                            if (rep.find((s) => s.type === "ExpressionStatement" &&
+                                (s.expression.type === "NewExpression" ||
+                                    (s.expression.type === "MemberExpression" &&
+                                        !s.expression.computed &&
+                                        s.expression.object.type === "NewExpression")))) {
+                                continue;
+                            }
                             if (parent.node.type === "ForStatement") {
                                 // declarations whose inits have side effects
                                 // can't be deleted from for statements.
@@ -3168,100 +3179,6 @@ function unused_exprs_cleanupUnusedVars(state, node) {
     }
 }
 
-;// CONCATENATED MODULE: ./src/visitor.ts
-
-function visitor_visitReferences(state, ast, name, defn, callback) {
-    const checkResults = ([name, results], node) => {
-        if (name && results) {
-            if (!defn || (0,external_api_cjs_namespaceObject.sameLookupResult)(results, defn)) {
-                if (callback(node, results, false) === false) {
-                    return [];
-                }
-            }
-        }
-        else if (defn === false) {
-            if (callback(node, [], results === null) === false) {
-                return [];
-            }
-        }
-        return null;
-    };
-    state.pre = (node) => {
-        switch (node.type) {
-            case "AttributeList":
-                return [];
-            case "UnaryExpression":
-                // a bare symbol isn't a reference
-                if (node.operator === ":")
-                    return [];
-                break;
-            case "BinaryExpression":
-                /*
-                 * `expr has :symbol` can be treated as a reference
-                 * to expr.symbol.
-                 */
-                if (node.operator === "has") {
-                    if (node.right.type === "UnaryExpression" &&
-                        node.right.operator === ":") {
-                        if (!name || node.right.argument.name === name) {
-                            return checkResults(state.lookup({
-                                type: "MemberExpression",
-                                object: node.left,
-                                property: node.right.argument,
-                                computed: false,
-                            }), node.right.argument);
-                        }
-                    }
-                }
-                break;
-            case "CallExpression":
-                // A call expression whose callee is an identifier is looked
-                // up as a non-local. ie even if there's a same named local,
-                // it will be ignored, and the lookup will start as if the
-                // call had been written self.foo() rather than foo().
-                if (node.callee.type === "Identifier") {
-                    if (!name || node.callee.name === name) {
-                        /* ignore return value */
-                        checkResults(state.lookupNonlocal(node.callee), node.callee);
-                    }
-                    return ["arguments"];
-                }
-                break;
-            case "Identifier":
-                if (!name || node.name === name) {
-                    return checkResults(state.lookup(node), node);
-                }
-                break;
-            case "MemberExpression": {
-                const property = (0,external_api_cjs_namespaceObject.isLookupCandidate)(node);
-                if (property) {
-                    if (!name || property.name === name) {
-                        return checkResults(state.lookup(node), node) || ["object"];
-                    }
-                    return ["object"];
-                }
-                break;
-            }
-            case "MethodDefinition": {
-                if (!state.inType) {
-                    throw new Error("Method definition outside of type!");
-                }
-                if (node.params) {
-                    node.params.forEach((param) => {
-                        if (param.type == "BinaryExpression") {
-                            state.traverse(param.right);
-                        }
-                    });
-                }
-                return ["returnType"];
-            }
-        }
-        return null;
-    };
-    (0,external_api_cjs_namespaceObject.collectNamespaces)(ast, state);
-    delete state.pre;
-}
-
 ;// CONCATENATED MODULE: ./src/mc-rewrite.ts
 
 
@@ -3274,7 +3191,6 @@ function visitor_visitReferences(state, ast, name, defn, callback) {
 
 
 
-
 function collectClassInfo(state) {
     const toybox = state.stack[0].decls["Toybox"][0];
     const lang = toybox.decls["Lang"][0];
@@ -3389,7 +3305,7 @@ function getFileASTs(fnMap) {
         return ok;
     }, true));
 }
-async function analyze(fnMap, barrelList, config) {
+async function analyze(fnMap, resourcesMap, config) {
     let hasTests = false;
     let markApi = true;
     const preState = {
@@ -3457,7 +3373,7 @@ async function analyze(fnMap, barrelList, config) {
             return null;
         },
     };
-    await getApiMapping(preState, barrelList);
+    await getApiMapping(preState, resourcesMap);
     markApi = false;
     const state = preState;
     await getFileASTs(fnMap);
@@ -3473,16 +3389,25 @@ async function analyze(fnMap, barrelList, config) {
     delete state.shouldExclude;
     delete state.pre;
     collectClassInfo(state);
+    state.exposed = state.nextExposed;
+    state.nextExposed = {};
+    return state;
+}
+function reportMissingSymbols(state, config) {
     const diagnosticType = config?.checkInvalidSymbols !== "OFF"
         ? config?.checkInvalidSymbols || "WARNING"
         : null;
     if (diagnosticType &&
         !config?.compilerOptions?.includes("--Eno-invalid-symbol")) {
         const checkTypes = config?.typeCheckLevel && config.typeCheckLevel !== "Off";
-        Object.entries(fnMap).forEach(([, v]) => {
+        Object.entries(state.fnMap).forEach(([, v]) => {
             visitReferences(state, v.ast, null, false, (node, results, error) => {
                 if (!error)
                     return undefined;
+                if (node.type === "BinaryExpression" && node.operator === "has") {
+                    // Its not an error to check whether a property exists...
+                    return undefined;
+                }
                 const nodeStr = formatAst(node);
                 if (state.inType) {
                     if (!checkTypes || nodeStr.match(/^Void|Null$/)) {
@@ -3494,9 +3419,6 @@ async function analyze(fnMap, barrelList, config) {
             });
         });
     }
-    state.exposed = state.nextExposed;
-    state.nextExposed = {};
-    return state;
 }
 function compareLiteralLike(a, b) {
     while (a.type === "BinaryExpression")
@@ -3790,8 +3712,8 @@ function markFunctionCalled(state, func) {
     }
     pushUnique(state.calledFunctions[func.id.name], func);
 }
-async function optimizeMonkeyC(fnMap, barrelList, config) {
-    const state = (await analyze(fnMap, barrelList, config));
+async function optimizeMonkeyC(fnMap, resourcesMap, config) {
+    const state = (await analyze(fnMap, resourcesMap, config));
     state.localsStack = [{}];
     state.calledFunctions = {};
     state.usedByName = {};
@@ -4191,6 +4113,37 @@ async function optimizeMonkeyC(fnMap, barrelList, config) {
                     return replace(optimizeCall(state, node.argument, node), node.argument);
                 }
                 break;
+            case "BinaryExpression":
+                if (node.operator === "has" &&
+                    node.right.type === "UnaryExpression" &&
+                    node.right.operator === ":") {
+                    const [, results] = state.lookup(node.left);
+                    if (results &&
+                        results.length === 1 &&
+                        results[0].results.length === 1) {
+                        const obj = results[0].results[0];
+                        if ((obj.type === "ModuleDeclaration" ||
+                            obj.type === "Program" ||
+                            obj.type === "ClassDeclaration") &&
+                            obj.decls &&
+                            obj.stack) {
+                            const exists = hasProperty(obj.decls, node.right.argument.name) ||
+                                // This is overkill, since we've already looked up
+                                // node.left, but the actual lookup rules are complicated,
+                                // and embedded within state.lookup; so just defer to that.
+                                state.lookup({
+                                    type: "MemberExpression",
+                                    object: node.left,
+                                    property: node.right.argument,
+                                    computed: false,
+                                })[1];
+                            if (!exists) {
+                                return replace({ type: "Literal", value: false, raw: "false" }, node);
+                            }
+                        }
+                    }
+                }
+                break;
             case "NewExpression":
                 if (state.currentFunction) {
                     const [, results] = state.lookup(node.callee);
@@ -4418,7 +4371,7 @@ async function optimizeMonkeyC(fnMap, barrelList, config) {
         }
         return null;
     };
-    Object.entries(fnMap).forEach(([name, f]) => {
+    Object.entries(fnMap).forEach(([, f]) => {
         traverseAst(f.ast, undefined, (node) => {
             const ret = cleanup(node);
             if (ret === false) {
@@ -4426,6 +4379,9 @@ async function optimizeMonkeyC(fnMap, barrelList, config) {
             }
             return ret;
         });
+    });
+    reportMissingSymbols(state, config);
+    Object.entries(fnMap).forEach(([name, f]) => {
         if (state.config && state.config.checkBuildPragmas) {
             pragmaChecker(state, f.ast, state.diagnostics?.[name]);
         }
@@ -4541,6 +4497,316 @@ const negativeFixups = [
 
 ;// CONCATENATED MODULE: external "./sdk-util.cjs"
 const external_sdk_util_cjs_namespaceObject = require("./sdk-util.cjs");
+;// CONCATENATED MODULE: ./src/resources.ts
+
+
+/*
+ * This is unavoidably ad-hoc. Garmin has arbitrary rules for how
+ * resources can be nested, which we need to mimic here.
+ */
+function visit_resources(elements, parent, visitor, error) {
+    elements.forEach((e) => {
+        switch (e.name) {
+            // <resources> can contain any of the resource lists (except
+            // another resources), and any of their contents
+            case "resources":
+                if (parent) {
+                    error(e, parent);
+                    return;
+                }
+                visit_resources(external_sdk_util_cjs_namespaceObject.xmlUtil.elementKids(e), "resources", visitor, error);
+                return;
+            // Each of these is a list that can contain certain kinds of resource.
+            // They can only occur at the top level, or under a <resources> list.
+            case "strings":
+            case "fonts":
+            case "animations":
+            case "bitmaps":
+            case "layouts":
+            case "menus":
+            case "drawables":
+            case "properties":
+            case "settings":
+            case "fitContributions":
+            case "jsonDataResources":
+            case "complications":
+                if (parent && parent !== "resources") {
+                    error(e, parent);
+                    return;
+                }
+                visit_resources(external_sdk_util_cjs_namespaceObject.xmlUtil.elementKids(e), e.name, visitor, error);
+                return;
+            // These are the resources themselves. Some can occur at top level; most
+            // are restricted to <resources> or one or more of the specific lists above
+            case "string":
+                if (parent !== "strings" && parent !== "resources") {
+                    error(e, parent);
+                    return;
+                }
+                visitor(e, "Strings");
+                return;
+            case "font":
+                if (parent !== "fonts" && parent !== "resources") {
+                    error(e, parent);
+                    return;
+                }
+                visitor(e, "Fonts");
+                return;
+            case "animation":
+                if (parent !== "animations" && parent !== "resources") {
+                    error(e, parent);
+                    return;
+                }
+                visitor(e, "Drawables");
+                return;
+            case "menu":
+            case "menu2":
+            case "checkbox-menu":
+            case "action-menu":
+                if (parent && parent !== "menus" && parent !== "resources") {
+                    error(e, parent);
+                    return;
+                }
+                visitor(e, "Menus");
+                return;
+            case "bitmap":
+                if (parent !== "bitmaps" &&
+                    parent !== "drawables" &&
+                    parent !== "resources") {
+                    error(e, parent);
+                    return;
+                }
+                visitor(e, "Drawables");
+                return;
+            case "layout":
+                if (parent && parent !== "layouts" && parent !== "resources") {
+                    error(e, parent);
+                    return;
+                }
+                visitor(e, "Layouts");
+                return;
+            case "drawable-list":
+                if (parent && parent !== "drawables" && parent !== "resources") {
+                    error(e, parent);
+                    return;
+                }
+                visitor(e, "Drawables");
+                return;
+            case "property":
+                if (parent !== "properties" && parent !== "resources") {
+                    error(e, parent);
+                    return;
+                }
+                visitor(e, "Properties");
+                return;
+            case "setting":
+                if (parent !== "settings" && parent !== "resources") {
+                    error(e, parent);
+                    return;
+                }
+                visitor(e, null);
+                return;
+            case "group":
+                if (parent !== "settings" /* && parent !== "resources" */) {
+                    error(e, parent);
+                    return;
+                }
+                visitor(e, null);
+                return;
+            case "fitField":
+                if (parent !== "fitContributions" && parent !== "resources") {
+                    error(e, parent);
+                    return;
+                }
+                visitor(e, null);
+                return;
+            case "jsonData":
+                if (parent && parent != "jsonDataResources" && parent !== "resources") {
+                    error(e, parent);
+                    return;
+                }
+                visitor(e, "JsonData");
+                return;
+            case "build":
+                if (parent && parent !== "resources") {
+                    error(e, parent);
+                    return;
+                }
+                visitor(e, null);
+                return;
+        }
+    });
+}
+function add_resources_to_ast(ast, resources) {
+    Object.entries(resources).forEach(([barrel, resourceMap]) => {
+        const rezModules = {
+            Drawables: [],
+            Fonts: [],
+            JsonData: [],
+            Layouts: [],
+            Menus: [],
+            Properties: [],
+            Strings: [],
+        };
+        Object.values(resourceMap).forEach((rez) => {
+            if (!rez || !(rez instanceof external_sdk_util_cjs_namespaceObject.xmlUtil.Document))
+                return;
+            visit_resources(rez.body.elements, null, (e, s) => {
+                if (!s)
+                    return;
+                if (!ast_hasProperty(rezModules, s))
+                    return;
+                rezModules[s].push(e);
+            }, (_e, _s) => {
+                return;
+            });
+        });
+        const outerLoc = ast.loc && { ...ast.loc };
+        const makeModule = (m) => ({
+            type: "ModuleDeclaration",
+            id: { type: "Identifier", name: m },
+            body: { type: "BlockStatement", body: [] },
+            loc: outerLoc,
+        });
+        let body = ast.body;
+        if (barrel !== "") {
+            const module = makeModule(barrel);
+            body.push(module);
+            body = module.body.body;
+        }
+        const rez = makeModule("Rez");
+        body.push(rez);
+        body = rez.body.body;
+        Object.entries(rezModules).forEach(([m, elements]) => {
+            const module = makeModule(m);
+            body.push(module);
+            elements.forEach((e) => e.attr.id &&
+                module.body.body.push({
+                    type: "VariableDeclaration",
+                    declarations: [
+                        {
+                            type: "VariableDeclarator",
+                            kind: "var",
+                            id: { type: "Identifier", name: e.attr.id, loc: e.loc },
+                            loc: e.loc,
+                        },
+                    ],
+                    kind: "var",
+                    loc: e.loc,
+                }));
+        });
+    });
+}
+
+;// CONCATENATED MODULE: ./src/visitor.ts
+
+function visitorNode(node) {
+    if (node.type === "Identifier") {
+        return node;
+    }
+    if (node.type === "MemberExpression") {
+        return node.property;
+    }
+    if (node.type === "BinaryExpression" &&
+        node.operator === "has" &&
+        node.right.type === "UnaryExpression" &&
+        node.right.operator === ":") {
+        return node.right.argument;
+    }
+    return node;
+}
+function visitor_visitReferences(state, ast, name, defn, callback) {
+    const checkResults = ([name, results], node) => {
+        if (name && results) {
+            if (!defn || (0,external_api_cjs_namespaceObject.sameLookupResult)(results, defn)) {
+                if (callback(node, results, false) === false) {
+                    return [];
+                }
+            }
+        }
+        else if (defn === false) {
+            if (callback(node, [], results === null) === false) {
+                return [];
+            }
+        }
+        return null;
+    };
+    state.pre = (node) => {
+        switch (node.type) {
+            case "AttributeList":
+                return [];
+            case "UnaryExpression":
+                // a bare symbol isn't a reference
+                if (node.operator === ":")
+                    return [];
+                break;
+            case "BinaryExpression":
+                /*
+                 * `expr has :symbol` can be treated as a reference
+                 * to expr.symbol.
+                 */
+                if (node.operator === "has") {
+                    if (node.right.type === "UnaryExpression" &&
+                        node.right.operator === ":") {
+                        if (!name || node.right.argument.name === name) {
+                            return checkResults(state.lookup({
+                                type: "MemberExpression",
+                                object: node.left,
+                                property: node.right.argument,
+                                computed: false,
+                            }), node);
+                        }
+                    }
+                }
+                break;
+            case "CallExpression":
+                // A call expression whose callee is an identifier is looked
+                // up as a non-local. ie even if there's a same named local,
+                // it will be ignored, and the lookup will start as if the
+                // call had been written self.foo() rather than foo().
+                if (node.callee.type === "Identifier") {
+                    if (!name || node.callee.name === name) {
+                        /* ignore return value */
+                        checkResults(state.lookupNonlocal(node.callee), node.callee);
+                    }
+                    return ["arguments"];
+                }
+                break;
+            case "Identifier":
+                if (!name || node.name === name) {
+                    return checkResults(state.lookup(node), node);
+                }
+                break;
+            case "MemberExpression": {
+                const property = (0,external_api_cjs_namespaceObject.isLookupCandidate)(node);
+                if (property) {
+                    if (!name || property.name === name) {
+                        return checkResults(state.lookup(node), node) || ["object"];
+                    }
+                    return ["object"];
+                }
+                break;
+            }
+            case "MethodDefinition": {
+                if (!state.inType) {
+                    throw new Error("Method definition outside of type!");
+                }
+                if (node.params) {
+                    node.params.forEach((param) => {
+                        if (param.type == "BinaryExpression") {
+                            state.traverse(param.right);
+                        }
+                    });
+                }
+                return ["returnType"];
+            }
+        }
+        return null;
+    };
+    (0,external_api_cjs_namespaceObject.collectNamespaces)(ast, state);
+    delete state.pre;
+}
+
 ;// CONCATENATED MODULE: ./src/api.ts
 
 
@@ -4553,6 +4819,7 @@ const external_sdk_util_cjs_namespaceObject = require("./sdk-util.cjs");
 
 
 
+
 /*
  * This is an unfortunate hack. I want to be able to extract things
  * like the types of all of a Class's variables (in particular the type
@@ -4563,34 +4830,24 @@ const external_sdk_util_cjs_namespaceObject = require("./sdk-util.cjs");
  * but those are at least in a standard format.
  */
 // Extract all enum values from api.mir
-async function api_getApiMapping(state, barrelList) {
+async function api_getApiMapping(state, resourcesMap) {
     // get the path to the currently active sdk
     const parser = (prettier_plugin_monkeyc_default()).parsers.monkeyc;
     const sdk = await (0,external_sdk_util_cjs_namespaceObject.getSdkPath)();
-    const rezDecl = `module Rez { ${[
-        "Drawables",
-        "Fonts",
-        "JsonData",
-        "Layouts",
-        "Menus",
-        "Strings",
-    ]
-        .map((s) => `  module ${s} {}\n`)
-        .join("")}}`;
     const api = (await promises_namespaceObject.readFile(`${sdk}bin/api.mir`))
         .toString()
         .replace(/\r\n/g, "\n")
         .replace(/^\s*\[.*?\]\s*$/gm, "")
         //.replace(/(COLOR_TRANSPARENT|LAYOUT_[HV]ALIGN_\w+) = (\d+)/gm, "$1 = -$2")
-        .replace(/^(\s*type)\s/gm, "$1def ") +
-        (barrelList || [])
-            .map((name) => `module ${name} { ${rezDecl} }`)
-            .concat(rezDecl)
-            .join("");
+        .replace(/^(\s*type)\s/gm, "$1def ");
     try {
-        const result = api_collectNamespaces(parser.parse(api, null, {
+        const ast = parser.parse(api, null, {
             filepath: "api.mir",
-        }), state);
+        });
+        if (resourcesMap) {
+            add_resources_to_ast(ast, resourcesMap);
+        }
+        const result = api_collectNamespaces(ast, state);
         negativeFixups.forEach((fixup) => {
             const vs = fixup.split(".").reduce((state, part) => {
                 const decls = api_isStateNode(state) && state.decls?.[part];
@@ -4760,14 +5017,11 @@ function lookup(state, decls, node, name, maybeStack, nonlocal) {
                     return current ? current.concat(items) : items;
                 }, null);
                 if (!result &&
-                    results.some((ld) => ld.results.some((sn) => (api_isStateNode(sn) && sn.fullName?.match(/^\$\.(\w+\.)?Rez\./)) ||
-                        sn.type === "VariableDeclarator" ||
+                    results.some((ld) => ld.results.some((sn) => sn.type === "VariableDeclarator" ||
                         sn.type === "Identifier" ||
                         sn.type === "BinaryExpression" ||
                         (sn.type === "ClassDeclaration" &&
                             property.name === "initialize")))) {
-                    // - The Rez module can contain lots of things from the resource
-                    //   compiler which we don't track.
                     // - Variables, and formal parameters would require type tracking
                     //   which we don't yet do
                     // - Its ok to call an undeclared initialize method.
@@ -4781,7 +5035,7 @@ function lookup(state, decls, node, name, maybeStack, nonlocal) {
         }
         case "ThisExpression": {
             for (let i = stack.length;;) {
-                const si = stack[i];
+                const si = stack[--i];
                 if (si.type == "ModuleDeclaration" ||
                     si.type == "ClassDeclaration" ||
                     !i) {